Re: [PROPOSAL] Remove SVN keywords from JavaDoc

2009-07-22 Thread sebb
On 07/07/2009, Mark Thomas ma...@apache.org wrote: Konstantin Kolinko wrote: As was written early in this my thread: http://www.nabble.com/Coding-Guidelines%2C-encodings%2C-keywords-td23662661.html (http://markmail.org/thread/d6dsgrsfvnuzclt7) there are problems with Subversion

Re: svn commit: r794798 - in /tomcat/trunk/java/org/apache/catalina/filters: Constants.java FilterBase.java LocalStrings.properties LocalStrings_es.properties LocalStrings_fr.properties RemoteAddrFi

2009-07-22 Thread sebb
On 16/07/2009, ma...@apache.org ma...@apache.org wrote: Author: markt Date: Thu Jul 16 19:34:49 2009 New Revision: 794798 URL: http://svn.apache.org/viewvc?rev=794798view=rev Log: More GSOC work from Xie Xiadong Initial implementation of RemoteHost and RemoteAddr filters. Added:

Re: JDBC-POOL release candidate

2009-07-22 Thread sebb
On 14/07/2009, Filip Hanik - Dev Lists devli...@hanik.com wrote: think it should be all in order now http://people.apache.org/~fhanik/jdbc-pool/v1.0.6/ There are some differences between the source archives and the SVN tag: In SVN, but not in source archive:

Re: svn commit: r796739 - /tomcat/trunk/java/org/apache/catalina/connector/AsyncContextImpl.java

2009-07-22 Thread sebb
On 22/07/2009, ma...@apache.org ma...@apache.org wrote: Author: markt Date: Wed Jul 22 14:29:09 2009 New Revision: 796739 URL: http://svn.apache.org/viewvc?rev=796739view=rev Log: Restore the @Overrides. Eclipse on my Mac wasn't configured right. Sorry for the noise. The

Re: JDBC-POOL release candidate

2009-07-21 Thread sebb
On 14/07/2009, Filip Hanik - Dev Lists devli...@hanik.com wrote: think it should be all in order now http://people.apache.org/~fhanik/jdbc-pool/v1.0.6/ Eclipse and Findbugs show the following warnings for the non-test code: Description ResourcePathTypeLocation Class is a

Re: svn commit: r790693 - /tomcat/trunk/modules/jdbc-pool/build.xml

2009-07-02 Thread sebb
On 02/07/2009, fha...@apache.org fha...@apache.org wrote: Author: fhanik Date: Thu Jul 2 17:35:26 2009 New Revision: 790693 URL: http://svn.apache.org/viewvc?rev=790693view=rev Log: break out javadoc into its own target Modified: tomcat/trunk/modules/jdbc-pool/build.xml

Re: svn commit: r790684 - /tomcat/trunk/modules/jdbc-pool/java/org/apache/tomcat/jdbc/pool/ConnectionPool.java

2009-07-02 Thread sebb
On 02/07/2009, fha...@apache.org fha...@apache.org wrote: Author: fhanik Date: Thu Jul 2 17:08:50 2009 New Revision: 790684 URL: http://svn.apache.org/viewvc?rev=790684view=rev Log: Add some doco, make shared variables volatile Modified:

Re: svn commit: r790155 - in /tomcat/container/tc5.5.x: catalina/src/share/org/apache/catalina/session/ catalina/src/share/org/apache/catalina/valves/ webapps/docs/ webapps/docs/config/

2009-07-01 Thread sebb
On 01/07/2009, ma...@apache.org ma...@apache.org wrote: Author: markt Date: Wed Jul 1 13:19:15 2009 New Revision: 790155 URL: http://svn.apache.org/viewvc?rev=790155view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=43343 Port of r656751, r778523, r778524, r784453

Re: svn commit: r789392 - in /tomcat/trunk/modules/jdbc-pool: ./ test/org/apache/tomcat/jdbc/test/

2009-06-30 Thread sebb
On 29/06/2009, sebb seb...@gmail.com wrote: On 29/06/2009, fha...@apache.org fha...@apache.org wrote: Author: fhanik Date: Mon Jun 29 17:38:21 2009 New Revision: 789392 URL: http://svn.apache.org/viewvc?rev=789392view=rev Log: Remove all usage of GPL or LGPL downloads

Re: svn commit: r789714 - in /tomcat: container/tc5.5.x/modules/cluster/src/share/org/apache/catalina/cluster/tcp/FastAsyncSocketSender.java container/tc5.5.x/webapps/docs/changelog.xml current/tc5.5

2009-06-30 Thread sebb
On 30/06/2009, rj...@apache.org rj...@apache.org wrote: Author: rjung Date: Tue Jun 30 13:26:10 2009 New Revision: 789714 URL: http://svn.apache.org/viewvc?rev=789714view=rev Log: Separate statistics counter lock in FastAsyncSocketSender from inherited DataSender lock to reduce

Re: svn commit: r789883 - in /tomcat/trunk/modules/jdbc-pool: build.properties.default build.xml

2009-06-30 Thread sebb
On 30/06/2009, fha...@apache.org fha...@apache.org wrote: Author: fhanik Date: Tue Jun 30 19:15:28 2009 New Revision: 789883 URL: http://svn.apache.org/viewvc?rev=789883view=rev Log: Apply patch by sebb from https://issues.apache.org/bugzilla/show_bug.cgi?id=47458 Store db

Re: svn commit: r789392 - in /tomcat/trunk/modules/jdbc-pool: ./ test/org/apache/tomcat/jdbc/test/

2009-06-29 Thread sebb
On 29/06/2009, fha...@apache.org fha...@apache.org wrote: Author: fhanik Date: Mon Jun 29 17:38:21 2009 New Revision: 789392 URL: http://svn.apache.org/viewvc?rev=789392view=rev Log: Remove all usage of GPL or LGPL downloads. +1, thanks. Use H2 for test database (EPL1.0) as it can

Re: svn commit: r788214 - /tomcat/current/tc5.5.x/STATUS.txt

2009-06-27 Thread sebb
On 27/06/2009, Xie Xiaodong xxd82...@gmail.com wrote: But how could ThreadLocal be shared among all AccessLogValve instances on the same server? After all, each thread access ThreadLocal has its own. Another point, based on the java doc of ThreadLocal, maybe private

Re: [VOTE] Release JDBC Pool module v1.0.5

2009-06-26 Thread sebb
On 26/06/2009, Filip Hanik - Dev Lists devli...@hanik.com wrote: sebb wrote: On 24/06/2009, Filip Hanik - Dev Lists devli...@hanik.com wrote: Cleaned up and fixed. The release is located here: http://people.apache.org/~fhanik/jdbc-pool/v1.0.5/ Exactly the same path

Re: [VOTE] Release JDBC Pool module v1.0.5

2009-06-26 Thread sebb
On 26/06/2009, Filip Hanik - Dev Lists devli...@hanik.com wrote: sebb wrote: On 26/06/2009, Filip Hanik - Dev Lists devli...@hanik.com wrote: sebb wrote: On 24/06/2009, Filip Hanik - Dev Lists devli...@hanik.com wrote: Cleaned up and fixed

Re: [VOTE] Release JDBC Pool module v1.0.5

2009-06-26 Thread sebb
When testing with Derby on Java 1.6.0 I get the following error: [junit] Running org.apache.tomcat.jdbc.test.StarvationTest [junit] Testsuite: org.apache.tomcat.jdbc.test.StarvationTest [junit] AbandonedObjectPool is used (org.apache.tomcat.dbcp.dbcp.abandonedobjectp...@1d6096)

Re: [VOTE] Release JDBC Pool module v1.0.5

2009-06-25 Thread sebb
On 24/06/2009, Filip Hanik - Dev Lists devli...@hanik.com wrote: Cleaned up and fixed. The release is located here: http://people.apache.org/~fhanik/jdbc-pool/v1.0.5/ Exactly the same path names were used previously; I assume you are referring to the following versions of the files:

Re: svn commit: r787211 - /tomcat/trunk/test/org/apache/catalina/startup/TestTomcat.java

2009-06-22 Thread sebb
On 22/06/2009, ma...@apache.org ma...@apache.org wrote: Author: markt Date: Mon Jun 22 11:58:07 2009 New Revision: 787211 URL: http://svn.apache.org/viewvc?rev=787211view=rev Log: Fix a couple of Eclipse warnings Modified:

Re: Please review JDBC Pool before vote

2009-06-22 Thread sebb
On 22/06/2009, Filip Hanik - Dev Lists devli...@hanik.com wrote: in the spirit of trying to get my poop right, http://people.apache.org/~fhanik/jdbc-pool/v1.0.5/ Looks a lot better. the binary releases contain everything in individual jar files (including source references for IDEs)

Duplicate code in AccessLogValve

2009-06-19 Thread sebb
Just spotted this duplicate code in AccessLogValve: 661:if (!dateStamp.equals(tsDate)) { 662:if (!dateStamp.equals(tsDate)) { Not sure this double-checked looking offers any benefit ;-)

Re: Duplicate code in AccessLogValve

2009-06-19 Thread sebb
On 19/06/2009, sebb seb...@gmail.com wrote: Just spotted this duplicate code in AccessLogValve: 661:if (!dateStamp.equals(tsDate)) { 662:if (!dateStamp.equals(tsDate)) { Not sure this double-checked looking offers any benefit ;-) Line

Re: Duplicate code in AccessLogValve

2009-06-19 Thread sebb
create a new Date unecessarily. 2009/6/19 sebb seb...@gmail.com On 19/06/2009, sebb seb...@gmail.com wrote: Just spotted this duplicate code in AccessLogValve: 661:if (!dateStamp.equals(tsDate)) { 662

Re: svn commit: r786532 - /tomcat/trunk/modules/jdbc-pool/NOTICE

2009-06-19 Thread sebb
On 19/06/2009, fha...@apache.org fha...@apache.org wrote: Author: fhanik Date: Fri Jun 19 15:05:04 2009 New Revision: 786532 URL: http://svn.apache.org/viewvc?rev=786532view=rev Log: Correct per sebb/markt Sorry, but this is still incorrect. The NOTICE is now: This product includes

Re: svn commit: r786569 - /tomcat/trunk/modules/jdbc-pool/NOTICE

2009-06-19 Thread sebb
On 19/06/2009, fha...@apache.org fha...@apache.org wrote: Author: fhanik Date: Fri Jun 19 16:16:16 2009 New Revision: 786569 URL: http://svn.apache.org/viewvc?rev=786569view=rev Log: correction Modified: tomcat/trunk/modules/jdbc-pool/NOTICE Modified:

Re: [VOTE] Release build 4.1.40 - Take 2

2009-06-19 Thread sebb
On 16/06/2009, Mark Thomas ma...@apache.org wrote: The (updated) candidates source tarball and derived binaries are available here: http://tomcat.apache.org/dev/dist/apache-tomcat-4.1.40/ According to the release process, the release based on the 4.0.40 tag is: Did you mean 4.1.40? Also,

Re: [VOTE] Release build 4.1.40 - Take 2

2009-06-19 Thread sebb
On 19/06/2009, Mark Thomas ma...@apache.org wrote: sebb wrote: On 16/06/2009, Mark Thomas ma...@apache.org wrote: The (updated) candidates source tarball and derived binaries are available here: http://tomcat.apache.org/dev/dist/apache-tomcat-4.1.40/ According to the release

Re: svn commit: r786631 - /tomcat/trunk/test/org/apache/catalina/valves/Benchmarks.java

2009-06-19 Thread sebb
On 19/06/2009, kkoli...@apache.org kkoli...@apache.org wrote: Author: kkolinko Date: Fri Jun 19 18:57:59 2009 New Revision: 786631 URL: http://svn.apache.org/viewvc?rev=786631view=rev Log: Add two more implementations for the second test. a) using a single ThreadLocal instead of

Re: svn commit: r786653 - /tomcat/trunk/java/org/apache/catalina/valves/AccessLogValve.java

2009-06-19 Thread sebb
On 19/06/2009, ma...@apache.org ma...@apache.org wrote: Author: markt Date: Fri Jun 19 20:21:53 2009 New Revision: 786653 URL: http://svn.apache.org/viewvc?rev=786653view=rev Log: Switch to ThreadLocal where possible. This removes all the syncs apart from those related to accessing

Re: svn commit: r785952 - in /tomcat/trunk/test/org/apache/catalina/valves: ./ Benchmarks.java

2009-06-18 Thread sebb
On 18/06/2009, Mark Thomas ma...@apache.org wrote: Tim Funk wrote: I think this needs to be volatile ? In (GetDateBenchmarkTest) +private long currentMillis = 0; Same for (in TimeDateElementBenchmarkTest) +private Date currentDate = null; Of course - since

Re: svn commit: r785952 - in /tomcat/trunk/test/org/apache/catalina/valves: ./ Benchmarks.java

2009-06-18 Thread sebb
On 18/06/2009, sebb seb...@gmail.com wrote: On 18/06/2009, Mark Thomas ma...@apache.org wrote: Tim Funk wrote: I think this needs to be volatile ? In (GetDateBenchmarkTest) +private long currentMillis = 0; Same for (in TimeDateElementBenchmarkTest

Re: [VOTE] Release JDBC Pool module v1.0.4

2009-06-18 Thread sebb
On 19/06/2009, Filip Hanik - Dev Lists devli...@hanik.com wrote: So now that we've clarified that NOTICE and LICENSE covers the entire release as an entity, No idea what you mean by that, but anyway: As I have written several times before, the NOTICE file is incorrect. This applies to the

Re: [VOTE] Release JDBC Pool module v1.0.4

2009-06-17 Thread sebb
On 17/06/2009, Filip Hanik - Dev Lists devli...@hanik.com wrote: sebb wrote: On 16/06/2009, Filip Hanik - Dev Lists devli...@hanik.com wrote: Sebb, I can't find anything that is broken. All your concerns seem invalid to me. Please revisit, especially the NOTICE files

Re: [VOTE] Release build 4.1.40

2009-06-16 Thread sebb
The copyright year in the NOTICE files in the binary archive is still 2008; surely it should be 2009? The connectors/NOTICE file in the source archive is wrong. There are no NOTICE files for the jasper and servletapi directory sub-trees. It would be better to have a single NL file at the top of

Re: svn commit: r785164 - /tomcat/container/branches/tc4.1.x/build.xml

2009-06-16 Thread sebb
On 16/06/2009, ma...@apache.org ma...@apache.org wrote: Author: markt Date: Tue Jun 16 11:17:26 2009 New Revision: 785164 URL: http://svn.apache.org/viewvc?rev=785164view=rev Log: Update exclusion list for EOL filtering Modified: tomcat/container/branches/tc4.1.x/build.xml

Re: svn commit: r785164 - /tomcat/container/branches/tc4.1.x/build.xml

2009-06-16 Thread sebb
On 16/06/2009, Mark Thomas ma...@apache.org wrote: sebb wrote: On 16/06/2009, ma...@apache.org ma...@apache.org wrote: Author: markt Date: Tue Jun 16 11:17:26 2009 New Revision: 785164 URL: http://svn.apache.org/viewvc?rev=785164view=rev Log: Update exclusion list

Re: [VOTE] [CANCELLED] Release build 4.1.40

2009-06-16 Thread sebb
[ ] Beta [ ] Stable There were enough issues to re-roll the release. For the record, I tried and failed on several machines to recreate the problem sebb saw so I can only assume it was a local JVM issue. I've just realised that it might be due to trying to install without Admin privileges

Re: [VOTE] [CANCELLED] Release build 4.1.40

2009-06-16 Thread sebb
On 16/06/2009, Mark Thomas ma...@apache.org wrote: sebb wrote: On 16/06/2009, Mark Thomas ma...@apache.org wrote: Mark Thomas wrote: The candidates source tarball and derived binaries are available here: http://tomcat.apache.org/dev/dist/apache-tomcat-4.1.40/ According

Re: [VOTE] Release JDBC Pool module v1.0.4

2009-06-16 Thread sebb
On 16/06/2009, Filip Hanik - Dev Lists devli...@hanik.com wrote: Sebb, I can't find anything that is broken. All your concerns seem invalid to me. Please revisit, especially the NOTICE files. Filip sebb wrote: On 15/06/2009, Filip Hanik - Dev Lists devli...@hanik.com wrote

Re: [VOTE] Release JDBC Pool module v1.0.3

2009-06-15 Thread sebb
On 15/06/2009, Filip Hanik - Dev Lists devli...@hanik.com wrote: Sebb, thanks for the feedback. sebb wrote: Apart from the problems with NL files etc that have already been mentioned, I found the following: == The changelog.html file refers to Tomcat JDBC Connection Pool *v1.0.5

Re: svn commit: r784083 - in /tomcat/trunk: java/org/apache/catalina/ java/org/apache/catalina/core/ java/org/apache/naming/resources/ webapps/docs/config/

2009-06-12 Thread sebb
On 12/06/2009, ma...@apache.org ma...@apache.org wrote: Author: markt Date: Fri Jun 12 11:38:29 2009 New Revision: 784083 URL: http://svn.apache.org/viewvc?rev=784083view=rev Log: Implement alias resources. Key features: - configured at the context level in the same way as the other

Re: [VOTE] Release JDBC Pool module v1.0.3

2009-06-11 Thread sebb
Apart from the problems with NL files etc that have already been mentioned, I found the following: == The changelog.html file refers to Tomcat JDBC Connection Pool *v1.0.5-beta* which looks wrong. == The documentation for the Interceptors appears to be incorrect. For example: The code

Re: [VOTE] Release build 6.0.20

2009-06-02 Thread sebb
On 02/06/2009, Filip Hanik - Dev Lists devli...@hanik.com wrote: Martin Dubuc wrote: What is going to happen to the 6.0.20 load? Will it be officially released? that is based on the voting results, which passed, so yes, it will be released. I've not seen the [VOTE][RESULT] e-mail ?

Re: [VOTE] Release build 6.0.20

2009-05-25 Thread sebb
On 25/05/2009, Konstantin Kolinko knst.koli...@gmail.com wrote: 2009/5/24 sebb seb...@gmail.com: On 24/05/2009, Konstantin Kolinko knst.koli...@gmail.com wrote: 2009/5/14 Remy Maucherat r...@apache.org: The candidates binaries are available here: http://people.apache.org/~remm

Re: [VOTE] Release build 6.0.20

2009-05-24 Thread sebb
On 24/05/2009, Konstantin Kolinko knst.koli...@gmail.com wrote: 2009/5/14 Remy Maucherat r...@apache.org: The candidates binaries are available here: http://people.apache.org/~remm/tomcat-6/v6.0.20/ According to the release process, the 6.0.20 tag is: [ ] Broken [ ] Alpha [ ]

Re: Mutable public fields in Tomcat 6 code

2009-05-22 Thread sebb
On 21/05/2009, Filip Hanik - Dev Lists devli...@hanik.com wrote: sebb wrote: There are quite a lot of public mutable static fields in the current Tomcat6 codebase. Such fields can allow malicious or accidental changes to occur, so should be avoided as far as possible. [And if a class

Re: svn commit: r777247 - /tomcat/tc6.0.x/trunk/java/org/apache/catalina/tribes/group/interceptors/SimpleCoordinator.java

2009-05-21 Thread sebb
Here are a few more missing properties: svn ps svn:eol-style native java/javax/el/LocalStrings_es.properties svn ps svn:eol-style native java/javax/servlet/LocalStrings_es.properties svn ps svn:eol-style native java/org/apache/catalina/ha/LocalStrings_es.properties svn ps svn:eol-style native

Mutable public fields in Tomcat 6 code

2009-05-21 Thread sebb
There are quite a lot of public mutable static fields in the current Tomcat6 codebase. Such fields can allow malicious or accidental changes to occur, so should be avoided as far as possible. [And if a class has public mutable static fields it's generally impossible to make it thread-safe.] The

Re: svn commit: r777247 - /tomcat/tc6.0.x/trunk/java/org/apache/catalina/tribes/group/interceptors/SimpleCoordinator.java

2009-05-21 Thread sebb
/tomcat/lite/LiteTestHelper.java svn ps svn:eol-style native modules/tomcat-lite/test/org/apache/tomcat/test/watchdog/WatchdogHttpClient.java On 21/05/2009, Rainer Jung rainer.j...@kippdata.de wrote: On 21.05.2009 23:29, sebb wrote: Here are a few more missing properties: svn ps svn:eol

Re: svn commit: r777247 - /tomcat/tc6.0.x/trunk/java/org/apache/catalina/tribes/group/interceptors/SimpleCoordinator.java

2009-05-21 Thread sebb
On 22/05/2009, Rainer Jung rainer.j...@kippdata.de wrote: On 22.05.2009 01:07, Filip Hanik - Dev Lists wrote: rj...@apache.org wrote: Guys fix your svn configuration. ;) This happens to me all the time, as I move between machines very often. Why is the ~/.subversion/config a

Re: Coding Guidelines, encodings, keywords

2009-05-21 Thread sebb
On 22/05/2009, Konstantin Kolinko kkoli...@apache.org wrote: Hi, all! Are there any Coding Guidelines that we ought to follow, or is our project on our own there? I am interested in clarifying the following question: What is the character encoding for our sources. Our build scripts

Re: [VOTE] Release build 6.0.20

2009-05-20 Thread sebb
extras/catalina-ws.jar does not have a NOTICE or a LICENSE file. All jars should ideally have NL files, but they must be present if the jar is published separately, as appears to be the case here. The EXE fails to install the following file: RELEASE-NOTES It also fails to install RUNNING.txt

Misleading name of Tomcat commiters list in svn-authorization

2009-05-14 Thread sebb
There are two Tomcat lists in svn-authorization: tomcat-pmc tomcat-watchdog The tomcat-pmc list appears to be the standard list for giving access to the normal Tomcat SVN development directories, and does not seem to have anything to do with the Tomcat PMC. I think all the other lists with -pmc

Re: jdbc pool - prepping for a first release

2009-05-01 Thread sebb
compile.source=1.5 yet there are several references to features which require Java 1.6+ On 01/05/2009, Filip Hanik - Dev Lists devli...@hanik.com wrote: I was thinking to create a release, (I know I dropped the ball on the last one), to gather feedback on the code itself. There have been

Re: DO NOT REPLY [Bug 47049] New: TOMCAT MANAGER appears in Spanish, tildes/accents are not resolved.

2009-04-20 Thread sebb
On 20/04/2009, Mark Thomas ma...@apache.org wrote: Mark Thomas wrote: Looks like we need to run native2ascii over a quite a few French and German files. Surely the ISO-8859-1 (Latin-1) character set supports most accents in Latin languages, so there should be no need to use Unicode escapes

Re: DO NOT REPLY [Bug 47049] New: TOMCAT MANAGER appears in Spanish, tildes/accents are not resolved.

2009-04-20 Thread sebb
On 20/04/2009, Mark Thomas ma...@apache.org wrote: sebb wrote: On 20/04/2009, Mark Thomas ma...@apache.org wrote: Mark Thomas wrote: Looks like we need to run native2ascii over a quite a few French and German files. Surely the ISO-8859-1 (Latin-1) character set supports most

Re: Problems building 5.5.27 from source

2009-04-17 Thread sebb
On 17/04/2009, Kirk True k...@mustardgrain.com wrote: Hi all, I had some problems building 5.5.27 as pulled from http://tomcat.apache.org/download-55.cgi. The first issue was that I couldn't use a JDK 1.4.2-level compiler as it chokes on the class format of the JUnit libraries. AFAIK it

Re: svn commit: r763298 - in /tomcat/trunk/java/org/apache/catalina: core/StandardContext.java core/StandardHost.java tribes/membership/Membership.java util/InstanceSupport.java util/LifecycleSuppor

2009-04-14 Thread sebb
On 12/04/2009, Filip Hanik - Dev Lists devli...@hanik.com wrote: sebb wrote: On 10/04/2009, Mark Thomas ma...@apache.org wrote: Filip Hanik - Dev Lists wrote: I'm generally against this find bugs 'may be bugs' issues. is there an actual bug here

Re: svn commit: r764985 - in /tomcat/trunk/java/org/apache/catalina/core: Constants.java StandardWrapper.java

2009-04-14 Thread sebb
On 14/04/2009, ma...@apache.org ma...@apache.org wrote: Author: markt Date: Tue Apr 14 22:16:53 2009 New Revision: 764985 URL: http://svn.apache.org/viewvc?rev=764985view=rev Log: Fix secondary issue reported as part of bug47013 Which says: req.setQueryString(Constants.PRECOMPILE +

Re: svn commit: r763726 - in /tomcat/trunk/java/org/apache/catalina/ha/backend: HeartbeatListener.java MultiCastSender.java Proxy.java Sender.java TcpSender.java

2009-04-11 Thread sebb
On 09/04/2009, jfcl...@apache.org jfcl...@apache.org wrote: Author: jfclere Date: Thu Apr 9 16:32:04 2009 New Revision: 763726 URL: http://svn.apache.org/viewvc?rev=763726view=rev Log: Add the Tcp code... Still need the code in httpd-trunk to test it. Added:

Re: svn commit: r763298 - in /tomcat/trunk/java/org/apache/catalina: core/StandardContext.java core/StandardHost.java tribes/membership/Membership.java util/InstanceSupport.java util/LifecycleSuppor

2009-04-11 Thread sebb
On 10/04/2009, Mark Thomas ma...@apache.org wrote: Filip Hanik - Dev Lists wrote: I'm generally against this find bugs 'may be bugs' issues. is there an actual bug here? Reported bug, no. Bugs uses could hit, yes. Hence why this is in trunk and not being proposed for backport. Are

Re: svn commit: r763635 - in /tomcat/trunk/java/org/apache/catalina/ha/backend: HeartbeatListener.java MultiCastSender.java Sender.java

2009-04-11 Thread sebb
On 09/04/2009, jfcl...@apache.org jfcl...@apache.org wrote: Author: jfclere Date: Thu Apr 9 13:00:21 2009 New Revision: 763635 URL: http://svn.apache.org/viewvc?rev=763635view=rev Log: Move the multi logic to MultiCastSender with the idea to TCP sockets and a list of proxy too.

Re: [VOTE] Release build 6.0.19

2009-04-07 Thread sebb
On 07/04/2009, Remy Maucherat r...@apache.org wrote: The candidates binaries are available here: http://people.apache.org/~remm/tomcat-6/v6.0.19/ Hashes and sigs look OK, though I only checked the main archives. There's a packaging problem with the source archives. I would expect the .zip

Re: svn commit: r759694 - /tomcat/sandbox/tomcat-oacc/trunk/src/share/org/apache/catalina/cluster/tcp/FastAsyncSocketSender.java

2009-03-29 Thread sebb
On 29/03/2009, Rainer Jung rainer.j...@kippdata.de wrote: On 29.03.2009 19:02, sebb wrote: On 29/03/2009, rj...@apache.orgrj...@apache.org wrote: Author: rjung Date: Sun Mar 29 14:17:16 2009 New Revision: 759694 URL: http://svn.apache.org/viewvc?rev=759694view=rev Log

Re: svn commit: r757381 - /tomcat/trunk/modules/jdbc-pool/java/org/apache/tomcat/jdbc/pool/DataSourceProxy.java

2009-03-24 Thread sebb
On 23/03/2009, Filip Hanik - Dev Lists devli...@hanik.com wrote: sebb wrote: Since it's a new variable, define new Has pool been released yet? one can make it private now without breaking anything. Every little helps. On 23/03/2009, Filip Hanik - Dev Lists devli...@hanik.com

Re: svn commit: r757381 - /tomcat/trunk/modules/jdbc-pool/java/org/apache/tomcat/jdbc/pool/DataSourceProxy.java

2009-03-23 Thread sebb
On 23/03/2009, fha...@apache.org fha...@apache.org wrote: Author: fhanik Date: Mon Mar 23 12:07:36 2009 New Revision: 757381 URL: http://svn.apache.org/viewvc?rev=757381view=rev Log: expose the poolname through a public method, this will allow one to retrieve the actual connection

Re: svn commit: r757381 - /tomcat/trunk/modules/jdbc-pool/java/org/apache/tomcat/jdbc/pool/DataSourceProxy.java

2009-03-23 Thread sebb
/ch0002425/quotes sebb wrote: On 23/03/2009, fha...@apache.org fha...@apache.org wrote: Author: fhanik Date: Mon Mar 23 12:07:36 2009 New Revision: 757381 URL: http://svn.apache.org/viewvc?rev=757381view=rev Log: expose the poolname through a public method

Re: svn commit: r753147 - /tomcat/connectors/trunk/jk/native/common/jk_lb_worker.c

2009-03-13 Thread sebb
On 13/03/2009, mt...@apache.org mt...@apache.org wrote: Author: mturk Date: Fri Mar 13 07:25:50 2009 New Revision: 753147 URL: http://svn.apache.org/viewvc?rev=753147view=rev Log: Use inplace rewrite of dot part. We are safe to do that cause sessionid is allocated for every request

Re: svn commit: r753147 - /tomcat/connectors/trunk/jk/native/common/jk_lb_worker.c

2009-03-13 Thread sebb
On 13/03/2009, sebb seb...@gmail.com wrote: On 13/03/2009, mt...@apache.org mt...@apache.org wrote: Author: mturk Date: Fri Mar 13 07:25:50 2009 New Revision: 753147 URL: http://svn.apache.org/viewvc?rev=753147view=rev Log: Use inplace rewrite of dot part. We are safe

Re: svn commit: r752584 [1/2] - in /tomcat/trunk: LICENSE NOTICE java/javax/servlet/resources/javaee_5.xsd java/javax/servlet/resources/javaee_web_services_1_2.xsd java/javax/servlet/resources/javae

2009-03-11 Thread sebb
On 11/03/2009, ma...@apache.org ma...@apache.org wrote: Author: markt Date: Wed Mar 11 19:12:03 2009 New Revision: 752584 URL: http://svn.apache.org/viewvc?rev=752584view=rev Log: Add missing XML Schemas for Java EE Deployment Descriptors Unlike the existing schemas, these files are

Re: svn commit: r752629 - /tomcat/connectors/trunk/jk/jkstatus/src/share/org/apache/jk/status/JkStatusTask.java

2009-03-11 Thread sebb
On 11/03/2009, rj...@apache.org rj...@apache.org wrote: Author: rjung Date: Wed Mar 11 21:33:54 2009 New Revision: 752629 URL: http://svn.apache.org/viewvc?rev=752629view=rev Log: Formally fix JavaDoc. The JavaDocs are more like dummies though. Modified:

Re: Apache Tomcat Connectors snapshot 1.2.28-dev-752124 available for testing.

2009-03-11 Thread sebb
On 11/03/2009, Rainer Jung rainer.j...@kippdata.de wrote: Hi Sebb, On 10.03.2009 21:33, sebb wrote: On 10/03/2009, Rainer Jungrainer.j...@kippdata.de wrote: Hi all, version 1.2.28 of mod_jk is approaching its release. A code snapshot (revision 752124) is available

Re: Apache Tomcat Connectors snapshot 1.2.28-dev-752124 available for testing.

2009-03-10 Thread sebb
On 10/03/2009, Rainer Jung rainer.j...@kippdata.de wrote: Hi all, version 1.2.28 of mod_jk is approaching its release. A code snapshot (revision 752124) is available at: http://tomcat.apache.org/dev/dist/tomcat-connectors/jk/source/jk-1.2.28-dev/ The NOTICE file is non-standard, as it

Re: svn commit: r749019 - in /tomcat/tc6.0.x/trunk: ./ java/org/apache/catalina/ java/org/apache/catalina/connector/ java/org/apache/catalina/session/ java/org/apache/tomcat/util/http/ webapps/docs

2009-03-01 Thread sebb
On 01/03/2009, ma...@apache.org ma...@apache.org wrote: Author: markt Date: Sun Mar 1 12:47:54 2009 New Revision: 749019 URL: http://svn.apache.org/viewvc?rev=749019view=rev Log: Provide an option to use httpOnly for session cookies. Disabled by default. ...

Re: tomcat-users.xml Unix file permissions and security (possible patch)

2009-02-13 Thread sebb
On 13/02/2009, Rainer Jung rainer.j...@kippdata.de wrote: Hi, On 12.02.2009 18:06, Petr Sumbera wrote: Hi all, From Tomcat tar archive I get: ls -l apache-tomcat-6.0.18/conf/tomcat-users.xml -rw--- 1 tomcat staff 1107 Jul 21 2008

Re: svn commit: r734706 - in /tomcat/trunk/java/org/apache: coyote/ActionCode.java tomcat/util/buf/MessageBytes.java tomcat/util/net/AprEndpoint.java

2009-01-15 Thread sebb
On 15/01/2009, ma...@apache.org ma...@apache.org wrote: Author: markt Date: Thu Jan 15 05:49:53 2009 New Revision: 734706 URL: http://svn.apache.org/viewvc?rev=734706view=rev Log: Remove unused imports idnetified by Eclipse Modified:

Java (and other) source files without AL headers

2008-12-30 Thread sebb
Tomcat trunk has quite a few Java files without the correct AL headers: java/org/apache/tomcat/util/net/jsse/NioX509KeyManager.java modules/bayeux/java/org/apache/tomcat/bayeux/HttpError.java modules/bayeux/test/org/apache/cometd/bayeux/samples/BayeuxStockTicker.java

SVN properties for tomcat trunk

2008-12-30 Thread sebb
AFAICT, the following SVN property settings are missing from tomcat-trunk: svn ps svn:eol-style native TOMCAT-7-RELEASE-PLAN.txt svn ps svn:eol-style native java/org/apache/catalina/tribes/group/interceptors/SimpleCoordinator.java svn ps svn:eol-style native

Re: svn commit: r723961 - in /tomcat/trunk/modules/jdbc-pool/test/org/apache/tomcat/jdbc/test: CreateTestTable.java TestSlowQueryReport.java

2008-12-06 Thread sebb
On 06/12/2008, Filip Hanik - Dev Lists [EMAIL PROTECTED] wrote: there has to be a way to automate this, since I'm a frequent offender, is there some SVN script we could do? http://www.apache.org/dev/version-control.html#https-svn-config http://www.apache.org/dev/svn-eol-style.txt If you are

Re: [VOTE] Release build 4.1.39

2008-11-19 Thread sebb
On 19/11/2008, Mark Thomas [EMAIL PROTECTED] wrote: The source tarball and other packages are available here: http://tomcat.apache.org/dev/dist/apache-tomcat-4.1.39/ According to the release process, the 4.1.39 tag is: [X] Broken The sigs and hashes don't agree with their targets, except

Re: [VOTE] Release build 4.1.39

2008-11-19 Thread sebb
On 19/11/2008, sebb [EMAIL PROTECTED] wrote: On 19/11/2008, Mark Thomas [EMAIL PROTECTED] wrote: The source tarball and other packages are available here: http://tomcat.apache.org/dev/dist/apache-tomcat-4.1.39/ According to the release process, the 4.1.39 tag is: [X] Broken

Re: [VOTE] Release build 4.1.39

2008-11-19 Thread sebb
On 19/11/2008, Mark Thomas [EMAIL PROTECTED] wrote: sebb wrote: On 19/11/2008, Mark Thomas [EMAIL PROTECTED] wrote: The source tarball and other packages are available here: http://tomcat.apache.org/dev/dist/apache-tomcat-4.1.39/ According to the release process, the 4.1.39 tag

Re: [VOTE] Release build 4.1.39

2008-11-19 Thread sebb
On 19/11/2008, sebb [EMAIL PROTECTED] wrote: On 19/11/2008, Mark Thomas [EMAIL PROTECTED] wrote: sebb wrote: On 19/11/2008, Mark Thomas [EMAIL PROTECTED] wrote: The source tarball and other packages are available here: http://tomcat.apache.org/dev/dist/apache-tomcat-4.1.39

Re: [VOTE] Release build 4.1.39

2008-11-19 Thread sebb
On 19/11/2008, Mark Thomas [EMAIL PROTECTED] wrote: sebb wrote: Sorry, just discovered the problem. The key id is not 33C60243 (as reported by GPGV); it is 0x33C60243. I'll know next time... Yep - that'll be the problem. When you search for key IDs you always have to use

Re: [VOTE] Release build 4.1.39

2008-11-19 Thread sebb
On 19/11/2008, Mark Thomas [EMAIL PROTECTED] wrote: sebb wrote: On 19/11/2008, Mark Thomas [EMAIL PROTECTED] wrote: I had network troubles during the upload and I had to retry several times. I thought it completed without error but it looks like apache-tomcat-4.1.39-LE-jdk14.exe got

Re: [VOTE] Release build 4.1.39

2008-11-19 Thread sebb
On 19/11/2008, sebb [EMAIL PROTECTED] wrote: On 19/11/2008, Mark Thomas [EMAIL PROTECTED] wrote: The source tarball and other packages are available here: http://tomcat.apache.org/dev/dist/apache-tomcat-4.1.39/ I just ran RAT on the source archive. There are a lot of source files

Re: [VOTE] Release build 4.1.39

2008-11-19 Thread sebb
On 19/11/2008, Mark Thomas [EMAIL PROTECTED] wrote: sebb wrote: On 19/11/2008, sebb [EMAIL PROTECTED] wrote: On 19/11/2008, Mark Thomas [EMAIL PROTECTED] wrote: The source tarball and other packages are available here: http://tomcat.apache.org/dev/dist/apache-tomcat-4.1.39

Re: [VOTE] Release build 4.1.39

2008-11-19 Thread sebb
On 19/11/2008, Mark Thomas [EMAIL PROTECTED] wrote: sebb wrote: However, there are several binary files that are different: connectors/jni/native/os/win32/logmessages.bin connectors/procrun/bin.../tomcat*.exe This suggests a packaging error - perhaps these bin files were

Re: [VOTE] Release build 4.1.39

2008-11-19 Thread sebb
On 19/11/2008, Mark Thomas [EMAIL PROTECTED] wrote: sebb wrote: On 19/11/2008, Mark Thomas [EMAIL PROTECTED] wrote: sebb wrote: On 19/11/2008, sebb [EMAIL PROTECTED] wrote: On 19/11/2008, Mark Thomas [EMAIL PROTECTED] wrote: The source tarball and other packages

Re: [VOTE] Release build 4.1.39

2008-11-19 Thread sebb
On 19/11/2008, Mark Thomas [EMAIL PROTECTED] wrote: sebb wrote: On 19/11/2008, Mark Thomas [EMAIL PROTECTED] wrote: sebb wrote: On 19/11/2008, Mark Thomas [EMAIL PROTECTED] wrote: sebb wrote: On 19/11/2008, sebb [EMAIL PROTECTED] wrote: On 19/11/2008, Mark Thomas

Re: [RESULT] [VOTE] Releasing Apache Tomcat Native 1.1.16

2008-11-18 Thread sebb
I happened to spot the following in ssl.c: static int jbs_gets(BIO *b, char *out, int outl) ... int l = (int)strlen(J2S(o)); if (l outl) { strcpy(out, J2S(o)); ret = outl; } ... return ret; It looks a bit odd to me - I would have expected it to return l rather than outl. However, I've

Re: [RESULT] [VOTE] Releasing Apache Tomcat Native 1.1.16

2008-11-18 Thread sebb
On 18/11/2008, Mladen Turk [EMAIL PROTECTED] wrote: sebb wrote: I happened to spot the following in ssl.c: static int jbs_gets(BIO *b, char *out, int outl) ... int l = (int)strlen(J2S(o)); if (l outl) { strcpy(out, J2S(o)); ret = outl; } ... return ret; It looks

Tomcat pool and Findbugs

2008-11-17 Thread sebb
This is a follow-on from Bugzilla 46209 - https://issues.apache.org/bugzilla/show_bug.cgi?id=46209. Findbugs reported several instances of protected static fields that were not final. For example, ConnectionPool: protected static Log log = LogFactory.getLog(ConnectionPool.class); Firstly,

Re: svn commit: r714246 - /tomcat/trunk/KEYS

2008-11-15 Thread sebb
On 15/11/2008, [EMAIL PROTECTED] [EMAIL PROTECTED] wrote: Author: markt Date: Sat Nov 15 04:59:01 2008 New Revision: 714246 URL: http://svn.apache.org/viewvc?rev=714246view=rev Log: Update KEYS with changes from 6.0.x (Remy updated his key) Are there any releases signed with the old

Re: Thread safety issues in org.apache.catalina.util.CookieTools

2008-11-11 Thread sebb
On 11/11/2008, Anton Khitrenovich [EMAIL PROTECTED] wrote: Hi all, We are using IPlanet 6.1 web server, that is based on Catalina 4.1 container. Recently we've run into strange exceptions on Catalina level. After examining stack trace and relevant code, I see that the problem originates

Re: Setting version number in build.properties.default

2008-11-05 Thread sebb
On 05/11/2008, Remy Maucherat [EMAIL PROTECTED] wrote: On Thu, 2008-11-06 at 00:32 +0100, Rainer Jung wrote: Yes: is there any reason to not do it? It does not look actually useful, and I could forget about it (meaning a lot of wasted time). Perhaps you could do something like we do for

Re: svn commit: r709018 - in /tomcat/trunk/java/org/apache/juli: AsyncFileHandler.java FileHandler.java

2008-11-03 Thread sebb
On 29/10/2008, [EMAIL PROTECTED] [EMAIL PROTECTED] wrote: Author: fhanik Date: Wed Oct 29 14:41:09 2008 New Revision: 709018 URL: http://svn.apache.org/viewvc?rev=709018view=rev Log: Add asynchronous log handling, feature not yet complete. Need to figure out when to stop the logger

Re: Byte Serving and PDFs with the DefaultServlet

2008-10-10 Thread sebb
On 09/10/2008, [EMAIL PROTECTED] [EMAIL PROTECTED] wrote: Hello Mark, you are right. The mime extension is not working on a case insensitive basis. Now my Tomcat 5.5 does byte serving with the web.xml portion below: mime-mapping extensionpdf/extension

Re: svn commit: r702587 - /tomcat/trunk/java/org/apache/jasper/compiler/Parser.java

2008-10-07 Thread sebb
On 07/10/2008, [EMAIL PROTECTED] [EMAIL PROTECTED] wrote: Author: markt Date: Tue Oct 7 12:10:51 2008 New Revision: 702587 URL: http://svn.apache.org/viewvc?rev=702587view=rev Log: EG confirmed that attribute values should be fully escaped, including any EL. Note this does not fix

Re: svn commit: r700170 - /tomcat/tc6.0.x/trunk/STATUS.txt

2008-10-01 Thread sebb
On 29/09/2008, Mark Thomas [EMAIL PROTECTED] wrote: sebb wrote: On 29/09/2008, Mark Thomas [EMAIL PROTECTED] wrote: ThreadLocals and container classloader environments need careful handling to avoid memory leaks. I would have thought that was a good reason to keep the class - one

Re: svn commit: r700170 - /tomcat/tc6.0.x/trunk/STATUS.txt

2008-09-29 Thread sebb
BTW, Commons LANG has a thread-safe FastDateUtils which can be used for formatting (but not parsing) dates. Not sure why you did not just fix DateTool - e.g. by using ThreadLocal (or indeed synchronizing the use of DateFormats) - rather than fixing all calls to DateTool. Or maybe I've

<    1   2   3   4   5   >