[PR] chore: fix some misaligned whitespace in web.xml [tomcat]

robinverduijn opened a new pull request, #727: URL: https://github.com/apache/tomcat/pull/727 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

Re: [PR] Openssl changelog update [tomcat-native]

markt-asf merged PR #24: URL: https://github.com/apache/tomcat-native/pull/24 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[PR] Openssl changelog update [tomcat-native]

dsoumis opened a new pull request, #24: URL: https://github.com/apache/tomcat-native/pull/24 Add to changelog that the recommended minimum version of OpenSSL has been updated to 3.0.13 with 1.3.0 release. -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] Add "Changes in 1.3.x" section [tomcat-native]

markt-asf merged PR #23: URL: https://github.com/apache/tomcat-native/pull/23 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[PR] Add "Changes in 1.3.x" section [tomcat-native]

dsoumis opened a new pull request, #23: URL: https://github.com/apache/tomcat-native/pull/23 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

Re: [PR] Improve the SSLValve so it is able to handle the ssl_client_escaped_cert header from Nginx [tomcat]

ehsaasprogram commented on PR #406: URL: https://github.com/apache/tomcat/pull/406#issuecomment-2116423996 There are many complaints against https://ehsaasprogramme8171.pk/;>Ehsaas Programpeople are not receiving money -- This is an automated message from the Apache Git Service. To

Re: [I] activemq 5.16.x not working after converting javax to jakarta using tomcat transformer [tomcat-jakartaee-migration]

ilapavuluri closed issue #55: activemq 5.16.x not working after converting javax to jakarta using tomcat transformer URL: https://github.com/apache/tomcat-jakartaee-migration/issues/55 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [I] activemq 5.16.x not working after converting javax to jakarta using tomcat transformer [tomcat-jakartaee-migration]

ilapavuluri commented on issue #55: URL: https://github.com/apache/tomcat-jakartaee-migration/issues/55#issuecomment-2112442350 Hi Team, Really sorry for the late response, resolved it by upgrading to 5.18.3 in my clientside and keep the activemq server as it is. Thanks

Re: [PR] adds missing quotation mark - makes changelog.xml parsable again [tomcat]

ChristopherSchultz commented on PR #726: URL: https://github.com/apache/tomcat/pull/726#issuecomment-255159 :/ Sorry about that. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] adds missing quotation mark - makes changelog.xml parsable again [tomcat]

markt-asf commented on PR #726: URL: https://github.com/apache/tomcat/pull/726#issuecomment-2111099637 Tx for the pR -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] adds missing quotation mark - makes changelog.xml parsable again [tomcat]

markt-asf merged PR #726: URL: https://github.com/apache/tomcat/pull/726 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[PR] adds missing quotation mark - makes changelog.xml parsable again [tomcat]

pluralistix opened a new pull request, #726: URL: https://github.com/apache/tomcat/pull/726 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

Re: [I] activemq 5.16.x not working after converting javax to jakarta using tomcat transformer [tomcat-jakartaee-migration]

rmannibucau commented on issue #55: URL: https://github.com/apache/tomcat-jakartaee-migration/issues/55#issuecomment-2108571969 Hi @ilapavuluri , * did you run with `-profile=EE`? * do you use a local (vm) uri or a remote one? * did you run it on both the client and broker if

Re: [I] activemq 5.16.x not working after converting javax to jakarta using tomcat transformer [tomcat-jakartaee-migration]

ebourg commented on issue #55: URL: https://github.com/apache/tomcat-jakartaee-migration/issues/55#issuecomment-2106053982 @ilapavuluri Do you have a stacktrace to share? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] Bump org.apache.commons:commons-compress from 1.25.0 to 1.26.0 [tomcat-jakartaee-migration]

markt-asf merged PR #53: URL: https://github.com/apache/tomcat-jakartaee-migration/pull/53 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] it will drop first header if any header cause exceptio during process [tomcat]

markt-asf commented on PR #710: URL: https://github.com/apache/tomcat/pull/710#issuecomment-2093184047 Thanks for spotting this. I've applied this fix along with a simple test case. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] it will drop first header if any header cause exceptio during process [tomcat]

markt-asf closed pull request #710: it will drop first header if any header cause exceptio during process URL: https://github.com/apache/tomcat/pull/710 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] remove obsolete JMX bean attributes [tomcat]

markt-asf commented on PR #719: URL: https://github.com/apache/tomcat/pull/719#issuecomment-2093075977 Thanks for the PR. I did a broader review and found a few more attributes that could be removed too. -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] remove obsolete JMX bean attributes [tomcat]

markt-asf closed pull request #719: remove obsolete JMX bean attributes URL: https://github.com/apache/tomcat/pull/719 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] Extend Asn1Parser to parse UTF8Strings [tomcat]

michael-o commented on PR #725: URL: https://github.com/apache/tomcat/pull/725#issuecomment-2092917929 @markt-asf, thank for merging. I will come up with my addtional X.509 username retriever idea shortly. -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] Extend Asn1Parser to parse UTF8Strings [tomcat]

markt-asf merged PR #725: URL: https://github.com/apache/tomcat/pull/725 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[PR] Extend Asn1Parser to parse UTF8Strings [tomcat]

michael-o opened a new pull request, #725: URL: https://github.com/apache/tomcat/pull/725 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

Re: [PR] Add support for timescales with time-taken access log token. [tomcat]

ChristopherSchultz merged PR #721: URL: https://github.com/apache/tomcat/pull/721 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Add support for timescales with time-taken access log token. [tomcat]

ChristopherSchultz commented on code in PR #721: URL: https://github.com/apache/tomcat/pull/721#discussion_r1578085100 ## java/org/apache/catalina/valves/AbstractAccessLogValve.java: ## @@ -1756,10 +1776,14 @@ protected AccessLogElement createAccessLogElement(String name, char

[PR] Configurable HTML subtitle in Manager web application [tomcat]

xsimo opened a new pull request, #724: URL: https://github.com/apache/tomcat/pull/724 Managing multiple tomcats on multiple servers, the need came to have a way of customizing the Manager HTML interface. This PR proposes to add a simple configurable html subtitle.

[PR] Make status code configurable [tomcat]

adwsingh opened a new pull request, #723: URL: https://github.com/apache/tomcat/pull/723 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

Re: [PR] Add support for timescales with time-taken access log token. [tomcat]

markt-asf commented on code in PR #721: URL: https://github.com/apache/tomcat/pull/721#discussion_r1572780769 ## java/org/apache/catalina/valves/AbstractAccessLogValve.java: ## @@ -1756,10 +1776,14 @@ protected AccessLogElement createAccessLogElement(String name, char pattern)

Re: [PR] Add support for timescales with time-taken access log token. [tomcat]

ChristopherSchultz commented on code in PR #721: URL: https://github.com/apache/tomcat/pull/721#discussion_r1572455403 ## java/org/apache/catalina/valves/AbstractAccessLogValve.java: ## @@ -1756,10 +1776,14 @@ protected AccessLogElement createAccessLogElement(String name, char

Re: [PR] Add support for timescales with time-taken access log token. [tomcat]

ChristopherSchultz commented on code in PR #721: URL: https://github.com/apache/tomcat/pull/721#discussion_r1572451843 ## java/org/apache/catalina/valves/AbstractAccessLogValve.java: ## @@ -1756,10 +1776,14 @@ protected AccessLogElement createAccessLogElement(String name, char

[PR] Tomcat-jdbc causes problem with graalvm [tomcat]

MartinLei opened a new pull request, #722: URL: https://github.com/apache/tomcat/pull/722 Using the Tomcat-JDBC library inside a Spring Native project causes the compilation step of a GraalVM native image to crash with the given error. > Exception in thread "main"

Re: [PR] Re-adding support for fractional seconds in access log [tomcat]

jose-galvez commented on PR #720: URL: https://github.com/apache/tomcat/pull/720#issuecomment-2066644940 I like it!! Definitely way better than my change which now seems like a bad hack 藍 I can close this PR in favor of yours  -- This is an automated message from the Apache Git

Re: [PR] Re-adding support for fractional seconds in access log [tomcat]

jose-galvez closed pull request #720: Re-adding support for fractional seconds in access log URL: https://github.com/apache/tomcat/pull/720 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] Add support for timescales with time-taken access log token. [tomcat]

markt-asf commented on code in PR #721: URL: https://github.com/apache/tomcat/pull/721#discussion_r1572301203 ## java/org/apache/catalina/valves/AbstractAccessLogValve.java: ## @@ -1756,10 +1776,14 @@ protected AccessLogElement createAccessLogElement(String name, char pattern)

Re: [PR] Re-adding support for fractional seconds in access log [tomcat]

ChristopherSchultz commented on PR #720: URL: https://github.com/apache/tomcat/pull/720#issuecomment-2066468644 Please have a look at a different PR which builds on some refactoring I just pushed: https://github.com/apache/tomcat/pull/721 I think I like mine better. -- This is an

Re: [PR] Re-adding support for fractional seconds in access log [tomcat]

jose-galvez commented on PR #720: URL: https://github.com/apache/tomcat/pull/720#issuecomment-2064310044 > Are you specifically talking about the ExtendedAccessLogValve's `time-taken` token? If so, you're right, that documentation did not change yet the underlying implementation did

Re: [PR] Re-adding support for fractional seconds in access log [tomcat]

ChristopherSchultz commented on PR #720: URL: https://github.com/apache/tomcat/pull/720#issuecomment-2063868914 Oh, I'm' sorry I didn't pick-up on the subtleties of your report. Tomcat 10.1 is documented that the value for `%T` is in (presumably _whole_) seconds. Tomcat 9 says it's

Re: [PR] Re-adding support for fractional seconds in access log [tomcat]

jose-galvez commented on PR #720: URL: https://github.com/apache/tomcat/pull/720#issuecomment-2063746801 It can, but in this case the documentation states that it didn't so I was trying to bring it back to how it behaved before (which as an added bonus helps us not change our scripts).

Re: [PR] Re-adding support for fractional seconds in access log [tomcat]

ChristopherSchultz commented on PR #720: URL: https://github.com/apache/tomcat/pull/720#issuecomment-2063733345 So nothing can ever change, then? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] Re-adding support for fractional seconds in access log [tomcat]

jose-galvez commented on PR #720: URL: https://github.com/apache/tomcat/pull/720#issuecomment-2061838297 > Why not use `%D` which is in milliseconds (Tomcat <10) or microseconds (Tomcat >= 10)? I wanted to keep parity on the behavior here with previous versions, especially because

Re: [PR] Re-adding support for fractional seconds in access log [tomcat]

jose-galvez commented on PR #720: URL: https://github.com/apache/tomcat/pull/720#issuecomment-2061821679 > From memory that change was to align Tomcat's access log configuration with httpd. It may well be that the correct fix here is to correct the documentation. Separately, comparing this

Re: [PR] Re-adding support for fractional seconds in access log [tomcat]

ChristopherSchultz commented on PR #720: URL: https://github.com/apache/tomcat/pull/720#issuecomment-2061771435 Why not use `%D` which is in milliseconds (Tomcat <10) or microseconds (Tomcat >= 10)? -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] Re-adding support for fractional seconds in access log [tomcat]

markt-asf commented on PR #720: URL: https://github.com/apache/tomcat/pull/720#issuecomment-2061540617 From memory that change was to align Tomcat's access log configuration with httpd. It may well be that the correct fix here is to correct the documentation. Separately, comparing this

[PR] Re-adding support for fractional seconds in access log [tomcat]

jose-galvez opened a new pull request, #720: URL: https://github.com/apache/tomcat/pull/720 commit [a8575ef](https://github.com/apache/tomcat/commit/a8575efbc1de64fe58c8fd99e53a0011b59a8e86) removed support for seconds with floating point for the Extended Access Log Valve and made it only

[I] activemq 5.16.x not working after converting javax to jakarta using tomcat transformer [tomcat-jakartaee-migration]

ilapavuluri opened a new issue, #55: URL: https://github.com/apache/tomcat-jakartaee-migration/issues/55 I am using tomcat transformer for javax to jakarta conversion, in the similar lines I converted my activemq-all 5.16.7 into jakarta using the same tomcat transformer, no errors during

[PR] remove obsolete bean attributes [tomcat]

qauck opened a new pull request, #719: URL: https://github.com/apache/tomcat/pull/719 These attributes no longer existing in corresponding org.apache.tomcat.util.net.NioEndpoint, which will cause java.lang.NoSuchMethodException at run time. -- This is an automated message from the

Re: [PR] Sessioncounter [tomcat]

rmaucher commented on PR #713: URL: https://github.com/apache/tomcat/pull/713#issuecomment-2051302240 Thanks for pointing this out. Since tracking too many redundant stats is not super useful, I decided to remove this one (it is now approximated by adding the active sessions to the expired

Re: [PR] Sessioncounter [tomcat]

rmaucher closed pull request #713: Sessioncounter URL: https://github.com/apache/tomcat/pull/713 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] fix CVE-2024-23672 [tomcat]

aooohan commented on PR #718: URL: https://github.com/apache/tomcat/pull/718#issuecomment-2050851432 Tomcat 7 is end of life since March 2021, so we won't merge this change, thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] fix CVE-2024-23672 [tomcat]

aooohan closed pull request #718: fix CVE-2024-23672 URL: https://github.com/apache/tomcat/pull/718 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] fix CVE-2024-23672 [tomcat]

hazendaz commented on PR #718: URL: https://github.com/apache/tomcat/pull/718#issuecomment-2050846843 Not speaking for team but as onlooker, Tomcat 7 is end of life since March 2021. There are no further updates. So it wouldn't make sense to patch it. It wouldn't be released anyways.

[PR] fix CVE-2024-23672 [tomcat]

achibear opened a new pull request, #718: URL: https://github.com/apache/tomcat/pull/718 Tomcat 8 fixed the CVE-2024-23672 vulnerability through commit [3631adb1](https://github.com/apache/tomcat/commit/3631adb1342d8bbd8598802a12b63ad02c37d591). However, we have discovered similar

Re: [PR] Bump org.apache.tomcat:tomcat-coyote from 11.0.0-M14 to 11.0.0-M17 in /modules/openssl-foreign [tomcat]

dependabot[bot] closed pull request #715: Bump org.apache.tomcat:tomcat-coyote from 11.0.0-M14 to 11.0.0-M17 in /modules/openssl-foreign URL: https://github.com/apache/tomcat/pull/715 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] Bump org.apache.tomcat:tomcat-coyote from 9.0.83 to 9.0.86 in /modules/openssl-java17 [tomcat]

dependabot[bot] commented on PR #717: URL: https://github.com/apache/tomcat/pull/717#issuecomment-2050326077 Looks like org.apache.tomcat:tomcat-coyote is up-to-date now, so this is no longer needed. -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] Bump org.apache.tomcat:tomcat-coyote from 9.0.83 to 9.0.86 in /modules/openssl-java21 [tomcat]

dependabot[bot] closed pull request #716: Bump org.apache.tomcat:tomcat-coyote from 9.0.83 to 9.0.86 in /modules/openssl-java21 URL: https://github.com/apache/tomcat/pull/716 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] Bump org.apache.tomcat:tomcat-coyote from 9.0.83 to 9.0.86 in /modules/openssl-java21 [tomcat]

dependabot[bot] commented on PR #716: URL: https://github.com/apache/tomcat/pull/716#issuecomment-2050326279 Looks like org.apache.tomcat:tomcat-coyote is up-to-date now, so this is no longer needed. -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] Bump org.apache.tomcat:tomcat-coyote from 11.0.0-M14 to 11.0.0-M17 in /modules/openssl-foreign [tomcat]

dependabot[bot] commented on PR #715: URL: https://github.com/apache/tomcat/pull/715#issuecomment-2050326108 Looks like org.apache.tomcat:tomcat-coyote is up-to-date now, so this is no longer needed. -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] Bump org.apache.tomcat:tomcat-coyote from 9.0.83 to 9.0.86 in /modules/openssl-java17 [tomcat]

dependabot[bot] closed pull request #717: Bump org.apache.tomcat:tomcat-coyote from 9.0.83 to 9.0.86 in /modules/openssl-java17 URL: https://github.com/apache/tomcat/pull/717 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] Bump org.apache.tomcat:tomcat-websocket from 11.0.0-M16 to 11.0.0-M17 in /modules/stuffed [tomcat]

dependabot[bot] closed pull request #714: Bump org.apache.tomcat:tomcat-websocket from 11.0.0-M16 to 11.0.0-M17 in /modules/stuffed URL: https://github.com/apache/tomcat/pull/714 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] Bump org.apache.tomcat:tomcat-websocket from 11.0.0-M16 to 11.0.0-M17 in /modules/stuffed [tomcat]

dependabot[bot] commented on PR #714: URL: https://github.com/apache/tomcat/pull/714#issuecomment-2050326037 Looks like org.apache.tomcat:tomcat-websocket is up-to-date now, so this is no longer needed. -- This is an automated message from the Apache Git Service. To respond to the

[PR] Bump org.apache.tomcat:tomcat-coyote from 9.0.83 to 9.0.86 in /modules/openssl-java17 [tomcat]

dependabot[bot] opened a new pull request, #717: URL: https://github.com/apache/tomcat/pull/717 Bumps org.apache.tomcat:tomcat-coyote from 9.0.83 to 9.0.86. [![Dependabot compatibility

[PR] Bump org.apache.tomcat:tomcat-coyote from 9.0.83 to 9.0.86 in /modules/openssl-java21 [tomcat]

dependabot[bot] opened a new pull request, #716: URL: https://github.com/apache/tomcat/pull/716 Bumps org.apache.tomcat:tomcat-coyote from 9.0.83 to 9.0.86. [![Dependabot compatibility

[PR] Bump org.apache.tomcat:tomcat-coyote from 11.0.0-M14 to 11.0.0-M17 in /modules/openssl-foreign [tomcat]

dependabot[bot] opened a new pull request, #715: URL: https://github.com/apache/tomcat/pull/715 Bumps org.apache.tomcat:tomcat-coyote from 11.0.0-M14 to 11.0.0-M17. [![Dependabot compatibility

[PR] Bump org.apache.tomcat:tomcat-websocket from 11.0.0-M16 to 11.0.0-M17 in /modules/stuffed [tomcat]

dependabot[bot] opened a new pull request, #714: URL: https://github.com/apache/tomcat/pull/714 Bumps org.apache.tomcat:tomcat-websocket from 11.0.0-M16 to 11.0.0-M17. [![Dependabot compatibility

Re: [PR] Simplify usage of custom ssl configuration [tomcat]

rmaucher commented on PR #706: URL: https://github.com/apache/tomcat/pull/706#issuecomment-2049169784 I had left the PR open since others could have been willing to go through with it (or not, I don't know). -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] Simplify usage of custom ssl configuration [tomcat]

Hakky54 commented on PR #706: URL: https://github.com/apache/tomcat/pull/706#issuecomment-2049130432 Ah so your feeling is that this also might cause some regression while this wrapper does not add that much value to the project itself. I can understand that. Okay, thank you for your time

Re: [PR] Simplify usage of custom ssl configuration [tomcat]

Hakky54 closed pull request #706: Simplify usage of custom ssl configuration URL: https://github.com/apache/tomcat/pull/706 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] Simplify usage of custom ssl configuration [tomcat]

rmaucher commented on PR #706: URL: https://github.com/apache/tomcat/pull/706#issuecomment-2049093782 Your previous PR, which was integrated, unfortunately caused a very high number of regressions that had to be fixed over multiple Tomcat releases. This PR similarly seems uninteresting to

Re: [PR] Simplify usage of custom ssl configuration [tomcat]

Hakky54 commented on PR #706: URL: https://github.com/apache/tomcat/pull/706#issuecomment-2049034933 Hi @markt-asf What do you think of this PR, would it make sense to have this kind of wrapper, or does it needs to be adjusted or would you like me to close it and disregard it?

Re: [PR] Sessioncounter [tomcat]

rmaucher commented on PR #713: URL: https://github.com/apache/tomcat/pull/713#issuecomment-2042934315 I think this field should simply be dropped in Tomcat 11, it's redundant with the others. Shouldn't it be expired + active ? For the other branches I would deprecate the field. -- This

Re: [PR] Sessioncounter [tomcat]

pangxianhai commented on PR #713: URL: https://github.com/apache/tomcat/pull/713#issuecomment-2041713809 > Is this fixing an observed issue or a theoretical one? observed issue. On the monitoring platform, we found that the sessionCounter is less than the expiredSessions. The

Re: [PR] Sessioncounter [tomcat]

markt-asf commented on PR #713: URL: https://github.com/apache/tomcat/pull/713#issuecomment-2041577898 Is this fixing an observed issue or a theoretical one? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[PR] Sessioncounter [tomcat]

pangxianhai opened a new pull request, #713: URL: https://github.com/apache/tomcat/pull/713 sessionCounter change to AtomicLong. Avoid inaccurate counting in concurrent situations -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] Changed simple synchronization to ReentrantReadWriteLock [tomcat]

ChristopherSchultz commented on PR #712: URL: https://github.com/apache/tomcat/pull/712#issuecomment-2032266991 Thank you for this PR, though I was already working on a patch and the unit tests pass, so I'm going to commit my patch instead of yours. I will credit you for the idea in the

Re: [PR] Changed simple synchronization to ReentrantReadWriteLock [tomcat]

ChristopherSchultz closed pull request #712: Changed simple synchronization to ReentrantReadWriteLock URL: https://github.com/apache/tomcat/pull/712 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] Sort the resource list,Ensure consistency in the order of loading res… [tomcat]

songxiaosheng commented on PR #708: URL: https://github.com/apache/tomcat/pull/708#issuecomment-2031977951 > Anyone who wants this should lobby the Jakarta Servlet Experts Group. It's the only way this is likely to get into Tomcat. Thank you. I feel it's worth a try -- This is an

[PR] Changed simple synchronization to ReentrantReadWriteLock [tomcat]

LupusMKW opened a new pull request, #712: URL: https://github.com/apache/tomcat/pull/712 Due to https://github.com/apache/tomcat/commit/4f33be682fda02a616baa0fd9b4965d248cfe1c1 our application does no longer work. The commit improved the situation with respect to concurrent

Re: [PR] Sort the resource list,Ensure consistency in the order of loading res… [tomcat]

ChristopherSchultz commented on PR #708: URL: https://github.com/apache/tomcat/pull/708#issuecomment-2031945781 Anyone who wants this should lobby the Jakarta Servlet Experts Group. It's the only way this is likely to get into Tomcat. -- This is an automated message from the Apache Git

Re: [PR] Sort the resource list,Ensure consistency in the order of loading res… [tomcat]

songxiaosheng commented on PR #708: URL: https://github.com/apache/tomcat/pull/708#issuecomment-2031336540 > https://bz.apache.org/bugzilla/show_bug.cgi?id=57129 From the user's perspective, there is a greater risk in the uncertainty of not sorting. Previous discussions did not seem

[PR] Adds the possibility to change the USE_TLS_RESPONSE HTTP response [tomcat]

Leon-Schwandt opened a new pull request, #709: URL: https://github.com/apache/tomcat/pull/709 Enables the USE_TLS_RESPONSE message to be changed at a global level. A possible use case would be a redirect to HTTPS -- This is an automated message from the Apache Git Service. To respond to

Re: [PR] Sort the resource list,Ensure consistency in the order of loading res… [tomcat]

markt-asf closed pull request #708: Sort the resource list,Ensure consistency in the order of loading res… URL: https://github.com/apache/tomcat/pull/708 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] Sort the resource list,Ensure consistency in the order of loading res… [tomcat]

markt-asf commented on PR #708: URL: https://github.com/apache/tomcat/pull/708#issuecomment-2006814096 Closing see https://bz.apache.org/bugzilla/show_bug.cgi?id=57129 for the reasons. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[PR] Sort the resource list,Ensure consistency in the order of loading res… [tomcat]

zxm1234 opened a new pull request, #708: URL: https://github.com/apache/tomcat/pull/708 …ources. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Unify comma-separated-value code and optimize the implementation [tomcat]

ChristopherSchultz commented on PR #707: URL: https://github.com/apache/tomcat/pull/707#issuecomment-2003805644 > Ok, so add back the protected static methods in 10.1, just in case. Sounds good. -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] Unify comma-separated-value code and optimize the implementation [tomcat]

rmaucher commented on PR #707: URL: https://github.com/apache/tomcat/pull/707#issuecomment-2002509259 Ok, so add back the protected static methods in 10.1, just in case. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] Unify comma-separated-value code and optimize the implementation [tomcat]

ChristopherSchultz commented on PR #707: URL: https://github.com/apache/tomcat/pull/707#issuecomment-2002496427 Hmm... I've merged this PR but it occurs to me that maybe I should have deprecated all those methods instead of removing them. Thoughts? -- This is an automated message

Re: [PR] Unify comma-separated-value code and optimize the implementation [tomcat]

ChristopherSchultz merged PR #707: URL: https://github.com/apache/tomcat/pull/707 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Unify comma-separated-value code and optimize the implementation [tomcat]

ChristopherSchultz commented on code in PR #707: URL: https://github.com/apache/tomcat/pull/707#discussion_r1527524948 ## java/org/apache/catalina/realm/JNDIRealm.java: ## @@ -966,7 +967,7 @@ private String[] getCipherSuitesArray() {

Re: [PR] support tomcat 8.5 [tomcat-maven-plugin]

liudongmiao closed pull request #32: support tomcat 8.5 URL: https://github.com/apache/tomcat-maven-plugin/pull/32 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] Unify comma-separated-value code and optimize the implementation [tomcat]

markt-asf commented on code in PR #707: URL: https://github.com/apache/tomcat/pull/707#discussion_r1526610303 ## java/org/apache/catalina/realm/JNDIRealm.java: ## @@ -966,7 +967,7 @@ private String[] getCipherSuitesArray() {

[PR] Unify comma-separated-value code and optimize the implementation [tomcat]

ChristopherSchultz opened a new pull request, #707: URL: https://github.com/apache/tomcat/pull/707 There was repeated code in various places in the source tree to spit simple comma-separated strings using the regular expression pattern `\s*,\s*`. This PR gathers those together into a

[PR] Simplify usage of custom ssl configuration [tomcat]

Hakky54 opened a new pull request, #706: URL: https://github.com/apache/tomcat/pull/706 This PR is a followup of the following earlier PR https://github.com/apache/tomcat/pull/673 Although that pull request didn't get merged, the code changes has been comitted to the main branch by the

Re: [PR] removed null eval statement code if os400 [tomcat]

markt-asf commented on PR #701: URL: https://github.com/apache/tomcat/pull/701#issuecomment-1984155698 The proposed change removes the explanatory comments. They need to be kept so future maintainers can easily understand why the test is skipped for OS/400. -- This is an automated

Re: [PR] Remove duplicate cipher element from unimplemented set in TesterOpenSSL.java [tomcat]

markt-asf merged PR #699: URL: https://github.com/apache/tomcat/pull/699 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Update MERGE.txt [tomcat]

anujdevopslearn closed pull request #705: Update MERGE.txt URL: https://github.com/apache/tomcat/pull/705 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

Re: [PR] remove unnecessary code in InputBuffer.available() [tomcat]

rmaucher closed pull request #704: remove unnecessary code in InputBuffer.available() URL: https://github.com/apache/tomcat/pull/704 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] remove unnecessary code in InputBuffer.available() [tomcat]

rmaucher commented on PR #704: URL: https://github.com/apache/tomcat/pull/704#issuecomment-1972669485 Thanks, but it looks equivalent to me. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] Remove duplicate if statements from the OutputBuffer.close() method [tomcat]

rmaucher merged PR #703: URL: https://github.com/apache/tomcat/pull/703 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[PR] Remove duplicate if statements from the OutputBuffer.close() method [tomcat]

RealTake opened a new pull request, #703: URL: https://github.com/apache/tomcat/pull/703 Hello I was checking the code regarding the "Content-length" of the response and found it. In my opinion, it is because I decided that it is unnecessary to double check !coyoteResponse.isCommitted()

Re: [PR] Avoid performance issues that may arise when the array is large. [tomcat]

rmaucher closed pull request #702: Avoid performance issues that may arise when the array is large. URL: https://github.com/apache/tomcat/pull/702 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] Avoid performance issues that may arise when the array is large. [tomcat]

rmaucher commented on PR #702: URL: https://github.com/apache/tomcat/pull/702#issuecomment-1969224578 I added some optimizations, still based on the array. If you investigate something, then fully using a LinkedHashSet would likely be better than HashSet + array. Please provide actual

  1   2   3   4   5   6   7   8   9   10   >