Re: [PR] 20.0.0/super tomcat [tomcat]

2024-02-14 Thread via GitHub
Seull1 closed pull request #695: 20.0.0/super tomcat URL: https://github.com/apache/tomcat/pull/695 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Super-Tomcat [tomcat]

2024-02-14 Thread via GitHub
papercrane55123 closed pull request #689: Super-Tomcat URL: https://github.com/apache/tomcat/pull/689 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] super super [tomcat]

2024-02-14 Thread via GitHub
pySatellite commented on PR #691: URL: https://github.com/apache/tomcat/pull/691#issuecomment-1945200861 Sorry, I sent you the wrong PR to the branch created for learning. I'm always using TOMCAT well as a Java developer. Thank you, I'll end that PR. -- This is an automated message from

Re: [PR] super super [tomcat]

2024-02-14 Thread via GitHub
pySatellite closed pull request #691: super super URL: https://github.com/apache/tomcat/pull/691 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] fix README.md [tomcat]

2024-02-14 Thread via GitHub
dhkdtld37 closed pull request #688: fix README.md URL: https://github.com/apache/tomcat/pull/688 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] super tomcat [tomcat]

2024-02-14 Thread via GitHub
parc02 commented on PR #693: URL: https://github.com/apache/tomcat/pull/693#issuecomment-1945198656 ![LGTM](https://i.lgtm.fun/2p8z.png) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] super tomcat [tomcat]

2024-02-14 Thread via GitHub
parc02 commented on PR #694: URL: https://github.com/apache/tomcat/pull/694#issuecomment-1945197670 ![LGTM](https://i.lgtm.fun/2p8z.png) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[PR] 20.0.0/super tomcat [tomcat]

2024-02-14 Thread via GitHub
temp12312yeap opened a new pull request, #696: URL: https://github.com/apache/tomcat/pull/696 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[PR] super tomcat [tomcat]

2024-02-14 Thread via GitHub
Jaelinny opened a new pull request, #693: URL: https://github.com/apache/tomcat/pull/693 first~ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[PR] super tomcat [tomcat]

2024-02-14 Thread via GitHub
hyunsungJoo opened a new pull request, #692: URL: https://github.com/apache/tomcat/pull/692 ![LGTM](https://thumbs.dreamstime.com/z/tomcat-snow-my-was-playing-last-winter-97029930.jpg) -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[PR] Super tomcat [tomcat]

2024-02-14 Thread via GitHub
parc02 opened a new pull request, #690: URL: https://github.com/apache/tomcat/pull/690 ![image](https://github.com/apache/tomcat/assets/148880521/94457007-bfb7-4d4f-98d2-7c7d4a7d44d3) -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] Super-Tomcat [tomcat]

2024-02-14 Thread via GitHub
papercrane55123 closed pull request #689: Super-Tomcat URL: https://github.com/apache/tomcat/pull/689 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[PR] fix README.md [tomcat]

2024-02-14 Thread via GitHub
dhkdtld37 opened a new pull request, #688: URL: https://github.com/apache/tomcat/pull/688 fix README.md -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

Re: [PR] Decode and normalize URIs before processing them [tomcat]

2024-02-07 Thread via GitHub
Woellchen commented on PR #687: URL: https://github.com/apache/tomcat/pull/687#issuecomment-1932961663 Alright, I guess I got this wrong then, thanks for your detailed explanations. In case others are wondering about the same issue I found two bugs for reference on prominent software

Re: [PR] Decode and normalize URIs before processing them [tomcat]

2024-02-07 Thread via GitHub
markt-asf commented on PR #687: URL: https://github.com/apache/tomcat/pull/687#issuecomment-1932891346 Nope, `%2F` is NOT equivalent to `/` in a URI as explained in section 2.2 of RFC 3986. -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] Decode and normalize URIs before processing them [tomcat]

2024-02-07 Thread via GitHub
Woellchen commented on PR #687: URL: https://github.com/apache/tomcat/pull/687#issuecomment-1932841669 Thanks for checking back! The section you are referring to does not really negate my statement however. If I get you right you are talking about this specific thing? > These URIs

Re: [PR] Decode and normalize URIs before processing them [tomcat]

2024-02-07 Thread via GitHub
markt-asf commented on PR #687: URL: https://github.com/apache/tomcat/pull/687#issuecomment-1932635647 Nope. Read the RFC again. Specifically 6.2.2.2. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] Decode and normalize URIs before processing them [tomcat]

2024-02-07 Thread via GitHub
Woellchen commented on PR #687: URL: https://github.com/apache/tomcat/pull/687#issuecomment-1932522774 Could you please elaborate how a URI is not user input and how it can be prevented that a user calls a URI on a web application? I can't follow you. Relative paths are explicitly

Re: [PR] Decode and normalize URIs before processing them [tomcat]

2024-02-07 Thread via GitHub
rmaucher commented on PR #687: URL: https://github.com/apache/tomcat/pull/687#issuecomment-1932491567 URL processing and mapping has to follow a lot of rules from specifications to avoid inconsistencies which would be security issues. So this is one of them. Indeed creative encoding can

Re: [PR] Decode and normalize URIs before processing them [tomcat]

2024-02-07 Thread via GitHub
rmaucher closed pull request #687: Decode and normalize URIs before processing them URL: https://github.com/apache/tomcat/pull/687 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[PR] Decode and normalize URIs before processing them [tomcat]

2024-02-07 Thread via GitHub
Woellchen opened a new pull request, #687: URL: https://github.com/apache/tomcat/pull/687 URIs must be at least decoded in order to process sub-delims as defined in RFC 3986, because slashes and their encoded counterparts are equivalent when processing paths. Normalization before the

Re: [PR] Added option to use custom SSLContext [tomcat]

2024-02-07 Thread via GitHub
Hakky54 commented on PR #673: URL: https://github.com/apache/tomcat/pull/673#issuecomment-1932206483 Thank you mate, I really appreciate this! Big kudos! 拾 I am looking forward to the new release! -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] Added option to use custom SSLContext [tomcat]

2024-02-07 Thread via GitHub
markt-asf commented on PR #673: URL: https://github.com/apache/tomcat/pull/673#issuecomment-1932089608 OK, it is in main. I'll back-port as well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] Added option to use custom SSLContext [tomcat]

2024-02-07 Thread via GitHub
markt-asf commented on PR #673: URL: https://github.com/apache/tomcat/pull/673#issuecomment-1931990842 I have some ideas on how to address this. I might have a fix for this soon that takes account of the lifecycle issues. -- This is an automated message from the Apache Git Service. To

Re: [PR] Added option to use custom SSLContext [tomcat]

2024-02-07 Thread via GitHub
Hakky54 commented on PR #673: URL: https://github.com/apache/tomcat/pull/673#issuecomment-1931967568 Ah that is pity, I was looking forward to it. You have a better overview of the issues which it can cause to other functionalities. I was not aware of the lifecycle management and only

Re: [PR] Added option to use custom SSLContext [tomcat]

2024-02-07 Thread via GitHub
markt-asf commented on PR #673: URL: https://github.com/apache/tomcat/pull/673#issuecomment-1931686883 I was tempted to merge this but having reviewed the Tomcat code I think this is going to create problems - the main one being that Tomcat clears the SSLContext on Connector.stop() when

Re: [PR] Added option to use custom SSLContext [tomcat]

2024-02-07 Thread via GitHub
markt-asf closed pull request #673: Added option to use custom SSLContext URL: https://github.com/apache/tomcat/pull/673 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] Add a fallback when people use Parameters class concurrently, to avoid lost params [tomcat]

2024-02-07 Thread via GitHub
markt-asf commented on PR #686: URL: https://github.com/apache/tomcat/pull/686#issuecomment-1931626326 WONTFIX - As per section 2.3.3.4 applications are responsible for accessing the request in a thread safe manner. -- This is an automated message from the Apache Git Service. To respond

Re: [PR] Add a fallback when people use Parameters class concurrently, to avoid lost params [tomcat]

2024-02-07 Thread via GitHub
markt-asf closed pull request #686: Add a fallback when people use Parameters class concurrently, to avoid lost params URL: https://github.com/apache/tomcat/pull/686 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] Added option to use custom SSLContext [tomcat]

2024-02-06 Thread via GitHub
Hakky54 commented on PR #673: URL: https://github.com/apache/tomcat/pull/673#issuecomment-1929460593 Hi team, is there any progress on this topic. Is there something what I can do on my side? Like backporting to other branches or anything else maybe? -- This is an automated message from

Re: [PR] Fix websocket processor leaks when WsSession expires and server sends close message by WsBackgroundThread [tomcat]

2024-02-02 Thread via GitHub
ChristopherSchultz commented on PR #683: URL: https://github.com/apache/tomcat/pull/683#issuecomment-1924044806 > > Fixed and back-ported. Will be in the February releases. > > Hi @markt-asf,What channel can I use to know that this problem has been fixed? Thank you very much.

Re: [PR] Fix websocket processor leaks when WsSession expires and server sends close message by WsBackgroundThread [tomcat]

2024-02-01 Thread via GitHub
chenbiaoit commented on PR #683: URL: https://github.com/apache/tomcat/pull/683#issuecomment-1923029828 > Fixed and back-ported. Will be in the February releases. Hi @markt-asf,What channel can I use to know that this problem has been fixed? Thank you very much. -- This is an

Re: [PR] Csrf filter improvements [tomcat]

2024-02-01 Thread via GitHub
ChristopherSchultz merged PR #681: URL: https://github.com/apache/tomcat/pull/681 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [I] Workaround for JDK-8303866 makes migrated jar incompatible with latest JDK releases [tomcat-jakartaee-migration]

2024-01-28 Thread via GitHub
DanielThomas commented on issue #48: URL: https://github.com/apache/tomcat-jakartaee-migration/issues/48#issuecomment-1913758414 Some improvements got made to this mitigation in later JDK releases, due to false positives in the detection, so I think this has been addressed upstream. --

Re: [PR] Update to use JakartaExpressionLanguage osgi.contract [tomcat]

2024-01-25 Thread via GitHub
markt-asf closed pull request #685: Update to use JakartaExpressionLanguage osgi.contract URL: https://github.com/apache/tomcat/pull/685 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] Update to use JakartaExpressionLanguage osgi.contract [tomcat]

2024-01-25 Thread via GitHub
markt-asf commented on PR #685: URL: https://github.com/apache/tomcat/pull/685#issuecomment-1910685730 Broader fix applied. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] Update to use JakartaExpressionLanguage osgi.contract [tomcat]

2024-01-25 Thread via GitHub
markt-asf commented on PR #685: URL: https://github.com/apache/tomcat/pull/685#issuecomment-1910670058 Thanks for reporting this. Looks like most of the embedded JARs got missed but EL was updated for embedded but not the standalone JAR in BZ 66834. I have a fix I'll push shortly that

[PR] native/common/jk_global.h: fix compilation on musl [tomcat-connectors]

2024-01-23 Thread via GitHub
ConiKost opened a new pull request, #8: URL: https://github.com/apache/tomcat-connectors/pull/8 On musl, sys/socketvar.h does not exist, so we need to make sure, not to use it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[PR] Update to use JakartaExpressionLanguage osgi.contract [tomcat]

2024-01-19 Thread via GitHub
pnicolucci opened a new pull request, #685: URL: https://github.com/apache/tomcat/pull/685 I opened: https://bz.apache.org/bugzilla/show_bug.cgi?id=66834 last year and upon looking at the latest M16 release of Expression Language 6.0 here:

Re: [PR] Fix websocket processor leaks when WsSession expires and server sends close message by WsBackgroundThread [tomcat]

2024-01-18 Thread via GitHub
imario42 commented on PR #683: URL: https://github.com/apache/tomcat/pull/683#issuecomment-1899854047 Thanks a lot @markt-asf for tackling and fixing it and @lbliangbin for the analysis.  -- This is an automated message from the Apache Git Service. To respond to the message, please

Re: [PR] Fix HTTP/2 support wording in HTTP docs [tomcat]

2024-01-18 Thread via GitHub
markt-asf commented on PR #682: URL: https://github.com/apache/tomcat/pull/682#issuecomment-1899075283 Tx. I'll back-port this fix shortly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] Fix HTTP/2 support wording in HTTP docs [tomcat]

2024-01-18 Thread via GitHub
markt-asf merged PR #682: URL: https://github.com/apache/tomcat/pull/682 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Fix websocket processor leaks when WsSession expires and server sends close message by WsBackgroundThread [tomcat]

2024-01-18 Thread via GitHub
markt-asf commented on PR #683: URL: https://github.com/apache/tomcat/pull/683#issuecomment-1899074074 Fixed and back-ported. Will be in the February releases. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] Fix websocket processor leaks when WsSession expires and server sends close message by WsBackgroundThread [tomcat]

2024-01-18 Thread via GitHub
markt-asf closed pull request #683: Fix websocket processor leaks when WsSession expires and server sends close message by WsBackgroundThread URL: https://github.com/apache/tomcat/pull/683 -- This is an automated message from the Apache Git Service. To respond to the message, please log on

Re: [PR] Fix websocket processor leaks when WsSession expires and server sends close message by WsBackgroundThread [tomcat]

2024-01-18 Thread via GitHub
markt-asf commented on PR #683: URL: https://github.com/apache/tomcat/pull/683#issuecomment-189414 The description of the problem and the analysis of the root cause (the BZ 66508 fix) is correct but the proposed fix is not. It will probably work the majority of the time but there is a

Re: [PR] Fix websocket processor leaks when WsSession expires and server sends close message by WsBackgroundThread [tomcat]

2024-01-18 Thread via GitHub
markt-asf commented on PR #683: URL: https://github.com/apache/tomcat/pull/683#issuecomment-1898853883 Thanks. The reference to the description on the users list helps. I'll look at this again. -- This is an automated message from the Apache Git Service. To respond to the message, please

Re: [PR] Fix websocket processor leaks when WsSession expires and server sends close message by WsBackgroundThread [tomcat]

2024-01-18 Thread via GitHub
imario42 commented on PR #683: URL: https://github.com/apache/tomcat/pull/683#issuecomment-1898787616 @markt-asf : He described his findings in that tomcat-user post [https://lists.apache.org/thread/vyog0dyxwq3hlpjgt2vb1wkrxw6x2h1k](url) However, I do not know if his patch works.

Re: [PR] Fix websocket processor leaks when WsSession expires and server sends close message by WsBackgroundThread [tomcat]

2024-01-18 Thread via GitHub
markt-asf closed pull request #683: Fix websocket processor leaks when WsSession expires and server sends close message by WsBackgroundThread URL: https://github.com/apache/tomcat/pull/683 -- This is an automated message from the Apache Git Service. To respond to the message, please log on

Re: [PR] Fix websocket processor leaks when WsSession expires and server sends close message by WsBackgroundThread [tomcat]

2024-01-18 Thread via GitHub
markt-asf commented on PR #683: URL: https://github.com/apache/tomcat/pull/683#issuecomment-1898765701 No evidence provided to support claim of a leak. No leak observed when testing with profiler. No obvious reason that proposed patch would impact `UpgradeProcessor` instances (or

Re: [PR] Update README.md [tomcat-tck]

2024-01-16 Thread via GitHub
markt-asf merged PR #1: URL: https://github.com/apache/tomcat-tck/pull/1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[PR] Update README.md [tomcat-tck]

2024-01-16 Thread via GitHub
fhanik opened a new pull request, #1: URL: https://github.com/apache/tomcat-tck/pull/1 Fix header typo -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

Re: [PR] Bump org.apache.tomcat:tomcat-catalina from 10.1.15 to 10.1.16 in /modules/owb [tomcat]

2024-01-16 Thread via GitHub
dependabot[bot] commented on PR #680: URL: https://github.com/apache/tomcat/pull/680#issuecomment-1893441318 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let

Re: [PR] Bump org.apache.tomcat:tomcat-catalina from 10.1.15 to 10.1.16 in /modules/owb [tomcat]

2024-01-16 Thread via GitHub
markt-asf commented on PR #680: URL: https://github.com/apache/tomcat/pull/680#issuecomment-1893441250 Out of date -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] Bump org.apache.tomcat:tomcat-catalina from 10.1.15 to 10.1.16 in /modules/owb [tomcat]

2024-01-16 Thread via GitHub
markt-asf closed pull request #680: Bump org.apache.tomcat:tomcat-catalina from 10.1.15 to 10.1.16 in /modules/owb URL: https://github.com/apache/tomcat/pull/680 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] Remove org.apache.catalina.ssi from tomcat-embed-core.jar.tmp.bnd [tomcat]

2024-01-15 Thread via GitHub
jjohannes commented on PR #684: URL: https://github.com/apache/tomcat/pull/684#issuecomment-1891752142 Thanks @markt-asf! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] Remove org.apache.catalina.ssi from tomcat-embed-core.jar.tmp.bnd [tomcat]

2024-01-15 Thread via GitHub
markt-asf commented on PR #684: URL: https://github.com/apache/tomcat/pull/684#issuecomment-1891608646 Fixed manually in main for 11.0.x (with change log entry) and then back-ported (cherry-picked) to 10.1.x and 9.0.x. -- This is an automated message from the Apache Git Service. To

Re: [PR] Remove org.apache.catalina.ssi from tomcat-embed-core.jar.tmp.bnd [tomcat]

2024-01-15 Thread via GitHub
markt-asf closed pull request #684: Remove org.apache.catalina.ssi from tomcat-embed-core.jar.tmp.bnd URL: https://github.com/apache/tomcat/pull/684 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[PR] Remove org.apache.catalina.ssi from tomcat-embed-core.jar.tmp.bnd [tomcat]

2024-01-13 Thread via GitHub
jjohannes opened a new pull request, #684: URL: https://github.com/apache/tomcat/pull/684 This package no longer exits in `tomcat-embed-core.jar`. It is in the 'module-info.class' of the current `10.1.18` and earlier `10.x` releases. Running `jlink` or `jpackage` with a Module Path

Re: [PR] Fix websocket processor leaks when WsSession expires and server send … [tomcat]

2024-01-06 Thread via GitHub
lbliangbin closed pull request #683: Fix websocket processor leaks when WsSession expires and server send … URL: https://github.com/apache/tomcat/pull/683 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[PR] Fix HTTP/2 support wording in HTTP docs [tomcat]

2024-01-06 Thread via GitHub
janbrasna opened a new pull request, #682: URL: https://github.com/apache/tomcat/pull/682 Trivial wording fix for config docs. _(Unfortunately goes all the way back to `9.0.x` and `8.5.x`)_ -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] Csrf filter improvements [tomcat]

2024-01-03 Thread via GitHub
ChristopherSchultz commented on PR #681: URL: https://github.com/apache/tomcat/pull/681#issuecomment-1875476100 > > Re 4: I think that if one is wise enough to write a RegExp, they could use "|" to combine several patterns, and do not really need splitting by comma. > > I suppose if

Re: [PR] Csrf filter improvements [tomcat]

2023-12-28 Thread via GitHub
isapir commented on code in PR #681: URL: https://github.com/apache/tomcat/pull/681#discussion_r1437906912 ## java/org/apache/catalina/filters/CsrfPreventionFilter.java: ## @@ -53,6 +58,25 @@ public class CsrfPreventionFilter extends CsrfPreventionFilterBase { private

Re: [PR] Csrf filter improvements [tomcat]

2023-12-28 Thread via GitHub
isapir commented on code in PR #681: URL: https://github.com/apache/tomcat/pull/681#discussion_r1437905241 ## java/org/apache/catalina/filters/CsrfPreventionFilter.java: ## @@ -110,45 +285,70 @@ public void doFilter(ServletRequest request, ServletResponse response, FilterCha

Re: [PR] Csrf filter improvements [tomcat]

2023-12-28 Thread via GitHub
isapir commented on code in PR #681: URL: https://github.com/apache/tomcat/pull/681#discussion_r1437903976 ## java/org/apache/catalina/filters/CsrfPreventionFilter.java: ## @@ -87,11 +104,170 @@ public void setNonceRequestParameterName(String parameterName) {

Re: [PR] Csrf filter improvements [tomcat]

2023-12-28 Thread via GitHub
ChristopherSchultz commented on code in PR #681: URL: https://github.com/apache/tomcat/pull/681#discussion_r1437901624 ## java/org/apache/catalina/filters/CsrfPreventionFilter.java: ## @@ -87,11 +104,170 @@ public void setNonceRequestParameterName(String parameterName) {

Re: [PR] Csrf filter improvements [tomcat]

2023-12-28 Thread via GitHub
ChristopherSchultz commented on code in PR #681: URL: https://github.com/apache/tomcat/pull/681#discussion_r1437900565 ## java/org/apache/catalina/filters/CsrfPreventionFilter.java: ## @@ -87,11 +104,170 @@ public void setNonceRequestParameterName(String parameterName) {

Re: [PR] Csrf filter improvements [tomcat]

2023-12-28 Thread via GitHub
ChristopherSchultz commented on code in PR #681: URL: https://github.com/apache/tomcat/pull/681#discussion_r1437899157 ## java/org/apache/catalina/filters/CsrfPreventionFilter.java: ## @@ -87,11 +104,170 @@ public void setNonceRequestParameterName(String parameterName) {

Re: [PR] Csrf filter improvements [tomcat]

2023-12-28 Thread via GitHub
ChristopherSchultz commented on code in PR #681: URL: https://github.com/apache/tomcat/pull/681#discussion_r1437898144 ## java/org/apache/catalina/filters/CsrfPreventionFilter.java: ## @@ -87,11 +104,170 @@ public void setNonceRequestParameterName(String parameterName) {

Re: [PR] Csrf filter improvements [tomcat]

2023-12-28 Thread via GitHub
ChristopherSchultz commented on code in PR #681: URL: https://github.com/apache/tomcat/pull/681#discussion_r1437898048 ## java/org/apache/catalina/filters/CsrfPreventionFilter.java: ## @@ -87,11 +104,170 @@ public void setNonceRequestParameterName(String parameterName) {

Re: [PR] Csrf filter improvements [tomcat]

2023-12-28 Thread via GitHub
ChristopherSchultz commented on code in PR #681: URL: https://github.com/apache/tomcat/pull/681#discussion_r1437897171 ## java/org/apache/catalina/filters/CsrfPreventionFilter.java: ## @@ -87,11 +104,170 @@ public void setNonceRequestParameterName(String parameterName) {

Re: [PR] Csrf filter improvements [tomcat]

2023-12-28 Thread via GitHub
ChristopherSchultz commented on code in PR #681: URL: https://github.com/apache/tomcat/pull/681#discussion_r1437896682 ## java/org/apache/catalina/filters/CsrfPreventionFilter.java: ## @@ -110,45 +285,70 @@ public void doFilter(ServletRequest request, ServletResponse response,

Re: [PR] Csrf filter improvements [tomcat]

2023-12-25 Thread via GitHub
michael-o commented on code in PR #681: URL: https://github.com/apache/tomcat/pull/681#discussion_r1436107052 ## java/org/apache/catalina/filters/CsrfPreventionFilter.java: ## @@ -87,11 +104,170 @@ public void setNonceRequestParameterName(String parameterName) {

Re: [PR] Csrf filter improvements [tomcat]

2023-12-24 Thread via GitHub
isapir commented on code in PR #681: URL: https://github.com/apache/tomcat/pull/681#discussion_r1435945699 ## java/org/apache/catalina/filters/CsrfPreventionFilter.java: ## @@ -87,11 +104,170 @@ public void setNonceRequestParameterName(String parameterName) {

Re: [PR] Csrf filter improvements [tomcat]

2023-12-24 Thread via GitHub
isapir commented on code in PR #681: URL: https://github.com/apache/tomcat/pull/681#discussion_r1435945537 ## java/org/apache/catalina/filters/CsrfPreventionFilter.java: ## @@ -110,45 +285,70 @@ public void doFilter(ServletRequest request, ServletResponse response, FilterCha

Re: [PR] Csrf filter improvements [tomcat]

2023-12-24 Thread via GitHub
isapir commented on code in PR #681: URL: https://github.com/apache/tomcat/pull/681#discussion_r1435943790 ## java/org/apache/catalina/filters/CsrfPreventionFilter.java: ## @@ -87,11 +104,170 @@ public void setNonceRequestParameterName(String parameterName) {

Re: [PR] Csrf filter improvements [tomcat]

2023-12-24 Thread via GitHub
isapir commented on code in PR #681: URL: https://github.com/apache/tomcat/pull/681#discussion_r1435943366 ## java/org/apache/catalina/filters/CsrfPreventionFilter.java: ## @@ -87,11 +104,170 @@ public void setNonceRequestParameterName(String parameterName) {

Re: [PR] Csrf filter improvements [tomcat]

2023-12-21 Thread via GitHub
michael-o commented on code in PR #681: URL: https://github.com/apache/tomcat/pull/681#discussion_r1434524088 ## java/org/apache/catalina/filters/CsrfPreventionFilter.java: ## @@ -87,11 +104,170 @@ public void setNonceRequestParameterName(String parameterName) {

Re: [PR] Csrf filter improvements [tomcat]

2023-12-21 Thread via GitHub
ChristopherSchultz commented on code in PR #681: URL: https://github.com/apache/tomcat/pull/681#discussion_r1434521612 ## webapps/docs/config/filter.xml: ## @@ -319,6 +326,34 @@ of java.security.SecureRandom will be used. + +A list of URL

Re: [PR] Csrf filter improvements [tomcat]

2023-12-21 Thread via GitHub
michael-o commented on code in PR #681: URL: https://github.com/apache/tomcat/pull/681#discussion_r1434518590 ## webapps/docs/config/filter.xml: ## @@ -291,6 +291,13 @@ request. The default value is 403. + +A flag to enable or disable

Re: [PR] Csrf filter improvements [tomcat]

2023-12-21 Thread via GitHub
ChristopherSchultz commented on code in PR #681: URL: https://github.com/apache/tomcat/pull/681#discussion_r1434514917 ## webapps/docs/config/filter.xml: ## @@ -291,6 +291,13 @@ request. The default value is 403. + +A flag to enable or disable

Re: [PR] Csrf filter improvements [tomcat]

2023-12-21 Thread via GitHub
michael-o commented on code in PR #681: URL: https://github.com/apache/tomcat/pull/681#discussion_r1434513367 ## webapps/docs/config/filter.xml: ## @@ -319,6 +326,34 @@ of java.security.SecureRandom will be used. + +A list of URL patterns that

Re: [PR] Csrf filter improvements [tomcat]

2023-12-21 Thread via GitHub
michael-o commented on code in PR #681: URL: https://github.com/apache/tomcat/pull/681#discussion_r1434512783 ## java/org/apache/catalina/filters/CsrfPreventionFilter.java: ## @@ -198,15 +416,27 @@ protected boolean skipNonceCheck(HttpServletRequest request) {

Re: [PR] Csrf filter improvements [tomcat]

2023-12-21 Thread via GitHub
ChristopherSchultz commented on code in PR #681: URL: https://github.com/apache/tomcat/pull/681#discussion_r1434511388 ## webapps/docs/config/filter.xml: ## @@ -319,6 +326,34 @@ of java.security.SecureRandom will be used. + +A list of URL

Re: [PR] Csrf filter improvements [tomcat]

2023-12-21 Thread via GitHub
ChristopherSchultz commented on code in PR #681: URL: https://github.com/apache/tomcat/pull/681#discussion_r1434510673 ## java/org/apache/catalina/filters/CsrfPreventionFilter.java: ## @@ -198,15 +416,27 @@ protected boolean skipNonceCheck(HttpServletRequest request) {

Re: [PR] Csrf filter improvements [tomcat]

2023-12-20 Thread via GitHub
michael-o commented on code in PR #681: URL: https://github.com/apache/tomcat/pull/681#discussion_r1433225531 ## java/org/apache/catalina/filters/CsrfPreventionFilter.java: ## @@ -198,15 +416,27 @@ protected boolean skipNonceCheck(HttpServletRequest request) {

Re: [PR] Csrf filter improvements [tomcat]

2023-12-20 Thread via GitHub
ChristopherSchultz commented on PR #681: URL: https://github.com/apache/tomcat/pull/681#issuecomment-1864951885 > Re 4: I think that if one is wise enough to write a RegExp, they could use "|" to combine several patterns, and do not really need splitting by comma. Or do you envision a use

Re: [PR] Csrf filter improvements [tomcat]

2023-12-20 Thread via GitHub
kkolinko commented on PR #681: URL: https://github.com/apache/tomcat/pull/681#issuecomment-1864889547 Re 8: Whatever is easier. (Maybe it will be easier to extract some logic into an utility class and test that utility class. My concern is just that the logic is not trivial, is

Re: [PR] Csrf filter improvements [tomcat]

2023-12-20 Thread via GitHub
kkolinko commented on PR #681: URL: https://github.com/apache/tomcat/pull/681#issuecomment-1864873921 Re 4: I think that if one is wise enough to write a RegExp, they could use "|" to combine several patterns, and do not really need splitting by comma. Or do you envision a use case, where

Re: [PR] Csrf filter improvements [tomcat]

2023-12-20 Thread via GitHub
ChristopherSchultz commented on PR #681: URL: https://github.com/apache/tomcat/pull/681#issuecomment-1864828084 > 1. There are case-insensitive file systems out there... I wonder whether those default extensions should be treated case-insensitively. (If one is serving a web site from an

Re: [PR] Csrf filter improvements [tomcat]

2023-12-20 Thread via GitHub
kkolinko commented on PR #681: URL: https://github.com/apache/tomcat/pull/681#issuecomment-1864808958 1. There are case-insensitive file systems out there... I wonder whether those default extensions should be treated case-insensitively. (If one is serving a web site from an USB stick or a

Re: [PR] Csrf filter improvements [tomcat]

2023-12-20 Thread via GitHub
michael-o commented on code in PR #681: URL: https://github.com/apache/tomcat/pull/681#discussion_r1432909931 ## java/org/apache/catalina/filters/CsrfPreventionFilter.java: ## @@ -53,6 +58,25 @@ public class CsrfPreventionFilter extends CsrfPreventionFilterBase {

Re: [PR] Csrf filter improvements [tomcat]

2023-12-20 Thread via GitHub
ChristopherSchultz commented on code in PR #681: URL: https://github.com/apache/tomcat/pull/681#discussion_r1432880460 ## java/org/apache/catalina/filters/CsrfPreventionFilter.java: ## @@ -53,6 +58,25 @@ public class CsrfPreventionFilter extends CsrfPreventionFilterBase {

Re: [PR] Csrf filter improvements [tomcat]

2023-12-20 Thread via GitHub
ChristopherSchultz commented on code in PR #681: URL: https://github.com/apache/tomcat/pull/681#discussion_r1432856054 ## java/org/apache/catalina/filters/CsrfPreventionFilter.java: ## @@ -53,6 +58,25 @@ public class CsrfPreventionFilter extends CsrfPreventionFilterBase {

Re: [PR] Csrf filter improvements [tomcat]

2023-12-20 Thread via GitHub
ChristopherSchultz commented on code in PR #681: URL: https://github.com/apache/tomcat/pull/681#discussion_r1432853641 ## java/org/apache/catalina/filters/CsrfPreventionFilter.java: ## @@ -53,6 +58,25 @@ public class CsrfPreventionFilter extends CsrfPreventionFilterBase {

Re: [PR] Csrf filter improvements [tomcat]

2023-12-20 Thread via GitHub
michael-o commented on code in PR #681: URL: https://github.com/apache/tomcat/pull/681#discussion_r1432402971 ## java/org/apache/catalina/filters/CsrfPreventionFilter.java: ## @@ -53,6 +58,25 @@ public class CsrfPreventionFilter extends CsrfPreventionFilterBase {

Re: [PR] Csrf filter improvements [tomcat]

2023-12-19 Thread via GitHub
markt-asf commented on code in PR #681: URL: https://github.com/apache/tomcat/pull/681#discussion_r1431736198 ## java/org/apache/catalina/filters/CsrfPreventionFilter.java: ## @@ -53,6 +58,25 @@ public class CsrfPreventionFilter extends CsrfPreventionFilterBase {

Re: [PR] Csrf filter improvements [tomcat]

2023-12-19 Thread via GitHub
ChristopherSchultz commented on code in PR #681: URL: https://github.com/apache/tomcat/pull/681#discussion_r1431641166 ## java/org/apache/catalina/filters/CsrfPreventionFilter.java: ## @@ -53,6 +58,25 @@ public class CsrfPreventionFilter extends CsrfPreventionFilterBase {

Re: [PR] Csrf filter improvements [tomcat]

2023-12-19 Thread via GitHub
ChristopherSchultz commented on code in PR #681: URL: https://github.com/apache/tomcat/pull/681#discussion_r1431639832 ## java/org/apache/catalina/filters/CsrfPreventionFilter.java: ## @@ -53,6 +58,25 @@ public class CsrfPreventionFilter extends CsrfPreventionFilterBase {

Re: [PR] Csrf filter improvements [tomcat]

2023-12-19 Thread via GitHub
ChristopherSchultz commented on code in PR #681: URL: https://github.com/apache/tomcat/pull/681#discussion_r1431618064 ## java/org/apache/catalina/filters/CsrfPreventionFilter.java: ## @@ -53,6 +58,25 @@ public class CsrfPreventionFilter extends CsrfPreventionFilterBase {

Re: [PR] Csrf filter improvements [tomcat]

2023-12-19 Thread via GitHub
ChristopherSchultz commented on code in PR #681: URL: https://github.com/apache/tomcat/pull/681#discussion_r1431615348 ## java/org/apache/catalina/filters/CsrfPreventionFilter.java: ## @@ -53,6 +58,25 @@ public class CsrfPreventionFilter extends CsrfPreventionFilterBase {

<    1   2   3   4   5   6   7   8   9   10   >