https://bz.apache.org/bugzilla/show_bug.cgi?id=63833
Mark Thomas changed:
What|Removed |Added
Resolution|--- |FIXED
Status|NEW
On 10/16/19 7:55 AM, Mark Thomas wrote:
On 12/10/2019 00:03, Phil Steitz wrote:
How about adding the DBCP unit tests to the source tree? I suspect some
would have failed due to this change. If others think this is a good
idea, I could take a stab at genericising them and creating a PR to
On 10/16/19 7:55 AM, Mark Thomas wrote:
On 12/10/2019 00:03, Phil Steitz wrote:
How about adding the DBCP unit tests to the source tree? I suspect some
would have failed due to this change. If others think this is a good
idea, I could take a stab at genericising them and creating a PR to
On 12/10/2019 00:03, Phil Steitz wrote:
> How about adding the DBCP unit tests to the source tree? I suspect some
> would have failed due to this change. If others think this is a good
> idea, I could take a stab at genericising them and creating a PR to add
> them.
+1
I'd suggest several
https://bz.apache.org/bugzilla/show_bug.cgi?id=63833
--- Comment #6 from Konstantin Kolinko ---
(In reply to Christopher Schultz from comment #4)
It is much better to keep discussion in one place in Bugzilla, rather than
scattered among maybe several PRs.
I was wondering why this bug report is
https://bz.apache.org/bugzilla/show_bug.cgi?id=63833
--- Comment #5 from Guoxiong Li ---
I once submitted a PR to solve a issue. But the PR was not good enough to merge
so that the committer solved the issue by himself and closed my PR without
merging. As a result, I attach the patch to this BZ
https://bz.apache.org/bugzilla/show_bug.cgi?id=63833
--- Comment #4 from Christopher Schultz ---
Both reviews and edits can all be done in a PR. Why attach successive patches
to this BZ issue when you plan in issuing a PR anyway?
--
You are receiving this mail because:
You are the assignee for
https://bz.apache.org/bugzilla/show_bug.cgi?id=63833
Guoxiong Li changed:
What|Removed |Added
Attachment #36823|0 |1
is obsolete|
How about adding the DBCP unit tests to the source tree? I suspect some
would have failed due to this change. If others think this is a good
idea, I could take a stab at genericising them and creating a PR to add
them.
On 10/11/19 3:31 PM, bugzi...@apache.org wrote:
https://bz.apache.org/bugzilla/show_bug.cgi?id=63833
Phil Steitz changed:
What|Removed |Added
OS||All
--- Comment #2 from Phil Steitz
https://bz.apache.org/bugzilla/show_bug.cgi?id=63833
--- Comment #1 from Guoxiong Li ---
Created attachment 36823
--> https://bz.apache.org/bugzilla/attachment.cgi?id=36823=edit
A draft to solve this issue.
--
You are receiving this mail because:
You are the assignee for the bug.
11 matches
Mail list logo