Re: [GitHub] [tomcat] rmaucher commented on pull request #669: Relocate the useCompression check and apply parts back to back

2023-09-11 Thread Rémy Maucherat
On Sun, Sep 10, 2023 at 12:38 PM Mark Thomas wrote: > > On 10/09/2023 10:21, rmaucher (via GitHub) wrote: > > > > rmaucher commented on PR #669: > > URL: https://github.com/apache/tomcat/pull/669#issuecomment-1712763013 > > > > The ordering of these is often important. Please don't try to

Re: [GitHub] [tomcat] rmaucher commented on pull request #669: Relocate the useCompression check and apply parts back to back

2023-09-10 Thread Mark Thomas
On 10/09/2023 10:21, rmaucher (via GitHub) wrote: rmaucher commented on PR #669: URL: https://github.com/apache/tomcat/pull/669#issuecomment-1712763013 The ordering of these is often important. Please don't try to change this for cosmetic reason since it needs time and expertise to

[GitHub] [tomcat] rmaucher commented on pull request #669: Relocate the useCompression check and apply parts back to back

2023-09-10 Thread via GitHub
rmaucher commented on PR #669: URL: https://github.com/apache/tomcat/pull/669#issuecomment-1712763013 The ordering of these is often important. Please don't try to change this for cosmetic reason since it needs time and expertise to review. -- This is an automated message from the Apache