[GitHub] tomcat issue #121: restart.bat

2018-09-14 Thread akag98
Github user akag98 commented on the issue: https://github.com/apache/tomcat/pull/121 Thanks @kkolinko for your review... --- - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail

[GitHub] tomcat issue #121: restart.bat

2018-09-12 Thread kkolinko
Github user kkolinko commented on the issue: https://github.com/apache/tomcat/pull/121 1. This does not conform to code style. The "echo off" command and license header are missing. 2. This approach is naive and does not work. The "shutdown.bat" script does not stop Tomcat! It jus

[GitHub] tomcat issue #121: restart.bat

2018-09-12 Thread akag98
Github user akag98 commented on the issue: https://github.com/apache/tomcat/pull/121 Thanks @isapir for your review. I will surely look into that. Thanks :) --- - To unsubscribe, e-mail: dev-unsubscr...@tomc

[GitHub] tomcat issue #121: restart.bat

2018-09-12 Thread isapir
Github user isapir commented on the issue: https://github.com/apache/tomcat/pull/121 While I like the idea of adding an easy way to restart, I'd prefer to add a switch to startup rather than add a new script just for that, e.g. `startup -restart` or `catalina restart`. ---