[GitHub] tomcat pull request #42: Read events suspend/resume logic in websocket impl ...

2017-04-28 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/tomcat/pull/42 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] tomcat pull request #42: Read events suspend/resume logic in websocket impl ...

2017-02-09 Thread violetagg
Github user violetagg commented on a diff in the pull request: https://github.com/apache/tomcat/pull/42#discussion_r100424012 --- Diff: java/org/apache/tomcat/websocket/WsFrameBase.java --- @@ -687,6 +691,29 @@ protected Transformation getTransformation() { }

[GitHub] tomcat pull request #42: Read events suspend/resume logic in websocket impl ...

2017-02-08 Thread martin-g
Github user martin-g commented on a diff in the pull request: https://github.com/apache/tomcat/pull/42#discussion_r100054233 --- Diff: java/org/apache/tomcat/websocket/WsFrameBase.java --- @@ -687,6 +691,29 @@ protected Transformation getTransformation() { }

[GitHub] tomcat pull request #42: Read events suspend/resume logic in websocket impl ...

2017-02-08 Thread violetagg
Github user violetagg commented on a diff in the pull request: https://github.com/apache/tomcat/pull/42#discussion_r100015643 --- Diff: test/org/apache/tomcat/websocket/TestWsSessionSuspendResume.java --- @@ -0,0 +1,144 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] tomcat pull request #42: Read events suspend/resume logic in websocket impl ...

2017-02-08 Thread violetagg
Github user violetagg commented on a diff in the pull request: https://github.com/apache/tomcat/pull/42#discussion_r100015479 --- Diff: java/org/apache/tomcat/websocket/SuspendableMessageReceiver.java --- @@ -0,0 +1,24 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] tomcat pull request #42: Read events suspend/resume logic in websocket impl ...

2017-02-08 Thread violetagg
Github user violetagg commented on a diff in the pull request: https://github.com/apache/tomcat/pull/42#discussion_r100015036 --- Diff: java/org/apache/tomcat/websocket/server/WsFrameServer.java --- @@ -124,4 +135,56 @@ protected void sendMessageBinary(ByteBuffer msg, boolean

[GitHub] tomcat pull request #42: Read events suspend/resume logic in websocket impl ...

2017-02-08 Thread violetagg
Github user violetagg commented on a diff in the pull request: https://github.com/apache/tomcat/pull/42#discussion_r100015018 --- Diff: java/org/apache/tomcat/websocket/server/WsFrameServer.java --- @@ -56,21 +61,27 @@ public void onDataAvailable() throws IOException {

[GitHub] tomcat pull request #42: Read events suspend/resume logic in websocket impl ...

2017-02-08 Thread violetagg
Github user violetagg commented on a diff in the pull request: https://github.com/apache/tomcat/pull/42#discussion_r100014999 --- Diff: java/org/apache/tomcat/websocket/WsFrameClient.java --- @@ -116,12 +129,11 @@ protected Log getLog() { return log; }

[GitHub] tomcat pull request #42: Read events suspend/resume logic in websocket impl ...

2017-02-08 Thread violetagg
Github user violetagg commented on a diff in the pull request: https://github.com/apache/tomcat/pull/42#discussion_r100015008 --- Diff: java/org/apache/tomcat/websocket/WsFrameClient.java --- @@ -150,10 +162,11 @@ public void completed(Integer result, Void attachment) {

[GitHub] tomcat pull request #42: Read events suspend/resume logic in websocket impl ...

2017-02-08 Thread violetagg
Github user violetagg commented on a diff in the pull request: https://github.com/apache/tomcat/pull/42#discussion_r100014979 --- Diff: java/org/apache/tomcat/websocket/WsFrameClient.java --- @@ -58,31 +59,44 @@ void startInputProcessing() { private void

[GitHub] tomcat pull request #42: Read events suspend/resume logic in websocket impl ...

2017-02-08 Thread violetagg
Github user violetagg commented on a diff in the pull request: https://github.com/apache/tomcat/pull/42#discussion_r100014965 --- Diff: java/org/apache/tomcat/websocket/WsFrameClient.java --- @@ -58,31 +59,44 @@ void startInputProcessing() { private void

[GitHub] tomcat pull request #42: Read events suspend/resume logic in websocket impl ...

2017-02-07 Thread martin-g
Github user martin-g commented on a diff in the pull request: https://github.com/apache/tomcat/pull/42#discussion_r99924344 --- Diff: java/org/apache/tomcat/websocket/WsFrameClient.java --- @@ -150,10 +162,11 @@ public void completed(Integer result, Void attachment) {

[GitHub] tomcat pull request #42: Read events suspend/resume logic in websocket impl ...

2017-02-07 Thread martin-g
Github user martin-g commented on a diff in the pull request: https://github.com/apache/tomcat/pull/42#discussion_r99924840 --- Diff: java/org/apache/tomcat/websocket/server/WsFrameServer.java --- @@ -56,21 +61,27 @@ public void onDataAvailable() throws IOException {

[GitHub] tomcat pull request #42: Read events suspend/resume logic in websocket impl ...

2017-02-07 Thread martin-g
Github user martin-g commented on a diff in the pull request: https://github.com/apache/tomcat/pull/42#discussion_r99924904 --- Diff: java/org/apache/tomcat/websocket/server/WsFrameServer.java --- @@ -124,4 +135,56 @@ protected void sendMessageBinary(ByteBuffer msg, boolean last)

[GitHub] tomcat pull request #42: Read events suspend/resume logic in websocket impl ...

2017-02-07 Thread martin-g
Github user martin-g commented on a diff in the pull request: https://github.com/apache/tomcat/pull/42#discussion_r99923774 --- Diff: java/org/apache/tomcat/websocket/WsFrameClient.java --- @@ -58,31 +59,44 @@ void startInputProcessing() { private void

[GitHub] tomcat pull request #42: Read events suspend/resume logic in websocket impl ...

2017-02-07 Thread martin-g
Github user martin-g commented on a diff in the pull request: https://github.com/apache/tomcat/pull/42#discussion_r99928093 --- Diff: test/org/apache/tomcat/websocket/TestWsSessionSuspendResume.java --- @@ -0,0 +1,144 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] tomcat pull request #42: Read events suspend/resume logic in websocket impl ...

2017-02-07 Thread martin-g
Github user martin-g commented on a diff in the pull request: https://github.com/apache/tomcat/pull/42#discussion_r99924267 --- Diff: java/org/apache/tomcat/websocket/WsFrameClient.java --- @@ -116,12 +129,11 @@ protected Log getLog() { return log; }

[GitHub] tomcat pull request #42: Read events suspend/resume logic in websocket impl ...

2017-02-07 Thread martin-g
Github user martin-g commented on a diff in the pull request: https://github.com/apache/tomcat/pull/42#discussion_r99922783 --- Diff: java/org/apache/tomcat/websocket/SuspendableMessageReceiver.java --- @@ -0,0 +1,24 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] tomcat pull request #42: Read events suspend/resume logic in websocket impl ...

2017-02-07 Thread martin-g
Github user martin-g commented on a diff in the pull request: https://github.com/apache/tomcat/pull/42#discussion_r99924137 --- Diff: java/org/apache/tomcat/websocket/WsFrameClient.java --- @@ -58,31 +59,44 @@ void startInputProcessing() { private void

[GitHub] tomcat pull request #42: Read events suspend/resume logic in websocket impl ...

2017-02-07 Thread violetagg
GitHub user violetagg opened a pull request: https://github.com/apache/tomcat/pull/42 Read events suspend/resume logic in websocket impl to achieve backpressure Hi, Currently JSR356 provides possibility to add message handlers in order to receive web socket messages