Re: AprLifecycleListener broken since 9.0.38?

2021-04-08 Thread Rémy Maucherat
On Thu, Apr 8, 2021 at 1:01 PM Rainer Jung wrote: > Hi Remy, > > Filip wrote in the git commit message "Avoid having to load APR classes > in the Connector". If this is an important goal for TC 9, we would need > some other place during TC startup that loads the APR classes before the >

Re: AprLifecycleListener broken since 9.0.38?

2021-04-08 Thread Rainer Jung
Hi Remy, Filip wrote in the git commit message "Avoid having to load APR classes in the Connector". If this is an important goal for TC 9, we would need some other place during TC startup that loads the APR classes before the connector gets instantiated. I don't know, what a good place would

Re: AprLifecycleListener broken since 9.0.38?

2021-04-08 Thread Rémy Maucherat
On Wed, Apr 7, 2021 at 2:42 PM Rainer Jung wrote: > The only direct calls to AprStatus.isAprAvailable() outside of the > APRLifecycleListener itself are actually in Connector.java. Replacing > those by calls to the listener seems to work for me: > > diff --git

Re: AprLifecycleListener broken since 9.0.38?

2021-04-07 Thread Rémy Maucherat
On Wed, Apr 7, 2021 at 2:42 PM Rainer Jung wrote: > The only direct calls to AprStatus.isAprAvailable() outside of the > APRLifecycleListener itself are actually in Connector.java. Replacing > those by calls to the listener seems to work for me: > I get the idea. So I think the purpose of the

Re: AprLifecycleListener broken since 9.0.38?

2021-04-07 Thread Rainer Jung
The only direct calls to AprStatus.isAprAvailable() outside of the APRLifecycleListener itself are actually in Connector.java. Replacing those by calls to the listener seems to work for me: diff --git a/java/org/apache/catalina/connector/Connector.java

Re: AprLifecycleListener broken since 9.0.38?

2021-04-07 Thread Rainer Jung
I think the reason is: o.a.c.connector.Connector checks AprStatus.isAprAvailable(). It previously checked AprLifecycleListener.isAprAvailable(). The difference is, that the old AprLifecycleListener.isAprAvailable() triggers the init() of AprLifecycleListener, whereas

Re: AprLifecycleListener broken since 9.0.38?

2021-04-07 Thread Rainer Jung
Maybe related to f4dac6846c548144799b1c3f33aba4eb320a3413. Am 07.04.2021 um 13:53 schrieb Rainer Jung: Hi there, a colleague of mine observed a change in behavior starting with TC 9.0.38: until 9.0.37 the default server.xml with the connector protocol="HTTP/1.1", installed tcnative and

AprLifecycleListener broken since 9.0.38?

2021-04-07 Thread Rainer Jung
Hi there, a colleague of mine observed a change in behavior starting with TC 9.0.38: until 9.0.37 the default server.xml with the connector protocol="HTTP/1.1", installed tcnative and attribute useAprConnector="true" for the AprLifecycleListener actually starts an APR connector as documented