Re: svn commit: r1417194 - in /tomcat/trunk/java/org/apache/tomcat/util/buf: ByteChunk.java CharChunk.java

2012-12-09 Thread Konstantin Kolinko
2012/12/8 Caldarale, Charles R chuck.caldar...@unisys.com: From: Christopher Schultz [mailto:ch...@christopherschultz.net] Subject: Re: svn commit: r1417194 - in /tomcat/trunk/java/org/apache/tomcat/util/buf: ByteChunk.java CharChunk.java On 12/4/12 4:21 PM, ma...@apache.org wrote

Re: svn commit: r1417194 - in /tomcat/trunk/java/org/apache/tomcat/util/buf: ByteChunk.java CharChunk.java

2012-12-08 Thread Mark Thomas
Christopher Schultz ch...@christopherschultz.net wrote: Mark, // Hash code +@Override +public int hashCode() { +if (hasHashCode) { +return hashCode; +} +int code = 0; + +code =

Re: svn commit: r1417194 - in /tomcat/trunk/java/org/apache/tomcat/util/buf: ByteChunk.java CharChunk.java

2012-12-07 Thread Christopher Schultz
Mark, On 12/4/12 4:21 PM, ma...@apache.org wrote: +private int hashCode=0; +// did we compute the hashcode ? +private boolean hasHashCode = false; Should hashCode and hasHashCode be volatile? // Hash code +@Override +

RE: svn commit: r1417194 - in /tomcat/trunk/java/org/apache/tomcat/util/buf: ByteChunk.java CharChunk.java

2012-12-07 Thread Caldarale, Charles R
From: Christopher Schultz [mailto:ch...@christopherschultz.net] Subject: Re: svn commit: r1417194 - in /tomcat/trunk/java/org/apache/tomcat/util/buf: ByteChunk.java CharChunk.java On 12/4/12 4:21 PM, ma...@apache.org wrote: +private int hashCode=0; +// did we compute