Regarding c:forEach and memory usage

2011-01-27 Thread Christopher Schultz
All, Today's (duplicate) bug report about held references in JSTL tags has me thinking. What is the resistance to fixing the problem of object retention in these tags? JSP 1.8.2 says that all page-scoped objects are released after the response is written or the request is forwarded to another

Re: Regarding c:forEach and memory usage

2011-01-27 Thread Mark Thomas
On 27/01/2011 16:54, Christopher Schultz wrote: I'd love to hear some comments. It is a simple trade-off. Enable pooling, use more memory, have less GC vs Disable pooling, use less memory, have more GC The memory/GC required will vary depending on which tags are used and how they are used. I

Re: Regarding c:forEach and memory usage

2011-01-27 Thread Kris Schneider
On Thu, Jan 27, 2011 at 11:54 AM, Christopher Schultz ch...@christopherschultz.net wrote: ... I'd love to hear some comments. Some additional background: https://issues.apache.org/bugzilla/show_bug.cgi?id=33934 I haven't looked at the patch, so I'm not sure exactly how that got solved... --

Re: Regarding c:forEach and memory usage

2011-01-27 Thread Jeremy Boynes
It also interacts with tag reinitialization as described here: https://issues.apache.org/bugzilla/show_bug.cgi?id=49589 in that we hang on to the value when the tag is in the pool only to clear it when we use it. I think there are other optimizations that could be done to forEach but

Re: Regarding c:forEach and memory usage

2011-01-27 Thread Jeremy Boynes
On Jan 27, 2011, at 10:14 AM, Kris Schneider wrote: On Thu, Jan 27, 2011 at 11:54 AM, Christopher Schultz ch...@christopherschultz.net wrote: ... I'd love to hear some comments. Some additional background: https://issues.apache.org/bugzilla/show_bug.cgi?id=33934 I haven't looked at the