Re: svn commit: r1132362 - in /tomcat/trunk/java/org/apache/coyote/http11: AbstractHttp11Processor.java Http11AprProcessor.java Http11NioProcessor.java Http11Processor.java

2011-06-06 Thread Mark Thomas
On 06/06/2011 06:54, Konstantin Kolinko wrote: 2011/6/6 Mark Thomas ma...@apache.org: On 05/06/2011 17:47, Rainer Jung wrote: +for (int i = valueL - 1; i colonPos; i--) { +int charValue = HexUtils.getDec(valueB[i + valueS]); Any idea, why hex digits (including

svn commit: r1132362 - in /tomcat/trunk/java/org/apache/coyote/http11: AbstractHttp11Processor.java Http11AprProcessor.java Http11NioProcessor.java Http11Processor.java

2011-06-05 Thread markt
Author: markt Date: Sun Jun 5 10:06:49 2011 New Revision: 1132362 URL: http://svn.apache.org/viewvc?rev=1132362view=rev Log: Pull up parseHost Modified: tomcat/trunk/java/org/apache/coyote/http11/AbstractHttp11Processor.java

Re: svn commit: r1132362 - in /tomcat/trunk/java/org/apache/coyote/http11: AbstractHttp11Processor.java Http11AprProcessor.java Http11NioProcessor.java Http11Processor.java

2011-06-05 Thread Rainer Jung
Hi Mark, On 05.06.2011 12:06, ma...@apache.org wrote: Modified: tomcat/trunk/java/org/apache/coyote/http11/AbstractHttp11Processor.java URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/coyote/http11/AbstractHttp11Processor.java?rev=1132362r1=1132361r2=1132362view=diff

Re: svn commit: r1132362 - in /tomcat/trunk/java/org/apache/coyote/http11: AbstractHttp11Processor.java Http11AprProcessor.java Http11NioProcessor.java Http11Processor.java

2011-06-05 Thread Mark Thomas
On 05/06/2011 14:09, Rainer Jung wrote: On 05.06.2011 12:06, ma...@apache.org wrote: Modified: tomcat/trunk/java/org/apache/coyote/http11/AbstractHttp11Processor.java URL:

Re: svn commit: r1132362 - in /tomcat/trunk/java/org/apache/coyote/http11: AbstractHttp11Processor.java Http11AprProcessor.java Http11NioProcessor.java Http11Processor.java

2011-06-05 Thread Rainer Jung
+for (int i = valueL - 1; i colonPos; i--) { +int charValue = HexUtils.getDec(valueB[i + valueS]); Any idea, why hex digits (including a-f, A-F) are allowed in port numbers? I know you only moved that code, but it reminded me of an observation I made long ago

Re: svn commit: r1132362 - in /tomcat/trunk/java/org/apache/coyote/http11: AbstractHttp11Processor.java Http11AprProcessor.java Http11NioProcessor.java Http11Processor.java

2011-06-05 Thread Mark Thomas
On 05/06/2011 17:47, Rainer Jung wrote: +for (int i = valueL - 1; i colonPos; i--) { +int charValue = HexUtils.getDec(valueB[i + valueS]); Any idea, why hex digits (including a-f, A-F) are allowed in port numbers? I know you only moved that code, but it reminded

Re: svn commit: r1132362 - in /tomcat/trunk/java/org/apache/coyote/http11: AbstractHttp11Processor.java Http11AprProcessor.java Http11NioProcessor.java Http11Processor.java

2011-06-05 Thread Konstantin Kolinko
2011/6/6 Mark Thomas ma...@apache.org: On 05/06/2011 17:47, Rainer Jung wrote: +            for (int i = valueL - 1; i colonPos; i--) { +                int charValue = HexUtils.getDec(valueB[i + valueS]); Any idea, why hex digits (including a-f, A-F) are allowed in port numbers? Probably