Re: JK 1.2.41

2015-07-27 Thread Mark Thomas
On 27/07/2015 00:05, George Stanchev wrote: > Is there anyone working on connectors or Apache is doing just > emergency security releases? As with all ASF projects, committers work on projects when they want to and when they have time to. At the moment, I'm working on a 1.2.41 release (as you can

[Bug 57836] Empty REMOTE_USER is translated to ""

2015-07-27 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=57836 Mark Thomas changed: What|Removed |Added OS||All --- Comment #2 from Mark Thomas ---

[Bug 58076] Embedded tomcat would not find tlds on open dependency artifacts

2015-07-27 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=58076 Mark Thomas changed: What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|---

svn commit: r1692847 - /tomcat/jk/trunk/native/iis/jk_isapi_plugin.c

2015-07-27 Thread markt
Author: markt Date: Mon Jul 27 09:34:45 2015 New Revision: 1692847 URL: http://svn.apache.org/r1692847 Log: Fix formatting nit Modified: tomcat/jk/trunk/native/iis/jk_isapi_plugin.c Modified: tomcat/jk/trunk/native/iis/jk_isapi_plugin.c URL: http://svn.apache.org/viewvc/tomcat/jk/trunk/nati

svn commit: r1692849 - /tomcat/trunk/java/org/apache/catalina/core/ApplicationContext.java

2015-07-27 Thread markt
Author: markt Date: Mon Jul 27 09:42:58 2015 New Revision: 1692849 URL: http://svn.apache.org/r1692849 Log: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=58179 Fix atomicity violation (concurrent requests could both see null as the old value) Modified: tomcat/trunk/java/org/apache/catal

svn commit: r1692850 - in /tomcat/tc8.0.x/trunk: ./ java/org/apache/catalina/core/ApplicationContext.java webapps/docs/changelog.xml

2015-07-27 Thread markt
Author: markt Date: Mon Jul 27 09:48:53 2015 New Revision: 1692850 URL: http://svn.apache.org/r1692850 Log: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=58179 Fix atomicity violation (concurrent requests could both see null as the old value) Modified: tomcat/tc8.0.x/trunk/ (props cha

buildbot failure in ASF Buildbot on tomcat-trunk

2015-07-27 Thread buildbot
The Buildbot has detected a new failure on builder tomcat-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-trunk/builds/74 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The AnyBranchSchedule

svn commit: r1692858 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/core/ApplicationContext.java webapps/docs/changelog.xml

2015-07-27 Thread markt
Author: markt Date: Mon Jul 27 10:24:29 2015 New Revision: 1692858 URL: http://svn.apache.org/r1692858 Log: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=58179 Fix atomicity violation (concurrent requests could both see null as the old value) Modified: tomcat/tc7.0.x/trunk/ (props cha

[Bug 58179] Atomicity violation

2015-07-27 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=58179 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

svn commit: r1692859 - in /tomcat/tc8.0.x/trunk: ./ java/org/apache/catalina/startup/HostConfig.java

2015-07-27 Thread markt
Author: markt Date: Mon Jul 27 10:29:51 2015 New Revision: 1692859 URL: http://svn.apache.org/r1692859 Log: Remove unnecessary null check (Eclipse is getting better at following complex code paths) Modified: tomcat/tc8.0.x/trunk/ (props changed) tomcat/tc8.0.x/trunk/java/org/apache/cat

svn commit: r1692860 - in /tomcat/tc8.0.x/trunk: ./ java/org/apache/tomcat/util/net/NioSelectorPool.java java/org/apache/tomcat/websocket/WsWebSocketContainer.java

2015-07-27 Thread markt
Author: markt Date: Mon Jul 27 10:30:34 2015 New Revision: 1692860 URL: http://svn.apache.org/r1692860 Log: Remove unnecessary suppressWarnings Modified: tomcat/tc8.0.x/trunk/ (props changed) tomcat/tc8.0.x/trunk/java/org/apache/tomcat/util/net/NioSelectorPool.java tomcat/tc8.0.x/t

svn commit: r1692861 - in /tomcat/tc8.0.x/trunk: ./ res/ide-support/eclipse/java-compiler-errors-warnings.txt

2015-07-27 Thread markt
Author: markt Date: Mon Jul 27 10:31:02 2015 New Revision: 1692861 URL: http://svn.apache.org/r1692861 Log: No changes to available options in Mars (we should review those that are currently disabled) Modified: tomcat/tc8.0.x/trunk/ (props changed) tomcat/tc8.0.x/trunk/res/ide-support

svn commit: r1692863 - in /tomcat/tc8.0.x/trunk: ./ java/org/apache/jasper/JspC.java webapps/docs/changelog.xml

2015-07-27 Thread markt
Author: markt Date: Mon Jul 27 10:33:50 2015 New Revision: 1692863 URL: http://svn.apache.org/r1692863 Log: Fix resource leak spotted by Eclipse by using try-with-resources Modified: tomcat/tc8.0.x/trunk/ (props changed) tomcat/tc8.0.x/trunk/java/org/apache/jasper/JspC.java tomcat/t

svn commit: r1692865 - /tomcat/trunk/java/org/apache/tomcat/websocket/LocalStrings.properties

2015-07-27 Thread markt
Author: markt Date: Mon Jul 27 10:42:38 2015 New Revision: 1692865 URL: http://svn.apache.org/r1692865 Log: Fix typo Modified: tomcat/trunk/java/org/apache/tomcat/websocket/LocalStrings.properties Modified: tomcat/trunk/java/org/apache/tomcat/websocket/LocalStrings.properties URL: http://sv

svn commit: r1692866 - in /tomcat/tc8.0.x/trunk: ./ java/org/apache/catalina/tribes/group/ java/org/apache/catalina/tribes/group/interceptors/ java/org/apache/catalina/tribes/io/ java/org/apache/catal

2015-07-27 Thread markt
Author: markt Date: Mon Jul 27 10:44:41 2015 New Revision: 1692866 URL: http://svn.apache.org/r1692866 Log: Auto-boxing warnings Modified: tomcat/tc8.0.x/trunk/ (props changed) tomcat/tc8.0.x/trunk/java/org/apache/catalina/tribes/group/ChannelCoordinator.java tomcat/tc8.0.x/trunk/

svn commit: r1692867 - /tomcat/tc8.0.x/trunk/java/org/apache/tomcat/websocket/WsWebSocketContainer.java

2015-07-27 Thread markt
Author: markt Date: Mon Jul 27 10:47:31 2015 New Revision: 1692867 URL: http://svn.apache.org/r1692867 Log: Stop Eclipse complaining Modified: tomcat/tc8.0.x/trunk/java/org/apache/tomcat/websocket/WsWebSocketContainer.java Modified: tomcat/tc8.0.x/trunk/java/org/apache/tomcat/websocket/WsW

buildbot exception in ASF Buildbot on tomcat-8-trunk

2015-07-27 Thread buildbot
The Buildbot has detected a build exception on builder tomcat-8-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-8-trunk/builds/32 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The AnyBranch

buildbot failure in ASF Buildbot on tomcat-8-trunk

2015-07-27 Thread buildbot
The Buildbot has detected a new failure on builder tomcat-8-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-8-trunk/builds/31 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The AnyBranchSche

buildbot exception in ASF Buildbot on tomcat-trunk

2015-07-27 Thread buildbot
The Buildbot has detected a build exception on builder tomcat-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-trunk/builds/75 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The AnyBranchSche

svn commit: r1692876 - /tomcat/trunk/res/ide-support/eclipse/java-compiler-errors-warnings.txt

2015-07-27 Thread markt
Author: markt Date: Mon Jul 27 13:01:32 2015 New Revision: 1692876 URL: http://svn.apache.org/r1692876 Log: Need to ignore this one given that we ignore exceptions all over the place. Modified: tomcat/trunk/res/ide-support/eclipse/java-compiler-errors-warnings.txt Modified: tomcat/trunk/res/

Re: svn commit: r1690035 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/ant/ java/org/apache/catalina/ha/deploy/ webapps/docs/

2015-07-27 Thread Mark Thomas
On 09/07/2015 18:50, Violeta Georgieva wrote: > 2015-07-09 15:56 GMT+03:00 Konstantin Kolinko : >> Reviewing DeployTask.java further (the code touched by >> http://svn.apache.org/r1689941 ) >> >> For current trunk: >> > http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/ant/Deplo

svn commit: r1692894 - in /tomcat/trunk: ./ res/ide-support/eclipse/ res/ide-support/netbeans/ res/maven/

2015-07-27 Thread markt
Author: markt Date: Mon Jul 27 15:13:17 2015 New Revision: 1692894 URL: http://svn.apache.org/r1692894 Log: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=58111 Update to Eclipse 4.5 Modified: tomcat/trunk/build.properties.default tomcat/trunk/res/ide-support/eclipse/eclipse.classpath

[Bug 58111] Update to Eclipse ECJ 4.5

2015-07-27 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=58111 --- Comment #2 from Mark Thomas --- I've updated Tomcat trunk. We'll see how that goes in the unit tests etc before back-porting the update to 8.0.x. -- You are receiving this mail because: You are the assignee for the bug. -

svn commit: r1692896 - /tomcat/trunk/java/org/apache/jasper/compiler/JDTCompiler.java

2015-07-27 Thread markt
Author: markt Date: Mon Jul 27 15:18:49 2015 New Revision: 1692896 URL: http://svn.apache.org/r1692896 Log: Add Java 9 support for JSPs Modified: tomcat/trunk/java/org/apache/jasper/compiler/JDTCompiler.java Modified: tomcat/trunk/java/org/apache/jasper/compiler/JDTCompiler.java URL: http:/

buildbot failure in ASF Buildbot on tomcat-trunk

2015-07-27 Thread buildbot
The Buildbot has detected a new failure on builder tomcat-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-trunk/builds/77 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The AnyBranchSchedule

[Bug 58103] NIO2 warning: Incorrect connection count, multiple socket.close called on the same socket.

2015-07-27 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=58103 --- Comment #8 from Mark Thomas --- I'll take a look at this. I think we do need to restore maxConnections support for NIO2 (probably with the limit disabled by default). While I am confident that NIO2 can scale to as many connections as the s

svn commit: r1692901 - /tomcat/trunk/java/org/apache/tomcat/util/net/Nio2Endpoint.java

2015-07-27 Thread markt
Author: markt Date: Mon Jul 27 15:44:34 2015 New Revision: 1692901 URL: http://svn.apache.org/r1692901 Log: Disable maxConnections by default for NIO2 but still allow it to be set rather than forcibly disabling maxConnections support with NIO2. Modified: tomcat/trunk/java/org/apache/tomcat/u

RE: JK 1.2.41

2015-07-27 Thread George Stanchev
Thanks for your reply Mark. I know how OSS projects work. I was just hoping that this issue, being rather small in fix-scope and large in impact-scope would be picked up for the next release. I know also that you're not the person usually maintaining the Connectors so I appreciate the new relea

[Bug 58103] NIO2 warning: Incorrect connection count, multiple socket.close called on the same socket.

2015-07-27 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=58103 --- Comment #9 from Mark Thomas --- Quick question. Do you see this on trunk or just 8.0.x? -- You are receiving this mail because: You are the assignee for the bug. - To un

[Bug 58103] NIO2 warning: Incorrect connection count, multiple socket.close called on the same socket.

2015-07-27 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=58103 --- Comment #10 from Mark Thomas --- I've just answered my own question. Running this test case once on Windows triggers the warning message once a second (roughly). Given how easy it is to reproduce, a fix should be (fairly) easy to track down

Running with SecurityManager: CometProcessor servlets throw NoSuchMethodException

2015-07-27 Thread Johno Crawford
Hi all, As of Tomcat 7.0.52 a bug was introduced which caused a regression with CometProcessor servlets being served on Tomcat running with a SecurityManager. I have created a bug report [1] and attached a patch with a proposed fix. If there is anything else you need from me to push this issu

[Bug 58116] [PATCH] Running with SecurityManager: CometProcessor servlets throw NoSuchMethodException

2015-07-27 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=58116 --- Comment #3 from Konstantin Kolinko --- 1. This is reproducible with examples webapp (comet chat example) 2. I think the same issue exists with Filter and CometFilter. I do not have an example though. It needs a fix. 3. The patch looks as