svn commit: r1807713 - in /tomcat/trunk: java/org/apache/tomcat/util/net/openssl/OpenSSLConf.java java/org/apache/tomcat/util/net/openssl/OpenSSLConfCmd.java test/org/apache/tomcat/util/net/TestSSLHos

2017-09-08 Thread markt
Author: markt Date: Fri Sep 8 11:12:13 2017 New Revision: 1807713 URL: http://svn.apache.org/viewvc?rev=1807713=rev Log: Make SSLHostConfig Serializable again Spotted by FindBugs but add a test case to ensure the expected behaviour. Modified:

svn commit: r1807716 - in /tomcat/tc8.5.x/trunk: ./ java/org/apache/tomcat/util/codec/ java/org/apache/tomcat/util/codec/binary/BaseNCodec.java

2017-09-08 Thread markt
Author: markt Date: Fri Sep 8 11:15:47 2017 New Revision: 1807716 URL: http://svn.apache.org/viewvc?rev=1807716=rev Log: Remove unused code reported by Findbugs Modified: tomcat/tc8.5.x/trunk/ (props changed) tomcat/tc8.5.x/trunk/java/org/apache/tomcat/util/codec/ (props changed)

svn commit: r1807715 - /tomcat/trunk/java/org/apache/tomcat/util/codec/binary/BaseNCodec.java

2017-09-08 Thread markt
Author: markt Date: Fri Sep 8 11:15:22 2017 New Revision: 1807715 URL: http://svn.apache.org/viewvc?rev=1807715=rev Log: Remove unused code reported by Findbugs Modified: tomcat/trunk/java/org/apache/tomcat/util/codec/binary/BaseNCodec.java Modified:

svn commit: r1807729 - /tomcat/trunk/test/org/apache/tomcat/util/net/openssl/TestOpenSSLConf.java

2017-09-08 Thread rjung
Author: rjung Date: Fri Sep 8 12:09:33 2017 New Revision: 1807729 URL: http://svn.apache.org/viewvc?rev=1807729=rev Log: Add unit test for OpenSSLConfCmd. The test is skipped for Java connectors with JSSE sslImplementation. Added:

Re: svn commit: r1807693 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/tomcat/websocket/PerMessageDeflate.java test/org/apache/tomcat/websocket/TestPerMessageDeflate.java webapps/docs/changelog.xml

2017-09-08 Thread Mark Thomas
On 08/09/17 13:23, Konstantin Kolinko wrote: > 2017-09-08 12:06 GMT+03:00 : >> Author: markt >> Date: Fri Sep 8 09:06:47 2017 >> New Revision: 1807693 >> >> URL: http://svn.apache.org/viewvc?rev=1807693=rev >> Log: >> Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=61491 >>

svn commit: r1807755 - /tomcat/trunk/test/org/apache/tomcat/util/net/openssl/TestOpenSSLConf.java

2017-09-08 Thread markt
Author: markt Date: Fri Sep 8 13:13:42 2017 New Revision: 1807755 URL: http://svn.apache.org/viewvc?rev=1807755=rev Log: Handle possible NPE in unit test Modified: tomcat/trunk/test/org/apache/tomcat/util/net/openssl/TestOpenSSLConf.java Modified:

svn commit: r1807757 - in /tomcat/tc8.5.x/trunk: ./ test/org/apache/tomcat/util/net/openssl/TestOpenSSLConf.java

2017-09-08 Thread markt
Author: markt Date: Fri Sep 8 13:18:54 2017 New Revision: 1807757 URL: http://svn.apache.org/viewvc?rev=1807757=rev Log: Handle possible NPE in unit test Modified: tomcat/tc8.5.x/trunk/ (props changed) tomcat/tc8.5.x/trunk/test/org/apache/tomcat/util/net/openssl/TestOpenSSLConf.java

svn commit: r1807714 - in /tomcat/tc8.5.x/trunk: ./ java/org/apache/tomcat/util/net/openssl/OpenSSLConf.java java/org/apache/tomcat/util/net/openssl/OpenSSLConfCmd.java test/org/apache/tomcat/util/net

2017-09-08 Thread markt
Author: markt Date: Fri Sep 8 11:12:43 2017 New Revision: 1807714 URL: http://svn.apache.org/viewvc?rev=1807714=rev Log: Make SSLHostConfig Serializable again Spotted by FindBugs but add a test case to ensure the expected behaviour. Modified: tomcat/tc8.5.x/trunk/ (props changed)

svn commit: r1807756 - in /tomcat/tc8.5.x/trunk: ./ test/org/apache/tomcat/util/net/openssl/TestOpenSSLConf.java

2017-09-08 Thread markt
Author: markt Date: Fri Sep 8 13:17:03 2017 New Revision: 1807756 URL: http://svn.apache.org/viewvc?rev=1807756=rev Log: Fix IDE nag Modified: tomcat/tc8.5.x/trunk/ (props changed) tomcat/tc8.5.x/trunk/test/org/apache/tomcat/util/net/openssl/TestOpenSSLConf.java Propchange:

buildbot success in on tomcat-trunk

2017-09-08 Thread buildbot
The Buildbot has detected a restored build on builder tomcat-trunk while building . Full details are available at: https://ci.apache.org/builders/tomcat-trunk/builds/2679 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The AnyBranchScheduler

svn commit: r1807733 - in /tomcat/tc8.5.x/trunk: ./ test/org/apache/tomcat/util/net/openssl/TestOpenSSLConf.java

2017-09-08 Thread rjung
Author: rjung Date: Fri Sep 8 12:16:37 2017 New Revision: 1807733 URL: http://svn.apache.org/viewvc?rev=1807733=rev Log: Add unit test for OpenSSLConfCmd. The test is skipped for Java connectors with JSSE sslImplementation. Backport of r1807729 from trunk. Added:

buildbot failure in on tomcat-trunk

2017-09-08 Thread buildbot
The Buildbot has detected a new failure on builder tomcat-trunk while building . Full details are available at: https://ci.apache.org/builders/tomcat-trunk/builds/2675 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The AnyBranchScheduler

Re: svn commit: r1807693 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/tomcat/websocket/PerMessageDeflate.java test/org/apache/tomcat/websocket/TestPerMessageDeflate.java webapps/docs/changelog.xml

2017-09-08 Thread Konstantin Kolinko
2017-09-08 12:06 GMT+03:00 : > Author: markt > Date: Fri Sep 8 09:06:47 2017 > New Revision: 1807693 > > URL: http://svn.apache.org/viewvc?rev=1807693=rev > Log: > Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=61491 > When using the permessage-deflate extension, correctly

Re: svn commit: r1807755 - /tomcat/trunk/test/org/apache/tomcat/util/net/openssl/TestOpenSSLConf.java

2017-09-08 Thread Rainer Jung
Thanks, you beat me by 10 minutes (and your solution is nicer than mine). Please do not wait for the docs with tagging. I have a bigger SSL docs change in mind which I'll not finish today. Tanks and Regards, Rainer Am 08.09.2017 um 15:13 schrieb ma...@apache.org: Author: markt Date: Fri

[Bug 61503] New: JarWarResourceSet finds META-INF/ jar entries that do not exist leading to FileNotFoundException

2017-09-08 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=61503 Bug ID: 61503 Summary: JarWarResourceSet finds META-INF/ jar entries that do not exist leading to FileNotFoundException Product: Tomcat 8 Version: 8.5.14 Hardware: PC

svn commit: r1807747 - /tomcat/trunk/res/findbugs/filter-false-positives.xml

2017-09-08 Thread markt
Author: markt Date: Fri Sep 8 12:49:53 2017 New Revision: 1807747 URL: http://svn.apache.org/viewvc?rev=1807747=rev Log: Fix a handful of SQL related false positives Modified: tomcat/trunk/res/findbugs/filter-false-positives.xml Modified:

svn commit: r1807751 - /tomcat/trunk/test/org/apache/tomcat/util/net/openssl/TestOpenSSLConf.java

2017-09-08 Thread markt
Author: markt Date: Fri Sep 8 13:05:57 2017 New Revision: 1807751 URL: http://svn.apache.org/viewvc?rev=1807751=rev Log: Fix IDE nag Modified: tomcat/trunk/test/org/apache/tomcat/util/net/openssl/TestOpenSSLConf.java Modified:

svn commit: r1807742 - /tomcat/trunk/java/org/apache/tomcat/util/http/fileupload/FileUploadBase.java

2017-09-08 Thread markt
Author: markt Date: Fri Sep 8 12:44:09 2017 New Revision: 1807742 URL: http://svn.apache.org/viewvc?rev=1807742=rev Log: Drop unused code identified by FindBugs Modified: tomcat/trunk/java/org/apache/tomcat/util/http/fileupload/FileUploadBase.java Modified:

svn commit: r1807700 - in /tomcat/tc8.0.x/trunk: ./ conf/web.xml java/org/apache/catalina/servlets/CGIServlet.java webapps/docs/cgi-howto.xml webapps/docs/changelog.xml

2017-09-08 Thread markt
Author: markt Date: Fri Sep 8 09:40:32 2017 New Revision: 1807700 URL: http://svn.apache.org/viewvc?rev=1807700=rev Log: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=61489 When using the CGI servlet, make the generation of command line arguments from the query string (as per section 4.4

svn commit: r1807690 - in /tomcat/tc8.0.x/trunk: ./ java/org/apache/tomcat/websocket/PerMessageDeflate.java test/org/apache/tomcat/websocket/TestPerMessageDeflate.java webapps/docs/changelog.xml

2017-09-08 Thread markt
Author: markt Date: Fri Sep 8 08:58:56 2017 New Revision: 1807690 URL: http://svn.apache.org/viewvc?rev=1807690=rev Log: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=61491 When using the permessage-deflate extension, correctly handle the sending of empty messages after non-empty messages

buildbot failure in on tomcat-7-trunk

2017-09-08 Thread buildbot
The Buildbot has detected a new failure on builder tomcat-7-trunk while building . Full details are available at: https://ci.apache.org/builders/tomcat-7-trunk/builds/866 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The AnyBranchScheduler

svn commit: r1807703 - in /tomcat/tc7.0.x/trunk: ./ conf/web.xml java/org/apache/catalina/servlets/CGIServlet.java webapps/docs/cgi-howto.xml webapps/docs/changelog.xml

2017-09-08 Thread markt
Author: markt Date: Fri Sep 8 09:43:04 2017 New Revision: 1807703 URL: http://svn.apache.org/viewvc?rev=1807703=rev Log: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=61489 When using the CGI servlet, make the generation of command line arguments from the query string (as per section 4.4

svn commit: r1807693 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/tomcat/websocket/PerMessageDeflate.java test/org/apache/tomcat/websocket/TestPerMessageDeflate.java webapps/docs/changelog.xml

2017-09-08 Thread markt
Author: markt Date: Fri Sep 8 09:06:47 2017 New Revision: 1807693 URL: http://svn.apache.org/viewvc?rev=1807693=rev Log: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=61491 When using the permessage-deflate extension, correctly handle the sending of empty messages after non-empty messages

[Bug 61491] IllegalArgumentException thrown by PerMessageDeflate sendMessagePart()

2017-09-08 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=61491 Mark Thomas changed: What|Removed |Added Resolution|--- |FIXED

svn commit: r1807698 - in /tomcat/trunk: conf/web.xml java/org/apache/catalina/servlets/CGIServlet.java webapps/docs/cgi-howto.xml webapps/docs/changelog.xml

2017-09-08 Thread markt
Author: markt Date: Fri Sep 8 09:36:08 2017 New Revision: 1807698 URL: http://svn.apache.org/viewvc?rev=1807698=rev Log: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=61489 When using the CGI servlet, make the generation of command line arguments from the query string (as per section 4.4

[Bug 61394] NIO/NIO2 + OpenSSL renegotiation doesn't send list of CAs to user agent

2017-09-08 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=61394 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED

svn commit: r1807699 - in /tomcat/tc8.5.x/trunk: ./ conf/web.xml java/org/apache/catalina/servlets/CGIServlet.java webapps/docs/cgi-howto.xml webapps/docs/changelog.xml

2017-09-08 Thread markt
Author: markt Date: Fri Sep 8 09:39:06 2017 New Revision: 1807699 URL: http://svn.apache.org/viewvc?rev=1807699=rev Log: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=61489 When using the CGI servlet, make the generation of command line arguments from the query string (as per section 4.4

svn commit: r1807689 - in /tomcat/tc8.5.x/trunk: ./ java/org/apache/tomcat/websocket/PerMessageDeflate.java test/org/apache/tomcat/websocket/TestPerMessageDeflate.java webapps/docs/changelog.xml

2017-09-08 Thread markt
Author: markt Date: Fri Sep 8 08:53:46 2017 New Revision: 1807689 URL: http://svn.apache.org/viewvc?rev=1807689=rev Log: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=61491 When using the permessage-deflate extension, correctly handle the sending of empty messages after non-empty messages

svn commit: r1807696 - /tomcat/tc7.0.x/trunk/test/org/apache/tomcat/websocket/TestPerMessageDeflate.java

2017-09-08 Thread markt
Author: markt Date: Fri Sep 8 09:21:41 2017 New Revision: 1807696 URL: http://svn.apache.org/viewvc?rev=1807696=rev Log: Fix imports Modified: tomcat/tc7.0.x/trunk/test/org/apache/tomcat/websocket/TestPerMessageDeflate.java Modified:

svn commit: r1807686 - in /tomcat/trunk: java/org/apache/tomcat/websocket/PerMessageDeflate.java test/org/apache/tomcat/websocket/TestPerMessageDeflate.java webapps/docs/changelog.xml

2017-09-08 Thread markt
Author: markt Date: Fri Sep 8 08:50:30 2017 New Revision: 1807686 URL: http://svn.apache.org/viewvc?rev=1807686=rev Log: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=61491 When using the permessage-deflate extension, correctly handle the sending of empty messages after non-empty messages

[Bug 61489] Disable creation of command line parameters from GET parameters in the URL for CGIServlet

2017-09-08 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=61489 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED

svn commit: r1807769 - in /tomcat/tc8.5.x/trunk: ./ res/findbugs/filter-false-positives.xml

2017-09-08 Thread markt
Author: markt Date: Fri Sep 8 14:34:03 2017 New Revision: 1807769 URL: http://svn.apache.org/viewvc?rev=1807769=rev Log: Fix a handful of SQL related false positives Modified: tomcat/tc8.5.x/trunk/ (props changed) tomcat/tc8.5.x/trunk/res/findbugs/filter-false-positives.xml

svn commit: r1807770 - in /tomcat/tc8.5.x/trunk: ./ java/org/apache/tomcat/util/http/fileupload/ java/org/apache/tomcat/util/http/fileupload/FileUploadBase.java

2017-09-08 Thread markt
Author: markt Date: Fri Sep 8 14:34:35 2017 New Revision: 1807770 URL: http://svn.apache.org/viewvc?rev=1807770=rev Log: Drop unused code identified by FindBugs Modified: tomcat/tc8.5.x/trunk/ (props changed) tomcat/tc8.5.x/trunk/java/org/apache/tomcat/util/http/fileupload/ (props

Re: svn commit: r1807755 - /tomcat/trunk/test/org/apache/tomcat/util/net/openssl/TestOpenSSLConf.java

2017-09-08 Thread Mark Thomas
On 08/09/17 14:27, Rainer Jung wrote: > Thanks, you beat me by 10 minutes (and your solution is nicer than mine). > > Please do not wait for the docs with tagging. I have a bigger SSL docs > change in mind which I'll not finish today. No problem. I'm not sure if I'll get to the tag today. There

[Bug 57767] Websocket client proprietary configuration

2017-09-08 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=57767 --- Comment #18 from J Fernandez --- I have spent some time looking for opportunities to reuse but did not find many. We could replace the WWWAuthenticate parser for digest with org.apache.tomcat.util.http.parser, but we

[Bug 61503] JarWarResourceSet finds META-INF/ jar entries that do not exist leading to FileNotFoundException

2017-09-08 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=61503 --- Comment #1 from Mark Thomas --- This would be easier to investigate with a WAR I could deploy in a standard Tomcat instance but when I try that with the provided sample it appears no initialization occurs. I haven't (yet)

[Bug 61503] JarWarResourceSet finds META-INF/ jar entries that do not exist leading to FileNotFoundException

2017-09-08 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=61503 --- Comment #3 from Mark Thomas --- Thanks. Let me get back to you on that offer. -- You are receiving this mail because: You are the assignee for the bug.

[Bug 61503] JarWarResourceSet finds META-INF/ jar entries that do not exist leading to FileNotFoundException

2017-09-08 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=61503 --- Comment #2 from Andy Wilkinson --- I think I understand the problem well enough to create a much simpler sample that reproduces the problem. Let me know if that would be useful and I'll see what I can manage. --

[Bug 57767] Websocket client proprietary configuration

2017-09-08 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=57767 --- Comment #16 from Mark Thomas --- If there is a possibility of reuse ( this is client side and the existing code is server side) we'd need to be careful about which package / jar we put it in to avoid adding unwanted

[Bug 57767] Websocket client proprietary configuration

2017-09-08 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=57767 --- Comment #17 from Remy Maucherat --- Yes, I would rather integrate it (if it works) then see about reuse. I also don't think javadoc is a big issue either for this kind of code. -- You are receiving this mail because: You