Re: svn commit: r1844066 - in /tomcat/tc8.5.x/trunk: ./ build.xml java/org/apache/tomcat/jni/Library.java res/ide-support/idea/inspections.xml res/ide-support/idea/misc.xml res/ide-support/idea/module

2018-10-17 Thread Igal Sapir
Rainer, On Wed, Oct 17, 2018 at 12:36 AM Rainer Jung wrote: > Hi Igal, > > yes, doing the commit after the merge is necessary. > > The svn merge command does not merge the commit log message. > > You can edit the (empty) log message even after the commit using > >svn propedit -r 1844066

svn propchange: r1844066 - svn:log

2018-10-17 Thread isapir
Author: isapir Revision: 1844066 Modified property: svn:log Modified: svn:log at Wed Oct 17 17:58:39 2018 -- --- svn:log (original) +++ svn:log Wed Oct 17 17:58:39 2018 @@ -0,0 +1 @@ +Backport r1842809 and r1844065 from

Re: svn propchange: r1844066 - svn:log

2018-10-17 Thread Mark Thomas
On 17/10/18 18:58, isa...@apache.org wrote: > Author: isapir > Revision: 1844066 > Modified property: svn:log > > Modified: svn:log at Wed Oct 17 17:58:39 2018 > -- > --- svn:log (original) > +++ svn:log Wed Oct 17

Re: svn propchange: r1844066 - svn:log

2018-10-17 Thread Igal Sapir
On Wed, Oct 17, 2018 at 11:20 AM Mark Thomas wrote: > On 17/10/18 18:58, isa...@apache.org wrote: > > Author: isapir > > Revision: 1844066 > > Modified property: svn:log > > > > Modified: svn:log at Wed Oct 17 17:58:39 2018 > > >

svn commit: r1844127 - /tomcat/native/trunk/native/srclib/BUILDING

2018-10-17 Thread markt
Author: markt Date: Wed Oct 17 16:35:24 2018 New Revision: 1844127 URL: http://svn.apache.org/viewvc?rev=1844127=rev Log: Add outline instructions for OpenSSL 1.1.1 and a link to the details steps. Modified: tomcat/native/trunk/native/srclib/BUILDING Modified:

svn commit: r1844126 - /tomcat/native/trunk/native/NMAKEmakefile

2018-10-17 Thread markt
Author: markt Date: Wed Oct 17 16:34:55 2018 New Revision: 1844126 URL: http://svn.apache.org/viewvc?rev=1844126=rev Log: Add option to build with OpenSSL 1.0.2 or 1.1.1 There is probably a better way to do this but this works. Modified: tomcat/native/trunk/native/NMAKEmakefile Modified:

svn commit: r1844128 - /tomcat/native/trunk/native/srclib/openssl/openssl-msvcrt-1.1.1.patch

2018-10-17 Thread markt
Author: markt Date: Wed Oct 17 16:35:49 2018 New Revision: 1844128 URL: http://svn.apache.org/viewvc?rev=1844128=rev Log: Simplify patch and get it working with 32-bit and 64-bit Modified: tomcat/native/trunk/native/srclib/openssl/openssl-msvcrt-1.1.1.patch Modified:

svn commit: r1844066 - in /tomcat/tc8.5.x/trunk: ./ build.xml java/org/apache/tomcat/jni/Library.java res/ide-support/idea/inspections.xml res/ide-support/idea/misc.xml res/ide-support/idea/modules.xm

2018-10-17 Thread isapir
Author: isapir Date: Wed Oct 17 06:12:38 2018 New Revision: 1844066 URL: http://svn.apache.org/viewvc?rev=1844066=rev Log: (empty) Added: tomcat/tc8.5.x/trunk/res/ide-support/idea/misc.xml - copied unchanged from r1842809, tomcat/trunk/res/ide-support/idea/misc.xml

Re: svn commit: r1844065 - /tomcat/trunk/java/org/apache/tomcat/jni/Library.java

2018-10-17 Thread Igal Sapir
RE this: On Tue, Oct 16, 2018 at 10:39 PM wrote: > Author: isapir > Date: Wed Oct 17 05:39:01 2018 > New Revision: 1844065 > > URL: http://svn.apache.org/viewvc?rev=1844065=rev > Log: > Added util methods load and loadLibrary per BZ 62830 > > Modified: >

Re: svn commit: r1844066 - in /tomcat/tc8.5.x/trunk: ./ build.xml java/org/apache/tomcat/jni/Library.java res/ide-support/idea/inspections.xml res/ide-support/idea/misc.xml res/ide-support/idea/module

2018-10-17 Thread Igal Sapir
OK, so I ran `svn commit` (I thought before that `svn merge` takes care of that), and I hope that it turned out fine, though it looks like the log message was left empty. #cantwaitforgit Igal On Tue, Oct 16, 2018 at 11:12 PM wrote: > Author: isapir > Date: Wed Oct 17 06:12:38 2018 > New

Re: [VOTE] Release Apache Tomcat Native 1.2.18

2018-10-17 Thread Igal Sapir
On 10/17/2018 3:19 PM, Mark Thomas wrote: Version 1.2.18 includes the following changes compared to 1.2.17: - Windows binaries built with OpenSSL 1.0.2p and APR 1.6.5 - Windows binaries built with OpenSSL 1.1.1 and APR 1.6.5 - TLSv1.3 support when built with OpenSSL 1.1.1 Various other fixes

[GUMP@vmgump-vm3]: Project tomcat-tc7.0.x-test-apr (in module tomcat-7.0.x) failed

2018-10-17 Thread Bill Barker
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project tomcat-tc7.0.x-test-apr has an issue affecting its community

svn propchange: r1844066 - svn:log

2018-10-17 Thread isapir
Author: isapir Revision: 1844066 Modified property: svn:log Modified: svn:log at Wed Oct 17 19:09:10 2018 -- --- svn:log (original) +++ svn:log Wed Oct 17 19:09:10 2018 @@ -1 +1,5 @@ Backport r1842809 and r1844065 from

svn commit: r1844161 - /tomcat/trunk/java/org/apache/tomcat/jni/SSL.java

2018-10-17 Thread markt
Author: markt Date: Wed Oct 17 20:14:20 2018 New Revision: 1844161 URL: http://svn.apache.org/viewvc?rev=1844161=rev Log: Avoid exception when using Tomcat Native built with OpenSSL that does not support TLSv1.3 Modified: tomcat/trunk/java/org/apache/tomcat/jni/SSL.java Modified:

[Bug 62830] Add static methods to load native libraries by the Common ClassLoader

2018-10-17 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62830 --- Comment #5 from Igal Sapir --- (In reply to Remy Maucherat from comment #3) > Yes, if it was using the thread context classloader, like is done nearly > 100% of the time elsewhere, it would be useless. Weird stuff there. > > Personally, I

svn commit: r1844170 - /tomcat/native/tags/TOMCAT_NATIVE_1_2_18/

2018-10-17 Thread markt
Author: markt Date: Wed Oct 17 20:50:16 2018 New Revision: 1844170 URL: http://svn.apache.org/viewvc?rev=1844170=rev Log: Drop tag Removed: tomcat/native/tags/TOMCAT_NATIVE_1_2_18/ - To unsubscribe, e-mail:

svn commit: r1844171 - in /tomcat/native/tags/TOMCAT_NATIVE_1_2_18: ./ build.properties.default native/include/tcn_version.h

2018-10-17 Thread markt
Author: markt Date: Wed Oct 17 20:50:43 2018 New Revision: 1844171 URL: http://svn.apache.org/viewvc?rev=1844171=rev Log: Tag 1.2.18 Added: tomcat/native/tags/TOMCAT_NATIVE_1_2_18/ - copied from r1844168, tomcat/native/trunk/ Modified:

[VOTE] Release Apache Tomcat Native 1.2.18

2018-10-17 Thread Mark Thomas
Version 1.2.18 includes the following changes compared to 1.2.17: - Windows binaries built with OpenSSL 1.0.2p and APR 1.6.5 - Windows binaries built with OpenSSL 1.1.1 and APR 1.6.5 - TLSv1.3 support when built with OpenSSL 1.1.1 Various other fixes and improvements. See the changelog for

[Bug 62825] JSP inline javeascript backslash miss escaping in single quote string values

2018-10-17 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62825 --- Comment #2 from isalis...@ust.hk --- Thanks for the clarification. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail:

svn commit: r1844162 - /tomcat/trunk/java/org/apache/tomcat/jni/Library.java

2018-10-17 Thread isapir
Author: isapir Date: Wed Oct 17 20:19:26 2018 New Revision: 1844162 URL: http://svn.apache.org/viewvc?rev=1844162=rev Log: Updated JavaDoc for r1844065 Modified: tomcat/trunk/java/org/apache/tomcat/jni/Library.java Modified: tomcat/trunk/java/org/apache/tomcat/jni/Library.java URL:

svn commit: r1844166 - in /tomcat/tc8.5.x/trunk: ./ java/org/apache/tomcat/jni/Library.java

2018-10-17 Thread isapir
Author: isapir Date: Wed Oct 17 20:34:33 2018 New Revision: 1844166 URL: http://svn.apache.org/viewvc?rev=1844166=rev Log: Updated JavaDoc for r1844066 Modified: tomcat/tc8.5.x/trunk/ (props changed) tomcat/tc8.5.x/trunk/java/org/apache/tomcat/jni/Library.java Propchange:

[Bug 62830] Add static methods to load native libraries by the Common ClassLoader

2018-10-17 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62830 --- Comment #4 from Igal Sapir --- (In reply to Mark Thomas from comment #2) > I think it would be worth updating the Javadoc for the new methods to make > it clear that System.load[Library]() associates the loaded library not with > the

svn commit: r1844168 - in /tomcat/native/trunk: java/org/apache/tomcat/ test/org/apache/tomcat/

2018-10-17 Thread markt
Author: markt Date: Wed Oct 17 20:49:19 2018 New Revision: 1844168 URL: http://svn.apache.org/viewvc?rev=1844168=rev Log: Update externals Modified: tomcat/native/trunk/java/org/apache/tomcat/ (props changed) tomcat/native/trunk/test/org/apache/tomcat/ (props changed) Propchange:

svn commit: r30123 - in /dev/tomcat/tomcat-connectors/native/1.2.18: ./ binaries/ source/

2018-10-17 Thread markt
Author: markt Date: Wed Oct 17 22:15:49 2018 New Revision: 30123 Log: Upload 1.2.18 for voting Added: dev/tomcat/tomcat-connectors/native/1.2.18/ dev/tomcat/tomcat-connectors/native/1.2.18/binaries/

Re: Tomcat Native 1.2.18

2018-10-17 Thread Rainer Jung
Am 17.10.2018 um 09:47 schrieb Rainer Jung: Am 16.10.2018 um 23:01 schrieb Mark Thomas: Hi, I've been working on building this with OpenSSL 1.1.1. It wasn't as simple as I expected as there is quite a lot of clean-up in 1.1.1. I now have a working build although it required a handful of

[Bug 62830] Add static methods to load native libraries by the Common ClassLoader

2018-10-17 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62830 --- Comment #2 from Mark Thomas --- I think it would be worth updating the Javadoc for the new methods to make it clear that System.load[Library]() associates the loaded library not with the current thread context class loader but with the

svn commit: r1844077 - /tomcat/native/trunk/native/srclib/VERSIONS

2018-10-17 Thread markt
Author: markt Date: Wed Oct 17 09:52:27 2018 New Revision: 1844077 URL: http://svn.apache.org/viewvc?rev=1844077=rev Log: Version update Modified: tomcat/native/trunk/native/srclib/VERSIONS Modified: tomcat/native/trunk/native/srclib/VERSIONS URL:

[GUMP@vmgump-vm3]: Project tomcat-trunk-test-nio (in module tomcat-trunk) failed

2018-10-17 Thread Bill Barker
-Dtest.openssl.path=/srv/gump/public/workspace/openssl-master/dest-20181017/bin/openssl -Dtest.temp=output/test-tmp-NIO -Dtest.accesslog=true -Dexecute.test.nio=true -Dbnd.jar=/srv/gump/packages/bnd/bnd-4.0.0/biz.aQute.bnd-4.0.0.jar -Dexecute.test.apr=false -Dtest.excludePerformance=true -Dtest.relaxTiming=true

svn commit: r1844075 - /tomcat/native/trunk/xdocs/miscellaneous/changelog.xml

2018-10-17 Thread markt
Author: markt Date: Wed Oct 17 09:39:04 2018 New Revision: 1844075 URL: http://svn.apache.org/viewvc?rev=1844075=rev Log: Make OpenSSL 1.1.1 requirement for TLSv1.3 clear in the change log Modified: tomcat/native/trunk/xdocs/miscellaneous/changelog.xml Modified:

Re: Threads

2018-10-17 Thread Rémy Maucherat
On Mon, Oct 15, 2018 at 5:26 PM Mark Thomas wrote: > > and we shouldn't pollute that with side uses. Is that > > doable in 9, or should it be added to the "10" todo list ? > > No strong view. If it can be done without impacting the external API > then no objections here. > This looks ok

[Bug 62830] Add static methods to load native libraries by the Common ClassLoader

2018-10-17 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62830 --- Comment #3 from Remy Maucherat --- Yes, if it was using the thread context classloader, like is done nearly 100% of the time elsewhere, it would be useless. Weird stuff there. Personally, I think native libraries can use extra care and if

svn commit: r1844079 - /tomcat/native/trunk/native/srclib/openssl/openssl-msvcrt.patch

2018-10-17 Thread markt
Author: markt Date: Wed Oct 17 10:09:39 2018 New Revision: 1844079 URL: http://svn.apache.org/viewvc?rev=1844079=rev Log: Latest OpenSSL 1.0.2 needs additional patch to work with our build env Modified: tomcat/native/trunk/native/srclib/openssl/openssl-msvcrt.patch Modified:

Re: Tomcat Native 1.2.18

2018-10-17 Thread Rainer Jung
Am 16.10.2018 um 23:01 schrieb Mark Thomas: Hi, I've been working on building this with OpenSSL 1.1.1. It wasn't as simple as I expected as there is quite a lot of clean-up in 1.1.1. I now have a working build although it required a handful of tweaks to the OpenSSL source. Some are bugs that

svn commit: r1844074 - in /tomcat/trunk: java/org/apache/catalina/tribes/membership/StaticMembershipProvider.java webapps/docs/changelog.xml

2018-10-17 Thread kfujino
Author: kfujino Date: Wed Oct 17 08:48:37 2018 New Revision: 1844074 URL: http://svn.apache.org/viewvc?rev=1844074=rev Log: Even if all members have already disappeared and PING can not be sent, ensure that members will be expired. Modified:

Re: svn commit: r1844066 - in /tomcat/tc8.5.x/trunk: ./ build.xml java/org/apache/tomcat/jni/Library.java res/ide-support/idea/inspections.xml res/ide-support/idea/misc.xml res/ide-support/idea/module

2018-10-17 Thread Rainer Jung
Hi Igal, yes, doing the commit after the merge is necessary. The svn merge command does not merge the commit log message. You can edit the (empty) log message even after the commit using svn propedit -r 1844066 --revprop svn:log . assuming you are inside the tc8.5.x/trunk directory

svn commit: r1844086 - /tomcat/native/trunk/native/srclib/openssl/openssl-msvcrt-1.1.1.patch

2018-10-17 Thread markt
Author: markt Date: Wed Oct 17 10:56:41 2018 New Revision: 1844086 URL: http://svn.apache.org/viewvc?rev=1844086=rev Log: Add first pass at OpenSSL-1.1.1 patch Added: tomcat/native/trunk/native/srclib/openssl/openssl-msvcrt-1.1.1.patch (with props) Added:

svn commit: r1844085 - /tomcat/native/trunk/native/srclib/openssl/openssl-msvcrt.patch

2018-10-17 Thread markt
Author: markt Date: Wed Oct 17 10:56:24 2018 New Revision: 1844085 URL: http://svn.apache.org/viewvc?rev=1844085=rev Log: Fix ws Modified: tomcat/native/trunk/native/srclib/openssl/openssl-msvcrt.patch Modified: tomcat/native/trunk/native/srclib/openssl/openssl-msvcrt.patch URL: