Position on failing tests with vendor-modified OpenSSL packages

2020-04-23 Thread Michael Osipov
Folks, I run test from Tomcat master and libtcnative master on FreeBSD, RHEL 7 and HP-UX 11.31 on a regular basis and noticed that the OpenSSL 1.0.2 packages provided by Red Hat and HPE are modified which make several tests fail. See an excerpt here [1]. To verify this I have compiled OpenSSL

Re: buildbot failure in on tomcat-9-trunk

2020-04-23 Thread Mark Thomas
On 22/04/2020 22:53, build...@apache.org wrote: > The Buildbot has detected a new failure on builder tomcat-9-trunk while > building tomcat. Full details are available at: > https://ci.apache.org/builders/tomcat-9-trunk/builds/193 This is bizarre. There are two failures but the really

Re: buildbot failure in on tomcat-9-trunk

2020-04-23 Thread Rémy Maucherat
On Thu, Apr 23, 2020 at 12:02 PM Mark Thomas wrote: > On 22/04/2020 22:53, build...@apache.org wrote: > > The Buildbot has detected a new failure on builder tomcat-9-trunk while > building tomcat. Full details are available at: > > https://ci.apache.org/builders/tomcat-9-trunk/builds/193 > >

[GitHub] [tomcat] markt-asf commented on issue #280: Remove unnecessary boxing and unboxing

2020-04-23 Thread GitBox
markt-asf commented on issue #280: URL: https://github.com/apache/tomcat/pull/280#issuecomment-618326624 These are all deliberate to keep the IDE (Eclipse) clear of warnings. We could disable that warning but that then runs the risk of us missing one of the more subtle autoboxing/unboxing

buildbot success in on tomcat-7-trunk

2020-04-23 Thread buildbot
The Buildbot has detected a restored build on builder tomcat-7-trunk while building tomcat. Full details are available at: https://ci.apache.org/builders/tomcat-7-trunk/builds/1681 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: asf946_ubuntu Build Reason: The

[GitHub] [tomcat] markt-asf commented on a change in pull request #273: Use enhanced for loops where possible

2020-04-23 Thread GitBox
markt-asf commented on a change in pull request #273: URL: https://github.com/apache/tomcat/pull/273#discussion_r413715418 ## File path: java/jakarta/el/Util.java ## @@ -380,11 +380,12 @@ static Method findMethod(Class clazz, Object base, String methodName, private

[tomcat] branch 9.0.x updated: Fix BZ 59203 - Try Thread.interrupt() before Thread.stop()

2020-04-23 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new 8c4afe4 Fix BZ 59203 - Try Thread.interrupt()

[tomcat] branch 7.0.x updated: Fix back-port of bulk operation - addAll() - refactoring

2020-04-23 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 7.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/7.0.x by this push: new 5a1b217 Fix back-port of bulk operation -

buildbot success in on tomcat-9-trunk

2020-04-23 Thread buildbot
The Buildbot has detected a restored build on builder tomcat-9-trunk while building tomcat. Full details are available at: https://ci.apache.org/builders/tomcat-9-trunk/builds/194 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: asf946_ubuntu Build Reason: The

[Bug 59203] Try to call Thread.interrupt before calling Thread.stop in WebappClassLoaderBase#clearReferencesThreads

2020-04-23 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=59203 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

[tomcat] branch 7.0.x updated: Fix BZ 59203 - Try Thread.interrupt() before Thread.stop()

2020-04-23 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 7.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/7.0.x by this push: new c8ef0bd Fix BZ 59203 - Try Thread.interrupt()

[Bug 64312] Many memberDisappeared messages are logged on all nodes of the cluster with JDK versions 12 or above, even when system is idle

2020-04-23 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=64312 Pavana Sai Mahathi Vavilala changed: What|Removed |Added Resolution|WORKSFORME |---

[tomcat] branch master updated: Fix BZ 59203 - Try Thread.interrupt() before Thread.stop()

2020-04-23 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/master by this push: new 2e52596 Fix BZ 59203 - Try Thread.interrupt()

[GitHub] [tomcat] markt-asf commented on issue #275: BZ 59203 - interrupt tomcat threads instead of stopping

2020-04-23 Thread GitBox
markt-asf commented on issue #275: URL: https://github.com/apache/tomcat/pull/275#issuecomment-618352734 Thanks. I used a variation of your PR to fix this. This is an automated message from the Apache Git Service. To respond

[tomcat] branch 8.5.x updated: Fix BZ 59203 - Try Thread.interrupt() before Thread.stop()

2020-04-23 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/8.5.x by this push: new acd2f7c Fix BZ 59203 - Try Thread.interrupt()

Re: Time for Tomcat Native 1.2.24?

2020-04-23 Thread Michael Osipov
Am 2020-04-22 um 12:34 schrieb Mark Thomas: Hi all, You have probably seen this: OpenSSL - CVE-2020-1967 https://openssl.markmail.org/thread/nuamcatocap7rwrw I have reviewed the Tomcat Native code and confirmed that we do not call SSL_check_chain() at any point. I also looked at the OpenSSL

[Bug 64312] Many memberDisappeared messages are logged on all nodes of the cluster with JDK versions 12 or above, even when system is idle

2020-04-23 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=64312 Remy Maucherat changed: What|Removed |Added Resolution|--- |WORKSFORME

Re: [tomcat] branch master updated: Improve the handling of requests that use an expectation.

2020-04-23 Thread Rainer Jung
Thanks for that. Rainer - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

[GitHub] [tomcat] rmaucher commented on issue #281: Change FilterChain holder from array to list

2020-04-23 Thread GitBox
rmaucher commented on issue #281: URL: https://github.com/apache/tomcat/pull/281#issuecomment-618465384 When I look at https://github.com/apache/tomcat/pull/271 in comparison, it has an extensive "why" demonstrating why it is actually better and it is not simply cosmetics.

[GitHub] [tomcat] larsgrefer opened a new pull request #282: Improve IDE support for IntelliJ IDEA

2020-04-23 Thread GitBox
larsgrefer opened a new pull request #282: URL: https://github.com/apache/tomcat/pull/282 This change makes IntelliJ IDEA and other IDE's aware of some of the coding standards of the Tomcat project. The .editorconfig file (and the rules therein) will be automatically used by the

[GitHub] [tomcat] larsgrefer opened a new pull request #283: Remove implicit unboxing

2020-04-23 Thread GitBox
larsgrefer opened a new pull request #283: URL: https://github.com/apache/tomcat/pull/283 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [tomcat] markt-asf commented on issue #282: Improve IDE support for IntelliJ IDEA

2020-04-23 Thread GitBox
markt-asf commented on issue #282: URL: https://github.com/apache/tomcat/pull/282#issuecomment-618510753 These need to be placed in `res/ide-support/idea` and you probably want to check that the `ide-intellij` Ant target will do the right thing with them and if not, adjust it.

[GitHub] [tomcat] markt-asf commented on issue #282: Improve IDE support for IntelliJ IDEA

2020-04-23 Thread GitBox
markt-asf commented on issue #282: URL: https://github.com/apache/tomcat/pull/282#issuecomment-618521303 Some community members (really) dislike having the clutter in the root of the repository. Some IDEs are worse than others for this (IDEA seems to be one of the better ones). There was

[GitHub] [tomcat] martin-g commented on issue #276: Add s390x Travis support

2020-04-23 Thread GitBox
martin-g commented on issue #276: URL: https://github.com/apache/tomcat/pull/276#issuecomment-618402125 The build for s390x fails at Travis: https://travis-ci.org/github/apache/tomcat/jobs/678503882 ``` Caused by: java.security.cert.CertificateExpiredException: NotAfter: Sat Dec

[GitHub] [tomcat] markt-asf commented on issue #277: Refuse adding invalid HTTP 2.0 headers

2020-04-23 Thread GitBox
markt-asf commented on issue #277: URL: https://github.com/apache/tomcat/pull/277#issuecomment-618453474 I've been reading the HTTP/2 RFC and there is more to this than simply blocking the `connection` header. 1. What the HTTP/2 and HTTP/1.1 specs suggest we should be doing in parsing

[tomcat-native] 03/03: Estimate 1.2.24 release date as 2020-04-29. Update news pages.

2020-04-23 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat-native.git commit cdee1db5349ae139d8244a21754b2ac5aad524e8 Author: Mark Thomas AuthorDate: Thu Apr 23 16:43:09 2020 +0100

[tomcat-native] 01/03: Remove OpenSSL 1.0.2 patch file as that version is no longer supported

2020-04-23 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat-native.git commit c49be394cc945c0c1c4656d68eb5c69846791e7e Author: Mark Thomas AuthorDate: Thu Apr 23 16:21:13 2020 +0100

[tomcat-native] branch master updated (db11788 -> cdee1db)

2020-04-23 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/tomcat-native.git. from db11788 Add changelog entry for BZ 63701 new c49be39 Remove OpenSSL 1.0.2 patch file as that version is

[tomcat-native] 02/03: Update version recommendations

2020-04-23 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat-native.git commit 04497fe553ac4a5497eeb7c011275c8e14eb6fec Author: Mark Thomas AuthorDate: Thu Apr 23 16:25:10 2020 +0100

[GitHub] [tomcat] michael-o commented on issue #277: Refuse adding invalid HTTP 2.0 headers

2020-04-23 Thread GitBox
michael-o commented on issue #277: URL: https://github.com/apache/tomcat/pull/277#issuecomment-618504729 Please note that there may be client components which may explicitly close connections with `Connection: close`. E.g., in `SpnegoAuthenticator`.

[GitHub] [tomcat] michael-o commented on issue #282: Improve IDE support for IntelliJ IDEA

2020-04-23 Thread GitBox
michael-o commented on issue #282: URL: https://github.com/apache/tomcat/pull/282#issuecomment-618507565 I am against IDE-specific config files, those should be automatically generated. Next one will request, VS Code, Eclipse, NetBeans, YouNameIt.

[tomcat-native] branch master updated: Tweak wording. Fix typo.

2020-04-23 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat-native.git The following commit(s) were added to refs/heads/master by this push: new 3cc27fa Tweak wording. Fix typo. 3cc27fa

Re: [tomcat-native] branch master updated: Tweak wording. Fix typo.

2020-04-23 Thread Michael Osipov
Am 2020-04-23 um 18:48 schrieb ma...@apache.org: This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat-native.git The following commit(s) were added to refs/heads/master by this push:

[GitHub] [tomcat] michael-o edited a comment on issue #282: Improve IDE support for IntelliJ IDEA

2020-04-23 Thread GitBox
michael-o edited a comment on issue #282: URL: https://github.com/apache/tomcat/pull/282#issuecomment-618526886 @larsgrefer I'd like to quote @markt-asf on point 2 and 3 when we met in person: "I can type `ant ide-...` and I am done.". If you whink that `ant ide-...` is not present

Re: [tomcat-native] 02/03: Update version recommendations

2020-04-23 Thread Michael Osipov
Am 2020-04-23 um 17:43 schrieb ma...@apache.org: This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat-native.git commit 04497fe553ac4a5497eeb7c011275c8e14eb6fec Author: Mark Thomas

Re: [tomcat-native] 02/03: Update version recommendations

2020-04-23 Thread Mark Thomas
On 23/04/2020 17:29, Michael Osipov wrote: > Am 2020-04-23 um 17:43 schrieb ma...@apache.org: >> This is an automated email from the ASF dual-hosted git repository. >> >> markt pushed a commit to branch master >> in repository https://gitbox.apache.org/repos/asf/tomcat-native.git >> >> commit

[GitHub] [tomcat] larsgrefer commented on issue #282: Improve IDE support for IntelliJ IDEA

2020-04-23 Thread GitBox
larsgrefer commented on issue #282: URL: https://github.com/apache/tomcat/pull/282#issuecomment-618515960 @michael-o You already have them for IntelliJ IDEA, Eclipse and NetBeans My idea was not to hide them in `res/ide-support/idea` but to directly put them where they belong.

[GitHub] [tomcat] rmaucher commented on issue #277: Refuse adding invalid HTTP 2.0 headers

2020-04-23 Thread GitBox
rmaucher commented on issue #277: URL: https://github.com/apache/tomcat/pull/277#issuecomment-618470184 Yes, it is accurate if there's a "connection: foobar" header, then there could be a "foobar" header and in that case it's tied to the connection header. Note about my earlier

[tomcat-native] branch master updated: Update patch for APR 1.7.x

2020-04-23 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat-native.git The following commit(s) were added to refs/heads/master by this push: new ba42a1e Update patch for APR 1.7.x

[GitHub] [tomcat] michael-o commented on issue #282: Improve IDE support for IntelliJ IDEA

2020-04-23 Thread GitBox
michael-o commented on issue #282: URL: https://github.com/apache/tomcat/pull/282#issuecomment-618526886 @larsgrefer I'd like to quote @markt-asf on point 2 and 3 while we met in person: "I can type `ant ide-...` and I am done.". If you whink that `ant ide-...` is not present enough,

[GitHub] [tomcat] rainerjung commented on issue #276: Add s390x Travis support

2020-04-23 Thread GitBox
rainerjung commented on issue #276: URL: https://github.com/apache/tomcat/pull/276#issuecomment-618408120 Hi Martin, the build.xml line numbers /home/travis/build/apache/tomcat/build.xml:2789: The following error occurred while executing this line:

Re: [tomcat] branch master updated: Fix changelog tags

2020-04-23 Thread Mark Thomas
On 23/04/2020 13:46, r...@apache.org wrote: > This is an automated email from the ASF dual-hosted git repository. > > remm pushed a commit to branch master > in repository https://gitbox.apache.org/repos/asf/tomcat.git > > > The following commit(s) were added to refs/heads/master by this push:

[GitHub] [tomcat] govi20 edited a comment on issue #281: Change FilterChain holder from array to list

2020-04-23 Thread GitBox
govi20 edited a comment on issue #281: URL: https://github.com/apache/tomcat/pull/281#issuecomment-61843 There are so many places in the codebase where we can replace array with List and we could reduce good amount of code.

[GitHub] [tomcat] rmaucher commented on issue #281: Change FilterChain holder from array to list

2020-04-23 Thread GitBox
rmaucher commented on issue #281: URL: https://github.com/apache/tomcat/pull/281#issuecomment-618384315 This commit seems functionally useless but is solely motivated by personal preferences. At the very least, they should be accompanied by quick perf numbers that show equivalence or

[GitHub] [tomcat] markt-asf commented on issue #281: Change FilterChain holder from array to list

2020-04-23 Thread GitBox
markt-asf commented on issue #281: URL: https://github.com/apache/tomcat/pull/281#issuecomment-618447383 The question is "At what cost?" I have two concerns. 1. Regressions. The changes should be obvious and easy to check but there are plenty of examples in the history of Tomcat of

[tomcat] branch 8.5.x updated: Fix changelog tags

2020-04-23 Thread remm
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/8.5.x by this push: new 79ce608 Fix changelog tags 79ce608 is described

[tomcat] branch 9.0.x updated: Fix changelog tags

2020-04-23 Thread remm
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new 2c81c41 Fix changelog tags 2c81c41 is described

[GitHub] [tomcat] govi20 opened a new pull request #281: Change FilterChain holder from array to list

2020-04-23 Thread GitBox
govi20 opened a new pull request #281: URL: https://github.com/apache/tomcat/pull/281 Instead of resizing array manually, we can leverage `List` to hold filter-chain This is an automated message from the Apache Git Service.

[tomcat] branch master updated: Fix changelog tags

2020-04-23 Thread remm
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/master by this push: new 5c76750 Fix changelog tags 5c76750 is described

[GitHub] [tomcat] martin-g commented on issue #276: Add s390x Travis support

2020-04-23 Thread GitBox
martin-g commented on issue #276: URL: https://github.com/apache/tomcat/pull/276#issuecomment-618421407 Thanks for the explanation, Rainer! I've restarted the job at Travis. Let's see! This is an automated message from

[GitHub] [tomcat] govi20 commented on issue #281: Change FilterChain holder from array to list

2020-04-23 Thread GitBox
govi20 commented on issue #281: URL: https://github.com/apache/tomcat/pull/281#issuecomment-61843 There are so many places in the codebase where we can replace array with List could reduce good amount of code. This is

[GitHub] [tomcat] martin-g commented on issue #276: Add s390x Travis support

2020-04-23 Thread GitBox
martin-g commented on issue #276: URL: https://github.com/apache/tomcat/pull/276#issuecomment-618443203 Thank you, @prankkelkar ! This is an automated message from the Apache Git Service. To respond to the message, please

[tomcat] branch master updated (5c76750 -> cbe6edb)

2020-04-23 Thread mgrigorov
This is an automated email from the ASF dual-hosted git repository. mgrigorov pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git. from 5c76750 Fix changelog tags new a3ddb06 s390x travis new ba95d82 Revert changes as per review

[GitHub] [tomcat] ChristopherSchultz commented on issue #281: Change FilterChain holder from array to list

2020-04-23 Thread GitBox
ChristopherSchultz commented on issue #281: URL: https://github.com/apache/tomcat/pull/281#issuecomment-618426909 There *is* some code-reduction, and therefore a reduction in the possibility of bugs. Obviously, this code is well-tested and does indeed work. Another possible

[GitHub] [tomcat] larsgrefer commented on a change in pull request #273: Use enhanced for loops where possible

2020-04-23 Thread GitBox
larsgrefer commented on a change in pull request #273: URL: https://github.com/apache/tomcat/pull/273#discussion_r413983378 ## File path: java/jakarta/el/Util.java ## @@ -380,11 +380,12 @@ static Method findMethod(Class clazz, Object base, String methodName, private

[CONF] Apache Tomcat > ReleaseProcess

2020-04-23 Thread Konstantin Kolinko (Confluence)
Title: Message Title There's 1 new edit on this page   ReleaseProcess Konstantin Kolinko edited this page Here's the version

[Bug 64373] New: tag-file reference from .tld in /WEB-INF/classes/META-INF cannot be resolved

2020-04-23 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=64373 Bug ID: 64373 Summary: tag-file reference from .tld in /WEB-INF/classes/META-INF cannot be resolved Product: Tomcat 9 Version: 9.0.34 Hardware: PC OS:

svn commit: r39070 - in /release/tomcat/tomcat-10/v10.0.0-M4/bin: apache-tomcat-10.0.0-M4.tar.gz.asc apache-tomcat-10.0.0-M4.zip.asc

2020-04-23 Thread kkolinko
Author: kkolinko Date: Thu Apr 23 18:23:13 2020 New Revision: 39070 Log: Add missing signature files for Tomcat 10.0.0-M4 release, as was reported on the users@ list I found these files in my copy of a Maven staging repository that I downloaded at the release voting time Added:

[tomcat] branch 7.0.x updated: Remove implicit unboxing

2020-04-23 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 7.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/7.0.x by this push: new a006140 Remove implicit unboxing a006140 is

[tomcat] branch 8.5.x updated: Remove implicit unboxing

2020-04-23 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/8.5.x by this push: new b5ba5a1 Remove implicit unboxing b5ba5a1 is

[tomcat] branch 9.0.x updated: Remove implicit unboxing

2020-04-23 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new 9091fa0 Remove implicit unboxing 9091fa0 is

[CONF] Apache Tomcat > Design and Development Issues

2020-04-23 Thread Konstantin Kolinko (Confluence)
Title: Message Title There's 1 new edit on this page   Design and Development Issues Konstantin Kolinko edited this page Here's

[tomcat] branch master updated: Remove implicit unboxing

2020-04-23 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/master by this push: new 110e084 Remove implicit unboxing 110e084 is

[GitHub] [tomcat] markt-asf commented on pull request #283: Remove implicit unboxing

2020-04-23 Thread GitBox
markt-asf commented on pull request #283: URL: https://github.com/apache/tomcat/pull/283#issuecomment-618583682 Thank you. That prompted me to figure out why I got the warning in the text editor but not in the problems tab. I now have ~1,500 errors and warnings to look at. But I'll merge

[tomcat-native] branch master updated: Introduce tcn_get_thread_id(void) to reduce code duplication

2020-04-23 Thread michaelo
This is an automated email from the ASF dual-hosted git repository. michaelo pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat-native.git The following commit(s) were added to refs/heads/master by this push: new f95f531 Introduce

[tomcat-native] branch master updated: Fix linking against OpenSSL in non-standard locations on FreeBSD

2020-04-23 Thread michaelo
This is an automated email from the ASF dual-hosted git repository. michaelo pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat-native.git The following commit(s) were added to refs/heads/master by this push: new 692dd48 Fix linking against OpenSSL

[GitHub] [tomcat] michael-o commented on pull request #282: Improve IDE support for IntelliJ IDEA

2020-04-23 Thread GitBox
michael-o commented on pull request #282: URL: https://github.com/apache/tomcat/pull/282#issuecomment-618717780 Please skim to IDEA only. This is an automated message from the Apache Git Service. To respond to the message,

[tomcat] 03/06: Add DTD definition to all mbean-descriptor files

2020-04-23 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 228dae2bf2a1b16dcbd8756c10e41fcb5d484a5b Author: Mark Thomas AuthorDate: Thu Apr 23 22:03:35 2020 +0100 Add DTD

[tomcat] 01/06: pageContext is never null

2020-04-23 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit b2c2b7f90a1629bddf09997a02e29546dd9023a1 Author: Mark Thomas AuthorDate: Thu Apr 23 20:17:40 2020 +0100 pageContext

[tomcat] 06/06: Default value not supported

2020-04-23 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit fd81ab91ae52bf6a47bcc07d2264a46c14cebb8d Author: Mark Thomas AuthorDate: Thu Apr 23 22:12:38 2020 +0100 Default

[tomcat] 02/06: Generics fixes for JSPs

2020-04-23 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 3c4c1a048147baa032ab8ec409dbbe573c59b7fb Author: Mark Thomas AuthorDate: Thu Apr 23 21:02:10 2020 +0100 Generics

[tomcat] branch 9.0.x updated (9091fa0 -> fd81ab9)

2020-04-23 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a change to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git. from 9091fa0 Remove implicit unboxing new b2c2b7f pageContext is never null new 3c4c1a0 Generics fixes for

[tomcat] 05/06: Order matters

2020-04-23 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit d2f9341ed16084389e44a6ea104a44801e79cad0 Author: Mark Thomas AuthorDate: Thu Apr 23 22:07:26 2020 +0100 Order

[tomcat] 04/06: Attributes don't have an impact attribute

2020-04-23 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit ce4622e1891ae9defd73d5353599c5d050d0318d Author: Mark Thomas AuthorDate: Thu Apr 23 22:05:47 2020 +0100 Attributes

[tomcat] 05/06: Order matters

2020-04-23 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git commit a3ada04132bae2c53b21af1f3731a020b0d3b6aa Author: Mark Thomas AuthorDate: Thu Apr 23 22:07:26 2020 +0100 Order

[tomcat] 01/06: pageContext is never null

2020-04-23 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git commit fb6c67c9f9d1a753458b0e2a730c0c4c21ecc566 Author: Mark Thomas AuthorDate: Thu Apr 23 20:17:40 2020 +0100 pageContext

[tomcat] 06/06: Default value not supported

2020-04-23 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 7d66c652a3e4d64b9711712fa1409ba1261effd8 Author: Mark Thomas AuthorDate: Thu Apr 23 22:12:38 2020 +0100 Default

[tomcat] 03/06: Add DTD definition to all mbean-descriptor files

2020-04-23 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 0dbb6c0b1b74d78191965fe3d40060eeedcde5b0 Author: Mark Thomas AuthorDate: Thu Apr 23 22:03:35 2020 +0100 Add DTD

[tomcat] 02/06: Generics fixes for JSPs

2020-04-23 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git commit cc0056cad9da0fa0f3d5b081544b0953a2cd1304 Author: Mark Thomas AuthorDate: Thu Apr 23 21:02:10 2020 +0100 Generics

[tomcat] 04/06: Attributes don't have an impact attribute

2020-04-23 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git commit c0f8f026865a16f89ec7ca7bc6487cc29231d983 Author: Mark Thomas AuthorDate: Thu Apr 23 22:05:47 2020 +0100 Attributes

[tomcat] branch master updated (110e084 -> 7d66c65)

2020-04-23 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git. from 110e084 Remove implicit unboxing new fb6c67c pageContext is never null new cc0056c Generics fixes for

[tomcat] 01/05: pageContext is never null

2020-04-23 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 7.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 9c2fd70f99f031489425d96359eac7580cef2803 Author: Mark Thomas AuthorDate: Thu Apr 23 20:17:40 2020 +0100 pageContext

[tomcat] branch 7.0.x updated (a006140 -> adf93c8)

2020-04-23 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a change to branch 7.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git. from a006140 Remove implicit unboxing new 9c2fd70 pageContext is never null new 1be170f Generics fixes for

[tomcat] 03/05: Add DTD definition to all mbean-descriptor files

2020-04-23 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 7.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 1f1877c3d888f519f0544386cebc3c3f0ca16786 Author: Mark Thomas AuthorDate: Thu Apr 23 22:03:35 2020 +0100 Add DTD

[tomcat] 05/05: Order matters

2020-04-23 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 7.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit adf93c80384b0f2dad1d1dedd1716e88a17f222c Author: Mark Thomas AuthorDate: Thu Apr 23 22:07:26 2020 +0100 Order

[tomcat] 04/05: Attributes don't have an impact attribute

2020-04-23 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 7.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit ebeefd18840b46aa9428078211655af957941c69 Author: Mark Thomas AuthorDate: Thu Apr 23 22:05:47 2020 +0100 Attributes

[tomcat] 02/05: Generics fixes for JSPs

2020-04-23 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 7.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 1be170fcf07e6105ecd4761e04fad6382540a534 Author: Mark Thomas AuthorDate: Thu Apr 23 21:02:10 2020 +0100 Generics

[tomcat] branch 9.0.x updated: Another IDE file to ignore

2020-04-23 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new 3cf66c7 Another IDE file to ignore 3cf66c7 is

[GitHub] [tomcat] larsgrefer opened a new pull request #284: Improve General IDE support

2020-04-23 Thread GitBox
larsgrefer opened a new pull request #284: URL: https://github.com/apache/tomcat/pull/284 see also: https://github.com/apache/tomcat/pull/282#pullrequestreview-399324287 This is an automated message from the Apache Git

[tomcat] 01/06: pageContext is never null

2020-04-23 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 3e7423e6a314e812c56a4d8b10857cd3398400c7 Author: Mark Thomas AuthorDate: Thu Apr 23 20:17:40 2020 +0100 pageContext

[tomcat] 03/06: Add DTD definition to all mbean-descriptor files

2020-04-23 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 0d493ae70ae736af7e20a2d66f2834ef07887b20 Author: Mark Thomas AuthorDate: Thu Apr 23 22:03:35 2020 +0100 Add DTD

[tomcat] branch 8.5.x updated (b5ba5a1 -> b551b40)

2020-04-23 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a change to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git. from b5ba5a1 Remove implicit unboxing new 3e7423e pageContext is never null new 2d6dfcb Generics fixes for

[tomcat] 02/06: Generics fixes for JSPs

2020-04-23 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 2d6dfcb75e63b585e27e3dc69d5f227b28f574a0 Author: Mark Thomas AuthorDate: Thu Apr 23 21:02:10 2020 +0100 Generics

[tomcat] 05/06: Order matters

2020-04-23 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit f05ad39d787959b6d13a35dd71f6cf2c91aaf149 Author: Mark Thomas AuthorDate: Thu Apr 23 22:07:26 2020 +0100 Order

[tomcat] 04/06: Attributes don't have an impact attribute

2020-04-23 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 66e0f7bfe077227a708e13f8e0cf0f75aa6e6dd5 Author: Mark Thomas AuthorDate: Thu Apr 23 22:05:47 2020 +0100 Attributes

[tomcat] 06/06: Default value not supported

2020-04-23 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit b551b40a506024abad9c310dee4572c8c829f0ed Author: Mark Thomas AuthorDate: Thu Apr 23 22:12:38 2020 +0100 Default

Re: [GitHub] [tomcat] markt-asf commented on pull request #283: Remove implicit unboxing

2020-04-23 Thread Mark Thomas
On 23/04/2020 19:43, GitBox wrote: > > markt-asf commented on pull request #283: > URL: https://github.com/apache/tomcat/pull/283#issuecomment-618583682 > > >Thank you. That prompted me to figure out why I got the warning in the > text editor but not in the problems tab. I now have ~1,500

buildbot failure in on tomcat-trunk

2020-04-23 Thread buildbot
The Buildbot has detected a new failure on builder tomcat-trunk while building tomcat. Full details are available at: https://ci.apache.org/builders/tomcat-trunk/builds/5141 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: asf946_ubuntu Build Reason: The AnyBranchScheduler