[tomcat] 03/04: Add changelog

2020-04-27 Thread remm
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 82598ebce058be73432bf8d118023a55f682669b Author: remm AuthorDate: Tue Apr 28 00:36:10 2020 +0200 Add changelog ---

[tomcat] 02/04: Fix validate

2020-04-27 Thread remm
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit f98c1049e3803d355fbb78355a61bc27451933db Author: remm AuthorDate: Tue Apr 28 00:33:00 2020 +0200 Fix validate ---

[tomcat] branch 8.5.x updated (59bd13c -> 1871935)

2020-04-27 Thread remm
This is an automated email from the ASF dual-hosted git repository. remm pushed a change to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git. from 59bd13c Fix bz 64373. Ensure tag file unpacked from WAR can be found. new 13de9aa Fix

[tomcat] 04/04: Use javax for 9

2020-04-27 Thread remm
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 187193585dceaaae06839c024e5c760e2b6f12ee Author: remm AuthorDate: Tue Apr 28 00:39:43 2020 +0200 Use javax for 9 ---

[tomcat] 01/04: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=64384

2020-04-27 Thread remm
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 13de9aa412237a42512cc6e0ae57254665ae539f Author: Christopher Schultz AuthorDate: Mon Apr 27 18:01:00 2020 -0400 Fix

Re: git-fu is (still) weak

2020-04-27 Thread Rémy Maucherat
On Tue, Apr 28, 2020 at 12:21 AM Christopher Schultz < ch...@christopherschultz.net> wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA256 > > All, > > I tried again to commit to tc10 branch, got commit id > 8dddc11512fbd3b91ed9d737a42e4b8415458ddf. > > Moving to tc9 branch: > > $ git

[tomcat] 01/04: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=64384

2020-04-27 Thread remm
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 56f21b8654260291d1e088016ab1145779c3329c Author: Christopher Schultz AuthorDate: Mon Apr 27 18:01:00 2020 -0400 Fix

[tomcat] 03/04: Add changelog

2020-04-27 Thread remm
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 24439fa833e41a1545750731f051210e181759c5 Author: remm AuthorDate: Tue Apr 28 00:36:10 2020 +0200 Add changelog ---

[tomcat] 04/04: Use javax for 9

2020-04-27 Thread remm
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit e928ee579285a5f9cbf446658da46e6f072fd55a Author: remm AuthorDate: Tue Apr 28 00:39:43 2020 +0200 Use javax for 9 ---

[tomcat] branch 9.0.x updated (d361c6e -> e928ee5)

2020-04-27 Thread remm
This is an automated email from the ASF dual-hosted git repository. remm pushed a change to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git. from d361c6e Fix bz 64373. Ensure tag file unpacked from WAR can be found. new 56f21b8 Fix

[tomcat] 02/04: Fix validate

2020-04-27 Thread remm
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 8455a251d2d077d1aaa58458acbf360851570ce7 Author: remm AuthorDate: Tue Apr 28 00:33:00 2020 +0200 Fix validate ---

[tomcat] branch master updated: Add changelog

2020-04-27 Thread remm
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/master by this push: new 788a657 Add changelog 788a657 is described below

[tomcat] branch master updated: Fix validate

2020-04-27 Thread remm
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/master by this push: new 5860d32 Fix validate 5860d32 is described below

buildbot success in on tomcat-trunk

2020-04-27 Thread buildbot
The Buildbot has detected a restored build on builder tomcat-trunk while building tomcat. Full details are available at: https://ci.apache.org/builders/tomcat-trunk/builds/5145 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: asf946_ubuntu Build Reason: The

Re: git-fu is (still) weak

2020-04-27 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 All, I tried again to commit to tc10 branch, got commit id 8dddc11512fbd3b91ed9d737a42e4b8415458ddf. Moving to tc9 branch: $ git cherry-pick -n 8dddc11512fbd3b91ed9d737a42e4b8415458ddf fatal: bad object 8dddc11512fbd3b91ed9d737a42e4b8415458ddf -

[Bug 64384] is ignored if any of max-file-size/max-request-size/file-threshold-size elements are missing

2020-04-27 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=64384 Christopher Schultz changed: What|Removed |Added Resolution|--- |FIXED Status|NEW

[tomcat] branch master updated: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=64384

2020-04-27 Thread schultz
This is an automated email from the ASF dual-hosted git repository. schultz pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/master by this push: new 8dddc11 Fix

[Bug 64373] tag-file reference from .tld in /WEB-INF/classes/META-INF cannot be resolved

2020-04-27 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=64373 --- Comment #3 from Karl von Randow --- That's fantastic, thank you very much Mark. -- You are receiving this mail because: You are the assignee for the bug. - To

[Bug 64384] is ignored if any of max-file-size/max-request-size/file-threshold-size elements are missing

2020-04-27 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=64384 --- Comment #6 from Christopher Schultz --- Initial testing indicates this patch is correct. I'll commit once I build a proper test-case. My guess is that this will not affect uses of @MultipartConfig annotation, as this bug occurs when

Re: [VOTE] Release Apache Tomcat Native 1.2.24

2020-04-27 Thread Michael Osipov
Am 2020-04-24 um 22:10 schrieb Mark Thomas: Version 1.2.24 includes the following changes compared to 1.2.23 - Various improvements to the build process related to OpenSSL - Windows binaries built with OpenSSL 1.1.1g Various other fixes and improvements. See the changelog for details. The

[Bug 64373] tag-file reference from .tld in /WEB-INF/classes/META-INF cannot be resolved

2020-04-27 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=64373 Mark Thomas changed: What|Removed |Added Resolution|--- |FIXED Status|NEW

buildbot failure in on tomcat-trunk

2020-04-27 Thread buildbot
The Buildbot has detected a new failure on builder tomcat-trunk while building tomcat. Full details are available at: https://ci.apache.org/builders/tomcat-trunk/builds/5144 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: asf946_ubuntu Build Reason: The AnyBranchScheduler

[tomcat] branch 8.5.x updated: Fix bz 64373. Ensure tag file unpacked from WAR can be found.

2020-04-27 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/8.5.x by this push: new 59bd13c Fix bz 64373. Ensure tag file unpacked

[tomcat] branch 9.0.x updated: Fix bz 64373. Ensure tag file unpacked from WAR can be found.

2020-04-27 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new d361c6e Fix bz 64373. Ensure tag file unpacked

[tomcat] branch master updated: Fix bz 64373. Ensure tag file unpacked from WAR can be found.

2020-04-27 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/master by this push: new 224fb6c Fix bz 64373. Ensure tag file unpacked

[Bug 64384] is ignored if any of max-file-size/max-request-size/file-threshold-size elements are missing

2020-04-27 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=64384 Christopher Schultz changed: What|Removed |Added Summary| is | is |ignored when there is no

[Bug 64384] is ignored when there is no element specified

2020-04-27 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=64384 --- Comment #4 from Christopher Schultz --- Created attachment 37199 --> https://bz.apache.org/bugzilla/attachment.cgi?id=37199=edit Proposed patch -- You are receiving this mail because: You are the assignee for the bug.

[Bug 64384] is ignored when there is no element specified

2020-04-27 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=64384 --- Comment #3 from Christopher Schultz --- I think I've found the problem, at ContextConfig:1355: 1355MultipartDef multipartdef = servlet.getMultipartDef(); 1356if (multipartdef != null) { 1357 if

[Bug 64373] tag-file reference from .tld in /WEB-INF/classes/META-INF cannot be resolved

2020-04-27 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=64373 --- Comment #1 from Mark Thomas --- Looking at this now... Yes, it is a spec requirement (JSP.8.4.1) that for tags packaged in a JAR the path must always start with "/META-INF/tags/..." -- You are receiving this mail because: You are the

[Bug 64384] is ignored when there is no element specified

2020-04-27 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=64384 --- Comment #2 from Remy Maucherat --- Ok, ok, the check here looks inaccurate: https://github.com/apache/tomcat/blob/master/java/org/apache/catalina/startup/ContextConfig.java#L1365 Unless all are set, only the location would be used. --

[Bug 64384] is ignored when there is no element specified

2020-04-27 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=64384 --- Comment #1 from Christopher Schultz --- Created attachment 37198 --> https://bz.apache.org/bugzilla/attachment.cgi?id=37198=edit Sample WAR file which reproduces the issue This WAR file (including source) will work as expected: 1.

[Bug 64384] New: is ignored when there is no element specified

2020-04-27 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=64384 Bug ID: 64384 Summary: is ignored when there is no element specified Product: Tomcat 8 Version: 8.5.51 Hardware: PC OS: Mac OS X 10.1

[Bug 64157] Tomcat 7 performance: enable tomcat to pre-start pool of min spare threads optionally

2020-04-27 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=64157 Mark Thomas changed: What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|---

[Bug 64155] Tomcat 7 Performance: acceptor thread bottleneck at getPoolSize() located at TaskQueue offer function

2020-04-27 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=64155 Mark Thomas changed: What|Removed |Added Resolution|--- |WORKSFORME Status|NEEDINFO

[Bug 62918] Tomcat Manager Server Status Errors After updating from 8.5.34 to 8.5.35. javax.management.AttributeNotFoundException: Cannot find attribute maxThreads for org.apache.tomcat.util.net.Sock

2020-04-27 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62918 --- Comment #5 from Remy Maucherat --- This works for me on 8.5.54. You should investigate on the user list if you run into problems. -- You are receiving this mail because: You are the assignee for the bug.

svn commit: r1877066 - in /tomcat: archive/taglibs/ taglibs/

2020-04-27 Thread markt
Author: markt Date: Mon Apr 27 11:28:58 2020 New Revision: 1877066 URL: http://svn.apache.org/viewvc?rev=1877066=rev Log: Archive Taglibs repos Added: tomcat/archive/taglibs/ - copied from r1877065, tomcat/taglibs/ Removed: tomcat/taglibs/

Re: Position on failing tests with vendor-modified OpenSSL packages

2020-04-27 Thread Mark Thomas
On 26/04/2020 10:36, Michael Osipov wrote: > Am 2020-04-24 um 18:30 schrieb Christopher Schultz: >> This comes down to algorithms which have been compiled-out of the >> library, right? So we just need to automatically skip tests which >> attempt to use those algorithms. Not entirely. We are

[GitHub] [tomcat] martin-g commented on pull request #286: optimized code,replace some c-style array

2020-04-27 Thread GitBox
martin-g commented on pull request #286: URL: https://github.com/apache/tomcat/pull/286#issuecomment-619872274 Thanks for cherry-picking the change, Remy! I was interrupted after merging the PR and I was going to do it at lunch break.

[GitHub] [tomcat] rmaucher commented on pull request #286: optimized code,replace some c-style array

2020-04-27 Thread GitBox
rmaucher commented on pull request #286: URL: https://github.com/apache/tomcat/pull/286#issuecomment-619853801 Hmmm :( So, ok, I guess you have to start somewhere, but it is best to have PRs on something meaningful (like at least a small bugfix or real improvement of some sort). Here,

[tomcat] branch 7.0.x updated: optimized code, replace some c-style array

2020-04-27 Thread remm
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch 7.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/7.0.x by this push: new 9af6dc9 optimized code,replace some c-style array

[tomcat] branch 9.0.x updated: optimized code, replace some c-style array

2020-04-27 Thread remm
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new 7b6f1aa optimized code,replace some c-style array

[tomcat] branch 8.5.x updated: optimized code, replace some c-style array

2020-04-27 Thread remm
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/8.5.x by this push: new 73f8d72 optimized code,replace some c-style array

Re: [VOTE] Release Apache Tomcat Native 1.2.24

2020-04-27 Thread Martin Grigorov
On Fri, Apr 24, 2020 at 11:10 PM Mark Thomas wrote: > Version 1.2.24 includes the following changes compared to 1.2.23 > > - Various improvements to the build process related to OpenSSL > > - Windows binaries built with OpenSSL 1.1.1g > > Various other fixes and improvements. See the changelog

[GitHub] [tomcat] martin-g commented on pull request #286: optimized code,replace some c-style array

2020-04-27 Thread GitBox
martin-g commented on pull request #286: URL: https://github.com/apache/tomcat/pull/286#issuecomment-619781821 Thank you, @XavierChengZW ! This is an automated message from the Apache Git Service. To respond to the message,

[tomcat] branch master updated: optimized code, replace some c-style array

2020-04-27 Thread mgrigorov
This is an automated email from the ASF dual-hosted git repository. mgrigorov pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/master by this push: new 2e2ac23 optimized code,replace some c-style