[GitHub] [tomcat-jakartaee-migration] rmaucher commented on issue #20: Skipping files

2021-05-18 Thread GitBox
rmaucher commented on issue #20: URL: https://github.com/apache/tomcat-jakartaee-migration/issues/20#issuecomment-843021850 It would still be interesting to get a zip/war that triggers this issue. Most likely it has a duplicate entry that gets ignored when expanding (I agree: who cares

[tomcat] branch master updated: Remove experimental code

2021-05-18 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/master by this push: new d731971 Remove experimental code d731971 is

Time to create Tomcat 10.1.x and master->main migration

2021-05-18 Thread Mark Thomas
All, Things are starting to move forward for Jakarta EE 10 so I think it is time for us to create the 10.1.x branch. At the same time, I'd like to switch our primary development branches from master to main for all our repos. We would, therefore, end up with the following for the Tomcat

[tomcat] branch 8.5.x updated: Fix BZ 65311. Correct race condition that could lead to short delay

2021-05-18 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/8.5.x by this push: new b42b6fe Fix BZ 65311. Correct race condition that

[Bug 65311] NioBlockingSelector.BlockPoller.run() may not be wakeup in time

2021-05-18 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=65311 Mark Thomas changed: What|Removed |Added Resolution|--- |FIXED Status|NEW

[tomcat] branch 9.0.x updated: Fix BZ 65311. Correct race condition that could lead to short delay

2021-05-18 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new dc442e5 Fix BZ 65311. Correct race condition that

[tomcat] branch master updated: Partial fix for BZ 65124. Only generate local out variable when required

2021-05-18 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/master by this push: new 4aab46d Partial fix for BZ 65124. Only generate

Re: JSP code generation optimizations

2021-05-18 Thread Mark Thomas
On 17/05/2021 21:42, Rémy Maucherat wrote: On Mon, May 17, 2021 at 8:47 PM Mark Thomas wrote: Hi all, I am looking at some of the optimizations requested in [1] One of the examples is show below. Code like this is used when the JSP calls a tag. private boolean

Re: Time to create Tomcat 10.1.x and master->main migration

2021-05-18 Thread Raymond Augé
+1 I think it's a great plan. Ray On Tue., May 18, 2021, 8:16 a.m. Romain Manni-Bucau, wrote: > +1 to move forward even if jakarta is not yet adopted (there is a single > time direction - at least at our scale ;)) > -0 to break all clones and related toolings/automotion for hypothetical >

[GitHub] [tomcat-jakartaee-migration] ShamithaSIlva closed issue #20: Skipping files

2021-05-18 Thread GitBox
ShamithaSIlva closed issue #20: URL: https://github.com/apache/tomcat-jakartaee-migration/issues/20 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about

[GitHub] [tomcat-jakartaee-migration] ShamithaSIlva commented on issue #20: Skipping files

2021-05-18 Thread GitBox
ShamithaSIlva commented on issue #20: URL: https://github.com/apache/tomcat-jakartaee-migration/issues/20#issuecomment-843006708 > > Failed to migrate archive [xyz.war]. Using the "-zipInMemory" option may help. > > Exception in thread "main" java.util.zip.ZipException: duplicate

[Bug 65124] Inefficient generated JSP code

2021-05-18 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=65124 --- Comment #12 from Mark Thomas --- Regarding issue 3: The call to _jspx_page_context.getOut() is now only made when required. The variable aliasing is more difficult. For more background see this thread

[Bug 65311] New: NioBlockingSelector.BlockPoller.run() may not be wakeup in time

2021-05-18 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=65311 Bug ID: 65311 Summary: NioBlockingSelector.BlockPoller.run() may not be wakeup in time Product: Tomcat 8 Version: 8.5.31 Hardware: PC OS: Linux

Re: Time to create Tomcat 10.1.x and master->main migration

2021-05-18 Thread Emmanuel Bourg
Le 2021-05-18 14:10, Emmanuel Bourg a écrit : Comments? I don't think the 7.0.x branch should be removed, there is no harm keeping it. As for the master->main change I think that's a waste of time for all of us. i don't buy the argument that "master" is offensive, but by moving awa Grr

Re: Time to create Tomcat 10.1.x and master->main migration

2021-05-18 Thread Rémy Maucherat
On Tue, May 18, 2021 at 1:34 PM Mark Thomas wrote: > All, > > Things are starting to move forward for Jakarta EE 10 so I think it is > time for us to create the 10.1.x branch. At the same time, I'd like to > switch our primary development branches from master to main for all our > repos. > Ah

Re: Time to create Tomcat 10.1.x and master->main migration

2021-05-18 Thread Romain Manni-Bucau
+1 to move forward even if jakarta is not yet adopted (there is a single time direction - at least at our scale ;)) -0 to break all clones and related toolings/automotion for hypothetical reasons, didn't pay in all projects which did AFAIK Romain Manni-Bucau @rmannibucau

Re: Time to create Tomcat 10.1.x and master->main migration

2021-05-18 Thread Emmanuel Bourg
Le 2021-05-18 13:18, Mark Thomas a écrit : All, Things are starting to move forward for Jakarta EE 10 so I think it is time for us to create the 10.1.x branch. At the same time, I'd like to switch our primary development branches from master to main for all our repos. We would, therefore, end

[Bug 65311] NioBlockingSelector.BlockPoller.run() may not "wake up" in time

2021-05-18 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=65311 --- Comment #2 from Remy Maucherat --- Too bad I had to revert the NioBlockingSelector removal, I was too worried of the initial regression I never tried to backport it again. But nobody has complained about it in Tomcat 10, so it's likely

[Bug 65311] NioBlockingSelector.BlockPoller.run() may not "wake up" in time

2021-05-18 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=65311 --- Comment #3 from Mark Thomas --- I'd have no objections if you wanted to back-port it now. -- You are receiving this mail because: You are the assignee for the bug. - To

Re: JSP code generation optimizations

2021-05-18 Thread Mark Thomas
On 18/05/2021 15:42, Christopher Schultz wrote: Mark, On 5/17/21 14:47, Mark Thomas wrote: Hi all, I am looking at some of the optimizations requested in [1] One of the examples is show below. Code like this is used when the JSP calls a tag. private boolean

Re: JSP code generation optimizations

2021-05-18 Thread Christopher Schultz
Mark, On 5/17/21 14:47, Mark Thomas wrote: Hi all, I am looking at some of the optimizations requested in [1] One of the examples is show below. Code like this is used when the JSP calls a tag. private boolean _jspx_meth_mytag_005fhelloWorld_005f0(     jakarta.servlet.jsp.PageContext

Re: Time to create Tomcat 10.1.x and master->main migration

2021-05-18 Thread Coty Sutherland
On Tue, May 18, 2021 at 7:34 AM Mark Thomas wrote: > All, > > Things are starting to move forward for Jakarta EE 10 so I think it is > time for us to create the 10.1.x branch. At the same time, I'd like to > switch our primary development branches from master to main for all our > repos. > > We

[Bug 65124] Inefficient generated JSP code

2021-05-18 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=65124 --- Comment #13 from Mark Thomas --- I've spent some time this afternoon looking at issue 1. Tomcat's tagPlugin mechanism is the supported way to approach this. It lets you generate your own optimised code for tags. It is pretty flexible so

[Bug 65124] Inefficient generated JSP code

2021-05-18 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=65124 --- Comment #14 from Mark Thomas --- Created attachment 37867 --> https://bz.apache.org/bugzilla/attachment.cgi?id=37867=edit Sample plug-in for -- You are receiving this mail because: You are the assignee for the bug.

[Bug 65311] NioBlockingSelector.BlockPoller.run() may not "wake up" in time

2021-05-18 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=65311 Christopher Schultz changed: What|Removed |Added Summary|NioBlockingSelector.BlockPo |NioBlockingSelector.BlockPo

[tomcat] branch 7.0.x updated: Guard new escape routines for null values

2021-05-18 Thread fschumacher
This is an automated email from the ASF dual-hosted git repository. fschumacher pushed a commit to branch 7.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/7.0.x by this push: new 7d709b5 Guard new escape routines for null

[GitHub] [tomcat-jakartaee-migration] rmaucher commented on issue #20: Skipping files

2021-05-18 Thread GitBox
rmaucher commented on issue #20: URL: https://github.com/apache/tomcat-jakartaee-migration/issues/20#issuecomment-842957167 > Failed to migrate archive [xyz.war]. Using the "-zipInMemory" option may help. > Exception in thread "main" java.util.zip.ZipException: duplicate entry: