On 24/09/2021 19:21, Christopher Schultz wrote:
Mark,
Sorry for the top-post but this is quite a long patch and it will be
easier to find my comments up here.
No problem. Makes sense.
When generating the String value for the request identifier, you could use:
private String requestId =
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/main by this push:
new e11f2ef Remove incorrect comment
e11f2ef is
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch 10.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/10.0.x by this push:
new 3b3cf12 Remove incorrect comment
3b3cf12 is
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch 9.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/9.0.x by this push:
new d01cf5a Remove incorrect comment
d01cf5a is
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch 8.5.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/8.5.x by this push:
new efd7c27 Remove incorrect comment
efd7c27 is
This is an automated email from the ASF dual-hosted git repository.
schultz pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/tomcat.git.
at b7c1897 Fix typo
No new revisions were added by this update.
On 24/09/2021 18:30, ma...@apache.org wrote:
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/main by this push:
new
Mark,
On 9/24/21 14:39, Mark Thomas wrote:
On 24/09/2021 19:21, Christopher Schultz wrote:
Mark,
Sorry for the top-post but this is quite a long patch and it will be
easier to find my comments up here.
No problem. Makes sense.
When generating the String value for the request identifier,
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/main by this push:
new b7c05a8 Implement the new connection ID and request
Mark,
I haven't looked at the patch yet but I was thinking about this since
you mentioned it at ApacheCon.
Many load-balancers and other similar network systems are capable of
generating their own request-identifiers and sending them as request
headers to origin servers. I think it would
Mark,
Sorry for the top-post but this is quite a long patch and it will be
easier to find my comments up here.
When generating the String value for the request identifier, you could use:
private String requestId =
Long.toHexString(requestIdGenerator.getAndIncrement());
This would
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch 10.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/10.0.x by this push:
new c9b14f7 Add support for OpenSSL 3.1.x to unit
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch 9.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/9.0.x by this push:
new 7d03135 Add support for OpenSSL 3.1.x to unit
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch 8.5.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/8.5.x by this push:
new d994418 Add support for OpenSSL 3.1.x to unit
On 24/09/2021 19:03, Christopher Schultz wrote:
Mark,
I haven't looked at the patch yet but I was thinking about this since
you mentioned it at ApacheCon.
Many load-balancers and other similar network systems are capable of
generating their own request-identifiers and sending them as
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/main by this push:
new 0608beb Use base 16 rather than base 10 for IDs.
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/main by this push:
new b22d93f Add support for OpenSSL 3.1.x to unit tests
martin-g commented on a change in pull request #452:
URL: https://github.com/apache/tomcat/pull/452#discussion_r715524193
##
File path: java/org/apache/catalina/filters/RestCsrfPreventionFilter.java
##
@@ -217,6 +238,10 @@ public boolean apply(HttpServletRequest request,
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/main by this push:
new 015c48b Additional clean-up after removal of APR
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch 10.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
commit 27f14e32bd43b4471617269f0857e418c089bb0e
Author: Mark Thomas
AuthorDate: Fri Sep 24 12:59:19 2021 +0100
Additional
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch 9.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
commit f14610e7237db303ca9bdffe3371f8a80d83aa72
Author: Mark Thomas
AuthorDate: Fri Sep 24 13:06:02 2021 +0100
Backport
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch 9.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
commit 7746fbcd250739fbb54e423cdccfb67880ffe78c
Author: Mark Thomas
AuthorDate: Fri Sep 24 12:59:19 2021 +0100
Additional
This is an automated email from the ASF dual-hosted git repository.
markt pushed a change to branch 9.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git.
from 0004b62 Fix incorrect indent
new 7746fbc Additional clean-up after removal of APR
new f14610e Backport
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/main by this push:
new 4e96884 Remove deprecated method
4e96884 is
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/main by this push:
new 7f8f1ca Avoid using deprecated method
7f8f1ca is
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch 10.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
commit 92e139a5876448b36f60294776d5a48f1df48db1
Author: Mark Thomas
AuthorDate: Fri Sep 24 13:06:02 2021 +0100
Backport
This is an automated email from the ASF dual-hosted git repository.
markt pushed a change to branch 10.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git.
from a7550fb Fix incorrect indent
new 27f14e3 Additional clean-up after removal of APR
new 92e139a Backport
27 matches
Mail list logo
