svn commit: r451529 - /tomcat/jasper/tc5.5.x/src/share/org/apache/jasper/compiler/PageDataImpl.java

2006-09-29 Thread markt
Author: markt Date: Fri Sep 29 20:39:02 2006 New Revision: 451529 URL: http://svn.apache.org/viewvc?view=rev&rev=451529 Log: Tabs to 8 spaces. No functional change. Modified: tomcat/jasper/tc5.5.x/src/share/org/apache/jasper/compiler/PageDataImpl.java Modified: tomcat/jasper/tc5.5.x/src/sha

DO NOT REPLY [Bug 39594] - Bug for creating relative context in the server.xml

2006-09-29 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bu

DO NOT REPLY [Bug 34956] - Tomcat should enforce the requirements from servlet 2.4 specification SRV.8.2

2006-09-29 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bu

DO NOT REPLY [Bug 35746] - session manager should be immune to system clock time changes (solution provided)

2006-09-29 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bu

DO NOT REPLY [Bug 34956] - Tomcat should enforce the requirements from servlet 2.4 specification SRV.8.2

2006-09-29 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bu

DO NOT REPLY [Bug 34956] - Tomcat should enforce the requirements from servlet 2.4 specification SRV.8.2

2006-09-29 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bu

DO NOT REPLY [Bug 34952] - Installer modifies windows service when it shouldn't

2006-09-29 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bu

svn commit: r451510 - /tomcat/connectors/trunk/util/java/org/apache/tomcat/util/buf/B2CConverter.java

2006-09-29 Thread markt
Author: markt Date: Fri Sep 29 17:51:58 2006 New Revision: 451510 URL: http://svn.apache.org/viewvc?view=rev&rev=451510 Log: Tabs to 8 spaces. No functional change. Modified: tomcat/connectors/trunk/util/java/org/apache/tomcat/util/buf/B2CConverter.java Modified: tomcat/connectors/trunk/ut

svn commit: r451509 - in /tomcat/container/tc5.5.x/webapps/docs: changelog.xml setup.xml

2006-09-29 Thread markt
Author: markt Date: Fri Sep 29 17:50:55 2006 New Revision: 451509 URL: http://svn.apache.org/viewvc?view=rev&rev=451509 Log: Clarify behaviour when using Windows installer. Modified: tomcat/container/tc5.5.x/webapps/docs/changelog.xml tomcat/container/tc5.5.x/webapps/docs/setup.xml Modif

svn commit: r451508 - /tomcat/build/tc5.5.x/tomcat.nsi

2006-09-29 Thread markt
Author: markt Date: Fri Sep 29 17:49:37 2006 New Revision: 451508 URL: http://svn.apache.org/viewvc?view=rev&rev=451508 Log: Make installer text clearer that Tomcat is always installed as a service. Modified: tomcat/build/tc5.5.x/tomcat.nsi Modified: tomcat/build/tc5.5.x/tomcat.nsi URL: htt

svn commit: r451507 - in /tomcat/site/trunk: docs/download-55.html xdocs/download-55.xml

2006-09-29 Thread markt
Author: markt Date: Fri Sep 29 17:36:56 2006 New Revision: 451507 URL: http://svn.apache.org/viewvc?view=rev&rev=451507 Log: (empty) Modified: tomcat/site/trunk/docs/download-55.html tomcat/site/trunk/xdocs/download-55.xml Modified: tomcat/site/trunk/docs/download-55.html URL: http://sv

DO NOT REPLY [Bug 40633] - DefaultContext tag still referenced in doc.

2006-09-29 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bu

svn commit: r451501 - in /tomcat/container/tc5.5.x/webapps/docs: changelog.xml config/context.xml config/engine.xml config/globalresources.xml config/host.xml funcspecs/mbean-names.xml jndi-resources-

2006-09-29 Thread markt
Author: markt Date: Fri Sep 29 17:23:26 2006 New Revision: 451501 URL: http://svn.apache.org/viewvc?view=rev&rev=451501 Log: Fix bug 40625. Remove DefaultContext from docs. Modified: tomcat/container/tc5.5.x/webapps/docs/changelog.xml tomcat/container/tc5.5.x/webapps/docs/config/context.x

DO NOT REPLY [Bug 40625] - CGIServlet eats root cause

2006-09-29 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bu

svn commit: r451495 - /tomcat/tc6.0.x/trunk/java/org/apache/catalina/servlets/CGIServlet.java

2006-09-29 Thread markt
Author: markt Date: Fri Sep 29 16:45:02 2006 New Revision: 451495 URL: http://svn.apache.org/viewvc?view=rev&rev=451495 Log: Port patch for 40625. Modified: tomcat/tc6.0.x/trunk/java/org/apache/catalina/servlets/CGIServlet.java Modified: tomcat/tc6.0.x/trunk/java/org/apache/catalina/servlets

svn commit: r451494 - in /tomcat/container/tc5.5.x: catalina/src/share/org/apache/catalina/servlets/CGIServlet.java webapps/docs/changelog.xml

2006-09-29 Thread markt
Author: markt Date: Fri Sep 29 16:44:34 2006 New Revision: 451494 URL: http://svn.apache.org/viewvc?view=rev&rev=451494 Log: Fix bug 40625. Patch by Takayoshi Kimura. Modified: tomcat/container/tc5.5.x/catalina/src/share/org/apache/catalina/servlets/CGIServlet.java tomcat/container/tc5.5

svn commit: r451485 - /tomcat/tc6.0.x/trunk/RELEASE-NOTES

2006-09-29 Thread remm
Author: remm Date: Fri Sep 29 15:42:21 2006 New Revision: 451485 URL: http://svn.apache.org/viewvc?view=rev&rev=451485 Log: - Update the release notes. Modified: tomcat/tc6.0.x/trunk/RELEASE-NOTES Modified: tomcat/tc6.0.x/trunk/RELEASE-NOTES URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/

svn commit: r451480 - in /tomcat/tc6.0.x/trunk: java/org/apache/catalina/ha/tcp/SimpleTcpCluster.java webapps/docs/config/cluster.xml

2006-09-29 Thread fhanik
Author: fhanik Date: Fri Sep 29 15:38:04 2006 New Revision: 451480 URL: http://svn.apache.org/viewvc?view=rev&rev=451480 Log: Started documenting the cluster configuration. On to the sub components Modified: tomcat/tc6.0.x/trunk/java/org/apache/catalina/ha/tcp/SimpleTcpCluster.java tomcat

Re: Tomcat keepAliveTimeout

2006-09-29 Thread Remy Maucherat
Filip Hanik - Dev Lists wrote: I like the trick, it's smart, but I believe we could also achieve it with keep alive request limits, ie, when thread count gets high, turn off keep alive by mocking maxKeepAliveRequests="1" ie, this way it doesn't affect the servlet and its usage of the stream.

DO NOT REPLY [Bug 38898] - Tomcat service fails without error message

2006-09-29 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bu

Re: [6.0] Updates

2006-09-29 Thread Filip Hanik - Dev Lists
Costin Manolache wrote: On 9/29/06, Remy Maucherat <[EMAIL PROTECTED]> wrote: Costin Manolache wrote: > IMO both clustering implementations should be provided as separate > downloads. > > No need to put them in sandbox ( since they were released in the past, it's > 'proven' code ). > Not sure i

svn commit: r451370 - /tomcat/tc6.0.x/trunk/webapps/docs/config/

2006-09-29 Thread fhanik
Author: fhanik Date: Fri Sep 29 11:09:25 2006 New Revision: 451370 URL: http://svn.apache.org/viewvc?view=rev&rev=451370 Log: Add in skeleton documentation for clustering, so that we can document in accordance to all the other elements in server.xml Added: tomcat/tc6.0.x/trunk/webapps/docs/c

Re: Tomcat keepAliveTimeout

2006-09-29 Thread Filip Hanik - Dev Lists
I like the trick, it's smart, but I believe we could also achieve it with keep alive request limits, ie, when thread count gets high, turn off keep alive by mocking maxKeepAliveRequests="1" ie, this way it doesn't affect the servlet and its usage of the stream. Filip Remy Maucherat wrote: Ml

Re: Tomcat keepAliveTimeout

2006-09-29 Thread Mladen Turk
Remy Maucherat wrote: Mladen Turk wrote: semi useless, LOL :) "when the number of threads gets lower, it tends to use fewer threads" Ok, it's the opposite: "when the number of threads gets higher, it will try using fewer threads". Looking at the code will makes this obvious. Look. My patc

Re: Tomcat keepAliveTimeout

2006-09-29 Thread Remy Maucherat
Mladen Turk wrote: semi useless, LOL :) "when the number of threads gets lower, it tends to use fewer threads" Ok, it's the opposite: "when the number of threads gets higher, it will try using fewer threads". Looking at the code will makes this obvious. I was talking about the soTimeout. Ac

Re: Tomcat keepAliveTimeout

2006-09-29 Thread Mladen Turk
Remy Maucherat wrote: Mladen Turk wrote: Filip Hanik - Dev Lists wrote: you are correct, soTimeout should not, imho, change depending on the thread count. if the user sets 20 seconds for soTimeout then it should stay that way. Right. With the current code you can only deduct what the actual

DO NOT REPLY [Bug 40645] New: - factory "parameter" in ResourceParams block

2006-09-29 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bu

Re: Tomcat keepAliveTimeout

2006-09-29 Thread Remy Maucherat
Mladen Turk wrote: Filip Hanik - Dev Lists wrote: you are correct, soTimeout should not, imho, change depending on the thread count. if the user sets 20 seconds for soTimeout then it should stay that way. Right. With the current code you can only deduct what the actual timeout will be. Like

svn commit: r451345 - in /tomcat/tc6.0.x/trunk/java/org/apache: catalina/startup/ContextConfig.java jasper/compiler/Generator.java

2006-09-29 Thread remm
Author: remm Date: Fri Sep 29 09:45:17 2006 New Revision: 451345 URL: http://svn.apache.org/viewvc?view=rev&rev=451345 Log: - Add back two reverted patches. Modified: tomcat/tc6.0.x/trunk/java/org/apache/catalina/startup/ContextConfig.java tomcat/tc6.0.x/trunk/java/org/apache/jasper/compi

svn commit: r451343 - in /tomcat/tc6.0.x/trunk: conf/ java/org/apache/catalina/ java/org/apache/catalina/core/ java/org/apache/catalina/ha/ java/org/apache/catalina/ha/session/ java/org/apache/catalin

2006-09-29 Thread fhanik
Author: fhanik Date: Fri Sep 29 09:32:32 2006 New Revision: 451343 URL: http://svn.apache.org/viewvc?view=rev&rev=451343 Log: Update configurations options, this new feature allows a specific to overwrite what cluster manager is used by specifying a element inside the context element and the c

Re: Tomcat keepAliveTimeout

2006-09-29 Thread Mladen Turk
Filip Hanik - Dev Lists wrote: you are correct, soTimeout should not, imho, change depending on the thread count. if the user sets 20 seconds for soTimeout then it should stay that way. Right. With the current code you can only deduct what the actual timeout will be. Like said, for 40 sec tim

Re: [6.0] Updates

2006-09-29 Thread Costin Manolache
On 9/29/06, Remy Maucherat <[EMAIL PROTECTED]> wrote: Costin Manolache wrote: > IMO both clustering implementations should be provided as separate > downloads. > > No need to put them in sandbox ( since they were released in the past, it's > 'proven' code ). > Not sure if they should be in separ

svn commit: r451339 - /tomcat/tc6.0.x/trunk/test/org/apache/catalina/tribes/test/channel/TestDataIntegrity.java

2006-09-29 Thread fhanik
Author: fhanik Date: Fri Sep 29 09:21:26 2006 New Revision: 451339 URL: http://svn.apache.org/viewvc?view=rev&rev=451339 Log: increased tolerance on the test Modified: tomcat/tc6.0.x/trunk/test/org/apache/catalina/tribes/test/channel/TestDataIntegrity.java Modified: tomcat/tc6.0.x/trunk/te

Re: Tomcat keepAliveTimeout

2006-09-29 Thread Filip Hanik - Dev Lists
you are correct, soTimeout should not, imho, change depending on the thread count. if the user sets 20 seconds for soTimeout then it should stay that way. on blocking io, soTimeout naturally becomes keepAliveTimeout, as when the request is complete, you go into read() again. on non blocking io

Tomcat keepAliveTimeout

2006-09-29 Thread Mladen Turk
Hi, The problem is that we presume that socket timeout is keep-alive timeout, and that is wrong. The reason is simple because the time between two requests has noting to do with the the time the data will be read. Also, the thing like reading the request is dependent on the number of client conn

Re: ApacheCon US - Austin

2006-09-29 Thread Yoav Shapira
I'd love to, but I'm not going to be there unfortunately ;( Just came back from vacation, can't take another... Yoav On 9/29/06, Filip Hanik - Dev Lists <[EMAIL PROTECTED]> wrote: is anyone from this group gonna attend? Austin is only 3hours from where I live so I will be there the whole week

svn commit: r451318 - in /tomcat/tc6.0.x/trunk/java/org/apache: catalina/connector/ catalina/startup/ coyote/ajp/ coyote/http11/ jasper/compiler/ tomcat/util/net/

2006-09-29 Thread mturk
Author: mturk Date: Fri Sep 29 07:58:32 2006 New Revision: 451318 URL: http://svn.apache.org/viewvc?view=rev&rev=451318 Log: Revert Keep-Alive patch. Modified: tomcat/tc6.0.x/trunk/java/org/apache/catalina/connector/mbeans-descriptors.xml tomcat/tc6.0.x/trunk/java/org/apache/catalina/sta

ApacheCon US - Austin

2006-09-29 Thread Filip Hanik - Dev Lists
is anyone from this group gonna attend? Austin is only 3hours from where I live so I will be there the whole week (Mon-Fri) I think it would be neat to get together, maybe during the hackathon or just for a drink in the bar and b.s. a little. Filip -

Re: [6.0] Updates

2006-09-29 Thread Filip Hanik - Dev Lists
Remy Maucherat wrote: Costin Manolache wrote: IMO both clustering implementations should be provided as separate downloads. No need to put them in sandbox ( since they were released in the past, it's 'proven' code ). Not sure if they should be in separate repos or it's ok to have both of the

Re: svn commit: r451157 - in /tomcat/tc6.0.x/trunk/java/org/apache: catalina/connector/ coyote/ajp/ coyote/http11/ tomcat/util/net/

2006-09-29 Thread Filip Hanik - Dev Lists
Remy Maucherat wrote: Filip Hanik - Dev Lists wrote: Remy Maucherat wrote: [EMAIL PROTECTED] wrote: Author: mturk Date: Fri Sep 29 01:23:37 2006 New Revision: 451157 URL: http://svn.apache.org/viewvc?view=rev&rev=451157 Log: Introduce keepAliveTimeout to be able to separate the Keep-Alive and

Re: svn commit: r451157 - in /tomcat/tc6.0.x/trunk/java/org/apache: catalina/connector/ coyote/ajp/ coyote/http11/ tomcat/util/net/

2006-09-29 Thread Remy Maucherat
Filip Hanik - Dev Lists wrote: Remy Maucherat wrote: [EMAIL PROTECTED] wrote: Author: mturk Date: Fri Sep 29 01:23:37 2006 New Revision: 451157 URL: http://svn.apache.org/viewvc?view=rev&rev=451157 Log: Introduce keepAliveTimeout to be able to separate the Keep-Alive and Socket timeout. The pa

RE: ANN] Apache Tomcat v5.5.20 Now Available

2006-09-29 Thread Warren Lewis
Hi, The changelog still points to Tomcat 5.5.17. cheers - Warren -Original Message- From: Filip Hanik - Dev Lists [mailto:[EMAIL PROTECTED] Sent: Thursday, September 28, 2006 11:57 AM To: Tomcat Developers List; Tomcat Users List; announce@apache.org Subject: ANN] Apache Tomcat v5.5.2

Re: svn commit: r451157 - in /tomcat/tc6.0.x/trunk/java/org/apache: catalina/connector/ coyote/ajp/ coyote/http11/ tomcat/util/net/

2006-09-29 Thread Filip Hanik - Dev Lists
Remy Maucherat wrote: [EMAIL PROTECTED] wrote: Author: mturk Date: Fri Sep 29 01:23:37 2006 New Revision: 451157 URL: http://svn.apache.org/viewvc?view=rev&rev=451157 Log: Introduce keepAliveTimeout to be able to separate the Keep-Alive and Socket timeout. The patch enables to have infinite soc

svn commit: r451231 - /tomcat/tc6.0.x/trunk/java/org/apache/jasper/compiler/Generator.java

2006-09-29 Thread remm
Author: remm Date: Fri Sep 29 04:09:42 2006 New Revision: 451231 URL: http://svn.apache.org/viewvc?view=rev&rev=451231 Log: - Try/catch around the clear buffer, as if the writer was closed the original exception will not be displayed. Modified: tomcat/tc6.0.x/trunk/java/org/apache/jasper/com

Re: [6.0] Updates

2006-09-29 Thread Remy Maucherat
Costin Manolache wrote: IMO both clustering implementations should be provided as separate downloads. No need to put them in sandbox ( since they were released in the past, it's 'proven' code ). Not sure if they should be in separate repos or it's ok to have both of them in the main tree. Wo

Re: Quick question - JSP2.1/Servlet2.5 support in tomcat?

2006-09-29 Thread Remy Maucherat
Kevin Jackson wrote: What is the current status of tomcat with respect to JSP2.1 spec (specifically the unified expression language feature)? The SVN repository is here: http://svn.apache.org/repos/asf/tomcat/tc6.0.x/trunk/ Also any area of the code a n00b could get involved in/help out with?

svn commit: r451207 - in /tomcat/tc6.0.x/trunk/java/org/apache: coyote/http11/Http11AprProtocol.java tomcat/util/net/AprEndpoint.java

2006-09-29 Thread remm
Author: remm Date: Fri Sep 29 02:57:41 2006 New Revision: 451207 URL: http://svn.apache.org/viewvc?view=rev&rev=451207 Log: - The keep alive value is actually in the endpoint. Modified: tomcat/tc6.0.x/trunk/java/org/apache/coyote/http11/Http11AprProtocol.java tomcat/tc6.0.x/trunk/java/org

Quick question - JSP2.1/Servlet2.5 support in tomcat?

2006-09-29 Thread Kevin Jackson
Hi all, Sorry to just drop in with this question, but I couldn't find anything related @ MARC so I thought the dev list would be the place to ask What is the current status of tomcat with respect to JSP2.1 spec (specifically the unified expression language feature)? Also any area of the code a

svn commit: r451202 - in /tomcat/tc6.0.x/trunk/java/org/apache: catalina/connector/ coyote/ajp/ coyote/http11/ tomcat/util/net/

2006-09-29 Thread remm
Author: remm Date: Fri Sep 29 02:42:56 2006 New Revision: 451202 URL: http://svn.apache.org/viewvc?view=rev&rev=451202 Log: - The addition of keepAliveTimeout is useless for the regular connector, as it already has two different timeouts as an option. - Make it default to soTimeout in the other

svn commit: r451198 - /tomcat/tc6.0.x/trunk/java/org/apache/catalina/startup/ContextConfig.java

2006-09-29 Thread remm
Author: remm Date: Fri Sep 29 02:38:35 2006 New Revision: 451198 URL: http://svn.apache.org/viewvc?view=rev&rev=451198 Log: - Also watch conf/web.xml. Modified: tomcat/tc6.0.x/trunk/java/org/apache/catalina/startup/ContextConfig.java Modified: tomcat/tc6.0.x/trunk/java/org/apache/catalina/s

Re: svn commit: r451157 - in /tomcat/tc6.0.x/trunk/java/org/apache: catalina/connector/ coyote/ajp/ coyote/http11/ tomcat/util/net/

2006-09-29 Thread Remy Maucherat
[EMAIL PROTECTED] wrote: Author: mturk Date: Fri Sep 29 01:23:37 2006 New Revision: 451157 URL: http://svn.apache.org/viewvc?view=rev&rev=451157 Log: Introduce keepAliveTimeout to be able to separate the Keep-Alive and Socket timeout. The patch enables to have infinite socket timeouts while stil

svn commit: r451157 - in /tomcat/tc6.0.x/trunk/java/org/apache: catalina/connector/ coyote/ajp/ coyote/http11/ tomcat/util/net/

2006-09-29 Thread mturk
Author: mturk Date: Fri Sep 29 01:23:37 2006 New Revision: 451157 URL: http://svn.apache.org/viewvc?view=rev&rev=451157 Log: Introduce keepAliveTimeout to be able to separate the Keep-Alive and Socket timeout. The patch enables to have infinite socket timeouts while still having correct keep alive