Re: svn commit: r652743 - /tomcat/trunk/.classpath

2008-05-01 Thread Filip Hanik - Dev Lists
ant -f extras.xml downloads and builds this this filip [EMAIL PROTECTED] wrote: Author: costin Date: Thu May 1 20:18:26 2008 New Revision: 652743 URL: http://svn.apache.org/viewvc?rev=652743&view=rev Log: Match build.xml - exclude webservices, missing deps Not sure why it's checked in - if 'd

svn commit: r652744 - /tomcat/trunk/build.xml

2008-05-01 Thread costin
Author: costin Date: Thu May 1 20:20:37 2008 New Revision: 652744 URL: http://svn.apache.org/viewvc?rev=652744&view=rev Log: Since not beeing able to build with JDK1.6 is so annoying - and commons-dbcp doesn't support jdk1.6 in the first place: - let the compile work with jdk1.6, minus dbcp - ad

svn commit: r652743 - /tomcat/trunk/.classpath

2008-05-01 Thread costin
Author: costin Date: Thu May 1 20:18:26 2008 New Revision: 652743 URL: http://svn.apache.org/viewvc?rev=652743&view=rev Log: Match build.xml - exclude webservices, missing deps Not sure why it's checked in - if 'download' doesn't get the deps and build.xml doesn't build it. Modified: tomca

DO NOT REPLY [Bug 43214] Calls to Embedded.setRealm(Realm) fails

2008-05-01 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=43214 Mark Thomas <[EMAIL PROTECTED]> changed: What|Removed |Added Status|NEW |RESOLVED

DO NOT REPLY [Bug 44908] LoggerConfigurationException Caused by session-timeout Setting in web.xml

2008-05-01 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=44908 Mark Thomas <[EMAIL PROTECTED]> changed: What|Removed |Added Status|NEW |RESOLVED

DO NOT REPLY [Bug 43150] Tomcat and path with pound sign (#) -> ClassNotFoundException

2008-05-01 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=43150 --- Comment #2 from Mark Thomas <[EMAIL PROTECTED]> 2008-05-01 14:24:05 PST --- I have fixed the bits that are clearly broken and proposed the patch for 6.0.x As for the rest, if it ain't broke... -- Configure bugmail: https://issue

svn commit: r652671 - /tomcat/tc6.0.x/trunk/STATUS.txt

2008-05-01 Thread markt
Author: markt Date: Thu May 1 14:27:15 2008 New Revision: 652671 URL: http://svn.apache.org/viewvc?rev=652671&view=rev Log: Propose fix for # in path Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/S

svn commit: r652669 - in /tomcat/trunk/java/org/apache: catalina/startup/ClassLoaderFactory.java jasper/JspCompilationContext.java

2008-05-01 Thread markt
Author: markt Date: Thu May 1 14:25:01 2008 New Revision: 652669 URL: http://svn.apache.org/viewvc?rev=652669&view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=43150 # in installation path stops Tomcat starting Modified: tomcat/trunk/java/org/apache/catalina/startup/ClassL

DO NOT REPLY [Bug 43333] Messed up "Asynchronous writes" (sendfile) documentation

2008-05-01 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=4 --- Comment #1 from Mark Thomas <[EMAIL PROTECTED]> 2008-05-01 14:19:47 PST --- The changes have been committed to trunk and proposed for 6.0.x -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email ---

svn commit: r652668 - /tomcat/tc6.0.x/trunk/STATUS.txt

2008-05-01 Thread markt
Author: markt Date: Thu May 1 14:22:59 2008 New Revision: 652668 URL: http://svn.apache.org/viewvc?rev=652668&view=rev Log: Propose fix for sendfile docs Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/tru

svn commit: r652666 - /tomcat/trunk/webapps/docs/aio.xml

2008-05-01 Thread markt
Author: markt Date: Thu May 1 14:20:45 2008 New Revision: 652666 URL: http://svn.apache.org/viewvc?rev=652666&view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=4 Correct sendfile docs. Modified: tomcat/trunk/webapps/docs/aio.xml Modified: tomcat/trunk/webapps/docs/aio

DO NOT REPLY [Bug 43343] Loss of data and concurrency issue with Catalina session persistent storage

2008-05-01 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=43343 --- Comment #5 from Mark Thomas <[EMAIL PROTECTED]> 2008-05-01 14:15:49 PST --- I have applied a patch to trunk based on the discussion here and proposed it for 6.0.x. -- Configure bugmail: https://issues.apache.org/bugzilla/userpref

svn commit: r652664 - /tomcat/tc6.0.x/trunk/STATUS.txt

2008-05-01 Thread markt
Author: markt Date: Thu May 1 14:13:33 2008 New Revision: 652664 URL: http://svn.apache.org/viewvc?rev=652664&view=rev Log: Propose patch Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?re

svn commit: r652662 - in /tomcat/trunk/java/org/apache/catalina: session/PersistentManagerBase.java valves/PersistentValve.java

2008-05-01 Thread markt
Author: markt Date: Thu May 1 14:11:26 2008 New Revision: 652662 URL: http://svn.apache.org/viewvc?rev=652662&view=rev Log: Fix bug 43343. Correctly handle the case where a request arrives for a session we are in the middle of persisting. Modified: tomcat/trunk/java/org/apache/catalina/sess

DO NOT REPLY [Bug 43142] webapp expanded in a FOLDER named webapps/xxx. war is loaded TWICE

2008-05-01 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=43142 Mark Thomas <[EMAIL PROTECTED]> changed: What|Removed |Added Status|NEW |RESOLVED

svn commit: r652659 - in /tomcat/tc6.0.x/trunk: STATUS.txt java/org/apache/catalina/startup/HostConfig.java webapps/docs/changelog.xml

2008-05-01 Thread markt
Author: markt Date: Thu May 1 13:57:28 2008 New Revision: 652659 URL: http://svn.apache.org/viewvc?rev=652659&view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=43142 Don't assume a directory named xxx.war is a war file Modified: tomcat/tc6.0.x/trunk/STATUS.txt tomcat/t

DO NOT REPLY [Bug 43366] Session Statistics command in manager fails with " Unknown command /sessions"

2008-05-01 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=43366 Mark Thomas <[EMAIL PROTECTED]> changed: What|Removed |Added Status|REOPENED|RESOLVED

svn commit: r652658 - in /tomcat/tc6.0.x/trunk: STATUS.txt java/org/apache/catalina/manager/ManagerServlet.java webapps/docs/changelog.xml

2008-05-01 Thread markt
Author: markt Date: Thu May 1 13:53:19 2008 New Revision: 652658 URL: http://svn.apache.org/viewvc?rev=652658&view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=43366 Provide backwards compatibility for manager sessions command Modified: tomcat/tc6.0.x/trunk/STATUS.txt

DO NOT REPLY [Bug 44877] ClassCastException due to bad TagHandlerPool name generation of two different tags

2008-05-01 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=44877 Mark Thomas <[EMAIL PROTECTED]> changed: What|Removed |Added Status|NEW |RESOLVED

svn commit: r652655 - in /tomcat/tc6.0.x/trunk: STATUS.txt java/org/apache/jasper/compiler/Generator.java webapps/docs/changelog.xml

2008-05-01 Thread markt
Author: markt Date: Thu May 1 13:46:28 2008 New Revision: 652655 URL: http://svn.apache.org/viewvc?rev=652655&view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=44877 Prevent collisions in tag pool names Modified: tomcat/tc6.0.x/trunk/STATUS.txt tomcat/tc6.0.x/trunk/jav

DO NOT REPLY [Bug 43425] Non-compliant annotations

2008-05-01 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=43425 Mark Thomas <[EMAIL PROTECTED]> changed: What|Removed |Added Status|NEW |RESOLVED

svn commit: r652644 - in /tomcat/tc6.0.x/trunk: STATUS.txt java/javax/annotation/security/DenyAll.java java/javax/ejb/EJB.java java/javax/persistence/PersistenceContext.java java/javax/persistence/Per

2008-05-01 Thread markt
Author: markt Date: Thu May 1 13:13:23 2008 New Revision: 652644 URL: http://svn.apache.org/viewvc?rev=652644&view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=43425 Annotations not spec compliant. Patch provided by Dain Sundstrom Added: tomcat/tc6.0.x/trunk/java/javax/per

DO NOT REPLY [Bug 43470] ClassCastException at org.apache.catalina.deploy. NamingResources

2008-05-01 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=43470 Mark Thomas <[EMAIL PROTECTED]> changed: What|Removed |Added Status|NEW |RESOLVED

DO NOT REPLY [Bug 43578] Tomcat fails to start on linux if CATALINA_HOME contains a space

2008-05-01 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=43578 Mark Thomas <[EMAIL PROTECTED]> changed: What|Removed |Added Component|Catalina|Catalina

svn commit: r652629 - in /tomcat/tc6.0.x/trunk: STATUS.txt bin/catalina.sh webapps/docs/changelog.xml

2008-05-01 Thread markt
Author: markt Date: Thu May 1 12:08:12 2008 New Revision: 652629 URL: http://svn.apache.org/viewvc?rev=652629&view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=43578 Fix issue where Tomcat doesn't start if installation path contains a space Modified: tomcat/tc6.0.x/trunk/S

svn commit: r652623 - in /tomcat/tc6.0.x/trunk: STATUS.txt java/org/apache/catalina/deploy/NamingResources.java webapps/docs/changelog.xml

2008-05-01 Thread markt
Author: markt Date: Thu May 1 11:58:16 2008 New Revision: 652623 URL: http://svn.apache.org/viewvc?rev=652623&view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=43470 Fix various class cast exceptions. Based on a patch by Lucas Galfaso. Modified: tomcat/tc6.0.x/trunk/STATUS

svn commit: r652620 - in /tomcat/tc6.0.x/trunk: STATUS.txt java/org/apache/tomcat/util/threads/ThreadWithAttributes.java webapps/docs/changelog.xml

2008-05-01 Thread markt
Author: markt Date: Thu May 1 11:51:26 2008 New Revision: 652620 URL: http://svn.apache.org/viewvc?rev=652620&view=rev Log: Add missing access check. Modified: tomcat/tc6.0.x/trunk/STATUS.txt tomcat/tc6.0.x/trunk/java/org/apache/tomcat/util/threads/ThreadWithAttributes.java tomcat/t

DO NOT REPLY [Bug 43617] attribute values within a .tag(x) file are not properly escaped

2008-05-01 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=43617 Mark Thomas <[EMAIL PROTECTED]> changed: What|Removed |Added Status|NEW |RESOLVED

svn commit: r652595 - in /tomcat/tc6.0.x/trunk: STATUS.txt java/org/apache/jasper/compiler/Generator.java webapps/docs/changelog.xml

2008-05-01 Thread markt
Author: markt Date: Thu May 1 10:58:14 2008 New Revision: 652595 URL: http://svn.apache.org/viewvc?rev=652595&view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=43617 Correctly handle quotes in attribute values for tag(x) files. Based on a patch by Lucas Galfaso. Modified:

DO NOT REPLY [Bug 31257] java.endorsed. dirs is not used when JSP compilation is forked

2008-05-01 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=31257 --- Comment #4 from Mark Thomas <[EMAIL PROTECTED]> 2008-05-01 10:49:04 PST --- This has been committed to 6.0.x and will be in 6.0.17 onwards. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email ---

svn commit: r652593 - in /tomcat/tc6.0.x/trunk: STATUS.txt java/org/apache/jasper/compiler/AntCompiler.java webapps/docs/changelog.xml

2008-05-01 Thread markt
Author: markt Date: Thu May 1 10:51:41 2008 New Revision: 652593 URL: http://svn.apache.org/viewvc?rev=652593&view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=31257 Quote endorsed dirs if they contain a space Modified: tomcat/tc6.0.x/trunk/STATUS.txt tomcat/tc6.0.x/tr

DO NOT REPLY [Bug 29936] XML parser loading problems by container

2008-05-01 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=29936 --- Comment #17 from Mark Thomas <[EMAIL PROTECTED]> 2008-05-01 10:43:29 PST --- This has been committed to 6.0.x and will be in 6.0.17 onwards. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --

svn commit: r652592 - in /tomcat/tc6.0.x/trunk: STATUS.txt java/org/apache/catalina/startup/ContextConfig.java webapps/docs/changelog.xml

2008-05-01 Thread markt
Author: markt Date: Thu May 1 10:46:37 2008 New Revision: 652592 URL: http://svn.apache.org/viewvc?rev=652592&view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=29936 Create digesters and parsers earlier so we aren't using the webapp class loader when we create them. Modified:

svn commit: r652589 - in /tomcat/tc6.0.x/trunk: STATUS.txt java/org/apache/el/lang/ELSupport.java test/org/apache/el/ test/org/apache/el/lang/ test/org/apache/el/lang/TestELSupport.java webapps/docs/c

2008-05-01 Thread markt
Author: markt Date: Thu May 1 10:41:59 2008 New Revision: 652589 URL: http://svn.apache.org/viewvc?rev=652589&view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=43656 Add a test case for additional, related bugs and fix those bugs. Patch by Nils Eckert and test case provided by

DO NOT REPLY [Bug 43656] ELSupport.coerceToType modifies BigDecimal Values

2008-05-01 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=43656 Mark Thomas <[EMAIL PROTECTED]> changed: What|Removed |Added Status|NEW |RESOLVED

DO NOT REPLY [Bug 43683] Accessing Servlet while Reloading context gives 404 error

2008-05-01 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=43683 Mark Thomas <[EMAIL PROTECTED]> changed: What|Removed |Added Status|NEW |RESOLVED

svn commit: r652586 - in /tomcat/tc6.0.x/trunk: STATUS.txt java/org/apache/catalina/core/StandardContextValve.java webapps/docs/changelog.xml

2008-05-01 Thread markt
Author: markt Date: Thu May 1 10:30:53 2008 New Revision: 652586 URL: http://svn.apache.org/viewvc?rev=652586&view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=43683 Prevent 404 during reloading. If servlet is no longer present after re-load, a 404 is returned which will be co

Re: Osgifing Tomcat

2008-05-01 Thread Costin Manolache
Long thread, my summary: 1. Adding OSGI manifests to tomcat jars: there is interest, it will provide benefits for people using tomcat in an OSGI environment. I don't think there is any major controversy - it'll not affect any existing functionality. If Henri or someone familiar with OSGi and inter

Re: Osgifing Tomcat

2008-05-01 Thread Jim Manico
> I just don't have the time. If you keep your responses to a few short paragraphs, you might get more input Filip, hey. May I ask when you think the HttpOnly patch will go live? And Mark, I've spammed you about this as well - I'm running my own custom branch eager to back back inline with the

svn commit: r652564 - /tomcat/tc6.0.x/trunk/STATUS.txt

2008-05-01 Thread fhanik
Author: fhanik Date: Thu May 1 09:14:27 2008 New Revision: 652564 URL: http://svn.apache.org/viewvc?rev=652564&view=rev Log: votes Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=65256

Re: Osgifing Tomcat

2008-05-01 Thread Filip Hanik - Dev Lists
Peter Kriens wrote: I must admit I feel I am walking on eggs ... and I am a bit surprised how few others tune in. there is a reason few others turn in, at this point, you have written, and very well so, about 30 pages of responses. It's just to hard keep up with long essays like that, not t

svn commit: r652554 - /tomcat/tc6.0.x/trunk/STATUS.txt

2008-05-01 Thread remm
Author: remm Date: Thu May 1 08:16:11 2008 New Revision: 652554 URL: http://svn.apache.org/viewvc?rev=652554&view=rev Log: - Votes. Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=6525

Re: Assuring Security by testing

2008-05-01 Thread Jim Manico
> if I got you and Jim correctly, the free service provided by Coverity is almost worthless because the positive to false positive rate is awfully bad? > From your point of view this tool isn't worth 50 k$? Tool being worth 50k? I don't think so. A group a trained humans can do it much cheaper

Re: Mavenizing Tomcat : Was: Osgifing Tomcat

2008-05-01 Thread Rainer Jung
Costin Manolache schrieb: I'm confused - there is a tomcat6/trunk repo - isn't this the trunk ? trunk:http://svn.apache.org/repos/asf/tomcat/trunk/ Tomcat 6.0.x: http://svn.apache.org/repos/asf/tomcat/tc6.0.x/trunk/ Regards, Rainer

Re: Assuring Security by testing

2008-05-01 Thread Michael Osipov
Mark Thomas wrote: Jim Manico wrote: The Fortify Opensource project automatically scans the Tomcat codebase on a regular basis. This probably only gives you 10% security coverage at best, but it's a free report form a $50k tool. http://opensource.fortifysoftware.com A great example of why

Re: Osgifing Tomcat

2008-05-01 Thread Peter Kriens
Regarding 'dynamic register/unregister' - the servlet API defines one way to do this, i.e. war and the deployment. There is no standard API to install/uninstall/start/stop a .war - but HttpService is not that either. Runtime config changes ( adding/removing servlets without web.xml changes an

svn commit: r652447 - /tomcat/tc6.0.x/trunk/STATUS.txt

2008-05-01 Thread markt
Author: markt Date: Thu May 1 00:42:25 2008 New Revision: 652447 URL: http://svn.apache.org/viewvc?rev=652447&view=rev Log: Propose fix for 43142. Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STAT

DO NOT REPLY [Bug 43142] webapp expanded in a FOLDER named webapps/xxx. war is loaded TWICE

2008-05-01 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=43142 --- Comment #1 from Mark Thomas <[EMAIL PROTECTED]> 2008-05-01 00:36:01 PST --- Fixed in trunk and proposed for 6.0.17 onwards. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receivin

svn commit: r652441 - /tomcat/trunk/java/org/apache/catalina/startup/HostConfig.java

2008-05-01 Thread markt
Author: markt Date: Thu May 1 00:00:14 2008 New Revision: 652441 URL: http://svn.apache.org/viewvc?rev=652441&view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=43142 If someone is daft enough to name their directory xxx.war, don't assume it is a war file. Modified: tomcat