DO NOT REPLY [Bug 50633] Stale cookie value obtained with getCookies() after login/logout/login

2011-01-21 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50633 Erik Bruchez changed: What|Removed |Added CC||e...@bruchez.org OS/Version

DO NOT REPLY [Bug 50633] New: Stale cookie value obtained with getCookies() after login/logout/login

2011-01-21 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50633 Summary: Stale cookie value obtained with getCookies() after login/logout/login Product: Tomcat 6 Version: 6.0.30 Platform: Macintosh Status: NEW Severity:

DO NOT REPLY [Bug 49711] HttpServletRequest#getParts() does not work in a Filter

2011-01-21 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49711 Christopher Schultz changed: What|Removed |Added Status|REOPENED|RESOLVED Resolution|

svn commit: r1061960 - /tomcat/trunk/webapps/docs/config/context.xml

2011-01-21 Thread schultz
Author: schultz Date: Fri Jan 21 18:38:28 2011 New Revision: 1061960 URL: http://svn.apache.org/viewvc?rev=1061960&view=rev Log: Fixed typo. Modified: tomcat/trunk/webapps/docs/config/context.xml Modified: tomcat/trunk/webapps/docs/config/context.xml URL: http://svn.apache.org/viewvc/tomcat

svn commit: r1061957 - /tomcat/trunk/java/org/apache/catalina/connector/Request.java

2011-01-21 Thread schultz
Author: schultz Date: Fri Jan 21 18:36:53 2011 New Revision: 1061957 URL: http://svn.apache.org/viewvc?rev=1061957&view=rev Log: Removed debug logging added with r1061929. Modified: tomcat/trunk/java/org/apache/catalina/connector/Request.java Modified: tomcat/trunk/java/org/apache/catalina/c

svn commit: r1061953 - in /tomcat/trunk: java/org/apache/catalina/ java/org/apache/catalina/connector/ java/org/apache/catalina/core/ test/org/apache/catalina/connector/ test/org/apache/catalina/core/

2011-01-21 Thread schultz
Author: schultz Date: Fri Jan 21 18:32:39 2011 New Revision: 1061953 URL: http://svn.apache.org/viewvc?rev=1061953&view=rev Log: Re-fixed bug #49711: HttpServletRequest#getParts() does not work in a Filter - Moved allowCasualMultipartParsing setting from to Modified: tomcat/trunk/java/org/

DO NOT REPLY [Bug 49711] HttpServletRequest#getParts() does not work in a Filter

2011-01-21 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49711 Christopher Schultz changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|

Re: Proposal: set default for Connector.allowCasualMultipartParsing to true

2011-01-21 Thread Konstantin Kolinko
2011/1/21 Christopher Schultz : > What about it's default setting? > I would opt for "false" 1) on the same grounds as Mark 2) what will happen with an older application that itself implements file upload if this feature were enabled globally? +e.printStackTrace(); Us

DO NOT REPLY [Bug 50631] New: InternalNioInputBuffer should honor maxHttpHeadSize

2011-01-21 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50631 Summary: InternalNioInputBuffer should honor maxHttpHeadSize Product: Tomcat 6 Version: 6.0.29 Platform: PC Status: NEW Severity: normal Priority: P2 Compone

Re: Proposal: set default for Connector.allowCasualMultipartParsing to true

2011-01-21 Thread Christopher Schultz
Konstantin, On 1/21/2011 12:57 PM, Konstantin Kolinko wrote: > 2011/1/21 Christopher Schultz : >> All, >> >> I've just committed a fix for >> https://issues.apache.org/bugzilla/show_bug.cgi?id=49711 >> (HttpServletRequest#getParts() does not work in a Filter) with a new >> configuration attribute

Re: Privileges in Bugzilla

2011-01-21 Thread Christopher Schultz
Mark, On 1/21/2011 1:02 PM, Mark Thomas wrote: > On 21/01/2011 17:53, Christopher Schultz wrote: >> All, >> >> I typically use my home email address instead of my @apache.org for >> everything, including BZ. I don't currently have rights to do things >> like assign bugs to myself, etc. Can that be

Re: Proposal: set default for Connector.allowCasualMultipartParsing to true

2011-01-21 Thread Mark Thomas
On 21/01/2011 17:57, Konstantin Kolinko wrote: > 2011/1/21 Christopher Schultz : >> All, >> >> I've just committed a fix for >> https://issues.apache.org/bugzilla/show_bug.cgi?id=49711 >> (HttpServletRequest#getParts() does not work in a Filter) with a new >> configuration attribute on the called

svn commit: r1061940 - in /tomcat/trunk/java/org/apache: catalina/ant/AbstractCatalinaTask.java tomcat/util/net/AprEndpoint.java

2011-01-21 Thread schultz
Author: schultz Date: Fri Jan 21 18:04:38 2011 New Revision: 1061940 URL: http://svn.apache.org/viewvc?rev=1061940&view=rev Log: Reverted inadvertently-committed files from r1061929. Modified: tomcat/trunk/java/org/apache/catalina/ant/AbstractCatalinaTask.java tomcat/trunk/java/org/apache

Re: Privileges in Bugzilla

2011-01-21 Thread Mark Thomas
On 21/01/2011 17:53, Christopher Schultz wrote: > All, > > I typically use my home email address instead of my @apache.org for > everything, including BZ. I don't currently have rights to do things > like assign bugs to myself, etc. Can that be done? Or, should I start > using my @apache.org email

RE: bug in TC6 ContainerBase class?

2011-01-21 Thread Caldarale, Charles R
> From: Christopher Schultz [mailto:ch...@christopherschultz.net] > Subject: Re: bug in TC6 ContainerBase class? > Are you saying that effectively most method calls have > pre- and post-memory barriers? Essentially yes - except in the presence of a JIT. Since a JIT can examine the called meth

Re: Proposal: set default for Connector.allowCasualMultipartParsing to true

2011-01-21 Thread Konstantin Kolinko
2011/1/21 Christopher Schultz : > All, > > I've just committed a fix for > https://issues.apache.org/bugzilla/show_bug.cgi?id=49711 > (HttpServletRequest#getParts() does not work in a Filter) with a new > configuration attribute on the called > allowCasualMultipartParsing whose default value is "f

Re: svn commit: r1061929 - in /tomcat/trunk: java/org/apache/catalina/ant/ java/org/apache/catalina/connector/ java/org/apache/tomcat/util/net/ test/org/apache/catalina/connector/ webapps/docs/ webapp

2011-01-21 Thread Christopher Schultz
All, Oops. I over-committed files. Evidently, svn commit doesn't work like cvs commit. I'll back-out my changes to: tomcat/trunk/java/org/apache/catalina/ant/AbstractCatalinaTask.java tomcat/trunk/java/org/apache/tomcat/util/net/AprEndpoint.java Sorry for the noise. Thanks, -chris On 1/21/201

Re: svn commit: r1061929 - in /tomcat/trunk: java/org/apache/catalina/ant/ java/org/apache/catalina/connector/ java/org/apache/tomcat/util/net/ test/org/apache/catalina/connector/ webapps/docs/ webapp

2011-01-21 Thread Mark Thomas
On 21/01/2011 17:46, schu...@apache.org wrote: > Author: schultz > Date: Fri Jan 21 17:46:03 2011 > New Revision: 1061929 > > URL: http://svn.apache.org/viewvc?rev=1061929&view=rev > Log: > Fixed bug #49711: HttpServletRequest#getParts() does not work in a Filter > - Added attribute allowCasualMu

Privileges in Bugzilla

2011-01-21 Thread Christopher Schultz
All, I typically use my home email address instead of my @apache.org for everything, including BZ. I don't currently have rights to do things like assign bugs to myself, etc. Can that be done? Or, should I start using my @apache.org email address to do that sort of thing? Thanks, -chris signat

DO NOT REPLY [Bug 50234] JspC use servlet 3.0 features

2011-01-21 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50234 --- Comment #2 from Christopher Schultz 2011-01-21 12:52:24 EST --- It looks like annotations don't make any sense, here. Brain fart on my part. On the other hand, it looks like a simple change to a properties file plus a new build-jspc.x

Proposal: set default for Connector.allowCasualMultipartParsing to true

2011-01-21 Thread Christopher Schultz
All, I've just committed a fix for https://issues.apache.org/bugzilla/show_bug.cgi?id=49711 (HttpServletRequest#getParts() does not work in a Filter) with a new configuration attribute on the called allowCasualMultipartParsing whose default value is "false". Please see BZ for details. I propose

DO NOT REPLY [Bug 49711] HttpServletRequest#getParts() does not work in a Filter

2011-01-21 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49711 Christopher Schultz changed: What|Removed |Added Status|NEW |RESOLVED Resolution|

svn commit: r1061929 - in /tomcat/trunk: java/org/apache/catalina/ant/ java/org/apache/catalina/connector/ java/org/apache/tomcat/util/net/ test/org/apache/catalina/connector/ webapps/docs/ webapps/do

2011-01-21 Thread schultz
Author: schultz Date: Fri Jan 21 17:46:03 2011 New Revision: 1061929 URL: http://svn.apache.org/viewvc?rev=1061929&view=rev Log: Fixed bug #49711: HttpServletRequest#getParts() does not work in a Filter - Added attribute allowCasualMultipartParsing (default false) - Requests that contain multipar

Re: bug in TC6 ContainerBase class?

2011-01-21 Thread Christopher Schultz
Chuck, On 1/21/2011 10:02 AM, Caldarale, Charles R wrote: >> From: sebb [mailto:seb...@gmail.com] Subject: Re: bug in TC6 >> ContainerBase class? > >> There is no requirement for the compiler to reload variables >> unless the variable is volatile, or there is a shared lock between >> threads. >

svn commit: r1061900 - in /tomcat/trunk: java/org/apache/tomcat/util/net/NioEndpoint.java webapps/docs/changelog.xml

2011-01-21 Thread markt
Author: markt Date: Fri Jan 21 16:49:02 2011 New Revision: 1061900 URL: http://svn.apache.org/viewvc?rev=1061900&view=rev Log: Fix possible thread exhaustion With a breakpoint in the servlet handling the timeout event, I was seeing a new thread being allocated from the poll every second or so Mo

RE: bug in TC6 ContainerBase class?

2011-01-21 Thread Caldarale, Charles R
> From: sebb [mailto:seb...@gmail.com] > Subject: Re: bug in TC6 ContainerBase class? > Do you mean: > * the compiler must assume that there is no synch, or > * the compiler must assume that there is synch. The latter; in the absence of information to the contrary, the compiler must assume the

Re: svn commit: r1061433 - in /tomcat/tc6.0.x/trunk: ./ java/org/apache/catalina/ha/session/ java/org/apache/catalina/session/ webapps/docs/

2011-01-21 Thread Konstantin Kolinko
2011/1/20 : > Author: markt > Date: Thu Jan 20 18:10:16 2011 > New Revision: 1061433 > > URL: http://svn.apache.org/viewvc?rev=1061433&view=rev > Log: > Add session creation / expiration rate statistics to the session managers > Adds ~10% to the session creation/destruction process when that is al

Re: Current TC 7.0.x/trunk fails to build release

2011-01-21 Thread Christopher Schultz
Konstantin, On 1/21/2011 9:47 AM, Konstantin Kolinko wrote: > 2011/1/21 Christopher Schultz : >> $ ant release > > What is your ant version? 1.8.x is needed. $ ant -version Apache Ant version 1.8.1 compiled on April 30 2010 > Buildbot runs "ant release" repeatedly, and it succeeds Hmm. I'll r

Re: bug in TC6 ContainerBase class?

2011-01-21 Thread sebb
On 21 January 2011 15:52, Konstantin Kolinko wrote: > 2011/1/21 maxxe...@gmail.com : >> In TC6 catalina core, ContainerBase class defines this field to stop >> the background processor thread: >> >>     private boolean threadDone = false; >> >> Shouldn't it be a volatile? Because the background pr

Re: bug in TC6 ContainerBase class?

2011-01-21 Thread Konstantin Kolinko
2011/1/21 maxxe...@gmail.com : > In TC6 catalina core, ContainerBase class defines this field to stop > the background processor thread: > >     private boolean threadDone = false; > > Shouldn't it be a volatile? Because the background processor refers to > a classloader, could it prevent a (weak)

Re: bug in TC6 ContainerBase class?

2011-01-21 Thread sebb
On 21 January 2011 15:02, Caldarale, Charles R wrote: >> From: sebb [mailto:seb...@gmail.com] >> Subject: Re: bug in TC6 ContainerBase class? > >> There is no requirement for the compiler to reload variables unless >> the variable is volatile, or there is a shared lock between threads. > > Correct

[Tomcat Wiki] Update of "PoweredBy" by SvenWoltmann

2011-01-21 Thread Apache Wiki
Dear Wiki user, You have subscribed to a wiki page or wiki category on "Tomcat Wiki" for change notification. The "PoweredBy" page has been changed by SvenWoltmann. http://wiki.apache.org/tomcat/PoweredBy?action=diff&rev1=299&rev2=300 -- {{http

[Tomcat Wiki] Update of "PoweredBy" by SvenWoltmann

2011-01-21 Thread Apache Wiki
Dear Wiki user, You have subscribed to a wiki page or wiki category on "Tomcat Wiki" for change notification. The "PoweredBy" page has been changed by SvenWoltmann. The comment on this change is: Added AndroidPIT. http://wiki.apache.org/tomcat/PoweredBy?action=diff&rev1=298&rev2=299 ---

Re: svn commit: r1061442 - in /tomcat/trunk/java/org/apache/catalina/connector: LocalStrings.properties Request.java

2011-01-21 Thread Konstantin Kolinko
2011/1/21 Mark Thomas : >> How can endAccess throw an exception ? > > I asked myself exactly the same question when I read the bug report. My > conclusion was: > - StandardSession - it can't unless there is a bug > - DeltaSession - it can't unless there is a bug > - Custom session implementation -

RE: bug in TC6 ContainerBase class?

2011-01-21 Thread Caldarale, Charles R
> From: sebb [mailto:seb...@gmail.com] > Subject: Re: bug in TC6 ContainerBase class? > There is no requirement for the compiler to reload variables unless > the variable is volatile, or there is a shared lock between threads. Correct - with one caveat: if the compiler cannot prove there is no

Re: Current TC 7.0.x/trunk fails to build release

2011-01-21 Thread Konstantin Kolinko
2011/1/21 Christopher Schultz : > $ ant release What is your ant version? 1.8.x is needed. Buildbot runs "ant release" repeatedly, and it succeeds E.g. http://ci.apache.org/builders/tomcat-trunk/builds/1181 -> "3. compile" -> look at stdio file Best regards, Konstantin Kolinko --

Current TC 7.0.x/trunk fails to build release

2011-01-21 Thread Christopher Schultz
All, $ svn up At revision 1061823. $ ant release [] logkit-warning: [echo] [echo] *** WARNING *** [echo] LogKit not found: Cannot Build LogKitLogger [echo] jdk1.4-warning: avalon-framework-warning: [echo] [echo] *** WARNING *** [echo] Ava

Re: bug in TC6 ContainerBase class?

2011-01-21 Thread sebb
On 21 January 2011 06:36, Caldarale, Charles R wrote: >> From: sebb [mailto:seb...@gmail.com] >> Subject: Re: bug in TC6 ContainerBase class? > >> What method calls will force a reload? Why must the compiler >> assume it has changed? > > Any other than Thread.sleep().  Again, we are discussing wha

buildbot success in ASF Buildbot on tomcat-trunk

2011-01-21 Thread buildbot
The Buildbot has detected a restored build of tomcat-trunk on ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-trunk/builds/1181 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: bb-vm_ubuntu Build Reason: Build Source Stamp: [branch tomcat/trunk]

Re: Need a 6.0.31 release

2011-01-21 Thread Mark Thomas
On 20/01/2011 16:38, jean-frederic clere wrote: > On 01/20/2011 05:09 PM, Mark Thomas wrote: >> The memory leak in the Tomcat 7 NIO connector [1] got back-ported to >> 6.0.x and included in 6.0.30. [2] >> >> I have proposed the fix for 6.0.x. Given the severity I think we need to >> approve the bac

DO NOT REPLY [Bug 50629] Make the bindThread/unbindThread method protected

2011-01-21 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50629 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|

svn commit: r1061797 - in /tomcat/trunk: java/org/apache/catalina/core/StandardContext.java webapps/docs/changelog.xml

2011-01-21 Thread markt
Author: markt Date: Fri Jan 21 13:17:12 2011 New Revision: 1061797 URL: http://svn.apache.org/viewvc?rev=1061797&view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=50629 Make StandardContext.bindThread() and StandardContext.unbindThread() protected to allow use by sub-classes.

buildbot failure in ASF Buildbot on tomcat-trunk

2011-01-21 Thread buildbot
The Buildbot has detected a new failure of tomcat-trunk on ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-trunk/builds/1180 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: bb-vm_ubuntu Build Reason: Build Source Stamp: [branch tomcat/trunk] 106

DO NOT REPLY [Bug 50629] Make the bindThread/unbindThread method protected

2011-01-21 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50629 --- Comment #1 from Konstantin Kolinko 2011-01-21 07:40:04 EST --- (In reply to comment #0) > But the two methods bindThread and unbindThread is marked as private, Methods of what class? Please, be more specific. -- Configure bugmail: h

svn commit: r1061787 - in /tomcat/trunk: java/org/apache/el/Messages.properties java/org/apache/el/parser/AstDotSuffix.java java/org/apache/el/parser/AstIdentifier.java webapps/docs/changelog.xml

2011-01-21 Thread markt
Author: markt Date: Fri Jan 21 12:39:15 2011 New Revision: 1061787 URL: http://svn.apache.org/viewvc?rev=1061787&view=rev Log: Improve error message & use i18n Modified: tomcat/trunk/java/org/apache/el/Messages.properties tomcat/trunk/java/org/apache/el/parser/AstDotSuffix.java tomcat

DO NOT REPLY [Bug 50629] New: Make the bindThread/unbindThread method protected

2011-01-21 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50629 Summary: Make the bindThread/unbindThread method protected Product: Tomcat 7 Version: trunk Platform: PC OS/Version: Windows XP Status: NEW Severity: enhancement

PoweredBy reverted to revision 290 on Tomcat Wiki

2011-01-21 Thread Apache Wiki
Dear wiki user, You have subscribed to a wiki page "Tomcat Wiki" for change notification. The page PoweredBy has been reverted to revision 290 by KonstantinKolinko. The comment on this change is: Reverted to r290 to remove spam. http://wiki.apache.org/tomcat/PoweredBy?action=diff&rev1=297&rev2=29

Re: svn commit: r1061442 - in /tomcat/trunk/java/org/apache/catalina/connector: LocalStrings.properties Request.java

2011-01-21 Thread Mark Thomas
On 21/01/2011 09:39, Remy Maucherat wrote: > On Thu, 2011-01-20 at 18:34 +, ma...@apache.org wrote: >> Author: markt >> Date: Thu Jan 20 18:34:18 2011 >> New Revision: 1061442 >> >> URL: http://svn.apache.org/viewvc?rev=1061442&view=rev >> Log: >> Fix https://issues.apache.org/bugzilla/show_bug

Re: svn commit: r1061442 - in /tomcat/trunk/java/org/apache/catalina/connector: LocalStrings.properties Request.java

2011-01-21 Thread Remy Maucherat
On Thu, 2011-01-20 at 18:34 +, ma...@apache.org wrote: > Author: markt > Date: Thu Jan 20 18:34:18 2011 > New Revision: 1061442 > > URL: http://svn.apache.org/viewvc?rev=1061442&view=rev > Log: > Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=50620 > Exceptions calling session.endAcces

[Tomcat Wiki] Update of "PoweredBy" by prosch

2011-01-21 Thread Apache Wiki
Dear Wiki user, You have subscribed to a wiki page or wiki category on "Tomcat Wiki" for change notification. The "PoweredBy" page has been changed by prosch. http://wiki.apache.org/tomcat/PoweredBy?action=diff&rev1=296&rev2=297 -- {{http://www