Re: Move to Maven? (WAS: Re: Publishing process for JARs for Maven Central)
+1 - Romain 2011/12/20 David Jencks david_jen...@yahoo.com On Dec 19, 2011, at 1:06 PM, jean-frederic clere wrote: On 12/19/2011 07:47 PM, David Jencks wrote: Are you reading the thread? I mentioned dec 17 that geronimo has been maintaining a script for 2+ years that pulls tomcat source out of tomcat svn and puts it in an appropriately structured maven mutli-project build and we've been re-releasing quite a few tomcat versions using this technique. Not sure how this is talk. I've experienced enough hostility over the years from the tomcat community (not necessarily any currently active members) that I'm reluctant to spend more time on this. So starting with what is in the geronimo repo, how much work would it to have a mavenized Tomcat? I did this work and suggested tomcat look at it several years ago, and don't remember all the details, some other people have been maintaining it recently. IIRC the maven projects generate pretty much the same jars as the ant build, possibly plus one more to get around the circular dependencies among the jars. So to generate a maven multimodule project to build the jars, 20 min to configure the script that builds the project, then you have a mavenized tomcat project checked in that builds pretty much the same jars as the ant build. I don't really know what else the ant build generates. As I have said before in previous iterations of this topic, IMO many of the advantages of maven are not for direct development of the project itself (although they certainly exist) but in encouraging interactions with other projects and communities. You won't be able to detect these without actually using maven. We already publish artifacs, do you need more of them? I think the benefit might be more on the order of encouraging people who ask where did this jar come from-- I wanna fix something. For people familiar with maven, there is IMO a much higher barrier to contributing to tomcat than a well-structured maven project. (BTW I must add that I'm delighted that the tomcat community seems much more receptive to outside input than it did several years ago -- community unfriendliness seems to be totally missing now :-) ). thanks david jencks Cheers Jean-Frederic - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: Move to Maven? (WAS: Re: Publishing process for JARs for Maven Central)
2011/12/19 Mladen Turk mt...@apache.org On 12/19/2011 07:04 PM, Henri Gomez wrote: Exactly. Since any change would require a learning curve and it seems we don't have that many (read none) maven experts in the house, Gradle could be equally considered, given that it seems more advanced in customization. I know well Maven but Olivier (Lamy) is a Maven expert, so there is friend in the business. And there is a full Maven PMC not too far ready to provide advices and help. Not counting Tomcat consumers ASF projects like OpenEJB. All I have seen so far is talk and talk and more talk. There is trunk, branches, sandbox, so anyone is free to make a proposal and if things work, I'll be the first one supporting it. I already forked my own repository from GitHub. I hope to start it after the holidays. Antonio
Re: Move to Maven? (WAS: Re: Publishing process for JARs for Maven Central)
2011/12/19 David Jencks david_jen...@yahoo.com Are you reading the thread? I mentioned dec 17 that geronimo has been maintaining a script for 2+ years that pulls tomcat source out of tomcat svn and puts it in an appropriately structured maven mutli-project build and we've been re-releasing quite a few tomcat versions using this technique. Not sure how this is talk. I've experienced enough hostility over the years from the tomcat community (not necessarily any currently active members) that I'm reluctant to spend more time on this. David, I think that I will use that stuff, do you mind if I do? :-D Antonio
Re: Move to Maven? (WAS: Re: Publishing process for JARs for Maven Central)
On 12/20/2011 08:58 AM, David Jencks wrote: did this work and suggested tomcat look at it several years ago, and don't remember all the details, some other people have been maintaining it recently. IIRC the maven projects generate pretty much the same jars as the ant build, possibly plus one more to get around the circular dependencies among the jars. I think it is fixed in trunk. So to generate a maven multimodule project to build the jars, 20 min to configure the script that builds the project, then you have a mavenized tomcat project checked in that builds pretty much the same jars as the ant build. I don't really know what else the ant build generates. Hm that means that we should be able to switch to maven in a day or 2, I will try that next week then ;-) Cheers Jean-Frederic - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: Move to Maven? (WAS: Re: Publishing process for JARs for Maven Central)
On 12/20/2011 09:17 AM, Antonio Petrelli wrote: 2011/12/19 Mladen Turkmt...@apache.org On 12/19/2011 07:04 PM, Henri Gomez wrote: Exactly. Since any change would require a learning curve and it seems we don't have that many (read none) maven experts in the house, Gradle could be equally considered, given that it seems more advanced in customization. I know well Maven but Olivier (Lamy) is a Maven expert, so there is friend in the business. And there is a full Maven PMC not too far ready to provide advices and help. Not counting Tomcat consumers ASF projects like OpenEJB. All I have seen so far is talk and talk and more talk. There is trunk, branches, sandbox, so anyone is free to make a proposal and if things work, I'll be the first one supporting it. I already forked my own repository from GitHub. I hope to start it after the holidays. Please publish the url... I can fork it and play there too. Cheers Jean-Frederic - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: Move to Maven? (WAS: Re: Publishing process for JARs for Maven Central)
2011/12/20 jean-frederic clere jfcl...@gmail.com On 12/20/2011 09:17 AM, Antonio Petrelli wrote: 2011/12/19 Mladen Turkmt...@apache.org On 12/19/2011 07:04 PM, Henri Gomez wrote: Exactly. Since any change would require a learning curve and it seems we don't have that many (read none) maven experts in the house, Gradle could be equally considered, given that it seems more advanced in customization. I know well Maven but Olivier (Lamy) is a Maven expert, so there is friend in the business. And there is a full Maven PMC not too far ready to provide advices and help. Not counting Tomcat consumers ASF projects like OpenEJB. All I have seen so far is talk and talk and more talk. There is trunk, branches, sandbox, so anyone is free to make a proposal and if things work, I'll be the first one supporting it. I already forked my own repository from GitHub. I hope to start it after the holidays. Please publish the url... I can fork it and play there too. Whoops! I had to do it before :-) First of all, Git is read-only at Apache: http://git.apache.org/ In this page there are many Gitted projects for Tomcat. My current fork is for Tomcat 7: https://github.com/apetrelli/tomcat70 However, since the fork, I did not pushed anything yet. Antonio Cheers Jean-Frederic --**--**- To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.**orgdev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: Move to Maven? (WAS: Re: Publishing process for JARs for Maven Central)
2011/12/19 Pid p...@pidster.com On 18/12/2011 08:37, Mladen Turk wrote: On 12/17/2011 09:24 PM, Antonio Petrelli wrote: As requested here is a proposal to move to Maven. I simply cannot understand why some folks have almost religious fascination with Maven. I know many projects that have move from Ant to Maven and are now either switched back or gone to some other solution like Gradle or are in the active process of seeking the alternative. I was wondering if someone would mention Gradle. If there's a build tool shootout to be had, Gradle should get fair consideration. I tried Gradle some time ago and, IMHO, it is pretty slow compared to Maven 3. Moreover, m2eclipse and Maven have some developers in common and are doing a great work to integrate the various plugins. The Eclipse-Gradle plugin seems not much mature IMHO. However, point in the right direction if I missed something :-) Thanks Antonio
DO NOT REPLY [Bug 52361] JasperException at JSP compilation
https://issues.apache.org/bugzilla/show_bug.cgi?id=52361 l...@dinec.be changed: What|Removed |Added Status|RESOLVED|VERIFIED --- Comment #2 from l...@dinec.be 2011-12-20 08:53:39 UTC --- You are right, this syntax is not correct. This code is not recent and It was successfully compiled with previous tomcat versions so I conclude to quickly it was a bug. Thank you. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: Move to Maven? (WAS: Re: Publishing process for JARs for Maven Central)
2011/12/20 Antonio Petrelli antonio.petre...@gmail.com: 2011/12/20 jean-frederic clere jfcl...@gmail.com On 12/20/2011 09:17 AM, Antonio Petrelli wrote: 2011/12/19 Mladen Turkmt...@apache.org On 12/19/2011 07:04 PM, Henri Gomez wrote: Exactly. Since any change would require a learning curve and it seems we don't have that many (read none) maven experts in the house, Gradle could be equally considered, given that it seems more advanced in customization. I know well Maven but Olivier (Lamy) is a Maven expert, so there is friend in the business. And there is a full Maven PMC not too far ready to provide advices and help. Not counting Tomcat consumers ASF projects like OpenEJB. All I have seen so far is talk and talk and more talk. There is trunk, branches, sandbox, so anyone is free to make a proposal and if things work, I'll be the first one supporting it. I already forked my own repository from GitHub. I hope to start it after the holidays. Please publish the url... I can fork it and play there too. Whoops! I had to do it before :-) First of all, Git is read-only at Apache: http://git.apache.org/ In this page there are many Gitted projects for Tomcat. My current fork is for Tomcat 7: https://github.com/apetrelli/tomcat70 However, since the fork, I did not pushed anything yet. Have a look at the maven layout I have done here: http://svn.apache.org/repos/asf/tomcat/tc7.0.x/trunk/maven/ It produces the same artifacts (except distrib) all tests are in a module. It's just a question of moving sources. Let me know if you want I push/commit some other changes in a branch somewhere with sources move and start to work on assembly stuff. Antonio Cheers Jean-Frederic --**--**- To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.**orgdev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org -- Olivier Lamy Talend: http://coders.talend.com http://twitter.com/olamy | http://linkedin.com/in/olamy - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
MBean InitialContext() Tomcat query- pls help
Hi, I created and deployed an MBean in my tomcat. It uses datasource to connect to DB. My questions is: When I create InitialContext() inside MBean's constructor and pass the envContext to DBManager class to lookup datasource it works fine. However when I create InitialContext() in DBManager class, it fails. Is it necessary to create InitialContext() during loading of MBean (either in ContextListener class or inside MBean constructor). When I did new InitialContext() in my DBManager class which is called from hello method of MBean it failed with below exception: avax.naming.NoInitialContextException: Cannot instantiate class: org.apache.naming.java.javaURLContextFactory [Root exception is java.lang.ClassNotFoundException: org.apache.naming.java.javaURLContextFactory] I invoked hello method of MBean from JConsole. Please let me know is it Tomcat specific? or same behavior is seen across all app servers. Also, What difference does it make if I create InitialContext inside MBean's constructor or in some other class at a later point of time. Thanks Ravi
Re: Move to Maven? (WAS: Re: Publishing process for JARs for Maven Central)
2011/12/20 Antonio Petrelli antonio.petre...@gmail.com: 2011/12/19 Pid p...@pidster.com On 18/12/2011 08:37, Mladen Turk wrote: On 12/17/2011 09:24 PM, Antonio Petrelli wrote: As requested here is a proposal to move to Maven. I simply cannot understand why some folks have almost religious fascination with Maven. I know many projects that have move from Ant to Maven and are now either switched back or gone to some other solution like Gradle or are in the active process of seeking the alternative. I was wondering if someone would mention Gradle. If there's a build tool shootout to be had, Gradle should get fair consideration. I tried Gradle some time ago and, IMHO, it is pretty slow compared to Maven 3. Moreover, m2eclipse and Maven have some developers in common and are doing a great work to integrate the various plugins. The Eclipse-Gradle plugin seems not much mature IMHO. The current version of m2e(clipse) in its default configuration (re)downloads 200Mb index file from Maven Central into my workspace, hanging IDE in the process. What is worse that it does that regardless of whether any projects in this workspace use Maven. I would not say that the issue is fatal, and it should not take a year to fix it, but judging just the current version I'd say it is not mature enough. Ant is surely easier to run and it comes with IDE by default. If one wants to convince me in using Maven - I would very like to see a release of Tomcat taglibs subproject. It looks we are stalled there. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: MBean InitialContext() Tomcat query- pls help
You should ask on the users@ list. It is offtopic on dev@. 2011/12/20 S B sbl...@gmail.com: Hi, I created and deployed an MBean in my tomcat. It uses datasource to connect to DB. My questions is: When I create InitialContext() inside MBean's constructor and pass the envContext to DBManager class to lookup datasource it works fine. However when I create InitialContext() in DBManager class, it fails. Is it necessary to create InitialContext() during loading of MBean (either in ContextListener class or inside MBean constructor). When I did new InitialContext() in my DBManager class which is called from hello method of MBean it failed with below exception: avax.naming.NoInitialContextException: Cannot instantiate class: org.apache.naming.java.javaURLContextFactory [Root exception is java.lang.ClassNotFoundException: org.apache.naming.java.javaURLContextFactory] I invoked hello method of MBean from JConsole. Please let me know is it Tomcat specific? or same behavior is seen across all app servers. Also, What difference does it make if I create InitialContext inside MBean's constructor or in some other class at a later point of time. Thanks Ravi - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 52361] JasperException at JSP compilation
https://issues.apache.org/bugzilla/show_bug.cgi?id=52361 Konstantin Kolinko knst.koli...@gmail.com changed: What|Removed |Added Status|VERIFIED|CLOSED -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: Move to Maven? (WAS: Re: Publishing process for JARs for Maven Central)
2011/12/20 Konstantin Kolinko knst.koli...@gmail.com The current version of m2e(clipse) in its default configuration (re)downloads 200Mb index file from Maven Central into my workspace, hanging IDE in the process. Never seen that... Or, at least, it does not hang. Ant is surely easier to run and it comes with IDE by default. But it does not come with library mapping, not because of Ant problems, but because Ant build scripts are always customized. There is no way to create a consistent plugin inside Eclipse for Ant, the only thing that an IDE can do is running Ant targets. If one wants to convince me in using Maven - I would very like to see a release of Tomcat taglibs subproject. It looks we are stalled there. I think that you should start another thread for this. Antonio
Re: Time for 5.5.35?
On Dec 20, 2011, at 2:42 AM, jean-frederic clere wrote: On 12/19/2011 10:49 PM, Mark Thomas wrote: All, I know the 5.5.x change log is short but [1] is one of those annoying (for me any way) bugs it would be nice to get in a fixed release. Jim: Any chance of a 5.5.x tag later this week? I won't suggest this coming weekend ;) +1 for middle of next week. Fine w/ me... - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: A question regarding using Tomcat
2011/12/20 Mayank Tripathi may...@customerxps.com: Hi , Greetings for the day. I've a question about using the tomcat as a TCP server. Given that tomcat uses basic TCPConnections how can we use it as TCP server?Are there some settings we need to turn on or given we already have our TCPClient how tomcat will be able to receive data from a port which is not wrapped in to HTTP? 1. Usage questions belong to users@ list, not dev@. 2. Tomcat is not a generic TCP server. It supports only certain client protocols: HTTP(S) and AJP. That is what Connector implementations are available. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: Move to Maven? (WAS: Re: Publishing process for JARs for Maven Central)
On 20/12/2011 03:21, David Jencks wrote: Thanks for your brevity, Mark On Dec 19, 2011, at 11:24 AM, Mark Thomas wrote: I'll try and keep this response short too, but these are non-trivial issues... On 19/12/2011 18:47, David Jencks wrote: I mentioned dec 17 that geronimo has been maintaining a script for 2+ years that pulls tomcat source out of tomcat svn and puts it in an appropriately structured maven mutli-project build more time on this. I'm curious. What are the benefits of doing this over using the JARs that Tomcat already publishes to Maven central? Is there something wrong / missing with those JARs? If so, it can probably be fixed. Geronimo originally needed a way we could track to apply patches. I don't know that we have needed any patches recently, but we now need osgi bundles. If Geronimo prefers a 100% Maven build and needs to patch Tomcat then I can see why you created the Mavenised layout. However, I don't see that as a good reason for changing Tomcat's build layout. There are other folks that consume Tomcat that prefer the 100% Ant approach. If there was an overwhelming majority for Maven then the switch could make sense just for that reason but I don't see an overwhelming majority one way or the other at the moment. Therefore, on this point, the status quo is the right answer in my view. OSGI bundles are a new requirement. And one that I don't recall seeing mentioned on the dev or users list. Is this just a Geronimo requirement or is there likely to be a wider demand for these? If it is just Geronimo then it might be easier to just leave this in Geronimo. If there is a wider demand, then the Tomcat project should probably take ownership of this. I have lots of questions on this which probably don't belong on this thread. If you think it would be better for the Tomcat project to produce these then please create an enhancement request and the details can be worked out there. If there is an easy way to create these in Maven and creating them with the Ant script is difficult / painful / error prone, then that would be an argument in favour of Maven. How strong that argument is would depend on how easy it was to do this with Maven and how big the problems were with doing this with Ant. As I have said before in previous iterations of this topic, IMO many of the advantages of maven are not for direct development of the project itself (although they certainly exist) but in encouraging interactions with other projects and communities. You won't be able to detect these without actually using maven. How does building with Maven encourage interaction with other communities over and above the interaction we see via publishing the JARS to Maven central that we already publish? I generally wont work on projects that aren't maven based because the project layout and build system usually takes too long for me to understand to be worth it for the possible contribution I might make. I feel exactly the opposite and tend to avoid projects that use Maven for exactly the same reasons. Now that Geronimo has a mavenized tomcat, I can consider working on tomcat problems in the mavenized copy and if I think it's worth the trouble try to generate a patch against the original tomcat source. I think the standardization maven brings makes projects much more friendly to outsiders looking to contribute. And I think Maven adds complexity and magic that makes it harder for folks to figure out what is going on. As I have said elsewhere, a lot of this comes down to how familiar you are with the tool. I'm not against learning how to use Maven, if the return is worth the investment. I remain to be convinced that that is the case. Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: Move to Maven? (WAS: Re: Publishing process for JARs for Maven Central)
2011/12/20 Mark Thomas ma...@apache.org If there is an easy way to create these in Maven and creating them with the Ant script is difficult / painful / error prone, then that would be an argument in favour of Maven. How strong that argument is would depend on how easy it was to do this with Maven and how big the problems were with doing this with Ant. The Maven Felix plugin uses dependencies to create OSGi Bundles with little, or no, configuration (there are some corner cases). Antonio
Re: Time for 5.5.35?
On 12/20/2011 11:03 AM, Jim Jagielski wrote: On Dec 20, 2011, at 2:42 AM, jean-frederic clere wrote: On 12/19/2011 10:49 PM, Mark Thomas wrote: All, I know the 5.5.x change log is short but [1] is one of those annoying (for me any way) bugs it would be nice to get in a fixed release. Jim: Any chance of a 5.5.x tag later this week? I won't suggest this coming weekend ;) +1 for middle of next week. Fine w/ me... if you have cycle you can do it before no? Cheers Jean-Frederic - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: Move to Maven? (WAS: Re: Publishing process for JARs for Maven Central)
On 20/12/2011 07:58, David Jencks wrote: I think the benefit might be more on the order of encouraging people who ask where did this jar come from-- I wanna fix something. For people familiar with maven, there is IMO a much higher barrier to contributing to tomcat than a well-structured maven project. I'm not sure I agree with this one. I think when folks find a bug they don't know which JAR the bug is in. A little debugging will (hopefully) tell them which class rather than which JAR the bug is in. Finding that class in a single source tree is arguably easier than trying to find it in multiple source trees. I do agree that compiling a fixed version of the JAR will be easier using Maven, if the user understands Maven but then we are back to folks that know Maven find Maven easier whereas folks that don't know Maven, find Maven harder. I agree that we need to have as low a barrier to entry as possible. The work that has been done on the build scripts has improved things significantly since I started work on Tomcat. I can hardly believe how much of a pain building a Tomcat 4.1.x release was compared to how easy 7.0.x is. Where I disagree is on whether a switch to Maven lowers that barrier to entry. I agree it lowers it for folks that already know Maven but don't know Ant but that it raises it for folks that know Ant but don't know Maven. (BTW I must add that I'm delighted that the tomcat community seems much more receptive to outside input than it did several years ago -- community unfriendliness seems to be totally missing now :-) ). That is good. Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: Move to Maven? (WAS: Re: Publishing process for JARs for Maven Central)
On 20/12/2011 08:17, Antonio Petrelli wrote: 2011/12/19 Mladen Turk mt...@apache.org On 12/19/2011 07:04 PM, Henri Gomez wrote: Exactly. Since any change would require a learning curve and it seems we don't have that many (read none) maven experts in the house, Gradle could be equally considered, given that it seems more advanced in customization. I know well Maven but Olivier (Lamy) is a Maven expert, so there is friend in the business. And there is a full Maven PMC not too far ready to provide advices and help. Not counting Tomcat consumers ASF projects like OpenEJB. All I have seen so far is talk and talk and more talk. There is trunk, branches, sandbox, so anyone is free to make a proposal and if things work, I'll be the first one supporting it. I already forked my own repository from GitHub. I hope to start it after the holidays. I would be very interested in seeing what a Mavenised build of trunk looks like. While I may come across as anti-Maven, that is not my position. I am anti *any* disruptive change that causes more disruption then benefit it brings and right now I see more disruption than I do benefit. I am also wary (from my experience of infrastructure at the ASF) of folks pushing strongly for a switch to something better, promising to help with the switch and promising to support things moving forwards and then melting away just as their support is really needed. A demonstration of a fully Mavenised build of Tomcat trunk (or 7.0.x, 6.0.x or 5.5.x) at GitHub would help considerably: - we would be able to see how all the potential wrinkles (down-loading JDT, building a packages renamed DBCP, building a package renamed Commons logging, etc) were handled in Maven - we'd be able to judge how much simpler the build process was - Maven newbies like me could try building it, debugging with it and developing with it to see how easy we found it - the work required to create it would demonstrate a commitment to supporting this change I should stress that a working Mavenised build of a version of Tomcat is necessary but not sufficient to get my support for a switch from Ant to Maven for the build / release process. Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: Move to Maven? (WAS: Re: Publishing process for JARs for Maven Central)
On 20/12/2011 09:05, Olivier Lamy wrote: 2011/12/20 Antonio Petrelli antonio.petre...@gmail.com: Whoops! I had to do it before :-) First of all, Git is read-only at Apache: http://git.apache.org/ In this page there are many Gitted projects for Tomcat. My current fork is for Tomcat 7: https://github.com/apetrelli/tomcat70 However, since the fork, I did not pushed anything yet. Have a look at the maven layout I have done here: http://svn.apache.org/repos/asf/tomcat/tc7.0.x/trunk/maven/ It produces the same artifacts (except distrib) all tests are in a module. It's just a question of moving sources. Let me know if you want I push/commit some other changes in a branch somewhere with sources move and start to work on assembly stuff. I'd suggest that the GitHub fork is the place to collaborate as we have both committers and non-committers wanting to work on this. I would add that a Maven build that produces everything the current Ant build does is necessary but not sufficient to get my support for a move from Ant to Maven. (feel free to replace Maven with Gradle or a.n.other build system in the paragraph above). Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: MBean InitialContext() Tomcat query- pls help
On 20/12/2011 09:39, S B wrote: Hi, I created and deployed an MBean in my tomcat. It uses datasource to connect to DB. My questions is: When I create InitialContext() inside MBean's constructor and pass the envContext to DBManager class to lookup datasource it works fine. However when I create InitialContext() in DBManager class, it fails. Is it necessary to create InitialContext() during loading of MBean (either in ContextListener class or inside MBean constructor). When I did new InitialContext() in my DBManager class which is called from hello method of MBean it failed with below exception: avax.naming.NoInitialContextException: Cannot instantiate class: org.apache.naming.java.javaURLContextFactory [Root exception is java.lang.ClassNotFoundException: org.apache.naming.java.javaURLContextFactory] I invoked hello method of MBean from JConsole. Please let me know is it Tomcat specific? or same behavior is seen across all app servers. Also, What difference does it make if I create InitialContext inside MBean's constructor or in some other class at a later point of time. This is a question for the users list, not the developers list. Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: Move to Maven? (WAS: Re: Publishing process for JARs for Maven Central)
2011/12/20 Mark Thomas ma...@apache.org On 20/12/2011 09:05, Olivier Lamy wrote: 2011/12/20 Antonio Petrelli antonio.petre...@gmail.com: Whoops! I had to do it before :-) First of all, Git is read-only at Apache: http://git.apache.org/ In this page there are many Gitted projects for Tomcat. My current fork is for Tomcat 7: https://github.com/apetrelli/tomcat70 However, since the fork, I did not pushed anything yet. Have a look at the maven layout I have done here: http://svn.apache.org/repos/asf/tomcat/tc7.0.x/trunk/maven/ It produces the same artifacts (except distrib) all tests are in a module. It's just a question of moving sources. Let me know if you want I push/commit some other changes in a branch somewhere with sources move and start to work on assembly stuff. I'd suggest that the GitHub fork is the place to collaborate as we have both committers and non-committers wanting to work on this. Thanks, I'm ok with this. However if a Maven committer forks at GitHub and, then, other Maven non-committers fork from it would be easier, because this way the committer might merge the pull requests and commit (if he likes it). Antonio
Re: Move to Maven? (WAS: Re: Publishing process for JARs for Maven Central)
2011/12/20 Antonio Petrelli antonio.petre...@gmail.com 2011/12/20 Mark Thomas ma...@apache.org On 20/12/2011 09:05, Olivier Lamy wrote: 2011/12/20 Antonio Petrelli antonio.petre...@gmail.com: Whoops! I had to do it before :-) First of all, Git is read-only at Apache: http://git.apache.org/ In this page there are many Gitted projects for Tomcat. My current fork is for Tomcat 7: https://github.com/apetrelli/tomcat70 However, since the fork, I did not pushed anything yet. Have a look at the maven layout I have done here: http://svn.apache.org/repos/asf/tomcat/tc7.0.x/trunk/maven/ It produces the same artifacts (except distrib) all tests are in a module. It's just a question of moving sources. Let me know if you want I push/commit some other changes in a branch somewhere with sources move and start to work on assembly stuff. I'd suggest that the GitHub fork is the place to collaborate as we have both committers and non-committers wanting to work on this. Thanks, I'm ok with this. However if a Maven committer forks at GitHub and, then, other Maven non-committers fork from it would be easier, because this way the committer might merge the pull requests and commit (if he likes it). Probably I said a stupid thing, ignore it... It's time to eat and I need calories :-D Antonio
Re: Move to Maven? (WAS: Re: Publishing process for JARs for Maven Central)
On 20/12/2011 08:38, Antonio Petrelli wrote: 2011/12/19 Pid p...@pidster.com On 18/12/2011 08:37, Mladen Turk wrote: On 12/17/2011 09:24 PM, Antonio Petrelli wrote: As requested here is a proposal to move to Maven. I simply cannot understand why some folks have almost religious fascination with Maven. I know many projects that have move from Ant to Maven and are now either switched back or gone to some other solution like Gradle or are in the active process of seeking the alternative. I was wondering if someone would mention Gradle. If there's a build tool shootout to be had, Gradle should get fair consideration. I tried Gradle some time ago and, IMHO, it is pretty slow compared to Maven 3. Gradle are releasing frequently, it would be worth trying again. Moreover, m2eclipse and Maven have some developers in common and are doing a great work to integrate the various plugins. The Eclipse-Gradle plugin seems not much mature IMHO. Have you tried that recently? It has been working OK for me - but then I prefer to do the build stuff from the CLI anyway. However, point in the right direction if I missed something :-) Plenty of new things to read in the changelog. A notable feature of Gradle is that it does not require the build tool to be pre-installed, it provides a wrapper mechanism that downloads the specified version of the tool when it runs. I think that the syntax of the Gradle DSL is easier to understand than Maven (certainly for new users) and it happily integrates with various of the popular repos and other build tool plugins. Seems like the best of both worlds to me. p -- [key:62590808] signature.asc Description: OpenPGP digital signature
[jira] [Commented] (MTOMCAT-109) protocolorg.apache.coyote.http11.Http11NioProtocol/protocol not honoured
[ https://issues.apache.org/jira/browse/MTOMCAT-109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13173158#comment-13173158 ] Morten Haraldsen commented on MTOMCAT-109: -- Thank you! :) protocolorg.apache.coyote.http11.Http11NioProtocol/protocol not honoured Key: MTOMCAT-109 URL: https://issues.apache.org/jira/browse/MTOMCAT-109 Project: Apache Tomcat Maven Plugin Issue Type: Bug Affects Versions: 2.0 Reporter: Morten Haraldsen Assignee: Olivier Lamy Fix For: 2.0 Original Estimate: 1h Remaining Estimate: 1h Tomcat7Runner.java Line 146: Connector connector = new Connector( HTTP/1.1 ); Make it possible to use NIO connector, through protocol option so that connector is initialized using something like: Connector connector = new Connector( org.apache.coyote.http11.Http11NioProtocol ); -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: Move to Maven? (WAS: Re: Publishing process for JARs for Maven Central)
Another good thing in gradle is its incremental build support. - Romain 2011/12/20 Pid p...@pidster.com On 20/12/2011 08:38, Antonio Petrelli wrote: 2011/12/19 Pid p...@pidster.com On 18/12/2011 08:37, Mladen Turk wrote: On 12/17/2011 09:24 PM, Antonio Petrelli wrote: As requested here is a proposal to move to Maven. I simply cannot understand why some folks have almost religious fascination with Maven. I know many projects that have move from Ant to Maven and are now either switched back or gone to some other solution like Gradle or are in the active process of seeking the alternative. I was wondering if someone would mention Gradle. If there's a build tool shootout to be had, Gradle should get fair consideration. I tried Gradle some time ago and, IMHO, it is pretty slow compared to Maven 3. Gradle are releasing frequently, it would be worth trying again. Moreover, m2eclipse and Maven have some developers in common and are doing a great work to integrate the various plugins. The Eclipse-Gradle plugin seems not much mature IMHO. Have you tried that recently? It has been working OK for me - but then I prefer to do the build stuff from the CLI anyway. However, point in the right direction if I missed something :-) Plenty of new things to read in the changelog. A notable feature of Gradle is that it does not require the build tool to be pre-installed, it provides a wrapper mechanism that downloads the specified version of the tool when it runs. I think that the syntax of the Gradle DSL is easier to understand than Maven (certainly for new users) and it happily integrates with various of the popular repos and other build tool plugins. Seems like the best of both worlds to me. p -- [key:62590808]
[jira] [Created] (MTOMCAT-111) Make extract directory configurable
Make extract directory configurable --- Key: MTOMCAT-111 URL: https://issues.apache.org/jira/browse/MTOMCAT-111 Project: Apache Tomcat Maven Plugin Issue Type: Improvement Components: tomcat7 Reporter: Morten Haraldsen Assignee: Olivier Lamy Fix For: 2.0 If one is launching the application bundled as an executable jar/war, it would be nice not to have to be in the directory you want to extract the war file. Now you have Tomcat7Runner.java:86: public File extractDirectory = new File( .extract ); Could you make this an option like -extractDirectory when launching? Thanks again! -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[jira] [Updated] (MTOMCAT-111) Make extract directory configurable
[ https://issues.apache.org/jira/browse/MTOMCAT-111?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Olivier Lamy updated MTOMCAT-111: - for sure definitely something I wanted to do :-) Make extract directory configurable --- Key: MTOMCAT-111 URL: https://issues.apache.org/jira/browse/MTOMCAT-111 Project: Apache Tomcat Maven Plugin Issue Type: Improvement Components: tomcat7 Reporter: Morten Haraldsen Assignee: Olivier Lamy Fix For: 2.0 Original Estimate: 1h Remaining Estimate: 1h If one is launching the application bundled as an executable jar/war, it would be nice not to have to be in the directory you want to extract the war file. Now you have Tomcat7Runner.java:86: public File extractDirectory = new File( .extract ); Could you make this an option like -extractDirectory when launching? Thanks again! -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1221266 - /tomcat/tc5.5.x/trunk/STATUS.txt
Author: funkman Date: Tue Dec 20 14:14:31 2011 New Revision: 1221266 URL: http://svn.apache.org/viewvc?rev=1221266view=rev Log: vote Modified: tomcat/tc5.5.x/trunk/STATUS.txt Modified: tomcat/tc5.5.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc5.5.x/trunk/STATUS.txt?rev=1221266r1=1221265r2=1221266view=diff == --- tomcat/tc5.5.x/trunk/STATUS.txt (original) +++ tomcat/tc5.5.x/trunk/STATUS.txt Tue Dec 20 14:14:31 2011 @@ -102,5 +102,5 @@ PATCHES PROPOSED TO BACKPORT: * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=52335 Only handle \% and not \% as escaped in template text. http://svn.apache.org/viewvc?rev=1215121view=rev - +1: markt + +1: markt, funkman -1: - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1221273 - /tomcat/tc5.5.x/trunk/STATUS.txt
Author: jim Date: Tue Dec 20 14:23:11 2011 New Revision: 1221273 URL: http://svn.apache.org/viewvc?rev=1221273view=rev Log: vote patches Modified: tomcat/tc5.5.x/trunk/STATUS.txt Modified: tomcat/tc5.5.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc5.5.x/trunk/STATUS.txt?rev=1221273r1=1221272r2=1221273view=diff == --- tomcat/tc5.5.x/trunk/STATUS.txt (original) +++ tomcat/tc5.5.x/trunk/STATUS.txt Tue Dec 20 14:23:11 2011 @@ -35,7 +35,7 @@ PATCHES PROPOSED TO BACKPORT: It is based on r1189256 and r1187027, r1198622 (r1189258, r1187029, r1198623 in TC7) http://people.apache.org/~kkolinko/patches/2011-11-08_tc55_RequestFilterValve_v4.patch - +1: kkolinko,funkman + +1: kkolinko,funkman,jim -1: kkolinko: It does its work and prevents app from starting and working. Though @@ -68,12 +68,12 @@ PATCHES PROPOSED TO BACKPORT: svn propset svn:eol-style native connectors/util/java/org/apache/tomcat/util/http/LocalStrings.properties svn propset svn:eol-style native container/catalina/src/share/org/apache/catalina/filters/FailedRequestFilter.java svn propset svn:eol-style native container/webapps/docs/config/filter.xml - +1: kkolinko, markt, funkman + +1: kkolinko, markt, funkman, jim -1: * Align %2f handling between implementations of UDecoder.convert() http://svn.apache.org/viewvc?rev=1203091view=rev - +1: kkolinko, markt, funkman + +1: kkolinko, markt, funkman, jim -1: * Remove obsolete build.xml file that was used to download source tree. @@ -82,25 +82,25 @@ PATCHES PROPOSED TO BACKPORT: 1. svn del build/resources/build.xml 2. apply patch: http://people.apache.org/~kkolinko/patches/2011-11-15_tc55_build.patch - +1: kkolinko, rjung, markt + +1: kkolinko, rjung, markt, jim -1: * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=52225 Fix ClassCastException in Alias added for existing host via JMX http://svn.apache.org/viewvc?rev=1204856view=rev (without tests; it is r1204860 in TC7) - +1: kkolinko, markt, funkman + +1: kkolinko, markt, funkman, jim -1: * Do not throw IllegalArgumentException from parseParameters() call when chunked POST request is too large, but treat it like an IO error. http://svn.apache.org/viewvc?rev=1206200view=rev (without tests; it is r1206205 in TC7) - +1: kkolinko, markt,funkman + +1: kkolinko, markt,funkman, jim -1: * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=52335 Only handle \% and not \% as escaped in template text. http://svn.apache.org/viewvc?rev=1215121view=rev - +1: markt, funkman + +1: markt, funkman, jim -1: - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1221274 - /tomcat/tc6.0.x/trunk/STATUS.txt
Author: funkman Date: Tue Dec 20 14:23:30 2011 New Revision: 1221274 URL: http://svn.apache.org/viewvc?rev=1221274view=rev Log: some votes Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=1221274r1=1221273r2=1221274view=diff == --- tomcat/tc6.0.x/trunk/STATUS.txt (original) +++ tomcat/tc6.0.x/trunk/STATUS.txt Tue Dec 20 14:23:30 2011 @@ -77,7 +77,7 @@ PATCHES PROPOSED TO BACKPORT: kkolinko: I tested only that it does not break things with the current released tcnative version 1.1.22 that does not have FIPS mode support. http://people.apache.org/~kkolinko/patches/2011-11-12_tc6_AprLifecycleListener.patch - +1: kkolinko, markt + +1: kkolinko, markt,funkman -1: * Fix autodeployment of applications that have configuration errors. @@ -102,37 +102,37 @@ PATCHES PROPOSED TO BACKPORT: * Reduce overhead from exception handling in UDecoder http://people.apache.org/~kkolinko/patches/2011-11-17_tc6_UDecoder.patch (r1203054 in TC7) - +1: kkolinko + +1: kkolinko,funkman -1: * Align %2f handling between implementations of UDecoder.convert() http://svn.apache.org/viewvc?rev=1203091view=rev - +1: kkolinko + +1: kkolinko,funkman -1: * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=52225 Fix ClassCastException in Alias added for existing host via JMX http://svn.apache.org/viewvc?rev=1204856view=rev (without tests; it is r1204860 in TC7) - +1: kkolinko, markt + +1: kkolinko, markt,funkman -1: * Do not throw IllegalArgumentException from parseParameters() call when chunked POST request is too large, but treat it like an IO error. http://svn.apache.org/viewvc?rev=1206200view=rev (without tests; it is r1206205 in TC7) - +1: kkolinko + +1: kkolinko,funkman -1: * Update Commons Daemon to 1.0.8 Change is trivial so no patch provided - +1: mturk, markt + +1: mturk, markt,funkman -1: * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=52335 Only handle \% and not \% as escaped in template text. http://svn.apache.org/viewvc?rev=1215121view=rev - +1: markt + +1: markt,funkman -1: - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1221275 - /tomcat/tc5.5.x/trunk/STATUS.txt
Author: jim Date: Tue Dec 20 14:23:33 2011 New Revision: 1221275 URL: http://svn.apache.org/viewvc?rev=1221275view=rev Log: and promote Modified: tomcat/tc5.5.x/trunk/STATUS.txt Modified: tomcat/tc5.5.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc5.5.x/trunk/STATUS.txt?rev=1221275r1=1221274r2=1221275view=diff == --- tomcat/tc5.5.x/trunk/STATUS.txt (original) +++ tomcat/tc5.5.x/trunk/STATUS.txt Tue Dec 20 14:23:33 2011 @@ -24,9 +24,6 @@ $Id$ PATCHES ACCEPTED TO BACKPORT FROM TRUNK/OTHER: [ start all new proposals below, under PATCHES PROPOSED. ] -PATCHES PROPOSED TO BACKPORT: - [ New proposals should be added at the end of the list ] - * Make configuration issue for RemoteAddrValve, RemoteHostValve result in the failure of the valve rather than just a warning message. Ensure changes to the configuration of these valves via JMX are thread-safe. @@ -104,3 +101,7 @@ PATCHES PROPOSED TO BACKPORT: http://svn.apache.org/viewvc?rev=1215121view=rev +1: markt, funkman, jim -1: + +PATCHES PROPOSED TO BACKPORT: + [ New proposals should be added at the end of the list ] + - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1221276 - in /tomcat/tc5.5.x/trunk: ./ container/catalina/src/share/org/apache/catalina/valves/
Author: jim
Date: Tue Dec 20 14:25:24 2011
New Revision: 1221276
URL: http://svn.apache.org/viewvc?rev=1221276view=rev
Log:
* Make configuration issue for RemoteAddrValve, RemoteHostValve result
in the failure of the valve rather than just a warning message.
Ensure changes to the configuration of these valves via JMX are thread-safe.
Refactor value matching logic into separate method.
Expose the new method isAllowed and isAllowValid, isDenyValid
properties through JMX.
It is based on r1189256 and r1187027, r1198622
(r1189258, r1187029, r1198623 in TC7)
http://people.apache.org/~kkolinko/patches/2011-11-08_tc55_RequestFilterValve_v4.patch
+1: kkolinko,funkman,jim
-1:
kkolinko: It does its work and prevents app from starting
and working. Though
1. Autodeployment prints the same error every 10s. It
is OK, though a
bit annoying.
2. Application that failed to start responds
with 403. I do not
understand why. I would expect 404 or
503.
3. Application that failed to
start is not listed by the manager app.
It is expected, but does
not explain why error 403 and not 404 is observed.
Modified:
tomcat/tc5.5.x/trunk/STATUS.txt
tomcat/tc5.5.x/trunk/container/catalina/src/share/org/apache/catalina/valves/LocalStrings.properties
tomcat/tc5.5.x/trunk/container/catalina/src/share/org/apache/catalina/valves/RequestFilterValve.java
tomcat/tc5.5.x/trunk/container/catalina/src/share/org/apache/catalina/valves/mbeans-descriptors.xml
Modified: tomcat/tc5.5.x/trunk/STATUS.txt
URL:
http://svn.apache.org/viewvc/tomcat/tc5.5.x/trunk/STATUS.txt?rev=1221276r1=1221275r2=1221276view=diff
==
--- tomcat/tc5.5.x/trunk/STATUS.txt (original)
+++ tomcat/tc5.5.x/trunk/STATUS.txt Tue Dec 20 14:25:24 2011
@@ -24,25 +24,6 @@ $Id$
PATCHES ACCEPTED TO BACKPORT FROM TRUNK/OTHER:
[ start all new proposals below, under PATCHES PROPOSED. ]
-* Make configuration issue for RemoteAddrValve, RemoteHostValve result
- in the failure of the valve rather than just a warning message.
- Ensure changes to the configuration of these valves via JMX are thread-safe.
- Refactor value matching logic into separate method.
- Expose the new method isAllowed and isAllowValid, isDenyValid properties
through JMX.
- It is based on r1189256 and r1187027, r1198622
- (r1189258, r1187029, r1198623 in TC7)
-
http://people.apache.org/~kkolinko/patches/2011-11-08_tc55_RequestFilterValve_v4.patch
- +1: kkolinko,funkman,jim
- -1:
-
- kkolinko: It does its work and prevents app from starting and working. Though
-1. Autodeployment prints the same error every 10s. It is OK, though a
- bit annoying.
-2. Application that failed to start responds with 403. I do not
- understand why. I would expect 404 or 503.
-3. Application that failed to start is not listed by the manager app.
- It is expected, but does not explain why error 403 and not 404 is
observed.
-
* Improve performance of parameter processing
add
Improve performance of parameter processing for GET and POST requests.
Modified:
tomcat/tc5.5.x/trunk/container/catalina/src/share/org/apache/catalina/valves/LocalStrings.properties
URL:
http://svn.apache.org/viewvc/tomcat/tc5.5.x/trunk/container/catalina/src/share/org/apache/catalina/valves/LocalStrings.properties?rev=1221276r1=1221275r2=1221276view=diff
==
---
tomcat/tc5.5.x/trunk/container/catalina/src/share/org/apache/catalina/valves/LocalStrings.properties
(original)
+++
tomcat/tc5.5.x/trunk/container/catalina/src/share/org/apache/catalina/valves/LocalStrings.properties
Tue Dec 20 14:25:24 2011
@@ -21,12 +21,15 @@ certificatesValve.alreadyStarted=Certifi
certificatesValve.notStarted=Certificates Valve has not yet been started
interceptorValve.alreadyStarted=Interceptor Valve has already been started
interceptorValve.notStarted=Interceptor Valve has not yet been started
-requestFilterValve.next=No ''next'' valve has been configured
-requestFilterValve.syntax=Syntax error in request filter pattern {0}
valveBase.noNext=Configuration error: No ''next'' valve configured
jdbcAccessLogValve.exception=Exception performing insert access entry
jdbcAccessLogValve.close=Exception closing database connection
+# Request filter valve - RemoteAddrValve, RemoteHostValve
+requestFilterValve.alreadyStarted=Valve has already been started
+requestFilterValve.syntax=Syntax error in request filter pattern {0}
+requestFilterValve.configInvalid=One or more invalid configuration settings
were provided for the
svn commit: r1221288 - /tomcat/tc5.5.x/trunk/connectors/util/java/org/apache/tomcat/util/buf/UDecoder.java
Author: jim
Date: Tue Dec 20 14:45:12 2011
New Revision: 1221288
URL: http://svn.apache.org/viewvc?rev=1221288view=rev
Log:
* Align %2f handling between implementations of UDecoder.convert()
http://svn.apache.org/viewvc?rev=1203091view=rev
+1: kkolinko, markt, funkman, jim
-1:
Modified:
tomcat/tc5.5.x/trunk/connectors/util/java/org/apache/tomcat/util/buf/UDecoder.java
Modified:
tomcat/tc5.5.x/trunk/connectors/util/java/org/apache/tomcat/util/buf/UDecoder.java
URL:
http://svn.apache.org/viewvc/tomcat/tc5.5.x/trunk/connectors/util/java/org/apache/tomcat/util/buf/UDecoder.java?rev=1221288r1=1221287r2=1221288view=diff
==
---
tomcat/tc5.5.x/trunk/connectors/util/java/org/apache/tomcat/util/buf/UDecoder.java
(original)
+++
tomcat/tc5.5.x/trunk/connectors/util/java/org/apache/tomcat/util/buf/UDecoder.java
Tue Dec 20 14:45:12 2011
@@ -94,7 +94,7 @@ public final class UDecoder {
idx=idx2;
}
-boolean noSlash = !(ALLOW_ENCODED_SLASH || query);
+final boolean noSlash = !(ALLOW_ENCODED_SLASH || query);
for( int j=idx; jend; j++, idx++ ) {
if( buff[ j ] == '+' query) {
@@ -161,7 +161,7 @@ public final class UDecoder {
idx=idx2;
}
-boolean noSlash = !(ALLOW_ENCODED_SLASH || query);
+final boolean noSlash = !(ALLOW_ENCODED_SLASH || query);
for( int j=idx; jcend; j++, idx++ ) {
if( buff[ j ] == '+' query ) {
buff[idx]=( ' ' );
@@ -208,7 +208,11 @@ public final class UDecoder {
case MessageBytes.T_STR:
String strValue=mb.toString();
if( strValue==null ) return;
-mb.setString( convert( strValue, query ));
+try {
+mb.setString( convert( strValue, query ));
+} catch (RuntimeException ex) {
+throw new DecodeException(ex.getMessage());
+}
break;
case MessageBytes.T_CHARS:
CharChunk charC=mb.getCharChunk();
@@ -234,7 +238,9 @@ public final class UDecoder {
if( (!query || str.indexOf( '+' ) 0) str.indexOf( '%' ) 0 )
return str;
-
+
+final boolean noSlash = !(ALLOW_ENCODED_SLASH || query);
+
StringBuffer dec = new StringBuffer();// decoded string output
int strPos = 0;
int strLen = str.length();
@@ -272,8 +278,12 @@ public final class UDecoder {
// We throw the original exception - the super will deal with
// it
//try {
-dec.append((char)Integer.
- parseInt(str.substring(strPos + 1, strPos + 3),16));
+char res = (char) Integer.parseInt(
+str.substring(strPos + 1, strPos + 3), 16);
+if (noSlash (res == '/')) {
+throw new IllegalArgumentException(noSlash);
+}
+dec.append(res);
strPos += 3;
}
}
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1221289 - in /tomcat/tc5.5.x/trunk: STATUS.txt build/build.xml build/resources/build.xml
Author: jim
Date: Tue Dec 20 14:46:13 2011
New Revision: 1221289
URL: http://svn.apache.org/viewvc?rev=1221289view=rev
Log:
* Remove obsolete build.xml file that was used to download source tree.
References to it were removed from build instructions in r1202235
1. svn del build/resources/build.xml
2. apply patch:
http://people.apache.org/~kkolinko/patches/2011-11-15_tc55_build.patch
+1: kkolinko, rjung, markt, jim
-1:
Removed:
tomcat/tc5.5.x/trunk/build/resources/build.xml
Modified:
tomcat/tc5.5.x/trunk/STATUS.txt
tomcat/tc5.5.x/trunk/build/build.xml
Modified: tomcat/tc5.5.x/trunk/STATUS.txt
URL:
http://svn.apache.org/viewvc/tomcat/tc5.5.x/trunk/STATUS.txt?rev=1221289r1=1221288r2=1221289view=diff
==
--- tomcat/tc5.5.x/trunk/STATUS.txt (original)
+++ tomcat/tc5.5.x/trunk/STATUS.txt Tue Dec 20 14:46:13 2011
@@ -24,20 +24,6 @@ $Id$
PATCHES ACCEPTED TO BACKPORT FROM TRUNK/OTHER:
[ start all new proposals below, under PATCHES PROPOSED. ]
-* Align %2f handling between implementations of UDecoder.convert()
- http://svn.apache.org/viewvc?rev=1203091view=rev
- +1: kkolinko, markt, funkman, jim
- -1:
-
-* Remove obsolete build.xml file that was used to download source tree.
- References to it were removed from build instructions in r1202235
-
- 1. svn del build/resources/build.xml
- 2. apply patch:
- http://people.apache.org/~kkolinko/patches/2011-11-15_tc55_build.patch
- +1: kkolinko, rjung, markt, jim
- -1:
-
* Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=52225
Fix ClassCastException in Alias added for existing host via JMX
http://svn.apache.org/viewvc?rev=1204856view=rev
Modified: tomcat/tc5.5.x/trunk/build/build.xml
URL:
http://svn.apache.org/viewvc/tomcat/tc5.5.x/trunk/build/build.xml?rev=1221289r1=1221288r2=1221289view=diff
==
--- tomcat/tc5.5.x/trunk/build/build.xml (original)
+++ tomcat/tc5.5.x/trunk/build/build.xml Tue Dec 20 14:46:13 2011
@@ -881,8 +881,6 @@
filtering=true encoding=ISO-8859-1 /
!-- Add documents to the tomcat-docs webapp --
-copy file=${basedir}/resources/build.xml
-todir=${tomcat.build}/webapps/tomcat-docs /
copy file=./RELEASE-NOTES
tofile=${tomcat.build}/webapps/tomcat-docs/RELEASE-NOTES.txt
filtering=true encoding=ISO-8859-1 /
@@ -1448,9 +1446,6 @@
!-- Main build file --
copy todir=${tomcat.dist}/src
- fileset dir=${basedir}/resources
-include name=build.xml /
- /fileset
fileset dir=..
include name=LICENSE /
include name=NOTICE /
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
[jira] [Commented] (MTOMCAT-104) Running java -jar from a parent directory causes a Zip file error
[ https://issues.apache.org/jira/browse/MTOMCAT-104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13173242#comment-13173242 ] Keith Corbin commented on MTOMCAT-104: -- Nope this appears to be fixed. Running java -jar from a parent directory causes a Zip file error - Key: MTOMCAT-104 URL: https://issues.apache.org/jira/browse/MTOMCAT-104 Project: Apache Tomcat Maven Plugin Issue Type: Bug Components: tomcat7 Affects Versions: 2.0 Environment: Mac OSX 10.6.8 Reporter: Keith Corbin Assignee: Olivier Lamy Priority: Minor Fix For: 2.0 If you attempt to run the executable jar rather than from the directory the jar file is in you get an error with Zip extraction. java -jar ./target/smapi-1.0-war-exec.jar Exception in thread main java.util.zip.ZipException: error in opening zip file at java.util.zip.ZipFile.open(Native Method) at java.util.zip.ZipFile.init(ZipFile.java:127) at java.util.jar.JarFile.init(JarFile.java:135) at java.util.jar.JarFile.init(JarFile.java:72) at sun.net.www.protocol.jar.URLJarFile.init(URLJarFile.java:72) at sun.net.www.protocol.jar.URLJarFile.getJarFile(URLJarFile.java:48) at sun.net.www.protocol.jar.JarFileFactory.get(JarFileFactory.java:55) at sun.net.www.protocol.jar.JarURLConnection.connect(JarURLConnection.java:104) at sun.net.www.protocol.jar.JarURLConnection.getInputStream(JarURLConnection.java:132) at org.apache.tomcat.maven.runner.Tomcat7Runner.getContextXml(Tomcat7Runner.java:229) at org.apache.tomcat.maven.runner.Tomcat7Runner.run(Tomcat7Runner.java:208) at org.apache.tomcat.maven.runner.Tomcat7RunnerCli.main(Tomcat7RunnerCli.java:144) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[jira] [Resolved] (MTOMCAT-104) Running java -jar from a parent directory causes a Zip file error
[ https://issues.apache.org/jira/browse/MTOMCAT-104?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Olivier Lamy resolved MTOMCAT-104. -- Resolution: Fixed Running java -jar from a parent directory causes a Zip file error - Key: MTOMCAT-104 URL: https://issues.apache.org/jira/browse/MTOMCAT-104 Project: Apache Tomcat Maven Plugin Issue Type: Bug Components: tomcat7 Affects Versions: 2.0 Environment: Mac OSX 10.6.8 Reporter: Keith Corbin Assignee: Olivier Lamy Priority: Minor Fix For: 2.0 If you attempt to run the executable jar rather than from the directory the jar file is in you get an error with Zip extraction. java -jar ./target/smapi-1.0-war-exec.jar Exception in thread main java.util.zip.ZipException: error in opening zip file at java.util.zip.ZipFile.open(Native Method) at java.util.zip.ZipFile.init(ZipFile.java:127) at java.util.jar.JarFile.init(JarFile.java:135) at java.util.jar.JarFile.init(JarFile.java:72) at sun.net.www.protocol.jar.URLJarFile.init(URLJarFile.java:72) at sun.net.www.protocol.jar.URLJarFile.getJarFile(URLJarFile.java:48) at sun.net.www.protocol.jar.JarFileFactory.get(JarFileFactory.java:55) at sun.net.www.protocol.jar.JarURLConnection.connect(JarURLConnection.java:104) at sun.net.www.protocol.jar.JarURLConnection.getInputStream(JarURLConnection.java:132) at org.apache.tomcat.maven.runner.Tomcat7Runner.getContextXml(Tomcat7Runner.java:229) at org.apache.tomcat.maven.runner.Tomcat7Runner.run(Tomcat7Runner.java:208) at org.apache.tomcat.maven.runner.Tomcat7RunnerCli.main(Tomcat7RunnerCli.java:144) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[jira] [Commented] (MTOMCAT-108) THe httpsPort flag starts another http thread not an https thread
[ https://issues.apache.org/jira/browse/MTOMCAT-108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13173251#comment-13173251 ] Keith Corbin commented on MTOMCAT-108: -- How long will it take for this to make its way to the Maven repo? THe httpsPort flag starts another http thread not an https thread - Key: MTOMCAT-108 URL: https://issues.apache.org/jira/browse/MTOMCAT-108 Project: Apache Tomcat Maven Plugin Issue Type: Bug Components: tomcat7 Affects Versions: 2.0 Environment: MAc OSX 10.6.8 Reporter: Keith Corbin Assignee: Olivier Lamy Fix For: 2.0 Attachments: https.patch, https.patch WHen you run the executable war the httpsPort flag starts an http protocol listener thread on the port listed not an https protocol listener. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[jira] [Commented] (MTOMCAT-108) THe httpsPort flag starts another http thread not an https thread
[ https://issues.apache.org/jira/browse/MTOMCAT-108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13173256#comment-13173256 ] Olivier Lamy commented on MTOMCAT-108: -- @Keith until a release :-) Currently you can use 2.0-SNAPSHOT to test. see [http://tomcat.apache.org/maven-plugin-2.0-SNAPSHOT/snapshot-test.html] THe httpsPort flag starts another http thread not an https thread - Key: MTOMCAT-108 URL: https://issues.apache.org/jira/browse/MTOMCAT-108 Project: Apache Tomcat Maven Plugin Issue Type: Bug Components: tomcat7 Affects Versions: 2.0 Environment: MAc OSX 10.6.8 Reporter: Keith Corbin Assignee: Olivier Lamy Fix For: 2.0 Attachments: https.patch, https.patch WHen you run the executable war the httpsPort flag starts an http protocol listener thread on the port listed not an https protocol listener. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[jira] [Commented] (MTOMCAT-108) THe httpsPort flag starts another http thread not an https thread
[ https://issues.apache.org/jira/browse/MTOMCAT-108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13173260#comment-13173260 ] Keith Corbin commented on MTOMCAT-108: -- @Olivier. Sorry, I meant when will it be available in the SNAPSHOT? Currently the SNAPSHOT is showing a last build date of Novermber 11th, 2011. THe httpsPort flag starts another http thread not an https thread - Key: MTOMCAT-108 URL: https://issues.apache.org/jira/browse/MTOMCAT-108 Project: Apache Tomcat Maven Plugin Issue Type: Bug Components: tomcat7 Affects Versions: 2.0 Environment: MAc OSX 10.6.8 Reporter: Keith Corbin Assignee: Olivier Lamy Fix For: 2.0 Attachments: https.patch, https.patch WHen you run the executable war the httpsPort flag starts an http protocol listener thread on the port listed not an https protocol listener. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1221322 - /tomcat/trunk/TOMCAT-NEXT.txt
Author: markt Date: Tue Dec 20 15:55:28 2011 New Revision: 1221322 URL: http://svn.apache.org/viewvc?rev=1221322view=rev Log: Add another entry Modified: tomcat/trunk/TOMCAT-NEXT.txt Modified: tomcat/trunk/TOMCAT-NEXT.txt URL: http://svn.apache.org/viewvc/tomcat/trunk/TOMCAT-NEXT.txt?rev=1221322r1=1221321r2=1221322view=diff == --- tomcat/trunk/TOMCAT-NEXT.txt (original) +++ tomcat/trunk/TOMCAT-NEXT.txt Tue Dec 20 15:55:28 2011 @@ -18,30 +18,34 @@ Notes of things to consider for the next major Tomcat release (probably 8.0.x but possibly 7.1.x). -1. Refactor the TLD parsing. TLDs are currently parsed twice. Once by Catalina - looking for listeners and once by Jasper. + 1. Refactor the TLD parsing. TLDs are currently parsed twice. Once by Catalina +looking for listeners and once by Jasper. -2. Refactor the XML parsing (org.apache.tomcat.util.xml ?) to remove duplicate - XML parsing code in Catalina and Jasper such as the entity resolvers used for - validation. + 2. Refactor the XML parsing (org.apache.tomcat.util.xml ?) to remove duplicate +XML parsing code in Catalina and Jasper such as the entity resolvers used +for validation. -3. TLDs may have a many to many relationship between URIs and TLD files. This - can result in the same TLD file being parsed many times. Refactor the - TldLocationCache to cache the parsed nodes (will need to check for changes to - TLD files). + 3. TLDs may have a many to many relationship between URIs and TLD files. This +can result in the same TLD file being parsed many times. Refactor the +TldLocationCache to cache the parsed nodes (will need to check for changes +to TLD files). -4. TLD files should be included in the dependencies for JSP and Tag files. + 4. TLD files should be included in the dependencies for JSP and Tag files. -5. Run the unused code detector and remove everything that isn't currently used. - Add deprecation markers for the removed code to Tomcat 7.0.x + 5. Run the unused code detector and remove everything that isn't currently used. +Add deprecation markers for the removed code to Tomcat 7.0.x -6. Change the default URIEncoding on the connector to UTF-8. + 6. Change the default URIEncoding on the connector to UTF-8. -7. Rip out all the JNDI code in resource handling and replace it with straight - URLs (File or WAR). + 7. Rip out all the JNDI code in resource handling and replace it with straight +URLs (File or WAR). -8. Review the connector shutdown code for timing and threading issues - particularly any that may result in a client socket being left open after a - connector.stop(). + 8. Review the connector shutdown code for timing and threading issues +particularly any that may result in a client socket being left open after a +connector.stop(). -9. Remove the svn keywords from all the files. (Just Java files?) + 9. Remove the svn keywords from all the files. (Just Java files?) + +10. Code to the interfaces in the o.a.catalina package and avoid coding directly +to implementations in other packages. This is likely to require a lot of +work. Maybe use Structure 101 (or similar) to help. \ No newline at end of file - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1221471 - in /tomcat/tc5.5.x/trunk: STATUS.txt connectors/util/java/org/apache/tomcat/util/http/mapper/Mapper.java container/webapps/docs/changelog.xml
Author: markt
Date: Tue Dec 20 20:17:25 2011
New Revision: 1221471
URL: http://svn.apache.org/viewvc?rev=1221471view=rev
Log:
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=52225
Fix ClassCastException in Alias added for existing host via JMX
Modified:
tomcat/tc5.5.x/trunk/STATUS.txt
tomcat/tc5.5.x/trunk/connectors/util/java/org/apache/tomcat/util/http/mapper/Mapper.java
tomcat/tc5.5.x/trunk/container/webapps/docs/changelog.xml
Modified: tomcat/tc5.5.x/trunk/STATUS.txt
URL:
http://svn.apache.org/viewvc/tomcat/tc5.5.x/trunk/STATUS.txt?rev=1221471r1=1221470r2=1221471view=diff
==
--- tomcat/tc5.5.x/trunk/STATUS.txt (original)
+++ tomcat/tc5.5.x/trunk/STATUS.txt Tue Dec 20 20:17:25 2011
@@ -24,13 +24,6 @@ $Id$
PATCHES ACCEPTED TO BACKPORT FROM TRUNK/OTHER:
[ start all new proposals below, under PATCHES PROPOSED. ]
-* Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=52225
- Fix ClassCastException in Alias added for existing host via JMX
- http://svn.apache.org/viewvc?rev=1204856view=rev
- (without tests; it is r1204860 in TC7)
- +1: kkolinko, markt, funkman, jim
- -1:
-
* Do not throw IllegalArgumentException from parseParameters() call when
chunked POST request is too large, but treat it like an IO error.
http://svn.apache.org/viewvc?rev=1206200view=rev
Modified:
tomcat/tc5.5.x/trunk/connectors/util/java/org/apache/tomcat/util/http/mapper/Mapper.java
URL:
http://svn.apache.org/viewvc/tomcat/tc5.5.x/trunk/connectors/util/java/org/apache/tomcat/util/http/mapper/Mapper.java?rev=1221471r1=1221470r2=1221471view=diff
==
---
tomcat/tc5.5.x/trunk/connectors/util/java/org/apache/tomcat/util/http/mapper/Mapper.java
(original)
+++
tomcat/tc5.5.x/trunk/connectors/util/java/org/apache/tomcat/util/http/mapper/Mapper.java
Tue Dec 20 20:17:25 2011
@@ -154,7 +154,7 @@ public final class Mapper {
Host newHost = new Host();
newHost.name = alias;
newHost.contextList = realHost.contextList;
-newHost.object = realHost;
+newHost.object = realHost.object;
if (insertMap(hosts, newHosts, newHost)) {
hosts = newHosts;
}
Modified: tomcat/tc5.5.x/trunk/container/webapps/docs/changelog.xml
URL:
http://svn.apache.org/viewvc/tomcat/tc5.5.x/trunk/container/webapps/docs/changelog.xml?rev=1221471r1=1221470r2=1221471view=diff
==
--- tomcat/tc5.5.x/trunk/container/webapps/docs/changelog.xml (original)
+++ tomcat/tc5.5.x/trunk/container/webapps/docs/changelog.xml Tue Dec 20
20:17:25 2011
@@ -40,6 +40,14 @@
General, Catalina, Coyote, Jasper, Cluster, Webapps, Other
--
section name=Tomcat 5.5.35 (jim) rtext=
+ subsection name=Catalina
+changelog
+ fix
+bug52225/bug: Fix ClassCastException when adding an alias for an
+existing host via JMX. (kkolinko)
+ /fix
+/changelog
+ /subsection
subsection name=General
changelog
update
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 52225] Adding Alias for existing host on running Tomcat causes ClassCastException
https://issues.apache.org/bugzilla/show_bug.cgi?id=52225 --- Comment #3 from Mark Thomas ma...@apache.org 2011-12-20 20:17:40 UTC --- Fixed in 5.5.x and will be in 5.5.35 onwards. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1221474 - in /tomcat/tc6.0.x/trunk: STATUS.txt java/org/apache/tomcat/util/http/mapper/Mapper.java webapps/docs/changelog.xml
Author: markt
Date: Tue Dec 20 20:19:39 2011
New Revision: 1221474
URL: http://svn.apache.org/viewvc?rev=1221474view=rev
Log:
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=52225
Fix ClassCastException in Alias added for existing host via JMX
Modified:
tomcat/tc6.0.x/trunk/STATUS.txt
tomcat/tc6.0.x/trunk/java/org/apache/tomcat/util/http/mapper/Mapper.java
tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml
Modified: tomcat/tc6.0.x/trunk/STATUS.txt
URL:
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=1221474r1=1221473r2=1221474view=diff
==
--- tomcat/tc6.0.x/trunk/STATUS.txt (original)
+++ tomcat/tc6.0.x/trunk/STATUS.txt Tue Dec 20 20:19:39 2011
@@ -110,13 +110,6 @@ PATCHES PROPOSED TO BACKPORT:
+1: kkolinko,funkman
-1:
-* Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=52225
- Fix ClassCastException in Alias added for existing host via JMX
- http://svn.apache.org/viewvc?rev=1204856view=rev
- (without tests; it is r1204860 in TC7)
- +1: kkolinko, markt,funkman
- -1:
-
* Do not throw IllegalArgumentException from parseParameters() call when
chunked POST request is too large, but treat it like an IO error.
http://svn.apache.org/viewvc?rev=1206200view=rev
Modified:
tomcat/tc6.0.x/trunk/java/org/apache/tomcat/util/http/mapper/Mapper.java
URL:
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/java/org/apache/tomcat/util/http/mapper/Mapper.java?rev=1221474r1=1221473r2=1221474view=diff
==
--- tomcat/tc6.0.x/trunk/java/org/apache/tomcat/util/http/mapper/Mapper.java
(original)
+++ tomcat/tc6.0.x/trunk/java/org/apache/tomcat/util/http/mapper/Mapper.java
Tue Dec 20 20:19:39 2011
@@ -154,7 +154,7 @@ public final class Mapper {
Host newHost = new Host();
newHost.name = alias;
newHost.contextList = realHost.contextList;
-newHost.object = realHost;
+newHost.object = realHost.object;
if (insertMap(hosts, newHosts, newHost)) {
hosts = newHosts;
}
Modified: tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml
URL:
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml?rev=1221474r1=1221473r2=1221474view=diff
==
--- tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml (original)
+++ tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml Tue Dec 20 20:19:39 2011
@@ -44,6 +44,14 @@
General, Catalina, Coyote, Jasper, Cluster, Webapps, Other
--
section name=Tomcat 6.0.36 (jfclere) rtext=
+ subsection name=Catalina
+changelog
+ fix
+bug52225/bug: Fix ClassCastException when adding an alias for an
+existing host via JMX. (kkolinko)
+ /fix
+/changelog
+ /subsection
subsection name=Other
changelog
fix
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 52225] Adding Alias for existing host on running Tomcat causes ClassCastException
https://issues.apache.org/bugzilla/show_bug.cgi?id=52225 Mark Thomas ma...@apache.org changed: What|Removed |Added Status|NEW |RESOLVED Resolution||FIXED --- Comment #4 from Mark Thomas ma...@apache.org 2011-12-20 20:20:02 UTC --- Fixed in 6.0.x and will be included in 6.0.36 onwards. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1221478 - in /tomcat/tc5.5.x/trunk: STATUS.txt container/catalina/src/share/org/apache/catalina/connector/Request.java container/webapps/docs/changelog.xml
Author: markt
Date: Tue Dec 20 20:24:01 2011
New Revision: 1221478
URL: http://svn.apache.org/viewvc?rev=1221478view=rev
Log:
Do not throw IllegalArgumentException from parseParameters() call when chunked
POST request is too large, but treat it like an IO error.
Modified:
tomcat/tc5.5.x/trunk/STATUS.txt
tomcat/tc5.5.x/trunk/container/catalina/src/share/org/apache/catalina/connector/Request.java
tomcat/tc5.5.x/trunk/container/webapps/docs/changelog.xml
Modified: tomcat/tc5.5.x/trunk/STATUS.txt
URL:
http://svn.apache.org/viewvc/tomcat/tc5.5.x/trunk/STATUS.txt?rev=1221478r1=1221477r2=1221478view=diff
==
--- tomcat/tc5.5.x/trunk/STATUS.txt (original)
+++ tomcat/tc5.5.x/trunk/STATUS.txt Tue Dec 20 20:24:01 2011
@@ -24,13 +24,6 @@ $Id$
PATCHES ACCEPTED TO BACKPORT FROM TRUNK/OTHER:
[ start all new proposals below, under PATCHES PROPOSED. ]
-* Do not throw IllegalArgumentException from parseParameters() call when
- chunked POST request is too large, but treat it like an IO error.
- http://svn.apache.org/viewvc?rev=1206200view=rev
- (without tests; it is r1206205 in TC7)
- +1: kkolinko, markt,funkman, jim
- -1:
-
* Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=52335
Only handle \% and not \% as escaped in template text.
http://svn.apache.org/viewvc?rev=1215121view=rev
Modified:
tomcat/tc5.5.x/trunk/container/catalina/src/share/org/apache/catalina/connector/Request.java
URL:
http://svn.apache.org/viewvc/tomcat/tc5.5.x/trunk/container/catalina/src/share/org/apache/catalina/connector/Request.java?rev=1221478r1=1221477r2=1221478view=diff
==
---
tomcat/tc5.5.x/trunk/container/catalina/src/share/org/apache/catalina/connector/Request.java
(original)
+++
tomcat/tc5.5.x/trunk/container/catalina/src/share/org/apache/catalina/connector/Request.java
Tue Dec 20 20:24:01 2011
@@ -2521,7 +2521,7 @@ public class Request
try {
formData = readChunkedPostBody();
} catch (IOException e) {
-// Client disconnect
+// Client disconnect or chunkedPostTooLarge error
if (context.getLogger().isDebugEnabled()) {
context.getLogger().debug(
sm.getString(coyoteRequest.parseParameters),
e);
@@ -2575,7 +2575,7 @@ public class Request
if (connector.getMaxPostSize() 0
(body.getLength() + len) connector.getMaxPostSize()) {
// Too much data
-throw new IllegalArgumentException(
+throw new IOException(
sm.getString(coyoteRequest.chunkedPostTooLarge));
}
if (len 0) {
Modified: tomcat/tc5.5.x/trunk/container/webapps/docs/changelog.xml
URL:
http://svn.apache.org/viewvc/tomcat/tc5.5.x/trunk/container/webapps/docs/changelog.xml?rev=1221478r1=1221477r2=1221478view=diff
==
--- tomcat/tc5.5.x/trunk/container/webapps/docs/changelog.xml (original)
+++ tomcat/tc5.5.x/trunk/container/webapps/docs/changelog.xml Tue Dec 20
20:24:01 2011
@@ -46,6 +46,11 @@
bug52225/bug: Fix ClassCastException when adding an alias for an
existing host via JMX. (kkolinko)
/fix
+ fix
+Do not throw an IllegalArgumentException from a
+codeparseParameters()/code call when a chunked POST request is too
+large, but treat it like an IO error. (kkolinko)
+ /fix
/changelog
/subsection
subsection name=General
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1221479 - in /tomcat/tc5.5.x/trunk: STATUS.txt container/webapps/docs/changelog.xml jasper/src/share/org/apache/jasper/compiler/Parser.java
Author: markt
Date: Tue Dec 20 20:28:49 2011
New Revision: 1221479
URL: http://svn.apache.org/viewvc?rev=1221479view=rev
Log:
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=52335
Only handle \% and not \% as escaped in template text.
Modified:
tomcat/tc5.5.x/trunk/STATUS.txt
tomcat/tc5.5.x/trunk/container/webapps/docs/changelog.xml
tomcat/tc5.5.x/trunk/jasper/src/share/org/apache/jasper/compiler/Parser.java
Modified: tomcat/tc5.5.x/trunk/STATUS.txt
URL:
http://svn.apache.org/viewvc/tomcat/tc5.5.x/trunk/STATUS.txt?rev=1221479r1=1221478r2=1221479view=diff
==
--- tomcat/tc5.5.x/trunk/STATUS.txt (original)
+++ tomcat/tc5.5.x/trunk/STATUS.txt Tue Dec 20 20:28:49 2011
@@ -24,12 +24,6 @@ $Id$
PATCHES ACCEPTED TO BACKPORT FROM TRUNK/OTHER:
[ start all new proposals below, under PATCHES PROPOSED. ]
-* Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=52335
- Only handle \% and not \% as escaped in template text.
- http://svn.apache.org/viewvc?rev=1215121view=rev
- +1: markt, funkman, jim
- -1:
-
PATCHES PROPOSED TO BACKPORT:
[ New proposals should be added at the end of the list ]
Modified: tomcat/tc5.5.x/trunk/container/webapps/docs/changelog.xml
URL:
http://svn.apache.org/viewvc/tomcat/tc5.5.x/trunk/container/webapps/docs/changelog.xml?rev=1221479r1=1221478r2=1221479view=diff
==
--- tomcat/tc5.5.x/trunk/container/webapps/docs/changelog.xml (original)
+++ tomcat/tc5.5.x/trunk/container/webapps/docs/changelog.xml Tue Dec 20
20:28:49 2011
@@ -67,6 +67,14 @@
/fix
/changelog
/subsection
+ subsection name=Jasper
+changelog
+ fix
+bug52335/bug: Only handle codelt;\%/code and not
+code\%/code as escaped in template text. (markt)
+ /fix
+/changelog
+ /subsection
subsection name=Webapps
changelog
fix
Modified:
tomcat/tc5.5.x/trunk/jasper/src/share/org/apache/jasper/compiler/Parser.java
URL:
http://svn.apache.org/viewvc/tomcat/tc5.5.x/trunk/jasper/src/share/org/apache/jasper/compiler/Parser.java?rev=1221479r1=1221478r2=1221479view=diff
==
---
tomcat/tc5.5.x/trunk/jasper/src/share/org/apache/jasper/compiler/Parser.java
(original)
+++
tomcat/tc5.5.x/trunk/jasper/src/share/org/apache/jasper/compiler/Parser.java
Tue Dec 20 20:28:49 2011
@@ -1405,6 +1405,7 @@ class Parser implements TagConstants {
}
while (reader.hasMoreInput()) {
+int prev = ch;
ch = reader.nextChar();
if (ch == '') {
reader.pushChar();
@@ -1430,10 +1431,11 @@ class Parser implements TagConstants {
ttext.write('\\');
break;
}
-// Look for \% or \$
+// Look for \% or \$
// Only recognize \$ if isELIgnored is false
char next = (char)reader.peekChar();
-if (next == '%' || (next == '$' !pageInfo.isELIgnored())) {
+if ((prev == '' next == '%') ||
+(next == '$' !pageInfo.isELIgnored())) {
ch = reader.nextChar();
}
}
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 52335] Tomcat escapes all the \% in Template Text as %.
https://issues.apache.org/bugzilla/show_bug.cgi?id=52335 Mark Thomas ma...@apache.org changed: What|Removed |Added Status|NEW |RESOLVED Resolution||FIXED --- Comment #3 from Mark Thomas ma...@apache.org 2011-12-20 20:29:04 UTC --- Fixed in 5.5.x and will be included in 5.5.35 onwards. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 28039] Cluster Support for SingleSignOn
https://issues.apache.org/bugzilla/show_bug.cgi?id=28039 Mark Thomas ma...@apache.org changed: What|Removed |Added Component|Catalina:Cluster|Cluster Version|Nightly Build |unspecified Product|Tomcat 5|Tomcat 7 --- Comment #7 from Mark Thomas ma...@apache.org 2011-12-20 20:31:46 UTC --- This Tomcat 5 enhancement request has been moved to Tomcat 7 (the latest version) since Tomcat 5 development is limited and focussed on bugs and security issues whereas Tomcat 7 is still seeing new feature development. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 38216] Extend Jmxproxy to allow call of MBean Operations
https://issues.apache.org/bugzilla/show_bug.cgi?id=38216 Mark Thomas ma...@apache.org changed: What|Removed |Added Status|NEEDINFO|NEW Component|Webapps:Manager |Manager Version|Unknown |unspecified Product|Tomcat 5|Tomcat 7 --- Comment #4 from Mark Thomas ma...@apache.org 2011-12-20 20:32:18 UTC --- This Tomcat 5 enhancement request has been moved to Tomcat 7 (the latest version) since Tomcat 5 development is limited and focussed on bugs and security issues whereas Tomcat 7 is still seeing new feature development. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 40728] Catalina MBeans use non-serializable classes
https://issues.apache.org/bugzilla/show_bug.cgi?id=40728 Mark Thomas ma...@apache.org changed: What|Removed |Added Component|Catalina|Catalina Version|Nightly Build |unspecified Product|Tomcat 5|Tomcat 7 --- Comment #12 from Mark Thomas ma...@apache.org 2011-12-20 20:32:40 UTC --- This Tomcat 5 enhancement request has been moved to Tomcat 7 (the latest version) since Tomcat 5 development is limited and focussed on bugs and security issues whereas Tomcat 7 is still seeing new feature development. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 40766] Using an unsecure jsessionid with mod_proxy_ajp over https
https://issues.apache.org/bugzilla/show_bug.cgi?id=40766 Mark Thomas ma...@apache.org changed: What|Removed |Added Status|NEW |RESOLVED Resolution||WONTFIX --- Comment #4 from Mark Thomas ma...@apache.org 2011-12-20 20:34:10 UTC --- This seems like a very bad idea to me too. Marking as WONTIX based on security concerns and general lack of interest in this enhancement for several years. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 40881] Unable to receive message through TCP channel - Nullpointer
https://issues.apache.org/bugzilla/show_bug.cgi?id=40881 Mark Thomas ma...@apache.org changed: What|Removed |Added Component|Catalina:Cluster|Cluster Version|5.5.20 |unspecified Product|Tomcat 5|Tomcat 7 --- Comment #13 from Mark Thomas ma...@apache.org 2011-12-20 20:34:40 UTC --- This Tomcat 5 enhancement request has been moved to Tomcat 7 (the latest version) since Tomcat 5 development is limited and focussed on bugs and security issues whereas Tomcat 7 is still seeing new feature development. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 41007] Can't define customized 503 error page
https://issues.apache.org/bugzilla/show_bug.cgi?id=41007 Mark Thomas ma...@apache.org changed: What|Removed |Added Component|Catalina|Catalina Version|5.5.20 |unspecified Product|Tomcat 5|Tomcat 7 --- Comment #6 from Mark Thomas ma...@apache.org 2011-12-20 20:35:11 UTC --- This Tomcat 5 enhancement request has been moved to Tomcat 7 (the latest version) since Tomcat 5 development is limited and focussed on bugs and security issues whereas Tomcat 7 is still seeing new feature development. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 43866] add support for session attribute propagation without calls to DeltaSession.setAttribute
https://issues.apache.org/bugzilla/show_bug.cgi?id=43866 Mark Thomas ma...@apache.org changed: What|Removed |Added Component|Catalina:Cluster|Cluster Version|5.5.23 |unspecified Product|Tomcat 5|Tomcat 7 --- Comment #1 from Mark Thomas ma...@apache.org 2011-12-20 20:35:30 UTC --- This Tomcat 5 enhancement request has been moved to Tomcat 7 (the latest version) since Tomcat 5 development is limited and focussed on bugs and security issues whereas Tomcat 7 is still seeing new feature development. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 43925] org.apache.jasper.runtime.BodyContentImpl causing huge memory allocations
https://issues.apache.org/bugzilla/show_bug.cgi?id=43925 Mark Thomas ma...@apache.org changed: What|Removed |Added Component|Jasper |Jasper Version|5.5.24 |unspecified Product|Tomcat 5|Tomcat 7 --- Comment #9 from Mark Thomas ma...@apache.org 2011-12-20 20:35:50 UTC --- This Tomcat 5 enhancement request has been moved to Tomcat 7 (the latest version) since Tomcat 5 development is limited and focussed on bugs and security issues whereas Tomcat 7 is still seeing new feature development. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 44216] Don't reuse session ID even if emptySessionPath=true
https://issues.apache.org/bugzilla/show_bug.cgi?id=44216 Mark Thomas ma...@apache.org changed: What|Removed |Added Component|Catalina|Catalina Version|Unknown |unspecified Product|Tomcat 5|Tomcat 7 --- Comment #1 from Mark Thomas ma...@apache.org 2011-12-20 20:36:23 UTC --- This Tomcat 5 enhancement request has been moved to Tomcat 7 (the latest version) since Tomcat 5 development is limited and focussed on bugs and security issues whereas Tomcat 7 is still seeing new feature development. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 44904] Provide warning message when DataSource's maxActive=0
https://issues.apache.org/bugzilla/show_bug.cgi?id=44904 Mark Thomas ma...@apache.org changed: What|Removed |Added Component|Unknown |Catalina Version|5.5.26 |unspecified Product|Tomcat 5|Tomcat 7 --- Comment #1 from Mark Thomas ma...@apache.org 2011-12-20 20:36:48 UTC --- This Tomcat 5 enhancement request has been moved to Tomcat 7 (the latest version) since Tomcat 5 development is limited and focussed on bugs and security issues whereas Tomcat 7 is still seeing new feature development. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1221485 - /tomcat/tc5.5.x/trunk/container/webapps/docs/changelog.xml
Author: markt Date: Tue Dec 20 20:44:07 2011 New Revision: 1221485 URL: http://svn.apache.org/viewvc?rev=1221485view=rev Log: Add missing entries Modified: tomcat/tc5.5.x/trunk/container/webapps/docs/changelog.xml Modified: tomcat/tc5.5.x/trunk/container/webapps/docs/changelog.xml URL: http://svn.apache.org/viewvc/tomcat/tc5.5.x/trunk/container/webapps/docs/changelog.xml?rev=1221485r1=1221484r2=1221485view=diff == --- tomcat/tc5.5.x/trunk/container/webapps/docs/changelog.xml (original) +++ tomcat/tc5.5.x/trunk/container/webapps/docs/changelog.xml Tue Dec 20 20:44:07 2011 @@ -42,6 +42,36 @@ section name=Tomcat 5.5.35 (jim) rtext= subsection name=Catalina changelog + add +Make configuration issues for security related Valves and Filters result +in the failure of the valve or filter rather than just a warning +message. (markt) + /add + fix +Ensure changes to the configuration of the RemoteHostValve and the +RemoteAddrValve via JMX are thread-safe. (markt) + /fix + update +In codeRequestFilterValve/code (codeRemoteAddrValve/code, +codeRemoteHostValve/code): refactor value matching logic into +separate method and expose this new method codeisAllowed/code +through JMX. (kkolinko) + /update + add +Improve performance of parameter processing for GET and POST requests. +Also add an option to limit the maximum number of parameters processed +per request. This defaults to 1. Excessive parameters are ignored. +Note that codeFailedRequestFilter/code can be used to reject the +request if some parameters were ignored. (markt/kkolinko) + /add + add +New filter codeFailedRequestFilter/code that will reject a request +if there were errors during HTTP parameter parsing. (kkolinko) + /add + fix +Slightly improve performance of UDecoder.convert(). Align +code%2f/code handling between implementations. (kkolinko) + /fix fix bug52225/bug: Fix ClassCastException when adding an alias for an existing host via JMX. (kkolinko) - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 51294] Since 7.0.12 do not work option unpackWARs=true for WARs outside appBase
https://issues.apache.org/bugzilla/show_bug.cgi?id=51294 Tiago Cruz tiago.tuxkil...@gmail.com changed: What|Removed |Added CC||tiago.tuxkil...@gmail.com -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: Time for 5.5.35?
On 20/12/2011 10:03, Jim Jagielski wrote: On Dec 20, 2011, at 2:42 AM, jean-frederic clere wrote: On 12/19/2011 10:49 PM, Mark Thomas wrote: All, I know the 5.5.x change log is short but [1] is one of those annoying (for me any way) bugs it would be nice to get in a fixed release. Jim: Any chance of a 5.5.x tag later this week? I won't suggest this coming weekend ;) +1 for middle of next week. Fine w/ me... The status file is clear. Bugzilla is clear (!) I think we are good to go. I'd suggest waiting ~24 hours for folks to spot anything else that needs doing and aim for a tag on Thursday. Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 51294] Since 7.0.12 do not work option unpackWARs=true for WARs outside appBase
https://issues.apache.org/bugzilla/show_bug.cgi?id=51294 --- Comment #7 from Tiago Cruz tiago.tuxkil...@gmail.com 2011-12-20 21:45:01 UTC --- I also have this problem with tomcat = 7.0.12 :/ Is this configuration possible? (unpackExternalWARs=true) :D 'Cause to use with configuration management (puppet, chef e etc) its easier to put the .war up-to-date in one directory and use a Context with one docBase using the full path of application. Thanks! -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: Move to Maven? (WAS: Re: Publishing process for JARs for Maven Central)
On 20 déc. 2011, at 12:22, Mark Thomas wrote: Where I disagree is on whether a switch to Maven lowers that barrier to entry. I agree it lowers it for folks that already know Maven but don't know Ant but that it raises it for folks that know Ant but don't know Maven. Knowing ant does not mean knowing how to build a particular project. That's the big drawback of ant over maven : there's no convention/standard way of doing things. IMHO knowing maven is worth the investment and can be applied to so many projects that the return on investment is quite quick. Regarding maven for tomcat, I think it would lower the barrier of entry for new developers. In a perfect maven scenario, a developer would checkout tomcat sources in its IDE, wait for the dependencies to be downloaded and have a workspace ready to hack into tomcat using standard maven commands. so, I'm +1 to support any experiments around maven and then judge on the results. Sylvain - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: svn commit: r1221276 - in /tomcat/tc5.5.x/trunk: ./ container/catalina/src/share/org/apache/catalina/valves/
On 20.12.2011 15:25, j...@apache.org wrote: Author: jim Date: Tue Dec 20 14:25:24 2011 New Revision: 1221276 URL: http://svn.apache.org/viewvc?rev=1221276view=rev Log: * Make configuration issue for RemoteAddrValve, RemoteHostValve result in the failure of the valve rather than just a warning message. Ensure changes to the configuration of these valves via JMX are thread-safe. Refactor value matching logic into separate method. Expose the new method isAllowed and isAllowValid, isDenyValid properties through JMX. It is based on r1189256 and r1187027, r1198622 (r1189258, r1187029, r1198623 in TC7) http://people.apache.org/~kkolinko/patches/2011-11-08_tc55_RequestFilterValve_v4.patch +1: kkolinko,funkman,jim -1: kkolinko: It does its work and prevents app from starting and working. Though 1. Autodeployment prints the same error every 10s. It is OK, though a bit annoying. 2. Application that failed to start responds with 403. I do not understand why. I would expect 404 or 503. 3. Application that failed to start is not listed by the manager app. It is expected, but does not explain why error 403 and not 404 is observed. Jim's famous my editor can do autoindent and provide nice ASCII art mode ;) Regards, Rainer - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [GUMP@vmgump]: Project jakarta-tomcat (in module jakarta-tomcat) failed
This is Tomcat 3.3 (jakarta-tomcat-33.xml in Gump). It is odd that this failed. 2011/12/21 Stefan Bodewig bode...@apache.org: To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project jakarta-tomcat has an issue affecting its community integration. This issue affects 2 projects, and has been outstanding for 219 runs. The current state of this project is 'Failed', with reason 'Build Failed'. For reference only, the following projects are affected by this: - jakarta-tomcat : Servlet 2.2 and JSP 1.1 Reference Implementation - jakarta-tomcat-coyote-tomcat3 : Connectors to various web servers Full details are available at: http://vmgump.apache.org/gump/public/jakarta-tomcat/jakarta-tomcat/index.html That said, some information snippets are provided here. The following annotations (debug/informational/warning/error messages) were provided: -DEBUG- Output [tomcat_core.jar] identifier set to output basename: [tomcat_core] -DEBUG- Output [core_util.jar] identifier set to output basename: [core_util] -DEBUG- Output [container_util.jar] identifier set to output basename: [container_util] -DEBUG- Output [tomcat_modules.jar] identifier set to output basename: [tomcat_modules] -DEBUG- Output [tomcat.jar] identifier set to output basename: [tomcat] -DEBUG- Output [tomcat-util.jar] identifier set to output basename: [tomcat-util] -DEBUG- Output [facade22.jar] identifier set to output basename: [facade22] -DEBUG- Output [jasper.jar] identifier set to output basename: [jasper] -DEBUG- Dependency on jakarta-servletapi exists, no need to add for property servlet22.jar. -DEBUG- Dependency on jmx exists, no need to add for property jmxtools.jar. -DEBUG- Dependency on ant exists, no need to add for property ant.home. -DEBUG- Dependency on jsse exists, no need to add for property jsse.home. -INFO- Failed with reason build failed -DEBUG- Extracted fallback artifacts from Gump Repository The following work was performed: http://vmgump.apache.org/gump/public/jakarta-tomcat/jakarta-tomcat/gump_work/build_jakarta-tomcat_jakarta-tomcat.html Work Name: build_jakarta-tomcat_jakarta-tomcat (Type: Build) Work ended in a state of : Failed Elapsed: 9 secs Command Line: /usr/lib/jvm/java-6-openjdk/bin/java -Djava.awt.headless=true -Dbuild.sysclasspath=only -Xbootclasspath/p:/srv/gump/public/workspace/xml-xerces2/build/xercesImpl.jar:/srv/gump/public/workspace/xml-commons/java/external/build/xml-apis.jar:/srv/gump/public/workspace/xml-xalan/build/xalan-unbundled.jar:/srv/gump/public/workspace/xml-xalan/build/serializer.jar org.apache.tools.ant.Main -Dgump.merge=/srv/gump/public/gump/work/merge.xml -Djakarta-tomcat-connectors=/srv/gump/public/workspace/jakarta-tomcat-connectors -Djtc.coyote.home=/srv/gump/public/workspace/jakarta-tomcat-connectors/coyote -Djaxp.home=/srv/gump/packages/jaxp-1_3 -Dcommons-modeler.jar=/srv/gump/public/workspace/apache-commons/modeler/dist/commons-modeler-21122011.jar -Djmxtools.jar=/srv/gump/packages/jmx-1_2_1-bin/lib/jmxtools.jar -Djmx.jar=/srv/gump/packages/jmx-1_2_1-bin/lib/jmxri.jar -Dtomcat-util.jar=/srv/gump/public/workspace/jakarta-tomcat-connectors/util/build/lib/tomcat-util.jar -Dant.home=/ srv/gump/public/workspace/ant/dist -Dservlet22.jar=/srv/gump/public/workspace/jakarta-servletapi/dist/lib/servlet.jar -Dtomcat-jk.home=/srv/gump/public/workspace/tomcat-connectors-native -Dcommons-logging.jar=/srv/gump/public/workspace/apache-commons/logging/target/commons-logging-api-21122011.jar -Djtc.http11.home=/srv/gump/public/workspace/jakarta-tomcat-connectors/http11/build -Djsse.home=/srv/gump/packages/jsse1.0.3 tomcat [Working Directory: /srv/gump/public/workspace/jakarta-tomcat] CLASSPATH: /usr/lib/jvm/java-6-openjdk/lib/tools.jar:/srv/gump/public/workspace/jakarta-tomcat/build/tomcat/classes:/srv/gump/public/workspace/xml-commons/java/external/build/xml-apis-ext.jar:/srv/gump/public/workspace/ant/dist/lib/ant.jar:/srv/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/srv/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit.jar:/srv/gump/public/workspace/ant/dist/lib/ant-swing.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-resolver.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-xalan2.jar:/srv/gump/public/workspace/xml-commons/java/build/resolver.jar:/srv/gump/public/workspace/jakarta-servletapi/dist/lib/servlet.jar:/srv/gump/packages/jsse1.0.3/lib/jsse.jar:/srv/gump/packages/jsse1.0.3/lib/jnet.jar:/srv/gump/packages/jsse1.0.3/lib/jcert.jar:/srv/gump/public/workspace/logging-log4j-12/dist/lib/log4j-21122011.jar:/srv/gump/public/workspace/apache-commons/modeler/dist/commons-modeler-2112201
