svn commit: r1586227 - /tomcat/native/branches/1.1.x/xdocs/miscellaneous/changelog.xml

2014-04-09 Thread mturk 
Author: mturk
Date: Thu Apr 10 06:55:27 2014
New Revision: 1586227

URL: http://svn.apache.org/r1586227
Log:
Resolve 56363 bug

Modified:
tomcat/native/branches/1.1.x/xdocs/miscellaneous/changelog.xml

Modified: tomcat/native/branches/1.1.x/xdocs/miscellaneous/changelog.xml
URL: 
http://svn.apache.org/viewvc/tomcat/native/branches/1.1.x/xdocs/miscellaneous/changelog.xml?rev=1586227&r1=1586226&r2=1586227&view=diff
==
--- tomcat/native/branches/1.1.x/xdocs/miscellaneous/changelog.xml (original)
+++ tomcat/native/branches/1.1.x/xdocs/miscellaneous/changelog.xml Thu Apr 10 
06:55:27 2014
@@ -39,6 +39,9 @@
 
   
 
+  56363: Use OpenSSL 1.0.1g with Windows binaries. (mturk)
+  
+
   55915: Apply Mike Noordermeer's patch for ECDHE support. 
(mturk)
 
 



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 56363] OpenSSL security advisory - Heartbleed bug

2014-04-09 Thread bugzilla 
https://issues.apache.org/bugzilla/show_bug.cgi?id=56363

Jani Similä  changed:

   What|Removed |Added

 CC||jani.sim...@gmail.com

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 56363] OpenSSL security advisory - Heartbleed bug

2014-04-09 Thread bugzilla 
https://issues.apache.org/bugzilla/show_bug.cgi?id=56363

Tomi Korkalainen  changed:

   What|Removed |Added

 CC||tomi.korkalai...@gmail.com

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r1586221 - /tomcat/native/branches/1.1.x/native/include/ssl_private.h

2014-04-09 Thread mturk 
Author: mturk
Date: Thu Apr 10 05:44:09 2014
New Revision: 1586221

URL: http://svn.apache.org/r1586221
Log:
Revert NO_SSL_INTERN define. We need direct struct access for sslinfo

Modified:
tomcat/native/branches/1.1.x/native/include/ssl_private.h

Modified: tomcat/native/branches/1.1.x/native/include/ssl_private.h
URL: 
http://svn.apache.org/viewvc/tomcat/native/branches/1.1.x/native/include/ssl_private.h?rev=1586221&r1=1586220&r2=1586221&view=diff
==
--- tomcat/native/branches/1.1.x/native/include/ssl_private.h (original)
+++ tomcat/native/branches/1.1.x/native/include/ssl_private.h Thu Apr 10 
05:44:09 2014
@@ -40,12 +40,7 @@
 #endif
 
 /* OpenSSL headers */
-/* OpenSSL headers */
 #include 
-#if (OPENSSL_VERSION_NUMBER >= 0x10001000)
-/* must be defined before including ssl.h */
-#define OPENSSL_NO_SSL_INTERN
-#endif
 #include 
 #include 
 #include 



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Tagging Tomcat Native 1.1.30

2014-04-09 Thread Mladen Turk 

I plan to tag 1.1.30 either later today or tomorrow and
push for a quick release vote.

Comments?

Regards
--
^TM

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

buildbot success in ASF Buildbot on tomcat-trunk

2014-04-09 Thread buildbot 
The Buildbot has detected a restored build on builder tomcat-trunk while 
building ASF Buildbot.
Full details are available at:
 http://ci.apache.org/builders/tomcat-trunk/builds/5668

Buildbot URL: http://ci.apache.org/

Buildslave for this Build: bb-vm_ubuntu

Build Reason: scheduler
Build Source Stamp: [branch tomcat/trunk] 1586177
Blamelist: remm

Build succeeded!

sincerely,
 -The Buildbot

[Bug 55943] Provide a way prevent looking at the System classloader before the webapp classloaders

2014-04-09 Thread bugzilla 
https://issues.apache.org/bugzilla/show_bug.cgi?id=55943

--- Comment #11 from hifisoftw...@gmail.com ---
Thank Mark for the link. I have trouble understanding how to configure to
follow the old behaviour.

Are you suggesting to override the WebappClassLoader class?

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

buildbot failure in ASF Buildbot on tomcat-trunk

2014-04-09 Thread buildbot 
The Buildbot has detected a new failure on builder tomcat-trunk while building 
ASF Buildbot.
Full details are available at:
 http://ci.apache.org/builders/tomcat-trunk/builds/5667

Buildbot URL: http://ci.apache.org/

Buildslave for this Build: bb-vm_ubuntu

Build Reason: scheduler
Build Source Stamp: [branch tomcat/trunk] 1586150
Blamelist: remm

BUILD FAILED: failed compile_1

sincerely,
 -The Buildbot




-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r1586177 - in /tomcat/trunk: java/org/apache/coyote/http11/upgrade/AbstractServletOutputStream.java java/org/apache/coyote/http11/upgrade/Nio2ServletOutputStream.java test/org/apache/tomca

2014-04-09 Thread remm 
Author: remm
Date: Wed Apr  9 23:57:09 2014
New Revision: 1586177

URL: http://svn.apache.org/r1586177
Log:
Does not fix the testsuite run, so revert.

Modified:

tomcat/trunk/java/org/apache/coyote/http11/upgrade/AbstractServletOutputStream.java

tomcat/trunk/java/org/apache/coyote/http11/upgrade/Nio2ServletOutputStream.java

tomcat/trunk/test/org/apache/tomcat/websocket/TestWebSocketFrameClientSSL.java

Modified: 
tomcat/trunk/java/org/apache/coyote/http11/upgrade/AbstractServletOutputStream.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/coyote/http11/upgrade/AbstractServletOutputStream.java?rev=1586177&r1=1586176&r2=1586177&view=diff
==
--- 
tomcat/trunk/java/org/apache/coyote/http11/upgrade/AbstractServletOutputStream.java
 (original)
+++ 
tomcat/trunk/java/org/apache/coyote/http11/upgrade/AbstractServletOutputStream.java
 Wed Apr  9 23:57:09 2014
@@ -76,9 +76,6 @@ public abstract class AbstractServletOut
 synchronized (fireListenerLock) {
 boolean result = (buffer == null);
 fireListener = !result;
-if (fireListener) {
-registerWriteInterest();
-}
 return result;
 }
 }
@@ -239,8 +236,4 @@ public abstract class AbstractServletOut
 protected abstract void doFlush() throws IOException;
 
 protected abstract void doClose() throws IOException;
-
-protected void registerWriteInterest() {
-}
-
 }

Modified: 
tomcat/trunk/java/org/apache/coyote/http11/upgrade/Nio2ServletOutputStream.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/coyote/http11/upgrade/Nio2ServletOutputStream.java?rev=1586177&r1=1586176&r2=1586177&view=diff
==
--- 
tomcat/trunk/java/org/apache/coyote/http11/upgrade/Nio2ServletOutputStream.java 
(original)
+++ 
tomcat/trunk/java/org/apache/coyote/http11/upgrade/Nio2ServletOutputStream.java 
Wed Apr  9 23:57:09 2014
@@ -176,14 +176,4 @@ public class Nio2ServletOutputStream ext
 channel.close(true);
 }
 
-@Override
-protected void registerWriteInterest() {
-synchronized (completionHandler) {
-if (writePending.availablePermits() > 0) {
-// If no write is pending, notify
-endpoint.processSocket(socketWrapper, SocketStatus.OPEN_WRITE, 
true);
-}
-}
-}
-
 }

Modified: 
tomcat/trunk/test/org/apache/tomcat/websocket/TestWebSocketFrameClientSSL.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/test/org/apache/tomcat/websocket/TestWebSocketFrameClientSSL.java?rev=1586177&r1=1586176&r2=1586177&view=diff
==
--- 
tomcat/trunk/test/org/apache/tomcat/websocket/TestWebSocketFrameClientSSL.java 
(original)
+++ 
tomcat/trunk/test/org/apache/tomcat/websocket/TestWebSocketFrameClientSSL.java 
Wed Apr  9 23:57:09 2014
@@ -46,6 +46,11 @@ public class TestWebSocketFrameClientSSL
 
 @Test
 public void testConnectToServerEndpoint() throws Exception {
+Assume.assumeFalse(
+"Skip this test on NIO2. FIXME: NIO2 SSL only issue.",
+getTomcatInstance().getConnector().getProtocol()
+.equals("org.apache.coyote.http11.Http11Nio2Protocol"));
+
 Tomcat tomcat = getTomcatInstance();
 // Must have a real docBase - just use temp
 Context ctx =



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 56363] OpenSSL security advisory - Heartbleed bug

2014-04-09 Thread bugzilla 
https://issues.apache.org/bugzilla/show_bug.cgi?id=56363

Keith Davis  changed:

   What|Removed |Added

 CC||keithdavis@solidtechservice
   ||.com

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 56363] OpenSSL security advisory - Heartbleed bug

2014-04-09 Thread bugzilla 
https://issues.apache.org/bugzilla/show_bug.cgi?id=56363

Klemen Novak  changed:

   What|Removed |Added

 CC||klemen.no...@mikrocop.com

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r1586150 - in /tomcat/trunk: java/org/apache/coyote/http11/ java/org/apache/coyote/http11/upgrade/ test/org/apache/tomcat/websocket/

2014-04-09 Thread remm 
Author: remm
Date: Wed Apr  9 21:21:16 2014
New Revision: 1586150

URL: http://svn.apache.org/r1586150
Log:
- Add possibly missing notification.
- Try again the SSL websocket test, will revert the commit if not fixed.

Modified:
tomcat/trunk/java/org/apache/coyote/http11/InternalNio2InputBuffer.java

tomcat/trunk/java/org/apache/coyote/http11/upgrade/AbstractServletOutputStream.java

tomcat/trunk/java/org/apache/coyote/http11/upgrade/Nio2ServletOutputStream.java

tomcat/trunk/test/org/apache/tomcat/websocket/TestWebSocketFrameClientSSL.java

Modified: 
tomcat/trunk/java/org/apache/coyote/http11/InternalNio2InputBuffer.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/coyote/http11/InternalNio2InputBuffer.java?rev=1586150&r1=1586149&r2=1586150&view=diff
==
--- tomcat/trunk/java/org/apache/coyote/http11/InternalNio2InputBuffer.java 
(original)
+++ tomcat/trunk/java/org/apache/coyote/http11/InternalNio2InputBuffer.java Wed 
Apr  9 21:21:16 2014
@@ -905,7 +905,7 @@ public class InternalNio2InputBuffer ext
 if (readPending) {
 interest = true;
 } else {
-// If no write is pending, notify
+// If no read is pending, notify
 endpoint.processSocket(socket, SocketStatus.OPEN_READ, true);
 }
 }

Modified: 
tomcat/trunk/java/org/apache/coyote/http11/upgrade/AbstractServletOutputStream.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/coyote/http11/upgrade/AbstractServletOutputStream.java?rev=1586150&r1=1586149&r2=1586150&view=diff
==
--- 
tomcat/trunk/java/org/apache/coyote/http11/upgrade/AbstractServletOutputStream.java
 (original)
+++ 
tomcat/trunk/java/org/apache/coyote/http11/upgrade/AbstractServletOutputStream.java
 Wed Apr  9 21:21:16 2014
@@ -76,6 +76,9 @@ public abstract class AbstractServletOut
 synchronized (fireListenerLock) {
 boolean result = (buffer == null);
 fireListener = !result;
+if (fireListener) {
+registerWriteInterest();
+}
 return result;
 }
 }
@@ -236,4 +239,8 @@ public abstract class AbstractServletOut
 protected abstract void doFlush() throws IOException;
 
 protected abstract void doClose() throws IOException;
+
+protected void registerWriteInterest() {
+}
+
 }

Modified: 
tomcat/trunk/java/org/apache/coyote/http11/upgrade/Nio2ServletOutputStream.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/coyote/http11/upgrade/Nio2ServletOutputStream.java?rev=1586150&r1=1586149&r2=1586150&view=diff
==
--- 
tomcat/trunk/java/org/apache/coyote/http11/upgrade/Nio2ServletOutputStream.java 
(original)
+++ 
tomcat/trunk/java/org/apache/coyote/http11/upgrade/Nio2ServletOutputStream.java 
Wed Apr  9 21:21:16 2014
@@ -175,4 +175,15 @@ public class Nio2ServletOutputStream ext
 protected void doClose() throws IOException {
 channel.close(true);
 }
+
+@Override
+protected void registerWriteInterest() {
+synchronized (completionHandler) {
+if (writePending.availablePermits() > 0) {
+// If no write is pending, notify
+endpoint.processSocket(socketWrapper, SocketStatus.OPEN_WRITE, 
true);
+}
+}
+}
+
 }

Modified: 
tomcat/trunk/test/org/apache/tomcat/websocket/TestWebSocketFrameClientSSL.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/test/org/apache/tomcat/websocket/TestWebSocketFrameClientSSL.java?rev=1586150&r1=1586149&r2=1586150&view=diff
==
--- 
tomcat/trunk/test/org/apache/tomcat/websocket/TestWebSocketFrameClientSSL.java 
(original)
+++ 
tomcat/trunk/test/org/apache/tomcat/websocket/TestWebSocketFrameClientSSL.java 
Wed Apr  9 21:21:16 2014
@@ -46,11 +46,6 @@ public class TestWebSocketFrameClientSSL
 
 @Test
 public void testConnectToServerEndpoint() throws Exception {
-Assume.assumeFalse(
-"Skip this test on NIO2. FIXME: NIO2 SSL only issue.",
-getTomcatInstance().getConnector().getProtocol()
-.equals("org.apache.coyote.http11.Http11Nio2Protocol"));
-
 Tomcat tomcat = getTomcatInstance();
 // Must have a real docBase - just use temp
 Context ctx =



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: Tagging JK 1.2.40

2014-04-09 Thread Mladen Turk 

On 04/09/2014 07:38 PM, Rainer Jung wrote:

On 08.04.2014 09:56, Mladen Turk wrote:

Hi,

I plan to tag JK 1.2.40 pretty soon (probably end of this week)
We have few bugs in the latest release which requires a new version.


I'm all for it, to many bugs which might affect many users.
Just now fixed another one (chunked requests broken).

If we keep only fixing real errors and let the rest of the code as-is,
we'll likely get a more stable release (means: let's not do bigger
refactorings or features this time).



+1. I'll tag on Friday and push for a release.


Regards
--
^TM

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn propchange: r1586044 - svn:log

2014-04-09 Thread rjung 
Author: rjung
Revision: 1586044
Modified property: svn:log

Modified: svn:log at Wed Apr  9 17:39:54 2014
--
--- svn:log (original)
+++ svn:log Wed Apr  9 17:39:54 2014
@@ -1,4 +1,4 @@
 Fix forwarding of chunked requests, which is
-broken in version 1.2.37.
+broken in version 1.2.39.
 
 Bug was introduced by refactoring in r1555413.


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: Tagging JK 1.2.40

2014-04-09 Thread Rainer Jung 
On 08.04.2014 09:56, Mladen Turk wrote:
> Hi,
> 
> I plan to tag JK 1.2.40 pretty soon (probably end of this week)
> We have few bugs in the latest release which requires a new version.

I'm all for it, to many bugs which might affect many users.
Just now fixed another one (chunked requests broken).

If we keep only fixing real errors and let the rest of the code as-is,
we'll likely get a more stable release (means: let's not do bigger
refactorings or features this time).

Regards,

Rainer


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: ErrorValve enhancement

2014-04-09 Thread Romain Manni-Bucau 
Hi

for this kind of reason we included in tomee
http://svn.apache.org/repos/asf/tomee/tomee/trunk/tomee/tomee-catalina/src/main/java/org/apache/tomee/catalina/valve/MinimumErrorReportValve.java

would be great to get it in tomcat OOTB.

Romain Manni-Bucau
Twitter: @rmannibucau
Blog: http://rmannibucau.wordpress.com/
LinkedIn: http://fr.linkedin.com/in/rmannibucau
Github: https://github.com/rmannibucau



2014-04-09 18:36 GMT+02:00 Nick Bunn :
> Good Day,
> As i'm sure you are all aware when the default error valve returns its
> report it publishes the tomcat version and some other troubleshooting data.
> This of course breaks one of my securities teams rules and also is published
> as a item that needs to be remediated when hardening tomcat(OWASP -
> goo.gl/Zr9xso ). When using the OWASP solution of replacing the
> serverInfo.properties file it can and will break tools/code that uses that
> information(in my case our deployment agent). The other two solutions are to
> create our own valve and just change it to the default error valve or
> override the status code at the HTTPD server(which broke our JSON and SOAP
> requests that were providing valid 4XX and 5XX). That being said why not
> just have the capability to disable this information in the current error
> valve? This way we are not requiring users to override there
> serverinfo.properties or create some customer error valve they will have to
> maintain. Thoughts?
>
> Attached is the a simple patch to version 7.0.x. Can easily be ported to
> 8.0.x as not much as changed. You would then just add the below to your
> server.xml
>
>  showReport="false" showServerInfo="false" />
>
>
> Thanks,
> Nick Bunn
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r1586044 - in /tomcat/jk/trunk: native/common/jk_ajp_common.c xdocs/miscellaneous/changelog.xml

2014-04-09 Thread rjung 
Author: rjung
Date: Wed Apr  9 17:26:13 2014
New Revision: 1586044

URL: http://svn.apache.org/r1586044
Log:
Fix forwarding of chunked requests, which is
broken in version 1.2.37.

Bug was introduced by refactoring in r1555413.

Modified:
tomcat/jk/trunk/native/common/jk_ajp_common.c
tomcat/jk/trunk/xdocs/miscellaneous/changelog.xml

Modified: tomcat/jk/trunk/native/common/jk_ajp_common.c
URL: 
http://svn.apache.org/viewvc/tomcat/jk/trunk/native/common/jk_ajp_common.c?rev=1586044&r1=1586043&r2=1586044&view=diff
==
--- tomcat/jk/trunk/native/common/jk_ajp_common.c (original)
+++ tomcat/jk/trunk/native/common/jk_ajp_common.c Wed Apr  9 17:26:13 2014
@@ -1482,7 +1482,7 @@ static int ajp_read_into_msg_buff(ajp_en
 if ((r->is_chunked && len == 0) || len < 0 || len > maxlen) {
 len = maxlen;
 }
-if ((jk_uint64_t)len > ae->left_bytes_to_send) {
+if (ae->left_bytes_to_send > 0 && (jk_uint64_t)len > 
ae->left_bytes_to_send) {
 len = (int)ae->left_bytes_to_send;
 }
 

Modified: tomcat/jk/trunk/xdocs/miscellaneous/changelog.xml
URL: 
http://svn.apache.org/viewvc/tomcat/jk/trunk/xdocs/miscellaneous/changelog.xml?rev=1586044&r1=1586043&r2=1586044&view=diff
==
--- tomcat/jk/trunk/xdocs/miscellaneous/changelog.xml (original)
+++ tomcat/jk/trunk/xdocs/miscellaneous/changelog.xml Wed Apr  9 17:26:13 2014
@@ -45,6 +45,10 @@
   
 
   
+Fix forwarding of chunked requests, which is broken in version 1.2.39.
+(rjung)
+  
+  
 56352: Fix regression in memory release. (mturk)
   
   



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

ErrorValve enhancement

2014-04-09 Thread Nick Bunn 
Good Day,
As i'm sure you are all aware when the default error valve returns its
report it publishes the tomcat version and some other troubleshooting data.
This of course breaks one of my securities teams rules and also is
published as a item that needs to be remediated when hardening tomcat(OWASP
- goo.gl/Zr9xso ). When using the OWASP solution of replacing the
serverInfo.properties file it can and will break tools/code that uses that
information(in my case our deployment agent). The other two solutions are
to create our own valve and just change it to the default error valve or
override the status code at the HTTPD server(which broke our JSON and SOAP
requests that were providing valid 4XX and 5XX). That being said why not
just have the capability to disable this information in the current error
valve? This way we are not requiring users to override there
serverinfo.properties or create some customer error valve they will have to
maintain. Thoughts?

Attached is the a simple patch to version 7.0.x. Can easily be ported to
8.0.x as not much as changed. You would then just add the below to your
server.xml



Thanks,
Nick Bunn
### Eclipse Workspace Patch 1.0
#P Tomcat_7.0.x
Index: java/org/apache/catalina/valves/ErrorReportValve.java
===
--- java/org/apache/catalina/valves/ErrorReportValve.java   (revision 
1583670)
+++ java/org/apache/catalina/valves/ErrorReportValve.java   (working copy)
@@ -62,7 +62,9 @@
 private static final String info =
 "org.apache.catalina.valves.ErrorReportValve/1.0";
 
-
+private boolean showReport = true;
+
+private boolean showServerInfo = true;
 // - Properties
 
 
@@ -196,11 +198,13 @@
 report = smClient.getString("errorReportValve.noDescription");
 }
 }
-
+
 StringBuilder sb = new StringBuilder();
 
 sb.append("");
-sb.append(ServerInfo.getServerInfo()).append(" - ");
+if(showServerInfo) {
+   sb.append(ServerInfo.getServerInfo()).append(" - ");
+}
 sb.append(smClient.getString("errorReportValve.errorReport"));
 sb.append("");
 sb.append("

[jira] [Commented] (MTOMCAT-266) The attribute crashes Tomcat on startup

2014-04-09 Thread M. R. (JIRA) 

[ 
https://issues.apache.org/jira/browse/MTOMCAT-266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13964332#comment-13964332
 ] 

M. R. commented on MTOMCAT-266:
---

I'm using 3.2.1.
Do you have a suggestion about which version I can downgrade to, so I can do 
some tests?

Just to be clear, the crash happens when I do "mvn tomcat7:run" (I see I didn't 
point that out in my original message).


> The  attribute crashes Tomcat on startup
> --
>
> Key: MTOMCAT-266
> URL: https://issues.apache.org/jira/browse/MTOMCAT-266
> Project: Apache Tomcat Maven Plugin
>  Issue Type: Bug
>  Components: tomcat7
>Affects Versions: 2.2
> Environment: Windows 8.1, Java 1.7.0_51 and Maven 3.2.1
>Reporter: M. R.
>Assignee: Olivier Lamy (*$^¨%`£)
>Priority: Minor
> Attachments: tomcat-plugin-crash.txt
>
>
> The plugin works perfectly running Tomcat with my project web application.
> I do "mvn tomcat7:run" and the server is started, the webapp is deployed and 
> I can browse to it.
> If I add the  attribute, though, the server crashes.
> Here's (a portion of) my pom:
> 
> org.apache.tomcat.maven
> tomcat7-maven-plugin
> 2.2
> 
> localhost
> 8080
> /
> UTF-8
> 
> 
> (I'll add the stacktrace later)



--
This message was sent by Atlassian JIRA
(v6.2#6252)

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 56378] Cert load fails if cert is located in path with non-ASCII characters

2014-04-09 Thread bugzilla 
https://issues.apache.org/bugzilla/show_bug.cgi?id=56378

Mladen Turk  changed:

   What|Removed |Added

 OS||All

--- Comment #1 from Mladen Turk  ---
I don't think OpenSSL supports UTF encoding for file system. It uses simple
fopen which is OEM encoded (for Windows). We would probably need some custom
encoder from UTF to OEM which I think is just too much for the few edge case.

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 56283] Add support for Java 8 to Jasper

2014-04-09 Thread bugzilla 
https://issues.apache.org/bugzilla/show_bug.cgi?id=56283

--- Comment #4 from Mark Thomas  ---
Patch applied to 6.0.x for 6.0.40 onwards.

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r1585997 - in /tomcat/tc6.0.x/trunk: STATUS.txt java/org/apache/catalina/startup/TldConfig.java java/org/apache/jasper/compiler/JDTCompiler.java java/org/apache/jasper/compiler/TldLocation

2014-04-09 Thread markt 
Author: markt
Date: Wed Apr  9 15:41:28 2014
New Revision: 1585997

URL: http://svn.apache.org/r1585997
Log:
Fix http://issues.apache.org/bugzilla/show_bug.cgi?id=56283
Add support for running Tomcat 6 with ecj-P20140317-1600.jar (as drop-in 
replacement for ecj-4.3.1.jar).
Add support for value "1.8" for the compilerSourceVM and compilerTargetVM 
options.
Note that ecj-P20140317-1600.jar can only be used when running with Java 6 or 
later. The "1.8" options make sense only when running with Java 8 (or later).

Modified:
tomcat/tc6.0.x/trunk/STATUS.txt
tomcat/tc6.0.x/trunk/java/org/apache/catalina/startup/TldConfig.java
tomcat/tc6.0.x/trunk/java/org/apache/jasper/compiler/JDTCompiler.java
tomcat/tc6.0.x/trunk/java/org/apache/jasper/compiler/TldLocationsCache.java
tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml

Modified: tomcat/tc6.0.x/trunk/STATUS.txt
URL: 
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=1585997&r1=1585996&r2=1585997&view=diff
==
--- tomcat/tc6.0.x/trunk/STATUS.txt (original)
+++ tomcat/tc6.0.x/trunk/STATUS.txt Wed Apr  9 15:41:28 2014
@@ -28,17 +28,6 @@ None
 PATCHES PROPOSED TO BACKPORT:
   [ New proposals should be added at the end of the list ]
 
-* Fix http://issues.apache.org/bugzilla/show_bug.cgi?id=56283
-  Add support for running Tomcat 6 with ecj-P20140317-1600.jar (as drop-in
-  replacement for ecj-4.3.1.jar). Add support for value "1.8" for the
-  compilerSourceVM and compilerTargetVM options.
-  Note that, per previous comments, ecj-P20140317-1600.jar can only be used 
when
-  running with Java 6 or later. The "1.8" options make sense only when running
-  with Java 8 (or later).
-  https://issues.apache.org/bugzilla/attachment.cgi?id=31476&action=diff
-  +1: markt, schultz, kkolinko
-  -1:
-
 * Add a work around for validating XML documents (often TLDs) that use
   just the file name to refer to refer to the JavaEE schema on which they
   are based.

Modified: tomcat/tc6.0.x/trunk/java/org/apache/catalina/startup/TldConfig.java
URL: 
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/java/org/apache/catalina/startup/TldConfig.java?rev=1585997&r1=1585996&r2=1585997&view=diff
==
--- tomcat/tc6.0.x/trunk/java/org/apache/catalina/startup/TldConfig.java 
(original)
+++ tomcat/tc6.0.x/trunk/java/org/apache/catalina/startup/TldConfig.java Wed 
Apr  9 15:41:28 2014
@@ -94,6 +94,8 @@ public final class TldConfig  implements
 noTldJars.add("ecj-4.2.1.jar");
 noTldJars.add("ecj-4.2.2.jar");
 noTldJars.add("ecj-4.3.1.jar");
+noTldJars.add("ecj-4.3.2.jar");
+noTldJars.add("ecj-P20140317-1600.jar");
 noTldJars.add("jsp-api.jar");
 noTldJars.add("servlet-api.jar");
 noTldJars.add("tomcat-coyote.jar");

Modified: tomcat/tc6.0.x/trunk/java/org/apache/jasper/compiler/JDTCompiler.java
URL: 
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/java/org/apache/jasper/compiler/JDTCompiler.java?rev=1585997&r1=1585996&r2=1585997&view=diff
==
--- tomcat/tc6.0.x/trunk/java/org/apache/jasper/compiler/JDTCompiler.java 
(original)
+++ tomcat/tc6.0.x/trunk/java/org/apache/jasper/compiler/JDTCompiler.java Wed 
Apr  9 15:41:28 2014
@@ -310,6 +310,9 @@ public class JDTCompiler extends org.apa
 } else if(opt.equals("1.7")) {
 settings.put(CompilerOptions.OPTION_Source,
  CompilerOptions.VERSION_1_7);
+} else if(opt.equals("1.8")) {
+settings.put(CompilerOptions.OPTION_Source,
+ "1.8"); // CompilerOptions.VERSION_1_8
 } else {
 log.warn("Unknown source VM " + opt + " ignored.");
 settings.put(CompilerOptions.OPTION_Source,
@@ -351,6 +354,11 @@ public class JDTCompiler extends org.apa
  CompilerOptions.VERSION_1_7);
 settings.put(CompilerOptions.OPTION_Compliance,
 CompilerOptions.VERSION_1_7);
+} else if(opt.equals("1.8")) {
+settings.put(CompilerOptions.OPTION_TargetPlatform,
+"1.8"); // CompilerOptions.VERSION_1_8
+settings.put(CompilerOptions.OPTION_Compliance,
+"1.8"); // CompilerOptions.VERSION_1_8
 } else {
 log.warn("Unknown target VM " + opt + " ignored.");
 settings.put(CompilerOptions.OPTION_TargetPlatform,

Modified: 
tomcat/tc6.0.x/trunk/java/org/apache/jasper/compiler/TldLocationsCache.java
URL: 
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/java/org/apache/jasper/compiler/TldLocationsCache.java?rev=1585997&r1=1585996&r2=1585997&view=diff
==
--- t

[Bug 56378] New: Cert load fails if cert is located in path with non-ASCII characters

2014-04-09 Thread bugzilla 
https://issues.apache.org/bugzilla/show_bug.cgi?id=56378

Bug ID: 56378
   Summary: Cert load fails if cert is located in path with
non-ASCII characters
   Product: Tomcat Native
   Version: 1.1.29
  Hardware: PC
Status: NEW
  Severity: normal
  Priority: P2
 Component: Library
  Assignee: dev@tomcat.apache.org
  Reporter: ma...@apache.org

A path known to cause isses with loading certs is:
C:\testüö

If Tomcat is installed in theis location then the certs fail to load from the
conf directory.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 46179] apr ssl client authentication

2014-04-09 Thread bugzilla 
https://issues.apache.org/bugzilla/show_bug.cgi?id=46179

Mark Thomas  changed:

   What|Removed |Added

 Status|REOPENED|RESOLVED
 Resolution|--- |WORKSFORME

--- Comment #5 from Mark Thomas  ---
This is tested with every Tomcat 7 release when we run the Servlet TCK which
explicitly tests CLIENT-CERT authentication.

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 56374] Page in wrong language - getting lower rank Accept-Language in request header

2014-04-09 Thread bugzilla 
https://issues.apache.org/bugzilla/show_bug.cgi?id=56374

Steve Root  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

--- Comment #8 from Steve Root  ---
It's fine on 7.0.53
Thanks!

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r1585966 - /tomcat/native/branches/1.1.x/xdocs/miscellaneous/changelog.xml

2014-04-09 Thread mturk 
Author: mturk
Date: Wed Apr  9 13:38:42 2014
New Revision: 1585966

URL: http://svn.apache.org/r1585966
Log:
Change patch author

Modified:
tomcat/native/branches/1.1.x/xdocs/miscellaneous/changelog.xml

Modified: tomcat/native/branches/1.1.x/xdocs/miscellaneous/changelog.xml
URL: 
http://svn.apache.org/viewvc/tomcat/native/branches/1.1.x/xdocs/miscellaneous/changelog.xml?rev=1585966&r1=1585965&r2=1585966&view=diff
==
--- tomcat/native/branches/1.1.x/xdocs/miscellaneous/changelog.xml (original)
+++ tomcat/native/branches/1.1.x/xdocs/miscellaneous/changelog.xml Wed Apr  9 
13:38:42 2014
@@ -39,7 +39,7 @@
 
   
 
-  55915: Apply Ognjen's patch for ECDHE support. (mturk)
+  55915: Apply Mike Noordermeer's patch for ECDHE support. 
(mturk)
 
 
   55663: Minor correction to the wording of the NOTICE file



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: svn commit: r1585898 - in /tomcat/native/branches/1.1.x: native/src/sslcontext.c xdocs/miscellaneous/changelog.xml

2014-04-09 Thread Ognjen Blagojevic 

On 9.4.2014 9:32, mt...@apache.org wrote:

Log:
Apply Ognjen's patch for bz55915


For the record, I am an issue reporter, but patch was provided by Mike 
Noordermeer.


-Ognjen


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: JDK 9 build 06 is available on java.net

2014-04-09 Thread Rory O'Donnell Oracle, Dublin ireland 

https://bugs.openjdk.java.net/browse/JDK-8039751

Dalibor has written a blog  
on how to track your issues in the

JDK bug system. I hope this helps.

Rgds,Rory

On 04/ 9/14 01:25 PM, Mark Thomas wrote:

On 09/04/2014 05:59, Mark Thomas wrote:

On 09/04/2014 05:14, Rory O'Donnell Oracle, Dublin ireland wrote:

Hi Mark,

If you log a bug, send me the incident number, I will follow
it up.

I'll see if I can find the incident number for the bug I already
reported but I think I deleted the e-mail after 6 or so months of no
response. If I don't find it, I open a new incident.

Your Report (Review ID: JI-9011609) - UTF-8 decoder fails to handle some
edge cases correctly

I didn't say so in the bug report but I'm happy to walk Oracle through
any of the failing test cases if it isn't clear why any of them are
bugs. Just point them towards the Tomcat dev list.

If you can nudge the right folks into getting this fixed for both Java 7
and Java 8 that would great. I'd be extremely happy to be able to delete
Tomcat's customer UTF-8 decoder.

Mark



Mark



Rgds, Rory

On 04/ 9/14 12:00 PM, Mark Thomas wrote:

On 09/04/2014 04:36, Rory O'Donnell Oracle, Dublin ireland wrote:

Hi Mark,

I suggest you send an email to core-libs-...@openjdk.java.net
or log a bug.

I've already filed the bug against Java. As far as I recall I never
received any response  - not unusual in my experience of reporting bugs
with Java. I've pretty much reached the conclusion - after reporting
multiple bugs only to have them completely ignored - that reporting bugs
in Java is a waste of my time.

I'll try the e-mail route but I have little hope that anything will
actually come of it.

Mark



Rgds, Rory

On 04/ 8/14 12:49 PM, Mark Thomas wrote:

On 08/04/2014 02:25, Rory O'Donnell Oracle, Dublin Ireland wrote:

Hi Mladen,

JDK 9 Build 06 Early Access Build is now available for download
 & test.

Rgds, Rory


Rory,

Java 8 (and I am guessing Java 9) still has issues with UTF-8 decoding.

For the latest status, see the Tomcat 8 unit tests for Java 8 decoding
[1]. If you look at the change history you'll see how things improved
between Java 7 and Java 8. It should be obvious what the problems are
from that unit test but ask of the Tomcat dev list if things aren't
clear.


Mark


[1]
http://svn.apache.org/viewvc/tomcat/trunk/test/org/apache/tomcat/util/buf/TestUtf8.java?view=annotate




-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



--
Rgds,
Rory O'Donnell

Senior Quality Engineering Manager
Java Platform Group
Oracle EMEA , Block P5,
East Point Business Park, Dublin 3
Phone: +353 (0)1 8033887

svn commit: r1585960 - /tomcat/tc6.0.x/trunk/STATUS.txt

2014-04-09 Thread kkolinko 
Author: kkolinko
Date: Wed Apr  9 13:02:45 2014
New Revision: 1585960

URL: http://svn.apache.org/r1585960
Log:
vote

Modified:
tomcat/tc6.0.x/trunk/STATUS.txt

Modified: tomcat/tc6.0.x/trunk/STATUS.txt
URL: 
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=1585960&r1=1585959&r2=1585960&view=diff
==
--- tomcat/tc6.0.x/trunk/STATUS.txt (original)
+++ tomcat/tc6.0.x/trunk/STATUS.txt Wed Apr  9 13:02:45 2014
@@ -36,7 +36,7 @@ PATCHES PROPOSED TO BACKPORT:
   running with Java 6 or later. The "1.8" options make sense only when running
   with Java 8 (or later).
   https://issues.apache.org/bugzilla/attachment.cgi?id=31476&action=diff
-  +1: markt, schultz
+  +1: markt, schultz, kkolinko
   -1:
 
 * Add a work around for validating XML documents (often TLDs) that use



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r1585957 - /tomcat/native/branches/1.1.x/native/src/sslcontext.c

2014-04-09 Thread mturk 
Author: mturk
Date: Wed Apr  9 12:54:25 2014
New Revision: 1585957

URL: http://svn.apache.org/r1585957
Log:
Ensure we have the needed ECDH with the OpenSSL used

Modified:
tomcat/native/branches/1.1.x/native/src/sslcontext.c

Modified: tomcat/native/branches/1.1.x/native/src/sslcontext.c
URL: 
http://svn.apache.org/viewvc/tomcat/native/branches/1.1.x/native/src/sslcontext.c?rev=1585957&r1=1585956&r2=1585957&view=diff
==
--- tomcat/native/branches/1.1.x/native/src/sslcontext.c (original)
+++ tomcat/native/branches/1.1.x/native/src/sslcontext.c Wed Apr  9 12:54:25 
2014
@@ -154,10 +154,12 @@ TCN_IMPLEMENT_CALL(jlong, SSLContext, ma
(unsigned long)((sizeof SSL_DEFAULT_VHOST_NAME) - 1),
&(c->context_id[0]), NULL, EVP_sha1(), NULL);
 if (mode) {
+#ifdef HAVE_ECC
 /* Set default (nistp256) elliptic curve for ephemeral ECDH keys */
 EC_KEY *ecdh = EC_KEY_new_by_curve_name(NID_X9_62_prime256v1);
 SSL_CTX_set_tmp_ecdh(c->ctx, ecdh);
 EC_KEY_free(ecdh);
+#endif
 SSL_CTX_set_tmp_rsa_callback(c->ctx, SSL_callback_tmp_RSA);
 SSL_CTX_set_tmp_dh_callback(c->ctx,  SSL_callback_tmp_DH);
 }



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: svn commit: r1585898 - in /tomcat/native/branches/1.1.x: native/src/sslcontext.c xdocs/miscellaneous/changelog.xml

2014-04-09 Thread Mladen Turk 

On 04/09/2014 02:03 PM, Konstantin Kolinko wrote:

2014-04-09 11:32 GMT+04:00  :

Author: mturk
Date: Wed Apr  9 07:32:29 2014
New Revision: 1585898

URL: http://svn.apache.org/r1585898
Log:
Apply Ognjen's patch for bz55915

Modified:
 tomcat/native/branches/1.1.x/native/src/sslcontext.c
 tomcat/native/branches/1.1.x/xdocs/miscellaneous/changelog.xml

Modified: tomcat/native/branches/1.1.x/native/src/sslcontext.c
URL: 
http://svn.apache.org/viewvc/tomcat/native/branches/1.1.x/native/src/sslcontext.c?rev=1585898&r1=1585897&r2=1585898&view=diff
==
--- tomcat/native/branches/1.1.x/native/src/sslcontext.c (original)
+++ tomcat/native/branches/1.1.x/native/src/sslcontext.c Wed Apr  9 07:32:29 
2014
@@ -151,6 +151,10 @@ TCN_IMPLEMENT_CALL(jlong, SSLContext, ma
 (unsigned long)((sizeof SSL_DEFAULT_VHOST_NAME) - 1),
 &(c->context_id[0]), NULL, EVP_sha1(), NULL);
  if (mode) {


All the following is unconditional?

I wonder whether OpenSSL always has these methods.



Yeah. I have added HAVE_ECS which I'll use for this section in case of 0.9.8x 
is used

Regards
--
^TM

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 56374] Page in wrong language - getting lower rank Accept-Language in request header

2014-04-09 Thread bugzilla 
https://issues.apache.org/bugzilla/show_bug.cgi?id=56374

--- Comment #7 from Steve Root  ---
Good question; On Debian 7 (wheezy) I used:
# apt-get install tomcat7 tomcat7-admin
and I got
Apache Tomcat/7.0.28

I'll go create a new server and try it on 7.0.53 and report back.
Thanks

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 56372] Which API is referenced in comment above public Iterator getFeatureDescriptors in javax.el.ResourceBundleELResolver

2014-04-09 Thread bugzilla 
https://issues.apache.org/bugzilla/show_bug.cgi?id=56372

Mark Thomas  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |INVALID

--- Comment #1 from Mark Thomas  ---
The comment already states that the method declaration must match the
specification which is clearly referring to the EL 2.2 specifcation where the
method signature for javax.el.ResourceBundleELResolver#getFeatureDescriptors()
is:

public java.util.Iterator getFeatureDescriptors(javax.el.ELContext52 context,
java.lang.Object base)

It is not an issue of API breakage but one of specifcation compliance. In order
to pass the TCK the API definitions must match those of the specification
exactly.

This was fixed in the EL 3.0 specification so generics were correctly used in
this case.

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: JDK 9 build 06 is available on java.net

2014-04-09 Thread Mark Thomas 
On 09/04/2014 05:59, Mark Thomas wrote:
> On 09/04/2014 05:14, Rory O'Donnell Oracle, Dublin ireland wrote:
>> Hi Mark,
>>
>> If you log a bug, send me the incident number, I will follow
>> it up.
> 
> I'll see if I can find the incident number for the bug I already
> reported but I think I deleted the e-mail after 6 or so months of no
> response. If I don't find it, I open a new incident.

Your Report (Review ID: JI-9011609) - UTF-8 decoder fails to handle some
edge cases correctly

I didn't say so in the bug report but I'm happy to walk Oracle through
any of the failing test cases if it isn't clear why any of them are
bugs. Just point them towards the Tomcat dev list.

If you can nudge the right folks into getting this fixed for both Java 7
and Java 8 that would great. I'd be extremely happy to be able to delete
Tomcat's customer UTF-8 decoder.

Mark


> 
> Mark
> 
> 
>>
>> Rgds, Rory
>>
>> On 04/ 9/14 12:00 PM, Mark Thomas wrote:
>>> On 09/04/2014 04:36, Rory O'Donnell Oracle, Dublin ireland wrote:
 Hi Mark,

 I suggest you send an email to core-libs-...@openjdk.java.net
 or log a bug.
>>> I've already filed the bug against Java. As far as I recall I never
>>> received any response  - not unusual in my experience of reporting bugs
>>> with Java. I've pretty much reached the conclusion - after reporting
>>> multiple bugs only to have them completely ignored - that reporting bugs
>>> in Java is a waste of my time.
>>>
>>> I'll try the e-mail route but I have little hope that anything will
>>> actually come of it.
>>>
>>> Mark
>>>
>>>
 Rgds, Rory

 On 04/ 8/14 12:49 PM, Mark Thomas wrote:
> On 08/04/2014 02:25, Rory O'Donnell Oracle, Dublin Ireland wrote:
>> Hi Mladen,
>>
>> JDK 9 Build 06 Early Access Build is now available for download
>>  & test.
>>
>> Rgds, Rory
>>
> Rory,
>
> Java 8 (and I am guessing Java 9) still has issues with UTF-8 decoding.
>
> For the latest status, see the Tomcat 8 unit tests for Java 8 decoding
> [1]. If you look at the change history you'll see how things improved
> between Java 7 and Java 8. It should be obvious what the problems are
> from that unit test but ask of the Tomcat dev list if things aren't
> clear.
>
>
> Mark
>
>
> [1]
> http://svn.apache.org/viewvc/tomcat/trunk/test/org/apache/tomcat/util/buf/TestUtf8.java?view=annotate
>
>
>
>>>
>>> -
>>> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
>>> For additional commands, e-mail: dev-h...@tomcat.apache.org
>>>
>>
> 
> 
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
> 


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[jira] [Commented] (MTOMCAT-266) The attribute crashes Tomcat on startup

2014-04-09 Thread *$^¨%`£ 

[ 
https://issues.apache.org/jira/browse/MTOMCAT-266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13964081#comment-13964081
 ] 

Olivier Lamy (*$^¨%`£) commented on MTOMCAT-266:


Are you using maven 3.1+ ?
If yes it's an issue with maven when running shutdownhook. BTW your build is 
success


> The  attribute crashes Tomcat on startup
> --
>
> Key: MTOMCAT-266
> URL: https://issues.apache.org/jira/browse/MTOMCAT-266
> Project: Apache Tomcat Maven Plugin
>  Issue Type: Bug
>  Components: tomcat7
>Affects Versions: 2.2
> Environment: Windows 8.1, Java 1.7.0_51 and Maven 3.2.1
>Reporter: M. R.
>Assignee: Olivier Lamy (*$^¨%`£)
>Priority: Minor
> Attachments: tomcat-plugin-crash.txt
>
>
> The plugin works perfectly running Tomcat with my project web application.
> I do "mvn tomcat7:run" and the server is started, the webapp is deployed and 
> I can browse to it.
> If I add the  attribute, though, the server crashes.
> Here's (a portion of) my pom:
> 
> org.apache.tomcat.maven
> tomcat7-maven-plugin
> 2.2
> 
> localhost
> 8080
> /
> UTF-8
> 
> 
> (I'll add the stacktrace later)



--
This message was sent by Atlassian JIRA
(v6.2#6252)

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 56374] Page in wrong language - getting lower rank Accept-Language in request header

2014-04-09 Thread bugzilla 
https://issues.apache.org/bugzilla/show_bug.cgi?id=56374

--- Comment #6 from Konstantin Kolinko  ---
> A fresh install of Tomcat7 on Debian.

Last time when I was looking, a "fresh" Tomcat on Debian was actually X years
old, where X was ~2 or 3.

1. What exactly x.y.z version are you using?
2. Is it reproducible with 7.0.53?

https://wiki.apache.org/tomcat/FAQ/Linux_Unix#Q5

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: svn commit: r1585898 - in /tomcat/native/branches/1.1.x: native/src/sslcontext.c xdocs/miscellaneous/changelog.xml

2014-04-09 Thread Konstantin Kolinko 
2014-04-09 11:32 GMT+04:00  :
> Author: mturk
> Date: Wed Apr  9 07:32:29 2014
> New Revision: 1585898
>
> URL: http://svn.apache.org/r1585898
> Log:
> Apply Ognjen's patch for bz55915
>
> Modified:
> tomcat/native/branches/1.1.x/native/src/sslcontext.c
> tomcat/native/branches/1.1.x/xdocs/miscellaneous/changelog.xml
>
> Modified: tomcat/native/branches/1.1.x/native/src/sslcontext.c
> URL: 
> http://svn.apache.org/viewvc/tomcat/native/branches/1.1.x/native/src/sslcontext.c?rev=1585898&r1=1585897&r2=1585898&view=diff
> ==
> --- tomcat/native/branches/1.1.x/native/src/sslcontext.c (original)
> +++ tomcat/native/branches/1.1.x/native/src/sslcontext.c Wed Apr  9 07:32:29 
> 2014
> @@ -151,6 +151,10 @@ TCN_IMPLEMENT_CALL(jlong, SSLContext, ma
> (unsigned long)((sizeof SSL_DEFAULT_VHOST_NAME) - 1),
> &(c->context_id[0]), NULL, EVP_sha1(), NULL);
>  if (mode) {

All the following is unconditional?

I wonder whether OpenSSL always has these methods.

> +/* Set default (nistp256) elliptic curve for ephemeral ECDH keys */
> +EC_KEY *ecdh = EC_KEY_new_by_curve_name(NID_X9_62_prime256v1);
> +SSL_CTX_set_tmp_ecdh(c->ctx, ecdh);
> +EC_KEY_free(ecdh);
>  SSL_CTX_set_tmp_rsa_callback(c->ctx, SSL_callback_tmp_RSA);
>  SSL_CTX_set_tmp_dh_callback(c->ctx,  SSL_callback_tmp_DH);
>  }
>


Best regards,
Konstantin Kolinko

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 56373] CompilerOptions.VERSION_1_8 only makes sense when running java8

2014-04-09 Thread bugzilla 
https://issues.apache.org/bugzilla/show_bug.cgi?id=56373

Mark Thomas  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |INVALID

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: JDK 9 build 06 is available on java.net

2014-04-09 Thread Mark Thomas 
On 09/04/2014 05:14, Rory O'Donnell Oracle, Dublin ireland wrote:
> Hi Mark,
> 
> If you log a bug, send me the incident number, I will follow
> it up.

I'll see if I can find the incident number for the bug I already
reported but I think I deleted the e-mail after 6 or so months of no
response. If I don't find it, I open a new incident.

Mark


> 
> Rgds, Rory
> 
> On 04/ 9/14 12:00 PM, Mark Thomas wrote:
>> On 09/04/2014 04:36, Rory O'Donnell Oracle, Dublin ireland wrote:
>>> Hi Mark,
>>>
>>> I suggest you send an email to core-libs-...@openjdk.java.net
>>> or log a bug.
>> I've already filed the bug against Java. As far as I recall I never
>> received any response  - not unusual in my experience of reporting bugs
>> with Java. I've pretty much reached the conclusion - after reporting
>> multiple bugs only to have them completely ignored - that reporting bugs
>> in Java is a waste of my time.
>>
>> I'll try the e-mail route but I have little hope that anything will
>> actually come of it.
>>
>> Mark
>>
>>
>>> Rgds, Rory
>>>
>>> On 04/ 8/14 12:49 PM, Mark Thomas wrote:
 On 08/04/2014 02:25, Rory O'Donnell Oracle, Dublin Ireland wrote:
> Hi Mladen,
>
> JDK 9 Build 06 Early Access Build is now available for download
>  & test.
>
> Rgds, Rory
>
 Rory,

 Java 8 (and I am guessing Java 9) still has issues with UTF-8 decoding.

 For the latest status, see the Tomcat 8 unit tests for Java 8 decoding
 [1]. If you look at the change history you'll see how things improved
 between Java 7 and Java 8. It should be obvious what the problems are
 from that unit test but ask of the Tomcat dev list if things aren't
 clear.


 Mark


 [1]
 http://svn.apache.org/viewvc/tomcat/trunk/test/org/apache/tomcat/util/buf/TestUtf8.java?view=annotate



>>
>> -
>> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
>> For additional commands, e-mail: dev-h...@tomcat.apache.org
>>
> 


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 56374] Page in wrong language - getting lower rank Accept-Language in request header

2014-04-09 Thread bugzilla 
https://issues.apache.org/bugzilla/show_bug.cgi?id=56374

Steve Root  changed:

   What|Removed |Added

Summary|Page in wrong language -|Page in wrong language -
   |getting lowest rank |getting lower rank
   |Accept-Language in request  |Accept-Language in request
   |header  |header
 OS||All

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 56374] Page in wrong language - getting lowest rank Accept-Language in request header

2014-04-09 Thread bugzilla 
https://issues.apache.org/bugzilla/show_bug.cgi?id=56374

--- Comment #5 from Steve Root  ---
Created attachment 31497
  --> https://issues.apache.org/bugzilla/attachment.cgi?id=31497&action=edit
EN-FR-ES_getES screenshot showing header request and result page

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 56374] Page in wrong language - getting lowest rank Accept-Language in request header

2014-04-09 Thread bugzilla 
https://issues.apache.org/bugzilla/show_bug.cgi?id=56374

--- Comment #4 from Steve Root  ---
Created attachment 31496
  --> https://issues.apache.org/bugzilla/attachment.cgi?id=31496&action=edit
EN-FR_getFR screenshot showing header request and result page

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 56374] Page in wrong language - getting lowest rank Accept-Language in request header

2014-04-09 Thread bugzilla 
https://issues.apache.org/bugzilla/show_bug.cgi?id=56374

--- Comment #3 from Steve Root  ---
Created attachment 31495
  --> https://issues.apache.org/bugzilla/attachment.cgi?id=31495&action=edit
EN-ES-FR_getES screenshot showing header request and result page

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 56374] Page in wrong language - getting lowest rank Accept-Language in request header

2014-04-09 Thread bugzilla 
https://issues.apache.org/bugzilla/show_bug.cgi?id=56374

--- Comment #2 from Steve Root  ---
Created attachment 31494
  --> https://issues.apache.org/bugzilla/attachment.cgi?id=31494&action=edit
EN-ES_getES screenshot showing header request and result page

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 56374] Page in wrong language - getting lowest rank Accept-Language in request header

2014-04-09 Thread bugzilla 
https://issues.apache.org/bugzilla/show_bug.cgi?id=56374

Steve Root  changed:

   What|Removed |Added

  Attachment #31493|screenshot showing header   |EN_getEN screenshot showing
description|request and result page |header request and result
   ||page

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 56374] Page in wrong language - getting lowest rank Accept-Language in request header

2014-04-09 Thread bugzilla 
https://issues.apache.org/bugzilla/show_bug.cgi?id=56374

--- Comment #1 from Steve Root  ---
Created attachment 31493
  --> https://issues.apache.org/bugzilla/attachment.cgi?id=31493&action=edit
screenshot showing header request and result page

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 56374] New: Page in wrong language - getting lowest rank Accept-Language in request header

2014-04-09 Thread bugzilla 
https://issues.apache.org/bugzilla/show_bug.cgi?id=56374

Bug ID: 56374
   Summary: Page in wrong language - getting lowest rank
Accept-Language in request header
   Product: Tomcat 7
   Version: unspecified
  Hardware: Macintosh
Status: NEW
  Severity: normal
  Priority: P2
 Component: Manager
  Assignee: dev@tomcat.apache.org
  Reporter: st...@rkbb.co.uk

Created attachment 31492
  --> https://issues.apache.org/bugzilla/attachment.cgi?id=31492&action=edit
Language preference showing EN-FR-ES test

A fresh install of Tomcat7 on Debian.
going to: http://mysever.com:8080/manager/html/ , after logging in, I get the
page in French rather than English.

Investigating further, my browser (Chrome)is set to accept multiple languages
in order of priority and this is confirmed when I checked the header request:

Chrome:
Accept-Language:en-GB,en;q=0.8,en-US;q=0.6,fr;q=0.4

When I visited the page using Firefox, I got the page in English.
Firefox:
Accept-Language:"en-us,en;q=0.5"
See EN_getEN.png

When I add FR to firefox as a lower priority language, I get: FR
Firefox:
Accept-Language:"en-us,en;q=0.7,fr;q=0.3"
See EN-FR_getFR.png

To test further, I started adding spanish.

When I add ES to firefox as a lower priority language, I get: ES
Firefox:
Accept-Language:"en-us,en;q=0.7,es;q=0.3"
See EN-ES_getES.png

When I add FR then ES (with ES as lowest priority language), I get: ES
Firefox:
Accept-Language:"en-us,en;q=0.8,fr;q=0.5,es;q=0.3"
See EN-FR-ES_getES.png

And just when it looked like the server was sending the lowest priority
language, I add ES then FR (with FR as lowest prioity language, I get: ES!!
Firefox:
Accept-Language:"en-us,en;q=0.8,es;q=0.5,fr;q=0.3"
See EN-ES-FR_getES.png

I've a screen shots showing each request and the resulting page, I'll add them
to this bug report in a moment.

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 56373] New: CompilerOptions.VERSION_1_8 only makes sense when running java8

2014-04-09 Thread bugzilla 
https://issues.apache.org/bugzilla/show_bug.cgi?id=56373

Bug ID: 56373
   Summary: CompilerOptions.VERSION_1_8 only makes sense when
running java8
   Product: Tomcat 7
   Version: trunk
  Hardware: PC
OS: Linux
Status: NEW
  Severity: normal
  Priority: P2
 Component: Jasper
  Assignee: dev@tomcat.apache.org
  Reporter: christian.ska...@met.no

Created attachment 31491
  --> https://issues.apache.org/bugzilla/attachment.cgi?id=31491&action=edit
Patch to http://svn.apache.org/repos/asf/tomcat/tc7.0.x/trunk

See https://issues.apache.org/bugzilla/show_bug.cgi?id=56283#c3
I propose using the same solution for tomcat7 as implemented in tomcat6, that
is to use the string "1.8" instead of CompilerOptions.VERSION_1_8.

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: JDK 9 build 06 is available on java.net

2014-04-09 Thread Rory O'Donnell Oracle, Dublin ireland 

Thanks Henri!
On 04/ 8/14 01:22 PM, Henri Gomez wrote:
OpenJDK 8 and 9 have also their continuous build via Obuildfactory 
(https://github.com/hgomez/obuildfactory) and hosted in Bintray for 
many Linux flavor ie :


* http://dl.bintray.com/hgomez/obuildfactory-fedora18-x86-64/
* http://dl.bintray.com/hgomez/obuildfactory-opensuse122-i386/
* http://dl.bintray.com/hgomez/obuildfactory-centos6-i386/

:)



2014-04-08 13:49 GMT+02:00 Mark Thomas >:


On 08/04/2014 02:25, Rory O'Donnell Oracle, Dublin Ireland wrote:
> Hi Mladen,
>
> JDK 9 Build 06 Early Access Build is now available for download
>  & test.
>
> Rgds, Rory
>

Rory,

Java 8 (and I am guessing Java 9) still has issues with UTF-8
decoding.

For the latest status, see the Tomcat 8 unit tests for Java 8 decoding
[1]. If you look at the change history you'll see how things improved
between Java 7 and Java 8. It should be obvious what the problems are
from that unit test but ask of the Tomcat dev list if things
aren't clear.


Mark


[1]

http://svn.apache.org/viewvc/tomcat/trunk/test/org/apache/tomcat/util/buf/TestUtf8.java?view=annotate


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org

For additional commands, e-mail: dev-h...@tomcat.apache.org





--
Rgds,
Rory O'Donnell

Senior Quality Engineering Manager
Java Platform Group
Oracle EMEA , Block P5,
East Point Business Park, Dublin 3
Phone: +353 (0)1 8033887

Re: JDK 9 build 06 is available on java.net

2014-04-09 Thread Rory O'Donnell Oracle, Dublin ireland 

Hi Mark,

If you log a bug, send me the incident number, I will follow
it up.

Rgds, Rory

On 04/ 9/14 12:00 PM, Mark Thomas wrote:

On 09/04/2014 04:36, Rory O'Donnell Oracle, Dublin ireland wrote:

Hi Mark,

I suggest you send an email to core-libs-...@openjdk.java.net
or log a bug.

I've already filed the bug against Java. As far as I recall I never
received any response  - not unusual in my experience of reporting bugs
with Java. I've pretty much reached the conclusion - after reporting
multiple bugs only to have them completely ignored - that reporting bugs
in Java is a waste of my time.

I'll try the e-mail route but I have little hope that anything will
actually come of it.

Mark



Rgds, Rory

On 04/ 8/14 12:49 PM, Mark Thomas wrote:

On 08/04/2014 02:25, Rory O'Donnell Oracle, Dublin Ireland wrote:

Hi Mladen,

JDK 9 Build 06 Early Access Build is now available for download
 & test.

Rgds, Rory


Rory,

Java 8 (and I am guessing Java 9) still has issues with UTF-8 decoding.

For the latest status, see the Tomcat 8 unit tests for Java 8 decoding
[1]. If you look at the change history you'll see how things improved
between Java 7 and Java 8. It should be obvious what the problems are
from that unit test but ask of the Tomcat dev list if things aren't
clear.


Mark


[1]
http://svn.apache.org/viewvc/tomcat/trunk/test/org/apache/tomcat/util/buf/TestUtf8.java?view=annotate




-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



--
Rgds,
Rory O'Donnell

Senior Quality Engineering Manager
Java Platform Group
Oracle EMEA , Block P5,
East Point Business Park, Dublin 3
Phone: +353 (0)1 8033887


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 56372] New: Which API is referenced in comment above public Iterator getFeatureDescriptors in javax.el.ResourceBundleELResolver

2014-04-09 Thread bugzilla 
https://issues.apache.org/bugzilla/show_bug.cgi?id=56372

Bug ID: 56372
   Summary: Which API is referenced in comment above public
Iterator getFeatureDescriptors in
javax.el.ResourceBundleELResolver
   Product: Tomcat 7
   Version: trunk
  Hardware: PC
OS: Linux
Status: NEW
  Severity: normal
  Priority: P2
 Component: Servlet & JSP API
  Assignee: dev@tomcat.apache.org
  Reporter: christian.ska...@met.no

javax.el.ELResolver changed method signature for getFeatureDescriptors in svn
r426537, but javax.el.ResourceBundleELResolver was not updated accordingly.
ResourceBundleELResolver extends ELResolver and does not implement any other
interfaces as far as I can read from the source file.

$ svn log -c 426537

r426537 | remm | 2006-07-28 15:57:53 +0200 (Fri, 28 Jul 2006) | 1 line

- JSP 2.1 API fixes.


Change in javax.el.ELResolver svn r426537, see:
http://svn.apache.org/viewvc/tomcat/trunk/java/javax/el/ELResolver.java?r1=423920&r2=426537&pathrev=884913&diff_format=h

See signature for getFeatureDescriptors in abstract class on line 65:
http://svn.apache.org/viewvc/tomcat/trunk/java/javax/el/ELResolver.java?revision=426537&view=markup&pathrev=884913#l65

See signature for getFeatureDescriptors in subclass on line 97:
http://svn.apache.org/viewvc/tomcat/trunk/java/javax/el/ResourceBundleELResolver.java?revision=426537&view=markup&pathrev=884913#l97





In svn r884913 a comment appeared above getFeatureDescriptors that says "Can't
use Iterator because API needs to match specification":
$ svn log -r 884913

r884913 | markt | 2009-11-27 18:14:16 +0100 (Fri, 27 Nov 2009) | 3 lines

Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=48267
Generics
Patch provided by sebb


Change in javax.el.ResourceBundleELResolver in svn r884913, see:
http://svn.apache.org/viewvc/tomcat/trunk/java/javax/el/ResourceBundleELResolver.java?r1=832955&r2=884913&pathrev=884913&diff_format=h



The latter comment is still present in trunk for tomcat7. I am curious which
API spesification that we try to satisfy in javax.el.ResourceBundleELResolver
as it is different from the implementation in the parent class
javax.el.ELResolver. Could we either update the comment with an url to the API
or some other hint about which API we would break if we return
Iterator instead of Iterator, or simply remove the comment
and align the signature with that in the parent class?

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: JDK 9 build 06 is available on java.net

2014-04-09 Thread Mark Thomas 
On 09/04/2014 04:36, Rory O'Donnell Oracle, Dublin ireland wrote:
> Hi Mark,
> 
> I suggest you send an email to core-libs-...@openjdk.java.net
> or log a bug.

I've already filed the bug against Java. As far as I recall I never
received any response  - not unusual in my experience of reporting bugs
with Java. I've pretty much reached the conclusion - after reporting
multiple bugs only to have them completely ignored - that reporting bugs
in Java is a waste of my time.

I'll try the e-mail route but I have little hope that anything will
actually come of it.

Mark


> 
> Rgds, Rory
> 
> On 04/ 8/14 12:49 PM, Mark Thomas wrote:
>> On 08/04/2014 02:25, Rory O'Donnell Oracle, Dublin Ireland wrote:
>>> Hi Mladen,
>>>
>>> JDK 9 Build 06 Early Access Build is now available for download
>>>  & test.
>>>
>>> Rgds, Rory
>>>
>> Rory,
>>
>> Java 8 (and I am guessing Java 9) still has issues with UTF-8 decoding.
>>
>> For the latest status, see the Tomcat 8 unit tests for Java 8 decoding
>> [1]. If you look at the change history you'll see how things improved
>> between Java 7 and Java 8. It should be obvious what the problems are
>> from that unit test but ask of the Tomcat dev list if things aren't
>> clear.
>>
>>
>> Mark
>>
>>
>> [1]
>> http://svn.apache.org/viewvc/tomcat/trunk/test/org/apache/tomcat/util/buf/TestUtf8.java?view=annotate
>>
>>
> 


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: JDK 9 build 06 is available on java.net

2014-04-09 Thread Rory O'Donnell Oracle, Dublin ireland 

Hi Mark,

I suggest you send an email to core-libs-...@openjdk.java.net
or log a bug.

Rgds, Rory

On 04/ 8/14 12:49 PM, Mark Thomas wrote:

On 08/04/2014 02:25, Rory O'Donnell Oracle, Dublin Ireland wrote:

Hi Mladen,

JDK 9 Build 06 Early Access Build is now available for download
 & test.

Rgds, Rory


Rory,

Java 8 (and I am guessing Java 9) still has issues with UTF-8 decoding.

For the latest status, see the Tomcat 8 unit tests for Java 8 decoding
[1]. If you look at the change history you'll see how things improved
between Java 7 and Java 8. It should be obvious what the problems are
from that unit test but ask of the Tomcat dev list if things aren't clear.


Mark


[1]
http://svn.apache.org/viewvc/tomcat/trunk/test/org/apache/tomcat/util/buf/TestUtf8.java?view=annotate



--
Rgds,
Rory O'Donnell

Senior Quality Engineering Manager
Java Platform Group
Oracle EMEA , Block P5,
East Point Business Park, Dublin 3
Phone: +353 (0)1 8033887


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [Bug 55915] Add ECDHE support to tcnative-1.dll

2014-04-09 Thread Mladen Turk 

On 04/09/2014 10:27 AM, Tim Whittington wrote:

Does this need a SSL_CTX_set_options(c->ctx, SSL_OP_SINGLE_ECDH_USE) as well?


Seems it does.
Just committed a code found in mod_ssl.



Regards
--
^TM

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r1585923 - in /tomcat/native/branches/1.1.x/native: include/ssl_private.h src/sslcontext.c

2014-04-09 Thread mturk 
Author: mturk
Date: Wed Apr  9 09:52:40 2014
New Revision: 1585923

URL: http://svn.apache.org/r1585923
Log:
As per Tom's suggestion. Set SSL_OP_SINGLE_ECDH_USE to context

Modified:
tomcat/native/branches/1.1.x/native/include/ssl_private.h
tomcat/native/branches/1.1.x/native/src/sslcontext.c

Modified: tomcat/native/branches/1.1.x/native/include/ssl_private.h
URL: 
http://svn.apache.org/viewvc/tomcat/native/branches/1.1.x/native/include/ssl_private.h?rev=1585923&r1=1585922&r2=1585923&view=diff
==
--- tomcat/native/branches/1.1.x/native/include/ssl_private.h (original)
+++ tomcat/native/branches/1.1.x/native/include/ssl_private.h Wed Apr  9 
09:52:40 2014
@@ -40,6 +40,12 @@
 #endif
 
 /* OpenSSL headers */
+/* OpenSSL headers */
+#include 
+#if (OPENSSL_VERSION_NUMBER >= 0x10001000)
+/* must be defined before including ssl.h */
+#define OPENSSL_NO_SSL_INTERN
+#endif
 #include 
 #include 
 #include 
@@ -208,6 +214,11 @@
 #define OCSP_STATUS_UNKNOWN   2
 
 
+/* ECC: make sure we have at least 1.0.0 */
+#if !defined(OPENSSL_NO_EC) && defined(TLSEXT_ECPOINTFORMAT_uncompressed)
+#define HAVE_ECC  1
+#endif
+
 extern void *SSL_temp_keys[SSL_TMP_KEY_MAX];
 
 typedef struct {

Modified: tomcat/native/branches/1.1.x/native/src/sslcontext.c
URL: 
http://svn.apache.org/viewvc/tomcat/native/branches/1.1.x/native/src/sslcontext.c?rev=1585923&r1=1585922&r2=1585923&view=diff
==
--- tomcat/native/branches/1.1.x/native/src/sslcontext.c (original)
+++ tomcat/native/branches/1.1.x/native/src/sslcontext.c Wed Apr  9 09:52:40 
2014
@@ -137,6 +137,9 @@ TCN_IMPLEMENT_CALL(jlong, SSLContext, ma
  * Configure additional context ingredients
  */
 SSL_CTX_set_options(c->ctx, SSL_OP_SINGLE_DH_USE);
+#ifdef HAVE_ECC
+SSL_CTX_set_options(c->ctx, SSL_OP_SINGLE_ECDH_USE);
+#endif
 
 #ifdef SSL_OP_NO_SESSION_RESUMPTION_ON_RENEGOTIATION
 /*



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r1585903 - /tomcat/native/branches/1.1.x/native/srclib/VERSIONS

2014-04-09 Thread mturk 
Author: mturk
Date: Wed Apr  9 08:31:42 2014
New Revision: 1585903

URL: http://svn.apache.org/r1585903
Log:
Update OpenSSL version

Modified:
tomcat/native/branches/1.1.x/native/srclib/VERSIONS

Modified: tomcat/native/branches/1.1.x/native/srclib/VERSIONS
URL: 
http://svn.apache.org/viewvc/tomcat/native/branches/1.1.x/native/srclib/VERSIONS?rev=1585903&r1=1585902&r2=1585903&view=diff
==
--- tomcat/native/branches/1.1.x/native/srclib/VERSIONS (original)
+++ tomcat/native/branches/1.1.x/native/srclib/VERSIONS Wed Apr  9 08:31:42 2014
@@ -1,4 +1,4 @@
 Use the following version of the libraries
 
 - APR 1.4.8, http://apr.apache.org
-- OpenSSL 1.0.1e, http://www.openssl.org
+- OpenSSL 1.0.1g, http://www.openssl.org



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [Bug 55915] Add ECDHE support to tcnative-1.dll

2014-04-09 Thread Tim Whittington 
Does this need a SSL_CTX_set_options(c->ctx, SSL_OP_SINGLE_ECDH_USE) as well?
The API docs are pretty sparse, but it looks like mod_ssl does this (as well as 
nginx etc.)

The description in ssl.h is “If set, always create a new key when using 
tmp_ecdh parameters”

Reading the docs for the equivalent DH option [1], it seems like this switches 
behaviour between single key generation on startup (which persists for the life 
of the process) and each session getting a new key generated from the 
parameters.
A quick source dive seems to confirm this behaviour (for DH and ECDH).

ECDH key gen should be pretty quick, and even though both behaviours are 
technically ephemeral, the SINGLE_ECDH_USE approach seems more conservative 
(and consistent with how we handle DHE now).

cheers
tim

[1] https://www.openssl.org/docs/ssl/SSL_CTX_set_tmp_dh_callback.html#NOTES


On 9/04/2014, at 7:36 pm, bugzi...@apache.org wrote:

> https://issues.apache.org/bugzilla/show_bug.cgi?id=55915
> 
> Mladen Turk  changed:
> 
>   What|Removed |Added
> 
> Status|NEW |RESOLVED
> Resolution|--- |FIXED
> 
> --- Comment #4 from Mladen Turk  ---
> Patch applied.
> Resolving, but will need to verify the functionality.
> 
> -- 
> You are receiving this mail because:
> You are the assignee for the bug.
> 
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
> 


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: Tagging JK 1.2.40

2014-04-09 Thread Tim Whittington 

On 8/04/2014, at 11:56 pm, Konstantin Kolinko  wrote:

> 2014-04-08 11:56 GMT+04:00 Mladen Turk :
>> Hi,
>> 
>> I plan to tag JK 1.2.40 pretty soon (probably end of this week)
>> We have few bugs in the latest release which requires a new version.
> 
> +1
> 
> There is also a need for a tc-native build, due to security issue in OpenSSL
> https://issues.apache.org/bugzilla/show_bug.cgi?id=56363
> 

On that subject, does anyone have a HOWTO to get a tcnative build working?

I’ve tried with and RHEL 6 and CentOS 6 (cmake is missing  
/usr/share/cmake/Modules/ExternalProject.cmake) and OS X Mavericks (downloaded 
apr is trying to include apr_private.h, which is missing).

(I was actually looking at the ECDHE support - Mladen looks like he’s across 
Heartbleed).

> I cannot test this now, but from reading the FAQ at
> http://heartbleed.com/  there are good chances that the current build
> of TC-Native (and included with windows versions of TC8, TC7 etc) is
> vulnerable.

I think it’s fairly probable given the static linking we do.

cheers
tim


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 55915] Add ECDHE support to tcnative-1.dll

2014-04-09 Thread bugzilla 
https://issues.apache.org/bugzilla/show_bug.cgi?id=55915

Mladen Turk  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

--- Comment #4 from Mladen Turk  ---
Patch applied.
Resolving, but will need to verify the functionality.

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: CVE-2014-0160

2014-04-09 Thread Mladen Turk 

On 04/09/2014 01:43 AM, Andrew Carr wrote:

http://www.openssl.org/news/secadv_20140407.txt

Hi Tomcat Devs,

I have been on the dev list for a few years, and a tomcat developer longer
than that.  While I haven't contributed yet, I was curious if this cve
needs a contribution.  As far as I can tell, if you recompile your native
libs with the unaffected version of SSL, you will not be vulnerable to this
CVE.

Is that assumption correct or does there need to be a change to tcnative?



Assumption is correct.
You may trac https://issues.apache.org/bugzilla/show_bug.cgi?id=56363
for this issue.

Regards
--
^TM

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r1585898 - in /tomcat/native/branches/1.1.x: native/src/sslcontext.c xdocs/miscellaneous/changelog.xml

2014-04-09 Thread mturk 
Author: mturk
Date: Wed Apr  9 07:32:29 2014
New Revision: 1585898

URL: http://svn.apache.org/r1585898
Log:
Apply Ognjen's patch for bz55915

Modified:
tomcat/native/branches/1.1.x/native/src/sslcontext.c
tomcat/native/branches/1.1.x/xdocs/miscellaneous/changelog.xml

Modified: tomcat/native/branches/1.1.x/native/src/sslcontext.c
URL: 
http://svn.apache.org/viewvc/tomcat/native/branches/1.1.x/native/src/sslcontext.c?rev=1585898&r1=1585897&r2=1585898&view=diff
==
--- tomcat/native/branches/1.1.x/native/src/sslcontext.c (original)
+++ tomcat/native/branches/1.1.x/native/src/sslcontext.c Wed Apr  9 07:32:29 
2014
@@ -151,6 +151,10 @@ TCN_IMPLEMENT_CALL(jlong, SSLContext, ma
(unsigned long)((sizeof SSL_DEFAULT_VHOST_NAME) - 1),
&(c->context_id[0]), NULL, EVP_sha1(), NULL);
 if (mode) {
+/* Set default (nistp256) elliptic curve for ephemeral ECDH keys */
+EC_KEY *ecdh = EC_KEY_new_by_curve_name(NID_X9_62_prime256v1);
+SSL_CTX_set_tmp_ecdh(c->ctx, ecdh);
+EC_KEY_free(ecdh);
 SSL_CTX_set_tmp_rsa_callback(c->ctx, SSL_callback_tmp_RSA);
 SSL_CTX_set_tmp_dh_callback(c->ctx,  SSL_callback_tmp_DH);
 }

Modified: tomcat/native/branches/1.1.x/xdocs/miscellaneous/changelog.xml
URL: 
http://svn.apache.org/viewvc/tomcat/native/branches/1.1.x/xdocs/miscellaneous/changelog.xml?rev=1585898&r1=1585897&r2=1585898&view=diff
==
--- tomcat/native/branches/1.1.x/xdocs/miscellaneous/changelog.xml (original)
+++ tomcat/native/branches/1.1.x/xdocs/miscellaneous/changelog.xml Wed Apr  9 
07:32:29 2014
@@ -39,6 +39,9 @@
 
   
 
+  55915: Apply Ognjen's patch for ECDHE support. (mturk)
+
+
   55663: Minor correction to the wording of the NOTICE file
   to align it with the http://www.apache.org/legal/src-headers.html#notice";>requirements



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 55915] Add ECDHE support to tcnative-1.dll

2014-04-09 Thread bugzilla 
https://issues.apache.org/bugzilla/show_bug.cgi?id=55915

--- Comment #3 from Mladen Turk  ---
New versions will be configured at build time using
perl Configure enable-ecdh enable-ec enable-ecdsa ...

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 56363] OpenSSL security advisory - Heartbleed bug

2014-04-09 Thread bugzilla 
https://issues.apache.org/bugzilla/show_bug.cgi?id=56363

--- Comment #1 from Mladen Turk  ---
Working on it.

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 56363] OpenSSL security advisory - Heartbleed bug

2014-04-09 Thread bugzilla 
https://issues.apache.org/bugzilla/show_bug.cgi?id=56363

r.schilpero...@greenvalley.nl changed:

   What|Removed |Added

 CC||r.schilperoort@greenvalley.
   ||nl

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org