[Bug 62371] Improve logging in AbstractProcessor.parseHost()

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=62371

--- Comment #5 from Robert Rettig  ---
This effects version 8.5.31 too, which has much bigger impact to other
projects!

see:
http://svn.apache.org/viewvc/tomcat/tc8.5.x/tags/TOMCAT_8_5_31/java/org/apache/tomcat/util/http/parser/HttpParser.java?r1=1830182=1830188

This validation is a new feature introduced in a minor version change!

Please check if such changes really correspond to your project policies.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 62371] Improve logging in AbstractProcessor.parseHost()

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=62371

Robert Rettig  changed:

   What|Removed |Added

 CC||robert@rettig.bayern

--- Comment #4 from Robert Rettig  ---
Created attachment 35931
  --> https://bz.apache.org/bugzilla/attachment.cgi?id=35931=edit
Fixes hyphen validation

This problem occurs in typical docker deployments, especially docker swarm
deployments where service names contain hyphens.
In Docker Swarm, the service names can be specified with the prefix "tasks.".
to get concrete container addresses through the embedded DNS instead of the
virtual address of the service.
In such environments you can no longer use Tomcat in the embedded version with
Spring Boot.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 50019] Adding JNDI "lookup-name" support In XML and Resource Annotations

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=50019

Mark Thomas  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[GitHub] tomcat issue #108: Improve undeployment in parallel deployment scenario

[markt-asf]

Github user markt-asf commented on the issue:

https://github.com/apache/tomcat/pull/108
  
I agree this should configurable on the Host.
It should be possible to remove the Comparator entirely if the version code 
is used directly in the Mapper.
I'd like this to be more robust. I'm thinking pad any dot-separated segment 
to a given length with a suitable character (possible space).


---

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r1831442 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/coyote/ajp/AjpAprProcessor.java java/org/apache/coyote/ajp/AjpNioProcessor.java java/org/apache/coyote/ajp/AjpProcessor.java webapps

[markt]

Author: markt
Date: Fri May 11 18:44:51 2018
New Revision: 1831442

URL: http://svn.apache.org/viewvc?rev=1831442=rev
Log:
Log an error message if the AJP connector detects the the reverse proxy is 
sending AJP messages that are too large for the configured packetSize.

Modified:
tomcat/tc7.0.x/trunk/   (props changed)
tomcat/tc7.0.x/trunk/java/org/apache/coyote/ajp/AjpAprProcessor.java
tomcat/tc7.0.x/trunk/java/org/apache/coyote/ajp/AjpNioProcessor.java
tomcat/tc7.0.x/trunk/java/org/apache/coyote/ajp/AjpProcessor.java
tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml

Propchange: tomcat/tc7.0.x/trunk/
--
--- svn:mergeinfo (original)
+++ svn:mergeinfo Fri May 11 18:44:51 2018
@@ -1,3 +1,3 @@
-/tomcat/tc8.0.x/trunk:1636525,1637336,1637685,1637709,1638726,1640089,1640276,1640349,1640363,1640366,1640642,1640672,1640674,1640689,1640884,1641001,1641065,1641067,1641375,1641638,1641723,1641726,1641729-1641730,1641736,1641988,1642669-1642670,1642698,1642701,1643205,1643215,1643217,1643230,1643232,1643273,1643285,1643329-1643330,1643511,1643513,1643521,1643539,1643571,1643581-1643582,1643635,1643655,1643738,1643964,1644018,1644333,1644525,1644954,1644992,1645014,1645360,1645456,1645627,1645642,1645686,1645903-1645904,1645908-1645909,1645913,1645920,1646458,1646460-1646462,1646735,1646738-1646741,1646744,1646746,1646748-1646755,1646757,1646759-1646760,1647043,1648816,1651420-1651422,1651844,1652926,1652939-1652940,1652973,1653798,1653817,1653841,1654042,1654161,1654736,1654767,1654787,1656592,1659907,1662986,1663265,1663278,1663325,1663535,1663567,1663679,1663997,1664175,1664321,1664872,1665061,1665086,1666027,1666395,1666503,1666506,1666560,1666570,1666581,1666759,1666967,1666988
 
,1667553-1667555,1667558,1667617,1667633,1667637,1667747,1667767,1667873,1668028,1668137,1668634,1669432,1669801,1669840,1669895-1669896,1670398,1670435,1670592,1670605-1670607,1670609,1670632,1670720,1670725,1670727,1670731,1671114,1672273,1672285,1673759,1674220,1674295,1675469,1675488,1675595,1675831,1676232,1676367-1676369,1676382,1676394,1676483,1676556,1676635,1678178,1679536,1679988,1680256,1681124,1681182,1681703,1681730,1681840,1681864,1681869,1682010,1682034,1682047,1682052-1682053,1682062,1682064,1682070,1682312,1682325,1682331,1682386,1684367,1684385,1685759,1685774,1685827,1685892,1687341,1688904,1689358,1689657,1689921,1692850,1693093,1693108,1693324,1694060,1694115,1694291,1694427,1694431,1694503,1694549,1694789,1694873,1694881,1695356,1695372,1695823-1695825,1696200,1696281,1696379,1696468,1700608,1700871,1700897,1700978,1701094,1701124,1701608,1701668,1701676,1701766,1701944,1702248,1702252,1702314,1702390,1702723,1702725,1702728,1702730,1702733,1702735,1702737,1702
 
739,1702742,1702744,1702748,1702751,1702754,1702758,1702760,1702763,1702766,1708779,1708782,1708806,1709314,1709670,1710347,1710442,1710448,1710490,1710574,1710578,1712226,1712229,1712235,1712255,1712618,1712649,1712655,1712860,1712899,1712903,1712906,1712913,1712926,1712975,1713185,1713262,1713287,1713613,1713621,1713872,1713976,1713994,1713998,1714004,1714013,1714059,1714538,1714580,1715189,1715207,1715544,1715549,1715637,1715639-1715645,1715667,1715683,1715866,1715978,1715981,1716216-1716217,1716355,1716414,1716421,1717208-1717209,1717257,1717283,1717288,1717291,1717421,1717517,1717529,1718797,1718840-1718843,1719348,1719357-1719358,1719400,1719491,1719737,1720235,1720396,1720442,1720446,1720450,1720463,1720658-1720660,1720756,1720816,1721813,1721818,1721831,1721861,1721867,1721882,1722523,1722527,1722800,1722926,1722941,1722997,1723130,1723440,1723488,1723890,1724434,1724674,1724792,1724803,1724902,1725128,1725131,1725154,1725167,1725911,1725921,1725929,1725963-1725965,1725970,1
 
725974,1726171-1726173,1726175,1726179-1726182,1726190-1726191,1726195-1726200,1726203,1726226,1726576,1726630,1726992,1727029,1727037,1727671,1727676,1727900,1728028,1728092,1728439,1728449,1729186,1729362,1731009,1731303,1731867,1731872,1731874,1731876,1731885,1731947,1731955,1731959,1731977,1731984,1732360,1732490,1732672,1732902,1733166,1733603,1733619,1733735,1733752,1733764,1733915,1733941,1733964,1734115,1734133,1734261,1734421,1734531,1736286,1737967,1738173,1738182,1738992,1739039,1739089-1739091,1739294,1739777,1739821,1739981,1740513,1740726,1741019,1741162,1741217,1743647,1743681,1744152,1744272,1746732,1746750,1752739,1754615,1755886,1756018,1758563,1759565,1761686,1762173,1762206,1766280,1767507-1767508,1767653,1767656,1769267,1772949,1773521,1773527,1774104,1777015,1777213,1779330,1783151,1784188,1784966,1785670,1786846,1788260,1788999,1789140,1789402,1791529,1791559,1795291,1796906,1797523,1799214,1800998-1800999,1801003,1801007-1801008,1801017,1801020,1802808,180281
 

svn commit: r1831441 - in /tomcat/tc8.0.x/trunk: ./ java/org/apache/coyote/ajp/AbstractAjpProcessor.java webapps/docs/changelog.xml

[markt]

Author: markt
Date: Fri May 11 18:40:17 2018
New Revision: 1831441

URL: http://svn.apache.org/viewvc?rev=1831441=rev
Log:
Log an error message if the AJP connector detects the the reverse proxy is 
sending AJP messages that are too large for the configured packetSize.

Modified:
tomcat/tc8.0.x/trunk/   (props changed)
tomcat/tc8.0.x/trunk/java/org/apache/coyote/ajp/AbstractAjpProcessor.java
tomcat/tc8.0.x/trunk/webapps/docs/changelog.xml

Propchange: tomcat/tc8.0.x/trunk/
--
--- svn:mergeinfo (original)
+++ svn:mergeinfo Fri May 11 18:40:17 2018
@@ -1,2 +1,2 @@
 
/tomcat/tc8.5.x/trunk:1735042,1737966,1743139-1743140,1744151,1747537,1747925,1748002,1754614,1754643,1762124,1762183,1762203,1763792,1772948,1777014,1779719,1779898,1782037,1782240,1782386-1782387,1785669,1786845,1788249,1788324,1788905,1789216,1789335,1791528,1791558,1796697-1796698,1797521,1798543,1799162,1800143,1801693,1802805,1806799,1807079-1807080,1808880,1809831,1812093,1812143,1812145,1812319,1814975,1815945,1815956,1820207,1822186,1823164,1823497,1824960,1826872-1826873,1827862,1829310,1829777,1829796,1829935,1830215,1830991,1831042
-/tomcat/trunk:1636524,1637156,1637176,1637188,1637331,1637684,1637695,1637890,1637892,1638720-1638725,1639653,1640010,1640083-1640084,1640088,1640275,1640322,1640347,1640361,1640365,1640403,1640410,1640652,1640655-1640658,1640688,1640700-1640883,1640903,1640976,1640978,1641000,1641026,1641038-1641039,1641051-1641052,1641058,1641064,1641300,1641369,1641374,1641380,1641486,1641634,1641656-1641692,1641704,1641707-1641718,1641720-1641722,1641735,1641981,1642233,1642280,1642554,1642564,1642595,1642606,1642668,1642679,1642697,1642699,1642766,1643002,1643045,1643054-1643055,1643066,1643121,1643128,1643206,1643209-1643210,1643216,1643249,1643270,1643283,1643309-1643310,1643323,1643365-1643366,1643370-1643371,1643465,1643474,1643536,1643570,1643634,1643649,1643651,1643654,1643675,1643731,1643733-1643734,1643761,1643766,1643814,1643937,1643963,1644017,1644169,1644201-1644203,1644321,1644323,1644516,1644523,1644529,1644535,1644730,1644768,1644784-1644785,1644790,1644793,1644815,1644884,1644886
 
,1644890,1644892,1644910,1644924,1644929-1644930,1644935,1644989,1645011,1645247,1645355,1645357-1645358,1645455,1645465,1645469,1645471,1645473,1645475,1645486-1645488,1645626,1645641,1645685,1645743,1645763,1645951-1645953,1645955,1645993,1646098-1646106,1646178,1646220,1646302,1646304,1646420,1646470-1646471,1646476,1646559,1646717-1646723,1646773,1647026,1647042,1647530,1647655,1648304,1648815,1648907,1649973,1650081,1650365,1651116,1651120,1651280,1651470,1652938,1652970,1653041,1653471,1653550,1653574,1653797,1653815-1653816,1653819,1653840,1653857,1653888,1653972,1654013,1654030,1654050,1654123,1654148,1654159,1654513,1654515,1654517,1654522,1654524,1654725,1654735,1654766,1654785,1654851-1654852,1654978,1655122-1655124,1655126-1655127,1655129-1655130,1655132-1655133,1655312,1655351,1655438,1655441,1655454,168,1656087,1656299,1656319,1656331,1656345,1656350,1656590,1656648-1656650,1656657,1657041,1657054,1657374,1657492,1657510,1657565,1657580,1657584,1657586,1657589,1657
 
592,1657607,1657609,1657682,1657907,1658207,1658734,1658781,1658790,1658799,1658802,1658804,1658833,1658840,1658966,1659043,1659053,1659059,1659174,1659184,1659188-1659189,1659216,1659263,1659293,1659304,1659306-1659307,1659382,1659384,1659428,1659471,1659486,1659505,1659516,1659521,1659524,1659559,1659562,1659803,1659806,1659814,1659833,1659862,1659905,1659919,1659948,1659967,1659983-1659984,1660060,1660074,1660077,1660133,1660168,1660331-1660332,1660353,1660358,1660924,1661386,1661770,1661867,1661972,1661990,1662200,1662308-1662309,1662548,1662614,1662696,1662736,1662985,1662988-1662989,1663264,1663277,1663298,1663534,1663562,1663676,1663715,1663754,1663768,1663772,1663781,1663893,1663995,1664143,1664163,1664174,1664301,1664317,1664347,1664657,1664659,1664710,1664863-1664864,1664866,1665085,1665292,1665559,1665653,1665661,1665672,1665694,1665697,1665736,1665779,1665976-1665977,1665980-1665981,1665985-1665986,1665989,1665998,1666004,1666008,1666013,1666017,1666024,1666116,1666386-1
 

svn commit: r1831440 - in /tomcat/tc8.5.x/trunk: ./ java/org/apache/coyote/ajp/AjpProcessor.java webapps/docs/changelog.xml

[markt]

Author: markt
Date: Fri May 11 18:36:41 2018
New Revision: 1831440

URL: http://svn.apache.org/viewvc?rev=1831440=rev
Log:
Log an error message if the AJP connector detects the the reverse proxy is 
sending AJP messages that are too large for the configured packetSize.

Modified:
tomcat/tc8.5.x/trunk/   (props changed)
tomcat/tc8.5.x/trunk/java/org/apache/coyote/ajp/AjpProcessor.java
tomcat/tc8.5.x/trunk/webapps/docs/changelog.xml

Propchange: tomcat/tc8.5.x/trunk/
--
--- svn:mergeinfo (original)
+++ svn:mergeinfo Fri May 11 18:36:41 2018
@@ -1,2 +1,2 @@
 /tomcat/tc8.0.x/trunk:1809644
-/tomcat/trunk:1734785,1734799,1734845,1734928,1735041,1735044,1735480,1735577,1735597,1735599-1735600,1735615,1736145,1736162,1736209,1736280,1736297,1736299,1736489,1736646,1736703,1736836,1736849,1737104-1737105,1737112,1737117,1737119-1737120,1737155,1737157,1737192,1737280,1737339,1737632,1737664,1737715,1737748,1737785,1737834,1737860,1737903,1737959,1738005,1738007,1738014-1738015,1738018,1738022,1738039,1738043,1738059-1738060,1738147,1738149,1738174-1738175,1738261,1738589,1738623-1738625,1738643,1738816,1738850,1738855,1738946-1738948,1738953-1738954,1738979,1738982,1739079-1739081,1739087,1739113,1739153,1739172,1739176,1739191,1739474,1739492,1739726,1739762,1739775,1739814,1739817-1739818,1739975,1740131,1740324,1740465,1740495,1740508-1740509,1740520,1740535,1740707,1740803,1740810,1740969,1740980,1740991,1740997,1741015,1741033,1741036,1741058,1741060,1741080,1741147,1741159,1741164,1741173,1741181,1741190,1741197,1741202,1741208,1741213,1741221,1741225,1741232,1741409
 
,1741501,1741677,1741892,1741896,1741984,1742023,1742042,1742071,1742090,1742093,1742101,1742105,1742111,1742139,1742146,1742148,1742166,1742181,1742184,1742187,1742246,1742248-1742251,1742263-1742264,1742268,1742276,1742369,1742387,1742448,1742509-1742512,1742917,1742919,1742933,1742975-1742976,1742984,1742986,1743019,1743115,1743117,1743124-1743125,1743134,1743425,1743554,1743679,1743696-1743698,1743700-1743701,1744058,1744064-1744065,1744125,1744149,1744194,1744229,1744270,1744323,1744432,1744684,1744697,1744705,1744713,1744760,1744786,1745083,1745142-1745143,1745145,1745177,1745179-1745180,1745227,1745248,1745254,1745337,1745467,1745473,1745535,1745576,1745735,1745744,1746304,1746306-1746307,1746319,1746327,1746338,1746340-1746341,1746344,1746427,1746441,1746473,1746490,1746492,1746495-1746496,1746499-1746501,1746503-1746507,1746509,1746549,1746551,1746554,1746556,1746558,1746584,1746620,1746649,1746724,1746939,1746989,1747014,1747028,1747035,1747210,1747225,1747234,1747253,1747
 
404,1747506,1747536,1747924,1747980,1747993,1748001,1748253,1748452,1748547,1748629,1748676,1748715,1749287,1749296,1749328,1749373,1749465,1749506,1749508,1749665-1749666,1749763,1749865-1749866,1749898,1749978,1749980,1750011,1750015,1750056,1750480,1750617,1750634,1750692,1750697,1750700,1750703,1750707,1750714,1750718,1750723,1750774,1750899,1750975,1750995,1751061,1751097,1751173,1751438,1751447,1751463,1751702,1752212,1752737,1752745,1753078,1753080,1753358,1753363,1754111,1754140-1754141,1754281,1754310,1754445,1754467,1754494,1754496,1754528,1754532-1754533,1754613,1754714,1754874,1754941,1754944,1754950-1754951,1755005,1755007,1755009,1755132,1755180-1755181,1755185,1755190,1755204-1755206,1755208,1755214,1755224,1755227,1755230,1755629,1755646-1755647,1755650,1755653,1755675,1755680,1755683,1755693,1755717,1755731-1755737,1755812,1755828,1755884,1755890,1755918-1755919,1755942,1755958,1755960,1755970,1755993,1756013,1756019,1756039,1756056,1756083-1756114,1756175,1756288-1
 
756289,1756408-1756410,1756778,1756798,1756878,1756898,1756939,1757123-1757124,1757126,1757128,1757132-1757133,1757136,1757145,1757167-1757168,1757175,1757180,1757182,1757195,1757271,1757278,1757347,1757353-1757354,1757363,1757374,1757399,1757406,1757408,1757485,1757495,1757499,1757527,1757578,1757684,1757722,1757727,1757790,1757799,1757813,1757853,1757883,1757903,1757976,1757997,1758000,1758058,1758072-1758075,1758078-1758079,1758223,1758257,1758261,1758276,1758292,1758369,1758378-1758383,1758421,1758423,1758425-1758427,1758430,1758443,1758448,1758459,1758483,1758486-1758487,1758499,1758525,1758556,1758580,1758582,1758584,1758588,1758842,1759019,1759212,1759224,1759227,1759252,1759274,1759513-1759516,1759611,1759757,1759785-1759790,1760005,1760022,1760109-1760110,1760135,1760200-1760201,1760227,1760300,1760397,1760446,1760454,1760640,1760648,1761057,1761422,1761491,1761498,1761500-1761501,1761550,1761553,1761572,1761574,1761625-1761626,1761628,1761682,1761740,1761752,1762051-176205
 

svn commit: r1831439 - in /tomcat/trunk: java/org/apache/coyote/ajp/AjpProcessor.java webapps/docs/changelog.xml

[markt]

Author: markt
Date: Fri May 11 18:36:15 2018
New Revision: 1831439

URL: http://svn.apache.org/viewvc?rev=1831439=rev
Log:
Log an error message if the AJP connector detects the the reverse proxy is 
sending AJP messages that are too large for the configured packetSize.

Modified:
tomcat/trunk/java/org/apache/coyote/ajp/AjpProcessor.java
tomcat/trunk/webapps/docs/changelog.xml

Modified: tomcat/trunk/java/org/apache/coyote/ajp/AjpProcessor.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/coyote/ajp/AjpProcessor.java?rev=1831439=1831438=1831439=diff
==
--- tomcat/trunk/java/org/apache/coyote/ajp/AjpProcessor.java (original)
+++ tomcat/trunk/java/org/apache/coyote/ajp/AjpProcessor.java Fri May 11 
18:36:15 2018
@@ -547,10 +547,10 @@ public class AjpProcessor extends Abstra
 if (messageLength > message.getBuffer().length) {
 // Message too long for the buffer
 // Need to trigger a 400 response
-throw new IllegalArgumentException(sm.getString(
-"ajpprocessor.header.tooLong",
-Integer.valueOf(messageLength),
-Integer.valueOf(buf.length)));
+String msg = sm.getString("ajpprocessor.header.tooLong",
+Integer.valueOf(messageLength), 
Integer.valueOf(buf.length));
+log.error(msg);
+throw new IllegalArgumentException(msg);
 }
 read(buf, Constants.H_SIZE, messageLength, true);
 return true;

Modified: tomcat/trunk/webapps/docs/changelog.xml
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/changelog.xml?rev=1831439=1831438=1831439=diff
==
--- tomcat/trunk/webapps/docs/changelog.xml (original)
+++ tomcat/trunk/webapps/docs/changelog.xml Fri May 11 18:36:15 2018
@@ -100,6 +100,11 @@
   
 Followup sync fix for NIO2 async IO blocking read/writes. (remm)
   
+  
+Log an error message if the AJP connector detects the the reverse proxy
+is sending AJP messages that are too large for the configured
+packetSize. (markt)
+  
 
   
   



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r1831432 - in /tomcat/trunk: java/org/apache/catalina/realm/ test/org/apache/tomcat/util/http/parser/ webapps/docs/ webapps/docs/config/

[markt]

Author: markt
Date: Fri May 11 16:39:43 2018
New Revision: 1831432

URL: http://svn.apache.org/viewvc?rev=1831432=rev
Log:
Add the AuthenticatedUserRealm for use with CLIENT-CERT and SPNEGO when just 
the authenticated user name is required.

Added:
tomcat/trunk/java/org/apache/catalina/realm/AuthenticatedUserRealm.java   
(with props)
Modified:
tomcat/trunk/test/org/apache/tomcat/util/http/parser/TestHttpParserHost.java
tomcat/trunk/webapps/docs/changelog.xml
tomcat/trunk/webapps/docs/config/realm.xml
tomcat/trunk/webapps/docs/windows-auth-howto.xml

Added: tomcat/trunk/java/org/apache/catalina/realm/AuthenticatedUserRealm.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/realm/AuthenticatedUserRealm.java?rev=1831432=auto
==
--- tomcat/trunk/java/org/apache/catalina/realm/AuthenticatedUserRealm.java 
(added)
+++ tomcat/trunk/java/org/apache/catalina/realm/AuthenticatedUserRealm.java Fri 
May 11 16:39:43 2018
@@ -0,0 +1,46 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *  http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.catalina.realm;
+
+import java.security.Principal;
+
+/**
+ * This Realm is intended for use with Authenticator implementations
+ * ({@link org.apache.catalina.authenticator.SSLAuthenticator},
+ * {@link org.apache.catalina.authenticator.SpnegoAuthenticator}) that
+ * authenticate the user as well as obtain the user credentials. An
+ * authenticated Principal is always created from the user name presented to
+ * without further validation.
+ * 
+ * Note: It is unsafe to use this Realm with Authenticator
+ * implementations that do not validate the provided credentials.
+ */
+public class AuthenticatedUserRealm extends RealmBase {
+
+@Override
+protected String getPassword(String username) {
+// Passwords never need validating so always return null
+return null;
+}
+
+@Override
+protected Principal getPrincipal(String username) {
+// The authentication mechanism has authenticated the user so create
+// the Principal directly
+return new GenericPrincipal(username, null, null);
+}
+}

Propchange: 
tomcat/trunk/java/org/apache/catalina/realm/AuthenticatedUserRealm.java
--
svn:eol-style = native

Modified: 
tomcat/trunk/test/org/apache/tomcat/util/http/parser/TestHttpParserHost.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/test/org/apache/tomcat/util/http/parser/TestHttpParserHost.java?rev=1831432=1831431=1831432=diff
==
--- 
tomcat/trunk/test/org/apache/tomcat/util/http/parser/TestHttpParserHost.java 
(original)
+++ 
tomcat/trunk/test/org/apache/tomcat/util/http/parser/TestHttpParserHost.java 
Fri May 11 16:39:43 2018
@@ -90,6 +90,7 @@ public class TestHttpParserHost {
 result.add(new Object[] { TestType.IPv4, "0com:8080", 
Integer.valueOf(4), null} );
 result.add(new Object[] { TestType.IPv4, "123", Integer.valueOf(-1), 
null} );
 result.add(new Object[] { TestType.IPv4, "123:8080", 
Integer.valueOf(3), null} );
+result.add(new Object[] { TestType.IPv4, "myapp-t.mydomain.com", 
Integer.valueOf(-1), null} );
 // Domain Name - invalid
 result.add(new Object[] { TestType.IPv4, ".", Integer.valueOf(-1), 
IAE} );
 result.add(new Object[] { TestType.IPv4, ".:8080", 
Integer.valueOf(-1), IAE} );

Modified: tomcat/trunk/webapps/docs/changelog.xml
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/changelog.xml?rev=1831432=1831431=1831432=diff
==
--- tomcat/trunk/webapps/docs/changelog.xml (original)
+++ tomcat/trunk/webapps/docs/changelog.xml Fri May 11 16:39:43 2018
@@ -81,6 +81,10 @@
 50019: Add support for lookup-name.
 Based on a patch by Gurkan Erdogdu. (markt)
   
+  
+Add the AuthenticatedUserRealm for use with CLIENT-CERT 
and
+SPNEGO when just the authenticated user name is required. (markt)
+  
 
   
   

Modified: 

[Bug 62371] Improve logging in AbstractProcessor.parseHost()

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=62371

--- Comment #3 from Mark Thomas  ---
The data on the wire will be after the punnycode encoding so the validation
performed by this parser should be correct (Tomcat allows '-' in every element
apart from the gTLD).

To get to the original report, logging the exception at debug is probably the
way to go unless we want to use the UserDataHelper.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: svn commit: r1831389 - /tomcat/trunk/java/org/apache/coyote/http11/Http11InputBuffer.java

[Mark Thomas]

On 11/05/18 15:44, Christopher Schultz wrote:



> Why not use something like "UNKNOWN" instead of "HTTP/1.1"? It might
> be confusing to see that the protocol "is" HTTP/1.1 when it was
> actually something else on the wire.

Because:
- neither the app nor the client ever sees it.
- it needs to be a valid value to prevent another error being triggered
later.

Mark

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 62371] Improve logging in AbstractProcessor.parseHost()

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=62371

--- Comment #2 from Christopher Schultz  ---
Hyphens (-) are allowed to be allowed in hostnames, but not in TLDs[1]

I wonder if this is too restrictive for Tomcat, and whether or not it would
apply (unfairly) to punycode hostnames. My sense is that these hostname
restrictions should apply AFTER any punycode transformation takes place, but
this parser appears to (a) perform no punycode transformation and therefore (b)
would fail to handle any non-US-ASCII domain names.

[1] https://tools.ietf.org/html/draft-liman-tld-names-06#section-1

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: svn commit: r1831389 - /tomcat/trunk/java/org/apache/coyote/http11/Http11InputBuffer.java

[Christopher Schultz]

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256

Mark,

On 5/11/18 4:34 AM, ma...@apache.org wrote:
> Author: markt Date: Fri May 11 08:34:21 2018 New Revision: 1831389
> 
> URL: http://svn.apache.org/viewvc?rev=1831389=rev Log: When
> the header limit is exceeded before the protocol is read (e.g. with
> excessive new lines before the request line), set the protocol to
> avoid the missing protocol triggering a 505 error masking the real
> error code.
> 
> Modified: 
> tomcat/trunk/java/org/apache/coyote/http11/Http11InputBuffer.java
> 
> Modified:
> tomcat/trunk/java/org/apache/coyote/http11/Http11InputBuffer.java 
> URL:
> http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/coyote/http1
1/Http11InputBuffer.java?rev=1831389=1831388=1831389=diff
>
> 

==
> ---
> tomcat/trunk/java/org/apache/coyote/http11/Http11InputBuffer.java
> (original) +++
> tomcat/trunk/java/org/apache/coyote/http11/Http11InputBuffer.java
> Fri May 11 08:34:21 2018 @@ -711,6 +711,10 @@ public class
> Http11InputBuffer implement
> 
> if (parsingHeader) { if (byteBuffer.limit() >= headerBufferSize) { 
> +if (parsingRequestLine) { +//
> Avoid unknown protocol triggering an additional error +
> request.protocol().setString(Constants.HTTP_11); +
> }

Why not use something like "UNKNOWN" instead of "HTTP/1.1"? It might
be confusing to see that the protocol "is" HTTP/1.1 when it was
actually something else on the wire.

- -chris
-BEGIN PGP SIGNATURE-
Comment: GPGTools - http://gpgtools.org
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQIzBAEBCAAdFiEEMmKgYcQvxMe7tcJcHPApP6U8pFgFAlr1rEgACgkQHPApP6U8
pFhn6BAAj1bBFKStBUHSL+9plGEz7X6jr48SuF3ftcbkKZ56saPdQ4xULJm8QUw4
YX+pw2ORv+fq+fmdfgNgIZnlatN4eXTAmUTlswnkjOPEP4LsJUYqFU8t8WT6iiUq
XnYQbyrSKNCcITSu4XQOV6CfvZuOo/Fu6t3SCR9bjQ9azKdUsq6TpnwAwyg3bMwI
25zxBymSWiBv2LENcV4c2CRYvOiTNCEn/DVYZVWubYiLhKuaeo6wD6QKiEnHqJvd
8vl1w7v/YQfauRIyQJZ3wXTmiX8+fTwHFrhVi/4mp0peRCHYc11mvlXVNKYHKLCO
2kizfdMljdZrdXTlEOGe7pPntliMXASiCGekSJoEh+weTFFwU74AYT8fZmssBUIz
qOS1bvopRf07rXWJe9XGAF5TGZKVVmy5cPAewlsfbA0cA4/h2b15al7UFYev8LTa
zbf/f/VImFx/3P5VeujnIy3Cir70MQpETwo1oBHLe6T7AcsLR/L9o3i7oUqj1vyA
U1jUlH6Bhabnh3HIl4uPamY4gDoYUAQMcM+giHsbgdpd8FAGbsh0V+bF7NcGmxgq
Mt38Ge5B5T3NO6uxpgkQqhfvlEn8DXtSJRxdV5eZQhpwrpkYjyaRFI+gItWw6f72
428BkppXqK6t/ob5gBJK7Mz6BZ4LqWpTVr6y3u3nCVOPxiNdKbg=
=RItO
-END PGP SIGNATURE-

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: Two especially slow performance tests on trunk

[Mark Thomas]

On 11/05/18 10:17, Rainer Jung wrote:
> Running the unit tests for trunk on my relatively slow Solaris machine,
> two of the performance tests run especially long:
> 
> javax.websocket.TestContainerProviderPerformance: about 25 minutes per
> connector.
> 
> org.apache.jasper.runtime.TestTagHandlerPoolPerformance: about 5 minutes
> per connector.

These are both intended to be run outside of the unit tests. They are
they to check performance when experimenting with different approaches.
I'd suggest renaming them to Tester... so they are not included in the
user tests.

Mark


> 
> I know that I can disable all performance tests using
> test.excludePerformance, but apart from those two all others run
> reasonably fast.
> 
> In test/javax/websocket/TestContainerProviderPerformance.java, there's
> an iteration count, currently 25. Is there a special reason, why it
> is so high? Would fast machines still generate a reasonable test result
> with something much smaller, like e.g. 1? Phrased differently: how
> fast does that test currently run on your machine?
> 
> The other test,
> test/org/apache/jasper/runtime/TestTagHandlerPoolPerformance.java, uses
> an iteration count of 500 and at least on my 2 core test system
> doesn't scale well. It takes "just" 5 minutes, but still the question
> is, whether we could lower the iteration count maybe to 100 without
> making the test useless?
> 
> Note that the tests seem to not have any success or failure assertion.
> 
> Regards,
> 
> Rainer
> 
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
> 


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r1831414 [2/2] - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/ha/session/DeltaManager.java java/org/apache/catalina/ha/session/LocalStrings.properties webapps/docs/changelog.xml

[markt]

Modified: 
tomcat/tc7.0.x/trunk/java/org/apache/catalina/ha/session/DeltaManager.java
URL: 
http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/java/org/apache/catalina/ha/session/DeltaManager.java?rev=1831414=1831413=1831414=diff
==
--- tomcat/tc7.0.x/trunk/java/org/apache/catalina/ha/session/DeltaManager.java 
(original)
+++ tomcat/tc7.0.x/trunk/java/org/apache/catalina/ha/session/DeltaManager.java 
Fri May 11 13:15:13 2018
@@ -5,9 +5,9 @@
  * The ASF licenses this file to You under the Apache License, Version 2.0
  * (the "License"); you may not use this file except in compliance with
  * the License.  You may obtain a copy of the License at
- * 
+ *
  *  http://www.apache.org/licenses/LICENSE-2.0
- * 
+ *
  * Unless required by applicable law or agreed to in writing, software
  * distributed under the License is distributed on an "AS IS" BASIS,
  * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
@@ -44,14 +44,14 @@ import org.apache.tomcat.util.res.String
  * The DeltaManager manages replicated sessions by only replicating the deltas
  * in data. For applications written to handle this, the DeltaManager is the
  * optimal way of replicating data.
- * 
+ *
  * This code is almost identical to StandardManager with a difference in how it
  * persists sessions and some modifications to it.
- * 
+ *
  * IMPLEMENTATION NOTE : Correct behavior of session storing and
  * reloading depends upon external calls to the start() and
  * stop() methods of this class at the correct times.
- * 
+ *
  * @author Filip Hanik
  * @author Craig R. McClanahan
  * @author Jean-Francois Arcand
@@ -79,7 +79,7 @@ public class DeltaManager extends Cluste
  */
 protected static String managerName = "DeltaManager";
 protected String name = null;
-
+
 private boolean expireSessionsOnShutdown = false;
 private boolean notifySessionListenersOnReplication = true;
 private boolean notifyContainerListenersOnReplication  = true;
@@ -88,19 +88,19 @@ public class DeltaManager extends Cluste
 private int stateTransferTimeout = 60;
 private boolean sendAllSessions = true;
 private int sendAllSessionsSize = 1000 ;
-
+
 /**
- * wait time between send session block (default 2 sec) 
+ * wait time between send session block (default 2 sec)
  */
-private int sendAllSessionsWaitTime = 2 * 1000 ; 
+private int sendAllSessionsWaitTime = 2 * 1000 ;
 private ArrayList receivedMessageQueue =
 new ArrayList() ;
 private boolean receiverQueue = false ;
 private boolean stateTimestampDrop = true ;
-private long stateTransferCreateSendTime; 
-
+private long stateTransferCreateSendTime;
+
 // -- 
stats attributes
-
+
 private long sessionReplaceCounter = 0 ;
 private long counterReceive_EVT_GET_ALL_SESSIONS = 0 ;
 private long counterReceive_EVT_ALL_SESSION_DATA = 0 ;
@@ -120,7 +120,7 @@ public class DeltaManager extends Cluste
 private int counterSend_EVT_ALL_SESSION_TRANSFERCOMPLETE = 0 ;
 private long counterSend_EVT_CHANGE_SESSION_ID = 0;
 private int counterNoStateTransfered = 0 ;
-
+
 
 // - 
Constructor
 public DeltaManager() {
@@ -128,7 +128,7 @@ public class DeltaManager extends Cluste
 }
 
 // - Properties
-
+
 /**
  * Return descriptive information about this Manager implementation and the
  * corresponding version number, in the format
@@ -155,14 +155,14 @@ public class DeltaManager extends Cluste
 public long getCounterSend_EVT_GET_ALL_SESSIONS() {
 return counterSend_EVT_GET_ALL_SESSIONS;
 }
-
+
 /**
  * @return Returns the counterSend_EVT_SESSION_ACCESSED.
  */
 public long getCounterSend_EVT_SESSION_ACCESSED() {
 return counterSend_EVT_SESSION_ACCESSED;
 }
-
+
 /**
  * @return Returns the counterSend_EVT_SESSION_CREATED.
  */
@@ -183,7 +183,7 @@ public class DeltaManager extends Cluste
 public long getCounterSend_EVT_SESSION_EXPIRED() {
 return counterSend_EVT_SESSION_EXPIRED;
 }
- 
+
 /**
  * @return Returns the counterSend_EVT_ALL_SESSION_DATA.
  */
@@ -211,43 +211,43 @@ public class DeltaManager extends Cluste
 public long getCounterReceive_EVT_ALL_SESSION_DATA() {
 return counterReceive_EVT_ALL_SESSION_DATA;
 }
-
+
 /**
  * @return Returns the counterReceive_EVT_GET_ALL_SESSIONS.
  */
 public long getCounterReceive_EVT_GET_ALL_SESSIONS() {
 return counterReceive_EVT_GET_ALL_SESSIONS;
 }
-
+
 /**
  * @return Returns the counterReceive_EVT_SESSION_ACCESSED.
  */
 public long getCounterReceive_EVT_SESSION_ACCESSED() {
 return 

svn commit: r1831414 [1/2] - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/ha/session/DeltaManager.java java/org/apache/catalina/ha/session/LocalStrings.properties webapps/docs/changelog.xml

[markt]

Author: markt
Date: Fri May 11 13:15:13 2018
New Revision: 1831414

URL: http://svn.apache.org/viewvc?rev=1831414=rev
Log:
Remove duplicate calls when creating a replicated session to reduce the time 
taken to create the session and thereby reduce the chances of a subsequent 
session update message being ignored because the session does not yet exist.

Modified:
tomcat/tc7.0.x/trunk/   (props changed)
tomcat/tc7.0.x/trunk/java/org/apache/catalina/ha/session/DeltaManager.java

tomcat/tc7.0.x/trunk/java/org/apache/catalina/ha/session/LocalStrings.properties
tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml

Propchange: tomcat/tc7.0.x/trunk/
--
--- svn:mergeinfo (original)
+++ svn:mergeinfo Fri May 11 13:15:13 2018
@@ -1,3 +1,3 @@
-/tomcat/tc8.0.x/trunk:1636525,1637336,1637685,1637709,1638726,1640089,1640276,1640349,1640363,1640366,1640642,1640672,1640674,1640689,1640884,1641001,1641065,1641067,1641375,1641638,1641723,1641726,1641729-1641730,1641736,1641988,1642669-1642670,1642698,1642701,1643205,1643215,1643217,1643230,1643232,1643273,1643285,1643329-1643330,1643511,1643513,1643521,1643539,1643571,1643581-1643582,1643635,1643655,1643738,1643964,1644018,1644333,1644525,1644954,1644992,1645014,1645360,1645456,1645627,1645642,1645686,1645903-1645904,1645908-1645909,1645913,1645920,1646458,1646460-1646462,1646735,1646738-1646741,1646744,1646746,1646748-1646755,1646757,1646759-1646760,1647043,1648816,1651420-1651422,1651844,1652926,1652939-1652940,1652973,1653798,1653817,1653841,1654042,1654161,1654736,1654767,1654787,1656592,1659907,1662986,1663265,1663278,1663325,1663535,1663567,1663679,1663997,1664175,1664321,1664872,1665061,1665086,1666027,1666395,1666503,1666506,1666560,1666570,1666581,1666759,1666967,1666988
 
,1667553-1667555,1667558,1667617,1667633,1667637,1667747,1667767,1667873,1668028,1668137,1668634,1669432,1669801,1669840,1669895-1669896,1670398,1670435,1670592,1670605-1670607,1670609,1670632,1670720,1670725,1670727,1670731,1671114,1672273,1672285,1673759,1674220,1674295,1675469,1675488,1675595,1675831,1676232,1676367-1676369,1676382,1676394,1676483,1676556,1676635,1678178,1679536,1679988,1680256,1681124,1681182,1681703,1681730,1681840,1681864,1681869,1682010,1682034,1682047,1682052-1682053,1682062,1682064,1682070,1682312,1682325,1682331,1682386,1684367,1684385,1685759,1685774,1685827,1685892,1687341,1688904,1689358,1689657,1689921,1692850,1693093,1693108,1693324,1694060,1694115,1694291,1694427,1694431,1694503,1694549,1694789,1694873,1694881,1695356,1695372,1695823-1695825,1696200,1696281,1696379,1696468,1700608,1700871,1700897,1700978,1701094,1701124,1701608,1701668,1701676,1701766,1701944,1702248,1702252,1702314,1702390,1702723,1702725,1702728,1702730,1702733,1702735,1702737,1702
 
739,1702742,1702744,1702748,1702751,1702754,1702758,1702760,1702763,1702766,1708779,1708782,1708806,1709314,1709670,1710347,1710442,1710448,1710490,1710574,1710578,1712226,1712229,1712235,1712255,1712618,1712649,1712655,1712860,1712899,1712903,1712906,1712913,1712926,1712975,1713185,1713262,1713287,1713613,1713621,1713872,1713976,1713994,1713998,1714004,1714013,1714059,1714538,1714580,1715189,1715207,1715544,1715549,1715637,1715639-1715645,1715667,1715683,1715866,1715978,1715981,1716216-1716217,1716355,1716414,1716421,1717208-1717209,1717257,1717283,1717288,1717291,1717421,1717517,1717529,1718797,1718840-1718843,1719348,1719357-1719358,1719400,1719491,1719737,1720235,1720396,1720442,1720446,1720450,1720463,1720658-1720660,1720756,1720816,1721813,1721818,1721831,1721861,1721867,1721882,1722523,1722527,1722800,1722926,1722941,1722997,1723130,1723440,1723488,1723890,1724434,1724674,1724792,1724803,1724902,1725128,1725131,1725154,1725167,1725911,1725921,1725929,1725963-1725965,1725970,1
 
725974,1726171-1726173,1726175,1726179-1726182,1726190-1726191,1726195-1726200,1726203,1726226,1726576,1726630,1726992,1727029,1727037,1727671,1727676,1727900,1728028,1728092,1728439,1728449,1729186,1729362,1731009,1731303,1731867,1731872,1731874,1731876,1731885,1731947,1731955,1731959,1731977,1731984,1732360,1732490,1732672,1732902,1733166,1733603,1733619,1733735,1733752,1733764,1733915,1733941,1733964,1734115,1734133,1734261,1734421,1734531,1736286,1737967,1738173,1738182,1738992,1739039,1739089-1739091,1739294,1739777,1739821,1739981,1740513,1740726,1741019,1741162,1741217,1743647,1743681,1744152,1744272,1746732,1746750,1752739,1754615,1755886,1756018,1758563,1759565,1761686,1762173,1762206,1766280,1767507-1767508,1767653,1767656,1769267,1772949,1773521,1773527,1774104,1777015,1777213,1779330,1783151,1784188,1784966,1785670,1786846,1788260,1788999,1789140,1789402,1791529,1791559,1795291,1796906,1797523,1799214,1800998-1800999,1801003,1801007-1801008,1801017,1801020,1802808,180281
 

svn commit: r1831413 - in /tomcat/tc8.0.x/trunk: ./ java/org/apache/catalina/ha/session/DeltaManager.java java/org/apache/catalina/ha/session/LocalStrings.properties webapps/docs/changelog.xml

[markt]

Author: markt
Date: Fri May 11 13:12:08 2018
New Revision: 1831413

URL: http://svn.apache.org/viewvc?rev=1831413=rev
Log:
Remove duplicate calls when creating a replicated session to reduce the time 
taken to create the session and thereby reduce the chances of a subsequent 
session update message being ignored because the session does not yet exist.

Modified:
tomcat/tc8.0.x/trunk/   (props changed)
tomcat/tc8.0.x/trunk/java/org/apache/catalina/ha/session/DeltaManager.java

tomcat/tc8.0.x/trunk/java/org/apache/catalina/ha/session/LocalStrings.properties
tomcat/tc8.0.x/trunk/webapps/docs/changelog.xml

Propchange: tomcat/tc8.0.x/trunk/
--
--- svn:mergeinfo (original)
+++ svn:mergeinfo Fri May 11 13:12:08 2018
@@ -1,2 +1,2 @@
 
/tomcat/tc8.5.x/trunk:1735042,1737966,1743139-1743140,1744151,1747537,1747925,1748002,1754614,1754643,1762124,1762183,1762203,1763792,1772948,1777014,1779719,1779898,1782037,1782240,1782386-1782387,1785669,1786845,1788249,1788324,1788905,1789216,1789335,1791528,1791558,1796697-1796698,1797521,1798543,1799162,1800143,1801693,1802805,1806799,1807079-1807080,1808880,1809831,1812093,1812143,1812145,1812319,1814975,1815945,1815956,1820207,1822186,1823164,1823497,1824960,1826872-1826873,1827862,1829310,1829777,1829796,1829935,1830215,1830991,1831042
-/tomcat/trunk:1636524,1637156,1637176,1637188,1637331,1637684,1637695,1637890,1637892,1638720-1638725,1639653,1640010,1640083-1640084,1640088,1640275,1640322,1640347,1640361,1640365,1640403,1640410,1640652,1640655-1640658,1640688,1640700-1640883,1640903,1640976,1640978,1641000,1641026,1641038-1641039,1641051-1641052,1641058,1641064,1641300,1641369,1641374,1641380,1641486,1641634,1641656-1641692,1641704,1641707-1641718,1641720-1641722,1641735,1641981,1642233,1642280,1642554,1642564,1642595,1642606,1642668,1642679,1642697,1642699,1642766,1643002,1643045,1643054-1643055,1643066,1643121,1643128,1643206,1643209-1643210,1643216,1643249,1643270,1643283,1643309-1643310,1643323,1643365-1643366,1643370-1643371,1643465,1643474,1643536,1643570,1643634,1643649,1643651,1643654,1643675,1643731,1643733-1643734,1643761,1643766,1643814,1643937,1643963,1644017,1644169,1644201-1644203,1644321,1644323,1644516,1644523,1644529,1644535,1644730,1644768,1644784-1644785,1644790,1644793,1644815,1644884,1644886
 
,1644890,1644892,1644910,1644924,1644929-1644930,1644935,1644989,1645011,1645247,1645355,1645357-1645358,1645455,1645465,1645469,1645471,1645473,1645475,1645486-1645488,1645626,1645641,1645685,1645743,1645763,1645951-1645953,1645955,1645993,1646098-1646106,1646178,1646220,1646302,1646304,1646420,1646470-1646471,1646476,1646559,1646717-1646723,1646773,1647026,1647042,1647530,1647655,1648304,1648815,1648907,1649973,1650081,1650365,1651116,1651120,1651280,1651470,1652938,1652970,1653041,1653471,1653550,1653574,1653797,1653815-1653816,1653819,1653840,1653857,1653888,1653972,1654013,1654030,1654050,1654123,1654148,1654159,1654513,1654515,1654517,1654522,1654524,1654725,1654735,1654766,1654785,1654851-1654852,1654978,1655122-1655124,1655126-1655127,1655129-1655130,1655132-1655133,1655312,1655351,1655438,1655441,1655454,168,1656087,1656299,1656319,1656331,1656345,1656350,1656590,1656648-1656650,1656657,1657041,1657054,1657374,1657492,1657510,1657565,1657580,1657584,1657586,1657589,1657
 
592,1657607,1657609,1657682,1657907,1658207,1658734,1658781,1658790,1658799,1658802,1658804,1658833,1658840,1658966,1659043,1659053,1659059,1659174,1659184,1659188-1659189,1659216,1659263,1659293,1659304,1659306-1659307,1659382,1659384,1659428,1659471,1659486,1659505,1659516,1659521,1659524,1659559,1659562,1659803,1659806,1659814,1659833,1659862,1659905,1659919,1659948,1659967,1659983-1659984,1660060,1660074,1660077,1660133,1660168,1660331-1660332,1660353,1660358,1660924,1661386,1661770,1661867,1661972,1661990,1662200,1662308-1662309,1662548,1662614,1662696,1662736,1662985,1662988-1662989,1663264,1663277,1663298,1663534,1663562,1663676,1663715,1663754,1663768,1663772,1663781,1663893,1663995,1664143,1664163,1664174,1664301,1664317,1664347,1664657,1664659,1664710,1664863-1664864,1664866,1665085,1665292,1665559,1665653,1665661,1665672,1665694,1665697,1665736,1665779,1665976-1665977,1665980-1665981,1665985-1665986,1665989,1665998,1666004,1666008,1666013,1666017,1666024,1666116,1666386-1
 

svn commit: r1831411 - in /tomcat/tc8.5.x/trunk: ./ java/org/apache/catalina/ha/session/DeltaManager.java java/org/apache/catalina/ha/session/LocalStrings.properties webapps/docs/changelog.xml

[markt]

Author: markt
Date: Fri May 11 13:09:36 2018
New Revision: 1831411

URL: http://svn.apache.org/viewvc?rev=1831411=rev
Log:
Remove duplicate calls when creating a replicated session to reduce the time 
taken to create the session and thereby reduce the chances of a subsequent 
session update message being ignored because the session does not yet exist.

Modified:
tomcat/tc8.5.x/trunk/   (props changed)
tomcat/tc8.5.x/trunk/java/org/apache/catalina/ha/session/DeltaManager.java

tomcat/tc8.5.x/trunk/java/org/apache/catalina/ha/session/LocalStrings.properties
tomcat/tc8.5.x/trunk/webapps/docs/changelog.xml

Propchange: tomcat/tc8.5.x/trunk/
--
--- svn:mergeinfo (original)
+++ svn:mergeinfo Fri May 11 13:09:36 2018
@@ -1,2 +1,2 @@
 /tomcat/tc8.0.x/trunk:1809644
-/tomcat/trunk:1734785,1734799,1734845,1734928,1735041,1735044,1735480,1735577,1735597,1735599-1735600,1735615,1736145,1736162,1736209,1736280,1736297,1736299,1736489,1736646,1736703,1736836,1736849,1737104-1737105,1737112,1737117,1737119-1737120,1737155,1737157,1737192,1737280,1737339,1737632,1737664,1737715,1737748,1737785,1737834,1737860,1737903,1737959,1738005,1738007,1738014-1738015,1738018,1738022,1738039,1738043,1738059-1738060,1738147,1738149,1738174-1738175,1738261,1738589,1738623-1738625,1738643,1738816,1738850,1738855,1738946-1738948,1738953-1738954,1738979,1738982,1739079-1739081,1739087,1739113,1739153,1739172,1739176,1739191,1739474,1739492,1739726,1739762,1739775,1739814,1739817-1739818,1739975,1740131,1740324,1740465,1740495,1740508-1740509,1740520,1740535,1740707,1740803,1740810,1740969,1740980,1740991,1740997,1741015,1741033,1741036,1741058,1741060,1741080,1741147,1741159,1741164,1741173,1741181,1741190,1741197,1741202,1741208,1741213,1741221,1741225,1741232,1741409
 
,1741501,1741677,1741892,1741896,1741984,1742023,1742042,1742071,1742090,1742093,1742101,1742105,1742111,1742139,1742146,1742148,1742166,1742181,1742184,1742187,1742246,1742248-1742251,1742263-1742264,1742268,1742276,1742369,1742387,1742448,1742509-1742512,1742917,1742919,1742933,1742975-1742976,1742984,1742986,1743019,1743115,1743117,1743124-1743125,1743134,1743425,1743554,1743679,1743696-1743698,1743700-1743701,1744058,1744064-1744065,1744125,1744149,1744194,1744229,1744270,1744323,1744432,1744684,1744697,1744705,1744713,1744760,1744786,1745083,1745142-1745143,1745145,1745177,1745179-1745180,1745227,1745248,1745254,1745337,1745467,1745473,1745535,1745576,1745735,1745744,1746304,1746306-1746307,1746319,1746327,1746338,1746340-1746341,1746344,1746427,1746441,1746473,1746490,1746492,1746495-1746496,1746499-1746501,1746503-1746507,1746509,1746549,1746551,1746554,1746556,1746558,1746584,1746620,1746649,1746724,1746939,1746989,1747014,1747028,1747035,1747210,1747225,1747234,1747253,1747
 
404,1747506,1747536,1747924,1747980,1747993,1748001,1748253,1748452,1748547,1748629,1748676,1748715,1749287,1749296,1749328,1749373,1749465,1749506,1749508,1749665-1749666,1749763,1749865-1749866,1749898,1749978,1749980,1750011,1750015,1750056,1750480,1750617,1750634,1750692,1750697,1750700,1750703,1750707,1750714,1750718,1750723,1750774,1750899,1750975,1750995,1751061,1751097,1751173,1751438,1751447,1751463,1751702,1752212,1752737,1752745,1753078,1753080,1753358,1753363,1754111,1754140-1754141,1754281,1754310,1754445,1754467,1754494,1754496,1754528,1754532-1754533,1754613,1754714,1754874,1754941,1754944,1754950-1754951,1755005,1755007,1755009,1755132,1755180-1755181,1755185,1755190,1755204-1755206,1755208,1755214,1755224,1755227,1755230,1755629,1755646-1755647,1755650,1755653,1755675,1755680,1755683,1755693,1755717,1755731-1755737,1755812,1755828,1755884,1755890,1755918-1755919,1755942,1755958,1755960,1755970,1755993,1756013,1756019,1756039,1756056,1756083-1756114,1756175,1756288-1
 
756289,1756408-1756410,1756778,1756798,1756878,1756898,1756939,1757123-1757124,1757126,1757128,1757132-1757133,1757136,1757145,1757167-1757168,1757175,1757180,1757182,1757195,1757271,1757278,1757347,1757353-1757354,1757363,1757374,1757399,1757406,1757408,1757485,1757495,1757499,1757527,1757578,1757684,1757722,1757727,1757790,1757799,1757813,1757853,1757883,1757903,1757976,1757997,1758000,1758058,1758072-1758075,1758078-1758079,1758223,1758257,1758261,1758276,1758292,1758369,1758378-1758383,1758421,1758423,1758425-1758427,1758430,1758443,1758448,1758459,1758483,1758486-1758487,1758499,1758525,1758556,1758580,1758582,1758584,1758588,1758842,1759019,1759212,1759224,1759227,1759252,1759274,1759513-1759516,1759611,1759757,1759785-1759790,1760005,1760022,1760109-1760110,1760135,1760200-1760201,1760227,1760300,1760397,1760446,1760454,1760640,1760648,1761057,1761422,1761491,1761498,1761500-1761501,1761550,1761553,1761572,1761574,1761625-1761626,1761628,1761682,1761740,1761752,1762051-176205
 

svn commit: r1831410 - in /tomcat/trunk: java/org/apache/catalina/ha/session/DeltaManager.java java/org/apache/catalina/ha/session/LocalStrings.properties webapps/docs/changelog.xml

[markt]

Author: markt
Date: Fri May 11 13:08:30 2018
New Revision: 1831410

URL: http://svn.apache.org/viewvc?rev=1831410=rev
Log:
Remove duplicate calls when creating a replicated session to reduce the time 
taken to create the session and thereby reduce the chances of a subsequent 
session update message being ignored because the session does not yet exist.

Modified:
tomcat/trunk/java/org/apache/catalina/ha/session/DeltaManager.java
tomcat/trunk/java/org/apache/catalina/ha/session/LocalStrings.properties
tomcat/trunk/webapps/docs/changelog.xml

Modified: tomcat/trunk/java/org/apache/catalina/ha/session/DeltaManager.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/ha/session/DeltaManager.java?rev=1831410=1831409=1831410=diff
==
--- tomcat/trunk/java/org/apache/catalina/ha/session/DeltaManager.java 
(original)
+++ tomcat/trunk/java/org/apache/catalina/ha/session/DeltaManager.java Fri May 
11 13:08:30 2018
@@ -1226,7 +1226,12 @@ public class DeltaManager extends Cluste
 counterReceive_EVT_SESSION_DELTA++;
 byte[] delta = msg.getSession();
 DeltaSession session = (DeltaSession) findSession(msg.getSessionID());
-if (session != null) {
+if (session == null) {
+if (log.isDebugEnabled()) {
+
log.debug(sm.getString("deltaManager.receiveMessage.delta.unknown",
+getName(), msg.getSessionID()));
+}
+} else {
 if (log.isDebugEnabled()) {
 log.debug(sm.getString("deltaManager.receiveMessage.delta",
 getName(), msg.getSessionID()));
@@ -1292,7 +1297,6 @@ public class DeltaManager extends Cluste
 getName(), msg.getSessionID()));
 }
 DeltaSession session = (DeltaSession) createEmptySession();
-session.setManager(this);
 session.setValid(true);
 session.setPrimarySession(false);
 session.setCreationTime(msg.getTimestamp());
@@ -1301,7 +1305,6 @@ public class DeltaManager extends Cluste
 session.setMaxInactiveInterval(getContext().getSessionTimeout() * 60, 
false);
 session.access();
 session.setId(msg.getSessionID(), notifySessionListenersOnReplication);
-session.resetDeltaRequest();
 session.endAccess();
 
 }

Modified: 
tomcat/trunk/java/org/apache/catalina/ha/session/LocalStrings.properties
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/ha/session/LocalStrings.properties?rev=1831410=1831409=1831410=diff
==
--- tomcat/trunk/java/org/apache/catalina/ha/session/LocalStrings.properties 
(original)
+++ tomcat/trunk/java/org/apache/catalina/ha/session/LocalStrings.properties 
Fri May 11 13:08:30 2018
@@ -37,6 +37,7 @@ deltaManager.expireSessions=Manager [{0}
 deltaManager.receiveMessage.accessed=Manager [{0}]: received session [{1}] 
accessed.
 deltaManager.receiveMessage.createNewSession=Manager [{0}]: received session 
[{1}] created.
 deltaManager.receiveMessage.delta=Manager [{0}]: received session [{1}] delta.
+deltaManager.receiveMessage.delta.unknown=Manager [{0}]: received unknown 
session [{1}] delta.
 deltaManager.receiveMessage.error=Manager [{0}]: Unable to receive message 
through TCP channel
 deltaManager.receiveMessage.eventType=Manager [{0}]: Received SessionMessage 
of type=[{1}] from [{2}]
 deltaManager.receiveMessage.expired=Manager [{0}]: received session [{1}] 
expired.

Modified: tomcat/trunk/webapps/docs/changelog.xml
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/changelog.xml?rev=1831410=1831409=1831410=diff
==
--- tomcat/trunk/webapps/docs/changelog.xml (original)
+++ tomcat/trunk/webapps/docs/changelog.xml Fri May 11 13:08:30 2018
@@ -110,6 +110,16 @@
   
 
   
+  
+
+  
+Remove duplicate calls when creating a replicated session to reduce the
+time taken to create the session and thereby reduce the chances of a
+subsequent session update message being ignored because the session 
does
+not yet exist. (markt)
+  
+
+  
   
 
   



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[GitHub] tomcat issue #108: Improve undeployment in parallel deployment scenario

[ChristopherSchultz]

Github user ChristopherSchultz commented on the issue:

https://github.com/apache/tomcat/pull/108
  
I'm starting to lean toward requiring this new feature to require a 
configuration option to enable it, and have it default to `false`. My 
justification is that it represents a breaking behavioral change that is *just 
slightly different* than previous behavior as to be unnoticeable until it 
starts behaving completely unexpectedly.

Can you please add a configuration option for `` to enable or disable 
this? Simply swap-out the `compareTo` implementation depending upon the value 
of that setting.


---

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 62371] Improve logging in AbstractProcessor.parseHost()

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=62371

--- Comment #1 from Luko  ---
I have the same issue.
In my opinion the issue is in Tomcat host validation.
My application DNS alias looks like this : myapp-t.my-dommain
where -t is env (test)
my-domain is the domain name (yes, with minus sign (-))

When I change the header request to name:myappt.mydomain everything is OK
When header request host name:myapp-t.my-dommain I get the HTTP 400 bad
request.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

REMINDER: Apache EU Roadshow 2018 schedule announced!

[sharan]

Hello Apache Supporters and Enthusiasts

This is a reminder that the schedule for the Apache EU Roadshow 2018 in 
Berlin has been announced.


http://apachecon.com/euroadshow18/schedule.html

Please note that we will not be running an ApacheCon in Europe this year 
which means that this Apache EU Roadshow will be the main Apache event 
in Europe for 2018.


The Apache EU Roadshow tracks take place on the 13th and 14th June 2018, 
and will feature 28 sessions across the following themes; Apache Tomcat, 
IoT , Cloud Technologies, Microservices and Apache Httpd Server.


Please note that the Apache EU Roadshow is co-located with FOSS 
Backstage and their schedule (https://foss-backstage.de/sessions) 
includes many Apache related sessions such as Incubator, Apache Way, 
Open Source Governance, Legal, Trademarks as well as a full range 
community related presentations and panel discussions.


One single registration gives you access to both events - the Apache EU 
Roadshow and FOSS Backstage.


Registration includes catering (breakfast & lunch both days) and also an 
attendee evening event. And if you want to have a project meet-up, hack 
or simply spend time and relax in our on-site Apache Lounge between 
sessions, then you are more than welcome.


We look forward to seeing you in Berlin!

Thanks
Sharan Foga, VP Apache Community Development

PLEASE NOTE: You are receiving this message because you are subscribed 
to a user@ or dev@ list of one or more Apache Software Foundation projects.

[GitHub] tomcat issue #108: Improve undeployment in parallel deployment scenario

[koraktor]

Github user koraktor commented on the issue:

https://github.com/apache/tomcat/pull/108
  
@markt-asf I’m sorry to nag you about this, but I didn’t get any 
feedback since my improvements on this patch series.


---

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r1831395 - /tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml

[violetagg]

Author: violetagg
Date: Fri May 11 09:42:59 2018
New Revision: 1831395

URL: http://svn.apache.org/viewvc?rev=1831395=rev
Log:
Update the release date for 7.0.88

Modified:
tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml

Modified: tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml
URL: 
http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml?rev=1831395=1831394=1831395=diff
==
--- tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml (original)
+++ tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml Fri May 11 09:42:59 2018
@@ -73,7 +73,7 @@
 
   
 
-
+
   
 
   



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r26843 - /dev/tomcat/tomcat-7/v7.0.88/ /release/tomcat/tomcat-7/v7.0.88/

[violetagg]

Author: violetagg
Date: Fri May 11 09:37:37 2018
New Revision: 26843

Log:
Release 7.0.88

Added:
release/tomcat/tomcat-7/v7.0.88/
  - copied from r26842, dev/tomcat/tomcat-7/v7.0.88/
Removed:
dev/tomcat/tomcat-7/v7.0.88/


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [RESULT][VOTE] Release Apache Tomcat 7.0.88

[Violeta Georgieva]

Hi,

2018-05-07 15:06 GMT+03:00 Violeta Georgieva :
>
> The proposed Apache Tomcat 7.0.88 release is now available for voting.
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-7/v7.0.88/
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1184/
> The svn tag is:
> http://svn.apache.org/repos/asf/tomcat/tc7.0.x/tags/TOMCAT_7_0_88/
>
> The proposed 7.0.88 release is:
> [ ] Broken - do not release
> [ ] Stable - go ahead and release as 7.0.88 Stable


+1 (binding):violetagg, huxing, kkolinko, fschumacher

No other voters were cast.

The vote has passed.

I'll do the release shortly and announce it once the mirrors catch up.

Regards,
Violeta

Two especially slow performance tests on trunk

[Rainer Jung]

Running the unit tests for trunk on my relatively slow Solaris machine, 
two of the performance tests run especially long:


javax.websocket.TestContainerProviderPerformance: about 25 minutes per 
connector.


org.apache.jasper.runtime.TestTagHandlerPoolPerformance: about 5 minutes 
per connector.


I know that I can disable all performance tests using 
test.excludePerformance, but apart from those two all others run 
reasonably fast.


In test/javax/websocket/TestContainerProviderPerformance.java, there's 
an iteration count, currently 25. Is there a special reason, why it 
is so high? Would fast machines still generate a reasonable test result 
with something much smaller, like e.g. 1? Phrased differently: how 
fast does that test currently run on your machine?


The other test, 
test/org/apache/jasper/runtime/TestTagHandlerPoolPerformance.java, uses 
an iteration count of 500 and at least on my 2 core test system 
doesn't scale well. It takes "just" 5 minutes, but still the question 
is, whether we could lower the iteration count maybe to 100 without 
making the test useless?


Note that the tests seem to not have any success or failure assertion.

Regards,

Rainer

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 62343] CORS security: reflecting any origin header value when configured to * is dangerous

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=62343

--- Comment #1 from Jianjun Chen  ---
Hi, is there something I forget to do to advance this report?  I haven't
received any response yet.

Thanks,
Jianjun

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: svn commit: r1830547 - in /tomcat/trunk: java/org/apache/coyote/Response.java java/org/apache/coyote/http11/Http11InputBuffer.java webapps/docs/changelog.xml

[Rainer Jung]

Am 11.05.2018 um 10:31 schrieb Mark Thomas:

On 11/05/18 08:58, Rainer Jung wrote:

Am 30.04.2018 um 12:57 schrieb ma...@apache.org:

Author: markt
Date: Mon Apr 30 10:57:27 2018
New Revision: 1830547

URL: http://svn.apache.org/viewvc?rev=1830547=rev
Log:
Correct a regression in the error page handling that prevented error
pages from issuing redirects or taking other action that required the
response status code to be changed.

Modified:
  tomcat/trunk/java/org/apache/coyote/Response.java
  tomcat/trunk/java/org/apache/coyote/http11/Http11InputBuffer.java
  tomcat/trunk/webapps/docs/changelog.xml

Modified: tomcat/trunk/java/org/apache/coyote/Response.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/coyote/Response.java?rev=1830547=1830546=1830547=diff

==

--- tomcat/trunk/java/org/apache/coyote/Response.java (original)
+++ tomcat/trunk/java/org/apache/coyote/Response.java Mon Apr 30
10:57:27 2018
@@ -227,10 +227,6 @@ public final class Response {
    * @param status The status value to set
    */
   public void setStatus(int status) {
-    if (this.status > 399) {
-    // Don't overwrite first recorded error status
-    return;
-    }
   this.status = status;
   }


This part of the patch makes TestHttp11InputBuffer fail for me, more
precisely

Testcase: testNewLinesExcessive took 0.12 sec
     FAILED
HTTP/1.1 505
junit.framework.AssertionFailedError: HTTP/1.1 505
     at
org.apache.coyote.http11.TestHttp11InputBuffer.testNewLinesExcessive(TestHttp11InputBuffer.java:385)


I can't repeat this but looking at the test is does look as if it might
depend on network behaviour.


The test expects status 400, but gets 505. The 505 is being set in the
following stack:

at org.apache.coyote.Response.setStatus(Response.java:231)
at
org.apache.coyote.http11.Http11Processor.prepareRequest(Http11Processor.java:588)


But I can put a break point here and catch this happening.


at
org.apache.coyote.http11.Http11Processor.service(Http11Processor.java:388)
at
org.apache.coyote.AbstractProcessorLight.process(AbstractProcessorLight.java:66)

at
org.apache.coyote.AbstractProtocol$ConnectionHandler.process(AbstractProtocol.java:754)

...

In prepareRequest(), the String protocolMB contains the text "null".

I don't know whether we just need to fix the test expectation, or tested
code.


I think something along the lines of the r1830547 changes for
Http11InputBuffer should do the trick. I should be able to commit
something shortly.


Thanks Mark, r1831389 fixed it for me.

Regards,

Rainer


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 62371] New: Improve logging in AbstractProcessor.parseHost()

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=62371

Bug ID: 62371
   Summary: Improve logging in AbstractProcessor.parseHost()
   Product: Tomcat 9
   Version: 9.0.7
  Hardware: PC
OS: Linux
Status: NEW
  Severity: normal
  Priority: P2
 Component: Catalina
  Assignee: dev@tomcat.apache.org
  Reporter: alex.cheve...@gmail.com
  Target Milestone: -

It now sends 400 code without any traces in logs of what is the source of the
problem. In my case it was quite hard to trace the issue. I had:

java.lang.IllegalArgumentException: The character [_] is never valid in a
domain name.
at
org.apache.tomcat.util.http.parser.HttpParser$DomainParseState.next(HttpParser.java:781)
at
org.apache.tomcat.util.http.parser.HttpParser.readHostDomainName(HttpParser.java:673)
at org.apache.tomcat.util.http.parser.Host.parse(Host.java:66)
at org.apache.tomcat.util.http.parser.Host.parse(Host.java:40)
at
org.apache.coyote.AbstractProcessor.parseHost(AbstractProcessor.java:269)
at
org.apache.coyote.http11.Http11Processor.prepareRequest(Http11Processor.java:760)
at
org.apache.coyote.http11.Http11Processor.service(Http11Processor.java:383)
at
org.apache.coyote.AbstractProcessorLight.process(AbstractProcessorLight.java:66)
at
org.apache.coyote.AbstractProtocol$ConnectionHandler.process(AbstractProtocol.java:754)
at
org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.doRun(NioEndpoint.java:1376)
at
org.apache.tomcat.util.net.SocketProcessorBase.run(SocketProcessorBase.java:49)
at
java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1135)
at
java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635)
at
org.apache.tomcat.util.threads.TaskThread$WrappingRunnable.run(TaskThread.java:61)
at java.base/java.lang.Thread.run(Thread.java:844)


I spend lots of time trying to debug the issue I had.


If you need more info on config - I have:

Apache 2.4 -> ProxyPass ajp -> tomcat (java 10)
   -> ProxyPass websocket (http11) -> tomcat (same)

All this runs as docker containers so in Apache config I connect to tomcat
using name "default_tomcat_1" - given by docker (compose). As a result after
upgrading from tomcat 7.0.56 to 9.0.7 I have all websocket requests just
failing with code 400. After debugging tomcat I understand that websocket
requests go via Http11Processor and fail cause it receives this
"default_tomcat_1" as host name from Apache. At the same time other requests
routed via AJP are working fine cause they've got Apache public IP as "host".

On apache config:

ProxyPass /websocket ws://default_tomcat_1:8080/websocket retry=0
ProxyPassReverse /websocket ws://default_tomcat_1:8080/websocket

ProxyPass / ajp://default_tomcat_1:8009/ retry=0
ProxyPassReverse / ajp://default_tomcat_1:8009/

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r1831390 - in /tomcat/tc8.5.x/trunk: ./ java/org/apache/coyote/http11/Http11InputBuffer.java

[markt]

Author: markt
Date: Fri May 11 08:34:55 2018
New Revision: 1831390

URL: http://svn.apache.org/viewvc?rev=1831390=rev
Log:
When the header limit is exceeded before the protocol is read (e.g. with 
excessive new lines before the request line), set the protocol to avoid the 
missing protocol triggering a 505 error masking the real error code.

Modified:
tomcat/tc8.5.x/trunk/   (props changed)
tomcat/tc8.5.x/trunk/java/org/apache/coyote/http11/Http11InputBuffer.java

Propchange: tomcat/tc8.5.x/trunk/
--
--- svn:mergeinfo (original)
+++ svn:mergeinfo Fri May 11 08:34:55 2018
@@ -1,2 +1,2 @@
 /tomcat/tc8.0.x/trunk:1809644
-/tomcat/trunk:1734785,1734799,1734845,1734928,1735041,1735044,1735480,1735577,1735597,1735599-1735600,1735615,1736145,1736162,1736209,1736280,1736297,1736299,1736489,1736646,1736703,1736836,1736849,1737104-1737105,1737112,1737117,1737119-1737120,1737155,1737157,1737192,1737280,1737339,1737632,1737664,1737715,1737748,1737785,1737834,1737860,1737903,1737959,1738005,1738007,1738014-1738015,1738018,1738022,1738039,1738043,1738059-1738060,1738147,1738149,1738174-1738175,1738261,1738589,1738623-1738625,1738643,1738816,1738850,1738855,1738946-1738948,1738953-1738954,1738979,1738982,1739079-1739081,1739087,1739113,1739153,1739172,1739176,1739191,1739474,1739492,1739726,1739762,1739775,1739814,1739817-1739818,1739975,1740131,1740324,1740465,1740495,1740508-1740509,1740520,1740535,1740707,1740803,1740810,1740969,1740980,1740991,1740997,1741015,1741033,1741036,1741058,1741060,1741080,1741147,1741159,1741164,1741173,1741181,1741190,1741197,1741202,1741208,1741213,1741221,1741225,1741232,1741409
 
,1741501,1741677,1741892,1741896,1741984,1742023,1742042,1742071,1742090,1742093,1742101,1742105,1742111,1742139,1742146,1742148,1742166,1742181,1742184,1742187,1742246,1742248-1742251,1742263-1742264,1742268,1742276,1742369,1742387,1742448,1742509-1742512,1742917,1742919,1742933,1742975-1742976,1742984,1742986,1743019,1743115,1743117,1743124-1743125,1743134,1743425,1743554,1743679,1743696-1743698,1743700-1743701,1744058,1744064-1744065,1744125,1744149,1744194,1744229,1744270,1744323,1744432,1744684,1744697,1744705,1744713,1744760,1744786,1745083,1745142-1745143,1745145,1745177,1745179-1745180,1745227,1745248,1745254,1745337,1745467,1745473,1745535,1745576,1745735,1745744,1746304,1746306-1746307,1746319,1746327,1746338,1746340-1746341,1746344,1746427,1746441,1746473,1746490,1746492,1746495-1746496,1746499-1746501,1746503-1746507,1746509,1746549,1746551,1746554,1746556,1746558,1746584,1746620,1746649,1746724,1746939,1746989,1747014,1747028,1747035,1747210,1747225,1747234,1747253,1747
 
404,1747506,1747536,1747924,1747980,1747993,1748001,1748253,1748452,1748547,1748629,1748676,1748715,1749287,1749296,1749328,1749373,1749465,1749506,1749508,1749665-1749666,1749763,1749865-1749866,1749898,1749978,1749980,1750011,1750015,1750056,1750480,1750617,1750634,1750692,1750697,1750700,1750703,1750707,1750714,1750718,1750723,1750774,1750899,1750975,1750995,1751061,1751097,1751173,1751438,1751447,1751463,1751702,1752212,1752737,1752745,1753078,1753080,1753358,1753363,1754111,1754140-1754141,1754281,1754310,1754445,1754467,1754494,1754496,1754528,1754532-1754533,1754613,1754714,1754874,1754941,1754944,1754950-1754951,1755005,1755007,1755009,1755132,1755180-1755181,1755185,1755190,1755204-1755206,1755208,1755214,1755224,1755227,1755230,1755629,1755646-1755647,1755650,1755653,1755675,1755680,1755683,1755693,1755717,1755731-1755737,1755812,1755828,1755884,1755890,1755918-1755919,1755942,1755958,1755960,1755970,1755993,1756013,1756019,1756039,1756056,1756083-1756114,1756175,1756288-1
 
756289,1756408-1756410,1756778,1756798,1756878,1756898,1756939,1757123-1757124,1757126,1757128,1757132-1757133,1757136,1757145,1757167-1757168,1757175,1757180,1757182,1757195,1757271,1757278,1757347,1757353-1757354,1757363,1757374,1757399,1757406,1757408,1757485,1757495,1757499,1757527,1757578,1757684,1757722,1757727,1757790,1757799,1757813,1757853,1757883,1757903,1757976,1757997,1758000,1758058,1758072-1758075,1758078-1758079,1758223,1758257,1758261,1758276,1758292,1758369,1758378-1758383,1758421,1758423,1758425-1758427,1758430,1758443,1758448,1758459,1758483,1758486-1758487,1758499,1758525,1758556,1758580,1758582,1758584,1758588,1758842,1759019,1759212,1759224,1759227,1759252,1759274,1759513-1759516,1759611,1759757,1759785-1759790,1760005,1760022,1760109-1760110,1760135,1760200-1760201,1760227,1760300,1760397,1760446,1760454,1760640,1760648,1761057,1761422,1761491,1761498,1761500-1761501,1761550,1761553,1761572,1761574,1761625-1761626,1761628,1761682,1761740,1761752,1762051-176205
 

svn commit: r1831389 - /tomcat/trunk/java/org/apache/coyote/http11/Http11InputBuffer.java

[markt]

Author: markt
Date: Fri May 11 08:34:21 2018
New Revision: 1831389

URL: http://svn.apache.org/viewvc?rev=1831389=rev
Log:
When the header limit is exceeded before the protocol is read (e.g. with 
excessive new lines before the request line), set the protocol to avoid the 
missing protocol triggering a 505 error masking the real error code.

Modified:
tomcat/trunk/java/org/apache/coyote/http11/Http11InputBuffer.java

Modified: tomcat/trunk/java/org/apache/coyote/http11/Http11InputBuffer.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/coyote/http11/Http11InputBuffer.java?rev=1831389=1831388=1831389=diff
==
--- tomcat/trunk/java/org/apache/coyote/http11/Http11InputBuffer.java (original)
+++ tomcat/trunk/java/org/apache/coyote/http11/Http11InputBuffer.java Fri May 
11 08:34:21 2018
@@ -711,6 +711,10 @@ public class Http11InputBuffer implement
 
 if (parsingHeader) {
 if (byteBuffer.limit() >= headerBufferSize) {
+if (parsingRequestLine) {
+// Avoid unknown protocol triggering an additional error
+request.protocol().setString(Constants.HTTP_11);
+}
 throw new 
IllegalArgumentException(sm.getString("iib.requestheadertoolarge.error"));
 }
 } else {



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: svn commit: r1830547 - in /tomcat/trunk: java/org/apache/coyote/Response.java java/org/apache/coyote/http11/Http11InputBuffer.java webapps/docs/changelog.xml

[Mark Thomas]

On 11/05/18 08:58, Rainer Jung wrote:
> Am 30.04.2018 um 12:57 schrieb ma...@apache.org:
>> Author: markt
>> Date: Mon Apr 30 10:57:27 2018
>> New Revision: 1830547
>>
>> URL: http://svn.apache.org/viewvc?rev=1830547=rev
>> Log:
>> Correct a regression in the error page handling that prevented error
>> pages from issuing redirects or taking other action that required the
>> response status code to be changed.
>>
>> Modified:
>>  tomcat/trunk/java/org/apache/coyote/Response.java
>>  tomcat/trunk/java/org/apache/coyote/http11/Http11InputBuffer.java
>>  tomcat/trunk/webapps/docs/changelog.xml
>>
>> Modified: tomcat/trunk/java/org/apache/coyote/Response.java
>> URL:
>> http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/coyote/Response.java?rev=1830547=1830546=1830547=diff
>>
>> ==
>>
>> --- tomcat/trunk/java/org/apache/coyote/Response.java (original)
>> +++ tomcat/trunk/java/org/apache/coyote/Response.java Mon Apr 30
>> 10:57:27 2018
>> @@ -227,10 +227,6 @@ public final class Response {
>>    * @param status The status value to set
>>    */
>>   public void setStatus(int status) {
>> -    if (this.status > 399) {
>> -    // Don't overwrite first recorded error status
>> -    return;
>> -    }
>>   this.status = status;
>>   }
> 
> This part of the patch makes TestHttp11InputBuffer fail for me, more
> precisely
> 
> Testcase: testNewLinesExcessive took 0.12 sec
>     FAILED
> HTTP/1.1 505
> junit.framework.AssertionFailedError: HTTP/1.1 505
>     at
> org.apache.coyote.http11.TestHttp11InputBuffer.testNewLinesExcessive(TestHttp11InputBuffer.java:385)

I can't repeat this but looking at the test is does look as if it might
depend on network behaviour.

> The test expects status 400, but gets 505. The 505 is being set in the
> following stack:
> 
> at org.apache.coyote.Response.setStatus(Response.java:231)
> at
> org.apache.coyote.http11.Http11Processor.prepareRequest(Http11Processor.java:588)

But I can put a break point here and catch this happening.

> at
> org.apache.coyote.http11.Http11Processor.service(Http11Processor.java:388)
> at
> org.apache.coyote.AbstractProcessorLight.process(AbstractProcessorLight.java:66)
> 
> at
> org.apache.coyote.AbstractProtocol$ConnectionHandler.process(AbstractProtocol.java:754)
> 
> ...
> 
> In prepareRequest(), the String protocolMB contains the text "null".
> 
> I don't know whether we just need to fix the test expectation, or tested
> code.

I think something along the lines of the r1830547 changes for
Http11InputBuffer should do the trick. I should be able to commit
something shortly.

Mark


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: svn commit: r1830547 - in /tomcat/trunk: java/org/apache/coyote/Response.java java/org/apache/coyote/http11/Http11InputBuffer.java webapps/docs/changelog.xml

[Rainer Jung]

Am 30.04.2018 um 12:57 schrieb ma...@apache.org:

Author: markt
Date: Mon Apr 30 10:57:27 2018
New Revision: 1830547

URL: http://svn.apache.org/viewvc?rev=1830547=rev
Log:
Correct a regression in the error page handling that prevented error pages from 
issuing redirects or taking other action that required the response status code 
to be changed.

Modified:
 tomcat/trunk/java/org/apache/coyote/Response.java
 tomcat/trunk/java/org/apache/coyote/http11/Http11InputBuffer.java
 tomcat/trunk/webapps/docs/changelog.xml

Modified: tomcat/trunk/java/org/apache/coyote/Response.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/coyote/Response.java?rev=1830547=1830546=1830547=diff
==
--- tomcat/trunk/java/org/apache/coyote/Response.java (original)
+++ tomcat/trunk/java/org/apache/coyote/Response.java Mon Apr 30 10:57:27 2018
@@ -227,10 +227,6 @@ public final class Response {
   * @param status The status value to set
   */
  public void setStatus(int status) {
-if (this.status > 399) {
-// Don't overwrite first recorded error status
-return;
-}
  this.status = status;
  }


This part of the patch makes TestHttp11InputBuffer fail for me, more 
precisely


Testcase: testNewLinesExcessive took 0.12 sec
FAILED
HTTP/1.1 505
junit.framework.AssertionFailedError: HTTP/1.1 505
at 
org.apache.coyote.http11.TestHttp11InputBuffer.testNewLinesExcessive(TestHttp11InputBuffer.java:385)


The test expects status 400, but gets 505. The 505 is being set in the 
following stack:


at org.apache.coyote.Response.setStatus(Response.java:231)
at 
org.apache.coyote.http11.Http11Processor.prepareRequest(Http11Processor.java:588)
at 
org.apache.coyote.http11.Http11Processor.service(Http11Processor.java:388)
at 
org.apache.coyote.AbstractProcessorLight.process(AbstractProcessorLight.java:66)
at 
org.apache.coyote.AbstractProtocol$ConnectionHandler.process(AbstractProtocol.java:754)

...

In prepareRequest(), the String protocolMB contains the text "null".

I don't know whether we just need to fix the test expectation, or tested 
code.


Regards,

Rainer

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: JDK 11 Early Access build 12 available

[Rory O'Donnell]

Thanks Mark, that is great to hear.

Rgds,Rory


On 08/05/2018 14:40, Mark Thomas wrote:

All,

I've just tried building with Java 11 and performing a very simple smoke
test (does the WebSocket snake game work).

The only issue I found was that the removal of the java.xml.ws module
meant that the utility class we use for working with the Symantec code
signing service would not compile. This blocked the main compilation
step as we compile everything together.

I have fixed this by pulling in the CDDL licensed SAAJ API 1.3.5 JAR.

This doesn't impact the overall licensing of Tomcat since the library is
only used to build/run the code signing tool used during the release
process. (And even if it did, we have other CDDL licensed dependencies
so it wouldn't be a big deal.)

Mark


On 08/05/18 09:14, Rory O'Donnell wrote:

Hi Mark,


**JDK 11 EA build 12 , *under both the GPL and Oracle EA licenses,
is now available at **http://jdk.java.net/11**. **
*

  * Newly approved Schedule, status & features
  o http://openjdk.java.net/projects/jdk/11/
  * Release Notes:
  o http://jdk.java.net/11/release-notes
  * Summary of changes
  o https://download.java.net/java/early_access/jdk11/12/jdk-11+12.html

*Notable changes in JDK 11 EA builds since last email:*

  * Build 11 - see Release Notes for details.
  o JDK-8201315 : SelectableChannel.register may be invoked while a
selection operation is in progress
  * Build 10 - see Release Notes for details.
  o JDK-8200149 : Removal of "com.sun.awt.AWTUtilities" class
  o JDK-8189997 (not public) :  Enhanced KeyStore Mechanisms
  o JDK-8175075 (not public) : 3DES Cipher Suites Disabled
  * Build 9: - see Release Notes for details.
  o JDK-8200152 : KerberosString uses UTF-8 encoding by default
  o JDK-8200458 : Readiness information previously recorded in
SelectionKey ready set not preserved

**


*Draft JEP: Deprecate pack200, unpack200 tools and related APIs. [1]
*
This draft JEP [2] proposes to deprecate the pack200 APIs and tools in
the JDK. As outlined in the JEP, the usefulness of this technology
have diminishing returns, the components using them are being removed
and connectivity speeds have improved by leaps and bounds,
since its inception.  Feedback appreciated via
http://mail.openjdk.java.net/pipermail/jdk-dev

Regards,
Rory

[1] http://mail.openjdk.java.net/pipermail/jdk-dev/2018-April/001074.html
[2] https://bugs.openjdk.java.net/browse/JDK-8200752

Rgds,Rory O'Donnell
Quality Engineering Manager
Oracle EMEA, Dublin,Ireland




--
Rgds,Rory O'Donnell
Quality Engineering Manager
Oracle EMEA, Dublin,Ireland


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

buildbot success in on tomcat-7-trunk

[buildbot]

The Buildbot has detected a restored build on builder tomcat-7-trunk while 
building . Full details are available at:
https://ci.apache.org/builders/tomcat-7-trunk/builds/1089

Buildbot URL: https://ci.apache.org/

Buildslave for this Build: silvanus_ubuntu

Build Reason: The AnyBranchScheduler scheduler named 'on-tomcat-7-commit' 
triggered this build
Build Source Stamp: [branch tomcat/tc7.0.x/trunk] 1831386
Blamelist: markt

Build succeeded!

Sincerely,
 -The Buildbot




-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r1831386 - in /tomcat/tc7.0.x/trunk/test: org/apache/naming/TestEnvEntry.java webapp-3.0-fragments/WEB-INF/web.xml

[markt]

Author: markt
Date: Fri May 11 06:33:48 2018
New Revision: 1831386

URL: http://svn.apache.org/viewvc?rev=1831386=rev
Log:
Follow-up to r1831352
Add additions to web.xml missed in original backport
Correct web-app path for 7.0.x

Modified:
tomcat/tc7.0.x/trunk/test/org/apache/naming/TestEnvEntry.java
tomcat/tc7.0.x/trunk/test/webapp-3.0-fragments/WEB-INF/web.xml

Modified: tomcat/tc7.0.x/trunk/test/org/apache/naming/TestEnvEntry.java
URL: 
http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/test/org/apache/naming/TestEnvEntry.java?rev=1831386=1831385=1831386=diff
==
--- tomcat/tc7.0.x/trunk/test/org/apache/naming/TestEnvEntry.java (original)
+++ tomcat/tc7.0.x/trunk/test/org/apache/naming/TestEnvEntry.java Fri May 11 
06:33:48 2018
@@ -93,7 +93,7 @@ public class TestEnvEntry extends Tomcat
 private void doTestJndiLookup(String jndiName, String expected) throws 
Exception {
 Tomcat tomcat = getTomcatInstance();
 
-File appDir = new File("test/webapp-fragments");
+File appDir = new File("test/webapp-3.0-fragments");
 tomcat.addWebapp(null, "/test", appDir.getAbsolutePath());
 
 tomcat.enableNaming();
@@ -114,7 +114,7 @@ public class TestEnvEntry extends Tomcat
 private void doTestJndiInjection(String injectionName, String expected) 
throws Exception {
 Tomcat tomcat = getTomcatInstance();
 
-File appDir = new File("test/webapp-fragments");
+File appDir = new File("test/webapp-3.0-fragments");
 Context context = tomcat.addWebapp(null, "/test", 
appDir.getAbsolutePath());
 
 Tomcat.addServlet(context, "InjectionServlet", 
"org.apache.naming.TesterInjectionServlet");

Modified: tomcat/tc7.0.x/trunk/test/webapp-3.0-fragments/WEB-INF/web.xml
URL: 
http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/test/webapp-3.0-fragments/WEB-INF/web.xml?rev=1831386=1831385=1831386=diff
==
--- tomcat/tc7.0.x/trunk/test/webapp-3.0-fragments/WEB-INF/web.xml (original)
+++ tomcat/tc7.0.x/trunk/test/webapp-3.0-fragments/WEB-INF/web.xml Fri May 11 
06:33:48 2018
@@ -86,4 +86,94 @@
 java.lang.Integer
 66
   
+  
+  
+injection
+org.apache.naming.TesterInjectionServlet
+  
+  
+injection
+/injection
+  
+
+  
+env-entry/basic
+java.lang.String
+basic-value
+  
+
+  
+env-entry/valid
+org.apache.naming.TesterEnvEntry
+valid
+  
+
+  
+env-entry/invalid
+org.apache.naming.TesterEnvEntry
+invalid
+  
+
+  
+env-entry/injectField
+java.lang.String
+inject-value-1
+
+  
org.apache.naming.TesterInjectionServlet
+  property1
+
+  
+
+  
+env-entry/injectProperty
+java.lang.String
+inject-value-2
+
+  
org.apache.naming.TesterInjectionServlet
+  property2
+
+  
+
+  
+env-entry/injectFieldNoType
+inject-value-3
+
+  
org.apache.naming.TesterInjectionServlet
+  property3
+
+  
+
+  
+env-entry/injectNoValue
+java.lang.String
+
+  
org.apache.naming.TesterInjectionServlet
+  property4
+
+  
+
+  
+env-entry/lookup
+java.lang.String
+java:comp/env/env-entry/basic
+  
+
+  
+env-entry/circular1
+java.lang.String
+java:comp/env/env-entry/circular2
+  
+
+  
+env-entry/circular2
+java.lang.String
+java:comp/env/env-entry/circular1
+  
+
+  
+env-entry/lookup-invalid
+java.lang.Integer
+java:comp/env/env-entry/basic
+  
+
 
\ No newline at end of file



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org