[GitHub] tomcat issue #107: underlying connection closed unexpectedly, so we must des...

2018-09-17 Thread dltc
Github user dltc commented on the issue: https://github.com/apache/tomcat/pull/107 mysql-drive close the connection while IOException occur. if testOnReturn is false the connection will have been returned to the pool and may have been borrowed by another thread --- ---

[GUMP@vmgump-vm3]: Project tomcat-trunk-test-nio (in module tomcat-trunk) failed

2018-09-17 Thread Bill Barker
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project tomcat-trunk-test-nio has an issue affecting its community integration. Th

Re: svn commit: r1840901 - /tomcat/trunk/java/org/apache/catalina/users/MemoryUserDatabase.java

2018-09-17 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Mark, On 9/17/18 08:34, Mark Thomas wrote: > On 17/09/18 10:50, Konstantin Kolinko wrote: > > > >> Implementing auto-reloading has a caveat: there is a race >> condition between an editor (that is used to update the file) and >> Tomcat. It may be

[GUMP@vmgump-vm3]: Project tomcat-trunk-test-nio (in module tomcat-trunk) failed

2018-09-17 Thread Bill Barker
n-1.1.1-SNAPSHOT.jar -Dtest.openssl.path=/srv/gump/public/workspace/openssl-master/dest-20180917/bin/openssl -Dtest.temp=output/test-tmp-NIO -Dtest.accesslog=true -Dexecute.test.nio=true -Dbnd.jar=/srv/gump/packages/bnd/bnd-4.0.0/biz.aQute.bnd-4.0.0.jar -Dexecute.test.apr=false -Dtest.excludePerformance=true -Dt

[GitHub] tomcat issue #122: Added a default value for ApplicationSessionCookieConfig#...

2018-09-17 Thread martin-g
Github user martin-g commented on the issue: https://github.com/apache/tomcat/pull/122 s/edge/age/ --- - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apac

[GitHub] tomcat issue #122: Added a default value for ApplicationSessionCookieConfig#...

2018-09-17 Thread bitstorm
Github user bitstorm commented on the issue: https://github.com/apache/tomcat/pull/122 To me specs are a little contradictory about this. They state that the default value is JSESSIONID but at the same time they allow to return a null if a custom value is not set for this parameter. S

[GitHub] tomcat issue #122: Added a default value for ApplicationSessionCookieConfig#...

2018-09-17 Thread solomax
Github user solomax commented on the issue: https://github.com/apache/tomcat/pull/122 +1 no-one like NPE :) --- - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@to

[Bug 62674] org.apache.jasper.JspC no longer compiles

2018-09-17 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62674 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

[GitHub] tomcat issue #122: Added a default value for ApplicationSessionCookieConfig#...

2018-09-17 Thread martin-g
Github user martin-g commented on the issue: https://github.com/apache/tomcat/pull/122 There is also nothing that says not to do it. The question is which behavior is better. IMO returning the actual value that is in use is much better than `null`. --- --

Re: svn commit: r1840901 - /tomcat/trunk/java/org/apache/catalina/users/MemoryUserDatabase.java

2018-09-17 Thread Mark Thomas
On 17/09/18 10:50, Konstantin Kolinko wrote: > Implementing auto-reloading has a caveat: there is a race condition > between an editor (that is used to update the file) and Tomcat. It may > be that Tomcat will try to read an incompletely written file. > > Also using a SAX parser + Digester, it

svn commit: r1841071 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/jasper/JspC.java webapps/docs/changelog.xml

2018-09-17 Thread markt
Author: markt Date: Mon Sep 17 12:32:07 2018 New Revision: 1841071 URL: http://svn.apache.org/viewvc?rev=1841071&view=rev Log: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=62674 Correct a regression in the stand-alone JSP compiler utility, JspC, caused by the fix for 53492, that caused the

svn commit: r1841070 - in /tomcat/tc8.5.x/trunk: ./ java/org/apache/jasper/JspC.java webapps/docs/changelog.xml

2018-09-17 Thread markt
Author: markt Date: Mon Sep 17 12:31:21 2018 New Revision: 1841070 URL: http://svn.apache.org/viewvc?rev=1841070&view=rev Log: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=62674 Correct a regression in the stand-alone JSP compiler utility, JspC, caused by the fix for 53492, that caused the

[GitHub] tomcat issue #122: Added a default value for ApplicationSessionCookieConfig#...

2018-09-17 Thread markt-asf
Github user markt-asf commented on the issue: https://github.com/apache/tomcat/pull/122 There is nothing in the spec that says Tomcat is required to do that. --- - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apach

[GitHub] tomcat issue #122: Added a default value for ApplicationSessionCookieConfig#...

2018-09-17 Thread martin-g
Github user martin-g commented on the issue: https://github.com/apache/tomcat/pull/122 The new question is "Should Tomcat call `#setName("JSESSIONID")` during start of an application (just after creation of `SessionCookieConfig`) ?" With the current behavior every application/framewor

svn commit: r1841069 - in /tomcat/trunk: java/org/apache/jasper/JspC.java webapps/docs/changelog.xml

2018-09-17 Thread markt
Author: markt Date: Mon Sep 17 12:19:37 2018 New Revision: 1841069 URL: http://svn.apache.org/viewvc?rev=1841069&view=rev Log: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=62674 Correct a regression in the stand-alone JSP compiler utility, JspC, caused by the fix for 53492, that caused the

[Bug 62674] org.apache.jasper.JspC no longer compiles

2018-09-17 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62674 --- Comment #13 from Mark Thomas --- Progress. If JspC is called directly using the Java task (rather than using the Ant Jasper task) and fork is set to true for the Java task then the hand will be observed. That it is necessary to use the Jav

Re: svn commit: r1840901 - /tomcat/trunk/java/org/apache/catalina/users/MemoryUserDatabase.java

2018-09-17 Thread Konstantin Kolinko
вс, 16 сент. 2018 г. в 23:20, Christopher Schultz : > > On 9/14/18 05:21, Mark Thomas wrote: > > On 14/09/18 10:07, Rémy Maucherat wrote: > >> On Fri, Sep 14, 2018 at 10:41 AM wrote: > >> > >>> Author: markt Date: Fri Sep 14 08:41:02 2018 New Revision: > >>> 1840901 > >>> > >>> URL: http://svn.apa

[GitHub] tomcat issue #122: Added a default value for ApplicationSessionCookieConfig#...

2018-09-17 Thread bitstorm
Github user bitstorm commented on the issue: https://github.com/apache/tomcat/pull/122 @kkolinko Thank you for the clarification! --- - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additio

Re: svn commit: r1840901 - /tomcat/trunk/java/org/apache/catalina/users/MemoryUserDatabase.java

2018-09-17 Thread Mark Thomas
On 16/09/18 21:20, Christopher Schultz wrote: > Mark, > > On 9/14/18 05:21, Mark Thomas wrote: >> On 14/09/18 10:07, Rémy Maucherat wrote: >>> On Fri, Sep 14, 2018 at 10:41 AM wrote: >>> Author: markt Date: Fri Sep 14 08:41:02 2018 New Revision: 1840901 URL: http://svn.apache.

[Bug 58072] ECDH curve selection

2018-09-17 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=58072 --- Comment #4 from Remy Maucherat --- The newly added OpenSSLConfCmd feature has something for this. I think this should be considered "done" as JSSE isn't going to get done. -- You are receiving this mail because: You are the assignee for t

[GitHub] tomcat pull request #122: Added a default value for ApplicationSessionCookie...

2018-09-17 Thread markt-asf
Github user markt-asf closed the pull request at: https://github.com/apache/tomcat/pull/122 --- - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

[GitHub] tomcat issue #122: Added a default value for ApplicationSessionCookieConfig#...

2018-09-17 Thread markt-asf
Github user markt-asf commented on the issue: https://github.com/apache/tomcat/pull/122 Closing the PR as the requested change is not correct. --- - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For addit

[Bug 62674] org.apache.jasper.JspC no longer compiles

2018-09-17 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62674 --- Comment #12 from Mark Thomas --- The relevant information is: ... with new the multithreaded JspC implementation in Tomcat 8.5.33, invoking it from an ant script as we do (with fork=true), the JVM never exits, presumably because the Tomca

[GitHub] tomcat issue #122: Added a default value for ApplicationSessionCookieConfig#...

2018-09-17 Thread kkolinko
Github user kkolinko commented on the issue: https://github.com/apache/tomcat/pull/122 The javadoc that you linked https://docs.oracle.com/javaee/7/api/javax/servlet/SessionCookieConfig.html says "Returns: [...] or null if setName(java.lang.String) was never called" Thu