[GitHub] [tomcat] zhanhb closed pull request #174: Clean method parseRange

2019-06-25 Thread GitBox
zhanhb closed pull request #174: Clean method parseRange URL: https://github.com/apache/tomcat/pull/174 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [tomcat] zhanhb closed pull request #175: Apply the suggestion in rfc7233

2019-06-25 Thread GitBox
zhanhb closed pull request #175: Apply the suggestion in rfc7233 URL: https://github.com/apache/tomcat/pull/175 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [tomcat] 01/02: Back-port spotbugs fixes

2019-06-25 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Mark, On 6/24/19 05:58, ma...@apache.org wrote: > This is an automated email from the ASF dual-hosted git > repository. > > markt pushed a commit to branch 8.5.x in repository > https://gitbox.apache.org/repos/asf/tomcat.git > > commit

[Bug 63528] WsFilter.destroy() missing (SpringJUnit4ClassRunner)

2019-06-25 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63528 Mark Thomas changed: What|Removed |Added OS||All Resolution|---

[Bug 63528] New: WsFilter.destroy() missing (SpringJUnit4ClassRunner)

2019-06-25 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63528 Bug ID: 63528 Summary: WsFilter.destroy() missing (SpringJUnit4ClassRunner) Product: Tomcat 9 Version: 9.0.21 Hardware: PC Status: NEW Severity: normal

[tomcat] branch master updated: Missed one

2019-06-25 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/master by this push: new 861a4d0 Missed one 861a4d0 is described below

[tomcat] branch master updated: Fix test for running onm platforms with different line endings

2019-06-25 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/master by this push: new c848a3a Fix test for running onm platforms with

[tomcat-native] branch master updated: Document change in min OpenSSL version

2019-06-25 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat-native.git The following commit(s) were added to refs/heads/master by this push: new 38b79ee Document change in min OpenSSL

[tomcat-native] 01/03: Correct format

2019-06-25 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat-native.git commit 39710ef04ee59b303541c431996a7bc1c5190cb7 Author: Mark Thomas AuthorDate: Tue Jun 25 18:52:51 2019 +0100

[tomcat-native] branch master updated (f03ed09 -> 7213f5f)

2019-06-25 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/tomcat-native.git. from f03ed09 Bump the minimum OpenSSL version new 39710ef Correct format new 92cf459 Document change

[tomcat-native] 03/03: Add flag to pick up intended version of function.

2019-06-25 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat-native.git commit 7213f5f38b71ef8aac0b3673a18bae0053fa8f18 Author: Mark Thomas AuthorDate: Tue Jun 25 18:54:01 2019 +0100 Add

[tomcat-native] 02/03: Document change in default target

2019-06-25 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat-native.git commit 92cf459c1865f534e1cffeb938298c6f4bfaf853 Author: Mark Thomas AuthorDate: Tue Jun 25 18:53:31 2019 +0100

[tomcat-native] branch master updated: Bump the minimum OpenSSL version

2019-06-25 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat-native.git The following commit(s) were added to refs/heads/master by this push: new f03ed09 Bump the minimum OpenSSL version

[CONF] Apache Tomcat > Building the Tomcat Native Connector binaries for Windows

2019-06-25 Thread Mark Thomas (Confluence)
Title: Message Title There's 1 new edit on this page   Building the Tomcat Native Connector binaries for Windows Mark Thomas edited this page

[CONF] Apache Tomcat > Building the Tomcat Native Connector binaries for Windows

2019-06-25 Thread Mark Thomas (Confluence)
Title: Message Title There's 1 new edit on this page   Building the Tomcat Native Connector binaries for Windows Mark Thomas edited this page

[tomcat-native] branch master updated (8301a9b -> d2bbada)

2019-06-25 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/tomcat-native.git. from 8301a9b Update Java code to latest from 9.0.x new 867d52c Increment version info ready for next

[tomcat-native] 02/02: Make file fixes to enable building with APR 1.7.x

2019-06-25 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat-native.git commit d2bbadafe6fda3c216580e8a00251fdf3ce18202 Author: Mark Thomas AuthorDate: Tue Jun 25 17:13:27 2019 +0100 Make

[tomcat-native] 01/02: Increment version info ready for next development cycle

2019-06-25 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat-native.git commit 867d52c04697d6f8a32f5bcf1846616a2e46fc1b Author: Mark Thomas AuthorDate: Tue Jun 25 17:12:10 2019 +0100

Re: [tomcat-native] 01/01: Tag 1.2.22

2019-06-25 Thread Mark Thomas
On 25/06/2019 15:48, ma...@apache.org wrote: > This is an automated email from the ASF dual-hosted git repository. > > markt pushed a commit to tag 1.2.22 > in repository https://gitbox.apache.org/repos/asf/tomcat-native.git > > commit ce0efe134673fa3094128ef74bca0a34cb0c8726 > Author: Mark

[tomcat-native] 01/01: Tag 1.2.22

2019-06-25 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to tag 1.2.22 in repository https://gitbox.apache.org/repos/asf/tomcat-native.git commit ce0efe134673fa3094128ef74bca0a34cb0c8726 Author: Mark Thomas AuthorDate: Tue Jun 25 15:40:55 2019 +0100 Tag

[tomcat-native] tag 1.2.22 created (now ce0efe1)

2019-06-25 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a change to tag 1.2.22 in repository https://gitbox.apache.org/repos/asf/tomcat-native.git. at ce0efe1 (commit) This tag includes the following new commits: new ce0efe1 Tag 1.2.22 The 1 revisions

[tomcat-native] branch master updated: Update Java code to latest from 9.0.x

2019-06-25 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat-native.git The following commit(s) were added to refs/heads/master by this push: new 8301a9b Update Java code to latest from

[tomcat-native] branch master updated: Link to 9.0.x docs for APR rather than 8.0.x

2019-06-25 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat-native.git The following commit(s) were added to refs/heads/master by this push: new bd3e661 Link to 9.0.x docs for APR

[tomcat-native] 01/02: Add Java test files

2019-06-25 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat-native.git commit 80f264c3d4a7a0b75cf147e5e0f1a64858ca1f44 Author: Mark Thomas AuthorDate: Tue Jun 25 14:44:45 2019 +0100 Add

[tomcat-native] branch master updated (a127b2c -> 0e33997)

2019-06-25 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/tomcat-native.git. from a127b2c Update release script for svn->git migration new 80f264c Add Java test files new 0e33997

[tomcat-native] 02/02: Update .gitignore

2019-06-25 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat-native.git commit 0e33997c741fcedc8d637b5ead961a062a804e60 Author: Mark Thomas AuthorDate: Tue Jun 25 14:45:09 2019 +0100

[CONF] Apache Tomcat > Tomcat Native - Java code

2019-06-25 Thread Mark Thomas (Confluence)
Title: Message Title There's 1 new edit on this page   Tomcat Native - Java code Mark Thomas edited this page Here's the version

buildbot success in on tomcat-trunk

2019-06-25 Thread buildbot
The Buildbot has detected a restored build on builder tomcat-trunk while building tomcat. Full details are available at: https://ci.apache.org/builders/tomcat-trunk/builds/4453 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The

[tomcat-native] branch master updated: Update release script for svn->git migration

2019-06-25 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat-native.git The following commit(s) were added to refs/heads/master by this push: new a127b2c Update release script for

[tomcat] branch master updated: Clean-up. Trivial change to test native build script

2019-06-25 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/master by this push: new dc324d8 Clean-up. Trivial change to test native

[GitHub] [tomcat] markt-asf commented on issue #174: Clean method parseRange

2019-06-25 Thread GitBox
markt-asf commented on issue #174: Clean method parseRange URL: https://github.com/apache/tomcat/pull/174#issuecomment-505391878 Partial PUT vs PATCH should be a separate topic. It will require careful consideration as some clients may depend on PUT. Support for multiple ranges

buildbot failure in on tomcat-trunk

2019-06-25 Thread buildbot
The Buildbot has detected a new failure on builder tomcat-trunk while building tomcat. Full details are available at: https://ci.apache.org/builders/tomcat-trunk/builds/4452 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The AnyBranchScheduler

[tomcat] branch master updated: Comment out the most optional dependencies

2019-06-25 Thread remm
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/master by this push: new 4a747ed Comment out the most optional

[GitHub] [tomcat] zhanhb commented on issue #174: Clean method parseRange

2019-06-25 Thread GitBox
zhanhb commented on issue #174: Clean method parseRange URL: https://github.com/apache/tomcat/pull/174#issuecomment-505359318 My suggestion for multiple range support: support is enough, don't let it be an entrance for DDOS attack. For this feature is specified in rfc document, many

[GitHub] [tomcat] zhanhb commented on issue #174: Clean method parseRange

2019-06-25 Thread GitBox
zhanhb commented on issue #174: Clean method parseRange URL: https://github.com/apache/tomcat/pull/174#issuecomment-505352885 Here's how I parse request `Range` now, glad if this can help you.

[GitHub] [tomcat] zhanhb commented on issue #174: Clean method parseRange

2019-06-25 Thread GitBox
zhanhb commented on issue #174: Clean method parseRange URL: https://github.com/apache/tomcat/pull/174#issuecomment-505350158 If strong weak tag is implemented, maybe strong etag validator can be applied on header `If-Range`. Just maybe, we can see on the client side, chrome doesn't do

[GitHub] [tomcat] zhanhb edited a comment on issue #172: Process request range as specified in RFC 7233

2019-06-25 Thread GitBox
zhanhb edited a comment on issue #172: Process request range as specified in RFC 7233 URL: https://github.com/apache/tomcat/pull/172#issuecomment-504718438 Before I write unit tests, maybe I need to explain what I my PR do. -

[GitHub] [tomcat] zhanhb edited a comment on issue #174: Clean method parseRange

2019-06-25 Thread GitBox
zhanhb edited a comment on issue #174: Clean method parseRange URL: https://github.com/apache/tomcat/pull/174#issuecomment-505345715 Here's a test case for PUT, no other cases yet now. (Maybe need to migrate to PATCH in the future) ```sh # got 201 or 204 curl -i -X PUT --header

[GitHub] [tomcat] zhanhb edited a comment on issue #174: Clean method parseRange

2019-06-25 Thread GitBox
zhanhb edited a comment on issue #174: Clean method parseRange URL: https://github.com/apache/tomcat/pull/174#issuecomment-505345715 Here's a test case for PUT, no other cases yet now. (Maybe need to migrate to PATCH in the future) ```sh curl -i -X PUT --header 'Content-Range:

[GitHub] [tomcat] zhanhb commented on issue #174: Clean method parseRange

2019-06-25 Thread GitBox
zhanhb commented on issue #174: Clean method parseRange URL: https://github.com/apache/tomcat/pull/174#issuecomment-505345715 Here's a test case for PUT, no other cases yet now. ```sh curl -i -X PUT --header 'Content-Range: bytes=1-5/4' --data 'abcdef'

[GitHub] [tomcat] markt-asf commented on issue #174: Clean method parseRange

2019-06-25 Thread GitBox
markt-asf commented on issue #174: Clean method parseRange URL: https://github.com/apache/tomcat/pull/174#issuecomment-505343860 I've re-written the Range header parsing using the code in org.apache.tomcat.util.http.parser and adding a new parser for Range. There is scope for further code

[tomcat] branch master updated: Improve parsing of Range request headers

2019-06-25 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/master by this push: new 276faa5 Improve parsing of Range request