Re: [DISCUSS] Remove org.apache.catalina.servlet4preview from 8.5.x

2019-12-01 Thread Mark Thomas 
On 27/11/2019 17:07, Rémy Maucherat wrote:
> On Wed, Nov 27, 2019 at 6:06 PM Mark Thomas  > wrote:
> 
> Hi all,
> 
> The Servlet 4 preview API in 8.5.x has been deprecated for over a year.
> It was also inconsistent with the final Servlet 4.0 API until I fixed it
> in 8.5.49 although no-one complained about the inconsistency.
> 
> I'd like to propose removing the code completely.
> 
> I know this is an unusual thing to do in a point release - hence this
> discussion thread. My reasoning is:
> 
> - Anyone who wants Servlet 4 will have moved to 9.0.x already
> 
> - The servlet4preview has been deprecated for over a year
> 
> - We warned that it would be removed from 8.5.x at some point when we
>   deprecated it.
> 
> - If people were using it, they would have complained that the API was
>   wrong and no complaints were received. (At least I don't recall any.)
> 
> - It adds unnecessary complexity to the 8.5.x code.
> 
> - I like deleting code ;)
> 
> 
> :)
> 
> 
> Thoughts?
> 
> 
> +1, try it.

I think I'll aim to do this not for the next 8.5.x release but the one
after that.

Mark

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: Initial set of patches for Jakarta EE 9

2019-12-01 Thread Mark Thomas 
On 30/11/2019 21:11, Igal Sapir wrote:
> Mark,
> 
> On 11/28/2019 11:46 AM, Mark Thomas wrote:
>> Hi all,
>>
>> I have pushed an initial set of patches for Jakarta EE 9 here:
>> https://github.com/markt-asf/tomcat/tree/jakarta
>>
>> The current status is:
>> - All the packages changing in Jakarta EE 9 have been renamed
>> - Any associated constants, service loader files etc. have also been
>>    renamed
>> - It builds
>> - The unit tests pass (excluding those that depend on JSTL - more on
>>    that below)
>> - A basic smoke test passes
>>
>> Please try and build it, take it for a spin and report back on this
>> thread if you find any issues.
> 
> First issue I noticed when trying to build on Windows:
> 
> compile:
>     [javac] Compiling 1727 source files to
> E:\Workspace\test\tomcat-jakarta\output\classes
>     [javac]
> E:\Workspace\test\tomcat-jakarta\java\org\apache\tomcat\util\http\RequestUtil.java:21:
> error: package javax.servlet.http does not exist
>     [javac] import javax.servlet.http.HttpServletRequest;
>     [javac]  ^
>     [javac]
> E:\Workspace\test\tomcat-jakarta\java\org\apache\tomcat\util\http\RequestUtil.java:122:
> error: cannot find symbol
>     [javac] public static boolean isSameOrigin(HttpServletRequest
> request, String origin) {
>     [javac]    ^
>     [javac]   symbol:   class HttpServletRequest
>     [javac]   location: class RequestUtil
>     [javac] Note: Some input files use or override a deprecated API.
>     [javac] Note: Recompile with -Xlint:deprecation for details.
>     [javac] 2 errors
> 
> BUILD FAILED
> E:\Workspace\test\tomcat-jakarta\build.xml:706: Compile failed; see the
> compiler error output for details.

Sorry. My error. When I rebased the branch I forgot to check if any
additional changes were required. I've fixed this now. Note I used a
force push to try and keep to the one commit per package I used originally.

Should be OK now.

Mark

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[GitHub] [tomcat] govi20 opened a new pull request #227: Unit test FileStore utility methods

2019-12-01 Thread GitBox 
govi20 opened a new pull request #227: Unit test FileStore utility methods
URL: https://github.com/apache/tomcat/pull/227
 
 
   Unit test FileStore utility methods and Refactor classic for loops in 
FIleStore.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org