[Bug 66324] New: HttpServletRequest.getRequestURI returns null

2022-10-25 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=66324 Bug ID: 66324 Summary: HttpServletRequest.getRequestURI returns null Product: Tomcat 9 Version: unspecified Hardware: PC OS: Linux Status: NEW

[GitHub] [tomcat-jakartaee-migration] DanielThomas commented on pull request #36: Improve composability when using from other tools

2022-10-25 Thread GitBox
DanielThomas commented on PR #36: URL: https://github.com/apache/tomcat-jakartaee-migration/pull/36#issuecomment-1291438441 Awesome, thanks much for the feedback! It's a much better PR for it. -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [tomcat-jakartaee-migration] DanielThomas commented on a diff in pull request #36: Improve composability when using from other tools

2022-10-25 Thread GitBox
DanielThomas commented on code in PR #36: URL: https://github.com/apache/tomcat-jakartaee-migration/pull/36#discussion_r1005164436 ## src/main/java/org/apache/tomcat/jakartaee/ManifestConverter.java: ## @@ -48,20 +48,16 @@ public boolean accepts(String filename) { }

[GitHub] [tomcat-jakartaee-migration] DanielThomas commented on a diff in pull request #36: Improve composability when using from other tools

2022-10-25 Thread GitBox
DanielThomas commented on code in PR #36: URL: https://github.com/apache/tomcat-jakartaee-migration/pull/36#discussion_r1005164436 ## src/main/java/org/apache/tomcat/jakartaee/ManifestConverter.java: ## @@ -48,20 +48,16 @@ public boolean accepts(String filename) { }

[GitHub] [tomcat-jakartaee-migration] DanielThomas commented on a diff in pull request #36: Improve composability when using from other tools

2022-10-25 Thread GitBox
DanielThomas commented on code in PR #36: URL: https://github.com/apache/tomcat-jakartaee-migration/pull/36#discussion_r1005164436 ## src/main/java/org/apache/tomcat/jakartaee/ManifestConverter.java: ## @@ -48,20 +48,16 @@ public boolean accepts(String filename) { }

[GitHub] [tomcat-jakartaee-migration] DanielThomas commented on a diff in pull request #36: Improve composability when using from other tools

2022-10-25 Thread GitBox
DanielThomas commented on code in PR #36: URL: https://github.com/apache/tomcat-jakartaee-migration/pull/36#discussion_r1005164436 ## src/main/java/org/apache/tomcat/jakartaee/ManifestConverter.java: ## @@ -48,20 +48,16 @@ public boolean accepts(String filename) { }

[GitHub] [tomcat-jakartaee-migration] DanielThomas commented on a diff in pull request #36: Improve composability when using from other tools

2022-10-25 Thread GitBox
DanielThomas commented on code in PR #36: URL: https://github.com/apache/tomcat-jakartaee-migration/pull/36#discussion_r1005151612 ## src/main/java/org/apache/tomcat/jakartaee/ManifestConverter.java: ## @@ -48,20 +48,16 @@ public boolean accepts(String filename) { }

[GitHub] [tomcat-jakartaee-migration] DanielThomas commented on a diff in pull request #36: Improve composability when using from other tools

2022-10-25 Thread GitBox
DanielThomas commented on code in PR #36: URL: https://github.com/apache/tomcat-jakartaee-migration/pull/36#discussion_r1005151612 ## src/main/java/org/apache/tomcat/jakartaee/ManifestConverter.java: ## @@ -48,20 +48,16 @@ public boolean accepts(String filename) { }

[GitHub] [tomcat-jakartaee-migration] DanielThomas commented on a diff in pull request #36: Improve composability when using from other tools

2022-10-25 Thread GitBox
DanielThomas commented on code in PR #36: URL: https://github.com/apache/tomcat-jakartaee-migration/pull/36#discussion_r1005151612 ## src/main/java/org/apache/tomcat/jakartaee/ManifestConverter.java: ## @@ -48,20 +48,16 @@ public boolean accepts(String filename) { }

[GitHub] [tomcat-jakartaee-migration] DanielThomas commented on a diff in pull request #36: Improve composability when using from other tools

2022-10-25 Thread GitBox
DanielThomas commented on code in PR #36: URL: https://github.com/apache/tomcat-jakartaee-migration/pull/36#discussion_r1005151612 ## src/main/java/org/apache/tomcat/jakartaee/ManifestConverter.java: ## @@ -48,20 +48,16 @@ public boolean accepts(String filename) { }

[GitHub] [tomcat-jakartaee-migration] aooohan commented on a diff in pull request #36: Improve composability when using from other tools

2022-10-25 Thread GitBox
aooohan commented on code in PR #36: URL: https://github.com/apache/tomcat-jakartaee-migration/pull/36#discussion_r1005142148 ## src/main/java/org/apache/tomcat/jakartaee/ManifestConverter.java: ## @@ -48,20 +48,16 @@ public boolean accepts(String filename) { }

Re: [DISCUSS] EOL date for 8.5.x

2022-10-25 Thread David Blevins
> On Oct 21, 2022, at 12:12 PM, Christopher Schultz > wrote: > > I'm wondering if I should migrate my applications to 9.0 or 10.x and start > re-writing imports. The flexibility of Tomcat 10.x is just incredible. I'm > kind of leaning toward skipping 9.x. Do it! :) -David smime.p7s

Re: [DISCUSS] EOL date for 8.5.x

2022-10-25 Thread David Blevins
> On Oct 7, 2022, at 2:27 AM, Mark Thomas wrote: > > Hi all, > > I don't think there is a need to make a decision on this quickly, but based > on past experience and the current discussions about Jakarta EE 11 I think > this is something we need to start thinking about. > > Some key facts: >

[GitHub] [tomcat-jakartaee-migration] DanielThomas commented on a diff in pull request #36: Improve composability when using from other tools

2022-10-25 Thread GitBox
DanielThomas commented on code in PR #36: URL: https://github.com/apache/tomcat-jakartaee-migration/pull/36#discussion_r1005100601 ## src/main/java/org/apache/tomcat/jakartaee/ManifestConverter.java: ## @@ -112,7 +107,7 @@ private boolean updateValues(Attributes attributes,

[GitHub] [tomcat-jakartaee-migration] DanielThomas commented on a diff in pull request #36: Improve composability when using from other tools

2022-10-25 Thread GitBox
DanielThomas commented on code in PR #36: URL: https://github.com/apache/tomcat-jakartaee-migration/pull/36#discussion_r1005100601 ## src/main/java/org/apache/tomcat/jakartaee/ManifestConverter.java: ## @@ -112,7 +107,7 @@ private boolean updateValues(Attributes attributes,

[GitHub] [tomcat-jakartaee-migration] DanielThomas commented on a diff in pull request #36: Improve composability when using from other tools

2022-10-25 Thread GitBox
DanielThomas commented on code in PR #36: URL: https://github.com/apache/tomcat-jakartaee-migration/pull/36#discussion_r1005100601 ## src/main/java/org/apache/tomcat/jakartaee/ManifestConverter.java: ## @@ -112,7 +107,7 @@ private boolean updateValues(Attributes attributes,

[Bug 66323] New: JDK_JAVA_OPTIONS grows unboundedly if webapp restarts Tomcat

2022-10-25 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=66323 Bug ID: 66323 Summary: JDK_JAVA_OPTIONS grows unboundedly if webapp restarts Tomcat Product: Tomcat 9 Version: 9.0.65 Hardware: PC OS: Linux

Re: November release round

2022-10-25 Thread Rémy Maucherat
On Tue, Oct 25, 2022 at 5:52 PM Mark Thomas wrote: > > Hi all, > > I've just seen the heads up from the OpenSSL project that there will be > a 3.0.7 release on 2022-12-01 that will address a critical > vulnerability. We won't know the details of the vulnerability until the > release announcement.

November release round

2022-10-25 Thread Mark Thomas
Hi all, I've just seen the heads up from the OpenSSL project that there will be a 3.0.7 release on 2022-12-01 that will address a critical vulnerability. We won't know the details of the vulnerability until the release announcement. Given that it may trigger a Tomcat Native release my

Re: Migrating away from Travis CI

2022-10-25 Thread Rémy Maucherat
On Tue, Oct 25, 2022 at 10:01 AM Mark Thomas wrote: > > Hi all, > > Infra have notified us that we need to migrate off Travis CI. The > recommended replacement is GitHub actions. > > We are already using GitHub actions as a smoke test and we also have > BuiltBot and Gump providing CI. > > Travis

[GitHub] [tomcat-jakartaee-migration] rmaucher commented on pull request #36: Improve composability when using from other tools

2022-10-25 Thread GitBox
rmaucher commented on PR #36: URL: https://github.com/apache/tomcat-jakartaee-migration/pull/36#issuecomment-1290577491 This looks like a very good improvement overall. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Migrating away from Travis CI

2022-10-25 Thread Mark Thomas
Hi all, Infra have notified us that we need to migrate off Travis CI. The recommended replacement is GitHub actions. We are already using GitHub actions as a smoke test and we also have BuiltBot and Gump providing CI. Travis provides access to ARM64, s390x and ppc64le which do not appear

[GitHub] [tomcat-jakartaee-migration] aooohan commented on a diff in pull request #36: Improve composability when using from other tools

2022-10-25 Thread GitBox
aooohan commented on code in PR #36: URL: https://github.com/apache/tomcat-jakartaee-migration/pull/36#discussion_r1004090783 ## src/main/java/org/apache/tomcat/jakartaee/ManifestConverter.java: ## @@ -48,20 +48,16 @@ public boolean accepts(String filename) { }

[GitHub] [tomcat-jakartaee-migration] aooohan commented on a diff in pull request #36: Improve composability when using from other tools

2022-10-25 Thread GitBox
aooohan commented on code in PR #36: URL: https://github.com/apache/tomcat-jakartaee-migration/pull/36#discussion_r1004090783 ## src/main/java/org/apache/tomcat/jakartaee/ManifestConverter.java: ## @@ -48,20 +48,16 @@ public boolean accepts(String filename) { }

[Bug 66320] NPE in checkResources

2022-10-25 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=66320 Mark Thomas changed: What|Removed |Added Resolution|--- |INVALID Status|REOPENED

[GitHub] [tomcat-jakartaee-migration] aooohan commented on a diff in pull request #36: Improve composability when using from other tools

2022-10-25 Thread GitBox
aooohan commented on code in PR #36: URL: https://github.com/apache/tomcat-jakartaee-migration/pull/36#discussion_r1004088967 ## src/main/java/org/apache/tomcat/jakartaee/ManifestConverter.java: ## @@ -112,7 +107,7 @@ private boolean updateValues(Attributes attributes,