CrazyHZM commented on code in PR #501:
URL: https://github.com/apache/tomcat/pull/501#discussion_r847005884
##
java/org/apache/coyote/http11/AbstractHttp11Protocol.java:
##
@@ -244,6 +244,34 @@ public void setMaxSavePostSize(int maxSavePostSize) {
public void setMaxHttpHead
rmaucher commented on PR #501:
URL: https://github.com/apache/tomcat/pull/501#issuecomment-1094622549
That seems pretty straightforward. I'm slightly skeptical about the real
practical use since trying to optimize the sizes too much is risky, but no
problem, this is the user's responsibilit
gmshake commented on code in PR #501:
URL: https://github.com/apache/tomcat/pull/501#discussion_r846991658
##
java/org/apache/coyote/http11/AbstractHttp11Protocol.java:
##
@@ -244,6 +244,34 @@ public void setMaxSavePostSize(int maxSavePostSize) {
public void setMaxHttpHeade
CrazyHZM opened a new pull request, #502:
URL: https://github.com/apache/tomcat/pull/502
Mail link：https://bz.apache.org/bugzilla/show_bug.cgi?id=65866
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
CrazyHZM commented on PR #501:
URL: https://github.com/apache/tomcat/pull/501#issuecomment-1094598895
Please review the code first, if there is no problem, I will support this on
other branches as well.
--
This is an automated message from the Apache Git Service.
To respond to the message
CrazyHZM opened a new pull request, #501:
URL: https://github.com/apache/tomcat/pull/501
Mail link：https://bz.apache.org/bugzilla/show_bug.cgi?id=65866
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL ab
dependabot[bot] opened a new pull request, #3:
URL: https://github.com/apache/tomcat-training/pull/3
Bumps [minimist](https://github.com/substack/minimist) from 0.0.8 to 1.2.6.
Commits
https://github.com/substack/minimist/commit/7efb22a518b53b06f5b02a1038a88bd6290c2846";>7efb22a
leggiero commented on PR #495:
URL: https://github.com/apache/tomcat/pull/495#issuecomment-1093126687
@isapir Just opened them :+1:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific c
leggiero closed pull request #497: Minor typo on javadoc of setHostHeader method
URL: https://github.com/apache/tomcat/pull/497
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
leggiero opened a new pull request, #497:
URL: https://github.com/apache/tomcat/pull/497
- This file should only be in the main branch
- Version updates
- Remove testing support for old OpenSSL versions
- Code clean-up: Add braces for clarity
- Code clean-up: Add braces for clarit
leggiero opened a new pull request, #496:
URL: https://github.com/apache/tomcat/pull/496
- Minor typo on javadoc of setHostHeader method
- Fix URL to Tomcat Versions page redirection
- Fix URL to Tomcat Versions page redirection
--
This is an automated message from the Apache Git
dsoumis opened a new pull request, #12:
URL: https://github.com/apache/tomcat-native/pull/12
By adding cd $(dirname $0) , user can run script from external directory and
not having issues with the actual location of deps directory.
--
This is an automated message from the Apache Git Servi
isapir commented on PR #495:
URL: https://github.com/apache/tomcat/pull/495#issuecomment-1092290696
@leggiero Can you do the same for the other active branches?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL a
isapir merged PR #495:
URL: https://github.com/apache/tomcat/pull/495
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
rmaucher closed pull request #494: Update BUILDING.txt
URL: https://github.com/apache/tomcat/pull/494
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: de
rmaucher commented on PR #494:
URL: https://github.com/apache/tomcat/pull/494#issuecomment-1091648175
Ok, this is now integrated, after fixing another item.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
dsoumis opened a new pull request, #494:
URL: https://github.com/apache/tomcat/pull/494
Regarding build.xml , there is not "native" directory in default path.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abo
suhail-1997 opened a new issue, #25:
URL: https://github.com/apache/tomcat-jakartaee-migration/issues/25
Im trying to upgrade spring web app to tomcat 10 for the upgrade im using
apache jakarta migration tool. the application got successfully migrated using
this tool but when i run the appl
be-hase commented on PR #493:
URL: https://github.com/apache/tomcat/pull/493#issuecomment-1091012924
[off topic]
For
[Spring4Shell](https://spring.io/blog/2022/03/31/spring-framework-rce-early-announcement),
I did a version up of Spring Boot. Then I met this `Shift_JIS` problem. 😭
Oliverwqcwrw closed pull request #492: Remove redundant 'of'
URL: https://github.com/apache/tomcat/pull/492
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-ma
be-hase commented on PR #493:
URL: https://github.com/apache/tomcat/pull/493#issuecomment-1090173899
Sorry, I'm not familiar with full history. I would be grateful if you could
consider this issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, ple
markt-asf commented on PR #493:
URL: https://github.com/apache/tomcat/pull/493#issuecomment-1090159236
This needs careful thought as the mapping was added to address a TCK
failure. We need to look into the full history to figure out the right fix.
--
This is an automated message from the
be-hase opened a new pull request, #493:
URL: https://github.com/apache/tomcat/pull/493
## Motivation
With this commit, `Shift_JIS` is now used as the default for `jp`.
eda77cd88b84d6002d9efb818e6d3fbc241e2284
`Shift_JIS` is a legacy character code, and this change causes a b
Oliverwqcwrw closed pull request #491: Fix method comment's grammar
URL: https://github.com/apache/tomcat/pull/491
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscrib
markt-asf commented on pull request #490:
URL: https://github.com/apache/tomcat/pull/490#issuecomment-1086097717
Thanke for spotting this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spe
markt-asf edited a comment on pull request #490:
URL: https://github.com/apache/tomcat/pull/490#issuecomment-1086097717
Thanks for spotting this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
markt-asf merged pull request #490:
URL: https://github.com/apache/tomcat/pull/490
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...
dsoumis opened a new pull request #490:
URL: https://github.com/apache/tomcat/pull/490
com.h2database version 2.0.210 does not exist in maven central repository.
It should be replaced with version 2.1.210 which is flawless.
--
This is an automated message from the Apache Git Service.
To
markt-asf commented on pull request #482:
URL: https://github.com/apache/tomcat/pull/482#issuecomment-1082404289
Ah. Problem solved. Just need to specify RFC 1779 format.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and us
markt-asf commented on pull request #482:
URL: https://github.com/apache/tomcat/pull/482#issuecomment-1082401729
There is an issue here. `getSubjectDN()` returns a DN that includes spaces
between the attribute name/value pairs. `getSubjectX500Principal().getName()`
does not include spaces.
markt-asf commented on pull request #488:
URL: https://github.com/apache/tomcat/pull/488#issuecomment-1082392340
Thanks. I ended up applying this manually as it was easier to sync with
POEditor that way.
--
This is an automated message from the Apache Git Service.
To respond to the messa
markt-asf closed pull request #488:
URL: https://github.com/apache/tomcat/pull/488
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...
markt-asf merged pull request #482:
URL: https://github.com/apache/tomcat/pull/482
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...
markt-asf commented on pull request #489:
URL: https://github.com/apache/tomcat/pull/489#issuecomment-1082232318
This is not correct. Null socket channels are usually an indication that
something has gone wrong. The warning is deliberate.
If you have a use case where a correctly handled
markt-asf closed pull request #489:
URL: https://github.com/apache/tomcat/pull/489
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...
markt-asf closed pull request #481:
URL: https://github.com/apache/tomcat/pull/481
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...
markt-asf commented on pull request #481:
URL: https://github.com/apache/tomcat/pull/481#issuecomment-1082229465
No response to Chris's questions so closing this as WONTFIX. Maintaining
deployment order of applications is something probably best discussed on the
users list in the first ins
rhernandez35 opened a new pull request #489:
URL: https://github.com/apache/tomcat/pull/489
Null socket channels are only a problem if the socket isn't closed.
Otherwise, they're just indicative of a stale event being processed.
--
This is an automated message from the Apache Git Service
volosied commented on pull request #488:
URL: https://github.com/apache/tomcat/pull/488#issuecomment-1077702530
Hey Mark, these translations where done with files prior to the `writeable"
-> "writable` change (which I had updated manually for this PR) I squashed the
two commits.
markt-asf commented on pull request #488:
URL: https://github.com/apache/tomcat/pull/488#issuecomment-1077358709
Please rebase the PR. The "writeable" -> "writable" change was made last
year.
--
This is an automated message from the Apache Git Service.
To respond to the message, please l
markt-asf commented on pull request #488:
URL: https://github.com/apache/tomcat/pull/488#issuecomment-1077355222
The files use unicode escapes rather than UTF-8. They should use UTF-8 as
this makes them easier for native speakers to review.
Tomcat uses POEditor to [manage
translatio
volosied opened a new pull request #488:
URL: https://github.com/apache/tomcat/pull/488
Open Liberty uses Tomcat's EL API, but, since some of the property file
translations were missing, IBM completed them and created new files for other
languages. We'd like to contribute these back to To
HoffmannTom commented on pull request #487:
URL: https://github.com/apache/tomcat/pull/487#issuecomment-1076767607
Thank you for the quick response and help!
My second pull request in future will hopefully improve.
--
This is an automated message from the Apache Git Service.
To respond
rmaucher commented on pull request #487:
URL: https://github.com/apache/tomcat/pull/487#issuecomment-1076764682
Oh, actually, this has the key -> id change, but it should still do
Integer.toString(id).
--
This is an automated message from the Apache Git Service.
To respond to the message
rmaucher closed pull request #487:
URL: https://github.com/apache/tomcat/pull/487
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@
rmaucher commented on pull request #487:
URL: https://github.com/apache/tomcat/pull/487#issuecomment-1076761134
Closing since the patch is wrong and I'm already about to commit it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Git
HoffmannTom opened a new pull request #487:
URL: https://github.com/apache/tomcat/pull/487
The logging of unknown http2 settings should contain the key and the value
of the setting.
The key is currently converted into a setting object. Unknown keys are
mapped to Integer.MAX_VALUE
Thu
masteryourself closed pull request #486:
URL: https://github.com/apache/tomcat/pull/486
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubs
masteryourself commented on pull request #485:
URL: https://github.com/apache/tomcat/pull/485#issuecomment-1072921366
sorry
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
masteryourself closed pull request #485:
URL: https://github.com/apache/tomcat/pull/485
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubs
masteryourself commented on pull request #485:
URL: https://github.com/apache/tomcat/pull/485#issuecomment-1072921287
yeap
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
kkolinko commented on pull request #484:
URL: https://github.com/apache/tomcat/pull/484#issuecomment-1071948912
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscri
ChristopherSchultz commented on pull request #484:
URL: https://github.com/apache/tomcat/pull/484#issuecomment-1071037596
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
kkolinko commented on pull request #483:
URL: https://github.com/apache/tomcat/pull/483#issuecomment-1071952012
Duplicate of #484
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific com
markt-asf commented on pull request #484:
URL: https://github.com/apache/tomcat/pull/484#issuecomment-1072350414
I am closing this as WONTFIX.
The current default behaviour is by design for DoS protection.
If you want the behaviour this PR is intended to provide set the
`recompileOnFa
F4ded edited a comment on pull request #484:
URL: https://github.com/apache/tomcat/pull/484#issuecomment-1071100064
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsub
F4ded closed pull request #483:
URL: https://github.com/apache/tomcat/pull/483
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@tom
F4ded commented on pull request #484:
URL: https://github.com/apache/tomcat/pull/484#issuecomment-1071100064
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
F4ded removed a comment on pull request #484:
URL: https://github.com/apache/tomcat/pull/484#issuecomment-1071100064
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsu
markt-asf closed pull request #484:
URL: https://github.com/apache/tomcat/pull/484
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...
markt-asf commented on pull request #484:
URL: https://github.com/apache/tomcat/pull/484#issuecomment-1072350414
I am closing this as WONTFIX.
The current default behaviour is by design for DoS protection.
If you want the behaviour this PR is intended to provide set the
`recompileOnFa
markt-asf closed pull request #484:
URL: https://github.com/apache/tomcat/pull/484
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...
F4ded removed a comment on pull request #484:
URL: https://github.com/apache/tomcat/pull/484#issuecomment-1071971332
> I think that the feature that this PR tries to remove may protect Tomcat
from a DOS attack.
>
> Consider, that an instance of Apache Tomcat is running in production
F4ded commented on pull request #484:
URL: https://github.com/apache/tomcat/pull/484#issuecomment-1071971332
> I think that the feature that this PR tries to remove may protect Tomcat
from a DOS attack.
>
> Consider, that an instance of Apache Tomcat is running in production and
has
kkolinko commented on pull request #484:
URL: https://github.com/apache/tomcat/pull/484#issuecomment-1071955873
I think that it is much better to discuss bugs in Bugzilla. So that an issue
is discussed in one place. Regardless of how may PRs are there.
--
This is an automated message fro
kkolinko commented on pull request #483:
URL: https://github.com/apache/tomcat/pull/483#issuecomment-1071952012
Duplicate of #484
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific com
kkolinko commented on pull request #484:
URL: https://github.com/apache/tomcat/pull/484#issuecomment-1071948912
I think that the feature that this PR tries to remove may protect Tomcat
from a DOS attack.
Consider, that an instance of Apache Tomcat is running in production and has
a
F4ded commented on pull request #484:
URL: https://github.com/apache/tomcat/pull/484#issuecomment-1071923602
> I've noticed this behavior in the past and never bothered to track it down
to the source.
>
> I'm having trouble loading the images, though I suspect they don't have
much i
F4ded removed a comment on pull request #484:
URL: https://github.com/apache/tomcat/pull/484#issuecomment-1071100064
> I would appreciate it if someone who understands the Jasper components of
Tomcat better than I do could please evaluate this patch for correctness. It
looks good to me, bu
F4ded edited a comment on pull request #484:
URL: https://github.com/apache/tomcat/pull/484#issuecomment-1071100064
> I would appreciate it if someone who understands the Jasper components of
Tomcat better than I do could please evaluate this patch for correctness. It
looks good to me, but
F4ded edited a comment on pull request #484:
URL: https://github.com/apache/tomcat/pull/484#issuecomment-1071100064
> I would appreciate it if someone who understands the Jasper components of
Tomcat better than I do could please evaluate this patch for correctness. It
looks good to me, but
F4ded commented on pull request #484:
URL: https://github.com/apache/tomcat/pull/484#issuecomment-1071100064
>
Here is the details.
org.apache.jasper.compiler.Compiler#isOutDated(boolean):
```java
public boolean isOutDated(boolean checkClass) {
if (jsw != null
ChristopherSchultz commented on pull request #484:
URL: https://github.com/apache/tomcat/pull/484#issuecomment-1071039140
I would appreciate it if someone who understands the Jasper components of
Tomcat better than I do could please evaluate this patch for correctness. It
looks good to me,
ChristopherSchultz commented on pull request #484:
URL: https://github.com/apache/tomcat/pull/484#issuecomment-1071037596
I've noticed this behavior in the past and never bothered to track it down
to the source.
I'm having trouble loading the images, though I suspect they don't have
F4ded opened a new pull request #484:
URL: https://github.com/apache/tomcat/pull/484
Bug fix: after a jsp file is accessed, modify the jsp file to make it have a
syntax error, when you accessing the jsp file again, the response will report a
synatx error for the first time, but if it is ac
F4ded closed pull request #483:
URL: https://github.com/apache/tomcat/pull/483
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@tom
F4ded opened a new pull request #483:
URL: https://github.com/apache/tomcat/pull/483
Bug fix: after a jsp file is accessed, modify the jsp file to make it have a
syntax error, when you accessing the jsp file again, the response will report a
synatx error for the first time, but if it is ac
ChristopherSchultz commented on pull request #482:
URL: https://github.com/apache/tomcat/pull/482#issuecomment-1069321989
LGTM. getSubjectX500Principal was added in Java 1.4 so we should be good all
the way back to 8.5.
--
This is an automated message from the Apache Git Service.
To resp
sim-lus opened a new pull request #482:
URL: https://github.com/apache/tomcat/pull/482
According to java spec, getSubjectDN() should not be used:
"denigrated, replaced by getSubjectX500Principal(). This method returns the
subject as an implementation specific Principal object, which shou
ChristopherSchultz commented on pull request #481:
URL: https://github.com/apache/tomcat/pull/481#issuecomment-1065380953
What exactly does this accomplish? LinkedHashMap just produces iterators
which maintain insertion-order. It doesn't impose any order on when they were
inserted.
pavandv9 commented on pull request #481:
URL: https://github.com/apache/tomcat/pull/481#issuecomment-1063832888
I agree to your point, but again since web applications are independent many
applications may be running in order.
So I hope by doing this it doesn't affect the existing fe
markt-asf commented on pull request #481:
URL: https://github.com/apache/tomcat/pull/481#issuecomment-1063793228
That is a backwards incompatible change so, if made, it will only be made to
the 10.1.x branch.
Web applications are meant to be independent. If there are dependencies
be
pavandv9 commented on pull request #481:
URL: https://github.com/apache/tomcat/pull/481#issuecomment-1063696340
Can someone review this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the speci
pavandv9 removed a comment on pull request #481:
URL: https://github.com/apache/tomcat/pull/481#issuecomment-1063696340
Can someone review this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
pavandv9 opened a new pull request #481:
URL: https://github.com/apache/tomcat/pull/481
currently deployment order is not maintain, in order to overcome this we can
change HashMap to LinkedHashMap.
So that the deployment order in maintained.
--
This is an automated message from the A
hakanbakacak closed pull request #480:
URL: https://github.com/apache/tomcat/pull/480
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr
ChristopherSchultz commented on pull request #480:
URL: https://github.com/apache/tomcat/pull/480#issuecomment-1058559040
IMO not worth it on its own. Removing a single space? Not worth a change to
the file history.
--
This is an automated message from the Apache Git Service.
To respond
elkman commented on pull request #479:
URL: https://github.com/apache/tomcat/pull/479#issuecomment-1057220843
Thanks for the discussion, time and all your great work on the Tomcat
project.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
markt-asf merged pull request #479:
URL: https://github.com/apache/tomcat/pull/479
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...
markt-asf commented on pull request #479:
URL: https://github.com/apache/tomcat/pull/479#issuecomment-1055537623
Based on this discussion, the original fix is correct. I'll merge this
shortly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please
rmaucher commented on pull request #479:
URL: https://github.com/apache/tomcat/pull/479#issuecomment-1055232521
It expands the capability of rewrite a bit, so "no" would be a good option.
Actually I was considering using rewrite for the context path optional
feature (until you said this
markt-asf commented on pull request #479:
URL: https://github.com/apache/tomcat/pull/479#issuecomment-1055206076
Thanks for that example.
The right way to fix this will depend on the answer to the question "If a
rewrite valve is configured at the Host level, is it a requirement that a
c
tandraschko commented on pull request #476:
URL: https://github.com/apache/tomcat/pull/476#issuecomment-1054621930
@markt-asf thanks, even better!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
elkman commented on pull request #479:
URL: https://github.com/apache/tomcat/pull/479#issuecomment-1054500688
A valid UseCase for me would be: _Migration of an application to a new
context_
`https://host/myOldApp` -> `https://host/myNewApp`
In this case you would forward both
markt-asf commented on pull request #479:
URL: https://github.com/apache/tomcat/pull/479#issuecomment-1054062262
I can see valid use cases that wouldn't meet at least one of those criteria
so I don't think it is quite that simple. Having a concrete use case to discuss
might make things a l
elkman commented on pull request #479:
URL: https://github.com/apache/tomcat/pull/479#issuecomment-1053990436
That is a good point. Do you think the misconfiguration is that a ROOT
context should always be configured, or that rewrite rules should only be
defined on existing contexts?
--
markt-asf commented on pull request #479:
URL: https://github.com/apache/tomcat/pull/479#issuecomment-1050857542
This looks like invalid configuration at this point.
Generally, an NPE is preferable to a change that masks a configuration issue.
--
This is an automated message from t
markt-asf merged pull request #477:
URL: https://github.com/apache/tomcat/pull/477
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...
elkman commented on pull request #479:
URL: https://github.com/apache/tomcat/pull/479#issuecomment-1050112226
Hi,
I stumbled across this issue while writing a "RewriteValve" rule that
redirects everything based on an HTTP header condition.
This is happening in a development en
elkman opened a new pull request #479:
URL: https://github.com/apache/tomcat/pull/479
If no ROOT context is defined, the context may be null in special cases,
e.g. RewriteValve may use Response#sendRedirect() without any application
context associated.
In this case, the Tomcat behaviors
501 - 600 of 2653 matches
Mail list logo
