markt-asf commented on issue #265: Replace LOGGING_CONFIG BY
CATALINA_LOGGING_CONFIG
URL: https://github.com/apache/tomcat/pull/265#issuecomment-607303421
Given containers seem to like environment variables, I don't see a way
around this. I'm working on a backwards compatible solution.
markt-asf merged pull request #259: Set 'release' parameter for main compile
target
URL: https://github.com/apache/tomcat/pull/259
This is an automated message from the Apache Git Service.
To respond to the message, please
markt-asf closed pull request #249: Support for default values in property
value expressions
URL: https://github.com/apache/tomcat/pull/249
This is an automated message from the Apache Git Service.
To respond to the
markt-asf commented on issue #249: Support for default values in property value
expressions
URL: https://github.com/apache/tomcat/pull/249#issuecomment-607903803
Thanks for thr PR. A variation has been applied to all currently supported
branches.
markt-asf commented on issue #252: 8.5.x
URL: https://github.com/apache/tomcat/pull/252#issuecomment-607731339
I can see why this is necessary and I support making the necessary changes
to Tomcat to support solving this problem. The patch as proposed cannot be
applied as the o.a.t.util
lkirchev commented on issue #252: 8.5.x
URL: https://github.com/apache/tomcat/pull/252#issuecomment-607765082
Thanks a lot Mark! Yes, you are right, I overlooked the dependency I
introduced. I added another commit with a proposal for replacing
o.a.c.c.Request with HttpServletRequest.
michael-o opened a new pull request #7: BZ 64260: Clean up install target
URL: https://github.com/apache/tomcat-native/pull/7
Remove bin/, include/, lib/pkgconfig/ from install target since they serve no
purpose for the outside world and rather might confuse people. libtcnative is
michael-o commented on issue #7: BZ 64260: Clean up install target
URL: https://github.com/apache/tomcat-native/pull/7#issuecomment-603783395
Works flawlessly on RHEL 7 and HP-UX 11.31.
This is an automated message from the
rmaucher commented on pull request #286:
URL: https://github.com/apache/tomcat/pull/286#issuecomment-619853801
Hmmm :(
So, ok, I guess you have to start somewhere, but it is best to have PRs on
something meaningful (like at least a small bugfix or real improvement of some
sort). Here,
martin-g commented on pull request #286:
URL: https://github.com/apache/tomcat/pull/286#issuecomment-619872274
Thanks for cherry-picking the change, Remy! I was interrupted after merging
the PR and I was going to do it at lunch break.
martin-g commented on pull request #286:
URL: https://github.com/apache/tomcat/pull/286#issuecomment-619781821
Thank you, @XavierChengZW !
This is an automated message from the Apache Git Service.
To respond to the message,
govi20 removed a comment on pull request #275:
URL: https://github.com/apache/tomcat/pull/275#issuecomment-615931189
I will remove the cleanup changes.
So apparently we should call interrupt, check if thread is still active, if
yes then call stop. Correct me if I'm wrong here.
rmaucher commented on pull request #277:
URL: https://github.com/apache/tomcat/pull/277#issuecomment-619026541
Indeed, there are two very legacy looking workarounds for brokeness in
spnego. One of them can be removed since using Java 8u40 is not reasonable
anymore. What about that
michael-o commented on pull request #277:
URL: https://github.com/apache/tomcat/pull/277#issuecomment-619041883
@rmaucher The question is when is it justified for component or webapp code
to close the connection? Should a container solely decide to close the
connection?
XavierChengZW opened a new pull request #286:
URL: https://github.com/apache/tomcat/pull/286
optimized code,replace some c-style array Brackets are a part of an Array
type. The definition could be: String[] args
This is an
KangZhiDong opened a new pull request #285:
URL: https://github.com/apache/tomcat/pull/285
avoid waste of resources due to reconstruction of objects
This is an automated message from the Apache Git Service.
To respond to the
markt-asf commented on pull request #277:
URL: https://github.com/apache/tomcat/pull/277#issuecomment-619147196
In an ideal world, anything in the Connection header should only be the
concern of the container. Historically that hasn't been possible due to broken
clients. The question is,
markt-asf commented on issue #279:
URL: https://github.com/apache/tomcat/pull/279#issuecomment-617338009
What is the basis for this change?
While the thread is in `wait()`, `notify()` should only be called if one of
the conditions in the surrounding `if(...)` is no longer true. I'd
larsgrefer opened a new pull request #280:
URL: https://github.com/apache/tomcat/pull/280
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
martin-g commented on a change in pull request #276:
URL: https://github.com/apache/tomcat/pull/276#discussion_r412708978
##
File path: .travis.yml
##
@@ -15,8 +15,12 @@
dist: bionic
language: java
-jdk: oraclejdk8
-arch: arm64
+jobs:
+include:
+ - arch: s390x
+
KangZhiDong commented on issue #279:
URL: https://github.com/apache/tomcat/pull/279#issuecomment-617485732
> What is the basis for this change?
> While the thread is in `wait()`, `notify()` should only be called if one
of the conditions in the surrounding `if(...)` is no longer true.
prankkelkar commented on a change in pull request #276:
URL: https://github.com/apache/tomcat/pull/276#discussion_r412705684
##
File path: .travis.yml
##
@@ -32,14 +36,7 @@ addons:
- libtool-bin
install:
-- ARCH=`uname -p`
-- echo $ARCH
--
prankkelkar commented on a change in pull request #276:
URL: https://github.com/apache/tomcat/pull/276#discussion_r412706114
##
File path: .travis.yml
##
@@ -15,8 +15,12 @@
dist: bionic
language: java
-jdk: oraclejdk8
-arch: arm64
+jobs:
+include:
+ - arch: s390x
markt-asf commented on issue #279:
URL: https://github.com/apache/tomcat/pull/279#issuecomment-617654855
Your analysis is not correct.
This is an automated message from the Apache Git Service.
To respond to the message,
markt-asf commented on issue #280:
URL: https://github.com/apache/tomcat/pull/280#issuecomment-618326624
These are all deliberate to keep the IDE (Eclipse) clear of warnings. We
could disable that warning but that then runs the risk of us missing one of the
more subtle autoboxing/unboxing
markt-asf commented on a change in pull request #273:
URL: https://github.com/apache/tomcat/pull/273#discussion_r413715418
##
File path: java/jakarta/el/Util.java
##
@@ -380,11 +380,12 @@ static Method findMethod(Class clazz, Object base,
String methodName,
private
markt-asf commented on issue #275:
URL: https://github.com/apache/tomcat/pull/275#issuecomment-618352734
Thanks. I used a variation of your PR to fix this.
This is an automated message from the Apache Git Service.
To respond
KangZhiDong commented on issue #279:
URL: https://github.com/apache/tomcat/pull/279#issuecomment-617483507
> What is the basis for this change?
> While the thread is in `wait()`, `notify()` should only be called if one
of the conditions in the surrounding `if(...)` is no longer true.
govi20 commented on issue #275:
URL: https://github.com/apache/tomcat/pull/275#issuecomment-617662936
@markt-asf could you please suggest if any further changes are required here.
This is an automated message from the Apache
arkanovicz commented on issue #277:
URL: https://github.com/apache/tomcat/pull/277#issuecomment-617753041
@rmaucher The spec authors justify themselves of this strict policy by
saying that otherwise it's a vector of attack. I don't know the whereabouts,
here.
About where to put the
rmaucher commented on issue #277:
URL: https://github.com/apache/tomcat/pull/277#issuecomment-617758397
Still, -1, again for your patch. In addition to being ugly, there's no
provision in the Servlet spec to throw an exception on random header names,
especially common ones, so failing,
rmaucher commented on issue #277:
URL: https://github.com/apache/tomcat/pull/277#issuecomment-617661025
The initial post says SHOULD, but after actually checking the spec it is a
MUST.
https://tools.ietf.org/html/rfc7540#section-8.1.2.2
It is really odd the specification made
markt-asf commented on issue #269:
URL: https://github.com/apache/tomcat/pull/269#issuecomment-617706987
`Collections.unmodifiable[Set|Map|List]` is probably an option in some cases
but some (most?) of these instances are returned as part of a public API and if
the API doesn't state they
rmaucher commented on issue #281:
URL: https://github.com/apache/tomcat/pull/281#issuecomment-618465384
When I look at https://github.com/apache/tomcat/pull/271 in comparison, it
has an extensive "why" demonstrating why it is actually better and it is not
simply cosmetics.
larsgrefer opened a new pull request #282:
URL: https://github.com/apache/tomcat/pull/282
This change makes IntelliJ IDEA and other IDE's aware of some of the coding
standards of the Tomcat project.
The .editorconfig file (and the rules therein) will be automatically used by
the
larsgrefer opened a new pull request #283:
URL: https://github.com/apache/tomcat/pull/283
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
markt-asf commented on issue #282:
URL: https://github.com/apache/tomcat/pull/282#issuecomment-618510753
These need to be placed in `res/ide-support/idea` and you probably want to
check that the `ide-intellij` Ant target will do the right thing with them and
if not, adjust it.
markt-asf commented on issue #282:
URL: https://github.com/apache/tomcat/pull/282#issuecomment-618521303
Some community members (really) dislike having the clutter in the root of
the repository. Some IDEs are worse than others for this (IDEA seems to be one
of the better ones). There was
martin-g commented on issue #276:
URL: https://github.com/apache/tomcat/pull/276#issuecomment-618402125
The build for s390x fails at Travis:
https://travis-ci.org/github/apache/tomcat/jobs/678503882
```
Caused by: java.security.cert.CertificateExpiredException: NotAfter: Sat Dec
markt-asf commented on issue #277:
URL: https://github.com/apache/tomcat/pull/277#issuecomment-618453474
I've been reading the HTTP/2 RFC and there is more to this than simply
blocking the `connection` header.
1. What the HTTP/2 and HTTP/1.1 specs suggest we should be doing in parsing
michael-o commented on issue #277:
URL: https://github.com/apache/tomcat/pull/277#issuecomment-618504729
Please note that there may be client components which may explicitly close
connections with `Connection: close`. E.g., in `SpnegoAuthenticator`.
michael-o commented on issue #282:
URL: https://github.com/apache/tomcat/pull/282#issuecomment-618507565
I am against IDE-specific config files, those should be automatically
generated. Next one will request, VS Code, Eclipse, NetBeans, YouNameIt.
michael-o edited a comment on issue #282:
URL: https://github.com/apache/tomcat/pull/282#issuecomment-618526886
@larsgrefer I'd like to quote @markt-asf on point 2 and 3 when we met in
person: "I can type `ant ide-...` and I am done.". If you whink that `ant
ide-...` is not present
larsgrefer commented on issue #282:
URL: https://github.com/apache/tomcat/pull/282#issuecomment-618515960
@michael-o You already have them for IntelliJ IDEA, Eclipse and NetBeans
My idea was not to hide them in `res/ide-support/idea` but to directly put
them where they belong.
rmaucher commented on issue #277:
URL: https://github.com/apache/tomcat/pull/277#issuecomment-618470184
Yes, it is accurate if there's a "connection: foobar" header, then there
could be a "foobar" header and in that case it's tied to the connection header.
Note about my earlier
michael-o commented on issue #282:
URL: https://github.com/apache/tomcat/pull/282#issuecomment-618526886
@larsgrefer I'd like to quote @markt-asf on point 2 and 3 while we met in
person: "I can type `ant ide-...` and I am done.". If you whink that `ant
ide-...` is not present enough,
rainerjung commented on issue #276:
URL: https://github.com/apache/tomcat/pull/276#issuecomment-618408120
Hi Martin,
the build.xml line numbers
/home/travis/build/apache/tomcat/build.xml:2789: The following error
occurred while executing this line:
govi20 edited a comment on issue #281:
URL: https://github.com/apache/tomcat/pull/281#issuecomment-61843
There are so many places in the codebase where we can replace array with
List and we could reduce good amount of code.
rmaucher commented on issue #281:
URL: https://github.com/apache/tomcat/pull/281#issuecomment-618384315
This commit seems functionally useless but is solely motivated by personal
preferences. At the very least, they should be accompanied by quick perf
numbers that show equivalence or
markt-asf commented on issue #281:
URL: https://github.com/apache/tomcat/pull/281#issuecomment-618447383
The question is "At what cost?" I have two concerns.
1. Regressions. The changes should be obvious and easy to check but there
are plenty of examples in the history of Tomcat of
govi20 opened a new pull request #281:
URL: https://github.com/apache/tomcat/pull/281
Instead of resizing array manually, we can leverage `List` to hold
filter-chain
This is an automated message from the Apache Git Service.
martin-g commented on issue #276:
URL: https://github.com/apache/tomcat/pull/276#issuecomment-618421407
Thanks for the explanation, Rainer!
I've restarted the job at Travis. Let's see!
This is an automated message from
govi20 commented on issue #281:
URL: https://github.com/apache/tomcat/pull/281#issuecomment-61843
There are so many places in the codebase where we can replace array with
List could reduce good amount of code.
This is
martin-g commented on issue #276:
URL: https://github.com/apache/tomcat/pull/276#issuecomment-618443203
Thank you, @prankkelkar !
This is an automated message from the Apache Git Service.
To respond to the message, please
ChristopherSchultz commented on issue #281:
URL: https://github.com/apache/tomcat/pull/281#issuecomment-618426909
There *is* some code-reduction, and therefore a reduction in the possibility
of bugs. Obviously, this code is well-tested and does indeed work.
Another possible
YYTVicky opened a new pull request #288:
URL: https://github.com/apache/tomcat/pull/288
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
markt-asf commented on pull request #288:
URL: https://github.com/apache/tomcat/pull/288#issuecomment-622089826
Adding comments to the code is note the way to recommend code changes.
Also, I don't agree with the recommendation.
This PR will not be applied.
markt-asf commented on pull request #287:
URL: https://github.com/apache/tomcat/pull/287#issuecomment-622096873
Thanks. We use POEditor.com to manage translations. I've updated the string
there and we will pick up the change the next time we import the translations
from POEditor.com to
markt-asf commented on a change in pull request #284:
URL: https://github.com/apache/tomcat/pull/284#discussion_r418686412
##
File path: .editorconfig
##
@@ -0,0 +1,18 @@
+root = true
+
+[*]
+end_of_line = lf
+indent_style = space
+trim_trailing_whitespace = true
+
+[*.java]
markt-asf commented on pull request #285:
URL: https://github.com/apache/tomcat/pull/285#issuecomment-622515717
What is the performance benefit here? I'm concerned that some error paths,
particularly around unhandled exceptions might lead to memory leaks. The PR
needs very careful
larsgrefer commented on a change in pull request #284:
URL: https://github.com/apache/tomcat/pull/284#discussion_r418772805
##
File path: .editorconfig
##
@@ -0,0 +1,18 @@
+root = true
Review comment:
More information can be found here: https://editorconfig.org/
larsgrefer commented on a change in pull request #284:
URL: https://github.com/apache/tomcat/pull/284#discussion_r418772613
##
File path: .editorconfig
##
@@ -0,0 +1,18 @@
+root = true
+
+[*]
+end_of_line = lf
+indent_style = space
+trim_trailing_whitespace = true
+
+[*.java]
markt-asf commented on pull request #273:
URL: https://github.com/apache/tomcat/pull/273#issuecomment-622538536
Thanks for the updates. I'm going to merge this via the command line as
there are a few minor things I want to tweak - mainly variable names.
Mahir92 commented on pull request #255:
URL: https://github.com/apache/tomcat/pull/255#issuecomment-623232365
Hi @markt-asf , I have posted the following enhancement request in BugZilla
describing the issue - https://bz.apache.org/bugzilla/show_bug.cgi?id=64409.
Please let me know
markt-asf commented on pull request #285:
URL: https://github.com/apache/tomcat/pull/285#issuecomment-623492707
Re-opening, as I have done most of the analysis required.
This is an automated message from the Apache Git
markt-asf commented on pull request #285:
URL: https://github.com/apache/tomcat/pull/285#issuecomment-623504537
The only one I'm concerned about is `JspFactoryImpl` as this would open up
the possibility of one web application being able to impact another. I'll merge
this manually so I can
markt-asf commented on pull request #285:
URL: https://github.com/apache/tomcat/pull/285#issuecomment-623510920
Merged
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
markt-asf commented on pull request #273:
URL: https://github.com/apache/tomcat/pull/273#issuecomment-623325970
Applied manually with some minor changes (and a larger follow-on commit)
This is an automated message from the
k-tamura opened a new pull request #287:
URL: https://github.com/apache/tomcat/pull/287
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
larsgrefer commented on a change in pull request #273:
URL: https://github.com/apache/tomcat/pull/273#discussion_r413983378
##
File path: java/jakarta/el/Util.java
##
@@ -380,11 +380,12 @@ static Method findMethod(Class clazz, Object base,
String methodName,
private
KangZhiDong opened a new pull request #279:
URL: https://github.com/apache/tomcat/pull/279
more performance
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
markt-asf commented on pull request #283:
URL: https://github.com/apache/tomcat/pull/283#issuecomment-618583682
Thank you. That prompted me to figure out why I got the warning in the text
editor but not in the problems tab. I now have ~1,500 errors and warnings to
look at. But I'll merge
michael-o commented on pull request #282:
URL: https://github.com/apache/tomcat/pull/282#issuecomment-618717780
Please skim to IDEA only.
This is an automated message from the Apache Git Service.
To respond to the message,
larsgrefer opened a new pull request #284:
URL: https://github.com/apache/tomcat/pull/284
see also:
https://github.com/apache/tomcat/pull/282#pullrequestreview-399324287
This is an automated message from the Apache Git
Thihup opened a new pull request #289:
URL: https://github.com/apache/tomcat/pull/289
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
Iridias opened a new pull request #264: fix regression: only skip jar-scanning
completely if scanSet is empty
URL: https://github.com/apache/tomcat/pull/264
The commit 21d08e1952d6612da9a712a173c81174958f4b8b introduced a regression
to the behavior of jar-scanning. Since version 9.0.31 it
ChristopherSchultz commented on issue #262: Fix and tests for tomcat bug #64226
URL: https://github.com/apache/tomcat/pull/262#issuecomment-600258315
Please don't change something like this in Tomcat 9.0 or older. Those
releases are far too stable to go around changing the date-related
rmaucher commented on issue #263: graal support for embedded jars
URL: https://github.com/apache/tomcat/pull/263#issuecomment-600194395
It doesn't seem bad to do that given how these jars are used.
Note: The resource bundles are now traced with Graal 20.0 so it's not 100%
mandatory to
ChristopherSchultz edited a comment on issue #262: Fix and tests for tomcat bug
#64226
URL: https://github.com/apache/tomcat/pull/262#issuecomment-600258315
Please don't change something like this in Tomcat 9.0 or older. Those
releases are far too stable to go around changing the
gazzyt commented on issue #262: Fix and tests for tomcat bug #64226
URL: https://github.com/apache/tomcat/pull/262#issuecomment-600542134
I did some hacking on the Java 8 `DateTimeFormatter` yesterday and concur
with @ChristopherSchultz. I found that `DateTimeFormatter` parsing was more
rmaucher commented on issue #262: Fix and tests for tomcat bug #64226
URL: https://github.com/apache/tomcat/pull/262#issuecomment-601617760
I preferred a simple reset of the timezone for now. Thanks for the PR.
This is an
rmaucher closed pull request #262: Fix and tests for tomcat bug #64226
URL: https://github.com/apache/tomcat/pull/262
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
martin-g closed pull request #264: fix regression: only skip jar-scanning
completely if scanSet is empty
URL: https://github.com/apache/tomcat/pull/264
This is an automated message from the Apache Git Service.
To respond to
martin-g commented on issue #264: fix regression: only skip jar-scanning
completely if scanSet is empty
URL: https://github.com/apache/tomcat/pull/264#issuecomment-602555158
Fixed with
https://github.com/apache/tomcat/commit/9c6563bf6ac723cda4e78d0e8c1a996fa1b8ce56
Iridias commented on issue #264: fix regression: only skip jar-scanning
completely if scanSet is empty
URL: https://github.com/apache/tomcat/pull/264#issuecomment-602564747
> Fixed with 9c6563b
Hm, that would ignore the case, that `jarsToScan` is specified but empty.
(Because then
rmaucher commented on issue #264: fix regression: only skip jar-scanning
completely if scanSet is empty
URL: https://github.com/apache/tomcat/pull/264#issuecomment-602567135
I hadn't seen this PR at all as there was a BZ there already and it didn't
mention it.
I will make the extra
bohmber commented on issue #249: Support for default values in property value
expressions
URL: https://github.com/apache/tomcat/pull/249#issuecomment-596735064
Added a simple unit test.
This is an automated message from the
fhanik opened a new pull request #263: graal support for embedded jars
URL: https://github.com/apache/tomcat/pull/263
Don't merge yet, opening PR for purpose of review.
I will bring this up on the mailing list.
_include Graal files so that the native-image compiler picks it up
rmaucher commented on pull request #221:
URL: https://github.com/apache/tomcat/pull/221#issuecomment-631480011
I integrated everything (and a bit more) except the service loader part.
This is an automated message from the
rmaucher closed pull request #221:
URL: https://github.com/apache/tomcat/pull/221
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
EruDev opened a new pull request #290:
URL: https://github.com/apache/tomcat/pull/290
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
markt-asf closed pull request #290:
URL: https://github.com/apache/tomcat/pull/290
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
markt-asf commented on pull request #290:
URL: https://github.com/apache/tomcat/pull/290#issuecomment-632589674
This will introduce an IDE warning for auto-boxing. The Tomcat code
deliberately uses explicit conversion rather than auto-boxing.
jaimecasero opened a new pull request #353:
URL: https://github.com/apache/tomcat/pull/353
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
martin-g commented on a change in pull request #352:
URL: https://github.com/apache/tomcat/pull/352#discussion_r482996760
##
File path: java/org/apache/catalina/webresources/JarContents.java
##
@@ -0,0 +1,144 @@
+package org.apache.catalina.webresources;
+
+import
rmaucher closed pull request #353:
URL: https://github.com/apache/tomcat/pull/353
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
martin-g commented on a change in pull request #351:
URL: https://github.com/apache/tomcat/pull/351#discussion_r483001907
##
File path: java/org/apache/jasper/EmbeddedServletOptions.java
##
@@ -84,6 +84,11 @@
*/
private boolean classDebugInfo = true;
+/**
+
markt-asf closed pull request #349:
URL: https://github.com/apache/tomcat/pull/349
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
markt-asf commented on pull request #349:
URL: https://github.com/apache/tomcat/pull/349#issuecomment-687631167
Updated PR provided at #354
This is an automated message from the Apache Git Service.
To respond to the message,
markt-asf closed pull request #332:
URL: https://github.com/apache/tomcat/pull/332
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
901 - 1000 of 3206 matches
Mail list logo
