Re: OpenSSL vulnerabilities

2016-03-02 Thread Rainer Jung
Am 02.03.2016 um 09:48 schrieb Mark Thomas: All, I'm primarily looking at the window builds for Tomcat Native. tc-native 1.1.34 was built with OpenSSL 1.0.1q tc-native 1.2.4 was built with OpenSSL 1.0.2e. Looking at the latest OpenSSL security vulnerabilities: CVE-2016-0800: SSLv2 disabled by

Re: Tomcat 8.next

2016-02-29 Thread Rainer Jung
Am 29.02.2016 um 14:00 schrieb Rémy Maucherat: 2016-02-28 14:09 GMT+01:00 Rainer Jung : I find it hard to judge between a) and b), because I don't know much about the gap between only merging the connectors and merging anything but not Servlet API. I think making HTTP/2 and also Op

Re: Tomcat 8.next

2016-02-28 Thread Rainer Jung
Am 25.02.2016 um 15:15 schrieb Mark Thomas: On 25/02/2016 13:52, Rémy Maucherat wrote: Hi, This has been hinted at in the past, but is not being discussed anymore. Possible options: a) Release a new 8.x branch that would include the connectors from 9 to support HTTP/2 [OpenSSL now allows reali

Re: [GUMP@vmgump]: Project tomcat-native-make (in module tomcat-native) failed

2016-02-23 Thread Rainer Jung
It is possible that this problem: /usr/bin/ld: /srv/gump/public/workspace/openssl-master/dest-20160223/lib/libcrypto.a(poly1305-x86_64.o): relocation R_X86_64_PC32 against symbol `poly1305_blocks' can not be used when making a shared object; recompile with -fPIC /usr/bin/ld: final link failed

Re: svn commit: r1730101 - in /tomcat/trunk: java/org/apache/catalina/loader/WebappClassLoaderBase.java test/org/apache/catalina/loader/TestWebappClassLoader.java

2016-02-12 Thread Rainer Jung
Hi Violeta, build breakage fixed in r1730137. I adjusted the test to better reflect what's implemented currently: - deny if name is something below the denied package. We don't care for the package names themselves without anything added. - permit exclude rules work the same way, only permit f

Re: [VOTE] Release Apache Tomcat 8.0.32

2016-02-05 Thread Rainer Jung
Hi Chris, Am 05.02.2016 um 23:56 schrieb Christopher Schultz: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Rainer, On 2/5/16 9:38 AM, Rainer Jung wrote: Am 04.02.2016 um 23:44 schrieb Rainer Jung: Am 03.02.2016 um 10:05 schrieb Mark Thomas: The proposed Apache Tomcat 8.0.32 release is now

Re: [VOTE] Release Apache Tomcat 8.0.32

2016-02-05 Thread Rainer Jung
Am 04.02.2016 um 23:44 schrieb Rainer Jung: Am 03.02.2016 um 10:05 schrieb Mark Thomas: The proposed Apache Tomcat 8.0.32 release is now available for voting. The main changes since 8.0.30 are: - Restore the default for mapperContextRootRedirectEnabled to true - Update the packaged version

Re: [VOTE] Release Apache Tomcat 8.0.32

2016-02-04 Thread Rainer Jung
Am 03.02.2016 um 21:58 schrieb Christopher Schultz: Oh, grumble, I forgot we the a whole-point upgrade of tcnative in a stable Tomcat release. :( We probably shouldn't have done that. I'll see about using OpenSSL 1.0.2 and re-test. If tcnative requires OpenSSL 1.0.2 or later, then the configur

Re: [VOTE] Release Apache Tomcat 8.0.32

2016-02-04 Thread Rainer Jung
Am 03.02.2016 um 10:05 schrieb Mark Thomas: The proposed Apache Tomcat 8.0.32 release is now available for voting. The main changes since 8.0.30 are: - Restore the default for mapperContextRootRedirectEnabled to true - Update the packaged version of the Tomcat Native Library to 1.2.4 to pic

Re: [VOTE] Release Apache Tomcat 9.0.0.M3

2016-02-04 Thread Rainer Jung
Am 02.02.2016 um 01:20 schrieb Mark Thomas: The proposed Apache Tomcat 9.0.0.M3 release is now available for voting. This is a milestone release for the 9.0.x branch. It should be noted that, as a milestone release: - Servlet 4.0 is not finalised - The EGs have not started work on JSP 2.4, EL 3.

Re: ELParser fiel of type LookaheadSuccess extends Error

2016-02-04 Thread Rainer Jung
Am 03.02.2016 um 16:48 schrieb Rainer Jung: Hi there, ELParser has a field named jj_ls of type LookaheadSuccess which extends Error. It is created during each instantiation of an ELParser object. Creating an Error is quite slow, because e.g. it calls java.lang.Throwable.fillInStack() during

Re: ELParser fiel of type LookaheadSuccess extends Error

2016-02-03 Thread Rainer Jung
Hi Chris, Am 03.02.2016 um 17:04 schrieb Christopher Schultz: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Rainer, On 2/3/16 10:48 AM, Rainer Jung wrote: Hi there, ELParser has a field named jj_ls of type LookaheadSuccess which extends Error. It is created during each instantiation of an

ELParser fiel of type LookaheadSuccess extends Error

2016-02-03 Thread Rainer Jung
Hi there, ELParser has a field named jj_ls of type LookaheadSuccess which extends Error. It is created during each instantiation of an ELParser object. Creating an Error is quite slow, because e.g. it calls java.lang.Throwable.fillInStack() during init. This jj_ls is only used once in jj_sca

Re: openssl 1.0.2f released

2016-01-28 Thread Rainer Jung
My first thoughts: - DH small subgroups (CVE-2016-0701) Our native code sets SSL_OP_SINGLE_DH_USE in sslcontext.c (in the native impl of SSLContext.make()). This is true for trunk and 1.1.x. This should suffice to not being exposed to the problem. It is a bit unfortunate though, that the adis

openssl 1.0.2f released

2016-01-28 Thread Rainer Jung
Since the advisory https://www.openssl.org/news/secadv/20160128.txt is currently under heavy load, here's a copy: OpenSSL Security Advisory [28th Jan 2016] = NOTE: SUPPORT FOR VERSION 1.0.1 WILL BE ENDING ON 31ST DECEMBER 2016. NO SECURITY FIXES WILL BE

AJP13 and flush handling

2016-01-26 Thread Rainer Jung
The AJP protocol on the client side is often implemented in the way, that an empty body packet is interpreted as a signal to flush data to the client. This is true in mod_proxy_ajp and mod_jk. This is not part of http://tomcat.apache.org/connectors-doc/ajp/ajpv13a.html but the two most common

Re: svn commit: r1726672 - /tomcat/tc8.0.x/trunk/java/org/apache/catalina/loader/WebappClassLoaderBase.java

2016-01-25 Thread Rainer Jung
Thanks Konstantin, just noticed it as well. At least it shows that the tests are actually testing something. Fixed in r1726696. Am 25.01.2016 um 22:35 schrieb Konstantin Kolinko: 2016-01-25 22:30 GMT+03:00 : Author: rjung Date: Mon Jan 25 19:30:19 2016 New Revision: 1726672 URL: http://svn.

JASPIC and class loader filtering

2016-01-25 Thread Rainer Jung
Currently trunk has filtering for JASPIC classes in the class loader, other branches not. It was added to trunk in r1684529, the filtered package is javax.security.auth.message. I didn't follow the details, but there was some removal and plans to reintroduce another impl. Since I'm currently

Re: TC WebappClassLoaderBase bottleneck in filter()

2016-01-25 Thread Rainer Jung
Am 25.01.2016 um 11:23 schrieb Mark Thomas: On 25/01/2016 09:32, Rainer Jung wrote: Hi Konstantin, thanks for the feedback. More inline. Am 25.01.2016 um 03:51 schrieb Konstantin Kolinko: 2016-01-23 15:17 GMT+03:00 Rainer Jung : I observed a bottleneck in WebappClassLoaderBase.filter

Re: TC WebappClassLoaderBase bottleneck in filter()

2016-01-25 Thread Rainer Jung
Hi Konstantin, thanks for the feedback. More inline. Am 25.01.2016 um 03:51 schrieb Konstantin Kolinko: 2016-01-23 15:17 GMT+03:00 Rainer Jung : I observed a bottleneck in WebappClassLoaderBase.filter() during a stress test. The reason is, that the method is synchronized. It looks to me, that

Re: [VOTE] Release Apache Tomcat 9.0.0.M2

2016-01-24 Thread Rainer Jung
Am 24.01.2016 um 18:31 schrieb Rémy Maucherat: 2016-01-24 15:27 GMT+01:00 Rainer Jung : APR+SSL seemed not to have worked in the unit tests. Yes, it doesn't work. I put in a quick fix which works for me but I am unsure of the relationship with the refactoring (r1724234). Thanks Rem

Re: TC WebappClassLoaderBase bottleneck in filter()

2016-01-24 Thread Rainer Jung
Am 24.01.2016 um 19:50 schrieb Felix Schumacher: Am 23.01.2016 um 17:05 schrieb Rainer Jung: Am 23.01.2016 um 13:17 schrieb Rainer Jung: Since the calls to filter() are in a hot code path, I wonder whether using a more complex code instead of a single regexp could be better. The code should be

Re: [VOTE] Release Apache Tomcat 9.0.0.M2

2016-01-24 Thread Rainer Jung
Am 21.01.2016 um 13:38 schrieb Mark Thomas: The proposed Apache Tomcat 9.0.0.M2 release is now available for voting. This is the second milestone release for the 9.0.x branch. It should be noted that, as a milestone release: - Servlet 4.0 is not finalised - The EGs have not started work on JSP 2

Re: TC WebappClassLoaderBase bottleneck in filter()

2016-01-23 Thread Rainer Jung
Am 23.01.2016 um 13:17 schrieb Rainer Jung: Since the calls to filter() are in a hot code path, I wonder whether using a more complex code instead of a single regexp could be better. The code should be fast in the common case, which IMHO is the case when the resource name neither starts with

TC WebappClassLoaderBase bottleneck in filter()

2016-01-23 Thread Rainer Jung
I observed a bottleneck in WebappClassLoaderBase.filter() during a stress test. The reason is, that the method is synchronized. It looks to me, that the reason for the synchronization is only the access to the non-thread safe Matchers packageTriggersPermit and packageTriggersDeny. Since they ar

Re: svn commit: r1724345 - /tomcat/native/branches/1.1.x/native/src/ssl.c

2016-01-18 Thread Rainer Jung
he call to CRYPTO_malloc_init, but to me it looks like if it was needed before the rename, we should keep it and rename to OPENSSL_malloc_init. Regards, Rainer Am 18.01.2016 um 10:28 schrieb Rainer Jung: Hi Bill, According to the log message of the OpenSSL commit bbd86bf5424a611cb6b77a3a17fc52

Re: svn commit: r1724345 - /tomcat/native/branches/1.1.x/native/src/ssl.c

2016-01-18 Thread Rainer Jung
Hi Bill, According to the log message of the OpenSSL commit bbd86bf5424a611cb6b77a3a17fc522931c4dcb8 (January 7th), we might need to use OPENSSL_malloc_init instead: "Rename CRYPTO_malloc_init to OPENSSL_malloc_init; remove needless calls." I didn't look for details though. Regards, Rainer

Re: [VOTE-RESTARTED] Release Apache Tomcat Native 1.2.4

2016-01-06 Thread Rainer Jung
Hi Mark, there's no file bin/openssl.exe in the Windows binariy zip files. It existed in 1.2.3 but was also missing for 1.2.2. It also exists in 1.2.0 and 1.2.1 as well as 1.1.33 and 1.1.34. So I guess it should be included for 1.2.4 as well? Only talking about the binary release artefact he

Re: Issues when building Tomcat 9 + tcnative

2015-11-15 Thread Rainer Jung
Am 15.11.2015 um 13:59 schrieb Martin Grigorov: On Sun, Nov 15, 2015 at 1:35 PM, Martin Grigorov wrote: To setup HTTP2 I follow the steps done by Konstantin Kolinko at https://bz.apache.org/bugzilla/show_bug.cgi?id=58605 But here it fails with: 15-Nov-2015 13:40:37.505 INFO [main] org.apache

Re: [VOTE] Release Apache Tomcat Native 1.2.2

2015-11-08 Thread Rainer Jung
I forgot (but that is not critical): - lots of javadocs warnings: org/apache/tomcat/jni/Address.java org/apache/tomcat/jni/Buffer.java org/apache/tomcat/jni/Directory.java org/apache/tomcat/jni/File.java org/apache/tomcat/jni/Global.java org/apache/tomcat/jni/Local.java org/apache/tomcat/jni/Loc

Re: [VOTE] Release Apache Tomcat Native 1.2.2

2015-11-07 Thread Rainer Jung
Am 04.11.2015 um 21:15 schrieb Mark Thomas: OK. Here we go again :) Thanks to everyone who has helped test 1.2.x so far. I'm hopeful that this one will be good enough for the 9.0.0 RCs and - fingers crossed - to replace 1.1.x as well. Version 1.2.2 includes the following changes: - Forward port

Re: mod_jk 1.2.40, Apache 2.4.x and ForwardURICompatUnparsed

2015-11-03 Thread Rainer Jung
Am 03.11.2015 um 21:10 schrieb Henri Gomez: Hi all When I upgraded some HTTPd instance from 2.2 to 2.4, I got errors with some VHost using AllowEncodedSlashes On JkOptions +ForwardURICompatUnparsed This is what I should define to avoid Jenkins complain about invalid configuration. Error repor

Re: [VOTE] Release Apache Tomcat Native 1.2.1

2015-11-03 Thread Rainer Jung
Am 03.11.2015 um 17:18 schrieb Christopher Schultz: Mark, On 11/2/15 4:04 PM, Mark Thomas wrote: Version 1.2.1 includes the following changes: - Fix to enable 1.2.x to work with Tomcat releases that do not have the SNI callback implemented on the Java side The proposed release artefacts can

Re: [VOTE] Release Apache Tomcat Native 1.2.1

2015-11-03 Thread Rainer Jung
Am 03.11.2015 um 13:31 schrieb Konstantin Kolinko: 2015-11-03 0:04 GMT+03:00 Mark Thomas : Version 1.2.1 includes the following changes: - Fix to enable 1.2.x to work with Tomcat releases that do not have the SNI callback implemented on the Java side The proposed release artefacts can be fou

Re: svn commit: r10986 - in /dev/tomcat/tomcat-connectors/native/1.2.1: ./ source/

2015-11-02 Thread Rainer Jung
Am 02.11.2015 um 22:32 schrieb Emmanuel Bourg: Le 02/11/2015 21:31, Rainer Jung a écrit : So as a safety check, one could check against c being NULL and throw an exception if it is. Thank you for the suggestion, I'll use that for the Debian package instead. I'll include --enable-

Re: svn commit: r1712026 - in /tomcat/native/tags/TOMCAT_NATIVE_1_2_1: ./ native/include/tcn_version.h

2015-11-02 Thread Rainer Jung
Am 02.11.2015 um 15:52 schrieb ma...@apache.org: Author: markt Date: Mon Nov 2 14:52:01 2015 New Revision: 1712026 URL: http://svn.apache.org/viewvc?rev=1712026&view=rev Log: Tag 1.2.1 Added: tomcat/native/tags/TOMCAT_NATIVE_1_2_1/ - copied from r1712025, tomcat/native/trunk/ Modif

Re: svn commit: r10986 - in /dev/tomcat/tomcat-connectors/native/1.2.1: ./ source/

2015-11-02 Thread Rainer Jung
Am 02.11.2015 um 18:26 schrieb Emmanuel Bourg: Le 02/11/2015 18:11, Emmanuel Bourg a écrit : src/ssl.c: In function 'Java_org_apache_tomcat_jni_SSL_setVerify': src/ssl.c:1557:16: error: 'ctx' undeclared (first use in this function) TCN_ASSERT(ctx != 0); I applied this patch to f

Re: svn commit: r10986 - in /dev/tomcat/tomcat-connectors/native/1.2.1: ./ source/

2015-11-02 Thread Rainer Jung
Am 02.11.2015 um 16:20 schrieb Mark Thomas: On 02/11/2015 15:10, ma...@apache.org wrote: Author: markt Date: Mon Nov 2 15:10:18 2015 New Revision: 10986 Log: Upload Tomcat Native 1.2.1 source files The Windows binaries should follow shortly. I've tested building on OSX from the tar.gz archiv

Re: Plan for Tomcat native 1.2.1

2015-11-01 Thread Rainer Jung
Am 31.10.2015 um 20:17 schrieb Mark Thomas: Given the issues with 1.2.0, I'd like to get 1.2.1 out sooner rather than later and then use that with 9.0.0.RC1. I think all the issues discovered so far have been fixed. If you know of one that hasn't, please speak up. One other observation: there'

Re: Plan for Tomcat native 1.2.1

2015-11-01 Thread Rainer Jung
Am 31.10.2015 um 20:17 schrieb Mark Thomas: Given the issues with 1.2.0, I'd like to get 1.2.1 out sooner rather than later and then use that with 9.0.0.RC1. I think all the issues discovered so far have been fixed. If you know of one that hasn't, please speak up. I noted a crash in TestWebSoc

Re: svn commit: r1711591 - /tomcat/native/trunk/native/buildconf

2015-10-31 Thread Rainer Jung
Am 31.10.2015 um 16:29 schrieb Konstantin Kolinko: 2015-10-31 13:48 GMT+03:00 : Author: rjung Date: Sat Oct 31 10:48:35 2015 New Revision: 1711591 URL: http://svn.apache.org/viewvc?rev=1711591&view=rev Log: buildconf updates: - don't use "test" when not needed - indent "case" - add some checks

Re: [VOTE][RESULT] Release Apache Tomcat Native 1.2.0

2015-10-30 Thread Rainer Jung
Am 30.10.2015 um 23:46 schrieb Rainer Jung: Before the crash, the test logged: ... [junit] 30-Oct-2015 23:32:16.526 INFO [main] org.apache.coyote.AbstractProtocol.pause Pausing ProtocolHandler ["https-apr-127.0.0.1-auto-1-37331"] [junit] 30-Oct-2015 23:32:16.600

Re: [VOTE][RESULT] Release Apache Tomcat Native 1.2.0

2015-10-30 Thread Rainer Jung
I'm sorry to be late to the game here. The source release for Unix/Linux is really broken (but only that source release). I recreated a source tarball using the jnirelease.sh script and that tarball was OK. It looks to me that the following happened during rolling the Unix/Linux src tarball fo

Re: [VOTE] Switch 6.0.x from RTC to CTR

2015-10-29 Thread Rainer Jung
Am 29.10.2015 um 00:57 schrieb Konstantin Kolinko: 2015-10-29 1:42 GMT+03:00 Mark Thomas : All, Many years ago, we switched all release branches to RTC primarily to address a community problem where we could not agree on the best way forward for some parts of the code. RTC served us well. The

Re: [ANN] New committer: Martin Grigorov

2015-10-26 Thread Rainer Jung
Hi Martin, Am 26.10.2015 um 15:35 schrieb Mark Thomas: On behalf of the Tomcat committers I am pleased to announce that Martin Grigorov (mgrigorov) has been voted in as a new Tomcat committer. Please join me in welcoming him. Long time no hear. Nice having you around here! Regards, Rainer

Re: [ANN] New committer: Ognjen Blagojevic

2015-10-25 Thread Rainer Jung
Am 24.10.2015 um 15:58 schrieb Mark Thomas: On behalf of the Tomcat committers I am pleased to announce that Ognjen Blagojevic (ognjen) has been voted in as a new Tomcat committer. Please join me in welcoming him. Congratulations and welcome to the team! Rainer --

Re: [VOTE] Release Apache Tomcat 7.0.65

2015-10-12 Thread Rainer Jung
Am 09.10.2015 um 13:04 schrieb Violeta Georgieva: The proposed Apache Tomcat 7.0.65 release is now available for voting. It can be obtained from: https://dist.apache.org/repos/dist/dev/tomcat/tomcat-7/v7.0.65/ The Maven staging repo is: https://repository.apache.org/content/repositories/orgapach

Re: [VOTE] Release Apache Tomcat 8.0.28

2015-10-10 Thread Rainer Jung
Am 07.10.2015 um 21:13 schrieb Mark Thomas: The proposed Apache Tomcat 8.0.28 release is now available for voting. The main changes since 8.0.27 are: - Allow file based configuration resources (e.g. key stores) to be configured using URLs - Restore code signing to the Windows installer an u

Re: [VOTE] Release Apache Tomcat 8.0.27

2015-09-30 Thread Rainer Jung
Am 28.09.2015 um 13:26 schrieb Mark Thomas: The proposed Apache Tomcat 8.0.27 release is now available for voting. The main changes since 8.0.26 are: - Correctly handle \${ vs \$ escaping in JSP and EL - Fix for issues with NIO + SSL + sendfile - Various TLD parsing fixes - Fix multiple (mos

Re: AJP Protocol enhancements

2015-09-24 Thread Rainer Jung
Am 24.09.2015 um 11:04 schrieb Mark Thomas: On 24/09/2015 02:45, Andrew Carr wrote: Devs, I have been following the AJP enhancements for a long time and it seems the protocol is stagnant. I prefer 'mature'. I do see some updates in the last year to the enhancements page and some of the bugs

Re: svn commit: r1700900 - in /tomcat/tc6.0.x/trunk: STATUS.txt java/org/apache/catalina/util/RequestUtil.java

2015-09-02 Thread Rainer Jung
Am 02.09.2015 um 23:08 schrieb Konstantin Kolinko: 2015-09-03 0:00 GMT+03:00 Mark Thomas : On 02/09/2015 21:46, ma...@apache.org wrote: Author: markt Date: Wed Sep 2 20:46:17 2015 New Revision: 1700900 URL: http://svn.apache.org/r1700900 Log: Update proposal Modified: tomcat/tc6.0.x/tru

Merging Netty and Twitter fork of tcnative back

2015-06-04 Thread Rainer Jung
There are some forks of tcnative. One from twitter named finagle-native: https://github.com/twitter/finagle/tree/master/finagle-native mostly in the form of a big patch: https://github.com/twitter/finagle/blob/master/finagle-native/tomcat-native-1.1.27.finagle.patch Another one inside Netty:

Re: End of life for 6.0.x

2015-05-29 Thread Rainer Jung
Am 14.05.2015 um 15:14 schrieb Mark Thomas: For some time now we have always said we will maintain three current Tomcat versions in parallel. As we start to think about milestone releases of Tomcat 9 soon (stable is unlikely to be until later next year due to the Java EE 8 timescales) I think now

Re: HTTP/2 progress report

2015-05-29 Thread Rainer Jung
Am 29.05.2015 um 11:13 schrieb Mark Thomas: On 15/05/2015 19:46, Rémy Maucherat wrote: 2015-05-13 22:57 GMT+02:00 Mark Thomas : The next steps are to get a basic implementation working which means: - figure out how to feed requests into Tomcat's processing chain - figure out how to extract

Re: svn commit: r1681807 - /tomcat/trunk/java/org/apache/tomcat/util/net/SSLHostConfig.java

2015-05-26 Thread Rainer Jung
Am 26.05.2015 um 20:31 schrieb r...@apache.org: Author: remm Date: Tue May 26 18:31:20 2015 New Revision: 1681807 URL: http://svn.apache.org/r1681807 Log: It works better like this. Modified: tomcat/trunk/java/org/apache/tomcat/util/net/SSLHostConfig.java Modified: tomcat/trunk/java/org/a

Re: TC trunk: protocol in SSLHostConfig only for OpenSSL?

2015-05-26 Thread Rainer Jung
Am 26.05.2015 um 18:02 schrieb Rémy Maucherat: 2015-05-26 17:40 GMT+02:00 Rainer Jung : I'm a bit confused: is "protocol" in SSLHostConfig only for OpenSSL, or also for JSSE? There's also sslProtocol, which seems to be for JSSE but the docs looked like protocol were for bo

TC trunk: protocol in SSLHostConfig only for OpenSSL?

2015-05-26 Thread Rainer Jung
I'm a bit confused: is "protocol" in SSLHostConfig only for OpenSSL, or also for JSSE? There's also sslProtocol, which seems to be for JSSE but the docs looked like protocol were for both. Or is it work in progress? Thanks for any hints. Rainer

Re: buildbot failure in ASF Buildbot on tomcat-8-trunk

2015-05-26 Thread Rainer Jung
Apart from the one failed test (BIO TestWebSocketFrameClient) CI logs all tests as having skipped tests, because the test run output does not contain "Skipped: 0" (checked in our build.xml). Locally executed tests print: [junit] Tests run: 23, Failures: 0, Errors: 0, Skipped: 0, Time elapsed:

Re: Looking for a good doc place

2015-05-26 Thread Rainer Jung
Am 25.05.2015 um 15:44 schrieb Rémy Maucherat: 2015-05-24 15:34 GMT+02:00 Rainer Jung : I need to add some info to the tcnative docs concerning using a native SSL connector and I'm quite uncertain where to add it. It will roughly be: Starting with version 1.1.34 of the APR/native conn

Re: Supporting multiple certificates

2015-05-25 Thread Rainer Jung
Hi Chris, Am 25.05.2015 um 14:01 schrieb Christopher Schultz: Rainer, On 5/24/15 2:09 PM, Rainer Jung wrote: mod_ssl supports multiple certificates for the same host, one with RSA key, one with DSA key and one with EC key. They can be configured at the same time. So the connector would be

Re: Drop support for EXPORT ciphers in tcnative 1.1?

2015-05-25 Thread Rainer Jung
Am 25.05.2015 um 14:05 schrieb Christopher Schultz: Rainer, On 5/24/15 2:12 PM, Rainer Jung wrote: Am 24.05.2015 um 18:33 schrieb Mark Thomas: On 23 May 2015 17:03:21 BST, Rainer Jung wrote: mod_ssl dropped support for EXPORT ciphers in Apache 2.4 some time ago and will also drop it in

Strange 1000 seconds timeout in AprEndpoint

2015-05-24 Thread Rainer Jung
When testing tcnative I observed a strange 1000 seconds timeout. The occurrence of the timeout was likely due to using an old OpenSSL version (0.9.8m) in combination with the unit tests that want a newer one, but I found the long duration of 1000 seconds strange. It happens in TestSsl.testSimp

tcnative commit flood

2015-05-24 Thread Rainer Jung
Just a short explanation: triggered by logjam I wanted to improve DH ephemeral key handling in tcnative. I had the BZ issue on my watch list and knew that mod_ssl had already improved a lot in that area. When looking at tcnative I noticed, that trunk now is no longer just an old fork one could

Re: svn commit: r1681218 - in /tomcat/native/trunk/native: include/ssl_private.h src/ssl.c src/sslutils.c

2015-05-24 Thread Rainer Jung
Am 24.05.2015 um 20:04 schrieb Christopher Schultz: Rainer, On 5/22/15 3:54 PM, rj...@apache.org wrote: Author: rjung Date: Fri May 22 19:54:09 2015 New Revision: 1681218 URL: http://svn.apache.org/r1681218 Log: Port mod_ssl improvements to tcnative/ssl: r1605827 | jorton | 2014-06-26 17:49:4

Re: Drop support for EXPORT ciphers in tcnative 1.1?

2015-05-24 Thread Rainer Jung
Am 24.05.2015 um 20:10 schrieb Christopher Schultz: Rainer, On 5/23/15 12:03 PM, Rainer Jung wrote: mod_ssl dropped support for EXPORT ciphers in Apache 2.4 some time ago and will also drop it in Apache 2.2 in the soon to be released next version. I applied a similar change to tcnative trunk

Re: Drop support for EXPORT ciphers in tcnative 1.1?

2015-05-24 Thread Rainer Jung
Am 24.05.2015 um 18:33 schrieb Mark Thomas: On 23 May 2015 17:03:21 BST, Rainer Jung wrote: mod_ssl dropped support for EXPORT ciphers in Apache 2.4 some time ago and will also drop it in Apache 2.2 in the sonn to be released next version. I applied a similar change to tcnative trunk and

Supporting multiple certificates

2015-05-24 Thread Rainer Jung
mod_ssl supports multiple certificates for the same host, one with RSA key, one with DSA key and one with EC key. They can be configured at the same time. Altough tcnative has the code to handle that, we currently do not wire it. We would need an way to express in the ssl config, that multiple

Looking for a good doc place

2015-05-24 Thread Rainer Jung
I need to add some info to the tcnative docs concerning using a native SSL connector and I'm quite uncertain where to add it. It will roughly be: Starting with version 1.1.34 of the APR/native connector, the strength of ephemeral keys for DH ciphers are by default chosen depending on the key s

Re: [GUMP@vmgump]: Project tomcat-native-make (in module tomcat-native) failed

2015-05-24 Thread Rainer Jung
Am 24.05.2015 um 00:57 schrieb Bill Barker: ... /bin/bash /srv/gump/public/workspace/apr-1/dest-20150524/build-1/libtool --silent --mode=compile gcc -g -O2 -pthread -DHAVE_CONFIG_H -DLINUX -D_REENTRANT -D_GNU_SOURCE -g -O2 -DHAVE_OPENSSL -I/srv/gump/public/workspace/tomcat-native/nativ

Drop support for EXPORT ciphers in tcnative 1.1?

2015-05-23 Thread Rainer Jung
mod_ssl dropped support for EXPORT ciphers in Apache 2.4 some time ago and will also drop it in Apache 2.2 in the sonn to be released next version. I applied a similar change to tcnative trunk and would also like to apply it to 1.1. Note that "drop support" would mean you can no longer enable

Re: OK to require APR 1.3 for tcnative 1.1?

2015-05-23 Thread Rainer Jung
Am 23.05.2015 um 12:40 schrieb Rainer Jung: Scrap that question, 1.1 already requires APR 1.3. And again I have to correct myself: we only require 1.2.1 but suggest 1.3. We use a 1.3 feature but only in form of the flag APR_POLLSET_NOCOPY which gets defined to 0 if the APR version is to old

Re: svn commit: r1681138 - in /tomcat/trunk/java/org/apache/catalina/util: LifecycleBase.java LocalStrings.properties

2015-05-23 Thread Rainer Jung
Feel free to revert my change (I won't be near my laptop for a few days.). The bz issue needs a more careful look. It might end up as won't fix. Throw during start, log during stop might work but I can't remember how this interacts with the error state. Will do. Have a nice time far from th

Re: OK to require APR 1.3 for tcnative 1.1?

2015-05-23 Thread Rainer Jung
Scrap that question, 1.1 already requires APR 1.3. Am 23.05.2015 um 12:36 schrieb Rainer Jung: APR is currently at 1.5.x and APR 1.3 goes back to 2008. Some of the differences between 1.1 and trunk are only because APR 1.2 is supported in 1.1. Is it OK to update the minimum required APR

OK to require APR 1.3 for tcnative 1.1?

2015-05-23 Thread Rainer Jung
APR is currently at 1.5.x and APR 1.3 goes back to 2008. Some of the differences between 1.1 and trunk are only because APR 1.2 is supported in 1.1. Is it OK to update the minimum required APR version to 1.3? Regards, Rainer ---

Re: svn commit: r1681138 - in /tomcat/trunk/java/org/apache/catalina/util: LifecycleBase.java LocalStrings.properties

2015-05-23 Thread Rainer Jung
Am 22.05.2015 um 16:55 schrieb ma...@apache.org: Author: markt Date: Fri May 22 14:55:06 2015 New Revision: 1681138 URL: http://svn.apache.org/r1681138 Log: Log errors processing LifecycleListener events and continue rather than allowing uncaught exception to propagate Modified: tomcat/tr

Re: ALPN in tcnative trunk

2015-05-22 Thread Rainer Jung
Am 22.05.2015 um 15:25 schrieb Mark Thomas: On 22/05/2015 14:14, Rainer Jung wrote: I get confused by ALPM in tcnative trunk. What is the semantics of the member alpn of tcn_ssl_ctxt_t: - a string - an array of strings - an array of individual characters None of the above! I get confused

ALPN in tcnative trunk

2015-05-22 Thread Rainer Jung
I get confused by ALPM in tcnative trunk. What is the semantics of the member alpn of tcn_ssl_ctxt_t: - a string - an array of strings - an array of individual characters I get confused by the code in src/sslcontext.c. Just in case there's something wrong I can help to clean up but first I wa

Re: svn commit: r1672272 - /tomcat/trunk/bin/catalina.sh

2015-04-09 Thread Rainer Jung
Am 09.04.2015 um 11:57 schrieb Konstantin Kolinko: 2015-04-09 12:24 GMT+03:00 : Author: rjung Date: Thu Apr 9 09:24:49 2015 New Revision: 1672272 URL: http://svn.apache.org/r1672272 Log: BZ57801: Give a hint on what to do. This might happen, if a system reboot happens, Tomcat is not shut dow

Re: [GUMP@vmgump]: Project tomcat-tc8.0.x (in module tomcat-8.0.x) failed

2015-04-09 Thread Rainer Jung
Am 09.04.2015 um 02:57 schrieb Bill Barker: To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project tomcat-tc8.0.x has an issue affecting

Re: svn commit: r1672068 - /tomcat/native/trunk/native/src/ssl.c

2015-04-08 Thread Rainer Jung
Am 08.04.2015 um 21:00 schrieb Christopher Schultz: Mark, On 4/8/15 7:47 AM, ma...@apache.org wrote: Author: markt Date: Wed Apr 8 11:47:09 2015 New Revision: 1672068 URL: http://svn.apache.org/r1672068 Log: Remove unnecessary directives since the minimum OpenSSL version is 1.0.2 Maybe we w

Re: [VOTE] Release Apache Tomcat 7.0.61

2015-04-06 Thread Rainer Jung
Am 27.03.2015 um 13:36 schrieb Violeta Georgieva: The proposed Apache Tomcat 7.0.61 release is now available for voting. It can be obtained from: https://dist.apache.org/repos/dist/dev/tomcat/tomcat-7/v7.0.61/ The Maven staging repo is: https://repository.apache.org/content/repositories/orgapach

Re: [VOTE] Release Apache Tomcat 7.0.61

2015-04-06 Thread Rainer Jung
Am 06.04.2015 um 09:43 schrieb Violeta Georgieva: Hi, 2015-03-27 14:36 GMT+02:00 Violeta Georgieva : The proposed Apache Tomcat 7.0.61 release is now available for voting. It can be obtained from: https://dist.apache.org/repos/dist/dev/tomcat/tomcat-7/v7.0.61/ The Maven staging repo is: https

Re: Time to switch tc-native development to trunk?

2015-04-03 Thread Rainer Jung
Am 03.04.2015 um 11:33 schrieb Mark Thomas: Keep in mind that the Java EE 8 schedule is that it won't be final until at least the second half of 2016 so if we did require OpenSSL 1.0.2 that would give it plenty of time to iron out any teething issues. +1, that was my first thought. Although I e

Re: svn commit: r1670609 - /tomcat/tc8.0.x/trunk/webapps/docs/changelog.xml

2015-04-01 Thread Rainer Jung
Am 01.04.2015 um 12:45 schrieb ma...@apache.org: Author: markt Date: Wed Apr 1 10:45:04 2015 New Revision: 1670609 URL: http://svn.apache.org/r1670609 Log: Update changelog Modified: tomcat/tc8.0.x/trunk/webapps/docs/changelog.xml Modified: tomcat/tc8.0.x/trunk/webapps/docs/changelog.xml

Re: [GUMP@vmgump]: Project tomcat-native-make (in module tomcat-native) failed

2015-03-26 Thread Rainer Jung
Am 26.03.2015 um 00:45 schrieb Bill Barker: To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project tomcat-native-make has an issue affect

Re: [VOTE] Release Apache Tomcat Native 1.1.33

2015-03-19 Thread Rainer Jung
Am 19.03.2015 um 17:52 schrieb Mark Thomas: Version 1.1.33 includes the following changes: - Windows binaries built with APR 1.5.1 and OpenSSL 1.0.1m - Fix BZ57653: Crash when multiple events for same socket are returned via separate apr_pollfd_t structures. The proposed release artefacts can

Re: Tomcat native 1.1.33 release

2015-03-19 Thread Rainer Jung
Am 16.03.2015 um 21:26 schrieb Mark Thomas: On 16/03/2015 20:17, Rainer Jung wrote: Am 13.03.2015 um 12:17 schrieb Mark Thomas: On 12/03/2015 19:09, Christopher Schultz wrote: Konstantin, On 3/12/15 2:22 PM, Konstantin Kolinko wrote: 2015-03-12 18:59 GMT+03:00 Rainer Jung : Am 12.03.2015

Re: Test for BZ 57621 fails sporadically

2015-03-18 Thread Rainer Jung
Am 18.03.2015 um 22:50 schrieb Mark Thomas: On 18/03/2015 13:52, Rainer Jung wrote: Just a heads up: Trunk, TC 8 and TC 7 fail on Gump for various connectors sporadically at Testcase: testBug57621 took 3.145 sec FAILED null junit.framework.AssertionFailedError at

Test for BZ 57621 fails sporadically

2015-03-18 Thread Rainer Jung
Just a heads up: Trunk, TC 8 and TC 7 fail on Gump for various connectors sporadically at Testcase: testBug57621 took 3.145 sec FAILED null junit.framework.AssertionFailedError at org.apache.coyote.http11.TestAbstractHttp11Processor.testBug57621(TestAbstractHttp11Processor.java:

Re: Tomcat native 1.1.33 release

2015-03-16 Thread Rainer Jung
Am 13.03.2015 um 12:17 schrieb Mark Thomas: On 12/03/2015 19:09, Christopher Schultz wrote: Konstantin, On 3/12/15 2:22 PM, Konstantin Kolinko wrote: 2015-03-12 18:59 GMT+03:00 Rainer Jung : Am 12.03.2015 um 14:04 schrieb Mark Thomas: Given bug 57653 [1], the next 8.0.x release (which is

Re: Tomcat native 1.1.33 release

2015-03-12 Thread Rainer Jung
Am 12.03.2015 um 14:04 schrieb Mark Thomas: Given bug 57653 [1], the next 8.0.x release (which is already over due from when I wanted to get it out) is going to need a new Tomcat native release. This would also be an opportunity to update the OpenSSl dependency in the Windows binaries. One quest

Re: Tomcat native 1.1.33 release

2015-03-12 Thread Rainer Jung
Am 12.03.2015 um 15:05 schrieb Christopher Schultz: Mark, On 3/12/15 9:04 AM, Mark Thomas wrote: Given bug 57653 [1], the next 8.0.x release (which is already over due from when I wanted to get it out) is going to need a new Tomcat native release. This would also be an opportunity to update the

Re: svn commit: r1665888 - /tomcat/native/branches/1.1.x/native/src/poll.c

2015-03-11 Thread Rainer Jung
Am 11.03.2015 um 15:45 schrieb Mark Thomas: On 11/03/2015 14:44, ma...@apache.org wrote: Author: markt Date: Wed Mar 11 14:44:23 2015 New Revision: 1665888 URL: http://svn.apache.org/r1665888 Log: Fix 57653. Crash when multiple events for same socket are returned via separate apr_pollfd_t stru

Re: Unsecure use of DH-Cipher

2015-03-10 Thread Rainer Jung
Am 10.03.2015 um 17:36 schrieb Rainer Jung: Am 10.03.2015 um 17:16 schrieb Robert Paasche: Hi guys, as requested by chris some explanation to the problem. The problem is, that openssl call the method "SSL_callback_tmp_DH" with keylen value of 512 or 1024. This cause that the cip

Re: Unsecure use of DH-Cipher

2015-03-10 Thread Rainer Jung
Am 10.03.2015 um 17:16 schrieb Robert Paasche: Hi guys, as requested by chris some explanation to the problem. The problem is, that openssl call the method "SSL_callback_tmp_DH" with keylen value of 512 or 1024. This cause that the cipher of the ssl handshake (key exchange) for a ssl-connectio

Re: [GUMP@vmgump]: Project tomcat-tc8.0.x-test-apr (in module tomcat-8.0.x) failed

2015-03-01 Thread Rainer Jung
TC 8 APR crash in TestWsSubprotocols. This is different from the failure for trunk (org.apache.catalina.nonblocking.TestNonBlockingAPI fails in testNonBlockingWriteError "Error listener should have been invoked."): [junit] Running org.apache.tomcat.websocket.TestWsSubprotocols [junit] 0

Re: [GUMP@vmgump]: Project tomcat-tc8.0.x-test-nio (in module tomcat-8.0.x) failed

2015-02-28 Thread Rainer Jung
Am 28.02.2015 um 14:37 schrieb Rainer Jung: Am 28.02.2015 um 13:07 schrieb Bill Barker: test: [concat] Testsuites with skipped tests: [concat] TEST-org.apache.catalina.connector.TestRequest.NIO.txt [concat] TEST-org.apache.tomcat.util.net.TestClientCert.NIO.txt [concat] TEST

Re: [GUMP@vmgump]: Project tomcat-tc8.0.x-test-nio (in module tomcat-8.0.x) failed

2015-02-28 Thread Rainer Jung
Am 28.02.2015 um 13:07 schrieb Bill Barker: test: [concat] Testsuites with skipped tests: [concat] TEST-org.apache.catalina.connector.TestRequest.NIO.txt [concat] TEST-org.apache.tomcat.util.net.TestClientCert.NIO.txt [concat] TEST-org.apache.tomcat.util.net.TestCustomSsl.NIO.txt

Re: svn commit: r1661932 - /tomcat/trunk/test/org/apache/tomcat/util/net/jsse/openssl/TesterOpenSSL.java

2015-02-24 Thread Rainer Jung
Am 24.02.2015 um 14:28 schrieb Mark Thomas: On 24/02/2015 13:15, Rainer Jung wrote: Am 24.02.2015 um 14:09 schrieb ma...@apache.org: Author: markt Date: Tue Feb 24 13:09:26 2015 New Revision: 1661932 URL: http://svn.apache.org/r1661932 Log: Reduce Gump's OpenSSL failures from 31

Re: svn commit: r1661932 - /tomcat/trunk/test/org/apache/tomcat/util/net/jsse/openssl/TesterOpenSSL.java

2015-02-24 Thread Rainer Jung
Am 24.02.2015 um 14:09 schrieb ma...@apache.org: Author: markt Date: Tue Feb 24 13:09:26 2015 New Revision: 1661932 URL: http://svn.apache.org/r1661932 Log: Reduce Gump's OpenSSL failures from 31 to 29 Modified: tomcat/trunk/test/org/apache/tomcat/util/net/jsse/openssl/TesterOpenSSL.java

<    1   2   3   4   5   6   7   8   9   10   >