[GitHub] [tomcat] rmaucher commented on pull request #371: NIO2: Call `accept` immediately if connection count is not close to max con…

2020-10-29 Thread GitBox
rmaucher commented on pull request #371: URL: https://github.com/apache/tomcat/pull/371#issuecomment-718885690 Hum, ok, since incrementing is not done in parallel, then it's something that can be tried. This is an automated

[GitHub] [tomcat] anilgursel commented on pull request #371: NIO2: Call `accept` immediately if connection count is not close to max con…

2020-10-29 Thread GitBox
anilgursel commented on pull request #371: URL: https://github.com/apache/tomcat/pull/371#issuecomment-718799285 I updated the PR to have it as `getMaxConnections() / 2`. I agree it is just a heuristic and not clean. We can potentially make it configurable? If my understanding is

[GitHub] [tomcat] rmaucher commented on pull request #371: NIO2: Call `accept` immediately if connection count is not close to max con…

2020-10-29 Thread GitBox
rmaucher commented on pull request #371: URL: https://github.com/apache/tomcat/pull/371#issuecomment-718632321 maxConnections overall is a bad design for NIO2, that is a bit obvious. It started with connections not being counted accurately then after some iterative refactorings of close

[GitHub] [tomcat] CheerfulSrr closed pull request #374: 配置idea运行方式

2020-10-24 Thread GitBox
CheerfulSrr closed pull request #374: URL: https://github.com/apache/tomcat/pull/374 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [tomcat] CheerfulSrr opened a new pull request #374: 配置idea运行方式

2020-10-24 Thread GitBox
CheerfulSrr opened a new pull request #374: URL: https://github.com/apache/tomcat/pull/374 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [tomcat] dao-jun commented on pull request #373: lazy set filed `DELETE_FILES_SERVICE`

2020-10-22 Thread GitBox
dao-jun commented on pull request #373: URL: https://github.com/apache/tomcat/pull/373#issuecomment-714864911 > Please provide more information what kind of issue you have now! > The description is a bit vague at the moment. We use `java agent` to enhance class

[GitHub] [tomcat] martin-g commented on pull request #373: lazy set filed `DELETE_FILES_SERVICE`

2020-10-22 Thread GitBox
martin-g commented on pull request #373: URL: https://github.com/apache/tomcat/pull/373#issuecomment-714587911 Please provide more information what kind of issue you have now! The description is a bit vague at the moment.

[GitHub] [tomcat] dao-jun opened a new pull request #373: lazy set filed `DELETE_FILES_SERVICE`

2020-10-22 Thread GitBox
dao-jun opened a new pull request #373: URL: https://github.com/apache/tomcat/pull/373 Lazy set field `DELETE_FILES_SERVICE` to avoid class `ThreadPoolExecutor` loaded earlier than tomcat start. Actually, some `APM` systems enhance class `ThreadPoolExecutor` with `java agent`, the

[GitHub] [tomcat] dao-jun commented on pull request #372: Update FileHandler.java

2020-10-22 Thread GitBox
dao-jun commented on pull request #372: URL: https://github.com/apache/tomcat/pull/372#issuecomment-714342340 > The DELETE_FILES_SERVICE executor is intended to be a singleton. This PR breaks that and is, therefore, unlikely to be applied. Yep, I forgot that. The pr will be closed

[GitHub] [tomcat] dao-jun closed pull request #372: Update FileHandler.java

2020-10-22 Thread GitBox
dao-jun closed pull request #372: URL: https://github.com/apache/tomcat/pull/372 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [tomcat] markt-asf commented on pull request #372: Update FileHandler.java

2020-10-22 Thread GitBox
markt-asf commented on pull request #372: URL: https://github.com/apache/tomcat/pull/372#issuecomment-714333180 The DELETE_FILES_SERVICE executor is intended to be a singleton. This PR breaks that and is, therefore, unlikely to be applied.

[GitHub] [tomcat] dao-jun opened a new pull request #372: Update FileHandler.java

2020-10-22 Thread GitBox
dao-jun opened a new pull request #372: URL: https://github.com/apache/tomcat/pull/372 remove static keyword from `DELETE_FILES_SERVICE` to avoid class `ThreadPoolExecutor` loaded earlier than agent start. It can cause agent enhance class `ThreadPoolExecutor` failed.

[GitHub] [tomcat] anilgursel opened a new pull request #371: Call `accept` immediately if connection count is not close to max con…

2020-10-20 Thread GitBox
anilgursel opened a new pull request #371: URL: https://github.com/apache/tomcat/pull/371 …nections Under regular load, we observe NIO2 has better CPU utilization and slightly better latency compared to NIO1. However, under heavy load or during spikes, we observed that the 99th

[GitHub] [tomcat] blueSky1825821 commented on pull request #368: fix: CachedResource add path length

2020-10-13 Thread GitBox
blueSky1825821 commented on pull request #368: URL: https://github.com/apache/tomcat/pull/368#issuecomment-707629467 > I've done some calculations and the absolute upper limit (the actual upper limit will be lower) is that a cache with a 10MB limit on size will actually use a little under

[GitHub] [tomcat] markt-asf closed pull request #370: Polish LocalStrings_zh_CN.properties

2020-10-12 Thread GitBox
markt-asf closed pull request #370: URL: https://github.com/apache/tomcat/pull/370 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [tomcat] markt-asf commented on pull request #370: Polish LocalStrings_zh_CN.properties

2020-10-12 Thread GitBox
markt-asf commented on pull request #370: URL: https://github.com/apache/tomcat/pull/370#issuecomment-707210751 Thanks for the PR. The Tomcat project manages i18n files via poeditor.com I've made these changes there (as well as several others I found) and I'll import them shortly.

[GitHub] [tomcat] ijliym opened a new pull request #370: Polish LocalStrings_zh_CN.properties

2020-10-12 Thread GitBox
ijliym opened a new pull request #370: URL: https://github.com/apache/tomcat/pull/370 Remove unexpected '('. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [tomcat] markt-asf closed pull request #369: UDecoder does not properly convert when EncodedSolidusHandling is PASS_THROUGH and non-solidus encoded characters are present before the solidus

2020-10-09 Thread GitBox
markt-asf closed pull request #369: URL: https://github.com/apache/tomcat/pull/369 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [tomcat-jakartaee-migration] darmbrust commented on issue #5: ability to ignore file extensions?

2020-10-09 Thread GitBox
darmbrust commented on issue #5: URL: https://github.com/apache/tomcat-jakartaee-migration/issues/5#issuecomment-705728238 For reference, this is the zip file the tool is failing on: https://github.com/rubyzip/rubyzip/blob/master/test/data/gpbit3stored.zip From the context of the

[GitHub] [tomcat] markt-asf commented on pull request #369: UDecoder does not properly convert when EncodedSolidusHandling is PASS_THROUGH and non-solidus encoded characters are present before the sol

2020-10-09 Thread GitBox
markt-asf commented on pull request #369: URL: https://github.com/apache/tomcat/pull/369#issuecomment-706113097 Thanks for the PR. I've applied a variation of your proposed fix along with some additional unit tests to: - 10.0.x for 10.0.0-M10 onwards - 9.0.x for 9.0.40 onwards -

[GitHub] [tomcat] markt-asf commented on pull request #369: UDecoder does not properly convert when EncodedSolidusHandling is PASS_THROUGH and non-solidus encoded characters are present before the sol

2020-10-09 Thread GitBox
markt-asf commented on pull request #369: URL: https://github.com/apache/tomcat/pull/369#issuecomment-706113097 Thanks for the PR. I've applied a variation of your proposed fix along with some additional unit tests to: - 10.0.x for 10.0.0-M10 onwards - 9.0.x for 9.0.40 onwards -

[GitHub] [tomcat] markt-asf closed pull request #369: UDecoder does not properly convert when EncodedSolidusHandling is PASS_THROUGH and non-solidus encoded characters are present before the solidus

2020-10-09 Thread GitBox
markt-asf closed pull request #369: URL: https://github.com/apache/tomcat/pull/369 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [tomcat] willmeck opened a new pull request #369: UDecoder does not properly convert when EncodedSolidusHandling is PASS_THROUGH and non-solidus encoded characters are present before the soli

2020-10-08 Thread GitBox
willmeck opened a new pull request #369: URL: https://github.com/apache/tomcat/pull/369 https://github.com/willmeck/tomcat-test-app - small test project showcasing the issue and fix When EncodedSolidusHandling is PASS_THROUGH, and other non-solidus encoded characters, such as

[GitHub] [tomcat-jakartaee-migration] darmbrust commented on issue #5: ability to ignore file extensions?

2020-10-08 Thread GitBox
darmbrust commented on issue #5: URL: https://github.com/apache/tomcat-jakartaee-migration/issues/5#issuecomment-705728238 For reference, this is the zip file the tool is failing on: https://github.com/rubyzip/rubyzip/blob/master/test/data/gpbit3stored.zip From the context of the

[GitHub] [tomcat-jakartaee-migration] darmbrust opened a new issue #5: ability to ignore file extensions?

2020-10-08 Thread GitBox
darmbrust opened a new issue #5: URL: https://github.com/apache/tomcat-jakartaee-migration/issues/5 I've been using this tool, to try out an entire stack with these changes, and we have one webapp which is a JRuby application. Using this tool on the war file produced by our JRuby

[GitHub] [tomcat] markt-asf commented on pull request #361: Add a GitHub action to lint the Markdown and YAML files.

2020-10-05 Thread GitBox
markt-asf commented on pull request #361: URL: https://github.com/apache/tomcat/pull/361#issuecomment-703802985 A couple of those files appear to be missing ALv2 headers. On that topic, it looks like the markdown files need an ALv2 header if possible as well.

[GitHub] [tomcat] markt-asf commented on pull request #368: fix: CachedResource add path length

2020-10-05 Thread GitBox
markt-asf commented on pull request #368: URL: https://github.com/apache/tomcat/pull/368#issuecomment-703797902 Fixed in: - master for 10.0.0-M9 onwards - 9.0.x for 9.0.39 onwards - 8.5.x for 8.5.59 onwards This

[GitHub] [tomcat] markt-asf closed pull request #368: fix: CachedResource add path length

2020-10-05 Thread GitBox
markt-asf closed pull request #368: URL: https://github.com/apache/tomcat/pull/368 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [tomcat] markt-asf commented on pull request #368: fix: CachedResource add path length

2020-10-05 Thread GitBox
markt-asf commented on pull request #368: URL: https://github.com/apache/tomcat/pull/368#issuecomment-703794569 I've done some calculations and the absolute upper limit (the actual upper limit will be lower) is that a cache with a 10MB limit on size will actually use a little under 175MB.

[GitHub] [tomcat-jakartaee-migration] markt-asf commented on issue #4: Download of Release

2020-10-05 Thread GitBox
markt-asf commented on issue #4: URL: https://github.com/apache/tomcat-jakartaee-migration/issues/4#issuecomment-703474248 We'd need to go through the ASF release process (not arduous but requires a little setting up as this is a new deliverable for the Tomcat project) and the primary

[GitHub] [tomcat-jakartaee-migration] martin-g commented on issue #4: Download of Release

2020-10-05 Thread GitBox
martin-g commented on issue #4: URL: https://github.com/apache/tomcat-jakartaee-migration/issues/4#issuecomment-703465446 Since this tool is not supposed to be used as a (Maven/Gradle) dependency there is no really point in uploading it to Maven Central. But we can publish GitHub

[GitHub] [tomcat-jakartaee-migration] Horcrux7 commented on issue #4: Download of Release

2020-10-04 Thread GitBox
Horcrux7 commented on issue #4: URL: https://github.com/apache/tomcat-jakartaee-migration/issues/4#issuecomment-703237186 A software developer has the source code of its projects and does not need your tool. It look for me more as a tool for administrators. So it might be. A tool

[GitHub] [tomcat-jakartaee-migration] ChristopherSchultz closed issue #4: Download of Release

2020-10-03 Thread GitBox
ChristopherSchultz closed issue #4: URL: https://github.com/apache/tomcat-jakartaee-migration/issues/4 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [tomcat-jakartaee-migration] ChristopherSchultz commented on issue #4: Download of Release

2020-10-03 Thread GitBox
ChristopherSchultz commented on issue #4: URL: https://github.com/apache/tomcat-jakartaee-migration/issues/4#issuecomment-703100871 This is intended to be a tool used by developers. Anyone qualified to use this tool should also be qualified to build it from source. Don't expect a binary

[GitHub] [tomcat-jakartaee-migration] Horcrux7 commented on issue #4: Download of Release

2020-10-02 Thread GitBox
Horcrux7 commented on issue #4: URL: https://github.com/apache/tomcat-jakartaee-migration/issues/4#issuecomment-702938334 Ok, I will wait until a binary version is available. This is an automated message from the Apache Git

[GitHub] [tomcat-jakartaee-migration] martin-g commented on issue #4: Download of Release

2020-10-02 Thread GitBox
martin-g commented on issue #4: URL: https://github.com/apache/tomcat-jakartaee-migration/issues/4#issuecomment-702628531 There is no such at the moment. You have to build it locally. This is an automated message from the

[GitHub] [tomcat-jakartaee-migration] Horcrux7 opened a new issue #4: Download of Release

2020-10-02 Thread GitBox
Horcrux7 opened a new issue #4: URL: https://github.com/apache/tomcat-jakartaee-migration/issues/4 Is there any download of the released version? For example in bintray or maven repository. I was not able to find it. This

[GitHub] [tomcat] markt-asf closed pull request #360: Fix 64735 ServletContext.addJspFile() always fails with SecurityManager

2020-09-30 Thread GitBox
markt-asf closed pull request #360: URL: https://github.com/apache/tomcat/pull/360 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [tomcat] markt-asf closed pull request #359: Fix 64735 ServletContext.addJspFile() always fails with SecurityManager

2020-09-30 Thread GitBox
markt-asf closed pull request #359: URL: https://github.com/apache/tomcat/pull/359 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [tomcat] markt-asf commented on pull request #359: Fix 64735 ServletContext.addJspFile() always fails with SecurityManager

2020-09-30 Thread GitBox
markt-asf commented on pull request #359: URL: https://github.com/apache/tomcat/pull/359#issuecomment-701522483 Thanks. Applied manually so I could make a few minor tweaks (mainly for consistency with existing tests). Also back-ported to 8.5.x and 7.0.x,

[GitHub] [tomcat] markt-asf commented on pull request #360: Fix 64735 ServletContext.addJspFile() always fails with SecurityManager

2020-09-30 Thread GitBox
markt-asf commented on pull request #360: URL: https://github.com/apache/tomcat/pull/360#issuecomment-701522275 Thanks. Applied manually so I could make a few minor tweaks (mainly for consistency with existing tests). Also back-ported to 8.5.x and 7.0.x,

[GitHub] [tomcat] markt-asf commented on pull request #359: Fix 64735 ServletContext.addJspFile() always fails with SecurityManager

2020-09-30 Thread GitBox
markt-asf commented on pull request #359: URL: https://github.com/apache/tomcat/pull/359#issuecomment-701253890 Many thanks for this. I particularly like the way you implemented the unit test. I am currently leaning towards packaging the test slightly differently so I'll apply this

[GitHub] [tomcat] blueSky1825821 removed a comment on pull request #368: fix: CachedResource add path length

2020-09-29 Thread GitBox
blueSky1825821 removed a comment on pull request #368: URL: https://github.com/apache/tomcat/pull/368#issuecomment-700584396 > What is the justification for this change? What problem does it solve? When our application is loaded in another path or attacked in an unknown way, webapp

[GitHub] [tomcat] blueSky1825821 commented on pull request #368: fix: CachedResource add path length

2020-09-29 Thread GitBox
blueSky1825821 commented on pull request #368: URL: https://github.com/apache/tomcat/pull/368#issuecomment-700585098 > > What is the justification for this change? What problem does it solve? > > When our application is loaded in another path or attacked in an unknown way, webapp

[GitHub] [tomcat] blueSky1825821 commented on pull request #368: fix: CachedResource add path length

2020-09-29 Thread GitBox
blueSky1825821 commented on pull request #368: URL: https://github.com/apache/tomcat/pull/368#issuecomment-700584396 > What is the justification for this change? What problem does it solve? When our application is loaded in another path or attacked in an unknown way, webapp path

[GitHub] [tomcat] markt-asf commented on pull request #368: fix: CachedResource add path length

2020-09-29 Thread GitBox
markt-asf commented on pull request #368: URL: https://github.com/apache/tomcat/pull/368#issuecomment-700577634 What is the justification for this change? What problem does it solve? This is an automated message from the

[GitHub] [tomcat] blueSky1825821 opened a new pull request #368: fix: CachedResource add path length

2020-09-29 Thread GitBox
blueSky1825821 opened a new pull request #368: URL: https://github.com/apache/tomcat/pull/368 cachedResource should add webapp path length This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [tomcat] kdillane commented on pull request #351: Remove White Spaces from the JSP files

2020-09-25 Thread GitBox
kdillane commented on pull request #351: URL: https://github.com/apache/tomcat/pull/351#issuecomment-698458135 > > Since there is no new test for this I am not sure but looking at the code I think "Remove white space" is not quite accurate. > > It is rather "Remove empty lines". Because

[GitHub] [tomcat] kamnani commented on pull request #351: Remove White Spaces from the JSP files

2020-09-25 Thread GitBox
kamnani commented on pull request #351: URL: https://github.com/apache/tomcat/pull/351#issuecomment-698430292 > Since there is no new test for this I am not sure but looking at the code I think "Remove white space" is not quite accurate. > It is rather "Remove empty lines". Because

[GitHub] [tomcat] kamnani edited a comment on pull request #351: Remove White Spaces from the JSP files

2020-09-25 Thread GitBox
kamnani edited a comment on pull request #351: URL: https://github.com/apache/tomcat/pull/351#issuecomment-698430292 > Since there is no new test for this I am not sure but looking at the code I think "Remove white space" is not quite accurate. > It is rather "Remove empty lines".

[GitHub] [tomcat] martin-g commented on pull request #351: Remove White Spaces from the JSP files

2020-09-25 Thread GitBox
martin-g commented on pull request #351: URL: https://github.com/apache/tomcat/pull/351#issuecomment-698157237 Since there is no new test for this I am not sure but looking at the code I think "Remove white space" is not quite accurate. It is rather "Remove empty lines". Because

[GitHub] [tomcat] martin-g commented on a change in pull request #351: Remove White Spaces from the JSP files

2020-09-25 Thread GitBox
martin-g commented on a change in pull request #351: URL: https://github.com/apache/tomcat/pull/351#discussion_r494077383 ## File path: java/org/apache/jasper/compiler/NewlineReductionServletWriter.java ## @@ -0,0 +1,41 @@ +package org.apache.jasper.compiler; + +import

[GitHub] [tomcat] kamnani commented on a change in pull request #351: Remove White Spaces from the JSP files

2020-09-25 Thread GitBox
kamnani commented on a change in pull request #351: URL: https://github.com/apache/tomcat/pull/351#discussion_r494418331 ## File path: java/org/apache/jasper/compiler/Generator.java ## @@ -2095,6 +2101,20 @@ public void visit(Node.JspElement n) throws JasperException {

[GitHub] [tomcat] kdillane commented on pull request #351: Remove White Spaces from the JSP files

2020-09-24 Thread GitBox
kdillane commented on pull request #351: URL: https://github.com/apache/tomcat/pull/351#issuecomment-698458135 > > Since there is no new test for this I am not sure but looking at the code I think "Remove white space" is not quite accurate. > > It is rather "Remove empty lines". Because

[GitHub] [tomcat] kamnani edited a comment on pull request #351: Remove White Spaces from the JSP files

2020-09-24 Thread GitBox
kamnani edited a comment on pull request #351: URL: https://github.com/apache/tomcat/pull/351#issuecomment-698430292 > Since there is no new test for this I am not sure but looking at the code I think "Remove white space" is not quite accurate. > It is rather "Remove empty lines".

[GitHub] [tomcat] kamnani commented on pull request #351: Remove White Spaces from the JSP files

2020-09-24 Thread GitBox
kamnani commented on pull request #351: URL: https://github.com/apache/tomcat/pull/351#issuecomment-698430292 > Since there is no new test for this I am not sure but looking at the code I think "Remove white space" is not quite accurate. > It is rather "Remove empty lines". Because

[GitHub] [tomcat] kamnani commented on a change in pull request #351: Remove White Spaces from the JSP files

2020-09-24 Thread GitBox
kamnani commented on a change in pull request #351: URL: https://github.com/apache/tomcat/pull/351#discussion_r494418331 ## File path: java/org/apache/jasper/compiler/Generator.java ## @@ -2095,6 +2101,20 @@ public void visit(Node.JspElement n) throws JasperException {

[GitHub] [tomcat] martin-g commented on pull request #351: Remove White Spaces from the JSP files

2020-09-24 Thread GitBox
martin-g commented on pull request #351: URL: https://github.com/apache/tomcat/pull/351#issuecomment-698157237 Since there is no new test for this I am not sure but looking at the code I think "Remove white space" is not quite accurate. It is rather "Remove empty lines". Because

[GitHub] [tomcat] martin-g commented on a change in pull request #351: Remove White Spaces from the JSP files

2020-09-24 Thread GitBox
martin-g commented on a change in pull request #351: URL: https://github.com/apache/tomcat/pull/351#discussion_r494079321 ## File path: java/org/apache/jasper/compiler/Generator.java ## @@ -2095,6 +2101,20 @@ public void visit(Node.JspElement n) throws JasperException {

[GitHub] [tomcat] martin-g commented on a change in pull request #351: Remove White Spaces from the JSP files

2020-09-24 Thread GitBox
martin-g commented on a change in pull request #351: URL: https://github.com/apache/tomcat/pull/351#discussion_r494077383 ## File path: java/org/apache/jasper/compiler/NewlineReductionServletWriter.java ## @@ -0,0 +1,41 @@ +package org.apache.jasper.compiler; + +import

[GitHub] [tomcat] kamnani edited a comment on pull request #352: Optimizing Resource Lookup using Bloom Filter

2020-09-23 Thread GitBox
kamnani edited a comment on pull request #352: URL: https://github.com/apache/tomcat/pull/352#issuecomment-697550277 > I tried it, with some changes. Will see the feedback about an actual performance benefit. I measured the cost of building the filter, not too big overall so there's

[GitHub] [tomcat] kamnani commented on pull request #352: Optimizing Resource Lookup using Bloom Filter

2020-09-23 Thread GitBox
kamnani commented on pull request #352: URL: https://github.com/apache/tomcat/pull/352#issuecomment-697550277 > I tried it, with some changes. Will see the feedback about an actual performance benefit. I measured the cost of building the filter, not too big overall so there's likely

[GitHub] [tomcat] ChristopherSchultz commented on pull request #351: Remove White Spaces from the JSP files

2020-09-23 Thread GitBox
ChristopherSchultz commented on pull request #351: URL: https://github.com/apache/tomcat/pull/351#issuecomment-697473351 @rotty3000 This is what I was thinking would be better than post-processing. The JSP->class translation should be a one-time hit rather than a filtering-step that

[GitHub] [tomcat] rotty3000 commented on pull request #351: Remove White Spaces from the JSP files

2020-09-23 Thread GitBox
rotty3000 commented on pull request #351: URL: https://github.com/apache/tomcat/pull/351#issuecomment-697412964 If I may bring one point; I wonder if maybe this optimization is later in the process than would _really_ benefit even more concerns. For instance, if the optimization was

[GitHub] [tomcat] markt-asf commented on pull request #351: Remove White Spaces from the JSP files

2020-09-23 Thread GitBox
markt-asf commented on pull request #351: URL: https://github.com/apache/tomcat/pull/351#issuecomment-697355204 The relevance of gzip depends on what you are trying to optimize. If you are trying to minimise network bytes then gzip is very relevant. For the minimise network bytes use

[GitHub] [tomcat] ChristopherSchultz commented on pull request #351: Remove White Spaces from the JSP files

2020-09-23 Thread GitBox
ChristopherSchultz commented on pull request #351: URL: https://github.com/apache/tomcat/pull/351#issuecomment-697345837 I still think gzip is a red herring, here. If you remove whitespace prior to gzipping, you'll likely see that gzip gives you a lower compression ratio when comparing

[GitHub] [tomcat] markt-asf commented on pull request #351: Remove White Spaces from the JSP files

2020-09-23 Thread GitBox
markt-asf commented on pull request #351: URL: https://github.com/apache/tomcat/pull/351#issuecomment-697269157 I have been doing some simple tests to compare the behaviour of compression with and without this PR. Using the default index page as an example, gzip achieves 80.1%

[GitHub] [tomcat] rmaucher closed pull request #352: Optimizing Resource Lookup using Bloom Filter

2020-09-23 Thread GitBox
rmaucher closed pull request #352: URL: https://github.com/apache/tomcat/pull/352 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [tomcat] rmaucher commented on pull request #352: Optimizing Resource Lookup using Bloom Filter

2020-09-23 Thread GitBox
rmaucher commented on pull request #352: URL: https://github.com/apache/tomcat/pull/352#issuecomment-697260660 I tried it, with some changes. Will see the feedback about an actual performance benefit. I measured the cost of building the filter, not too big overall so there's likely

[GitHub] [tomcat] mcgitty commented on pull request #367: HTML URL must match RemoteAddrValve allow pattern

2020-09-22 Thread GitBox
mcgitty commented on pull request #367: URL: https://github.com/apache/tomcat/pull/367#issuecomment-696835594 Hi Mark, I found the root cause of the issue. It is the confusion created by this paragraph: > A default Tomcat installation includes the Manager. To add an

[GitHub] [tomcat] jbampton commented on pull request #361: Add a GitHub action to lint the Markdown and YAML files.

2020-09-22 Thread GitBox
jbampton commented on pull request #361: URL: https://github.com/apache/tomcat/pull/361#issuecomment-696741586 Hey @markt-asf what do you think about this PR ? This is an automated message from the Apache Git Service. To

[GitHub] [tomcat] markt-asf commented on pull request #367: HTML URL must match RemoteAddrValve allow pattern

2020-09-22 Thread GitBox
markt-asf commented on pull request #367: URL: https://github.com/apache/tomcat/pull/367#issuecomment-696733828 The premise of this PR is incorrect. The allow pattern in the `RemoteAddrValve` has no relationship to the host name used to access the Tomcat instance. The pattern is matched

[GitHub] [tomcat] jbampton commented on pull request #362: Fix spelling

2020-09-22 Thread GitBox
jbampton commented on pull request #362: URL: https://github.com/apache/tomcat/pull/362#issuecomment-696680907 Hey @markt-asf I just rebased and we have 20 files changed only in the `.xsd` files. Seems to be the same twenty that was in your list.

[GitHub] [tomcat] kamnani commented on pull request #351: Remove White Spaces from the JSP files

2020-09-22 Thread GitBox
kamnani commented on pull request #351: URL: https://github.com/apache/tomcat/pull/351#issuecomment-696807874 @markt-asf I am sure you wouldn't be able to test this on proprietary code, because that will generate empty outputs/compile-errors after stripping out the important

[GitHub] [tomcat] markt-asf closed pull request #367: HTML URL must match RemoteAddrValve allow pattern

2020-09-22 Thread GitBox
markt-asf closed pull request #367: URL: https://github.com/apache/tomcat/pull/367 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [tomcat] markt-asf commented on pull request #362: Fix spelling

2020-09-22 Thread GitBox
markt-asf commented on pull request #362: URL: https://github.com/apache/tomcat/pull/362#issuecomment-696726509 Great. Thanks for the confirmation. On that basis, I am going to close the PR. Thanks for all the fixes. This

[GitHub] [tomcat] markt-asf closed pull request #362: Fix spelling

2020-09-22 Thread GitBox
markt-asf closed pull request #362: URL: https://github.com/apache/tomcat/pull/362 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [tomcat] kamnani commented on pull request #352: Optimizing Resource Lookup using Bloom Filter

2020-09-22 Thread GitBox
kamnani commented on pull request #352: URL: https://github.com/apache/tomcat/pull/352#issuecomment-696834567 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [tomcat] rmaucher commented on pull request #352: Optimizing Resource Lookup using Bloom Filter

2020-09-22 Thread GitBox
rmaucher commented on pull request #352: URL: https://github.com/apache/tomcat/pull/352#issuecomment-696769628 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [tomcat] kamnani commented on pull request #352: Optimizing Resource Lookup using Bloom Filter

2020-09-22 Thread GitBox
kamnani commented on pull request #352: URL: https://github.com/apache/tomcat/pull/352#issuecomment-696930075 > There's no cache here: the AbstractArchiveResourceSet already has a "JarFile archive" field, so it adds a new JarContents field with the same data and both get created and

[GitHub] [tomcat] rmaucher commented on pull request #352: Optimizing Resource Lookup using Bloom Filter

2020-09-22 Thread GitBox
rmaucher commented on pull request #352: URL: https://github.com/apache/tomcat/pull/352#issuecomment-696927281 There's no cache here: the AbstractArchiveResourceSet already has a "JarFile archive" field, so it adds a new JarContents field with the same data and both get created and

[GitHub] [tomcat] mcgitty commented on pull request #367: HTML URL must match RemoteAddrValve allow pattern

2020-09-22 Thread GitBox
mcgitty commented on pull request #367: URL: https://github.com/apache/tomcat/pull/367#issuecomment-696835594 Hi Mark, I found the root cause of the issue. It is the confusion created by this paragraph: > A default Tomcat installation includes the Manager. To add an

[GitHub] [tomcat] kamnani commented on pull request #352: Optimizing Resource Lookup using Bloom Filter

2020-09-22 Thread GitBox
kamnani commented on pull request #352: URL: https://github.com/apache/tomcat/pull/352#issuecomment-696834567 > I made the change to use the Context instead of the Host, no issue there. > However, I'm not ok with the proposed changes as is. The problem for me is that I don't understand

[GitHub] [tomcat] kamnani commented on pull request #351: Remove White Spaces from the JSP files

2020-09-22 Thread GitBox
kamnani commented on pull request #351: URL: https://github.com/apache/tomcat/pull/351#issuecomment-696807874 @markt-asf I am sure you wouldn't be able to test this on proprietary code, because that will generate empty outputs/compile-errors after stripping out the important

[GitHub] [tomcat] rmaucher commented on pull request #352: Optimizing Resource Lookup using Bloom Filter

2020-09-22 Thread GitBox
rmaucher commented on pull request #352: URL: https://github.com/apache/tomcat/pull/352#issuecomment-696769628 I made the change to use the Context instead of the Host, no issue there. However, I'm not ok with the proposed changes as is. The problem for me is that I don't understand the

[GitHub] [tomcat] jbampton commented on pull request #361: Add a GitHub action to lint the Markdown and YAML files.

2020-09-22 Thread GitBox
jbampton commented on pull request #361: URL: https://github.com/apache/tomcat/pull/361#issuecomment-696741586 Hey @markt-asf what do you think about this PR ? This is an automated message from the Apache Git Service. To

[GitHub] [tomcat] markt-asf closed pull request #367: HTML URL must match RemoteAddrValve allow pattern

2020-09-22 Thread GitBox
markt-asf closed pull request #367: URL: https://github.com/apache/tomcat/pull/367 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [tomcat] markt-asf commented on pull request #367: HTML URL must match RemoteAddrValve allow pattern

2020-09-22 Thread GitBox
markt-asf commented on pull request #367: URL: https://github.com/apache/tomcat/pull/367#issuecomment-696733828 The premise of this PR is incorrect. The allow pattern in the `RemoteAddrValve` has no relationship to the host name used to access the Tomcat instance. The pattern is matched

[GitHub] [tomcat] markt-asf commented on pull request #362: Fix spelling

2020-09-22 Thread GitBox
markt-asf commented on pull request #362: URL: https://github.com/apache/tomcat/pull/362#issuecomment-696726509 Great. Thanks for the confirmation. On that basis, I am going to close the PR. Thanks for all the fixes. This

[GitHub] [tomcat] markt-asf closed pull request #362: Fix spelling

2020-09-22 Thread GitBox
markt-asf closed pull request #362: URL: https://github.com/apache/tomcat/pull/362 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [tomcat] jbampton commented on pull request #362: Fix spelling

2020-09-22 Thread GitBox
jbampton commented on pull request #362: URL: https://github.com/apache/tomcat/pull/362#issuecomment-696680907 Hey @markt-asf I just rebased and we have 20 files changed only in the `.xsd` files. Seems to be the same twenty that was in your list.

[GitHub] [tomcat] kamnani commented on pull request #351: Remove White Spaces from the JSP files

2020-09-21 Thread GitBox
kamnani commented on pull request #351: URL: https://github.com/apache/tomcat/pull/351#issuecomment-696193669 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [tomcat] kamnani commented on a change in pull request #351: Remove White Spaces from the JSP files

2020-09-21 Thread GitBox
kamnani commented on a change in pull request #351: URL: https://github.com/apache/tomcat/pull/351#discussion_r492175527 ## File path: java/org/apache/jasper/EmbeddedServletOptions.java ## @@ -84,6 +84,11 @@ */ private boolean classDebugInfo = true; +/** +

[GitHub] [tomcat] markt-asf commented on pull request #351: Remove White Spaces from the JSP files

2020-09-21 Thread GitBox
markt-asf commented on pull request #351: URL: https://github.com/apache/tomcat/pull/351#issuecomment-695996844 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [tomcat] mcgitty opened a new pull request #367: HTML URL must match RemoteAddrValve allow pattern

2020-09-21 Thread GitBox
mcgitty opened a new pull request #367: URL: https://github.com/apache/tomcat/pull/367 There seems to be no address resolution such that "http://localhost:8080/manager/html; will not be treated as 127.0.0.1 in the RemoteAddrValve allow= pattern.

[GitHub] [tomcat] markt-asf commented on pull request #351: Remove White Spaces from the JSP files

2020-09-21 Thread GitBox
markt-asf commented on pull request #351: URL: https://github.com/apache/tomcat/pull/351#issuecomment-696218075 Yes, that is the JSP after the modifications. I asked you for a JSP that demonstrated the utility of the feature you propose. The JSP you provided did not compile. I made the

[GitHub] [tomcat] kamnani commented on a change in pull request #351: Remove White Spaces from the JSP files

2020-09-21 Thread GitBox
kamnani commented on a change in pull request #351: URL: https://github.com/apache/tomcat/pull/351#discussion_r492175527 ## File path: java/org/apache/jasper/EmbeddedServletOptions.java ## @@ -84,6 +84,11 @@ */ private boolean classDebugInfo = true; +/** +

[GitHub] [tomcat] kamnani commented on pull request #351: Remove White Spaces from the JSP files

2020-09-21 Thread GitBox
kamnani commented on pull request #351: URL: https://github.com/apache/tomcat/pull/351#issuecomment-696211325 @markt-asf is this the jsp after the modifications? If not, can you attach your modified file ? Also, I know trimSpaces touches the empty output files/blank pages, but had

[GitHub] [tomcat] markt-asf commented on pull request #351: Remove White Spaces from the JSP files

2020-09-21 Thread GitBox
markt-asf commented on pull request #351: URL: https://github.com/apache/tomcat/pull/351#issuecomment-696204359 ``` <%@ taglib uri="http://java.sun.com/jsp/jstl/core; prefix="c"%> <%@ taglib uri="http://java.sun.com/jsp/jstl/functions; prefix="fn" %>

[GitHub] [tomcat] kamnani commented on pull request #351: Remove White Spaces from the JSP files

2020-09-21 Thread GitBox
kamnani commented on pull request #351: URL: https://github.com/apache/tomcat/pull/351#issuecomment-696193669 @markt-asf Can you attach what was your JSP when you tested this feature? This is an automated message from the

  1   2   3   4   5   6   7   8   9   10   >