dependabot[bot] opened a new pull request, #7:
URL: https://github.com/apache/tomcat-taglibs-standard/pull/7
Bumps taglibs-standard-impl from 1.2.3-SNAPSHOT to 1.2.3.
[![Dependabot compatibility
dependabot[bot] opened a new pull request, #6:
URL: https://github.com/apache/tomcat-taglibs-standard/pull/6
Bumps [junit](https://github.com/junit-team/junit4) from 4.8.1 to 4.13.1.
Release notes
Sourced from https://github.com/junit-team/junit4/releases;>junit's
releases.
karacz opened a new pull request, #575:
URL: https://github.com/apache/tomcat/pull/575
Fix for the bug https://bz.apache.org/bugzilla/show_bug.cgi?id=66419
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
markt-asf closed pull request #572: 66370-Fix for Boolean System property
lookup with Security Manager enabled
URL: https://github.com/apache/tomcat/pull/572
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
markt-asf commented on PR #572:
URL: https://github.com/apache/tomcat/pull/572#issuecomment-1371172938
The PR will not be applied.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
markt-asf closed pull request #574: Update web.xml
URL: https://github.com/apache/tomcat/pull/574
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
markt-asf commented on PR #574:
URL: https://github.com/apache/tomcat/pull/574#issuecomment-1366474879
No prior discussion.
No justification for change.
Change removes explanatory comment.
Change uses inconsistent indent.
--
This is an automated message from the Apache Git
dhirajk4 opened a new pull request, #574:
URL: https://github.com/apache/tomcat/pull/574
change file size 50 to 250
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
aooohan closed pull request #573: fix 66382 for build.xml have includ unfound
path
URL: https://github.com/apache/tomcat/pull/573
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
aooohan commented on PR #573:
URL: https://github.com/apache/tomcat/pull/573#issuecomment-1344002368
Merged manually. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
snifferhu opened a new pull request, #573:
URL: https://github.com/apache/tomcat/pull/573
remove include org.apache.jk
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
dependabot[bot] opened a new pull request, #12:
URL: https://github.com/apache/tomcat-training/pull/12
Bumps [express](https://github.com/expressjs/express) from 4.16.3 to 4.17.3.
Release notes
Sourced from https://github.com/expressjs/express/releases;>express's
releases.
ChristopherSchultz commented on PR #572:
URL: https://github.com/apache/tomcat/pull/572#issuecomment-1341716603
You should read both
https://lists.apache.org/thread/66djc4j4ybz45ponly0x5g94oyt844cm and
https://lists.apache.org/thread/7w4x90zwp3qhn9qopbhmg5wponcc468n in their
entirety to
isaacrivriv commented on PR #572:
URL: https://github.com/apache/tomcat/pull/572#issuecomment-1341392982
Yes I saw that, my question was more as to why by default the property was
made to disable the security manager. There are other areas of code where the
security manager is used but
lalo-mx commented on PR #572:
URL: https://github.com/apache/tomcat/pull/572#issuecomment-1341125405
See https://bz.apache.org/bugzilla/show_bug.cgi?id=66294
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
dependabot[bot] opened a new pull request, #11:
URL: https://github.com/apache/tomcat-training/pull/11
Bumps [qs](https://github.com/ljharb/qs) and
[qs](https://github.com/ljharb/qs). These dependencies needed to be updated
together.
Updates `qs` from 6.5.1 to 6.5.3
Changelog
rmaucher closed pull request #41: Avoid bcel thread safety issue
URL: https://github.com/apache/tomcat-jakartaee-migration/pull/41
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
rmaucher commented on PR #41:
URL:
https://github.com/apache/tomcat-jakartaee-migration/pull/41#issuecomment-1334920596
Nice trick. I didn't try to reproduce it, but given the stack trace it seems
useful. Thanks for the PR. This will be in 1.0.6.
--
This is an automated message from the
rmaucher closed pull request #40: Fix issues with annotations packages
URL: https://github.com/apache/tomcat-jakartaee-migration/pull/40
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
rmaucher commented on PR #40:
URL:
https://github.com/apache/tomcat-jakartaee-migration/pull/40#issuecomment-1334909213
Thanks for the PR. Merged manually and this will be in 1.0.6.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
DanielThomas opened a new pull request, #41:
URL: https://github.com/apache/tomcat-jakartaee-migration/pull/41
Allow `ClassConverter` to be used safely in parallel by avoiding
`ConcurrentModificationException` from `SyntheticRepository` for the default
`getInstance`:
```
DanielThomas opened a new pull request, #40:
URL: https://github.com/apache/tomcat-jakartaee-migration/pull/40
With more testing we found a couple of issues with my changes for
https://github.com/apache/tomcat-jakartaee-migration/pull/37. Add more tests
and fix the issues with the patterns
isaacrivriv opened a new pull request, #572:
URL: https://github.com/apache/tomcat/pull/572
https://bz.apache.org/bugzilla/show_bug.cgi?id=66370
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
markt-asf closed pull request #565: updated link to download cvs
URL: https://github.com/apache/tomcat/pull/565
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
markt-asf commented on PR #565:
URL: https://github.com/apache/tomcat/pull/565#issuecomment-1332484054
I've updated the docs to use more generic language.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
markt-asf closed pull request #571: some el implements spi loader not support
comment line
URL: https://github.com/apache/tomcat/pull/571
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
markt-asf commented on PR #571:
URL: https://github.com/apache/tomcat/pull/571#issuecomment-1332407078
This is a WONTFIX.
EL implementations that do not ignore comment lines are broken and should be
fixed. The Tomcat project's default position is that we do not change Tomcat to
laeubi commented on issue #39:
URL:
https://github.com/apache/tomcat-jakartaee-migration/issues/39#issuecomment-1327302693
> Removing or updating the version constraint to include 5 will fix the
problem.
I think the real fix would be that the converter enters the appropriate
ifurnadjiev opened a new issue, #39:
URL: https://github.com/apache/tomcat-jakartaee-migration/issues/39
When "javax.servlet.*" package is specified in the MANIFEST.MF with version
constraints like:
```
Import-Package: javax.servlet;version="[3.1.0,5.0.0)",
markt-asf merged PR #569:
URL: https://github.com/apache/tomcat/pull/569
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
dependabot[bot] closed pull request #7: Bump engine.io from 1.8.5 to 3.6.0
URL: https://github.com/apache/tomcat-training/pull/7
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
dependabot[bot] commented on PR #7:
URL: https://github.com/apache/tomcat-training/pull/7#issuecomment-1323316120
Superseded by #10.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
dependabot[bot] opened a new pull request, #10:
URL: https://github.com/apache/tomcat-training/pull/10
Bumps [engine.io](https://github.com/socketio/engine.io) from 1.8.5 to 3.6.1.
Release notes
Sourced from https://github.com/socketio/engine.io/releases;>engine.io's
releases.
markt-asf merged PR #566:
URL: https://github.com/apache/tomcat/pull/566
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
JLLeitschuh opened a new pull request, #39:
URL: https://github.com/apache/tomcat-maven-plugin/pull/39
# Security Vulnerability Fix
This pull request fixes a Temporary File Information Disclosure
Vulnerability, which existed in this project.
## Preamble
The system
sdeleuze commented on code in PR #569:
URL: https://github.com/apache/tomcat/pull/569#discussion_r1025340076
##
modules/stuffed/tomcat-resource.json:
##
@@ -73,9 +73,13 @@
{"name":"org.apache.tomcat.websocket.server.LocalStrings"}
],
"resources":[
-
sdeleuze commented on code in PR #569:
URL: https://github.com/apache/tomcat/pull/569#discussion_r1025160017
##
modules/stuffed/tomcat-resource.json:
##
@@ -73,9 +73,13 @@
{"name":"org.apache.tomcat.websocket.server.LocalStrings"}
],
"resources":[
-
aooohan merged PR #567:
URL: https://github.com/apache/tomcat/pull/567
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
sdeleuze commented on code in PR #569:
URL: https://github.com/apache/tomcat/pull/569#discussion_r1024921333
##
modules/stuffed/tomcat-resource.json:
##
@@ -73,9 +73,13 @@
{"name":"org.apache.tomcat.websocket.server.LocalStrings"}
],
"resources":[
-
mhalbritter commented on code in PR #569:
URL: https://github.com/apache/tomcat/pull/569#discussion_r1024913815
##
modules/stuffed/tomcat-resource.json:
##
@@ -73,9 +73,13 @@
{"name":"org.apache.tomcat.websocket.server.LocalStrings"}
],
"resources":[
-
glendagonzales closed pull request #38: PDS-3713 bump tomcat to 9.0.69
URL: https://github.com/apache/tomcat-maven-plugin/pull/38
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
glendagonzales opened a new pull request, #38:
URL: https://github.com/apache/tomcat-maven-plugin/pull/38
[PDS-3713](https://keap.atlassian.net/browse/PDS-3713)
Upgrade to tomcat 9.0.69 for security reasons.
--
This is an automated message from the Apache Git Service.
To respond to
aooohan merged PR #570:
URL: https://github.com/apache/tomcat/pull/570
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
guillaumecle opened a new pull request, #570:
URL: https://github.com/apache/tomcat/pull/570
https://bz.apache.org/bugzilla/show_bug.cgi?id=66029 poi 5.0 generated xlsx
file RUN TO EMAIL APPENDS .TXT TO OUTPUT
https://bz.apache.org/bugzilla/show_bug.cgi?id=66209 CPU regression when
sdeleuze commented on code in PR #569:
URL: https://github.com/apache/tomcat/pull/569#discussion_r1024337553
##
modules/stuffed/tomcat-resource.json:
##
@@ -73,9 +73,13 @@
{"name":"org.apache.tomcat.websocket.server.LocalStrings"}
],
"resources":[
-
ChristopherSchultz commented on code in PR #569:
URL: https://github.com/apache/tomcat/pull/569#discussion_r1024327589
##
modules/stuffed/tomcat-resource.json:
##
@@ -73,9 +73,13 @@
{"name":"org.apache.tomcat.websocket.server.LocalStrings"}
],
"resources":[
-
sdeleuze opened a new pull request, #569:
URL: https://github.com/apache/tomcat/pull/569
This commit updates the native resources hints in order to avoid classpath
wide inclusion of resources.
@markt-asf @mhalbritter Please check I did not make any mistake.
--
This is an automated
jgneff commented on PR #566:
URL: https://github.com/apache/tomcat/pull/566#issuecomment-1314042008
After this fix, the only remaining difference that I have found between any
two builds of Tomcat using the default Ant target is the build path that gets
included in two XML files:
aooohan closed pull request #568: 10.1.x
URL: https://github.com/apache/tomcat/pull/568
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
suamly2021 opened a new pull request, #568:
URL: https://github.com/apache/tomcat/pull/568
Just for test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
vassilismourikis opened a new pull request, #567:
URL: https://github.com/apache/tomcat/pull/567
In order to overcome the server.xml permission denial problem.
Signed-off: [vassilismouri...@gmail.com](mailto:vmour...@redhat.com)
--
This is an automated message from the Apache Git
jgneff commented on PR #566:
URL: https://github.com/apache/tomcat/pull/566#issuecomment-1312794140
I found how to test the [Tomcat JDBC Connection
Pool](https://tomcat.apache.org/tomcat-10.0-doc/jdbc-pool.html) test JAR files
(`tomcat-jdbc-test.jar` and `tomcat-jdbc-test-src.jar`). I
jgneff opened a new pull request, #566:
URL: https://github.com/apache/tomcat/pull/566
Fixes [Bug 66346](https://bz.apache.org/bugzilla/show_bug.cgi?id=66346).
Only the first change is required to fix the timestamps in
`tomcat-jdbc-src.jar`, but this seemed a good time to fix the
dependabot[bot] closed pull request #8: Bump socket.io-parser from 2.3.1 to
3.3.2
URL: https://github.com/apache/tomcat-training/pull/8
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
dependabot[bot] commented on PR #8:
URL: https://github.com/apache/tomcat-training/pull/8#issuecomment-1309683026
Superseded by #9.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
dependabot[bot] opened a new pull request, #9:
URL: https://github.com/apache/tomcat-training/pull/9
Bumps [socket.io-parser](https://github.com/socketio/socket.io-parser) from
2.3.1 to 3.3.3.
Release notes
Sourced from
aooohan commented on PR #565:
URL: https://github.com/apache/tomcat/pull/565#issuecomment-1309666942
Thanks for bringing it to my attention. But CSV is too old and outdated and
I think it's time to use Git instead. So I will try to change some docs related
to this.
--
This is an
Naturbelassen opened a new pull request, #565:
URL: https://github.com/apache/tomcat/pull/565
The documentation suggest to get cvs by following this link:
http://www.cvshome.org/
However the linked page has nothing to do with csv.
--
This is an automated message from the Apache
markt-asf merged PR #564:
URL: https://github.com/apache/tomcat/pull/564
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
sdeleuze opened a new pull request, #564:
URL: https://github.com/apache/tomcat/pull/564
This pull request fixes regressions in the Tomcat 10.1 native support
compared to Tomcat 10.0.
It brings back required reflection metadata on `AbstractProtocol` and
`AbstractHttp11Protocol` lost
markt-asf commented on PR #562:
URL: https://github.com/apache/tomcat/pull/562#issuecomment-1305623555
Thanks for the PR. I applied to it manually so I could use a slightly
different fix and add a change log entry.
--
This is an automated message from the Apache Git Service.
To respond
markt-asf closed pull request #562: Remove unnecessary -1 predicate because
write will not return -1 unless NioChannel is CLOSED_NIO_CHANNEL
URL: https://github.com/apache/tomcat/pull/562
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
aooohan commented on PR #563:
URL: https://github.com/apache/tomcat/pull/563#issuecomment-1304982523
Thanks for the PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
aooohan merged PR #563:
URL: https://github.com/apache/tomcat/pull/563
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
zsrv opened a new pull request, #563:
URL: https://github.com/apache/tomcat/pull/563
The default formatter was changed
[here](https://github.com/apache/tomcat/commit/7d0408eb47c52376cf210cc4b8d897d1bffac947#diff-e0d7b86da38bd411282a14bd82e8cc517ff64f68fc3c882647e5a3e0ed736840R335).
--
markt-asf closed issue #35: Does this project work in a spring 5 project?
URL: https://github.com/apache/tomcat-jakartaee-migration/issues/35
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
markt-asf commented on issue #35:
URL:
https://github.com/apache/tomcat-jakartaee-migration/issues/35#issuecomment-1299935540
No. Those JARs are excluded because they are known not to contain any
classes that require conversion. The exclusion is a performance optimisation.
--
This is an
markt-asf merged PR #14:
URL: https://github.com/apache/tomcat-native/pull/14
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
markt-asf commented on code in PR #13:
URL: https://github.com/apache/tomcat-native/pull/13#discussion_r1009712365
##
native/build/tcnative.m4:
##
@@ -233,7 +233,7 @@ AC_DEFUN([TCN_FIND_SSL_TOOLKIT],[
#include
#include
int main() {
-if (OPENSSL_VERSION_NUMBER >=
markt-asf merged PR #13:
URL: https://github.com/apache/tomcat-native/pull/13
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
dependabot[bot] opened a new pull request, #8:
URL: https://github.com/apache/tomcat-training/pull/8
Bumps [socket.io-parser](https://github.com/socketio/socket.io-parser) from
2.3.1 to 3.3.2.
Release notes
Sourced from
rmaucher closed pull request #37: Exclude Findbugs JSR-305 annotation packages
and classes
URL: https://github.com/apache/tomcat-jakartaee-migration/pull/37
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
rmaucher commented on PR #37:
URL:
https://github.com/apache/tomcat-jakartaee-migration/pull/37#issuecomment-1294954276
This will be in 1.0.5.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
rmaucher commented on PR #37:
URL:
https://github.com/apache/tomcat-jakartaee-migration/pull/37#issuecomment-1294704497
Ok !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
DanielThomas commented on PR #37:
URL:
https://github.com/apache/tomcat-jakartaee-migration/pull/37#issuecomment-1294527488
I omitted those so:
- A move from `jakarta` -> `javax` would only relocate the classes provided
by 1.3, leaving the later ones alone
- Especially avoids
rmaucher commented on PR #37:
URL:
https://github.com/apache/tomcat-jakartaee-migration/pull/37#issuecomment-1294510686
I would also think the difference is functionally "ok", before these
intermediate paths were matched since not excluded I suppose. So this can be
committed, but I'll
DanielThomas commented on PR #37:
URL:
https://github.com/apache/tomcat-jakartaee-migration/pull/37#issuecomment-1294468210
Definitely better - moving only `tomcat-annotations-api` avoids touching a
bunch of files that don't actually need a migration. Guava is completely
untouched by
DanielThomas commented on PR #37:
URL:
https://github.com/apache/tomcat-jakartaee-migration/pull/37#issuecomment-1293277673
That had occured to me too, let me do that!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
rmaucher commented on PR #37:
URL:
https://github.com/apache/tomcat-jakartaee-migration/pull/37#issuecomment-1293108227
Ok, so there's even more in javax.annotation (I didn't know). It would
likely be better and less hacky to switch to an include list rather than an
exclude one.
--
DanielThomas commented on PR #37:
URL:
https://github.com/apache/tomcat-jakartaee-migration/pull/37#issuecomment-1293003077
Ah, I missed this because the manifest wasn't logged. I might need to do
something to avoid this too:
```
Manifest-Version: 1.0
Bundle-Description: Guava is
codecov-commenter commented on PR #37:
URL:
https://github.com/apache/tomcat-jakartaee-migration/pull/37#issuecomment-1292915384
#
DanielThomas opened a new pull request, #37:
URL: https://github.com/apache/tomcat-jakartaee-migration/pull/37
On deeper investigation, it turns out the problems I had with
`javax.annotation` when testing
https://github.com/apache/tomcat-jakartaee-migration/pull/36 were all Findbugs
tianshuang opened a new pull request, #562:
URL: https://github.com/apache/tomcat/pull/562
The following are the low-level implementations of the Solaris platform,
other platforms are similar:
rmaucher commented on PR #36:
URL:
https://github.com/apache/tomcat-jakartaee-migration/pull/36#issuecomment-1291700768
Tested with the examples webapp from Tomcat 9 and verified that it is a bit
faster (about 20% for this one).
--
This is an automated message from the Apache Git
aooohan closed pull request #36: Improve composability when using from other
tools
URL: https://github.com/apache/tomcat-jakartaee-migration/pull/36
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
aooohan commented on PR #36:
URL:
https://github.com/apache/tomcat-jakartaee-migration/pull/36#issuecomment-1291681450
Merge manually, thanks for the PR. ;)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
DanielThomas commented on PR #36:
URL:
https://github.com/apache/tomcat-jakartaee-migration/pull/36#issuecomment-1291438441
Awesome, thanks much for the feedback! It's a much better PR for it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please
DanielThomas commented on code in PR #36:
URL:
https://github.com/apache/tomcat-jakartaee-migration/pull/36#discussion_r1005164436
##
src/main/java/org/apache/tomcat/jakartaee/ManifestConverter.java:
##
@@ -48,20 +48,16 @@ public boolean accepts(String filename) {
}
DanielThomas commented on code in PR #36:
URL:
https://github.com/apache/tomcat-jakartaee-migration/pull/36#discussion_r1005164436
##
src/main/java/org/apache/tomcat/jakartaee/ManifestConverter.java:
##
@@ -48,20 +48,16 @@ public boolean accepts(String filename) {
}
DanielThomas commented on code in PR #36:
URL:
https://github.com/apache/tomcat-jakartaee-migration/pull/36#discussion_r1005164436
##
src/main/java/org/apache/tomcat/jakartaee/ManifestConverter.java:
##
@@ -48,20 +48,16 @@ public boolean accepts(String filename) {
}
DanielThomas commented on code in PR #36:
URL:
https://github.com/apache/tomcat-jakartaee-migration/pull/36#discussion_r1005164436
##
src/main/java/org/apache/tomcat/jakartaee/ManifestConverter.java:
##
@@ -48,20 +48,16 @@ public boolean accepts(String filename) {
}
DanielThomas commented on code in PR #36:
URL:
https://github.com/apache/tomcat-jakartaee-migration/pull/36#discussion_r1005151612
##
src/main/java/org/apache/tomcat/jakartaee/ManifestConverter.java:
##
@@ -48,20 +48,16 @@ public boolean accepts(String filename) {
}
DanielThomas commented on code in PR #36:
URL:
https://github.com/apache/tomcat-jakartaee-migration/pull/36#discussion_r1005151612
##
src/main/java/org/apache/tomcat/jakartaee/ManifestConverter.java:
##
@@ -48,20 +48,16 @@ public boolean accepts(String filename) {
}
DanielThomas commented on code in PR #36:
URL:
https://github.com/apache/tomcat-jakartaee-migration/pull/36#discussion_r1005151612
##
src/main/java/org/apache/tomcat/jakartaee/ManifestConverter.java:
##
@@ -48,20 +48,16 @@ public boolean accepts(String filename) {
}
DanielThomas commented on code in PR #36:
URL:
https://github.com/apache/tomcat-jakartaee-migration/pull/36#discussion_r1005151612
##
src/main/java/org/apache/tomcat/jakartaee/ManifestConverter.java:
##
@@ -48,20 +48,16 @@ public boolean accepts(String filename) {
}
aooohan commented on code in PR #36:
URL:
https://github.com/apache/tomcat-jakartaee-migration/pull/36#discussion_r1005142148
##
src/main/java/org/apache/tomcat/jakartaee/ManifestConverter.java:
##
@@ -48,20 +48,16 @@ public boolean accepts(String filename) {
}
DanielThomas commented on code in PR #36:
URL:
https://github.com/apache/tomcat-jakartaee-migration/pull/36#discussion_r1005100601
##
src/main/java/org/apache/tomcat/jakartaee/ManifestConverter.java:
##
@@ -112,7 +107,7 @@ private boolean updateValues(Attributes attributes,
DanielThomas commented on code in PR #36:
URL:
https://github.com/apache/tomcat-jakartaee-migration/pull/36#discussion_r1005100601
##
src/main/java/org/apache/tomcat/jakartaee/ManifestConverter.java:
##
@@ -112,7 +107,7 @@ private boolean updateValues(Attributes attributes,
DanielThomas commented on code in PR #36:
URL:
https://github.com/apache/tomcat-jakartaee-migration/pull/36#discussion_r1005100601
##
src/main/java/org/apache/tomcat/jakartaee/ManifestConverter.java:
##
@@ -112,7 +107,7 @@ private boolean updateValues(Attributes attributes,
rmaucher commented on PR #36:
URL:
https://github.com/apache/tomcat-jakartaee-migration/pull/36#issuecomment-1290577491
This looks like a very good improvement overall.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
1 - 100 of 3206 matches
Mail list logo
