[GitHub] [tomcat] mulkgun opened a new pull request, #553: Undocumented nonce parameter name

2022-09-30 Thread GitBox
mulkgun opened a new pull request, #553: URL: https://github.com/apache/tomcat/pull/553 The "nonce parameter name" initialisation parameter is undocumented. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [tomcat-jakartaee-migration] markt-asf merged pull request #28: Additional Profile to Migrate Back to JEE8 from Jakarta EE

2022-09-15 Thread GitBox
markt-asf merged PR #28: URL: https://github.com/apache/tomcat-jakartaee-migration/pull/28 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [tomcat-jakartaee-migration] markt-asf commented on pull request #28: Additional Profile to Migrate Back to JEE8 from Jakarta EE

2022-09-15 Thread GitBox
markt-asf commented on PR #28: URL: https://github.com/apache/tomcat-jakartaee-migration/pull/28#issuecomment-1247723803 Risky, but with a suitable warning in the docs I think it will be OK. -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [tomcat-jakartaee-migration] gregorkistler commented on issue #34: v1.0.3 causes java.lang.IllegalArgumentException: java.io.EOFException on certain Tomcat War deployments

2022-09-14 Thread GitBox
gregorkistler commented on issue #34: URL: https://github.com/apache/tomcat-jakartaee-migration/issues/34#issuecomment-1247614172 Sweet! Thank you. I can confirm that commit adc4ec5b8f3375bfc98d35f694fd6a0cc75f29f1 fixes the issue 拾 -- This is an automated message from the Apache Git

[GitHub] [tomcat-jakartaee-migration] aooohan closed issue #34: v1.0.3 causes java.lang.IllegalArgumentException: java.io.EOFException on certain Tomcat War deployments

2022-09-14 Thread GitBox
aooohan closed issue #34: v1.0.3 causes java.lang.IllegalArgumentException: java.io.EOFException on certain Tomcat War deployments URL: https://github.com/apache/tomcat-jakartaee-migration/issues/34 -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [tomcat-jakartaee-migration] aooohan commented on issue #34: v1.0.3 causes java.lang.IllegalArgumentException: java.io.EOFException on certain Tomcat War deployments

2022-09-14 Thread GitBox
aooohan commented on issue #34: URL: https://github.com/apache/tomcat-jakartaee-migration/issues/34#issuecomment-1247598549 > After having a look at the jars and the file size differences between migrated ones with 1.0.0 and 1.0.3 I could figure out four jars where I can reproduce the

[GitHub] [tomcat-jakartaee-migration] gregorkistler commented on issue #34: v1.0.3 causes java.lang.IllegalArgumentException: java.io.EOFException on certain Tomcat War deployments

2022-09-14 Thread GitBox
gregorkistler commented on issue #34: URL: https://github.com/apache/tomcat-jakartaee-migration/issues/34#issuecomment-1247052094 No worries and thanks for the quick response :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [tomcat-jakartaee-migration] aooohan commented on issue #34: v1.0.3 causes java.lang.IllegalArgumentException: java.io.EOFException on certain Tomcat War deployments

2022-09-14 Thread GitBox
aooohan commented on issue #34: URL: https://github.com/apache/tomcat-jakartaee-migration/issues/34#issuecomment-1246998359 Oh my goodness! It's my fault. I have fixed this bug in my local branch and passed the test you provided, and I have found out what is going wrong. But It is now

[GitHub] [tomcat] aooohan closed pull request #552: UTF-8 makes Non-English Windows Console garbled

2022-09-13 Thread GitBox
aooohan closed pull request #552: UTF-8 makes Non-English Windows Console garbled URL: https://github.com/apache/tomcat/pull/552 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [tomcat-native] markt-asf commented on pull request #15: Update README.txt

2022-09-13 Thread GitBox
markt-asf commented on PR #15: URL: https://github.com/apache/tomcat-native/pull/15#issuecomment-1245242996 The current grammar is correct. And grammatical is spelt with threes 'a's, not two 'a's and an 'e'. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [tomcat-native] markt-asf closed pull request #15: Update README.txt

2022-09-13 Thread GitBox
markt-asf closed pull request #15: Update README.txt URL: https://github.com/apache/tomcat-native/pull/15 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[GitHub] [tomcat-native] IAMBANN opened a new pull request, #15: Update README.txt

2022-09-13 Thread GitBox
IAMBANN opened a new pull request, #15: URL: https://github.com/apache/tomcat-native/pull/15 grammetical correction -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [tomcat] aooohan commented on pull request #552: UTF-8 makes Non-English Windows Console garbled

2022-09-13 Thread GitBox
aooohan commented on PR #552: URL: https://github.com/apache/tomcat/pull/552#issuecomment-1244966144 > -1 In the majority of use cases the console output (the stdout & stderr streams) are redirected, to a file or to a process (such as being displayed in an IDE). This includes the case when

[GitHub] [tomcat] malaysf commented on pull request #550: Http11Processor's keep alive state and input buffer's swallow state must be synchronized

2022-09-12 Thread GitBox
malaysf commented on PR #550: URL: https://github.com/apache/tomcat/pull/550#issuecomment-1244022378 @markt-asf Thanks for reviewing and merging. Could this please also be included in 9.0.x? -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [tomcat] markt-asf merged pull request #550: Http11Processor's keep alive state and input buffer's swallow state must be synchronized

2022-09-12 Thread GitBox
markt-asf merged PR #550: URL: https://github.com/apache/tomcat/pull/550 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [tomcat] kkolinko commented on pull request #552: UTF-8 makes Non-English Windows Console garbled

2022-09-12 Thread GitBox
kkolinko commented on PR #552: URL: https://github.com/apache/tomcat/pull/552#issuecomment-1243385264 -1 In the majority of use cases the console output (the stdout & stderr streams) are redirected, to a file or to a process (such as being displayed in an IDE). This includes the case

[GitHub] [tomcat] aooohan commented on pull request #552: UTF-8 makes Non-English Windows Console garbled

2022-09-11 Thread GitBox
aooohan commented on PR #552: URL: https://github.com/apache/tomcat/pull/552#issuecomment-1243148093 I have no objection as the ConsoleHandler shouldn't be used on production system, so this change will allow for better monitoring at development time. -- This is an automated message from

[GitHub] [tomcat] xth opened a new pull request, #552: UTF-8 makes Non-English Windows Console garbled

2022-09-11 Thread GitBox
xth opened a new pull request, #552: URL: https://github.com/apache/tomcat/pull/552 Windows console dose not use UTF-8 by default. Unset the ConsoleHandler.encoding ,the JVM would choose the platform default. -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [tomcat] malaysf commented on pull request #550: Http11Processor's keep alive state and input buffer's swallow state must be synchronized

2022-09-08 Thread GitBox
malaysf commented on PR #550: URL: https://github.com/apache/tomcat/pull/550#issuecomment-1241479251 I've included that change too. Please let me know if there's anything else that should be done. Thanks! -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [tomcat] markt-asf commented on pull request #550: Http11Processor's keep alive state and input buffer's swallow state must be synchronized

2022-09-08 Thread GitBox
markt-asf commented on PR #550: URL: https://github.com/apache/tomcat/pull/550#issuecomment-1240278052 > Are you referring to the call to `inputBuffer.setSwallowInput(true);` in `Http11Processor.ack`? That does appear to be unnecessary now. Yes. That was the one. -- This is an

[GitHub] [tomcat] malaysf commented on pull request #550: Http11Processor's keep alive state and input buffer's swallow state must be synchronized

2022-09-07 Thread GitBox
malaysf commented on PR #550: URL: https://github.com/apache/tomcat/pull/550#issuecomment-1239848521 Are you referring to the call to `inputBuffer.setSwallowInput(true);` in `Http11Processor.ack`? That does appear to be unnecessary now. -- This is an automated message from the Apache Git

[GitHub] [tomcat] markt-asf commented on pull request #550: Http11Processor's keep alive state and input buffer's swallow state must be synchronized

2022-09-07 Thread GitBox
markt-asf commented on PR #550: URL: https://github.com/apache/tomcat/pull/550#issuecomment-1239284952 I suspect the call in `Http11Processor.ack()` can also be removed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [tomcat] aooohan closed pull request #551: Update Http11InputBuffer.java

2022-09-07 Thread GitBox
aooohan closed pull request #551: Update Http11InputBuffer.java URL: https://github.com/apache/tomcat/pull/551 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[GitHub] [tomcat] aooohan commented on pull request #551: Update Http11InputBuffer.java

2022-09-07 Thread GitBox
aooohan commented on PR #551: URL: https://github.com/apache/tomcat/pull/551#issuecomment-1239031095 Merge manually. Thanks for the PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [tomcat] dllfun opened a new pull request, #551: Update Http11InputBuffer.java

2022-09-06 Thread GitBox
dllfun opened a new pull request, #551: URL: https://github.com/apache/tomcat/pull/551 fix the potential java.lang.IndexOutOfBoundsException ,if a client send content like PRI * HTTP/2.0\r\n\r\nSM\r\n\r (lose one byte at last) exception will occure when dealing zhe preface。 -- This is

[GitHub] [tomcat] malaysf commented on pull request #550: Http11Processor's keep alive state and input buffer's swallow state must be synchronized

2022-09-06 Thread GitBox
malaysf commented on PR #550: URL: https://github.com/apache/tomcat/pull/550#issuecomment-1238525462 @markt-asf That does work and is a much simpler solution! It also doesn't break TestSwallowAbortedUploads (which I now understand why). I will update my PR with that change. What is

[GitHub] [tomcat] markt-asf commented on pull request #550: Http11Processor's keep alive state and input buffer's swallow state must be synchronized

2022-09-06 Thread GitBox
markt-asf commented on PR #550: URL: https://github.com/apache/tomcat/pull/550#issuecomment-1238513982 I think you can just remove the `inputBuffer.setSwallowInput(false)` in `Http11Processor.prepareExpectation()`. If that is correct, I think there is at least one other call that can also

[GitHub] [tomcat] malaysf commented on pull request #550: Http11Processor's keep alive state and input buffer's swallow state must be synchronized

2022-09-06 Thread GitBox
malaysf commented on PR #550: URL: https://github.com/apache/tomcat/pull/550#issuecomment-1238435761 The TestSwallowAbortedUploads test fails so I need to look into that. We ran into this issue in production and were able to reproduce with curl or postman requests to an API that

[GitHub] [tomcat-jakartaee-migration] markt-asf closed issue #32: Manifest in exploded osgi bundle is not migrated

2022-09-06 Thread GitBox
markt-asf closed issue #32: Manifest in exploded osgi bundle is not migrated URL: https://github.com/apache/tomcat-jakartaee-migration/issues/32 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [tomcat-jakartaee-migration] markt-asf merged pull request #33: fixes #32 check if file name ends with manifest name

2022-09-06 Thread GitBox
markt-asf merged PR #33: URL: https://github.com/apache/tomcat-jakartaee-migration/pull/33 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [tomcat] rmaucher commented on pull request #550: Http11Processor's keep alive state and input buffer's swallow state must be synchronized

2022-09-05 Thread GitBox
rmaucher commented on PR #550: URL: https://github.com/apache/tomcat/pull/550#issuecomment-1237008899 A request with an expectation is not supposed to be performed the same way as an identical request without it. So you have to be careful and I don't think your patch is correct. Looking

[GitHub] [tomcat] malaysf opened a new pull request, #550: Http11Processor's keep alive state and input buffer's swallow state must be synchronized

2022-09-02 Thread GitBox
malaysf opened a new pull request, #550: URL: https://github.com/apache/tomcat/pull/550 Fixing a bug where a connection would be kept alive without swallowing the input from the request stream. When a request comes in with a 100 Continue expectation, and the server immediately

[GitHub] [tomcat-jakartaee-migration] aooohan closed issue #25: java.lang.IllegalArgumentException: Unknown Entity bean class with eclipselink in tomcat 10

2022-08-31 Thread GitBox
aooohan closed issue #25: java.lang.IllegalArgumentException: Unknown Entity bean class with eclipselink in tomcat 10 URL: https://github.com/apache/tomcat-jakartaee-migration/issues/25 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [tomcat-jakartaee-migration] aooohan commented on issue #25: java.lang.IllegalArgumentException: Unknown Entity bean class with eclipselink in tomcat 10

2022-08-31 Thread GitBox
aooohan commented on issue #25: URL: https://github.com/apache/tomcat-jakartaee-migration/issues/25#issuecomment-1232735173 Close this issue first, then reopen it when you have provided a test case. -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [tomcat] michael-o commented on pull request #506: Adding Redirect and Proxy Error Reporting Valves

2022-08-30 Thread GitBox
michael-o commented on PR #506: URL: https://github.com/apache/tomcat/pull/506#issuecomment-1231777237 I would recommend to make this TWO PRs because both new valves serve different purposes... -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [tomcat] aooohan closed pull request #548: Avoid int overflow when parsing octet

2022-08-29 Thread GitBox
aooohan closed pull request #548: Avoid int overflow when parsing octet URL: https://github.com/apache/tomcat/pull/548 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [tomcat] aooohan commented on pull request #548: Avoid int overflow when parsing octet

2022-08-29 Thread GitBox
aooohan commented on PR #548: URL: https://github.com/apache/tomcat/pull/548#issuecomment-1230336825 Thanks for the PR. I applied this manually so I could: - add some test cases - add changelog entry -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [tomcat] sashashura commented on pull request #549: GitHub Workflows security hardening

2022-08-29 Thread GitBox
sashashura commented on PR #549: URL: https://github.com/apache/tomcat/pull/549#issuecomment-1230174757 Great. There is no way for me to see if this is set in the org settings. In this case I still think it still adds a little value of portability if transferred to other repository and

[GitHub] [tomcat] markt-asf closed pull request #549: GitHub Workflows security hardening

2022-08-29 Thread GitBox
markt-asf closed pull request #549: GitHub Workflows security hardening URL: https://github.com/apache/tomcat/pull/549 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [tomcat] markt-asf commented on pull request #549: GitHub Workflows security hardening

2022-08-29 Thread GitBox
markt-asf commented on PR #549: URL: https://github.com/apache/tomcat/pull/549#issuecomment-1230114372 Unnecessary. Handled by org level permissions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [tomcat] sashashura opened a new pull request, #549: GitHub Workflows security hardening

2022-08-29 Thread GitBox
sashashura opened a new pull request, #549: URL: https://github.com/apache/tomcat/pull/549 This PR adds explicit [permissions section](https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#permissions) to workflows. This is a security best practice because

[GitHub] [tomcat] mayrstefan opened a new pull request, #548: Avoid int overflow when parsing octet

2022-08-26 Thread GitBox
mayrstefan opened a new pull request, #548: URL: https://github.com/apache/tomcat/pull/548 When parsing an octet stop when value exceeds 255. Should fix [bug 66240](https://bz.apache.org/bugzilla/show_bug.cgi?id=66240) -- This is an automated message from the Apache Git Service. To

[GitHub] [tomcat-jakartaee-migration] aooohan closed issue #29: Exception in thread "main" java.util.zip.ZipException: Bad CRC checksum for entry META-INF/MANIFEST.MF

2022-08-26 Thread GitBox
aooohan closed issue #29: Exception in thread "main" java.util.zip.ZipException: Bad CRC checksum for entry META-INF/MANIFEST.MF URL: https://github.com/apache/tomcat-jakartaee-migration/issues/29 -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [tomcat-jakartaee-migration] aooohan closed pull request #30: Exception in thread "main" java.util.zip.ZipException: Bad CRC checksum for entry

2022-08-26 Thread GitBox
aooohan closed pull request #30: Exception in thread "main" java.util.zip.ZipException: Bad CRC checksum for entry URL: https://github.com/apache/tomcat-jakartaee-migration/pull/30 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [tomcat-jakartaee-migration] aooohan commented on pull request #30: Exception in thread "main" java.util.zip.ZipException: Bad CRC checksum for entry

2022-08-26 Thread GitBox
aooohan commented on PR #30: URL: https://github.com/apache/tomcat-jakartaee-migration/pull/30#issuecomment-1228271046 Merge manually -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [tomcat-jakartaee-migration] aooohan commented on pull request #30: Exception in thread "main" java.util.zip.ZipException: Bad CRC checksum for entry

2022-08-25 Thread GitBox
aooohan commented on PR #30: URL: https://github.com/apache/tomcat-jakartaee-migration/pull/30#issuecomment-1227979940 If there are no objections to this sloution, I will merge it today. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [tomcat-jakartaee-migration] aooohan closed pull request #27: Clean up duplicate property key and the use of deprecated api.

2022-08-25 Thread GitBox
aooohan closed pull request #27: Clean up duplicate property key and the use of deprecated api. URL: https://github.com/apache/tomcat-jakartaee-migration/pull/27 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [tomcat-jakartaee-migration] wmccusker commented on pull request #33: fixes #32 check if file name ends with manifest name

2022-08-25 Thread GitBox
wmccusker commented on PR #33: URL: https://github.com/apache/tomcat-jakartaee-migration/pull/33#issuecomment-1227772671 Thanks for the context Mark! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [tomcat] ppkarwasz commented on pull request #545: Replace `LoggerThread` with single-threaded executor

2022-08-25 Thread GitBox
ppkarwasz commented on PR #545: URL: https://github.com/apache/tomcat/pull/545#issuecomment-1227607499 @markt-asf, thanks for taking care of this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [tomcat-jakartaee-migration] markt-asf commented on pull request #33: fixes #32 check if file name ends with manifest name

2022-08-25 Thread GitBox
markt-asf commented on PR #33: URL: https://github.com/apache/tomcat-jakartaee-migration/pull/33#issuecomment-1227529439 Some background might help here. The main Tomcat code base doesn't use static imports at all. That is mostly my fault. For the migration tool for Jakarta

[GitHub] [tomcat-jakartaee-migration] wmccusker commented on a diff in pull request #33: fixes #32 check if file name ends with manifest name

2022-08-25 Thread GitBox
wmccusker commented on code in PR #33: URL: https://github.com/apache/tomcat-jakartaee-migration/pull/33#discussion_r955189029 ## src/test/java/org/apache/tomcat/jakartaee/ManifestConverterTest.java: ## @@ -0,0 +1,16 @@ +package org.apache.tomcat.jakartaee; + +import static

[GitHub] [tomcat] markt-asf merged pull request #547: Simplifying ImportHandler to not test class presence with getResource

2022-08-25 Thread GitBox
markt-asf merged PR #547: URL: https://github.com/apache/tomcat/pull/547 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [tomcat] markt-asf commented on pull request #545: Replace `LoggerThread` with single-threaded executor

2022-08-25 Thread GitBox
markt-asf commented on PR #545: URL: https://github.com/apache/tomcat/pull/545#issuecomment-1227323763 Applied manually so I could address the lost messages on shutdown issue. Thanks for the PR. -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [tomcat] markt-asf closed pull request #545: Replace `LoggerThread` with single-threaded executor

2022-08-25 Thread GitBox
markt-asf closed pull request #545: Replace `LoggerThread` with single-threaded executor URL: https://github.com/apache/tomcat/pull/545 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [tomcat] markt-asf closed pull request #544: Avoid errors from shutting down `LoggerThread`

2022-08-25 Thread GitBox
markt-asf closed pull request #544: Avoid errors from shutting down `LoggerThread` URL: https://github.com/apache/tomcat/pull/544 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [tomcat] markt-asf commented on pull request #544: Avoid errors from shutting down `LoggerThread`

2022-08-25 Thread GitBox
markt-asf commented on PR #544: URL: https://github.com/apache/tomcat/pull/544#issuecomment-1227322736 Fixed via #545 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [tomcat] aooohan closed pull request #542: Bugfix for 66210 - Some unit tests are failing on a non-English PC

2022-08-25 Thread GitBox
aooohan closed pull request #542: Bugfix for 66210 - Some unit tests are failing on a non-English PC URL: https://github.com/apache/tomcat/pull/542 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [tomcat] aooohan commented on pull request #542: Bugfix for 66210 - Some unit tests are failing on a non-English PC

2022-08-25 Thread GitBox
aooohan commented on PR #542: URL: https://github.com/apache/tomcat/pull/542#issuecomment-1226960393 Merge manually. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [tomcat] markt-asf commented on pull request #545: Replace `LoggerThread` with single-threaded executor

2022-08-25 Thread GitBox
markt-asf commented on PR #545: URL: https://github.com/apache/tomcat/pull/545#issuecomment-1226902105 I think this is a better approach than the current code that uses a Thread. Therefore, I think we can close #544. I have been reviewing the PR and overall I like it. I have noticed

[GitHub] [tomcat] aooohan closed pull request #531: Bugfix for 63080 - Support rfc7239 Forwarded header

2022-08-24 Thread GitBox
aooohan closed pull request #531: Bugfix for 63080 - Support rfc7239 Forwarded header URL: https://github.com/apache/tomcat/pull/531 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [tomcat] aooohan commented on pull request #531: Bugfix for 63080 - Support rfc7239 Forwarded header

2022-08-24 Thread GitBox
aooohan commented on PR #531: URL: https://github.com/apache/tomcat/pull/531#issuecomment-1226801420 The implementation is a bit ugly, continue to optimize later, close first. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [tomcat-jakartaee-migration] aooohan commented on a diff in pull request #33: fixes #32 check if file name ends with manifest name

2022-08-24 Thread GitBox
aooohan commented on code in PR #33: URL: https://github.com/apache/tomcat-jakartaee-migration/pull/33#discussion_r954498342 ## src/test/java/org/apache/tomcat/jakartaee/ManifestConverterTest.java: ## @@ -0,0 +1,16 @@ +package org.apache.tomcat.jakartaee; + +import static

[GitHub] [tomcat] aooohan commented on pull request #542: Bugfix for 66210 - Some unit tests are failing on a non-English PC

2022-08-24 Thread GitBox
aooohan commented on PR #542: URL: https://github.com/apache/tomcat/pull/542#issuecomment-1226672348 If there are no problems, I will merge it today. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [tomcat] markt-asf closed pull request #535: List duplicate locations when failing a deploy due to duplicated fragment names

2022-08-24 Thread GitBox
markt-asf closed pull request #535: List duplicate locations when failing a deploy due to duplicated fragment names URL: https://github.com/apache/tomcat/pull/535 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [tomcat] markt-asf commented on pull request #535: List duplicate locations when failing a deploy due to duplicated fragment names

2022-08-24 Thread GitBox
markt-asf commented on PR #535: URL: https://github.com/apache/tomcat/pull/535#issuecomment-1225720989 AS per previous comment, merged manually. Thanks very much for the PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [tomcat] markt-asf commented on pull request #535: List duplicate locations when failing a deploy due to duplicated fragment names

2022-08-24 Thread GitBox
markt-asf commented on PR #535: URL: https://github.com/apache/tomcat/pull/535#issuecomment-1225666701 Thanks for the PR. I like it. I'm probably being over cautious but I'd like to retain backwards compatibility for the existing methods on WebXml - at least up to 10.0.x anyway. Therefore,

[GitHub] [tomcat] markt-asf commented on pull request #543: Optimize comment

2022-08-24 Thread GitBox
markt-asf commented on PR #543: URL: https://github.com/apache/tomcat/pull/543#issuecomment-122992 Thanks. I'll back-port this to earlier Tomcat versions as well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [tomcat] markt-asf merged pull request #543: Optimize comment

2022-08-24 Thread GitBox
markt-asf merged PR #543: URL: https://github.com/apache/tomcat/pull/543 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [tomcat] markt-asf closed pull request #546: Bugfix for 66233 - Response error msg when the number of Cookie exceeds maxCookieCount

2022-08-24 Thread GitBox
markt-asf closed pull request #546: Bugfix for 66233 - Response error msg when the number of Cookie exceeds maxCookieCount URL: https://github.com/apache/tomcat/pull/546 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [tomcat] markt-asf commented on pull request #546: Bugfix for 66233 - Response error msg when the number of Cookie exceeds maxCookieCount

2022-08-24 Thread GitBox
markt-asf commented on PR #546: URL: https://github.com/apache/tomcat/pull/546#issuecomment-122269 Sorry - didn't see this PR. I've just applied the same fix. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [tomcat-jakartaee-migration] wmccusker commented on a diff in pull request #33: fixes #32 check if file name ends with manifest name

2022-08-23 Thread GitBox
wmccusker commented on code in PR #33: URL: https://github.com/apache/tomcat-jakartaee-migration/pull/33#discussion_r951564802 ## src/test/java/org/apache/tomcat/jakartaee/ManifestConverterTest.java: ## @@ -0,0 +1,16 @@ +package org.apache.tomcat.jakartaee; + +import static

[GitHub] [tomcat] markt-asf closed pull request #541: Bugfix for 66183 - AccessLogValve - %{xxx}c should output the value of all cookies with the same name

2022-08-23 Thread GitBox
markt-asf closed pull request #541: Bugfix for 66183 - AccessLogValve - %{xxx}c should output the value of all cookies with the same name URL: https://github.com/apache/tomcat/pull/541 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [tomcat] markt-asf commented on pull request #541: Bugfix for 66183 - AccessLogValve - %{xxx}c should output the value of all cookies with the same name

2022-08-23 Thread GitBox
markt-asf commented on PR #541: URL: https://github.com/apache/tomcat/pull/541#issuecomment-1223727734 Applied manually with a few tweaks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [tomcat] aooohan commented on a diff in pull request #541: Bugfix for 66183 - AccessLogValve - %{xxx}c should output the value of all cookies with the same name

2022-08-23 Thread GitBox
aooohan commented on code in PR #541: URL: https://github.com/apache/tomcat/pull/541#discussion_r952287911 ## java/org/apache/catalina/valves/ExtendedAccessLogValve.java: ## @@ -298,12 +298,22 @@ public CookieElement(String name) { @Override public void

[GitHub] [tomcat] markt-asf commented on a diff in pull request #541: Bugfix for 66183 - AccessLogValve - %{xxx}c should output the value of all cookies with the same name

2022-08-23 Thread GitBox
markt-asf commented on code in PR #541: URL: https://github.com/apache/tomcat/pull/541#discussion_r952256591 ## java/org/apache/catalina/valves/ExtendedAccessLogValve.java: ## @@ -298,12 +298,22 @@ public CookieElement(String name) { @Override public void

[GitHub] [tomcat-jakartaee-migration] wmccusker commented on a diff in pull request #33: fixes #32 check if file name ends with manifest name

2022-08-22 Thread GitBox
wmccusker commented on code in PR #33: URL: https://github.com/apache/tomcat-jakartaee-migration/pull/33#discussion_r951564802 ## src/test/java/org/apache/tomcat/jakartaee/ManifestConverterTest.java: ## @@ -0,0 +1,16 @@ +package org.apache.tomcat.jakartaee; + +import static

[GitHub] [tomcat-jakartaee-migration] wmccusker commented on a diff in pull request #33: fixes #32 check if file name ends with manifest name

2022-08-22 Thread GitBox
wmccusker commented on code in PR #33: URL: https://github.com/apache/tomcat-jakartaee-migration/pull/33#discussion_r951564802 ## src/test/java/org/apache/tomcat/jakartaee/ManifestConverterTest.java: ## @@ -0,0 +1,16 @@ +package org.apache.tomcat.jakartaee; + +import static

[GitHub] [tomcat-jakartaee-migration] wmccusker commented on a diff in pull request #33: fixes #32 check if file name ends with manifest name

2022-08-22 Thread GitBox
wmccusker commented on code in PR #33: URL: https://github.com/apache/tomcat-jakartaee-migration/pull/33#discussion_r951565338 ## src/test/java/org/apache/tomcat/jakartaee/ManifestConverterTest.java: ## @@ -0,0 +1,16 @@ +package org.apache.tomcat.jakartaee; + +import static

[GitHub] [tomcat-jakartaee-migration] wmccusker commented on a diff in pull request #33: fixes #32 check if file name ends with manifest name

2022-08-22 Thread GitBox
wmccusker commented on code in PR #33: URL: https://github.com/apache/tomcat-jakartaee-migration/pull/33#discussion_r951564802 ## src/test/java/org/apache/tomcat/jakartaee/ManifestConverterTest.java: ## @@ -0,0 +1,16 @@ +package org.apache.tomcat.jakartaee; + +import static

[GitHub] [tomcat] aooohan opened a new pull request, #546: Bugfix for 66233 - Response error msg when the number of Cookie exceeds maxCookieCount

2022-08-22 Thread GitBox
aooohan opened a new pull request, #546: URL: https://github.com/apache/tomcat/pull/546 Fix [BZ66233](https://bz.apache.org/bugzilla/show_bug.cgi?id=66233) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [tomcat] ppkarwasz commented on a diff in pull request #545: Replace `LoggerThread` with single-threaded executor

2022-08-21 Thread GitBox
ppkarwasz commented on code in PR #545: URL: https://github.com/apache/tomcat/pull/545#discussion_r950998700 ## java/org/apache/juli/AsyncFileHandler.java: ## @@ -54,17 +60,12 @@ public class AsyncFileHandler extends FileHandler {

[GitHub] [tomcat] aooohan commented on a diff in pull request #545: Replace `LoggerThread` with single-threaded executor

2022-08-21 Thread GitBox
aooohan commented on code in PR #545: URL: https://github.com/apache/tomcat/pull/545#discussion_r950959440 ## java/org/apache/juli/AsyncFileHandler.java: ## @@ -54,17 +60,12 @@ public class AsyncFileHandler extends FileHandler {

[GitHub] [tomcat-jakartaee-migration] aooohan commented on a diff in pull request #33: fixes #32 check if file name ends with manifest name

2022-08-20 Thread GitBox
aooohan commented on code in PR #33: URL: https://github.com/apache/tomcat-jakartaee-migration/pull/33#discussion_r950782169 ## src/test/java/org/apache/tomcat/jakartaee/ManifestConverterTest.java: ## @@ -0,0 +1,16 @@ +package org.apache.tomcat.jakartaee; + +import static

[GitHub] [tomcat] ppkarwasz opened a new pull request, #545: Replace `LoggerThread` with single-threaded executor

2022-08-20 Thread GitBox
ppkarwasz opened a new pull request, #545: URL: https://github.com/apache/tomcat/pull/545 This provides an alternative solution to the `LoggerThread` problems described in #544. It replaces `LoggerThread` with a single-threaded `ExecutorService` almost identical to the one used by

[GitHub] [tomcat-jakartaee-migration] wmccusker opened a new pull request, #33: fixes #32 check if file name ends with manifest name

2022-08-19 Thread GitBox
wmccusker opened a new pull request, #33: URL: https://github.com/apache/tomcat-jakartaee-migration/pull/33 Check if the file name ends with the manifest name so that exploded archives with a war deployment are also migrated. -- This is an automated message from the Apache Git Service.

[GitHub] [tomcat-jakartaee-migration] wmccusker opened a new issue, #32: Manifest in exploded osgi bundle is not migrated

2022-08-19 Thread GitBox
wmccusker opened a new issue, #32: URL: https://github.com/apache/tomcat-jakartaee-migration/issues/32 Hi, When running the migration on a war file that contains an exploded osgi bundle the class files and jar files within the exploded bundle are migrated but the manifest file is

[GitHub] [tomcat] ppkarwasz commented on pull request #544: Avoid errors from shutting down `LoggerThread`

2022-08-18 Thread GitBox
ppkarwasz commented on PR #544: URL: https://github.com/apache/tomcat/pull/544#issuecomment-1220013953 @markt-asf, As far as I can see, the `LoggerThread` is the only part of JULI that needs to be concerned with `Throwable`s. I inline the relevant part of

[GitHub] [tomcat] markt-asf commented on pull request #544: Avoid errors from shutting down `LoggerThread`

2022-08-18 Thread GitBox
markt-asf commented on PR #544: URL: https://github.com/apache/tomcat/pull/544#issuecomment-1219639781 No need for a BZ issue. This looks like it needs some variation of ExceptionUtils.handleThrowable(). JULI may need its own copy of the utility. -- This is an automated message from

[GitHub] [tomcat] ppkarwasz opened a new pull request, #544: Avoid errors from shutting down `LoggerThread`

2022-08-18 Thread GitBox
ppkarwasz opened a new pull request, #544: URL: https://github.com/apache/tomcat/pull/544 A Java `Error` in the `LoggerThread` can effectively cripple Tomcat JULI, preventing all `AsyncFileHandler` from writing to their files. We experienced such a logging shutdown on a real Gerrit

[GitHub] [tomcat-jakartaee-migration] nissan4x4 commented on issue #29: Exception in thread "main" java.util.zip.ZipException: Bad CRC checksum for entry META-INF/MANIFEST.MF

2022-08-18 Thread GitBox
nissan4x4 commented on issue #29: URL: https://github.com/apache/tomcat-jakartaee-migration/issues/29#issuecomment-1219283706 Thank you very much Han. That worked perfectly. From: Han Li ***@***.***> Sent: Thursday, 18 August 2022 7:17 PM To:

[GitHub] [tomcat-jakartaee-migration] aooohan commented on issue #29: Exception in thread "main" java.util.zip.ZipException: Bad CRC checksum for entry META-INF/MANIFEST.MF

2022-08-18 Thread GitBox
aooohan commented on issue #29: URL: https://github.com/apache/tomcat-jakartaee-migration/issues/29#issuecomment-1219238170 > but my OS is windows not Unix. Sorry, I was careless.

[GitHub] [tomcat-jakartaee-migration] nissan4x4 commented on issue #29: Exception in thread "main" java.util.zip.ZipException: Bad CRC checksum for entry META-INF/MANIFEST.MF

2022-08-18 Thread GitBox
nissan4x4 commented on issue #29: URL: https://github.com/apache/tomcat-jakartaee-migration/issues/29#issuecomment-1219219413 Hi Han, Thanks for that, but my OS is windows not Unix. From: Han Li ***@***.***> Sent: Thursday, 18 August 2022 6:03 PM To:

[GitHub] [tomcat-jakartaee-migration] aooohan commented on issue #29: Exception in thread "main" java.util.zip.ZipException: Bad CRC checksum for entry META-INF/MANIFEST.MF

2022-08-18 Thread GitBox
aooohan commented on issue #29: URL: https://github.com/apache/tomcat-jakartaee-migration/issues/29#issuecomment-1219162105 Hi, @nissan4x4

[GitHub] [tomcat-jakartaee-migration] nissan4x4 commented on issue #29: Exception in thread "main" java.util.zip.ZipException: Bad CRC checksum for entry META-INF/MANIFEST.MF

2022-08-18 Thread GitBox
nissan4x4 commented on issue #29: URL: https://github.com/apache/tomcat-jakartaee-migration/issues/29#issuecomment-1219144189 Hi, @aooohan. I am experiencing the same issue as @gregorkistler with the CRC. ``` 18-Aug-2022 14:55:06.339 WARNING [Catalina-utility-1]

[GitHub] [tomcat] tianshuang opened a new pull request, #543: Optimize comment

2022-08-18 Thread GitBox
tianshuang opened a new pull request, #543: URL: https://github.com/apache/tomcat/pull/543 HTTP2 also supports relative redirects. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [tomcat] aooohan opened a new pull request, #542: Bugfix for 66210 - Some unit tests are failing on a non-English PC

2022-08-17 Thread GitBox
aooohan opened a new pull request, #542: URL: https://github.com/apache/tomcat/pull/542 Fix [BZ66210](https://bz.apache.org/bugzilla/show_bug.cgi?id=66210) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [tomcat-jakartaee-migration] markt-asf closed issue #31: Exception occured while sending Websocket Message and the session is being closed.

2022-08-16 Thread GitBox
markt-asf closed issue #31: Exception occured while sending Websocket Message and the session is being closed. URL: https://github.com/apache/tomcat-jakartaee-migration/issues/31 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [tomcat-jakartaee-migration] markt-asf commented on issue #31: Exception occured while sending Websocket Message and the session is being closed.

2022-08-16 Thread GitBox
markt-asf commented on issue #31: URL: https://github.com/apache/tomcat-jakartaee-migration/issues/31#issuecomment-1216759692 Wrong project. And support questions belong on the users mailing list, not in the issue tracker. https://tomcat.apache.org/lists.html#tomcat-users -- This is

[GitHub] [tomcat-jakartaee-migration] Karthikeyan021298 opened a new issue, #31: Exception occured while sending Websocket Message and the session is being closed.

2022-08-16 Thread GitBox
Karthikeyan021298 opened a new issue, #31: URL: https://github.com/apache/tomcat-jakartaee-migration/issues/31 Hi, I am trying to send the Message from the Websocket Server using "session.getBasicRemote().sendText("message");" , I got the IO exception message" The current thread

[GitHub] [tomcat] aooohan opened a new pull request, #541: Bugfix for 66183 - AccessLogValve - %{xxx}c should output the value of all cookies with the same name

2022-08-15 Thread GitBox
aooohan opened a new pull request, #541: URL: https://github.com/apache/tomcat/pull/541 Fix [BZ66183](https://bz.apache.org/bugzilla/show_bug.cgi?id=66183) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

  1   2   3   4   5   6   7   8   9   10   >