Re: [VOTE] Release Apache Tomcat 8.5.59

2020-10-07 Thread Igal Sapir
On Tue, Oct 6, 2020 at 10:34 AM Mark Thomas wrote: > The proposed Apache Tomcat 8.5.59 release is now available for voting. > > > > The proposed 8.5.59 release is: > [ ] Broken - do not release > [X] Stable - go ahead and release as 8.5.59 > Unit tests passed on Ubuntu 20.04 with Java 11 and

Re: [VOTE] Release Apache Tomcat 9.0.39

2020-10-07 Thread Igal Sapir
On Tue, Oct 6, 2020 at 7:49 AM Mark Thomas wrote: > The proposed Apache Tomcat 9.0.39 release is now available for voting. > > > > The proposed 9.0.39 release is: > [ ] Broken - do not release > [X] Stable - go ahead and release as 9.0.39 > Unit tests passed on Ubuntu 20.04 with Java 11 and

Re: [VOTE] Release Apache Tomcat 9.0.39

2020-10-07 Thread Igal Sapir
I got an error [1] running unit tests. Will run it again in case it's just a fluke or a fragile test case. Igal [1] Testcase: testExceedMaxActiveStreams02[0] took 0.282 sec Caused an ERROR End of input stream java.io.IOException: End of input stream at

Re: [VOTE] Release Apache Tomcat 10.0.0-M9

2020-10-07 Thread Igal Sapir
On Tue, Oct 6, 2020 at 6:38 AM Mark Thomas wrote: > The proposed Apache Tomcat 10.0.0-M9 release is now available for > voting. > > > > The proposed 10.0.0-M9 release is: > [ ] Broken - do not release > [X] Alpha - go ahead and release as 10.0.0-M9 > Unit tests passed on Ubuntu 20.04 with

Re: Use of "constants" in Manager to generate HTML/CSS content

2020-08-16 Thread Igal Sapir
Konstantin, On Sun, Aug 16, 2020 at 1:00 PM Konstantin Kolinko wrote: > вс, 16 авг. 2020 г. в 21:32, Igal Sapir : > > > > I don't see any scripts either. Why not add a CSP and set script to > 'none'? I can add that if no one objects. > > > > sessionsList.jsp

Re: [tomcat] branch master updated: Extracted CSS styles to external file for better code mainenance

2020-08-16 Thread Igal Sapir
gitbox.apache.org/repos/asf/tomcat.git > > > > > > The following commit(s) were added to refs/heads/master by this push: > > new 9c5d2e3 Extracted CSS styles to external file for better code > mainenance > > 9c5d2e3 is described below > > > >

Re: Use of "constants" in Manager to generate HTML/CSS content

2020-08-16 Thread Igal Sapir
On Wed, Aug 12, 2020 at 8:47 AM Christopher Schultz < ch...@christopherschultz.net> wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA256 > > Konstantin, > > On 8/12/20 10:02, Konstantin Kolinko wrote: > > вт, 28 июл. 2020 г. в 16:55, Christopher Schultz > > : > >> > >> All, > >> > >> I was

Re: Use of "constants" in Manager to generate HTML/CSS content

2020-08-11 Thread Igal Sapir
Chris, On Mon, Aug 10, 2020 at 12:20 PM Martin Grigorov wrote: > > On Tue, Jul 28, 2020, 16:48 Christopher Schultz < > ch...@christopherschultz.net> wrote: > >> -BEGIN PGP SIGNED MESSAGE- >> Hash: SHA256 >> >> All, >> >> I was looking at this PR[1] and wondering why we have huge swaths

Re: How to run individual Test

2020-08-10 Thread Igal Sapir
Saksham, On Mon, Aug 10, 2020 at 9:46 AM Saksham Verma wrote: > Hi Dev Team, > > Need help with below questions: > > 1. The Pull request Tests are failing on Travis CI. But Is there any way I > can get the logs for the test job? > > 2. How can I run any individual test. > See section 7 of the

Re: Publishing EOL dates on whichversion?

2020-08-07 Thread Igal Sapir
Chris, On Thu, Aug 6, 2020 at 8:29 AM Christopher Schultz < ch...@christopherschultz.net> wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA256 > > All, > > I'm wondering if we shouldn't add EOL dates to the "which version" page. > > The table on that page is very busy, but I think it would

Jasper throws an NPE when running in IntelliJ IDEA

2019-12-24 Thread Igal Sapir
I have set up Tomcat in IntelliJ using the ant task, `ant ide-intellij`. I added the PATH variables for ANT_HOME and TOMCAT_BUILD_LIBS, and marked the directory webapps/examples/WEB-INF/classes as a Source Folder. If I call the URI for /tomcat.gif, for example, it works as expected and I get the

Re: Broken links on the website

2019-12-17 Thread Igal Sapir
[2] https://tomcat.apache.org/download-90.cgi [3] https://support.google.com/webmasters/answer/139066?hl=en On Tue, Dec 17, 2019 at 6:18 PM Igal Sapir wrote: > Something went wrong on the website. Specifically, the Download page for > 9.0 [1] shows attributes that should be evaluated, e.g

Broken links on the website

2019-12-17 Thread Igal Sapir
Something went wrong on the website. Specifically, the Download page for 9.0 [1] shows attributes that should be evaluated, e.g. [define v]9.0.30[end]. That also breaks the download links which do not evaluate the version number properly. I can look into it tomorrow, but if someone more

Re: Initial set of patches for Jakarta EE 9

2019-12-02 Thread Igal Sapir
On 12/1/2019 1:28 PM, Mark Thomas wrote: On 30/11/2019 21:11, Igal Sapir wrote: First issue I noticed when trying to build on Windows: compile:     [javac] Compiling 1727 source files to E:\Workspace\test\tomcat-jakarta\output\classes     [javac] E:\Workspace\test\tomcat-jakarta\java\org

Re: Initial set of patches for Jakarta EE 9

2019-11-30 Thread Igal Sapir
Mark, On 11/28/2019 11:46 AM, Mark Thomas wrote: Hi all, I have pushed an initial set of patches for Jakarta EE 9 here: https://github.com/markt-asf/tomcat/tree/jakarta The current status is: - All the packages changing in Jakarta EE 9 have been renamed - Any associated constants, service

Re: [VOTE] Release Apache Tomcat 8.5.49

2019-11-18 Thread Igal Sapir
On 11/18/2019 1:22 PM, Mark Thomas wrote: On 17/11/2019 19:01, Mark Thomas wrote: We have a regression affecting 8.5.x (and 7.0.x). The fix [1] for an issue raised on the users list [2] was incorrect and creating a different issue [3]. There are two questions to address. a) Do we cancel the

Re: [VOTE] Release Apache Tomcat 9.0.29

2019-11-18 Thread Igal Sapir
On 11/16/2019 10:56 AM, Mark Thomas wrote: The proposed Apache Tomcat 9.0.29 release is now available for voting. The proposed 9.0.29 release is: [ ] Broken - do not release [X] Stable - go ahead and release as 9.0.29 Unit tests passed on Windows 10 and Ubuntu 18.04 Igal

Re: [VOTE] Release Apache Tomcat 8.5.49

2019-11-18 Thread Igal Sapir
On 11/17/2019 11:01 AM, Mark Thomas wrote: The proposed Apache Tomcat 8.5.49 release is now available for voting. The proposed 8.5.49 release is: [ ] Broken - do not release [X] Stable - go ahead and release as 8.5.49 Unit tests passed on Windows 10 and Ubuntu 18.04 Igal

Re: [VOTE] Release Apache Tomcat 8.5.47

2019-10-08 Thread Igal Sapir
On 10/7/2019 6:58 AM, Mark Thomas wrote: The proposed Apache Tomcat 8.5.47 release is now available for voting. The major changes compared to the 8.5.46 release are: I'm getting similar test failures as I did for 9.0.27 on that same Windows machine: > grep -A 5 FAILED

Re: [VOTE] Release Apache Tomcat 9.0.27

2019-10-07 Thread Igal Sapir
Mark, On 10/7/2019 4:51 AM, Mark Thomas wrote: The proposed Apache Tomcat 9.0.27 release is now available for voting. I'm getting the failures below [1] for unit tests on Windows 10 with Java 1.8u181.  False positives? Igal [1] output\build\logs> grep -A 5 FAILED * */*

Re: [PROPOSAL] Tomcat 10: Remove CGI Servlet

2019-10-07 Thread Igal Sapir
On 10/7/2019 8:14 AM, Christopher Schultz wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Mark, On 10/7/19 11:10, Mark Thomas wrote: All, I recently gave a presentation on locking-down Apache Tomcat[1] and I briefly discussed the "sharp edges" present in Tomcat. Some of them are

Re: [PROPOSAL] Tomcat 10: Remove Server-Side Includes (SSI)

2019-10-07 Thread Igal Sapir
On 10/7/2019 7:46 AM, Christopher Schultz wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA256 All, I recently gave a presentation on locking-down Apache Tomcat[1] and I briefly discussed the "sharp edges" present in Tomcat. Some of them are unnecessarily sharp and may be actually

Re: [VOTE] Release Apache Tomcat 8.5.46

2019-09-17 Thread Igal Sapir
On 9/16/2019 11:46 AM, Mark Thomas wrote: The proposed Apache Tomcat 8.5.46 release is now available for voting. The proposed 8.5.46 release is: [ ] Broken - do not release [X] Stable - go ahead and release as 8.5.46 Igal

Re: [VOTE] Release Apache Tomcat 9.0.26

2019-09-17 Thread Igal Sapir
Mark, On 9/17/2019 1:56 PM, Mark Thomas wrote: On 17/09/2019 19:46, Igal Sapir wrote: On 9/16/2019 9:15 AM, Mark Thomas wrote: The proposed Apache Tomcat 9.0.26 release is now available for voting. [1] Testsuite: org.apache.catalina.core.TestAsyncContextImpl Tests run: 1, Failures: 0

Re: [VOTE] Release Apache Tomcat 9.0.26

2019-09-17 Thread Igal Sapir
On 9/16/2019 9:15 AM, Mark Thomas wrote: The proposed Apache Tomcat 9.0.26 release is now available for voting. The major changes compared to the 9.0.24 release are: - Update to Commons Daemon 1.2.1 to pick up fixes for regressions in Commons Daemon 1.2.0, most notably a failure to start

Re: [VOTE] Release Apache Tomcat 9.0.24

2019-08-15 Thread Igal Sapir
On Wed, Aug 14, 2019 at 2:45 PM Mark Thomas wrote: > > The proposed 9.0.24 release is: > [ ] Broken - do not release > [X] Stable - go ahead and release as 9.0.24 > All unit tests passed successfully on Windows 10 and Ubuntu 18.04 Best, Igal > >

Re: [VOTE] Release Apache Tomcat 8.5.45

2019-08-15 Thread Igal Sapir
On Wed, Aug 14, 2019 at 3:48 PM Mark Thomas wrote: > > The tag is: > https://github.com/apache/tomcat/tree/8.5.45 > 46d444a14cdac3e7e1f011a02cbdac9e5a80631c > > The proposed 8.5.45 release is: > [ ] Broken - do not release > [X] Stable - go ahead and release as 8.5.45 > All unit tests passed

Re: Graal and Tomcat Native

2019-07-10 Thread Igal Sapir
Rémy, At the risk of pointing out the obvious as I'm sure that you are much more familiar with this than I am: On 7/10/2019 11:42 AM, Rémy Maucherat wrote: Hi, I'm a bit stumped there, as I'm trying to get native to work in that rather special environment. JNI_OnLoad fails with: WARNING:

Re: [VOTE][RESULT] Release Apache Tomcat 9.0.22

2019-07-10 Thread Igal Sapir
Chris, On 7/10/2019 6:44 AM, Christopher Schultz wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA256 All, Yep, the APR library was the problem. For some reason, it did not load for a great many (all?) tests. I'll have to check my testing process. - -chris I would suspect an all or

Re: Git repo for Tomcat Site

2019-07-09 Thread Igal Sapir
Mark, On 7/9/2019 1:45 AM, Mark Thomas wrote: On 09/07/2019 05:29, Igal Sapir wrote: Can we move the Tomcat site to Git? Yes. ASF infra supports both svnpubsub and gitpubsub for websites. There will need to be a little co-ordination with infra as we'd need to switch where the source

Git repo for Tomcat Site

2019-07-08 Thread Igal Sapir
Can we move the Tomcat site to Git?  Possibly to a repo named "tomcat-site"? I'd be happy to make the required changes per prior emails so that we can publish the new design in time for ACNA. Thoughts? Igal - To

Broken Download Links for Tomcat Native Binaries

2019-07-08 Thread Igal Sapir
The download page for the Tomcat Native Binaries [1] has broken links.  Pretty much all of the links under "Binaries for Microsoft Windows", e.g. the one labeled "Native 1.2.23 Windows Binaries zip" [2] returns a 404. Were the binaries created at all?  Perhaps at a different location? Igal

Re: [VOTE] Release Apache Tomcat 8.5.43

2019-07-08 Thread Igal Sapir
On 7/4/2019 2:19 PM, Mark Thomas wrote: The proposed Apache Tomcat 8.5.43 release is now available for voting. The proposed 8.5.43 release is: [ ] Broken - do not release [X] Stable - go ahead and release as 8.5.43 Unit tests passed on Windows 10 and Ubuntu 18.04 with Java 8 Igal

Re: [VOTE] Release Apache Tomcat 9.0.22

2019-07-08 Thread Igal Sapir
On 7/4/2019 12:33 PM, Mark Thomas wrote: The proposed Apache Tomcat 9.0.22 release is now available for voting. The proposed 9.0.22 release is: [ ] Broken - do not release [X] Stable - go ahead and release as 9.0.22 Unit tests passed on Windows 10 and Ubuntu 18.04 with Java 8 Igal

Re: Unit Tests and OpenSSL Ciphers

2019-06-27 Thread Igal Sapir
On 6/27/2019 8:56 AM, Mark Thomas wrote: The ciphers supported by Ubuntu have changed. You need to use: openssl ciphers -v ALL:eNULL to see all of them. The short version is that ARIA ciphers are now supported. test.openssl.unimplemented=IDEA should fix it. Thanks, Mark! The part that

Unit Tests and OpenSSL Ciphers

2019-06-26 Thread Igal Sapir
While testing Tomcat Native 1.2.23 two unit tests failed on my system: TEST-org.apache.tomcat.util.net.openssl.ciphers.TestCipher.APR.txt TEST-org.apache.tomcat.util.net.openssl.ciphers.TestOpenSSLCipherConfigurationParser.APR.txt My build.properties includes the following:

Re: [VOTE] Release Apache Tomcat Native 1.2.23

2019-06-26 Thread Igal Sapir
On 6/26/2019 6:20 AM, Mark Thomas wrote: The Apache Tomcat Native 1.2.23 release is [X] Stable, go ahead and release [ ] Broken because of ... Built from source and ran unit tests with Tomcat 9.0.21 on Ubuntu 18.04 with Java 8u202. I got two failing tests but it looks like they failed

Re: Tomcat-Native - Time to move to git?

2019-06-17 Thread Igal Sapir
On 6/17/2019 2:18 PM, Rainer Jung wrote: Am 17.06.2019 um 18:56 schrieb Mark Thomas: Hi, I'm starting to look at OCSP stapling for our OpenSSL based connectors and I suspect a Tomcat Native release will be required. Even if it isn't for this, it has been a while since the last Tomcat Native

Re: [VOTE] Release Apache Tomcat 9.0.21

2019-06-05 Thread Igal Sapir
On 6/4/2019 1:50 PM, Mark Thomas wrote: The proposed 9.0.21 release is: [ ] Broken - do not release [X] Stable - go ahead and release as 9.0.21 +1 Igal - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For

Re: [VOTE] Release Apache Tomcat 8.5.42

2019-06-05 Thread Igal Sapir
On 6/4/2019 2:06 PM, Mark Thomas wrote: The proposed 8.5.42 release is: [ ] Broken - do not release [X] Stable - go ahead and release as 8.5.42 +1 Igal - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For

Re: [VOTE] Release Apache Tomcat 8.5.41

2019-05-04 Thread Igal Sapir
On 5/4/2019 2:56 AM, Mark Thomas wrote: The proposed Apache Tomcat 8.5.41 release is now available for voting. The proposed 8.5.41 release is: [ ] Broken - do not release [X] Stable - go ahead and release as 8.5.41 Unit tests passed on Ubuntu and Windows with Java 8 and tc-native-1.2.21 Igal

Re: [VOTE] Release Apache Tomcat 9.0.20

2019-05-04 Thread Igal Sapir
On 5/3/2019 3:52 PM, Mark Thomas wrote: The proposed Apache Tomcat 9.0.20 release is now available for voting. The proposed 9.0.20 release is: [ ] Broken - do not release [X] Stable - go ahead and release as 9.0.20 Unit tests pass for NIO, NIO2, and APR on Ubuntu and Windows with Java 8 and

Re: Remote attendance at Hackathon

2019-05-02 Thread Igal Sapir
On Thu, May 2, 2019 at 7:26 AM Christopher Schultz < ch...@christopherschultz.net> wrote: > > > > > I think that it's a great idea. I would have loved to attend in > > person but travelling on those dates didn't work for me. Doing so > > remotely would be great if possible. > > The schedule

Re: Remote attendance at Hackathon

2019-05-01 Thread Igal Sapir
Mark, On Wed, May 1, 2019 at 2:03 PM Mark Thomas wrote: > Hi all, > > What to folks think about setting up a #Tomcat channel on the ASF slack > instance and using it during the hackathon to interact with folks that > want to be involved but can't travel? > > It would allow general chat as well

Re: [OT] Finally getting around to switching to Git

2019-04-29 Thread Igal Sapir
Chris, On 4/29/2019 12:18 PM, Christopher Schultz wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Igal, On 4/29/19 14:52, Igal Sapir wrote: Chris, On Thu, Apr 25, 2019 at 12:08 PM Christopher Schultz < ch...@christopherschultz.net> wrote: -BEGIN PGP SIGNED MESSAGE

Re: [OT] Finally getting around to switching to Git

2019-04-29 Thread Igal Sapir
Chris, On Thu, Apr 25, 2019 at 12:08 PM Christopher Schultz < ch...@christopherschultz.net> wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA256 > > Igal, > > On 4/25/19 14:42, Igal Sapir wrote: > > On 4/25/2019 11:30 AM, Coty Sutherland wrote: >

Enabling Jasper when running in IDE

2019-04-28 Thread Igal Sapir
When running Tomcat (using 9.0.x with default settings) in an IDE I get an NPE when trying to access JSP files. I have traced it down to the fact that the JspFactory.setDefaultFactory() is never called and therefore getDefaultFactory() returns null. When launching using the catalina.sh script,

Re: [OT] Finally getting around to switching to Git

2019-04-25 Thread Igal Sapir
Chris, On 4/25/2019 12:08 PM, Christopher Schultz wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Igal, On 4/25/19 14:42, Igal Sapir wrote: On 4/25/2019 11:30 AM, Coty Sutherland wrote: If you clone a single branch with no references such as `git clone apache/tomcat -b master

Re: Finally getting around to switching to Git

2019-04-25 Thread Igal Sapir
Chris, On 4/25/2019 12:07 PM, Christopher Schultz wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Igal, On 4/25/19 14:03, Igal Sapir wrote: Chris, On 4/25/2019 10:32 AM, Christopher Schultz wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Igal, On 4/23/19 12:52, Igal Sapir

Re: Finally getting around to switching to Git

2019-04-25 Thread Igal Sapir
Coty, On 4/25/2019 11:30 AM, Coty Sutherland wrote: On Thu, Apr 25, 2019 at 2:06 PM Igal Sapir wrote: On 4/25/2019 10:56 AM, Coty Sutherland wrote: On Thu, Apr 25, 2019 at 1:32 PM Christopher Schultz < ch...@christopherschultz.net> wrote: -BEGIN PGP SIGNED MESSAGE- Hash:

Re: Finally getting around to switching to Git

2019-04-25 Thread Igal Sapir
On 4/25/2019 10:56 AM, Coty Sutherland wrote: On Thu, Apr 25, 2019 at 1:32 PM Christopher Schultz < ch...@christopherschultz.net> wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Igal, On 4/23/19 12:52, Igal Sapir wrote: Another thing that I have changed in my workflow based on

Re: Finally getting around to switching to Git

2019-04-25 Thread Igal Sapir
Chris, On 4/25/2019 10:32 AM, Christopher Schultz wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Igal, On 4/23/19 12:52, Igal Sapir wrote: Another thing that I have changed in my workflow based on Mark's past suggestion, is that I keep a local repo for each major branch now. Okay, I

Re: Finally getting around to switching to Git

2019-04-23 Thread Igal Sapir
On 4/23/2019 8:48 AM, Martin Grigorov wrote: On Tue, Apr 23, 2019, 17:29 Christopher Schultz < ch...@christopherschultz.net> wrote: Setting up the account is needed. I failed to do it, and Mark told me I needed three green ticks there: https://gitbox.apache.org/setup/ Thanks. Looks like

Re: [VOTE] Release Apache Tomcat 9.0.19

2019-04-12 Thread Igal Sapir
I am getting a unit test failure: On Fri, Apr 12, 2019 at 7:48 AM Mark Thomas wrote: > The proposed Apache Tomcat 9.0.19 release is now available for voting. > 9.0.19 corrects a regression and a number of packaging errors in 9.0.18. > > The major changes compared to the 9.0.17 release are: > >

RE: [tomcat] branch master updated: Fixed false positives in unit tests on Windows

2019-04-11 Thread Igal Sapir
985d008 is described below > > commit 985d0086329c012a994c842f0a88a9b33989827c > Author: Igal Sapir > AuthorDate: Thu Apr 11 08:45:22 2019 -0700 > > Fixed false positives in unit tests on Windows > > When the drive letter is lower cased in a Windows command prompt the > test cases were failing

Re: [VOTE] Release Apache Tomcat 8.5.40

2019-04-10 Thread Igal Sapir
On 4/10/2019 7:58 AM, Mark Thomas wrote: The proposed 8.5.40 release is: [ ] Broken - do not release [X] Stable - go ahead and release as 8.5.40 Unit tests pass for NIO, NIO2, and APR on Windows 10 with Java 1.8u181 and TC-Native 1.2.21 and Ubuntu 18.04 with Java 1.8u202 and TC-Native 1.2.21

Re: [VOTE] Release Apache Tomcat 9.0.18

2019-04-10 Thread Igal Sapir
On 4/10/2019 6:44 AM, Mark Thomas wrote: The proposed 9.0.18 release is: [ ] Broken - do not release [X] Stable - go ahead and release as 9.0.18 Unit tests pass for NIO, NIO2, and APR on Ubuntu 18.04 with Java 1.8u202 and TC-Native 1.2.21 Igal

Re: [VOTE] Release Apache Tomcat 7.0.94

2019-04-10 Thread Igal Sapir
On 4/10/2019 10:22 AM, Mark Thomas wrote: The proposed 7.0.94 release is: [ ] Broken - do not release [X] Stable - go ahead and release as 7.0.94 Stable Unit tests pass for BIO, NIO, and APR on Ubuntu 18.04 with Java 1.6u45/1.7u80 and TC-Native-1.2.21 Igal

Re: Tomcat Site Redesign

2019-03-27 Thread Igal Sapir
standable. > > сб, 9 мар. 2019 г. в 00:15, Igal @ Lucee.org : > > > > All, > > > > On 3/7/2019 3:22 AM, Konstantin Kolinko wrote: > > > > > пн, 4 мар. 2019 г. в 09:02, Igal Sapir : > > >> I have uploaded the Tomcat site redesign to a temporary loca

Re: Tomcat Site Redesign

2019-03-27 Thread Igal Sapir
On Tue, Mar 26, 2019 at 6:12 PM Christopher Schultz < ch...@christopherschultz.net> wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA256 > > Konstantin, > > On 3/25/19 17:41, Konstantin Kolinko wrote: > > My main concern is that the documentation is printable and is easy > > to use as a

Re: Is it possible to modify the commit email template?

2019-03-23 Thread Igal Sapir
ion email. Thanks, Igal [1] https://github.com/apache/infrastructure-puppet/pull/1489/files https://ci.apache.org/builders/infrastructure-puppet-deployment/builds/4228 > > Mark > > > On 22/03/2019 16:40, Igal Sapir wrote: > > Is it possible to add a URL to the commit email tem

Re: Test Case Ciphers (was: Release Apache Tomcat 8.5.38)

2019-03-23 Thread Igal Sapir
Emmanuel, On Tue, Feb 5, 2019 at 11:45 AM Igal Sapir wrote: > On Tue, Feb 5, 2019 at 11:12 AM Emmanuel Bourg wrote: > >> Le 05/02/2019 à 19:02, Igal Sapir a écrit : >> >> > Do you get any "missing ciphers" errors or not even that? I always get >>

Is it possible to modify the commit email template?

2019-03-22 Thread Igal Sapir
Is it possible to add a URL to the commit email templates so that it's easier to see the diff? For example, the email titled "[tomcat] branch 7.0.x updated: Generics: BasicDataSource" has a commit hash of 153757518621f906d3a223836b8d80 If we could prefix it as below it can become a link to a

Re: Tomcat Website Redesign

2019-03-20 Thread Igal Sapir
On 3/20/2019 10:49 AM, Mark Thomas wrote: On 20/03/2019 16:01, Igal Sapir wrote:   The way I see it we have the following options ATM: a) Do nothing, i.e. keep the website as-is [1] for now b) I can address the issues that were brought up and fix them for the current proposed design [2] c) I

Tomcat Website Redesign

2019-03-20 Thread Igal Sapir
Hi all, As you probably know I have been working on a redesign of the Tomcat website but it's a bit of a challenge to come up with a design that everyone likes.  The way I see it we have the following options ATM: a) Do nothing, i.e. keep the website as-is [1] for now b) I can address the

Re: Tomcat 7, DBCP 1.x and generics

2019-03-20 Thread Igal Sapir
On 3/19/2019 6:34 AM, Mark Thomas wrote: On 19/03/2019 04:04, Igal Sapir wrote: On 3/18/2019 1:28 PM, Mark Thomas wrote: All, I started to work on cleaning up the DBCP generics warnings in 7.0.x before I remembered what "fun" it was when I did this for DBCP2. While some of it i

Re: Tomcat 7, DBCP 1.x and generics

2019-03-18 Thread Igal Sapir
On 3/18/2019 1:28 PM, Mark Thomas wrote: All, I started to work on cleaning up the DBCP generics warnings in 7.0.x before I remembered what "fun" it was when I did this for DBCP2. While some of it is straight-forward, some of it requires some refactoring. From memory, the refactoring did fix

Re: Default Number of Test Threads

2019-03-17 Thread Igal Sapir
Chris, On Sat, Mar 16, 2019 at 8:22 AM Christopher Schultz < ch...@christopherschultz.net> wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA256 > > Igal, > > On 3/15/19 22:38, Igal Sapir wrote: > > Chris, > > > > On Fri, Mar 15, 20

Re: Default Number of Test Threads

2019-03-15 Thread Igal Sapir
Chris, On Fri, Mar 15, 2019 at 4:56 PM Christopher Schultz < ch...@christopherschultz.net> wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA256 > > Igal, > > On 3/15/19 16:45, Igal Sapir wrote: > > > > I looked deeper into build.xml and I fo

Re: Default Number of Test Threads

2019-03-15 Thread Igal Sapir
Chris, On Fri, Mar 15, 2019 at 4:53 PM Christopher Schultz < ch...@christopherschultz.net> wrote: > > > I think you are on Windows (?),. but maybe you could use this script: > > https://github.com/ChristopherSchultz/apache-tomcat-stuff/tree/master/bi > n > > (look for test-tomcat-release.sh) >

Re: Wiki migration

2019-03-15 Thread Igal Sapir
On 3/15/2019 11:32 AM, Mark Thomas wrote: There also exists the following project, http://jspwiki.apache.org/ if we talk about "our own dog food". Infra has chosen Confluence. If we want to run jspwiki on our own VM that is an option but it needs *long term* volunteers to maintain the VM.

Re: buildbot failure in on tomcat-trunk

2019-03-15 Thread Igal Sapir
Source Stamp: [branch master] 8a2f41bed80a96bd6d711594ea8b6b7f0f1451da Blamelist: Igal Sapir BUILD FAILED: failed compile_1 Sincerely, -The Buildbot - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional

Re: Default Number of Test Threads

2019-03-15 Thread Igal Sapir
On Fri, Mar 15, 2019 at 9:45 AM Konstantin Kolinko wrote: > чт, 14 мар. 2019 г. в 22:26, Igal Sapir : > > What is the use case? People verifying a release? CI servers that may > have different hardware? > The idea was more for testing new releases. On my laptop setting te

Re: [VOTE] Release Apache Tomcat 8.5.39

2019-03-14 Thread Igal Sapir
On 3/14/2019 6:43 AM, Mark Thomas wrote: The proposed Apache Tomcat 8.5.39 release is now available for voting. The proposed 8.5.39 release is: [ ] Broken - do not release [X] Stable - go ahead and release as 8.5.39 Tested on Windows 10 and Ubuntu 18.04 Best, Igal

Re: Default Number of Test Threads

2019-03-14 Thread Igal Sapir
On 3/14/2019 12:51 PM, Mark Thomas wrote: On 14/03/2019 19:26, Igal Sapir wrote: Does test.threads default to 1 for a reason? Mostly historical. The tests weren't originally designed to run in parallel. If there is no objection, I would like to set the default to the number of available CPU

Default Number of Test Threads

2019-03-14 Thread Igal Sapir
Does test.threads default to 1 for a reason? If there is no objection, I would like to set the default to the number of available CPU Threads.  It looks like that can be done with a custom Ant task which should be fairly simple to implement. Best, Igal

Re: [VOTE] Release Apache Tomcat 9.0.17

2019-03-14 Thread Igal Sapir
On 3/13/2019 11:23 AM, Mark Thomas wrote: The proposed Apache Tomcat 9.0.17 release is now available for voting. The proposed 9.0.17 release is: [ ] Broken - do not release [X] Stable - go ahead and release as 9.0.17 Tested on Ubuntu 18.04 and Windows 10

Re: GitHub notifications show Mark Thomas as Sender

2019-03-08 Thread Igal Sapir
Oh wait, unless that action was made by Mark. I saw a few messages in a row and misunderstood. Please ignore the previous email. On Fri, Mar 8, 2019 at 12:58 PM Igal Sapir wrote: > I got some GitHub notifications and they have the following header: > > From: Mark Thomas >

GitHub notifications show Mark Thomas as Sender

2019-03-08 Thread Igal Sapir
I got some GitHub notifications and they have the following header: From: Mark Thomas If someone with permissions can change that please. Best, Igal

Re: Tomcat Site Redesign

2019-03-07 Thread Igal Sapir
I made the text darker (#333) and pulled the date to the right as on the current site. On Thu, Mar 7, 2019 at 9:50 AM Igal Sapir wrote: > Konstantin, > > Thank you for your feedback: > > On Thu, Mar 7, 2019 at 3:29 AM Konstantin Kolinko > wrote: > >> пн, 4 мар.

Re: Tomcat Site Redesign

2019-03-07 Thread Igal Sapir
Konstantin, Thank you for your feedback: On Thu, Mar 7, 2019 at 3:29 AM Konstantin Kolinko wrote: > пн, 4 мар. 2019 г. в 09:02, Igal Sapir : > > > > I have uploaded the Tomcat site redesign to a temporary location for > review: > > http://people.apache.org/~isapir/mo

Re: Tomcat Site Redesign

2019-03-05 Thread Igal Sapir
Chris, Thank you for the feedback: On Tue, Mar 5, 2019 at 11:49 AM Christopher Schultz < ch...@christopherschultz.net> wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA256 > > Igal, > > On 3/4/19 01:02, Igal Sapir wrote: > > I have uploaded the Tomcat site re

Re: Git Migration: What is the svn:eol-style equilvalent?

2019-03-05 Thread Igal Sapir
Coty, On Tue, Mar 5, 2019 at 6:23 AM Coty Sutherland wrote: > Hi, > > I updated the BUILDING and CONTRIBUTING documents so that GitHub users no > longer see instructions for SVN after our migration, however I had a few > questions. Does anyone know of a git equivalent to svn:eol-style that we >

Tomcat Site Redesign

2019-03-03 Thread Igal Sapir
I have uploaded the Tomcat site redesign to a temporary location for review: http://people.apache.org/~isapir/mockups/tomcat-site/ The source can be seen at https://github.com/isapir/tomcat-website This includes all of the pages for the website, but not the documentation for the different

Building and Testing Tomcat 7

2019-03-02 Thread Igal Sapir
Rainer, On Sat, Feb 16, 2019 at 2:42 PM Rainer Jung wrote: > Hi Igal, > > Am 16.02.2019 um 22:10 schrieb Igal Sapir: > > Violeta, > > > > On Sat, Feb 16, 2019 at 9:41 AM Violeta Georgieva > > wrote: > > > >> The proposed Apache Tomcat 7.0.93 rele

Re: Building and Testing Tomcat 7

2019-03-02 Thread Igal Sapir
Fix typo: On Sat, Mar 2, 2019 at 2:08 PM Igal Sapir wrote: > > > To use the new update, you can now download all of the dependencies using > the new "download-deps" target using Java 8+: > > $ export JAVA_HOME=/path-to-jdk8 > $ ant download-deps > > T

Re: Git migration read for testing

2019-03-02 Thread Igal Sapir
Using an SSH remote URL has resolved the issue for me. Thank you. On Sat, Mar 2, 2019 at 1:35 PM Igal Sapir wrote: > On Wed, Feb 27, 2019 at 2:09 AM Mark Thomas wrote: > >> On 27/02/2019 09:44, Rémy Maucherat wrote: >> > On Tue, Feb 26, 2019 at 1:33 PM Mark Thomas

Re: Git migration read for testing

2019-03-02 Thread Igal Sapir
On Wed, Feb 27, 2019 at 2:09 AM Mark Thomas wrote: > On 27/02/2019 09:44, Rémy Maucherat wrote: > > On Tue, Feb 26, 2019 at 1:33 PM Mark Thomas wrote: > > > >> All, > >> > >> https://github.com/apache/tomcat > > > > Trying my test commit, I can't push to the github repo. I probably missed > >

Re: Git migration read for testing

2019-02-26 Thread Igal Sapir
Konstantin, On Tue, Feb 26, 2019 at 4:23 PM Konstantin Kolinko wrote: > вт, 26 февр. 2019 г. в 21:24, Igal Sapir : > > > > Mark, > > > > On Tue, Feb 26, 2019 at 4:33 AM Mark Thomas wrote: > > > > > > > > branches > > > - master (9

Re: Git migration read for testing

2019-02-26 Thread Igal Sapir
On Tue, Feb 26, 2019 at 11:28 AM Mark Thomas wrote: > On 26/02/2019 18:23, Igal Sapir wrote: > > Mark, > > > > On Tue, Feb 26, 2019 at 4:33 AM Mark Thomas wrote: > > > >> All, > >> > >> https://github.com/apache/tomcat > >

Re: Git migration read for testing

2019-02-26 Thread Igal Sapir
Mark, On Tue, Feb 26, 2019 at 4:33 AM Mark Thomas wrote: > All, > > https://github.com/apache/tomcat > > is now ready for testing. > > It should contain: > branches > - master (9.0.x) > - 8.5.x > - 7.0.x > What are the plans for the tomcat-site? I am working on the new site design and will

Re: Git migration read for testing

2019-02-26 Thread Igal Sapir
On Tue, Feb 26, 2019 at 6:45 AM Mark Thomas wrote: > On 26/02/2019 13:54, Rémy Maucherat wrote: > > On Tue, Feb 26, 2019 at 1:33 PM Mark Thomas wrote: > > > >> All, > >> > >> https://github.com/apache/tomcat > >> > >> is now ready for testing. > >> > > > > That looks quite good :) > +1. Looks

Re: [VOTE] Migrate to git

2019-02-21 Thread Igal Sapir
On 2/21/2019 8:13 AM, Mark Thomas wrote: This is a VOTE to migrate the primary source code repository for Apache Tomcat 9.0.x, 8.5.x and 7.0.x from svn to git. The migration will be performed as per: https://cwiki.apache.org/confluence/display/TOMCAT/Git+migration with the following changes: -

Re: Git migration: new branch/tag naming scheme

2019-02-20 Thread Igal Sapir
Mark, On 2/20/2019 8:44 AM, Mark Thomas wrote: On 20/02/2019 16:14, Igal Sapir wrote: Michael, On Mon, Feb 18, 2019 at 11:53 AM Michael Osipov wrote: Am 2019-02-18 um 15:19 schrieb Igal Sapir: I actually prefer "tc8.5" and "tc7.0" for the branches (over "8.5.

Re: Git migration: new branch/tag naming scheme

2019-02-20 Thread Igal Sapir
Michael, On Mon, Feb 18, 2019 at 11:53 AM Michael Osipov wrote: > Am 2019-02-18 um 15:19 schrieb Igal Sapir: > > > > > > I actually prefer "tc8.5" and "tc7.0" for the branches (over "8.5.x" and > > "7.0.x"). If tags

Re: Git migration: new branch/tag naming scheme

2019-02-18 Thread Igal Sapir
On Mon, Feb 18, 2019 at 2:03 AM Mark Thomas wrote: > On 18/02/2019 09:13, Rémy Maucherat wrote: > > On Sat, Feb 16, 2019 at 4:09 PM Michael Osipov > wrote: > > > >> Folks, > >> > >> given that we are currently in the process of migrating to Git I'd like > >> to propose a more readible and with

Re: Git migration - Timing

2019-02-17 Thread Igal Sapir
On Mon, Feb 11, 2019 at 6:51 AM Mark Thomas wrote: > All, > > I'd like to propose that we make the move from svn to git for Tomcat > 7.0.x, 8.5.x and 9.0.x as soon as the next 7.0.x release is complete. > This is very exciting. I have been using Git for some time now, and only started using

Re: Git migration: new branch/tag naming scheme

2019-02-17 Thread Igal Sapir
Michael, On Sat, Feb 16, 2019 at 7:09 AM Michael Osipov wrote: > > > There are bascially two approaches I'd like to discuss: > > Approch 1: It will reuse the branch name of the current major version, > excluding master. Thus, we will have the following prefixes: tomcat90-, > tomcat85-, and

Re: [VOTE] Release Apache Tomcat 7.0.93

2019-02-17 Thread Igal Sapir
On Sat, Feb 16, 2019 at 9:41 AM Violeta Georgieva wrote: > The proposed Apache Tomcat 7.0.93 release is now available for voting. > > It can be obtained from: > https://dist.apache.org/repos/dist/dev/tomcat/tomcat-7/v7.0.93/ > The Maven staging repo is: >

Re: [VOTE] Release Apache Tomcat 7.0.93

2019-02-16 Thread Igal Sapir
Hi Rainer, On Sat, Feb 16, 2019 at 2:42 PM Rainer Jung wrote: > Hi Igal, > > Am 16.02.2019 um 22:10 schrieb Igal Sapir: > > Violeta, > > > > On Sat, Feb 16, 2019 at 9:41 AM Violeta Georgieva > > wrote: > > > >> The proposed Apache T

  1   2   >