[Bug 66210] Some unit tests are failing on a non-English PC
https://bz.apache.org/bugzilla/show_bug.cgi?id=66210 Han Li changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 66210] Some unit tests are failing on a non-English PC
https://bz.apache.org/bugzilla/show_bug.cgi?id=66210 --- Comment #6 from Han Li --- PR: https://github.com/apache/tomcat/pull/542 -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 66210] Some unit tests are failing on a non-English PC
https://bz.apache.org/bugzilla/show_bug.cgi?id=66210 --- Comment #5 from Mark Thomas --- Sounds great. Thanks. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 66210] Some unit tests are failing on a non-English PC
https://bz.apache.org/bugzilla/show_bug.cgi?id=66210 --- Comment #4 from Han Li --- (In reply to Mark Thomas from comment #3) > Option 2 is sufficient to test the functionality primarily being tested > whereas option 3 (sort of) tests some of the i18n as well. Agreed! I also think that option 3 is the best solution. > I'm leaning towards option 3 as it doesn't look too challenging to implement > for > the small number of test cases where this is an issue. It's not too difficult to implement, and i found that the only trouble is that we may need to process the parameters in the text via regular expressions (we may not get the parameters, e.g. connectionId). So i will refix the problematic unit tests (include previous PR) according to option 3, is that OK? Han -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 66210] Some unit tests are failing on a non-English PC
https://bz.apache.org/bugzilla/show_bug.cgi?id=66210 --- Comment #3 from Mark Thomas --- I think we have a number of options here: 1. (Similar to my previous 'fixes') reduce the text tested to that which doesn't change depending on locale. 2. Force the unit tests to run under en-US. 3. Use StringManager to retrieve the expected txt in the current locale and then compare the actual output to the locale specific expected text. My concern with 1 is that sometimes we may skip testing parts of the output that are relevant and miss bugs as a result. Option 2 is sufficient to test the functionality primarily being tested whereas option 3 (sort of) tests some of the i18n as well. I'm leaning towards option 3 as it doesn't look too challenging to implement for the small number of test cases where this is an issue. We do need to make sure we distinguish between the system locale and the locale we expected to be used for the response. Thoughts? -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 66210] Some unit tests are failing on a non-English PC
https://bz.apache.org/bugzilla/show_bug.cgi?id=66210 --- Comment #2 from HanLi --- (In reply to HanLi from comment #0) > BUT `org.apache.coyote.http2.TestHttp2Limits#testSettingsOverheadLimits`,I > don't know know how to fix the problem of it. Aha! I found that Mark had solved a similar problem before, so I referenced his implementation. ;) -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 66210] Some unit tests are failing on a non-English PC
https://bz.apache.org/bugzilla/show_bug.cgi?id=66210 HanLi changed: What|Removed |Added Summary|TestAbstractAjpProcessor |Some unit tests are failing |stFlowControl tests are |on a non-English PC |failing on a non-English PC | -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
