Re: Responsive Website for tomcat.apache.org

[Konstantin Kolinko]

2018-02-06 21:58 GMT+03:00 Igal @ Lucee.org :
>
> Also, can anyone confirm if they can still see the menu in Print? And if so,
> on what platform/browser?  I can not reproduce that.

Yes, I see the menu. Both in Firefox and in Chrome, latest. (58.0, 64.0)

You need to have wide paper: set paper orientation to Landscape
(horizontal).  Select paper size "A3" in Chrome.


Best regards,
Konstantin Kolinko

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: Responsive Website for tomcat.apache.org

[Igal @ Lucee.org]

Violeta,

On 1/26/2018 9:57 AM, Violeta Georgieva wrote:

I still see odd "OK" button on Chrome and Safari, only Firefox is ok.
Regards,
Violeta

- MacOS High Sierra
-
https://github.com/violetagg/tomcat-website-screenshots/tree/master/r1822283
- no cache
- the version is provided with every screenshot


This patch should fix the issue on MacOS:
https://github.com/isapir/tomcat-site/commit/286454b

Also, can anyone confirm if they can still see the menu in Print? And if 
so, on what platform/browser?  I can not reproduce that.


Igal Sapir
Lucee Core Developer
Lucee.org 

Re: Responsive Website for tomcat.apache.org

[Violeta Georgieva]

Hi,

2018-01-26 19:07 GMT+02:00 Igal @ Lucee.org :
>
> On 1/26/2018 5:16 AM, Violeta Georgieva wrote:
>>
>> 2018-01-26 14:40 GMT+02:00 Konstantin Kolinko :
>>>
>>> It looks OK now, after I regenerated the docs - r1822283 .
>
> Right.  I do not patch the generated files, only the source ones, so docs
must be regenerated after each patch.
>
>> I still see odd "OK" button on Chrome and Safari, only Firefox is ok.
>> Regards,
>> Violeta
>
> What OS are you running?  Can you please provide the full versions of the
browsers?  Also, please ensure that
> https://tomcat.apache.org/res/css/tomcat.css is not cached.

- MacOS High Sierra
-
https://github.com/violetagg/tomcat-website-screenshots/tree/master/r1822283
- no cache
- the version is provided with every screenshot

Regards,
Violeta

>
>> 2018-01-26 14:40 GMT+02:00 Konstantin Kolinko :
>>>
>>> Print view is yet to be fixed.
>
> I provided the patch for the more urgent things since the site is live,
so I did not cover everything in that patch.
>
> The Print looked fine on Chrome ( see previous printout at
https://github.com/isapir/tomcat-site/releases/download/0.1/Apache.Tomcat.-.Welcome.pdf
), but I checked now on Firefox and I see what you mean.  Not sure why that
happens but I'll fix it.
>
> Best,
>
>
> Igal
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>

Re: Responsive Website for tomcat.apache.org

[Igal @ Lucee.org]

On 1/26/2018 5:16 AM, Violeta Georgieva wrote:

2018-01-26 14:40 GMT+02:00 Konstantin Kolinko :

It looks OK now, after I regenerated the docs - r1822283 .
Right.  I do not patch the generated files, only the source ones, so 
docs must be regenerated after each patch.



I still see odd "OK" button on Chrome and Safari, only Firefox is ok.
Regards,
Violeta
What OS are you running?  Can you please provide the full versions of 
the browsers?  Also, please ensure that

https://tomcat.apache.org/res/css/tomcat.css is not cached.


2018-01-26 14:40 GMT+02:00 Konstantin Kolinko :

Print view is yet to be fixed.
I provided the patch for the more urgent things since the site is live, 
so I did not cover everything in that patch.


The Print looked fine on Chrome ( see previous printout at 
https://github.com/isapir/tomcat-site/releases/download/0.1/Apache.Tomcat.-.Welcome.pdf 
), but I checked now on Firefox and I see what you mean.  Not sure why 
that happens but I'll fix it.


Best,


Igal

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: Responsive Website for tomcat.apache.org

[Violeta Georgieva]

2018-01-26 14:40 GMT+02:00 Konstantin Kolinko :
>
> 2018-01-26 13:04 GMT+03:00 Violeta Georgieva :
> > Hi,
> >
> > 2018-01-26 7:14 GMT+02:00 Igal Sapir :
> >>
> >> Please see patch at
https://github.com/isapir/tomcat-site/commit/5e4d642
> >> which adjusts the search box alignment and adds a keyboard toggle with
the
> >> Enter key when the hamburger menu icon has focus.
> >
> > Here is what I see after applying the patch to the website:
> >
https://github.com/violetagg/tomcat-website-screenshots/tree/master/r1822263
> >
> > Regards,
> > Violeta
>
> It looks OK now, after I regenerated the docs - r1822283 .

I still see odd "OK" button on Chrome and Safari, only Firefox is ok.
Regards,
Violeta

> Print view is yet to be fixed.
>
>
> Best regards,
> Konstantin Kolinko
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>

Re: Responsive Website for tomcat.apache.org

[Konstantin Kolinko]

2018-01-26 13:04 GMT+03:00 Violeta Georgieva :
> Hi,
>
> 2018-01-26 7:14 GMT+02:00 Igal Sapir :
>>
>> Please see patch at https://github.com/isapir/tomcat-site/commit/5e4d642
>> which adjusts the search box alignment and adds a keyboard toggle with the
>> Enter key when the hamburger menu icon has focus.
>
> Here is what I see after applying the patch to the website:
> https://github.com/violetagg/tomcat-website-screenshots/tree/master/r1822263
>
> Regards,
> Violeta

It looks OK now, after I regenerated the docs - r1822283 .

Print view is yet to be fixed.


Best regards,
Konstantin Kolinko

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: Responsive Website for tomcat.apache.org

[Violeta Georgieva]

Hi,

2018-01-26 7:14 GMT+02:00 Igal Sapir :
>
> Please see patch at https://github.com/isapir/tomcat-site/commit/5e4d642
> which adjusts the search box alignment and adds a keyboard toggle with the
> Enter key when the hamburger menu icon has focus.

Here is what I see after applying the patch to the website:
https://github.com/violetagg/tomcat-website-screenshots/tree/master/r1822263

Regards,
Violeta

> Best,
>
>
> Igal
>
> On Thu, Jan 25, 2018 at 1:34 PM, Igal @ Lucee.org  wrote:
>
> > On 1/25/2018 1:04 PM, Konstantin Kolinko wrote:
> >
> >> 2018-01-25 20:06 GMT+03:00 Igal @ Lucee.org :
> >>
> >>> Thank you for sharing your screenshots.  I am not sure why that
happened
> >>> but
> >>> I will fix it.
> >>>
> >>> The first thing that comes to mind is a cached CSS file, so I will
rename
> >>> the file to make sure that that's not a factor.  It's a bit
challenging
> >>> that
> >>> I can't reproduce it on my system, but I will check on my Fedora
laptop
> >>> too.
> >>>
> >> That Firefox is run with a separate profile that I use for testing -
> >> it has caching disabled.
> >>
> >> Comparing eu/us mirrors, both are the same,
> >> http://tomcat.eu.apache.org/
> >> http://tomcat.us.apache.org/
> >>
> >> What happens when you zoom out?
> >>
> >> Looking for active css rules on the input element,
> >>
> >> .searchbox input[type="search"], .searchbox button {
> >>  height: 25px;
> >> }
> >>
> >> Why a "type" selector is here? Can it be more simple?
> >> It can be just #query, as this input has an id.
> >>
> > Styling by ID instead of a class has other implications, primarily
> > specificity [1], which makes projects styling harder to maintain.  I am
> > unaware of any browser that has issue with that selector.  If there is
then
> > I can modify it.
> >
> > Why the height is in pixels, not in font units?
> >>
> >> There is a css rule for height (quoted above),  but there is no rule
> >> for width of this input field.
> >> (When size attribute not specified it should default to size="20", and
> >> width depends on the actual font).
> >>
> > The width here came from the parent container.  I was unaware of any
> > issues as all 4 browsers (Chrome, Firefox, Edge, IE11) that I tested on
> > rendered it correctly in my testing.
> >
> > I will fix the known issues and submit a new patch.
> >
> > Thank you,
> >
> >
> > Igal
> >
> > [1] https://developer.mozilla.org/en-US/docs/Web/CSS/Specificity
> >

Re: Responsive Website for tomcat.apache.org

[Igal Sapir]

Please see patch at https://github.com/isapir/tomcat-site/commit/5e4d642
which adjusts the search box alignment and adds a keyboard toggle with the
Enter key when the hamburger menu icon has focus.

Best,


Igal

On Thu, Jan 25, 2018 at 1:34 PM, Igal @ Lucee.org  wrote:

> On 1/25/2018 1:04 PM, Konstantin Kolinko wrote:
>
>> 2018-01-25 20:06 GMT+03:00 Igal @ Lucee.org :
>>
>>> Thank you for sharing your screenshots.  I am not sure why that happened
>>> but
>>> I will fix it.
>>>
>>> The first thing that comes to mind is a cached CSS file, so I will rename
>>> the file to make sure that that's not a factor.  It's a bit challenging
>>> that
>>> I can't reproduce it on my system, but I will check on my Fedora laptop
>>> too.
>>>
>> That Firefox is run with a separate profile that I use for testing -
>> it has caching disabled.
>>
>> Comparing eu/us mirrors, both are the same,
>> http://tomcat.eu.apache.org/
>> http://tomcat.us.apache.org/
>>
>> What happens when you zoom out?
>>
>> Looking for active css rules on the input element,
>>
>> .searchbox input[type="search"], .searchbox button {
>>  height: 25px;
>> }
>>
>> Why a "type" selector is here? Can it be more simple?
>> It can be just #query, as this input has an id.
>>
> Styling by ID instead of a class has other implications, primarily
> specificity [1], which makes projects styling harder to maintain.  I am
> unaware of any browser that has issue with that selector.  If there is then
> I can modify it.
>
> Why the height is in pixels, not in font units?
>>
>> There is a css rule for height (quoted above),  but there is no rule
>> for width of this input field.
>> (When size attribute not specified it should default to size="20", and
>> width depends on the actual font).
>>
> The width here came from the parent container.  I was unaware of any
> issues as all 4 browsers (Chrome, Firefox, Edge, IE11) that I tested on
> rendered it correctly in my testing.
>
> I will fix the known issues and submit a new patch.
>
> Thank you,
>
>
> Igal
>
> [1] https://developer.mozilla.org/en-US/docs/Web/CSS/Specificity
>

Re: Responsive Website for tomcat.apache.org

[Igal @ Lucee.org]

On 1/25/2018 1:04 PM, Konstantin Kolinko wrote:

2018-01-25 20:06 GMT+03:00 Igal @ Lucee.org :

Thank you for sharing your screenshots.  I am not sure why that happened but
I will fix it.

The first thing that comes to mind is a cached CSS file, so I will rename
the file to make sure that that's not a factor.  It's a bit challenging that
I can't reproduce it on my system, but I will check on my Fedora laptop too.

That Firefox is run with a separate profile that I use for testing -
it has caching disabled.

Comparing eu/us mirrors, both are the same,
http://tomcat.eu.apache.org/
http://tomcat.us.apache.org/

What happens when you zoom out?

Looking for active css rules on the input element,

.searchbox input[type="search"], .searchbox button {
 height: 25px;
}

Why a "type" selector is here? Can it be more simple?
It can be just #query, as this input has an id.
Styling by ID instead of a class has other implications, primarily 
specificity [1], which makes projects styling harder to maintain.  I am 
unaware of any browser that has issue with that selector.  If there is 
then I can modify it.



Why the height is in pixels, not in font units?

There is a css rule for height (quoted above),  but there is no rule
for width of this input field.
(When size attribute not specified it should default to size="20", and
width depends on the actual font).
The width here came from the parent container.  I was unaware of any 
issues as all 4 browsers (Chrome, Firefox, Edge, IE11) that I tested on 
rendered it correctly in my testing.


I will fix the known issues and submit a new patch.

Thank you,


Igal

[1] https://developer.mozilla.org/en-US/docs/Web/CSS/Specificity

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: Responsive Website for tomcat.apache.org

[Konstantin Kolinko]

2018-01-25 20:06 GMT+03:00 Igal @ Lucee.org :
> Violeta, Konstantin,
>
> On 1/25/2018 3:57 AM, Konstantin Kolinko wrote:
>>
>> 2018-01-25 10:00 GMT+03:00 Violeta Georgieva :
>>>
>>> Here is what I see with Chrome, Firefox and Safari
>>> https://github.com/violetagg/tomcat-website-screenshots
>>>
>>> Regards,
>>> Violeta
>>
>> Here are mine screenshots:
>> https://github.com/kkolinko/tomcat_screenshots_2018
>
>
> Thank you for sharing your screenshots.  I am not sure why that happened but
> I will fix it.
>
> The first thing that comes to mind is a cached CSS file, so I will rename
> the file to make sure that that's not a factor.  It's a bit challenging that
> I can't reproduce it on my system, but I will check on my Fedora laptop too.

That Firefox is run with a separate profile that I use for testing -
it has caching disabled.

Comparing eu/us mirrors, both are the same,
http://tomcat.eu.apache.org/
http://tomcat.us.apache.org/

What happens when you zoom out?

Looking for active css rules on the input element,

.searchbox input[type="search"], .searchbox button {
height: 25px;
}

Why a "type" selector is here? Can it be more simple?
It can be just #query, as this input has an id.

Why the height is in pixels, not in font units?

There is a css rule for height (quoted above),  but there is no rule
for width of this input field.
(When size attribute not specified it should default to size="20", and
width depends on the actual font).


Best regards,
Konstantin Kolinko

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: Responsive Website for tomcat.apache.org

[Igal @ Lucee.org]

On 1/25/2018 1:48 AM, Violeta Georgieva wrote:

2018-01-24 21:05 GMT+02:00 Igal @ Lucee.org :

Perhaps a better phrasing would be:

"Note, that Tomcat Documentation is provided on this site and is searchable (see 
links and search box at the left)."
Given that I can not make the change myself and the git patches take an extra 
step, it would be easier for any committer to update it without a patch from me 
at this point.

I did that + added info for all Tomcat version that we support.

Regards,
Violeta


Awesome, thanks!


Igal

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: Responsive Website for tomcat.apache.org

[Igal @ Lucee.org]

Violeta, Konstantin,

On 1/25/2018 3:57 AM, Konstantin Kolinko wrote:

2018-01-25 10:00 GMT+03:00 Violeta Georgieva :

Here is what I see with Chrome, Firefox and Safari
https://github.com/violetagg/tomcat-website-screenshots

Regards,
Violeta

Here are mine screenshots:
https://github.com/kkolinko/tomcat_screenshots_2018


Thank you for sharing your screenshots.  I am not sure why that happened 
but I will fix it.


The first thing that comes to mind is a cached CSS file, so I will 
rename the file to make sure that that's not a factor.  It's a bit 
challenging that I can't reproduce it on my system, but I will check on 
my Fedora laptop too.


Best,

Igal Sapir
Lucee Core Developer
Lucee.org 

Re: Responsive Website for tomcat.apache.org

[Konstantin Kolinko]

2018-01-25 10:00 GMT+03:00 Violeta Georgieva :
> 2018-01-24 21:05 GMT+02:00 Igal @ Lucee.org :
>>
>> Konstantin,
>>
>> I'd be happy to make all the necessary corections.
>>
>> On 1/24/2018 2:44 AM, Konstantin Kolinko wrote:
>>>
>>> 1. The "print view" of the page is important. One should be able to
>>> print it. Especially the documentation.
>>>
>>> I think that menu and search box were not visible when printing, but
>>> one has to check.
>>
>> IIRC the menu and search box were not visible when printing earlier
> either.  The print view is very similar to the way it.  Is there any
> important information that is missing?  See my print out at
> https://github.com/isapir/tomcat-site/releases/download/0.1/Apache.Tomcat.-.Welcome.pdf
>>
>>> 2. The "GO" button on the search box looks off, misaligned.
>>
>> What browser are you using?  See screenshots at
>>
> https://user-images.githubusercontent.com/885907/35351078-b1cece0e-00f4-11e8-9d4d-6305d7ef4545.png
>>
> https://user-images.githubusercontent.com/885907/35351182-fd2f6048-00f4-11e8-8b73-1a005145a85a.png
>
> Here is what I see with Chrome, Firefox and Safari
> https://github.com/violetagg/tomcat-website-screenshots
>
> Regards,
> Violeta

Here are mine screenshots:
https://github.com/kkolinko/tomcat_screenshots_2018

Best regards,
Konstantin Kolinko

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: Responsive Website for tomcat.apache.org

[Violeta Georgieva]

2018-01-24 21:05 GMT+02:00 Igal @ Lucee.org :
>
> Konstantin,
>
> I'd be happy to make all the necessary corections.
>
> On 1/24/2018 2:44 AM, Konstantin Kolinko wrote:
>>
>> 1. The "print view" of the page is important. One should be able to
>> print it. Especially the documentation.
>>
>> I think that menu and search box were not visible when printing, but
>> one has to check.
>
> IIRC the menu and search box were not visible when printing earlier
either.  The print view is very similar to the way it.  Is there any
important information that is missing?  See my print out at
https://github.com/isapir/tomcat-site/releases/download/0.1/Apache.Tomcat.-.Welcome.pdf
>
>> 2. The "GO" button on the search box looks off, misaligned.
>
> What browser are you using?  See screenshots at
>
https://user-images.githubusercontent.com/885907/35351078-b1cece0e-00f4-11e8-9d4d-6305d7ef4545.png
>
https://user-images.githubusercontent.com/885907/35351182-fd2f6048-00f4-11e8-8b73-1a005145a85a.png
>
>> 3. We would have to update some documentation.
>>
>> http://tomcat.apache.org/lists.html#tomcat-users
>> "2. Note, that Tomcat Documentation is provided on this site (see the
>> links at the left) and is searchable (see an input box above)."
>
> Perhaps a better phrasing would be:
>
> "Note, that Tomcat Documentation is provided on this site and is
searchable (see links and search box at the left)."
>
> Given that I can not make the change myself and the git patches take an
extra step, it would be easier for any committer to update it without a
patch from me at this point.

I did that + added info for all Tomcat version that we support.

Regards,
Violeta

>> 4. Accessibility. Is it possible to operate the site without having a
mouse?
>>
>> If menu is closed, I cannot access the hamburger button with keyboard
>> (e.g. pressing tab), cannot open it.  And the text on the main page
>> does not provide other ways to access those parts of the site.
>
> Sure, I will work on that.
>
> Best,
>
>
> Igal Sapir
> Lucee Core Developer
> Lucee.org 
>

Re: Responsive Website for tomcat.apache.org

[Violeta Georgieva]

2018-01-24 21:05 GMT+02:00 Igal @ Lucee.org :
>
> Konstantin,
>
> I'd be happy to make all the necessary corections.
>
> On 1/24/2018 2:44 AM, Konstantin Kolinko wrote:
>>
>> 1. The "print view" of the page is important. One should be able to
>> print it. Especially the documentation.
>>
>> I think that menu and search box were not visible when printing, but
>> one has to check.
>
> IIRC the menu and search box were not visible when printing earlier
either.  The print view is very similar to the way it.  Is there any
important information that is missing?  See my print out at
https://github.com/isapir/tomcat-site/releases/download/0.1/Apache.Tomcat.-.Welcome.pdf
>
>> 2. The "GO" button on the search box looks off, misaligned.
>
> What browser are you using?  See screenshots at
>
https://user-images.githubusercontent.com/885907/35351078-b1cece0e-00f4-11e8-9d4d-6305d7ef4545.png
>
https://user-images.githubusercontent.com/885907/35351182-fd2f6048-00f4-11e8-8b73-1a005145a85a.png

Here is what I see with Chrome, Firefox and Safari
https://github.com/violetagg/tomcat-website-screenshots

Regards,
Violeta


>> 3. We would have to update some documentation.
>>
>> http://tomcat.apache.org/lists.html#tomcat-users
>> "2. Note, that Tomcat Documentation is provided on this site (see the
>> links at the left) and is searchable (see an input box above)."
>
> Perhaps a better phrasing would be:
>
> "Note, that Tomcat Documentation is provided on this site and is
searchable (see links and search box at the left)."
>
> Given that I can not make the change myself and the git patches take an
extra step, it would be easier for any committer to update it without a
patch from me at this point.
>
>> 4. Accessibility. Is it possible to operate the site without having a
mouse?
>>
>> If menu is closed, I cannot access the hamburger button with keyboard
>> (e.g. pressing tab), cannot open it.  And the text on the main page
>> does not provide other ways to access those parts of the site.
>
> Sure, I will work on that.
>
> Best,
>
>
> Igal Sapir
> Lucee Core Developer
> Lucee.org 
>

Re: Responsive Website for tomcat.apache.org

[Igal @ Lucee.org]

Konstantin,

I'd be happy to make all the necessary corections.

On 1/24/2018 2:44 AM, Konstantin Kolinko wrote:

1. The "print view" of the page is important. One should be able to
print it. Especially the documentation.

I think that menu and search box were not visible when printing, but
one has to check.
IIRC the menu and search box were not visible when printing earlier 
either.  The print view is very similar to the way it.  Is there any 
important information that is missing?  See my print out at 
https://github.com/isapir/tomcat-site/releases/download/0.1/Apache.Tomcat.-.Welcome.pdf



2. The "GO" button on the search box looks off, misaligned.

What browser are you using?  See screenshots at
https://user-images.githubusercontent.com/885907/35351078-b1cece0e-00f4-11e8-9d4d-6305d7ef4545.png
https://user-images.githubusercontent.com/885907/35351182-fd2f6048-00f4-11e8-8b73-1a005145a85a.png


3. We would have to update some documentation.

http://tomcat.apache.org/lists.html#tomcat-users
"2. Note, that Tomcat Documentation is provided on this site (see the
links at the left) and is searchable (see an input box above)."

Perhaps a better phrasing would be:

"Note, that Tomcat Documentation is provided on this site and is 
searchable (see links and search box at the left)."


Given that I can not make the change myself and the git patches take an 
extra step, it would be easier for any committer to update it without a 
patch from me at this point.



4. Accessibility. Is it possible to operate the site without having a mouse?

If menu is closed, I cannot access the hamburger button with keyboard
(e.g. pressing tab), cannot open it.  And the text on the main page
does not provide other ways to access those parts of the site.

Sure, I will work on that.

Best,

Igal Sapir
Lucee Core Developer
Lucee.org 

Re: Responsive Website for tomcat.apache.org

[Mark Thomas]

On 24/01/18 18:38, Igal @ Lucee.org wrote:
> Mark,
> 
> On 1/24/2018 1:43 AM, Mark Thomas wrote:
>> Looks great. Patch applied many thanks.
> Thank you.  I appreciate the feedback.
> 
>> I don't suppose you are interested in making similar changes to the
>> documentation web applications (the content gets copied to the web-site)
>> and/or updating the Tomcat 7 docs to match the style of the others?
> I'm happy to contribute to the Tomcat project in any way that I can.
> 
> To clarify, you are referring to these sites, right?
> http://svn.apache.org/repos/asf/tomcat/tc7.0.x/trunk/webapps/docs/
> http://svn.apache.org/repos/asf/tomcat/tc***.x/trunk/webapps/docs/

I am.

Konstantin's feedback on the changes so far is probably a higher
priority though.

Mark

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: Responsive Website for tomcat.apache.org

[Igal @ Lucee.org]

Mark,

On 1/24/2018 1:43 AM, Mark Thomas wrote:

Looks great. Patch applied many thanks.

Thank you.  I appreciate the feedback.


I don't suppose you are interested in making similar changes to the
documentation web applications (the content gets copied to the web-site)
and/or updating the Tomcat 7 docs to match the style of the others?

I'm happy to contribute to the Tomcat project in any way that I can.

To clarify, you are referring to these sites, right?
http://svn.apache.org/repos/asf/tomcat/tc7.0.x/trunk/webapps/docs/
http://svn.apache.org/repos/asf/tomcat/tc***.x/trunk/webapps/docs/

Igal Sapir
Lucee Core Developer
Lucee.org 

Re: Responsive Website for tomcat.apache.org

[Konstantin Kolinko]

2018-01-24 12:43 GMT+03:00 Mark Thomas :
> On 20/01/18 03:04, Igal Sapir wrote:
>> UPDATE:
>>
>> On Fri, Jan 19, 2018 at 4:30 PM, Igal Sapir  wrote:
>>
>>> To clarify,
>>>
>>> I have updated the code for the site.  I have not updated the site itself
>>> since I'm not a committer (my previous statement seemed unclear).
>>>
>>> A committer needs to patch the tomcat-site accordingly.
>>>
>>
>> I made a small change and a second commit.  This changeset includes both
>> commits:
>> https://github.com/isapir/tomcat-site/compare/186404e...4046209
>> and this is the patch file that includes both:
>> https://github.com/isapir/tomcat-site/compare/186404e...4046209.patch
>
> Looks great. Patch applied many thanks.
>
> I don't suppose you are interested in making similar changes to the
> documentation web applications (the content gets copied to the web-site)
> and/or updating the Tomcat 7 docs to match the style of the others?

1. The "print view" of the page is important. One should be able to
print it. Especially the documentation.

I think that menu and search box were not visible when printing, but
one has to check.

2. The "GO" button on the search box looks off, misaligned.

3. We would have to update some documentation.

http://tomcat.apache.org/lists.html#tomcat-users
"2. Note, that Tomcat Documentation is provided on this site (see the
links at the left) and is searchable (see an input box above)."

4. Accessibility. Is it possible to operate the site without having a mouse?

If menu is closed, I cannot access the hamburger button with keyboard
(e.g. pressing tab), cannot open it.  And the text on the main page
does not provide other ways to access those parts of the site.

Best regards,
Konstantin Kolinko

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: Responsive Website for tomcat.apache.org

[Mark Thomas]

On 20/01/18 03:04, Igal Sapir wrote:
> UPDATE:
> 
> On Fri, Jan 19, 2018 at 4:30 PM, Igal Sapir  wrote:
> 
>> To clarify,
>>
>> I have updated the code for the site.  I have not updated the site itself
>> since I'm not a committer (my previous statement seemed unclear).
>>
>> A committer needs to patch the tomcat-site accordingly.
>>
> 
> I made a small change and a second commit.  This changeset includes both
> commits:
> https://github.com/isapir/tomcat-site/compare/186404e...4046209
> and this is the patch file that includes both:
> https://github.com/isapir/tomcat-site/compare/186404e...4046209.patch

Looks great. Patch applied many thanks.

I don't suppose you are interested in making similar changes to the
documentation web applications (the content gets copied to the web-site)
and/or updating the Tomcat 7 docs to match the style of the others?

Mark

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: Responsive Website for tomcat.apache.org

[Igal Sapir]

UPDATE:

On Fri, Jan 19, 2018 at 4:30 PM, Igal Sapir  wrote:

> To clarify,
>
> I have updated the code for the site.  I have not updated the site itself
> since I'm not a committer (my previous statement seemed unclear).
>
> A committer needs to patch the tomcat-site accordingly.
>

I made a small change and a second commit.  This changeset includes both
commits:
https://github.com/isapir/tomcat-site/compare/186404e...4046209
and this is the patch file that includes both:
https://github.com/isapir/tomcat-site/compare/186404e...4046209.patch

Thank you,


Igal

Re: Responsive Website for tomcat.apache.org

[Igal Sapir]

To clarify,

On Fri, Jan 19, 2018 at 4:24 PM, Igal Sapir  wrote:

> I have updated the site and it is now responsive.  On browsers where the
> width is 960px or smaller, the menu on the left is hidden and an hamburger
> toggler button appears on the top left.  Images at the banner are scaled
> down as well.
>
> You can see the changeset at https://github.com/isapir/tomcat-site/commit/
> 2fe680d55e6b81543e2fd1ec6fe0d9584761e96b?w=1
>
>
I have updated the code for the site.  I have not updated the site itself
since I'm not a committer (my previous statement seemed unclear).

A committer needs to patch the tomcat-site accordingly.

Thank you,


Igal

Re: Responsive Website for tomcat.apache.org

[Igal Sapir]

I have updated the site and it is now responsive.  On browsers where the
width is 960px or smaller, the menu on the left is hidden and an hamburger
toggler button appears on the top left.  Images at the banner are scaled
down as well.

You can see the changeset at
https://github.com/isapir/tomcat-site/commit/2fe680d55e6b81543e2fd1ec6fe0d9584761e96b?w=1

If you want to specify a different breakpoint instead of 960px you can
modify it at
https://github.com/isapir/tomcat-site/blob/master/xdocs/res/css/tomcat.css#L343
though I think that 960px is a good breakpoint here.

We should probably change some fonts for smaller screens so that it's
easier to read, but this patch takes care of most of the work.

I ended up coding it without adding Bootstrap and jQuery since it seemed to
add much bloat for the relatively little functionality that we needed here.

Please let me know if you have any questions.

Best,


Igal



On Fri, Jan 19, 2018 at 2:49 AM, Mark Thomas  wrote:

> On 19/01/18 08:34, Mark Thomas wrote:
> > On 18/01/18 22:38, Igal Sapir wrote:
> >> Hello,
> >>
> >> I have moved the static resources to a common directory at /res and I
> would
> >> like to push that as the first step of updating the website since that
> >> clean up makes the website's code easier to maintain.  That will also
> get
> >> the process of updating the website started with a relatively
> non-intrusive
> >> change.
> >>
> >> I have pushed my changes to a git repo and you can see the changeset at
> >> https://github.com/isapir/tomcat-site/commit/
> 1d8dcf5e24cbe48341baac09331490b26c79f4ae?w=1
> >
> > It is going to trigger a bunch of changes in the docs directory as well.
> > Probably easier to apply this patch and regenerate rather than include
> > the generated docs in the patch.
> >
> >> How do we go about propagating these changes to the tomcat-site SVN?
> >
> > Someone with commit rights needs to apply the patch. I'll take a look
> > shortly unless someone beats me to it.
>
> Done. It will be live in the next few seconds. Please ping this thread
> if you notice any breakage (and/or just fix it if you are a committer).
>
> Mark
>
>
> >
> > Mark
> >
> >>
> >> Thanks,
> >>
> >>
> >> Igal
> >>
> >>
> >> On Thu, Jan 18, 2018 at 1:51 PM, Igal @ Lucee.org 
> wrote:
> >>
> >>> On 12/23/2017 1:22 PM, Mark Thomas wrote:
> >>>
>  On 23 December 2017 18:39:33 GMT+00:00, "Igal @ Lucee.org" <
>  i...@lucee.org> wrote:
> 
> > Actually I have a question already.  I see the site's SVN at
> > http://svn.apache.org/repos/asf/tomcat/site/trunk/
> >
> > Is there a git mirror for it or should I grab the sources from SVN?
> >
>  Just svn. That part of the repo isn't mirror to git.
> 
> >>>
> >>> According to http://svn.apache.org/repos/asf/tomcat/site/trunk/README.
> txt
> >>> I need "jk-xdocs native-xdocs", but these directories are empty.  Can I
> >>> remove them in my patches?  I want to clean up some stuff as I go
> through
> >>> it.
> >>>
> >>> I will also update the README.txt accordingly.
> >>>
> >>>
> >>> Igal
> >>>
> >>>
> >>
> >
> >
> > -
> > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> > For additional commands, e-mail: dev-h...@tomcat.apache.org
> >
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>

Re: Responsive Website for tomcat.apache.org

[Mark Thomas]

On 19/01/18 08:34, Mark Thomas wrote:
> On 18/01/18 22:38, Igal Sapir wrote:
>> Hello,
>>
>> I have moved the static resources to a common directory at /res and I would
>> like to push that as the first step of updating the website since that
>> clean up makes the website's code easier to maintain.  That will also get
>> the process of updating the website started with a relatively non-intrusive
>> change.
>>
>> I have pushed my changes to a git repo and you can see the changeset at
>> https://github.com/isapir/tomcat-site/commit/1d8dcf5e24cbe48341baac09331490b26c79f4ae?w=1
> 
> It is going to trigger a bunch of changes in the docs directory as well.
> Probably easier to apply this patch and regenerate rather than include
> the generated docs in the patch.
> 
>> How do we go about propagating these changes to the tomcat-site SVN?
> 
> Someone with commit rights needs to apply the patch. I'll take a look
> shortly unless someone beats me to it.

Done. It will be live in the next few seconds. Please ping this thread
if you notice any breakage (and/or just fix it if you are a committer).

Mark


> 
> Mark
> 
>>
>> Thanks,
>>
>>
>> Igal
>>
>>
>> On Thu, Jan 18, 2018 at 1:51 PM, Igal @ Lucee.org  wrote:
>>
>>> On 12/23/2017 1:22 PM, Mark Thomas wrote:
>>>
 On 23 December 2017 18:39:33 GMT+00:00, "Igal @ Lucee.org" <
 i...@lucee.org> wrote:

> Actually I have a question already.  I see the site's SVN at
> http://svn.apache.org/repos/asf/tomcat/site/trunk/
>
> Is there a git mirror for it or should I grab the sources from SVN?
>
 Just svn. That part of the repo isn't mirror to git.

>>>
>>> According to http://svn.apache.org/repos/asf/tomcat/site/trunk/README.txt
>>> I need "jk-xdocs native-xdocs", but these directories are empty.  Can I
>>> remove them in my patches?  I want to clean up some stuff as I go through
>>> it.
>>>
>>> I will also update the README.txt accordingly.
>>>
>>>
>>> Igal
>>>
>>>
>>
> 
> 
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
> 


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: Responsive Website for tomcat.apache.org

[Mark Thomas]

On 18/01/18 22:38, Igal Sapir wrote:
> Hello,
> 
> I have moved the static resources to a common directory at /res and I would
> like to push that as the first step of updating the website since that
> clean up makes the website's code easier to maintain.  That will also get
> the process of updating the website started with a relatively non-intrusive
> change.
> 
> I have pushed my changes to a git repo and you can see the changeset at
> https://github.com/isapir/tomcat-site/commit/1d8dcf5e24cbe48341baac09331490b26c79f4ae?w=1

It is going to trigger a bunch of changes in the docs directory as well.
Probably easier to apply this patch and regenerate rather than include
the generated docs in the patch.

> How do we go about propagating these changes to the tomcat-site SVN?

Someone with commit rights needs to apply the patch. I'll take a look
shortly unless someone beats me to it.

Mark

> 
> Thanks,
> 
> 
> Igal
> 
> 
> On Thu, Jan 18, 2018 at 1:51 PM, Igal @ Lucee.org  wrote:
> 
>> On 12/23/2017 1:22 PM, Mark Thomas wrote:
>>
>>> On 23 December 2017 18:39:33 GMT+00:00, "Igal @ Lucee.org" <
>>> i...@lucee.org> wrote:
>>>
 Actually I have a question already.  I see the site's SVN at
 http://svn.apache.org/repos/asf/tomcat/site/trunk/

 Is there a git mirror for it or should I grab the sources from SVN?

>>> Just svn. That part of the repo isn't mirror to git.
>>>
>>
>> According to http://svn.apache.org/repos/asf/tomcat/site/trunk/README.txt
>> I need "jk-xdocs native-xdocs", but these directories are empty.  Can I
>> remove them in my patches?  I want to clean up some stuff as I go through
>> it.
>>
>> I will also update the README.txt accordingly.
>>
>>
>> Igal
>>
>>
> 


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: Responsive Website for tomcat.apache.org

[Igal Sapir]

Hello,

I have moved the static resources to a common directory at /res and I would
like to push that as the first step of updating the website since that
clean up makes the website's code easier to maintain.  That will also get
the process of updating the website started with a relatively non-intrusive
change.

I have pushed my changes to a git repo and you can see the changeset at
https://github.com/isapir/tomcat-site/commit/1d8dcf5e24cbe48341baac09331490b26c79f4ae?w=1

How do we go about propagating these changes to the tomcat-site SVN?

Thanks,


Igal


On Thu, Jan 18, 2018 at 1:51 PM, Igal @ Lucee.org  wrote:

> On 12/23/2017 1:22 PM, Mark Thomas wrote:
>
>> On 23 December 2017 18:39:33 GMT+00:00, "Igal @ Lucee.org" <
>> i...@lucee.org> wrote:
>>
>>> Actually I have a question already.  I see the site's SVN at
>>> http://svn.apache.org/repos/asf/tomcat/site/trunk/
>>>
>>> Is there a git mirror for it or should I grab the sources from SVN?
>>>
>> Just svn. That part of the repo isn't mirror to git.
>>
>
> According to http://svn.apache.org/repos/asf/tomcat/site/trunk/README.txt
> I need "jk-xdocs native-xdocs", but these directories are empty.  Can I
> remove them in my patches?  I want to clean up some stuff as I go through
> it.
>
> I will also update the README.txt accordingly.
>
>
> Igal
>
>