[GitHub] [tomcat] stokito commented on pull request #337: Bug fix: If-None-Match: 304 response should return a real resource ETag

2020-08-12 Thread GitBox
stokito commented on pull request #337: URL: https://github.com/apache/tomcat/pull/337#issuecomment-672871214 I reviewed and it looks fine and simpler. I just want to note here for history that according RFC 7232 sec 2.3.2 if resource's real etag is weak than strong comparison always

[GitHub] [tomcat] stokito commented on pull request #337: Bug fix: If-None-Match: 304 response should return a real resource ETag

2020-08-12 Thread GitBox
stokito commented on pull request #337: URL: https://github.com/apache/tomcat/pull/337#issuecomment-672785490 I added a commit that extracts common matching logic This is an automated message from the Apache Git Service. To

[GitHub] [tomcat] stokito commented on pull request #337: Bug fix: If-None-Match: 304 response should return a real resource ETag

2020-08-12 Thread GitBox
stokito commented on pull request #337: URL: https://github.com/apache/tomcat/pull/337#issuecomment-672777683 yes, you are right and I wanted to discuss it latter. The PR fixes only one specific problem + small refactoring. The problem that I see is that the new