Re: Back-porting BZ57338 SSO + Cluster improvements

2014-12-31 Thread Mark Thomas
On 24/12/2014 08:18, Keiichi Fujino wrote: > 2014-12-19 21:40 GMT+09:00 Mark Thomas : > >> On 17/12/2014 16:57, Mark Thomas wrote: >>> On 17/12/2014 09:58, Keiichi Fujino wrote: >> [A] I think that the process of updating SSO entry needs to be notify cluster. >>> >>> I'll take a look at

Re: Back-porting BZ57338 SSO + Cluster improvements

2014-12-24 Thread Keiichi Fujino
2014-12-19 21:40 GMT+09:00 Mark Thomas : > On 17/12/2014 16:57, Mark Thomas wrote: > > On 17/12/2014 09:58, Keiichi Fujino wrote: > > >> [A] I think that the process of updating SSO entry needs to be notify > >> cluster. > > > > I'll take a look at this. I didn't see any issues in my simple testin

Re: Back-porting BZ57338 SSO + Cluster improvements

2014-12-19 Thread Mark Thomas
On 17/12/2014 16:57, Mark Thomas wrote: > On 17/12/2014 09:58, Keiichi Fujino wrote: >> [A] I think that the process of updating SSO entry needs to be notify >> cluster. > > I'll take a look at this. I didn't see any issues in my simple testing > but I may well have missed this scenario. My test

Re: Back-porting BZ57338 SSO + Cluster improvements

2014-12-18 Thread Christopher Schultz
Mark, On 12/16/14 5:52 PM, Mark Thomas wrote: > The fix for BZ 57338 (SSO + cluster) ended up making some fairly > invasive changes so that the implementation was sensible. I'd like to > discuss which - if any - of these changes we'd be happy to back-port to > Tomcat 8 and Tomcat 7. I think you s

Re: Back-porting BZ57338 SSO + Cluster improvements

2014-12-17 Thread Mark Thomas
On 17/12/2014 09:58, Keiichi Fujino wrote: > 2014-12-17 7:52 GMT+09:00 Mark Thomas : >> In summary, patches [7] and [8] look to be the ones that need the most >> careful consideration followed by [2]. >> >> Thoughts? >> >> > [1][2][3][4][5][6][9][A] > +1 back-port. > There is no objection here.

Re: Back-porting BZ57338 SSO + Cluster improvements

2014-12-17 Thread Keiichi Fujino
2014-12-17 7:52 GMT+09:00 Mark Thomas : > > The fix for BZ 57338 (SSO + cluster) ended up making some fairly > invasive changes so that the implementation was sensible. I'd like to > discuss which - if any - of these changes we'd be happy to back-port to > Tomcat 8 and Tomcat 7. > > [1] Make Generi

Back-porting BZ57338 SSO + Cluster improvements

2014-12-16 Thread Mark Thomas
The fix for BZ 57338 (SSO + cluster) ended up making some fairly invasive changes so that the implementation was sensible. I'd like to discuss which - if any - of these changes we'd be happy to back-port to Tomcat 8 and Tomcat 7. [1] Make GenericPrincipal Serializable I don't see any harm in back-