Re: Git migration read for testing
Using an SSH remote URL has resolved the issue for me. Thank you. On Sat, Mar 2, 2019 at 1:35 PM Igal Sapir wrote: > On Wed, Feb 27, 2019 at 2:09 AM Mark Thomas wrote: > >> On 27/02/2019 09:44, Rémy Maucherat wrote: >> > On Tue, Feb 26, 2019 at 1:33 PM Mark Thomas wrote: >> > >> >> All, >> >> >> >> https://github.com/apache/tomcat >> > >> > Trying my test commit, I can't push to the github repo. I probably >> missed >> > something obvious. >> >> You need to make sure you have three green ticks here: >> https://gitbox.apache.org/setup/ >> >> If you haven't linked your ASF and GitHub accounts or setup MFA then it >> can take an hour or so after you make those changes for write access to >> be enabled (various systems need to sync in the background). >> > > I have the three green ticks with the message "Write access granted" on > gitbox.apache.org/setup (for a couple of days now), but am still unable > to push a commit. > > My remote is set using https: > $ git remote -v > originhttps://github.com/apache/tomcat (fetch) > originhttps://github.com/apache/tomcat (push) > > I've created a Personal Access Token with admin:org scope and tried > logging in with it and my GitHub username, but still no go. > > Any ideas? Thanks, > > Igal > >
Re: Git migration read for testing
On Wed, Feb 27, 2019 at 2:09 AM Mark Thomas wrote: > On 27/02/2019 09:44, Rémy Maucherat wrote: > > On Tue, Feb 26, 2019 at 1:33 PM Mark Thomas wrote: > > > >> All, > >> > >> https://github.com/apache/tomcat > > > > Trying my test commit, I can't push to the github repo. I probably missed > > something obvious. > > You need to make sure you have three green ticks here: > https://gitbox.apache.org/setup/ > > If you haven't linked your ASF and GitHub accounts or setup MFA then it > can take an hour or so after you make those changes for write access to > be enabled (various systems need to sync in the background). > I have the three green ticks with the message "Write access granted" on gitbox.apache.org/setup (for a couple of days now), but am still unable to push a commit. My remote is set using https: $ git remote -v originhttps://github.com/apache/tomcat (fetch) originhttps://github.com/apache/tomcat (push) I've created a Personal Access Token with admin:org scope and tried logging in with it and my GitHub username, but still no go. Any ideas? Thanks, Igal
Re: Git migration read for testing
Am 2019-03-01 um 21:50 schrieb Mark Thomas: On 01/03/2019 19:54, Mark Thomas wrote: On 01/03/2019 19:00, Coty Sutherland wrote: The email notifications work for when we push commits to the repository, but it looks like we're missing emails when PRs are opened. ACK. I'll talk to infra. Fixed. FYI we have the option to route commits to one location and PRs + comments to another. At the moment, everything goes to dev@ Some projects have separate commits@ and notifications@ lists (and possibly issues@ as well). Personally, I like it all in one place and tend to filter everything into a single folder anyway. But I wanted to mention that the option was there. I'd opt for commits to commits@ and PRs to dev@. For those who'd like see commits will need to subscribe to it. Commits on dev@ produce a lot of traffic not necessarily related to dev discusssions. Michael - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: Git migration read for testing
On 01/03/2019 20:58, Rémy Maucherat wrote: > On Fri, Mar 1, 2019 at 9:50 PM Mark Thomas wrote: > >> On 01/03/2019 19:54, Mark Thomas wrote: >>> On 01/03/2019 19:00, Coty Sutherland wrote: The email notifications work for when we push commits to the repository, but it looks like we're missing emails when PRs are opened. >>> >>> ACK. I'll talk to infra. >> >> Fixed. >> > > Looks like it :) > >> >> FYI we have the option to route commits to one location and PRs + >> comments to another. At the moment, everything goes to dev@ >> >> Some projects have separate commits@ and notifications@ lists (and >> possibly issues@ as well). >> >> Personally, I like it all in one place and tend to filter everything >> into a single folder anyway. But I wanted to mention that the option was >> there. >> > > It is true other projects may have more mailing lists, but I'm not > convinced right now. > > BTW, I made a commit on github one hour ago, but it still isn't on gitbox. > Isn't this bad ? Infra have been dealing with some abusive traffic to Gitbox. It got behind. I think I can manually sync it. Let me look. Yes, I can. Done. Hmm. I might need to manually trigger the commit mails... Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: Git migration read for testing
On Fri, Mar 1, 2019 at 9:50 PM Mark Thomas wrote: > On 01/03/2019 19:54, Mark Thomas wrote: > > On 01/03/2019 19:00, Coty Sutherland wrote: > >> The email notifications work for when we push commits to the repository, > >> but it looks like we're missing emails when PRs are opened. > > > > ACK. I'll talk to infra. > > Fixed. > Looks like it :) > > FYI we have the option to route commits to one location and PRs + > comments to another. At the moment, everything goes to dev@ > > Some projects have separate commits@ and notifications@ lists (and > possibly issues@ as well). > > Personally, I like it all in one place and tend to filter everything > into a single folder anyway. But I wanted to mention that the option was > there. > It is true other projects may have more mailing lists, but I'm not convinced right now. BTW, I made a commit on github one hour ago, but it still isn't on gitbox. Isn't this bad ? Rémy
Re: Git migration read for testing
On 01/03/2019 19:54, Mark Thomas wrote: > On 01/03/2019 19:00, Coty Sutherland wrote: >> The email notifications work for when we push commits to the repository, >> but it looks like we're missing emails when PRs are opened. > > ACK. I'll talk to infra. Fixed. FYI we have the option to route commits to one location and PRs + comments to another. At the moment, everything goes to dev@ Some projects have separate commits@ and notifications@ lists (and possibly issues@ as well). Personally, I like it all in one place and tend to filter everything into a single folder anyway. But I wanted to mention that the option was there. Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: Git migration read for testing
On 01/03/2019 19:00, Coty Sutherland wrote: > The email notifications work for when we push commits to the repository, > but it looks like we're missing emails when PRs are opened. ACK. I'll talk to infra. Mark > > On Wed, Feb 27, 2019 at 9:03 AM Rémy Maucherat wrote: > >> On Wed, Feb 27, 2019 at 11:09 AM Mark Thomas wrote: >> >>> On 27/02/2019 09:44, Rémy Maucherat wrote: On Tue, Feb 26, 2019 at 1:33 PM Mark Thomas wrote: > All, > > https://github.com/apache/tomcat Trying my test commit, I can't push to the github repo. I probably >> missed something obvious. >>> >>> You need to make sure you have three green ticks here: >>> https://gitbox.apache.org/setup/ >>> >>> If you haven't linked your ASF and GitHub accounts or setup MFA then it >>> can take an hour or so after you make those changes for write access to >>> be enabled (various systems need to sync in the background). >>> >> >> I had forgotten about this as the Tomcat repo commit info was already >> linked to my account. Thanks for the help ! >> >> Rémy >> >> >>> >>> Mark >>> >>> Rémy > > > is now ready for testing. > > It should contain: > branches > - master (9.0.x) > - 8.5.x > - 7.0.x > > Tags: > - one for each 7.0.x, 8.5.x and 9.0.x release > > Tags have all been renamed to follow a a.b.c-MODIFIERn format for > version number where modifier is RC or M. > > The repository is probably read/write for all committers now but >> please > refrain from making any changes until we confirm that all is well. > > If you have some time available now, please test this new repository >> and > report and questions or concerns to this thread. > > Assuming no issues are discovered, I'd like to formally move over to >> git > later today. > > Mark > > - > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > For additional commands, e-mail: dev-h...@tomcat.apache.org > > >>> >>> >>> - >>> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org >>> For additional commands, e-mail: dev-h...@tomcat.apache.org >>> >>> >> > - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: Git migration read for testing
The email notifications work for when we push commits to the repository, but it looks like we're missing emails when PRs are opened. On Wed, Feb 27, 2019 at 9:03 AM Rémy Maucherat wrote: > On Wed, Feb 27, 2019 at 11:09 AM Mark Thomas wrote: > > > On 27/02/2019 09:44, Rémy Maucherat wrote: > > > On Tue, Feb 26, 2019 at 1:33 PM Mark Thomas wrote: > > > > > >> All, > > >> > > >> https://github.com/apache/tomcat > > > > > > > > > Trying my test commit, I can't push to the github repo. I probably > missed > > > something obvious. > > > > You need to make sure you have three green ticks here: > > https://gitbox.apache.org/setup/ > > > > If you haven't linked your ASF and GitHub accounts or setup MFA then it > > can take an hour or so after you make those changes for write access to > > be enabled (various systems need to sync in the background). > > > > I had forgotten about this as the Tomcat repo commit info was already > linked to my account. Thanks for the help ! > > Rémy > > > > > > Mark > > > > > > > > > > Rémy > > > > > > > > >> > > >> > > >> is now ready for testing. > > >> > > >> It should contain: > > >> branches > > >> - master (9.0.x) > > >> - 8.5.x > > >> - 7.0.x > > >> > > >> Tags: > > >> - one for each 7.0.x, 8.5.x and 9.0.x release > > >> > > >> Tags have all been renamed to follow a a.b.c-MODIFIERn format for > > >> version number where modifier is RC or M. > > >> > > >> The repository is probably read/write for all committers now but > please > > >> refrain from making any changes until we confirm that all is well. > > >> > > >> If you have some time available now, please test this new repository > and > > >> report and questions or concerns to this thread. > > >> > > >> Assuming no issues are discovered, I'd like to formally move over to > git > > >> later today. > > >> > > >> Mark > > >> > > >> - > > >> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > > >> For additional commands, e-mail: dev-h...@tomcat.apache.org > > >> > > >> > > > > > > > > > - > > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > > For additional commands, e-mail: dev-h...@tomcat.apache.org > > > > >
Re: Git migration read for testing
On Wed, Feb 27, 2019 at 11:09 AM Mark Thomas wrote: > On 27/02/2019 09:44, Rémy Maucherat wrote: > > On Tue, Feb 26, 2019 at 1:33 PM Mark Thomas wrote: > > > >> All, > >> > >> https://github.com/apache/tomcat > > > > > > Trying my test commit, I can't push to the github repo. I probably missed > > something obvious. > > You need to make sure you have three green ticks here: > https://gitbox.apache.org/setup/ > > If you haven't linked your ASF and GitHub accounts or setup MFA then it > can take an hour or so after you make those changes for write access to > be enabled (various systems need to sync in the background). > I had forgotten about this as the Tomcat repo commit info was already linked to my account. Thanks for the help ! Rémy > > Mark > > > > > > Rémy > > > > > >> > >> > >> is now ready for testing. > >> > >> It should contain: > >> branches > >> - master (9.0.x) > >> - 8.5.x > >> - 7.0.x > >> > >> Tags: > >> - one for each 7.0.x, 8.5.x and 9.0.x release > >> > >> Tags have all been renamed to follow a a.b.c-MODIFIERn format for > >> version number where modifier is RC or M. > >> > >> The repository is probably read/write for all committers now but please > >> refrain from making any changes until we confirm that all is well. > >> > >> If you have some time available now, please test this new repository and > >> report and questions or concerns to this thread. > >> > >> Assuming no issues are discovered, I'd like to formally move over to git > >> later today. > >> > >> Mark > >> > >> - > >> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > >> For additional commands, e-mail: dev-h...@tomcat.apache.org > >> > >> > > > > > - > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > For additional commands, e-mail: dev-h...@tomcat.apache.org > >
Re: Git migration read for testing
On 27/02/2019 09:44, Rémy Maucherat wrote: > On Tue, Feb 26, 2019 at 1:33 PM Mark Thomas wrote: > >> All, >> >> https://github.com/apache/tomcat > > > Trying my test commit, I can't push to the github repo. I probably missed > something obvious. You need to make sure you have three green ticks here: https://gitbox.apache.org/setup/ If you haven't linked your ASF and GitHub accounts or setup MFA then it can take an hour or so after you make those changes for write access to be enabled (various systems need to sync in the background). Mark > > Rémy > > >> >> >> is now ready for testing. >> >> It should contain: >> branches >> - master (9.0.x) >> - 8.5.x >> - 7.0.x >> >> Tags: >> - one for each 7.0.x, 8.5.x and 9.0.x release >> >> Tags have all been renamed to follow a a.b.c-MODIFIERn format for >> version number where modifier is RC or M. >> >> The repository is probably read/write for all committers now but please >> refrain from making any changes until we confirm that all is well. >> >> If you have some time available now, please test this new repository and >> report and questions or concerns to this thread. >> >> Assuming no issues are discovered, I'd like to formally move over to git >> later today. >> >> Mark >> >> - >> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org >> For additional commands, e-mail: dev-h...@tomcat.apache.org >> >> > - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: Git migration read for testing
On Tue, Feb 26, 2019 at 1:33 PM Mark Thomas wrote: > All, > > https://github.com/apache/tomcat Trying my test commit, I can't push to the github repo. I probably missed something obvious. Rémy > > > is now ready for testing. > > It should contain: > branches > - master (9.0.x) > - 8.5.x > - 7.0.x > > Tags: > - one for each 7.0.x, 8.5.x and 9.0.x release > > Tags have all been renamed to follow a a.b.c-MODIFIERn format for > version number where modifier is RC or M. > > The repository is probably read/write for all committers now but please > refrain from making any changes until we confirm that all is well. > > If you have some time available now, please test this new repository and > report and questions or concerns to this thread. > > Assuming no issues are discovered, I'd like to formally move over to git > later today. > > Mark > > - > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > For additional commands, e-mail: dev-h...@tomcat.apache.org > >
Re: Git migration read for testing
Konstantin, On Tue, Feb 26, 2019 at 4:23 PM Konstantin Kolinko wrote: > вт, 26 февр. 2019 г. в 21:24, Igal Sapir : > > > > Mark, > > > > On Tue, Feb 26, 2019 at 4:33 AM Mark Thomas wrote: > > > > > > > > branches > > > - master (9.0.x) > > > - 8.5.x > > > - 7.0.x > > > > What are the plans for the tomcat-site? [...] > > Igal, > > If you look at a *-fulldocs.tar.gz file with full documentation that > accompanies each Tomcat release, > you'll find that e.g. for Tomcat 9.0.16 its unpacked size is 60 Mb, > with 2385 files in 165 directories. > > The full tomcat.apache.org site contains such documentation for every > major version of Tomcat. See all directories listed ar > http://svn.apache.org/viewvc/tomcat/site/trunk/docs/ > > With Subversion it is easy to work with that, using "sparse checkout" > feature. The relevant commands are documented in site's README file. > Git is much more efficient than Subversion, as it only keeps a single copy of files that were unchanged. The new github repo takes on my drive 133.2 MiB for the 3 branches combined with the master branch checked out (125.6 MiB when the 7.0.x branch is checked out as less files get uncompressed). > > With some googling, it seems that Git also has some sparse checkout > support [1], but I am not sure whether it is as easy to use as this > feature in Subversion. > > (How does one manage the checkout layout? Is there a better way to > update the ".git/info/sparse-checkout" file rather than having to edit > it by manually? In Subversion the checkout depth can be changed easily > with "svn update --set-depth" command). > In Git you don't have to get a partial depth due to the efficiency mentioned above - you get the whole depth at no additional cost. If you have for example a file that hasn't been changed in any commit from 7.0.1 to 9.0.16 then Git keeps only one copy of it across all branches throughout the repository. > If people really want to use git for the site, I think the first step > it to create a Git mirror for the current site repository and to see > whether it is usable. > I have created a local git repo from the site branch. From what I see the most disk space goes for the JavaDoc sections, and some on the docs directory. These are generated files so they can be added to .gitignore and not tracked by Git. > At this point, I think that Subversion is better tool for managing the > site. I do not expect much from Git. > I agree with you that ideally the site should not be mixed with the source code. The tomcat-site should have its own repository. A GitHub search shows that the apache account has 94 repositories with `site` in the name [1]. So for example there are repos like `kafka-site` and `spark-website` in addition to the `kafka` and `spark` source code repositories. All we have to do is create a separate repo for the site, either `tomcat-website` or `tomcat-site`. I believe that INFRA takes care of that. Best, Igal [1] https://github.com/search?q=org%3Aapache+site&type=Repositories
Re: Git migration read for testing
вт, 26 февр. 2019 г. в 21:24, Igal Sapir : > > Mark, > > On Tue, Feb 26, 2019 at 4:33 AM Mark Thomas wrote: > > > All, > > > > https://github.com/apache/tomcat > > > > is now ready for testing. > > > > It should contain: > > branches > > - master (9.0.x) > > - 8.5.x > > - 7.0.x > > > > What are the plans for the tomcat-site? [...] Igal, If you look at a *-fulldocs.tar.gz file with full documentation that accompanies each Tomcat release, you'll find that e.g. for Tomcat 9.0.16 its unpacked size is 60 Mb, with 2385 files in 165 directories. The full tomcat.apache.org site contains such documentation for every major version of Tomcat. See all directories listed ar http://svn.apache.org/viewvc/tomcat/site/trunk/docs/ With Subversion it is easy to work with that, using "sparse checkout" feature. The relevant commands are documented in site's README file. With some googling, it seems that Git also has some sparse checkout support [1], but I am not sure whether it is as easy to use as this feature in Subversion. (How does one manage the checkout layout? Is there a better way to update the ".git/info/sparse-checkout" file rather than having to edit it by manually? In Subversion the checkout depth can be changed easily with "svn update --set-depth" command). If people really want to use git for the site, I think the first step it to create a Git mirror for the current site repository and to see whether it is usable. At this point, I think that Subversion is better tool for managing the site. I do not expect much from Git. [1] https://briancoyner.github.io/2013/06/05/git-sparse-checkout.html Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: Git migration read for testing
On Tue, Feb 26, 2019 at 11:28 AM Mark Thomas wrote: > On 26/02/2019 18:23, Igal Sapir wrote: > > Mark, > > > > On Tue, Feb 26, 2019 at 4:33 AM Mark Thomas wrote: > > > >> All, > >> > >> https://github.com/apache/tomcat > >> > >> is now ready for testing. > >> > >> It should contain: > >> branches > >> - master (9.0.x) > >> - 8.5.x > >> - 7.0.x > >> > > > > What are the plans for the tomcat-site? > > Migrate to git-pub-sub from svn-pub-sub at some point. Timing TBD. > > > I am working on the new site > > design and will soon be ready to push the changes. > > > > I will first upload a full working version to a temporary location for > > review. > > Cool. > > > How will the site's source directory be wired to tomcat.apache.org? Do > we > > need to request INFRA to set it up? > > We'll need a branch called asf-site and that needs to contain the site's > content which should consist entirely of static files. How we generate > the content of that branch from (presumably) master is up to us. > > We can set this git repo up whenever we want. We can do it now if it > makes it easier for you. > No rush on my end since I can always push the changes to a repo on my own GitHub account and we can later merge it. I thought that it might be easier for you since you're already working on that and I wanted to make sure that we don't "forget" it, so whenever it works for you is fine by me. Thanks, Igal
Re: Git migration read for testing
On 26/02/2019 18:23, Igal Sapir wrote: > Mark, > > On Tue, Feb 26, 2019 at 4:33 AM Mark Thomas wrote: > >> All, >> >> https://github.com/apache/tomcat >> >> is now ready for testing. >> >> It should contain: >> branches >> - master (9.0.x) >> - 8.5.x >> - 7.0.x >> > > What are the plans for the tomcat-site? Migrate to git-pub-sub from svn-pub-sub at some point. Timing TBD. > I am working on the new site > design and will soon be ready to push the changes. > > I will first upload a full working version to a temporary location for > review. Cool. > How will the site's source directory be wired to tomcat.apache.org? Do we > need to request INFRA to set it up? We'll need a branch called asf-site and that needs to contain the site's content which should consist entirely of static files. How we generate the content of that branch from (presumably) master is up to us. We can set this git repo up whenever we want. We can do it now if it makes it easier for you. Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: Git migration read for testing
Mark, On Tue, Feb 26, 2019 at 4:33 AM Mark Thomas wrote: > All, > > https://github.com/apache/tomcat > > is now ready for testing. > > It should contain: > branches > - master (9.0.x) > - 8.5.x > - 7.0.x > What are the plans for the tomcat-site? I am working on the new site design and will soon be ready to push the changes. I will first upload a full working version to a temporary location for review. How will the site's source directory be wired to tomcat.apache.org? Do we need to request INFRA to set it up? Best, Igal
Re: Git migration read for testing
On Tue, Feb 26, 2019 at 6:45 AM Mark Thomas wrote: > On 26/02/2019 13:54, Rémy Maucherat wrote: > > On Tue, Feb 26, 2019 at 1:33 PM Mark Thomas wrote: > > > >> All, > >> > >> https://github.com/apache/tomcat > >> > >> is now ready for testing. > >> > > > > That looks quite good :) > +1. Looks good to me. > > > > Should we plan to all work with PRs for large changes ? > > That sounds like a better way of doing what we have done in the past > with large proposed patches. > +1 > > I've just discovered that the Eclipse IDE does not support Git > worktrees. I'm not sure how much of a nuisance that is going to turn out > to be. IntelliJ IDEA does support worktrees and JetBrains offer open > source licenses so I've applied for one. I'm not sure the benefit of > worktree support is going to be worth the pain of switching IDEs. I > guess I'll find out... > I find IntelliJ to be much superior to Eclipse. JetBrains does offer license which is very generous of them, but I find that for Java (IDEA, as opposed to some of their other products) even the free, community edition, is more than sufficient and possibly also lighter than the Ultimate edition. Igal
Re: Git migration read for testing
On 26/02/2019 16:20, Mark Thomas wrote: > On 26/02/2019 15:25, Huxing Zhang wrote: >> Hi, >> >> It looks good to me. >> >> I think it is better to add some description and tags in the headline >> of Github, to make it more informative and searchable. >> >> For example: Apache Tomcat® is an open source implementation of the >> Java Servlet, JavaServer Pages, Java Expression Language and Java >> WebSocket technologies. >> >> Also I think the CONTRIBUTING file need to be update, to deprecate the >> usage of svn. >> >> Further search using SVN as keyword in the repo shows more work need >> to be updated. > > Indeed. There are a whole bunch of things that will need to be updated > assuming we decide we are happy with the new repos. > > So far all looks good. I'm just trying to work through with infra why we > saw 2 commit emails. Appears to be a one-off glitch. I'm going to tell infra all is well and they can remove the tomcat85 and tomcat70 mirrors from github. The git repo is now officially read/write and can be used via either of: https://gitbox.apache.org/repos/asf/tomcat.git https://github.com/apache/tomcat I'm going to start updating docs, CI systems etc. As part of those updates, I'll move the svn repos to tomcat/archive Mark > > Mark > > >> >> [1] https://github.com/apache/tomcat/blob/master/CONTRIBUTING.md >> >> On Tue, Feb 26, 2019 at 8:33 PM Mark Thomas wrote: >>> >>> All, >>> >>> https://github.com/apache/tomcat >>> >>> is now ready for testing. >>> >>> It should contain: >>> branches >>> - master (9.0.x) >>> - 8.5.x >>> - 7.0.x >>> >>> Tags: >>> - one for each 7.0.x, 8.5.x and 9.0.x release >>> >>> Tags have all been renamed to follow a a.b.c-MODIFIERn format for >>> version number where modifier is RC or M. >>> >>> The repository is probably read/write for all committers now but please >>> refrain from making any changes until we confirm that all is well. >>> >>> If you have some time available now, please test this new repository and >>> report and questions or concerns to this thread. >>> >>> Assuming no issues are discovered, I'd like to formally move over to git >>> later today. >>> >>> Mark >>> >>> - >>> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org >>> For additional commands, e-mail: dev-h...@tomcat.apache.org >>> >> >> > > > - > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > For additional commands, e-mail: dev-h...@tomcat.apache.org > - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: Git migration read for testing
Am 2019-02-26 um 13:33 schrieb Mark Thomas: All, https://github.com/apache/tomcat is now ready for testing. It should contain: branches - master (9.0.x) - 8.5.x - 7.0.x Tags: - one for each 7.0.x, 8.5.x and 9.0.x release Tags have all been renamed to follow a a.b.c-MODIFIERn format for version number where modifier is RC or M. That looks so sweet and tidy. I cannot clone the repo at the moment, Gitbox seems to be down in EU. Thank you for your effort! Michael - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: Git migration read for testing
On 26/02/2019 15:25, Huxing Zhang wrote: > Hi, > > It looks good to me. > > I think it is better to add some description and tags in the headline > of Github, to make it more informative and searchable. > > For example: Apache Tomcat® is an open source implementation of the > Java Servlet, JavaServer Pages, Java Expression Language and Java > WebSocket technologies. > > Also I think the CONTRIBUTING file need to be update, to deprecate the > usage of svn. > > Further search using SVN as keyword in the repo shows more work need > to be updated. Indeed. There are a whole bunch of things that will need to be updated assuming we decide we are happy with the new repos. So far all looks good. I'm just trying to work through with infra why we saw 2 commit emails. Mark > > [1] https://github.com/apache/tomcat/blob/master/CONTRIBUTING.md > > On Tue, Feb 26, 2019 at 8:33 PM Mark Thomas wrote: >> >> All, >> >> https://github.com/apache/tomcat >> >> is now ready for testing. >> >> It should contain: >> branches >> - master (9.0.x) >> - 8.5.x >> - 7.0.x >> >> Tags: >> - one for each 7.0.x, 8.5.x and 9.0.x release >> >> Tags have all been renamed to follow a a.b.c-MODIFIERn format for >> version number where modifier is RC or M. >> >> The repository is probably read/write for all committers now but please >> refrain from making any changes until we confirm that all is well. >> >> If you have some time available now, please test this new repository and >> report and questions or concerns to this thread. >> >> Assuming no issues are discovered, I'd like to formally move over to git >> later today. >> >> Mark >> >> - >> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org >> For additional commands, e-mail: dev-h...@tomcat.apache.org >> > > - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: Git migration read for testing
Am 2019-02-26 um 14:54 schrieb Rémy Maucherat: On Tue, Feb 26, 2019 at 1:33 PM Mark Thomas wrote: All, https://github.com/apache/tomcat is now ready for testing. It should contain: branches - master (9.0.x) - 8.5.x - 7.0.x Tags: - one for each 7.0.x, 8.5.x and 9.0.x release Tags have all been renamed to follow a a.b.c-MODIFIERn format for version number where modifier is RC or M. The repository is probably read/write for all committers now but please refrain from making any changes until we confirm that all is well. If you have some time available now, please test this new repository and report and questions or concerns to this thread. Assuming no issues are discovered, I'd like to formally move over to git later today. That looks quite good :) Should we plan to all work with PRs for large changes ? I'd love to have this, giving some time for the community to watch over the change...and assigning reviewers to it. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: Git migration read for testing
Hi, It looks good to me. I think it is better to add some description and tags in the headline of Github, to make it more informative and searchable. For example: Apache Tomcat® is an open source implementation of the Java Servlet, JavaServer Pages, Java Expression Language and Java WebSocket technologies. Also I think the CONTRIBUTING file need to be update, to deprecate the usage of svn. Further search using SVN as keyword in the repo shows more work need to be updated. [1] https://github.com/apache/tomcat/blob/master/CONTRIBUTING.md On Tue, Feb 26, 2019 at 8:33 PM Mark Thomas wrote: > > All, > > https://github.com/apache/tomcat > > is now ready for testing. > > It should contain: > branches > - master (9.0.x) > - 8.5.x > - 7.0.x > > Tags: > - one for each 7.0.x, 8.5.x and 9.0.x release > > Tags have all been renamed to follow a a.b.c-MODIFIERn format for > version number where modifier is RC or M. > > The repository is probably read/write for all committers now but please > refrain from making any changes until we confirm that all is well. > > If you have some time available now, please test this new repository and > report and questions or concerns to this thread. > > Assuming no issues are discovered, I'd like to formally move over to git > later today. > > Mark > > - > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > For additional commands, e-mail: dev-h...@tomcat.apache.org > -- Best Regards！ Huxing - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: Git migration read for testing
On 26/02/2019 13:54, Rémy Maucherat wrote: > On Tue, Feb 26, 2019 at 1:33 PM Mark Thomas wrote: > >> All, >> >> https://github.com/apache/tomcat >> >> is now ready for testing. >> >> It should contain: >> branches >> - master (9.0.x) >> - 8.5.x >> - 7.0.x >> >> Tags: >> - one for each 7.0.x, 8.5.x and 9.0.x release >> >> Tags have all been renamed to follow a a.b.c-MODIFIERn format for >> version number where modifier is RC or M. >> >> The repository is probably read/write for all committers now but please >> refrain from making any changes until we confirm that all is well. >> >> If you have some time available now, please test this new repository and >> report and questions or concerns to this thread. >> >> Assuming no issues are discovered, I'd like to formally move over to git >> later today. >> > > That looks quite good :) > > Should we plan to all work with PRs for large changes ? That sounds like a better way of doing what we have done in the past with large proposed patches. I've just discovered that the Eclipse IDE does not support Git worktrees. I'm not sure how much of a nuisance that is going to turn out to be. IntelliJ IDEA does support worktrees and JetBrains offer open source licenses so I've applied for one. I'm not sure the benefit of worktree support is going to be worth the pain of switching IDEs. I guess I'll find out... I've done a diff and current git and svn HEAD agree. I've also done some random checks of tags etc and all looks OK. Next up I want to do a test commit. All, please don't commit to the repo just yet - even if you see me making commits. Thanks, Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: Git migration read for testing
On Tue, Feb 26, 2019 at 1:33 PM Mark Thomas wrote: > All, > > https://github.com/apache/tomcat > > is now ready for testing. > > It should contain: > branches > - master (9.0.x) > - 8.5.x > - 7.0.x > > Tags: > - one for each 7.0.x, 8.5.x and 9.0.x release > > Tags have all been renamed to follow a a.b.c-MODIFIERn format for > version number where modifier is RC or M. > > The repository is probably read/write for all committers now but please > refrain from making any changes until we confirm that all is well. > > If you have some time available now, please test this new repository and > report and questions or concerns to this thread. > > Assuming no issues are discovered, I'd like to formally move over to git > later today. > That looks quite good :) Should we plan to all work with PRs for large changes ? Rémy
Re: Git migration read for testing
On 26/02/2019 13:10, Mark Thomas wrote: > On 26/02/2019 12:45, Martin Grigorov wrote: >> All seems to work. >> I haven't received any email notifications though. > > I'll check where notifications are being sent. That should be fixed now. Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: Git migration read for testing
On 26/02/2019 12:45, Martin Grigorov wrote: > Hi, > > On Tue, Feb 26, 2019 at 2:33 PM Mark Thomas wrote: > >> All, >> >> https://github.com/apache/tomcat >> >> is now ready for testing. >> >> It should contain: >> branches >> - master (9.0.x) >> - 8.5.x >> - 7.0.x >> >> Tags: >> - one for each 7.0.x, 8.5.x and 9.0.x release >> >> Tags have all been renamed to follow a a.b.c-MODIFIERn format for >> version number where modifier is RC or M. >> >> The repository is probably read/write for all committers now but please >> refrain from making any changes until we confirm that all is well. >> >> If you have some time available now, please test this new repository and >> report and questions or concerns to this thread. >> > > I've just created a new branch, committed an empty change and removed the > branch. > All seems to work. > I haven't received any email notifications though. I'll check where notifications are being sent. Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: Git migration read for testing
Hi, On Tue, Feb 26, 2019 at 2:33 PM Mark Thomas wrote: > All, > > https://github.com/apache/tomcat > > is now ready for testing. > > It should contain: > branches > - master (9.0.x) > - 8.5.x > - 7.0.x > > Tags: > - one for each 7.0.x, 8.5.x and 9.0.x release > > Tags have all been renamed to follow a a.b.c-MODIFIERn format for > version number where modifier is RC or M. > > The repository is probably read/write for all committers now but please > refrain from making any changes until we confirm that all is well. > > If you have some time available now, please test this new repository and > report and questions or concerns to this thread. > I've just created a new branch, committed an empty change and removed the branch. All seems to work. I haven't received any email notifications though. Martin > > Assuming no issues are discovered, I'd like to formally move over to git > later today. > > Mark > > - > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > For additional commands, e-mail: dev-h...@tomcat.apache.org > >
Git migration read for testing
All, https://github.com/apache/tomcat is now ready for testing. It should contain: branches - master (9.0.x) - 8.5.x - 7.0.x Tags: - one for each 7.0.x, 8.5.x and 9.0.x release Tags have all been renamed to follow a a.b.c-MODIFIERn format for version number where modifier is RC or M. The repository is probably read/write for all committers now but please refrain from making any changes until we confirm that all is well. If you have some time available now, please test this new repository and report and questions or concerns to this thread. Assuming no issues are discovered, I'd like to formally move over to git later today. Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
