Re: Possible bugs in Http11Processor

2019-10-09 Thread Michael Osipov
Am 2019-10-09 um 23:46 schrieb Michael Osipov: Am 2019-10-09 um 23:23 schrieb Mark Thomas: On 09/10/2019 22:03, Michael Osipov wrote: Am 2019-10-09 um 19:08 schrieb Mark Thomas: On 09/10/2019 16:58, Michael Osipov wrote: Folks, while working on an improvement for Http11Processor I have

Re: Possible bugs in Http11Processor

2019-10-09 Thread Michael Osipov
Am 2019-10-09 um 23:23 schrieb Mark Thomas: On 09/10/2019 22:03, Michael Osipov wrote: Am 2019-10-09 um 19:08 schrieb Mark Thomas: On 09/10/2019 16:58, Michael Osipov wrote: Folks, while working on an improvement for Http11Processor I have noticed there constructs: if ((contentEncodingMB

Re: Possible bugs in Http11Processor

2019-10-09 Thread Mark Thomas
On 09/10/2019 22:03, Michael Osipov wrote: > Am 2019-10-09 um 19:08 schrieb Mark Thomas: >> On 09/10/2019 16:58, Michael Osipov wrote: >>> Folks, >>> >>> while working on an improvement for Http11Processor I have noticed there >>> constructs: >>> if ((contentEncodingMB != null)    

Re: Possible bugs in Http11Processor

2019-10-09 Thread Michael Osipov
Am 2019-10-09 um 19:08 schrieb Mark Thomas: On 09/10/2019 16:58, Michael Osipov wrote: Folks, while working on an improvement for Http11Processor I have noticed there constructs: if ((contentEncodingMB != null)    (contentEncodingMB.indexOf("gzip") != -1)) The parsing of this is much

Re: Possible bugs in Http11Processor

2019-10-09 Thread Mark Thomas
On 09/10/2019 17:49, Michael Osipov wrote: > Just found another bug: >>     private static boolean isConnectionClose(MimeHeaders headers) { >>     MessageBytes connection = headers.getValue(Constants.CONNECTION); >>     if (connection == null) { >>     return false; >>     }

Re: Possible bugs in Http11Processor

2019-10-09 Thread Mark Thomas
On 09/10/2019 16:58, Michael Osipov wrote: > Folks, > > while working on an improvement for Http11Processor I have noticed there > constructs: > >> if ((contentEncodingMB != null) >>    (contentEncodingMB.indexOf("gzip") != -1)) The parsing of this is much tighter on input. For output I think

Re: Possible bugs in Http11Processor

2019-10-09 Thread Michael Osipov
Just found another bug: private static boolean isConnectionClose(MimeHeaders headers) { MessageBytes connection = headers.getValue(Constants.CONNECTION); if (connection == null) { return false; } return connection.equals(Constants.CLOSE); }

Possible bugs in Http11Processor

2019-10-09 Thread Michael Osipov
Folks, while working on an improvement for Http11Processor I have noticed there constructs: if ((contentEncodingMB != null) (contentEncodingMB.indexOf("gzip") != -1)) if (connectionValue != null) foundUpgrade = connectionValue.toLowerCase(Locale.ENGLISH).contains("upgrade");