Re: Reduce default for maxParameterCount

2024-07-05 Thread Konstantin Kolinko
пт, 5 июл. 2024 г. в 23:40, Christopher Schultz : > > Mark, > > On 7/2/24 06:33, Mark Thomas wrote: > > [...] > > I would support a move to throw an unchecked exception from > getParameter* in older versions of Tomcat in order to produce a hard-fail. > > But I'm somewhat more bullish about this ki

Re: Reduce default for maxParameterCount

2024-07-05 Thread Christopher Schultz
Mark, On 7/2/24 06:33, Mark Thomas wrote: On 01/07/2024 07:17, Michael Osipov wrote: On 2024/06/27 17:13:56 Christopher Schultz wrote: Michael, On 6/27/24 08:46, Michael Osipov wrote: On 2023/03/09 14:23:33 Christopher Schultz wrote: A potential use-case for "large numbers of parameters" mi

Re: Reduce default for maxParameterCount

2024-07-02 Thread Michael Osipov
On 2024/07/02 11:06:55 Rémy Maucherat wrote: > On Tue, Jul 2, 2024 at 1:05 PM Mark Thomas wrote: > > > > On 02/07/2024 12:01, Michael Osipov wrote: > > > On 2024/07/02 10:33:29 Mark Thomas wrote: > > >> On 01/07/2024 07:17, Michael Osipov wrote: > > > > > > > > >>> I would really really expect th

Re: Reduce default for maxParameterCount

2024-07-02 Thread Rémy Maucherat
On Tue, Jul 2, 2024 at 1:05 PM Mark Thomas wrote: > > On 02/07/2024 12:01, Michael Osipov wrote: > > On 2024/07/02 10:33:29 Mark Thomas wrote: > >> On 01/07/2024 07:17, Michael Osipov wrote: > > > > >>> I would really really expect that Tomcat fails hard with 4xx if the input > >>> is invalid an

Re: Reduce default for maxParameterCount

2024-07-02 Thread Mark Thomas
On 02/07/2024 12:01, Michael Osipov wrote: On 2024/07/02 10:33:29 Mark Thomas wrote: On 01/07/2024 07:17, Michael Osipov wrote: I would really really expect that Tomcat fails hard with 4xx if the input is invalid and not issue a simple INFO at the log. The huge problem is that the request

Re: Reduce default for maxParameterCount

2024-07-02 Thread Michael Osipov
On 2024/07/02 10:33:29 Mark Thomas wrote: > On 01/07/2024 07:17, Michael Osipov wrote: > > On 2024/06/27 17:13:56 Christopher Schultz wrote: > >> Michael, > >> > >> On 6/27/24 08:46, Michael Osipov wrote: > >>> On 2023/03/09 14:23:33 Christopher Schultz wrote: > A potential use-case for "large

Re: Reduce default for maxParameterCount

2024-07-02 Thread Mark Thomas
On 01/07/2024 07:17, Michael Osipov wrote: On 2024/06/27 17:13:56 Christopher Schultz wrote: Michael, On 6/27/24 08:46, Michael Osipov wrote: On 2023/03/09 14:23:33 Christopher Schultz wrote: A potential use-case for "large numbers of parameters" might be an application that uses something li

Re: Reduce default for maxParameterCount

2024-06-30 Thread Michael Osipov
On 2024/06/27 17:13:56 Christopher Schultz wrote: > Michael, > > On 6/27/24 08:46, Michael Osipov wrote: > > On 2023/03/09 14:23:33 Christopher Schultz wrote: > >> A potential use-case for "large numbers of parameters" might be an > >> application that uses something like a multi-select list and t

Re: Reduce default for maxParameterCount

2024-06-27 Thread Christopher Schultz
Michael, On 6/27/24 08:46, Michael Osipov wrote: On 2023/03/09 14:23:33 Christopher Schultz wrote: A potential use-case for "large numbers of parameters" might be an application that uses something like a multi-select list and the number of choices is stupendously high. As in, when the applicat

Re: Reduce default for maxParameterCount

2023-03-24 Thread Rémy Maucherat
On Fri, Mar 24, 2023 at 10:01 AM Mark Thomas wrote: > > On 23/03/2023 20:20, Christopher Schultz wrote: > > Mark, > > > > On 3/22/23 07:38, Mark Thomas wrote: > >> Any more thoughts on this? > >> > >> There hasn't been much movement from the spec EG on this, so my > >> current thinking is to rever

Re: Reduce default for maxParameterCount

2023-03-24 Thread Mark Thomas
On 23/03/2023 20:20, Christopher Schultz wrote: Mark, On 3/22/23 07:38, Mark Thomas wrote: Any more thoughts on this? There hasn't been much movement from the spec EG on this, so my current thinking is to revert this change for 10.1.x and earlier to wait and see what the Servlet EG decides.

Re: Reduce default for maxParameterCount

2023-03-23 Thread Christopher Schultz
Mark, On 3/22/23 07:38, Mark Thomas wrote: Any more thoughts on this? There hasn't been much movement from the spec EG on this, so my current thinking is to revert this change for 10.1.x and earlier to wait and see what the Servlet EG decides. I'd like to leave our changes in, but I underst

Re: Reduce default for maxParameterCount

2023-03-23 Thread Mark Thomas
On 23/03/2023 12:02, Konstantin Kolinko wrote: Thanks for the continued feedback. Having someone to bounce ideas off is really helpful. ср, 22 мар. 2023 г. в 14:38, Mark Thomas : Any more thoughts on this? 1. If we cannot agree on the required behaviour, it is one more reason to make it

Re: Reduce default for maxParameterCount

2023-03-23 Thread Konstantin Kolinko
ср, 22 мар. 2023 г. в 14:38, Mark Thomas : > > Any more thoughts on this? > 1. If we cannot agree on the required behaviour, it is one more reason to make it configurable. As I said, it would be more useful to configure it at a Context. 2. Regarding the default behaviour, Throwing an exception

Re: Reduce default for maxParameterCount

2023-03-22 Thread Mark Thomas
Any more thoughts on this? There hasn't been much movement from the spec EG on this, so my current thinking is to revert this change for 10.1.x and earlier to wait and see what the Servlet EG decides. Mark On 15/03/2023 15:05, Mark Thomas wrote: On 15/03/2023 11:22, Konstantin Kolinko wrot

Re: Reduce default for maxParameterCount

2023-03-15 Thread Mark Thomas
On 15/03/2023 11:22, Konstantin Kolinko wrote: ср, 15 мар. 2023 г. в 13:29, Konstantin Kolinko : ср, 15 мар. 2023 г. в 13:15, Konstantin Kolinko : ср, 15 мар. 2023 г. в 12:07, Mark Thomas : On 14/03/2023 21:13, Christopher Schultz wrote: On 3/14/23 13:57, Mark Thomas wrote: On 09/03/2023 14:

Re: Reduce default for maxParameterCount

2023-03-15 Thread Konstantin Kolinko
ср, 15 мар. 2023 г. в 13:15, Konstantin Kolinko : > > [...] > > -1 unless the behaviour of "silently dropping extra parameters" is > changed as well. > > Silent loss of data is not what I want to see in production. > > Documentation [1] says "Request parameters beyond this limit will be ignored." >

Re: Reduce default for maxParameterCount

2023-03-15 Thread Konstantin Kolinko
ср, 15 мар. 2023 г. в 13:29, Konstantin Kolinko : > > ср, 15 мар. 2023 г. в 13:15, Konstantin Kolinko : > > > > ср, 15 мар. 2023 г. в 12:07, Mark Thomas : > > > > > > On 14/03/2023 21:13, Christopher Schultz wrote: > > > > Mark, > > > > > > > > On 3/14/23 13:57, Mark Thomas wrote: > > > >> On 09/03

Re: Reduce default for maxParameterCount

2023-03-15 Thread Konstantin Kolinko
ср, 15 мар. 2023 г. в 13:15, Konstantin Kolinko : > > ср, 15 мар. 2023 г. в 12:07, Mark Thomas : > > > > On 14/03/2023 21:13, Christopher Schultz wrote: > > > Mark, > > > > > > On 3/14/23 13:57, Mark Thomas wrote: > > >> On 09/03/2023 14:23, Christopher Schultz wrote: > > >>> Mark, > > >>> > > >>>

Re: Reduce default for maxParameterCount

2023-03-15 Thread Konstantin Kolinko
ср, 15 мар. 2023 г. в 12:07, Mark Thomas : > > On 14/03/2023 21:13, Christopher Schultz wrote: > > Mark, > > > > On 3/14/23 13:57, Mark Thomas wrote: > >> On 09/03/2023 14:23, Christopher Schultz wrote: > >>> Mark, > >>> > >>> On 3/9/23 05:56, Mark Thomas wrote: > Hi all, > > In the

Re: Reduce default for maxParameterCount

2023-03-15 Thread Mark Thomas
On 14/03/2023 21:13, Christopher Schultz wrote: Mark, On 3/14/23 13:57, Mark Thomas wrote: On 09/03/2023 14:23, Christopher Schultz wrote: Mark, On 3/9/23 05:56, Mark Thomas wrote: Hi all, In the context of CVE-2023-24998 (performance issues for large numbers of uploaded parts), I have bee

Re: Reduce default for maxParameterCount

2023-03-14 Thread Christopher Schultz
Mark, On 3/14/23 13:57, Mark Thomas wrote: On 09/03/2023 14:23, Christopher Schultz wrote: Mark, On 3/9/23 05:56, Mark Thomas wrote: Hi all, In the context of CVE-2023-24998 (performance issues for large numbers of uploaded parts), I have been wondering about reducing the default value for

Re: Reduce default for maxParameterCount

2023-03-14 Thread Mark Thomas
On 09/03/2023 14:23, Christopher Schultz wrote: Mark, On 3/9/23 05:56, Mark Thomas wrote: Hi all, In the context of CVE-2023-24998 (performance issues for large numbers of uploaded parts), I have been wondering about reducing the default value for maxParameterCount. The current default for

Re: Reduce default for maxParameterCount

2023-03-09 Thread Christopher Schultz
Mark, On 3/9/23 05:56, Mark Thomas wrote: Hi all, In the context of CVE-2023-24998 (performance issues for large numbers of uploaded parts), I have been wondering about reducing the default value for maxParameterCount. The current default for maxParameterCount is 10,000. It was set based on

Reduce default for maxParameterCount

2023-03-09 Thread Mark Thomas
Hi all, In the context of CVE-2023-24998 (performance issues for large numbers of uploaded parts), I have been wondering about reducing the default value for maxParameterCount. The current default for maxParameterCount is 10,000. It was set based on it being low enough to mitigate CVE-2012-0