Re: Responsive Website for tomcat.apache.org

2018-02-15 Thread Konstantin Kolinko
2018-02-06 21:58 GMT+03:00 Igal @ Lucee.org : > > Also, can anyone confirm if they can still see the menu in Print? And if so, > on what platform/browser? I can not reproduce that. Yes, I see the menu. Both in Firefox and in Chrome, latest. (58.0, 64.0) You need to have wide

Re: Responsive Website for tomcat.apache.org

2018-02-06 Thread Igal @ Lucee.org
Violeta, On 1/26/2018 9:57 AM, Violeta Georgieva wrote: I still see odd "OK" button on Chrome and Safari, only Firefox is ok. Regards, Violeta - MacOS High Sierra - https://github.com/violetagg/tomcat-website-screenshots/tree/master/r1822283 - no cache - the version is provided with every

Re: Responsive Website for tomcat.apache.org

2018-01-26 Thread Violeta Georgieva
Hi, 2018-01-26 19:07 GMT+02:00 Igal @ Lucee.org : > > On 1/26/2018 5:16 AM, Violeta Georgieva wrote: >> >> 2018-01-26 14:40 GMT+02:00 Konstantin Kolinko : >>> >>> It looks OK now, after I regenerated the docs - r1822283 . > > Right. I do not patch the

Re: Responsive Website for tomcat.apache.org

2018-01-26 Thread Igal @ Lucee.org
On 1/26/2018 5:16 AM, Violeta Georgieva wrote: 2018-01-26 14:40 GMT+02:00 Konstantin Kolinko : It looks OK now, after I regenerated the docs - r1822283 . Right.  I do not patch the generated files, only the source ones, so docs must be regenerated after each patch. I

Re: Responsive Website for tomcat.apache.org

2018-01-26 Thread Violeta Georgieva
2018-01-26 14:40 GMT+02:00 Konstantin Kolinko : > > 2018-01-26 13:04 GMT+03:00 Violeta Georgieva : > > Hi, > > > > 2018-01-26 7:14 GMT+02:00 Igal Sapir : > >> > >> Please see patch at https://github.com/isapir/tomcat-site/commit/5e4d642 >

Re: Responsive Website for tomcat.apache.org

2018-01-26 Thread Konstantin Kolinko
2018-01-26 13:04 GMT+03:00 Violeta Georgieva : > Hi, > > 2018-01-26 7:14 GMT+02:00 Igal Sapir : >> >> Please see patch at https://github.com/isapir/tomcat-site/commit/5e4d642 >> which adjusts the search box alignment and adds a keyboard toggle with the >> Enter

Re: Responsive Website for tomcat.apache.org

2018-01-26 Thread Violeta Georgieva
Hi, 2018-01-26 7:14 GMT+02:00 Igal Sapir : > > Please see patch at https://github.com/isapir/tomcat-site/commit/5e4d642 > which adjusts the search box alignment and adds a keyboard toggle with the > Enter key when the hamburger menu icon has focus. Here is what I see after

Re: Responsive Website for tomcat.apache.org

2018-01-25 Thread Igal Sapir
Please see patch at https://github.com/isapir/tomcat-site/commit/5e4d642 which adjusts the search box alignment and adds a keyboard toggle with the Enter key when the hamburger menu icon has focus. Best, Igal On Thu, Jan 25, 2018 at 1:34 PM, Igal @ Lucee.org wrote: > On

Re: Responsive Website for tomcat.apache.org

2018-01-25 Thread Igal @ Lucee.org
On 1/25/2018 1:04 PM, Konstantin Kolinko wrote: 2018-01-25 20:06 GMT+03:00 Igal @ Lucee.org : Thank you for sharing your screenshots. I am not sure why that happened but I will fix it. The first thing that comes to mind is a cached CSS file, so I will rename the file to make

Re: Responsive Website for tomcat.apache.org

2018-01-25 Thread Konstantin Kolinko
2018-01-25 20:06 GMT+03:00 Igal @ Lucee.org : > Violeta, Konstantin, > > On 1/25/2018 3:57 AM, Konstantin Kolinko wrote: >> >> 2018-01-25 10:00 GMT+03:00 Violeta Georgieva : >>> >>> Here is what I see with Chrome, Firefox and Safari >>>

Re: Responsive Website for tomcat.apache.org

2018-01-25 Thread Igal @ Lucee.org
On 1/25/2018 1:48 AM, Violeta Georgieva wrote: 2018-01-24 21:05 GMT+02:00 Igal @ Lucee.org : Perhaps a better phrasing would be: "Note, that Tomcat Documentation is provided on this site and is searchable (see links and search box at the left)." Given that I can not make the

Re: Responsive Website for tomcat.apache.org

2018-01-25 Thread Igal @ Lucee.org
Violeta, Konstantin, On 1/25/2018 3:57 AM, Konstantin Kolinko wrote: 2018-01-25 10:00 GMT+03:00 Violeta Georgieva : Here is what I see with Chrome, Firefox and Safari https://github.com/violetagg/tomcat-website-screenshots Regards, Violeta Here are mine screenshots:

Re: Responsive Website for tomcat.apache.org

2018-01-25 Thread Konstantin Kolinko
2018-01-25 10:00 GMT+03:00 Violeta Georgieva : > 2018-01-24 21:05 GMT+02:00 Igal @ Lucee.org : >> >> Konstantin, >> >> I'd be happy to make all the necessary corections. >> >> On 1/24/2018 2:44 AM, Konstantin Kolinko wrote: >>> >>> 1. The "print view" of the

Re: Responsive Website for tomcat.apache.org

2018-01-25 Thread Violeta Georgieva
2018-01-24 21:05 GMT+02:00 Igal @ Lucee.org : > > Konstantin, > > I'd be happy to make all the necessary corections. > > On 1/24/2018 2:44 AM, Konstantin Kolinko wrote: >> >> 1. The "print view" of the page is important. One should be able to >> print it. Especially the

Re: Responsive Website for tomcat.apache.org

2018-01-24 Thread Violeta Georgieva
2018-01-24 21:05 GMT+02:00 Igal @ Lucee.org : > > Konstantin, > > I'd be happy to make all the necessary corections. > > On 1/24/2018 2:44 AM, Konstantin Kolinko wrote: >> >> 1. The "print view" of the page is important. One should be able to >> print it. Especially the

Re: Responsive Website for tomcat.apache.org

2018-01-24 Thread Igal @ Lucee.org
Konstantin, I'd be happy to make all the necessary corections. On 1/24/2018 2:44 AM, Konstantin Kolinko wrote: 1. The "print view" of the page is important. One should be able to print it. Especially the documentation. I think that menu and search box were not visible when printing, but one

Re: Responsive Website for tomcat.apache.org

2018-01-24 Thread Mark Thomas
On 24/01/18 18:38, Igal @ Lucee.org wrote: > Mark, > > On 1/24/2018 1:43 AM, Mark Thomas wrote: >> Looks great. Patch applied many thanks. > Thank you.  I appreciate the feedback. > >> I don't suppose you are interested in making similar changes to the >> documentation web applications (the

Re: Responsive Website for tomcat.apache.org

2018-01-24 Thread Igal @ Lucee.org
Mark, On 1/24/2018 1:43 AM, Mark Thomas wrote: Looks great. Patch applied many thanks. Thank you.  I appreciate the feedback. I don't suppose you are interested in making similar changes to the documentation web applications (the content gets copied to the web-site) and/or updating the

Re: Responsive Website for tomcat.apache.org

2018-01-24 Thread Konstantin Kolinko
2018-01-24 12:43 GMT+03:00 Mark Thomas : > On 20/01/18 03:04, Igal Sapir wrote: >> UPDATE: >> >> On Fri, Jan 19, 2018 at 4:30 PM, Igal Sapir wrote: >> >>> To clarify, >>> >>> I have updated the code for the site. I have not updated the site itself >>> since I'm

Re: Responsive Website for tomcat.apache.org

2018-01-24 Thread Mark Thomas
On 20/01/18 03:04, Igal Sapir wrote: > UPDATE: > > On Fri, Jan 19, 2018 at 4:30 PM, Igal Sapir wrote: > >> To clarify, >> >> I have updated the code for the site. I have not updated the site itself >> since I'm not a committer (my previous statement seemed unclear). >> >> A

Re: Responsive Website for tomcat.apache.org

2018-01-19 Thread Igal Sapir
UPDATE: On Fri, Jan 19, 2018 at 4:30 PM, Igal Sapir wrote: > To clarify, > > I have updated the code for the site. I have not updated the site itself > since I'm not a committer (my previous statement seemed unclear). > > A committer needs to patch the tomcat-site accordingly.

Re: Responsive Website for tomcat.apache.org

2018-01-19 Thread Igal Sapir
To clarify, On Fri, Jan 19, 2018 at 4:24 PM, Igal Sapir wrote: > I have updated the site and it is now responsive. On browsers where the > width is 960px or smaller, the menu on the left is hidden and an hamburger > toggler button appears on the top left. Images at the banner

Re: Responsive Website for tomcat.apache.org

2018-01-19 Thread Igal Sapir
I have updated the site and it is now responsive. On browsers where the width is 960px or smaller, the menu on the left is hidden and an hamburger toggler button appears on the top left. Images at the banner are scaled down as well. You can see the changeset at

Re: Responsive Website for tomcat.apache.org

2018-01-19 Thread Mark Thomas
On 19/01/18 08:34, Mark Thomas wrote: > On 18/01/18 22:38, Igal Sapir wrote: >> Hello, >> >> I have moved the static resources to a common directory at /res and I would >> like to push that as the first step of updating the website since that >> clean up makes the website's code easier to

Re: Responsive Website for tomcat.apache.org

2018-01-19 Thread Mark Thomas
On 18/01/18 22:38, Igal Sapir wrote: > Hello, > > I have moved the static resources to a common directory at /res and I would > like to push that as the first step of updating the website since that > clean up makes the website's code easier to maintain. That will also get > the process of

Re: Responsive Website for tomcat.apache.org

2018-01-18 Thread Igal Sapir
Hello, I have moved the static resources to a common directory at /res and I would like to push that as the first step of updating the website since that clean up makes the website's code easier to maintain. That will also get the process of updating the website started with a relatively