Re: svn commit: r1794651 [1/3] - in /tomcat/trunk: java/org/apache/catalina/ java/org/apache/catalina/ant/ java/org/apache/catalina/ant/jmx/ java/org/apache/catalina/authenticator/ java/org/apache/cat

2017-05-10 Thread Emmanuel Bourg
Le 10/05/2017 à 12:04, Mark Thomas a écrit : > No need to apologise. Doing that had been on my wish list for a long > time but I hadn't found an easy way to do it. What it you use? Regexp? I started with a regexp and then switched to the structural search and replace feature of IntelliJ. > I'm

RE: svn commit: r1794651 [1/3] - in /tomcat/trunk: java/org/apache/catalina/ java/org/apache/catalina/ant/ java/org/apache/catalina/ant/jmx/ java/org/apache/catalina/authenticator/ java/org/apache/cat

2017-05-10 Thread Caldarale, Charles R
> From: Mark Thomas [mailto:ma...@apache.org] > Subject: Re: svn commit: r1794651 [1/3] - in /tomcat/trunk: java/org/apache/catalina/ > java/org/apache/catalina/ant/ java/org/apache/catalina/ant/jmx/ > java/org/apache/catalina/authenticator/ java/org/apache/catalina/connector/ > java/org/apache/ca

Re: svn commit: r1794651 [1/3] - in /tomcat/trunk: java/org/apache/catalina/ java/org/apache/catalina/ant/ java/org/apache/catalina/ant/jmx/ java/org/apache/catalina/authenticator/ java/org/apache/cat

2017-05-10 Thread Mark Thomas
On 10/05/17 10:32, Emmanuel Bourg wrote: > Le 10/05/2017 à 10:39, Mark Thomas a écrit : > >> I think you might just have made Chuck's day with this commit. > > Norris? :) :) Caldarale > Sorry for the noise, I noticed that you were often removing > these parentheses when modifying the code, so

Re: svn commit: r1794651 [1/3] - in /tomcat/trunk: java/org/apache/catalina/ java/org/apache/catalina/ant/ java/org/apache/catalina/ant/jmx/ java/org/apache/catalina/authenticator/ java/org/apache/cat

2017-05-10 Thread Emmanuel Bourg
Le 10/05/2017 à 10:39, Mark Thomas a écrit : > I think you might just have made Chuck's day with this commit. Norris? :) Sorry for the noise, I noticed that you were often removing these parentheses when modifying the code, so I thought it would be a good idea to remove them once and for all. No

Re: svn commit: r1794651 [1/3] - in /tomcat/trunk: java/org/apache/catalina/ java/org/apache/catalina/ant/ java/org/apache/catalina/ant/jmx/ java/org/apache/catalina/authenticator/ java/org/apache/cat

2017-05-10 Thread Mark Thomas
On 09/05/17 23:23, ebo...@apache.org wrote: > Author: ebourg > Date: Tue May 9 22:22:59 2017 > New Revision: 1794651 > > URL: http://svn.apache.org/viewvc?rev=1794651&view=rev > Log: > Removed unnecessary parentheses in return statements I think you might just have made Chuck's day with this com