Re: svn commit: r471309 - in /tomcat/container/tc5.5.x: catalina/src/share/org/apache/catalina/session/StandardSession.java webapps/docs/changelog.xml

2006-11-09 Thread Sandy McArthur
After having slept on it and reading more of the servlet spec I no longer think this is the best solution. I think it would make Tomcat more divergent from the spec in the common case which is not good. I think I was trying to be too clever. If someone wants the patch, I'll send it to you. On 11/

Re: svn commit: r471309 - in /tomcat/container/tc5.5.x: catalina/src/share/org/apache/catalina/session/StandardSession.java webapps/docs/changelog.xml

2006-11-09 Thread Filip Hanik - Dev Lists
I tend to agree with Rainer, session expiration should be done with a predictable pattern the trick below is neat, the idea of it, but for practical session expiration I'm not so sure. Filip Rainer Jung wrote: Hi, Sandy McArthur schrieb: The way it works is the StandardSessionFacade is r

Re: svn commit: r471309 - in /tomcat/container/tc5.5.x: catalina/src/share/org/apache/catalina/session/StandardSession.java webapps/docs/changelog.xml

2006-11-09 Thread Rainer Jung
Hi, Sandy McArthur schrieb: > The way it works is the StandardSessionFacade is referenced like it > was with the facade field in StandardSession and a WeakReference to > the StandardSessionFacade is added the the field facadeReference. > After the maxInactiveInterval the facade field is set to nul

Re: svn commit: r471309 - in /tomcat/container/tc5.5.x: catalina/src/share/org/apache/catalina/session/StandardSession.java webapps/docs/changelog.xml

2006-11-08 Thread Mark Thomas
Sandy McArthur wrote: > Attached is what I think may be an even more improved fix for 37356. > It does away with the accessCount which should make Remy happy. > It should prevent sessions currently in use from expiring which should > make those other 2 people and myself happy. > It doesn't add any

Re: svn commit: r471309 - in /tomcat/container/tc5.5.x: catalina/src/share/org/apache/catalina/session/StandardSession.java webapps/docs/changelog.xml

2006-11-08 Thread Remy Maucherat
Sandy McArthur wrote: Attached is what I think may be an even more improved fix for 37356. It does away with the accessCount which should make Remy happy. It should prevent sessions currently in use from expiring which should make those other 2 people and myself happy. It doesn't add any synchron

Re: svn commit: r471309 - in /tomcat/container/tc5.5.x: catalina/src/share/org/apache/catalina/session/StandardSession.java webapps/docs/changelog.xml

2006-11-08 Thread Sandy McArthur
Attached is what I think may be an even more improved fix for 37356. It does away with the accessCount which should make Remy happy. It should prevent sessions currently in use from expiring which should make those other 2 people and myself happy. It doesn't add any synchronization but I believe i

svn commit: r471309 - in /tomcat/container/tc5.5.x: catalina/src/share/org/apache/catalina/session/StandardSession.java webapps/docs/changelog.xml

2006-11-04 Thread markt
Author: markt Date: Sat Nov 4 17:11:11 2006 New Revision: 471309 URL: http://svn.apache.org/viewvc?view=rev&rev=471309 Log: Improve fix for 37356. Modified: tomcat/container/tc5.5.x/catalina/src/share/org/apache/catalina/session/StandardSession.java tomcat/container/tc5.5.x/webapps/docs