TOMEE-2484 | Missing AsciiDoc format for TomEE Embedded Maven Plugin documentation

2019-02-28 Thread César Hernández Mendoza
Hi, I opened https://issues.apache.org/jira/browse/TOMEE-2484 because TomEE Embedded Maven Plugin documentation is missing propper AsciiDoc format. If somebody wants to work on it, please reply to the list so we can proceed to assign the JIRA ticket. -- Atentamente: César Hernández Mendoza.

Re: TOMEE-2482 | Add missing modules into tomee/example parent pom.xml

2019-02-28 Thread César Hernández Mendoza
Awesome, thanks Sherman. TOMEE-2482 is now assigned to you. Feel free reach out to the list for pointers or help if need it. El jue., 28 feb. 2019 a las 15:54, Sherman Marshall (< sherman.david.marsh...@gmail.com>) escribió: > I can pick that one up. > > I'm looking to work on some examples,

Re: TOMEE-2482 | Add missing modules into tomee/example parent pom.xml

2019-02-28 Thread Sherman Marshall
I can pick that one up. I'm looking to work on some examples, and it should help me get familiar with the different TomEE builds. Regards, Sherman On Thu, Feb 28, 2019, 1:44 PM César Hernández Mendoza wrote: > Hi, > > As part of a conversation with James, we detected that there are a couple

TOMEE-2483 | Updates for TomEE Maven Plugin documentation

2019-02-28 Thread César Hernández Mendoza
It seems the documentation for TomEE Maven Plugin requires a couple of updates. I opened https://issues.apache.org/jira/browse/TOMEE-2483. If somebody wants to work on it, please reply to the list so we can proceed to assign the JIRA ticket. -- Atentamente: César Hernández Mendoza.

TOMEE-2482 | Add missing modules into tomee/example parent pom.xml

2019-02-28 Thread César Hernández Mendoza
Hi, As part of a conversation with James, we detected that there are a couple of modules missing from the tomee/example parent pom.xml. I opened TOMEE-2482 [1] if somebody wants to work on it, please reply to the list so we can proceed to assign the JIRA ticket. [1]

CXF PRs (M3)

2019-02-28 Thread Ivan Junckes Filho
Hey guys, it seems these PRs are already reviewed. Can someone merge them? It would be very nice if this makes to M3. https://github.com/apache/tomee/pull/409 https://github.com/apache/tomee/pull/419

Re: LocalInitialContextFactory instead of InitContextFactory

2019-02-28 Thread Daniel Cunha
I see it in a lot of sample. By the way, we also have it in org.apache.openejb.core.LocalInitialContext https://github.com/apache/tomee/blob/master/container/openejb-core/src/main/java/org/apache/openejb/core/LocalInitialContext.java#L54

[GitHub] danielsoro edited a comment on issue #427: TOMEE-2481 - Move code using PropertyEditors (deprectaed class) to PropertyEditorRegistry

2019-02-28 Thread GitBox
danielsoro edited a comment on issue #427: TOMEE-2481 - Move code using PropertyEditors (deprectaed class) to PropertyEditorRegistry URL: https://github.com/apache/tomee/pull/427#issuecomment-468354049 @otaviojava Well.. this class is from xbean-reflect library. Should exists

[GitHub] danielsoro commented on issue #427: TOMEE-2481 - Move code using PropertyEditors (deprectaed class) to PropertyEditorRegistry

2019-02-28 Thread GitBox
danielsoro commented on issue #427: TOMEE-2481 - Move code using PropertyEditors (deprectaed class) to PropertyEditorRegistry URL: https://github.com/apache/tomee/pull/427#issuecomment-468354049 Well.. this class is from xbean-reflect library. Should exists reason because it is not

[GitHub] j4fm commented on a change in pull request #419: TOMEE-2274 (JAXB bump); exclusions for CXF 3.3.0; fix those existing build WARNINGs

2019-02-28 Thread GitBox
j4fm commented on a change in pull request #419: TOMEE-2274 (JAXB bump); exclusions for CXF 3.3.0; fix those existing build WARNINGs URL: https://github.com/apache/tomee/pull/419#discussion_r261282801 ## File path: examples/bval-evaluation-redeployment/runner/pom.xml ##

[GitHub] cesarhernandezgt commented on a change in pull request #419: TOMEE-2274 (JAXB bump); exclusions for CXF 3.3.0; fix those existing build WARNINGs

2019-02-28 Thread GitBox
cesarhernandezgt commented on a change in pull request #419: TOMEE-2274 (JAXB bump); exclusions for CXF 3.3.0; fix those existing build WARNINGs URL: https://github.com/apache/tomee/pull/419#discussion_r261281263 ## File path: examples/bval-evaluation-redeployment/runner/pom.xml

Re: How can I help?

2019-02-28 Thread César Hernández Mendoza
Welcome, Sherman! I'm catching up with the mailing list it's great to see you jumping right into PR that was already merged! El mié., 27 feb. 2019 a las 18:41, Sherman Marshall (< sherman.david.marsh...@gmail.com>) escribió: > To Whom it May Concern, > > My name is Sherman Marshall. I live in

Re: JIRA permission request

2019-02-28 Thread César Hernández Mendoza
Thank you all! El jue., 28 feb. 2019 a las 8:02, Jonathan Gallimore (< jonathan.gallim...@gmail.com>) escribió: > Done! > > On Tue, Feb 26, 2019 at 12:59 AM David Blevins > wrote: > > > Go for it. The permissions are restricted to try and get people on the > > list working together. Cesar is

[GitHub] otaviojava commented on issue #427: TOMEE-2481 - Move code using PropertyEditors (deprectaed class) to PropertyEditorRegistry

2019-02-28 Thread GitBox
otaviojava commented on issue #427: TOMEE-2481 - Move code using PropertyEditors (deprectaed class) to PropertyEditorRegistry URL: https://github.com/apache/tomee/pull/427#issuecomment-468336959 @danielsoro every time you need to use the method ` new

Re: LocalInitialContextFactory instead of InitContextFactory

2019-02-28 Thread Jonathan Gallimore
Hey Dani Can you post a couple of examples? Jon On Thu, Feb 28, 2019 at 3:30 PM Daniel Cunha wrote: > Hi folks, > > I saw that we are using > org.apache.openejb.core.ivm.naming.InitContextFactory in some places. > Shouldn't we move the code to use definitely >

[GitHub] j4fm commented on a change in pull request #419: TOMEE-2274 (JAXB bump); exclusions for CXF 3.3.0; fix those existing build WARNINGs

2019-02-28 Thread GitBox
j4fm commented on a change in pull request #419: TOMEE-2274 (JAXB bump); exclusions for CXF 3.3.0; fix those existing build WARNINGs URL: https://github.com/apache/tomee/pull/419#discussion_r261269263 ## File path: examples/bval-evaluation-redeployment/runner/pom.xml ##

Re: How can I help?

2019-02-28 Thread David Blevins
> On Feb 27, 2019, at 9:50 PM, Sherman Marshall > wrote: > > I'll definitely keep an eye out for fixes like that! I think I'll see if I > can do some examples too, and check out the code coverage there next. Sounds great. > I see examples for interceptors, but not filters... which seems odd.

LocalInitialContextFactory instead of InitContextFactory

2019-02-28 Thread Daniel Cunha
Hi folks, I saw that we are using org.apache.openejb.core.ivm.naming.InitContextFactory in some places. Shouldn't we move the code to use definitely org.apache.openejb.core.LocalInitialContextFactory instead of org.apache.openejb.core.ivm.naming.InitContextFactory? -- Daniel "soro" Cunha

Re: PRs ready for review

2019-02-28 Thread César Hernández Mendoza
Hi James, Yes, you resolved the point from my first review. I review it again and left one comment on https://github.com/apache/tomee/pull/419#pullrequestreview-209121248 El jue., 28 feb. 2019 a las 5:49, j4fm () escribió: > Hi César, are you happy with the PR419+PR409 after I resolved your

PropertyEditors deprecated class.

2019-02-28 Thread Daniel Cunha
Hi Folks, I've created the ticket https://issues.apache.org/jira/browse/TOMEE-2481 That because the class PropertyEditors is a deprected class, because of that we are moving it to use the PropertyEditorRegistry as indicated on the PropertyEditors comment: this is all static and leaks, use

[GitHub] cesarhernandezgt commented on a change in pull request #419: TOMEE-2274 (JAXB bump); exclusions for CXF 3.3.0; fix those existing build WARNINGs

2019-02-28 Thread GitBox
cesarhernandezgt commented on a change in pull request #419: TOMEE-2274 (JAXB bump); exclusions for CXF 3.3.0; fix those existing build WARNINGs URL: https://github.com/apache/tomee/pull/419#discussion_r261235019 ## File path: examples/bval-evaluation-redeployment/runner/pom.xml

[GitHub] danielsoro opened a new pull request #427: TOMEE-2481 - Move code using PropertyEditors (deprectaed class) to PropertyEditorRegistry

2019-02-28 Thread GitBox
danielsoro opened a new pull request #427: TOMEE-2481 - Move code using PropertyEditors (deprectaed class) to PropertyEditorRegistry URL: https://github.com/apache/tomee/pull/427 This is an automated message from the

Re: Idea of an M3

2019-02-28 Thread Salomon Mayengue
+1 Le lun. 25 févr. 2019 à 23:35, César Hernández Mendoza a écrit : > +1 > > El dom., 24 feb. 2019 a las 15:58, Ivan Junckes Filho (< > ivanjunc...@gmail.com>) escribió: > > > +1 > > > > On Sun, Feb 24, 2019 at 4:09 AM David Blevins > > wrote: > > > > > Huge +1 > > > > > > Doing more frequent

Re: JIRA permission request

2019-02-28 Thread Jonathan Gallimore
Done! On Tue, Feb 26, 2019 at 12:59 AM David Blevins wrote: > Go for it. The permissions are restricted to try and get people on the > list working together. Cesar is doing exactly that. > > > -- > David Blevins > http://twitter.com/dblevins > http://www.tomitribe.com > > > On Feb 25, 2019,

[GitHub] jgallimore merged pull request #425: TOMEE-2477 - Upgrade .gitignore to ignore files generated by test.

2019-02-28 Thread GitBox
jgallimore merged pull request #425: TOMEE-2477 - Upgrade .gitignore to ignore files generated by test. URL: https://github.com/apache/tomee/pull/425 This is an automated message from the Apache Git Service. To respond to

[GitHub] jgallimore merged pull request #421: TOMEE-2474 Translate to Portuguese: examples/jpa-hibernate.

2019-02-28 Thread GitBox
jgallimore merged pull request #421: TOMEE-2474 Translate to Portuguese: examples/jpa-hibernate. URL: https://github.com/apache/tomee/pull/421 This is an automated message from the Apache Git Service. To respond to the

[GitHub] jgallimore merged pull request #423: TOMEE-2476 - Fix async-method documentation

2019-02-28 Thread GitBox
jgallimore merged pull request #423: TOMEE-2476 - Fix async-method documentation URL: https://github.com/apache/tomee/pull/423 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] otaviojava commented on a change in pull request #426: Simple code refactoring. Trying to gain familiarity with the project

2019-02-28 Thread GitBox
otaviojava commented on a change in pull request #426: Simple code refactoring. Trying to gain familiarity with the project URL: https://github.com/apache/tomee/pull/426#discussion_r261179831 ## File path:

Re: PRs ready for review

2019-02-28 Thread j4fm
Hi César, are you happy with the PR419+PR409 after I resolved your valid points? My local full run of tests succeeds (with the examples too). Thanks again for checking. James -- Sent from: http://tomee-openejb.979440.n4.nabble.com/TomEE-Dev-f982480.html

Re: New Status of TomEE 8

2019-02-28 Thread Roberto Cortez
I think we need to clear all the MP work, Java 11 support, Security API implementation and push a final release with that. We can focus on the TCK later. > On 28 Feb 2019, at 01:04, David Blevins wrote: > >> On Feb 27, 2019, at 12:47 PM, j4fm wrote: >> >> On Jarkata EE cert... +1 for after

Re: New Status of TomEE 8

2019-02-28 Thread Roberto Cortez
> On 28 Feb 2019, at 01:04, David Blevins wrote: > >> On Feb 27, 2019, at 12:47 PM, j4fm wrote: >> >> On Jarkata EE cert... +1 for after 8 is released. This conversation just >> reminded me of this thread quite some time ago now, with some views :) >> >> Status-of-TomEE-8 >>

Re: MicroProfile Integration in Plus and Plume

2019-02-28 Thread j4fm
FYI, the full run of tests succeeded locally with this PR over night. :) -- Sent from: http://tomee-openejb.979440.n4.nabble.com/TomEE-Dev-f982480.html

[GitHub] jgallimore commented on a change in pull request #422: Creates Unit test to CmpJpaConversion

2019-02-28 Thread GitBox
jgallimore commented on a change in pull request #422: Creates Unit test to CmpJpaConversion URL: https://github.com/apache/tomee/pull/422#discussion_r261122565 ## File path: container/openejb-core/src/test/java/org/apache/openejb/config/CmpJpaConversionTest.java ## @@

[GitHub] jgallimore commented on a change in pull request #422: Creates Unit test to CmpJpaConversion

2019-02-28 Thread GitBox
jgallimore commented on a change in pull request #422: Creates Unit test to CmpJpaConversion URL: https://github.com/apache/tomee/pull/422#discussion_r261120405 ## File path: container/openejb-core/src/main/java/org/apache/openejb/config/CmpJpaConversion.java ## @@

Re: Assignment of task: TOMEE-2480

2019-02-28 Thread Jean-Louis Monteiro
Done. Thank you -- Jean-Louis Monteiro http://twitter.com/jlouismonteiro http://www.tomitribe.com On Thu, Feb 28, 2019 at 4:33 AM Gabriel Ferreira wrote: > Hey guys, can someone assign this task for me? > https://issues.apache.org/jira/browse/TOMEE-2480 > > thanks ;) >