Re: JSON Pointer/Patch issue with /-

2020-12-02 Thread Romain Manni-Bucau
Let say it enables more control whereas this kind of toggle system properties can be random when apps don't need the same (once again it is functional and not about perf there). Feel free to take back my PR, was just sharing the idea with code to try to fix it together faster. Romain Manni-Bucau

Re: JSON Pointer/Patch issue with /-

2020-12-02 Thread Jean-Louis MONTEIRO
Hey Romain, Your email was clear on how to do it. But thanks for creating the PR. To be honest, I don't really care if you prefer this way. Essentially, instead of adding a property into a file, I'll now add a Maven dependency into my pom file. Does not change much. If on the other hand, it

Re: JSON Pointer/Patch issue with /-

2020-12-02 Thread Romain Manni-Bucau
Send a PR with the "SPI" option which enables to have this toggle *at will* and drop it when not desired anymore without any config. Hope it illustrates better than words one toggle option which wouldnt depend on the env. Romain Manni-Bucau @rmannibucau | Blog

Re: JSON Pointer/Patch issue with /-

2020-12-02 Thread Jean-Louis MONTEIRO
I understand it's a nice feature and the RFC does not address it. What I'm not happy with is that adding this feature breaks what's actually in the spec. I would prefer us to implement this feature without breaking standard features. I'll push a proposal for now and we can improve. Le mar. 1

Re: JSON Pointer/Patch issue with /-

2020-12-01 Thread Romain Manni-Bucau
Le mar. 1 déc. 2020 à 14:40, Jonathan Gallimore < jonathan.gallim...@gmail.com> a écrit : > I'll address a few points inline below, but at a high level, what are we > looking to achieve from a spec/tck challenge? > > I can see a case for some clarification and updates to the Javadoc. > > The

Re: JSON Pointer/Patch issue with /-

2020-12-01 Thread Jonathan Gallimore
I'll address a few points inline below, but at a high level, what are we looking to achieve from a spec/tck challenge? I can see a case for some clarification and updates to the Javadoc. The assertions that /- will return an error (as that references an index to append to after the *end* of an

Re: JSON Pointer/Patch issue with /-

2020-11-27 Thread Romain Manni-Bucau
Hi JL, As discussed together - but sharing for others - we must take into account some points: 1. reading both spec, JSON-Patch enables to handle /- as your first did (ie consider it is last element). JSON-Patch uses JSON-Pointer but nowhere it is written it behaves as JSON-Pointer in all cases