Re: default tomee credentials (WAS: [VOTE] TomEE 1.6.0.2...)
Hi Jack, Straight to the point and to , *no* it does not affect your production environment. This has to do with testing and development environments. I'll get something documented on the site so that you have something to reference. Andy. - -- Andy Gumbrecht http://www.tomitribe.com agumbre...@tomitribe.com https://twitter.com/AndyGeeDe TomEE treibt Tomitribe ! | http://tomee.apache.org -- View this message in context: http://openejb.979440.n4.nabble.com/default-tomee-credentials-WAS-VOTE-TomEE-1-6-0-2-tp4669261p4669343.html Sent from the OpenEJB Dev mailing list archive at Nabble.com.
commit messages
Hi guys, a quick message to try to normalize a bit commit messages (I blame nobody that's for me too ;) ). If working against a jira would be great to use (my proposal but can be discussed): [JIRA NAME] [short description in english] For instance: TOMEE- change default value foo attribute in tomee.xml Main goal is to avoid things like: working on TOMEE-4568 or https://issues.apache.org/jira/browse/TOMEE-8756; This is hard to re-browse history without textual description Romain Manni-Bucau Twitter: @rmannibucau Blog: http://rmannibucau.wordpress.com/ LinkedIn: http://fr.linkedin.com/in/rmannibucau Github: https://github.com/rmannibucau
Re: commit messages
Looks good to me. []s, Thiago. On Fri, May 16, 2014 at 11:31 AM, Romain Manni-Bucau rmannibu...@gmail.comwrote: Hi guys, a quick message to try to normalize a bit commit messages (I blame nobody that's for me too ;) ). If working against a jira would be great to use (my proposal but can be discussed): [JIRA NAME] [short description in english] For instance: TOMEE- change default value foo attribute in tomee.xml Main goal is to avoid things like: working on TOMEE-4568 or https://issues.apache.org/jira/browse/TOMEE-8756; This is hard to re-browse history without textual description Romain Manni-Bucau Twitter: @rmannibucau Blog: http://rmannibucau.wordpress.com/ LinkedIn: http://fr.linkedin.com/in/rmannibucau Github: https://github.com/rmannibucau
Re: svn commit: r1593721 - in /tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb: ./ assembler/classic/ cdi/ core/ core/ivm/ core/mdb/
Hi Isnt it fixed now? Mail delay? Le 16 mai 2014 01:03, Thiago Veronezi thi...@veronezi.org a écrit : Hi Romain, This is the revision that breaks the OpenEjbContainerTest that I mentioned earlier today. wdyt? []s, Thiago. On Sat, May 10, 2014 at 3:47 PM, rmannibu...@apache.org wrote: Author: rmannibucau Date: Sat May 10 19:47:21 2014 New Revision: 1593721 URL: http://svn.apache.org/r1593721 Log: trying to avoid to create local bean lazily which creates a bottleneck + thread safety in cdiplugin Modified: tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/BeanContext.java tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/assembler/classic/Assembler.java tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/cdi/CdiPlugin.java tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/core/BaseSessionContext.java tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/core/ivm/EjbHomeProxyHandler.java tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/core/mdb/EndpointFactory.java Modified: tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/BeanContext.java URL: http://svn.apache.org/viewvc/tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/BeanContext.java?rev=1593721r1=1593720r2=1593721view=diff == --- tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/BeanContext.java (original) +++ tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/BeanContext.java Sat May 10 19:47:21 2014 @@ -1816,4 +1816,16 @@ public class BeanContext extends Deploym private Class localInterface; private Method createMethod; } + +public static final class ProxyClass { +private final Class? proxy; + +public ProxyClass(final Class? proxy) { +this.proxy = proxy; +} + +public Class? getProxy() { +return proxy; +} +} } Modified: tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/assembler/classic/Assembler.java URL: http://svn.apache.org/viewvc/tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/assembler/classic/Assembler.java?rev=1593721r1=1593720r2=1593721view=diff == --- tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/assembler/classic/Assembler.java (original) +++ tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/assembler/classic/Assembler.java Sat May 10 19:47:21 2014 @@ -72,6 +72,7 @@ import org.apache.openejb.core.ServerFed import org.apache.openejb.core.SimpleTransactionSynchronizationRegistry; import org.apache.openejb.core.TransactionSynchronizationRegistryWrapper; import org.apache.openejb.core.WebContext; +import org.apache.openejb.core.ivm.IntraVmProxy; import org.apache.openejb.core.ivm.naming.ContextualJndiReference; import org.apache.openejb.core.ivm.naming.IvmContext; import org.apache.openejb.core.ivm.naming.IvmJndiFactory; @@ -124,6 +125,7 @@ import org.apache.openejb.util.SuperProp import org.apache.openejb.util.URLs; import org.apache.openejb.util.classloader.ClassLoaderAwareHandler; import org.apache.openejb.util.classloader.URLClassLoaderFirst; +import org.apache.openejb.util.proxy.LocalBeanProxyFactory; import org.apache.openejb.util.proxy.ProxyFactory; import org.apache.openejb.util.proxy.ProxyManager; import org.apache.webbeans.config.WebBeansContext; @@ -147,6 +149,7 @@ import javax.enterprise.context.Dependen import javax.enterprise.context.spi.CreationalContext; import javax.enterprise.inject.spi.Bean; import javax.enterprise.inject.spi.BeanManager; +import javax.jms.MessageListener; import javax.management.InstanceNotFoundException; import javax.management.MBeanRegistrationException; import javax.management.MBeanServer; @@ -1062,6 +1065,27 @@ public class Assembler extends Assembler beanContext.setMethodTransactionAttribute(entry.getKey(), TransactionType.Required); } } + +// if local bean or mdb generate proxy class now to avoid bottleneck on classloader later +if (beanContext.isLocalbean() || beanContext.getBusinessLocalInterfaces().contains(MessageListener.class)) { +final ListClass interfaces = new ArrayListClass(3); +interfaces.add(Serializable.class); +interfaces.add(IntraVmProxy.class); +final BeanType type = beanContext.getComponentType(); +
Re: commit messages
+1 works fine for me. JLouis -- Jean-Louis Monteiro http://twitter.com/jlouismonteiro http://www.tomitribe.com On Fri, May 16, 2014 at 8:31 AM, Romain Manni-Bucau rmannibu...@gmail.comwrote: Hi guys, a quick message to try to normalize a bit commit messages (I blame nobody that's for me too ;) ). If working against a jira would be great to use (my proposal but can be discussed): [JIRA NAME] [short description in english] For instance: TOMEE- change default value foo attribute in tomee.xml Main goal is to avoid things like: working on TOMEE-4568 or https://issues.apache.org/jira/browse/TOMEE-8756; This is hard to re-browse history without textual description Romain Manni-Bucau Twitter: @rmannibucau Blog: http://rmannibucau.wordpress.com/ LinkedIn: http://fr.linkedin.com/in/rmannibucau Github: https://github.com/rmannibucau
Re: Maven / tomEE
We added in tomee openejb.check.classloader=true - in conf/system.properties - for it. See http://tomee.apache.org/properties-listing.html Romain Manni-Bucau Twitter: @rmannibucau Blog: http://rmannibucau.wordpress.com/ LinkedIn: http://fr.linkedin.com/in/rmannibucau Github: https://github.com/rmannibucau 2014-05-07 13:59 GMT+02:00 agumbrecht agumbre...@tomitribe.com: When faced with this challenge in the past I used the following to regularly create a directory listing of all jars. http://maven.apache.org/plugins/maven-dependency-plugin/examples/copying-project-dependencies.html I could usually see at a glance if duplicate libraries were sneaking in, but also had a small program to check for duplicates. I regularly try and pull up all deps into the TomEE top parent pom, so it's easy to search that file before pulling in a dep in your project. Andy. - -- Andy Gumbrecht http://www.tomitribe.com agumbre...@tomitribe.com https://twitter.com/AndyGeeDe TomEE treibt Tomitribe ! | http://tomee.apache.org -- View this message in context: http://openejb.979440.n4.nabble.com/Maven-tomEE-tp4669168p4669208.html Sent from the OpenEJB Dev mailing list archive at Nabble.com.
The binary quartz-2.2.0.jar is not the same in TomEE 1.6.0.1 and 1.6.0.2
Hello Everybody, Using WinMerge, I just see that both quartz jar (2.2.0) are not the same ... Have you any idea why? Rgds, Thibault -- View this message in context: http://openejb.979440.n4.nabble.com/The-binary-quartz-2-2-0-jar-is-not-the-same-in-TomEE-1-6-0-1-and-1-6-0-2-tp4669361.html Sent from the OpenEJB Dev mailing list archive at Nabble.com.
Re: commit messages
Maybe someone can update this document. Include the JIRA number and title (if there is a jira). I try never to say Fixed FOO-2543 all by itself. - http://tomee.apache.org/dev/tips-and-suggestions.html This was already the proposed and agreed commit message format from some years ago, but these things have a way of getting lost every few years as committers come and go. There's a handful of other guidelines on that page such as don't reformat code and make logic changes in the same commit, etc. Might be good to clean it up and get everyone to take a fresh look. -David On May 16, 2014, at 10:53 AM, Jean-Louis Monteiro jlmonte...@tomitribe.com wrote: +1 works fine for me. JLouis -- Jean-Louis Monteiro http://twitter.com/jlouismonteiro http://www.tomitribe.com On Fri, May 16, 2014 at 8:31 AM, Romain Manni-Bucau rmannibu...@gmail.comwrote: Hi guys, a quick message to try to normalize a bit commit messages (I blame nobody that's for me too ;) ). If working against a jira would be great to use (my proposal but can be discussed): [JIRA NAME] [short description in english] For instance: TOMEE- change default value foo attribute in tomee.xml Main goal is to avoid things like: working on TOMEE-4568 or https://issues.apache.org/jira/browse/TOMEE-8756; This is hard to re-browse history without textual description Romain Manni-Bucau Twitter: @rmannibucau Blog: http://rmannibucau.wordpress.com/ LinkedIn: http://fr.linkedin.com/in/rmannibucau Github: https://github.com/rmannibucau
Re: Debian Package
Hi guys, A new tentative of having a debian packages is ready. Please note that this is only a trial. I plan to upload it to launchpad, then submit it to debian (integration with existing debian packages). I don't want to overload people.apache.org. The goal of it is to be able to have fresh deb packages with our standard mvn install. You guys can check it out by following these steps. Include this line in your /etc/apt/sources.list... deb http://people.apache.org/~tveronezi/deb-repo/ tomee main Execute... gpg --keyserver keyserver.ubuntu.com --recv-keys 9344B2AF Execute... gpg -a --export 9344B2AF | sudo apt-key add - The last two steps import my gpg key, so apt-get won't complain about non-authenticated repositories. Execute... sudo apt-get update Install tomee with... sudo apt-get install tomee-webprofile or... sudo apt-get install tomee-jaxrs or... sudo apt-get install tomee-plus or... sudo apt-get install tomee-plume It will install tomee under /var/lib/tomee-{classifier} []s, Thiago. On Thu, Apr 10, 2014 at 8:21 AM, Thiago Veronezi thi...@veronezi.orgwrote: Hi Daniel, Thanks for the changelog tip. It works like a charm! :) Regarding the dependencies on other packages: I'm still trying to get our package done. Once we have something good enough, I will try to use the libraries from other packages like tomcat and activemq. I will need to ping the package maintainers and try sync updates with them. Just for fun, these are the current lintian results... tveronezi@debianboto:~/dev/ws/tomee/trunk/tomee/tomee-deb$ lintian ./target/apache-tomee-plus-1.6.1-SNAPSHOT.deb E: tomee-plus: non-etc-file-marked-as-conffile var/lib/tomee-plus-1.6.1-SNAPSHOT/conf/openejb.conf E: tomee-plus: non-etc-file-marked-as-conffile var/lib/tomee-plus-1.6.1-SNAPSHOT/conf/server.xml E: tomee-plus: non-etc-file-marked-as-conffile var/lib/tomee-plus-1.6.1-SNAPSHOT/conf/tomcat-users.xml E: tomee-plus: non-etc-file-marked-as-conffile var/lib/tomee-plus-1.6.1-SNAPSHOT/conf/conf.d/cxf-rs.properties E: tomee-plus: non-etc-file-marked-as-conffile var/lib/tomee-plus-1.6.1-SNAPSHOT/conf/conf.d/cxf.properties E: tomee-plus: non-etc-file-marked-as-conffile var/lib/tomee-plus-1.6.1-SNAPSHOT/conf/conf.d/hsql.properties E: tomee-plus: no-copyright-file W: tomee-plus: extra-license-file usr/share/doc/tomee-plus-1.6.1-SNAPSHOT/LICENSE E: tomee-plus: init.d-script-does-not-implement-required-option etc/init.d/tomee-plus force-reload W: tomee-plus: codeless-jar usr/share/tomee-plus-1.6.1-SNAPSHOT/lib/tomcat-i18n-es.jar W: tomee-plus: codeless-jar usr/share/tomee-plus-1.6.1-SNAPSHOT/lib/tomcat-i18n-fr.jar W: tomee-plus: codeless-jar usr/share/tomee-plus-1.6.1-SNAPSHOT/lib/tomcat-i18n-ja.jar W: tomee-plus: codeless-jar usr/share/tomee-plus-1.6.1-SNAPSHOT/lib/tomee-webapp-1.6.1-SNAPSHOT.jar []s, Thiago. On Sun, Mar 30, 2014 at 11:56 AM, dsh daniel.hais...@gmail.com wrote: Hi Thiago, I suppose that is the constraint you have to deal with if you depend on others. Usually on Linux (or even commonly on Unix type of systems) it is uncommon, that every app ships it's own Java, app server or more generally it's own runtime env. That's why I did ask whether it's a self contained package or not. Additionally in cloud envirnments it might add additional constraints if each app comes with it's own runtime env. On the other that might even have some advantages in cloude environments. Probably something to be researched and/or discussed. Cheers Daniel On Sun, Mar 30, 2014 at 4:54 PM, Thiago Veronezi thi...@veronezi.org wrote: Hi Daniel, For now it is self contained, but I guess I would get one big REJECT if I submit it. One of the current violations is exactly that: packages shouldn't duplicate binaries. I was thinking about adding a dependency on libtomcat7 (or maybe tomcat7-common), but this would also add a dependency on how fast they publish their tomcat packages. For example, this developer is publishing tomcat7_7.0.52-1~bpo70+1 ( https://lists.debian.org/debian-java/2014/03/msg6.html) but apt still shows 7.0.28... ** tveronezi@debianboto:~/dev$ apt-cache show tomcat7 Package: tomcat7 Version: 7.0.28-4 Installed-Size: 351 Maintainer: Debian Java Maintainers pkg-java-maintain...@lists.alioth.debian.org Architecture: all Depends: tomcat7-common (= 7.0.28-4), ucf, adduser, debconf (= 0.5) | debconf-2.0 Recommends: authbind Suggests: tomcat7-docs (= 7.0.28-4), tomcat7-admin (= 7.0.28-4), tomcat7-examples (= 7.0.28-4), tomcat7-user (= 7.0.28-4), libtcnative-1 Description-en: Servlet and JSP engine Apache Tomcat implements the Java Servlet and the JavaServer Pages (JSP) specifications from Sun Microsystems, and provides a pure Java HTTP web server environment for Java code to run. . This package contains
Re: svn commit: r1593721 - in /tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb: ./ assembler/classic/ cdi/ core/ core/ivm/ core/mdb/
yeap... it's fixed. :) I've read that there are ~1M emails in backlog yet. Btw, thanks for fixing it! On May 16, 2014 8:29 PM, Romain Manni-Bucau rmannibu...@gmail.com wrote: Hi Isnt it fixed now? Mail delay? Le 16 mai 2014 01:03, Thiago Veronezi thi...@veronezi.org a écrit : Hi Romain, This is the revision that breaks the OpenEjbContainerTest that I mentioned earlier today. wdyt? []s, Thiago. On Sat, May 10, 2014 at 3:47 PM, rmannibu...@apache.org wrote: Author: rmannibucau Date: Sat May 10 19:47:21 2014 New Revision: 1593721 URL: http://svn.apache.org/r1593721 Log: trying to avoid to create local bean lazily which creates a bottleneck + thread safety in cdiplugin Modified: tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/BeanContext.java tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/assembler/classic/Assembler.java tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/cdi/CdiPlugin.java tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/core/BaseSessionContext.java tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/core/ivm/EjbHomeProxyHandler.java tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/core/mdb/EndpointFactory.java Modified: tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/BeanContext.java URL: http://svn.apache.org/viewvc/tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/BeanContext.java?rev=1593721r1=1593720r2=1593721view=diff == --- tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/BeanContext.java (original) +++ tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/BeanContext.java Sat May 10 19:47:21 2014 @@ -1816,4 +1816,16 @@ public class BeanContext extends Deploym private Class localInterface; private Method createMethod; } + +public static final class ProxyClass { +private final Class? proxy; + +public ProxyClass(final Class? proxy) { +this.proxy = proxy; +} + +public Class? getProxy() { +return proxy; +} +} } Modified: tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/assembler/classic/Assembler.java URL: http://svn.apache.org/viewvc/tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/assembler/classic/Assembler.java?rev=1593721r1=1593720r2=1593721view=diff == --- tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/assembler/classic/Assembler.java (original) +++ tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/assembler/classic/Assembler.java Sat May 10 19:47:21 2014 @@ -72,6 +72,7 @@ import org.apache.openejb.core.ServerFed import org.apache.openejb.core.SimpleTransactionSynchronizationRegistry; import org.apache.openejb.core.TransactionSynchronizationRegistryWrapper; import org.apache.openejb.core.WebContext; +import org.apache.openejb.core.ivm.IntraVmProxy; import org.apache.openejb.core.ivm.naming.ContextualJndiReference; import org.apache.openejb.core.ivm.naming.IvmContext; import org.apache.openejb.core.ivm.naming.IvmJndiFactory; @@ -124,6 +125,7 @@ import org.apache.openejb.util.SuperProp import org.apache.openejb.util.URLs; import org.apache.openejb.util.classloader.ClassLoaderAwareHandler; import org.apache.openejb.util.classloader.URLClassLoaderFirst; +import org.apache.openejb.util.proxy.LocalBeanProxyFactory; import org.apache.openejb.util.proxy.ProxyFactory; import org.apache.openejb.util.proxy.ProxyManager; import org.apache.webbeans.config.WebBeansContext; @@ -147,6 +149,7 @@ import javax.enterprise.context.Dependen import javax.enterprise.context.spi.CreationalContext; import javax.enterprise.inject.spi.Bean; import javax.enterprise.inject.spi.BeanManager; +import javax.jms.MessageListener; import javax.management.InstanceNotFoundException; import javax.management.MBeanRegistrationException; import javax.management.MBeanServer; @@ -1062,6 +1065,27 @@ public class Assembler extends Assembler beanContext.setMethodTransactionAttribute(entry.getKey(), TransactionType.Required); } } + +// if local bean or mdb generate proxy class now to avoid bottleneck on classloader later +if (beanContext.isLocalbean() ||
Re: default tomee credentials (WAS: [VOTE] TomEE 1.6.0.2...)
Does this effect me as a user of TomEE? Do I have to use that production mode or is it already enabled? Is that somewhere in the docs? -- View this message in context: http://openejb.979440.n4.nabble.com/default-tomee-credentials-WAS-VOTE-TomEE-1-6-0-2-tp4669261p4669341.html Sent from the OpenEJB Dev mailing list archive at Nabble.com.
Re: commit messages
+1 Le 16 mai 2014 18:27, David Blevins david.blev...@gmail.com a écrit : Maybe someone can update this document. Include the JIRA number and title (if there is a jira). I try never to say Fixed FOO-2543 all by itself. - http://tomee.apache.org/dev/tips-and-suggestions.html This was already the proposed and agreed commit message format from some years ago, but these things have a way of getting lost every few years as committers come and go. There's a handful of other guidelines on that page such as don't reformat code and make logic changes in the same commit, etc. Might be good to clean it up and get everyone to take a fresh look. -David On May 16, 2014, at 10:53 AM, Jean-Louis Monteiro jlmonte...@tomitribe.com wrote: +1 works fine for me. JLouis -- Jean-Louis Monteiro http://twitter.com/jlouismonteiro http://www.tomitribe.com On Fri, May 16, 2014 at 8:31 AM, Romain Manni-Bucau rmannibu...@gmail.comwrote: Hi guys, a quick message to try to normalize a bit commit messages (I blame nobody that's for me too ;) ). If working against a jira would be great to use (my proposal but can be discussed): [JIRA NAME] [short description in english] For instance: TOMEE- change default value foo attribute in tomee.xml Main goal is to avoid things like: working on TOMEE-4568 or https://issues.apache.org/jira/browse/TOMEE-8756; This is hard to re-browse history without textual description Romain Manni-Bucau Twitter: @rmannibucau Blog: http://rmannibucau.wordpress.com/ LinkedIn: http://fr.linkedin.com/in/rmannibucau Github: https://github.com/rmannibucau