OpenEJB custom configuration factory & bval.in-container=true

Hello, In *one* of the configuration factory constructors a system property is set: public ConfigurationFactory() { this(!shouldAutoDeploy()); System.setProperty("bval.in-container", "true"); } What do you think about moving this to system.properties ? The reason is that: * it's really

Re: OpenEJB custom configuration factory & bval.in-container=true

17-02-07 10:31 GMT+01:00 Svetlin Zarev <svetlin.angelov.za...@gmail.com > >: > > > Hello, > > > > In *one* of the configuration factory constructors a system property is > > set: > > > > public ConfigurationFactory() { > > this(

Customizing the dynamic deployer chain

Hello, I want to subclass the org.apache.openejb.config.ConfigurationFactory class in order to customize the deployer chain. Unfortunately the chain is constructed inside ConfigurationFactory(offline, preAutoConfigDeployer) constructor, so when I use the ConfigurationFactory(offline,

Re: Customizing the dynamic deployer chain

om/ > rmannibucau> | > LinkedIn <https://www.linkedin.com/in/rmannibucau> | JavaEE Factory > <https://javaeefactory-rmannibucau.rhcloud.com> > > 2017-02-27 14:40 GMT+01:00 Svetlin Zarev <svetlin.angelov.za...@gmail.com > >: > > > Hi, > > >

Re: Customizing the dynamic deployer chain

Hi, That event is fired too late :) When it's fired, the AutoConfig deployer has already created the datasource. Is there an event fired just before the AutoConfig deployer ? Kind regards, Svetlin 2017-02-24 16:23 GMT+02:00 Svetlin Zarev <svetlin.angelov.za...@gmail.com>: > This event

Re: OpenEJB/TomEE static code analysis

mainly for Java 8fy reasons. > > There are also several thousand places where the code may be rewritten > with > > java 8 constructions. > > > > Regards, > > > > Mitia > > > > 2016-09-14 10:35 GMT+03:00 Svetlin Zarev <svetlin.angelov.zarev@gmail. > com

OpenEJB/TomEE static code analysis

Dear TomEE developers, I've been running static code analysis (fortify) against TomEE 7 and as a result I have a list of more than 8000 potential issues (I hope most of them are false positives). Unfortunately I'm not allowed to share the list itself. Either way I'll have to go through that list

Re: OpenEJB/TomEE static code analysis

I've cleaned up the PR to make it more readable. I'll be grateful for any comments. Svetlin 2016-09-14 16:15 GMT+03:00 Svetlin Zarev <svetlin.angelov.za...@gmail.com>: > Hi, > > I think I've fixed[1] all stream leaks to files or streams opened by > classLoader.getRe

String equality checks in JAXB classes

Hi, The static code analysis revealed that in all JAXB classes strings are being compared using == and !=. Obviously TomEE works, so this is not such a big issue, but I cannot explain to myself why it works :) I know that the string literals are interned by default, but how do you guarantee that

Re: getResourceAsStream() for a folder

Hi, IMO this is a bug introduced with [1][2]. Although the root cause is in the bad impl. of FileResource [3] that ignores the IOException and despite the error, still returns a byte[] as if nothing bad happened. [1] https://bz.apache.org/bugzilla/show_bug.cgi?id=60146 [2]

Outdated/Junk PR

Hi, I constantly get notifications about [1], which is now more than 1.5 years old. It looks like some mistake - i.e to merge the 1.7.x into master., Github is regularly sending notifications to all watchers about it So what do you think about discarding & closing it ? [1]

Forgotten PRs

Hi, Would you consider merging [1] which fixes deployment issues in case of java 8 (it was approved by Romain last week) and [2] which adds a missing test scope to test dependency (approved last week by Romain and Jean-Louis). [1] https://github.com/apache/tomee/pull/84 [2]

Re: @PostConstruct and @PreDestrory

Hi, I'm not sure what will happen if the IvmContext is in read-only mode (i.e. openejb.forceReadOnlyAppNamingContext=true). You may-need to make the context writable before unbinding. Svetlin 2017-07-13 13:46 GMT+03:00 Jonathan Gallimore : > Hey folks > > I

TOMEE-2098: TomcatWebAppBuilder does not correctly handle the case when startInternal(StandardContext) fails

Hi, If the application configuration fails in TomcatWebAppBuilder.startInternal(StandardContext), the web app builder tries to "undeploy" the app, but this operation can never succeed because the StandardContext is in state STARTING_PREP, while this operation requires it to be in one of NEW,

Re: [PR] TOMEE-2087 IvmContext.list() does not correctly list the context content

Hi, Do you have any comments ? Do you thing that something is missing or maybe that something additional is needed ? Kind regards, Svetlin 2017-07-11 15:07 GMT+03:00 Romain Manni-Bucau <rmannibu...@gmail.com>: > 2017-07-11 12:38 GMT+02:00 Svetlin Zarev <svetlin.angelov.za.

Re: Forgotten PRs

t; > jlmonte...@tomitribe.com> wrote: > > > Hi, > > > > Thanks for pinging us here. > > I can merge both for you. > > > > Jean-Louis > > > > -- > > Jean-Louis Monteiro > > http://twitter.com/jlouismonteiro > > http://www.to

TOMEE-2102: IvmContext bind/unbind creates duplicate contexts

Hi, While i was trying to simplify my IvmTests I stubmbled on another bug in IvmContext - thi stime in bind()/unbind(). The issue is simple -> if bind()-ing from a "relative" node (for instance lets have "a/b/c", and you try to do b.bind(x, obj) instead of root.bind("a/b/x", obj)), bind() binds

Re: [jira] [Commented] (TOMEE-2102) IvmContext bind/unbind creates duplicate contexts

Zarev/tomee fixBindUndbind > >> > >> Alternatively you can review and apply these changes as the patch at: > >> > >> https://github.com/apache/tomee/pull/94.patch > >> > >> To close this pull request, make a commit to your master/trunk branch > &g

Re: [jira] [Commented] (TOMEE-2102) IvmContext bind/unbind creates duplicate contexts

u.wordpress.com> | Github <https://github.com/ > rmannibucau> | > LinkedIn <https://www.linkedin.com/in/rmannibucau> | JavaEE Factory > <https://javaeefactory-rmannibucau.rhcloud.com> > > 2017-07-20 13:42 GMT+02:00 Svetlin Zarev <svetlin.angelov.za...@gmail.com >

[PR] TOMEE-2102: IvmContext bind/unbind creates duplicate contexts

Hi, Yesterday the topic was hijaced by unrelated issues, so I'd like to restart the discussion. The issue is that bind() may create alternative NameNodes for the very same JNDI name, which results in issues such as being able to bind to objects to the same JNDI name, or being unable to lookup

Re: [PR] TOMEE-2102: IvmContext bind/unbind creates duplicate contexts

gt; > > Hi Svetlin, > > > > Many thanks for the writeup - really helpful. I'm reviewing now. > > > > Jon > > > > On Fri, Jul 21, 2017 at 12:43 PM, Svetlin Zarev < > > svetlin.angelov.za...@gmail.com> wrote: > > > >> Hi, &g

Re: [PR] TOMEE-2087 IvmContext.list() does not correctly list the context content

wordpress.com> | Github <https://github.com/ > rmannibucau> | > > LinkedIn <https://www.linkedin.com/in/rmannibucau> | JavaEE Factory > > <https://javaeefactory-rmannibucau.rhcloud.com> > > > > 2017-07-14 12:55 GMT+02:00 Svetlin Zarev <svetlin.

Re: AutoConfig - IllegalArgumentException: Comparison method violates its general contract!

n.com/in/rmannibucau> | JavaEE Factory > <https://javaeefactory-rmannibucau.rhcloud.com> > > 2017-07-04 9:38 GMT+02:00 Svetlin Zarev <svetlin.angelov.za...@gmail.com>: > > > Hi, > > > > I found a nasty bug in AutoConfig:2077. The comparator does not

AutoConfig - IllegalArgumentException: Comparison method violates its general contract!

Hi, I found a nasty bug in AutoConfig:2077. The comparator does not work correctly with java 8. In older java versions (older than 8), Collections.sort() always creates an array from the list content, while starting with java 8 -> it delegates to the sort() method implemented in the concrete list

Removing ANT from the packaged tomee distributions

Hi everyone! Recently CGLIB was added as a dependency to TomEE (commit id: 703e9770), and in turn it brought Apache Ant as "compile" dependency. Yet it's not used by cglib at runtime, so it shouldn't really be packaged in the final assembly. What do you think about excluding it from the packaged

7.0.4 release plans

Hi, Are there any plans for releasing 7.0.4 ? It has quite a lot of important fixes and it would be great to have them GA. Also tomcat in 7.0.3 is quite old (8.5.11) and there have been several security fixes in tomcat since then [1][2]. [1]

Re: 7.0.4 release plans

Blog > <http://rmannibucau.wordpress.com> | Github <https://github.com/ > rmannibucau> | > LinkedIn <https://www.linkedin.com/in/rmannibucau> | JavaEE Factory > <https://javaeefactory-rmannibucau.rhcloud.com> > > 2017-07-03 14:09 GMT+02:00 Svetlin Zarev <svetli

Re: Removing ANT from the packaged tomee distributions

;test" scope. Here is the PR: https://github.com/apache/tomee/pull/82 Bets regards, Svetlin 2017-07-03 14:09 GMT+03:00 Jean-Louis Monteiro <jlmonte...@tomitribe.com>: > If not needed I'm totally ok. > Can you submit a PR? > I'dbe happy to merge it for you > > > Le

Re: freeze OPENEJB jira project

Hi, You can remove all groups and project roles from the "Create Issue", "modify issue", add/edit comment etc permissions from the permission scheme of the project. Kind regards, Svetlin 2017-04-25 12:47 GMT+03:00 Romain Manni-Bucau : > Hi guys, > > anyone knows how to

Re: TOMEE-2057 fix proposal

> LinkedIn <https://www.linkedin.com/in/rmannibucau> | JavaEE Factory > <https://javaeefactory-rmannibucau.rhcloud.com> > > 2017-06-12 15:34 GMT+02:00 Svetlin Zarev <svetlin.angelov.za...@gmail.com > >: > > > I've added Arquilian test in arquillian-tomee-web

Using non-default JsonProvider

Hi, If the application brings its own JsonProvider, then JsonProvider.provider() should return it instead of the default one. Instead TomEE always returns the default one (Johnzon). The issue is that JsonProvider.doLoadProvider() returns the first encountered one and does not check if it's the

Re: Using non-default JsonProvider

t;https://www.linkedin.com/in/rmannibucau> | JavaEE Factory > <https://javaeefactory-rmannibucau.rhcloud.com> > > 2017-06-05 11:37 GMT+02:00 Svetlin Zarev <svetlin.angelov.za...@gmail.com > >: > > > Hi, > > > > If the application brings its own JsonProvider, the

Re: CompManagedBean & @DatasourceDefinition - TOMEE-2053

er.com/rmannibucau> | Blog > > <https://blog-rmannibucau.rhcloud.com> | Old Blog > > <http://rmannibucau.wordpress.com> | Github > > <https://github.com/rmannibucau> | LinkedIn > > <https://www.linkedin.com/in/rmannibucau> | JavaEE Factory > >

Re: CompManagedBean & @DatasourceDefinition - TOMEE-2053

;https://blog-rmannibucau.rhcloud.com> | Old Blog > <http://rmannibucau.wordpress.com> | Github <https://github.com/ > rmannibucau> | > LinkedIn <https://www.linkedin.com/in/rmannibucau> | JavaEE Factory > <https://javaeefactory-rmannibucau.rhcloud.com> > > 2017-06-16 15:2

Re: CompManagedBean & @DatasourceDefinition - TOMEE-2053

<https://twitter.com/rmannibucau> | Blog > <https://blog-rmannibucau.rhcloud.com> | Old Blog > <http://rmannibucau.wordpress.com> | Github <https://github.com/ > rmannibucau> | > LinkedIn <https://www.linkedin.com/in/rmannibucau> | JavaEE Factory > <h

Re: Any EE8 spec API releases needed?

Hi Mark, Have you considered fixing https://issues.apache.org/jira/browse/GERONIMO-6569 ? It's about common annotations spec compliance. Kind regards, SVetlin 2017-06-17 19:37 GMT+03:00 Mark Struberg : > Hi folks! > > I'm about to release the common-annotation-1.3

Re: TOMEE-2057 fix proposal

//github.com/ > rmannibucau> | > LinkedIn <https://www.linkedin.com/in/rmannibucau> | JavaEE Factory > <https://javaeefactory-rmannibucau.rhcloud.com> > > 2017-06-12 10:13 GMT+02:00 Svetlin Zarev <svetlin.angelov.za...@gmail.com > >: > > > Hi Everyone, Romain,

Re: TOMEE-2057 fix proposal

to use txn if you insist. 2017-06-12 11:36 GMT+03:00 Romain Manni-Bucau <rmannibu...@gmail.com>: > 2017-06-12 10:29 GMT+02:00 Svetlin Zarev <svetlin.angelov.za...@gmail.com > >: > > > > why not relying on the > > default? javax.transaction.Transaction.class.ca

Re: TOMEE-2057 fix proposal

OK, I'll update my PR. I want to write a test as well. In which project should I add it, so it's executed with both OpenJPA & Eclipse link ? 2017-06-12 11:43 GMT+03:00 Romain Manni-Bucau <rmannibu...@gmail.com>: > 2017-06-12 10:42 GMT+02:00 Svetlin Zarev <svetlin.angelov

Re: CompManagedBean & @DatasourceDefinition - TOMEE-2053

;https://twitter.com/rmannibucau> | Blog > <https://blog-rmannibucau.rhcloud.com> | Old Blog > <http://rmannibucau.wordpress.com> | Github <https://github.com/ > rmannibucau> | > LinkedIn <https://www.linkedin.com/in/rmannibucau> | JavaEE Factory > <https://j

CompManagedBean & @DatasourceDefinition - TOMEE-2053

Hi Everyone, What's the purpose of the org.apache.openejb.config.CompManagedBean ? I'm asking in the context of TOMEE-2053. I have a @DataSourceDefinition with some attributes which should be overrriden by ejb-jar.xml. Everithing works great, with the sole exception of CompManagedBean. It seems

Re: CompManagedBean & @DatasourceDefinition - TOMEE-2053

; | Github <https://github.com/ > rmannibucau> | > LinkedIn <https://www.linkedin.com/in/rmannibucau> | JavaEE Factory > <https://javaeefactory-rmannibucau.rhcloud.com> > > 2017-06-17 7:56 GMT+02:00 Svetlin Zarev <svetlin.angelov.za...@gmail.com>: > > > Hi,

Re: 7.0.4 release plans

Hi, I'd suggest to wait until https://bz.apache.org/bugzilla/show_bug.cgi?id=61450 is fixed or at least to get more info if it will be fixed in a recent release. Best regards, Svetlin 2017-08-15 14:12 GMT+03:00 Jonathan Gallimore : > Hi > > I'll give folks an

Re: [VOTE] Apache TomEE 7.0.4 - Roll 2

+0 It would be great if the tomcat dependency is updated to 8.5.21 because of the fixed regressions with the SSL configuration Kind regadrs, Svetlin 2017-09-27 0:24 GMT+03:00 Andy Gumbrecht : > Hi Everyone, > > I'd kindly like to ask you all to take a look at this

Re: Issue TOMEE-2063 not solved in TomEE 7.0.4?

Interceptor.Priority.PLATFORM_BEFORE has a value of 0. It's also a static and final [1] which makes it a "compile time constant expression" [2] So according to LJS 13.4.9-2 [3] the compiled annotation should not have any reference to Interceptor.Priority.PLATFORM_BEFORE. So 200 + 0 == 200, and

Re: Issue TOMEE-2063 not solved in TomEE 7.0.4?

Hi, The fix was pushed on 13 Jun [1] , so it is available in 7.0.4 [1] https://github.com/apache/tomee/commit/29c7594baff0161f358f1e6585fe36730d14f43c Kind regards, Svetlin 2017-11-09 14:34 GMT+02:00 Frankie : > Hello, > > it seems, the fix for the resolved Issue

Re: Kill JVM on deployment failure

Hi, For example this would not work if you have unsatisified resource-ref: 09-Nov-2017 09:38:59.118 SEVERE [localhost-startStop-1] org.apache.tomee.catalina.TomcatWebAppBuilder.startInternal Unable to deploy collapsed ear in war

Re: [VOTE] Release Apache TomEE 7.0.5 (round 2)

Hi, > If folks could reply to the original post with their +1 / 0 / -1 ... +1 [VOTE] Kind regards, Svetlin На вт, 10.07.2018 г. в 21:26 ч. Jonathan Gallimore < jonathan.gallim...@gmail.com> написа: > Hi Everyone, > > Here is the second roll of TomEE 7.0.5. Please can you take a look and >

Re: [VOTE] Apache TomEE 7.0.5

Hi, I've successfully built it as well (ubuntu + openjdk). I've triggered my tests, but they take 36h+ to complete :) I'll update you one they finish. Kind regards, Svetlin На ср, 4.07.2018 г. в 16:05 ч. Jonathan Gallimore < jonathan.gallim...@gmail.com> написа: > That test passes here: > >

Re: [ANNOUNCE] Welcome Roberto Cortez as new Apache TomEE committer

Congratulations! На вт, 11.09.2018 г. в 19:30 ч. Ivan Junckes Filho написа: > Well deserved, congratulations Roberto! > > On Tue, Sep 11, 2018 at 1:25 PM Bruno Baptista wrote: > > > Congratulations Roberto! > > > > Bruno Baptista > > http://twitter.com/brunobat_ > > > > > > On 10/09/2018