Deprecate /capabilities/{{name}}

2019-08-15 Thread ocket 8888
I recently marked a PR that rewrites the `/capabilities` endpoint in Go as ready for review (https://github.com/apache/trafficcontrol/pull/3870) and with it added handlers for PUT and DELETE. That means that `/capabilities/{{name}}` will no longer do anything that `/capabilities` does not, so is

Re: Deprecate /capabilities/{{name}}

2019-08-15 Thread Rawlin Peters
On Thu, Aug 15, 2019 at 1:01 PM Robert Butts wrote: > > >- don't bother converting `/capabilities/{{name}}` from Perl to Go > > But we still have to support those routes, until API 1.x is no longer > supported, which is far in the future. > > We should still rewrite deprecated Perl routes in Go,

Go Code Coverage Merge lib

2019-08-15 Thread Lavanya Bathina
Hi, I am using the below lib to merge the code coverage report from multiple runs. "github.com/wadey/gocovmerge" Based on the review, it seems there is specific way in which external libraries can be used or it needs approval. I am pretty new to the open source world. Seeking help to understand

Re: Deprecate /capabilities/{{name}}

2019-08-15 Thread Jeremy Mitchell
Can you elaborate on what "deprecate" actually means? Here's what i think it means: - don't bother converting `/capabilities/{{name}}` from Perl to Go and adding some kind of deprecation message to the `/capabilities/{{name}}` Perl response. On Thu, Aug 15, 2019 at 12:15 PM ocket wrote: >

Re: Deprecate /capabilities/{{name}}

2019-08-15 Thread Rawlin Peters
TO-Perl currently has full CRUD API support for both /capabilities and /api_capabilities. It seems to me like capabilities are statically-defined in terms of what the actual capabilities of the system are at the current version (via seeds.sql), so we don't really need API-level support for

Re: Deprecate /capabilities/{{name}}

2019-08-15 Thread Jeremy Mitchell
Maybe so I don't have to keep asking the question of what "deprecate" means to us, we should add it to https://cwiki.apache.org/confluence/display/TC/API+Guidelines so it's very clear how we handle deprecated routes. On Thu, Aug 15, 2019 at 12:54 PM Jeremy Mitchell wrote: > Can you elaborate on

Re: Deprecate /capabilities/{{name}}

2019-08-15 Thread Robert Butts
>- don't bother converting `/capabilities/{{name}}` from Perl to Go But we still have to support those routes, until API 1.x is no longer supported, which is far in the future. We should still rewrite deprecated Perl routes in Go, just so we can get rid of Perl sooner than that. On Thu, Aug

Re: Deprecate /capabilities/{{name}}

2019-08-15 Thread ocket 8888
Well, we've immediately derailed, lol. I just want to know if I can mark `/capabilities/{{name}}` as deprecated. But if we're going to discuss this immediately, here's my two cents: We've committed to API versioning. That means that you can't remove an endpoint that existed in version 1.x without