Re: [PROPOSAL] Remove "proxy.process" prefix from all core metrics

> On 18 Dec 2023, at 1:28 pm, Leif Hedstrom wrote: > > Through all our cleanup and refactoring in the past, as far as I can tell, > all metrics are now prefixed with proxy.process. > > This seems a little superfluous. I’d like to suggests one of two options: > > 1. Just drop the prefix

Re: Vote: Remove autotools build files from the repository (ATS 10)

> On 22 Oct 2023, at 10:50 am, James Peach wrote: > > Thanks Chris, that list is pretty helpful. > > BTW, the default cmake biuld doesn’t work on macOS: > > $ cmake -B build && make -j10 -C build > … > In file included from > /Users/jpeach/src/traffics

Re: Vote: Remove autotools build files from the repository (ATS 10)

=OFF) > —-enable-ccache > BUILD_NUMBER.> —-with-build-number > > > Sent with Proton Mail secure email. > > --- Original Message --- > On Thursday, October 19th, 2023 at 8:44 PM, James Peach > wrote: > > >> Could you please summ

Re: Vote: Remove autotools build files from the repository (ATS 10)

Could you please summarize the current state of the cmake work? Is there any documentation for users of how to switch from autotools to cmake? Are there any autotools build features that are not supported in cmake? FWIW I have builds that are using --prefix --with-user

Re: Proposal: TS API: Don' t require a DbgCtl instance of have a tag when constructed.

> On 6 Sep 2023, at 10:30 am, Walt Karas wrote: > > See https://github.com/apache/trafficserver/pull/10375 . There’s no description either here or in the PR; could you please explain the use case for this? thanks, James

Re: [E] Proposal: make utilities declared in Cleanup.h part of TS API

> On 2 Sep 2023, at 3:44 am, Masakazu Kitajo wrote: > >> Its a judgement call, how much to minimize the API. > > Yes, that's why we send API proposals on the dev list. And I don't think > I'm absolutely right. If we, as a community, want to have utilities as TS > API, that's what we should

Re: TS API Proposal: TS_FETCH_FLAGS_SKIP_REMAP

> On 4 Aug 2023, at 1:45 am, Masakazu Kitajo wrote: > > Hi, > > I'd like to propose a new flag for FetchSM that'd allow making HTTP > requests for other servers without remap rules regardless of ATS > configuration (proxy.config.url_remap.remap_required). Could you achieve the same result

Re: [proposal] Minimum supported version for openssl is 1.1.1 for ATS 10.

somewhere listing the current minimum versions? > > — Leif > > > >> On Jun 24, 2023, at 20:41, James Peach wrote: >> >>  >> >>> On 24 Jun 2023, at 2:52 am, Chris McFarlen wrote: >>> >>> As part of updating the build system

Re: [proposal] Minimum supported version for openssl is 1.1.1 for ATS 10.

> On 24 Jun 2023, at 2:52 am, Chris McFarlen wrote: > > As part of updating the build system to cmake we are looking for areas to > simplify the build. One area could be the conditional checks and preprocessor > defines around features added to openssl on or before 1.1.1. This email is to

Re: [Discussion/Proposal] Regex support in sni.yaml

.io" and "amc.swoc.io"). Yup there are various ways to redesign the feature to improve lookup performance, but I expect they would all be breaking changes to existing config. > -Original Message- > From: James Peach > Sent: Monday, June 19, 2023 12:09 AM > To:

Re: [Discussion/Proposal] Regex support in sni.yaml

IIUC, the regex is used to match a policy configuration based on the requested hostname (either inbound or outbound). This means that the matching doesn’t need to be constrained by wildcard certificate semantics. It’s not made explicit in the documentation, but it looks like the policy match

Re: [E] Proposal for TS API in 9.2.1: Remove TSSslSecretXxx functions

Susan that said Y! have production plugins using these APIs? > > On Thu, Apr 27, 2023 at 12:17 AM James Peach wrote: > >> >> >>> On 27 Apr 2023, at 1:52 pm, Walt Karas >> wrote: >>> >>> Everything I know is in this issue: >>>

Re: [E] Proposal for TS API in 9.2.1: Remove TSSslSecretXxx functions

e link to #9587 in your original email wasn’t enough for me :) > > On Wed, Apr 26, 2023 at 9:48 PM James Peach wrote: > >> >> >>> On 25 Apr 2023, at 1:01 pm, Walt Karas >> wrote: >>> >>> >> https://urldefense.com/v3/__

Re: Proposal for TS API in 9.2.1: Remove TSSslSecretXxx functions

> On 25 Apr 2023, at 1:01 pm, Walt Karas wrote: > > https://github.com/apache/trafficserver/pull/9587 indicates they do not > work. There are no definite plans to fix them. So, seems they are > unlikely to be fixed before the release of 9.2.1. Fixing or removing them > in 10.0 is a related

Re: [PROPOSAL] Rename ssl_server_name.yaml to sni.yaml

> On May 31, 2019, at 9:39 AM, Randall Meyer > wrote: > > I'd like to rename ssl_server_name.yaml to sni.yaml for ATS 9. This would > also affect the toplevel key in the yaml config file (making the contents > rooted under "sni"). The code/classes it is used to configure is SNIConfig. >

Re: [PROPOSAL] Move from the IRC to Slack

be able to join and participate unless they have some out of band way to ask for an invite? If that’s the case, I don’t think this is a good idea. > > Cheers, > > — Leif > > >> On May 11, 2019, at 23:26, James Peach wrote: >> >> >> >>&g

Re: [PROPOSAL] Move from the IRC to Slack

> On May 12, 2019, at 4:57 AM, Evan Zelkowitz wrote: > > +1 > > Though it would be nice if there was an easier way to get new people > in rather than having to manually invite them. My only worry is people > who just want to ask a question dont have an easy way to be able to > get in. So

Re: API Proposal: TSThreadSetCancelState, TSThreadSetCancelType, TSThreadCancel, TSThreadJoin

> On Feb 28, 2019, at 9:17 AM, Fei Deng wrote: > > void TSThreadSetCancelState(TSThread thread, int state); > void TSThreadSetCancelType(TSThread thread, int type); I guess you are supposed to pass PTHREAD_CANCEL_* for type type parameter? I don't like how this leaks the pthread

Re: free lists 2.0

> On Dec 10, 2018, at 9:08 AM, Walt Karas wrote: > > It's a matter of intuition how much free lists improve TS performance, Is it? Can you benchmark with the -f and -F flags to verify the effect of free lists and the proxy allocator? J

Re: [PROPOSAL] Kill traffic_cop for ATS v8.0.0

> On May 7, 2018, at 4:28 AM, Leif Hedstrom wrote: > > Hi all, > > I’d like to propose that we kill off traffic_cop for ATS v8.0.0. The > consensus is that there are better system level tools to manage health checks > out of band like it does. Do you mean a local service

Re: API proposal: TSReturnCode TSSslOCSPCallbackSet(TSSslContext ctx)

we >> already >>>> have the OCSP query,response and caching mechanism are already in ATS, >> the >>>> developer can choose to use this callback for OCSP stapling. Otherwise >> the >>>> whole OCSP part has to rewritten in the plugin. We hav

Re: API proposal: TSReturnCode TSSslOCSPCallbackSet(TSSslContext ctx)

> On Mar 27, 2018, at 12:45 PM, Persia Aziz > wrote: > > TSReturnCode TSSslOCSPCallbackSet(TSSslContext ctx) > TSSslOCSPCallbackSet sets the OCSP callback described in ATS What does "sets the OCSP callback described in ATS" mean? If I'm writing a plugin why

Re: Proposed new ts api calls

> On Jan 30, 2018, at 9:15 AM, Walt Karas wrote: > > Revised: > > const char *TSRemapFromUrlStringGet(const TSHttpTxn txnp, int ); > > const char *TSRemapToUrlStringGet(const TSHttpTxn txnp, int ); > > These would return, from the transaction state object, >

Re: [DISCUSS] Move pagespeed plugin to the Pagespeed Incubator project

> On Jan 16, 2018, at 11:11 AM, Leif Hedstrom wrote: > > Hi all, > > The Pagespeed project recently moved from Google over to the Apache > Incubator! I’d like to move our ATS plugin over to their project for v8.0. > This is simply to make it a lot easier to build, and

Re: [API] Change TSHttpArgs to split reserved indices for TXN and SSN args.

> On Dec 1, 2017, at 2:39 PM, Alan Carroll > wrote: > > As discussed in issue #2883, based on work in issue #2388, I would like to > split the TXN and SSN plugin argument index reservations. Currently nothing > in the TS code base uses SSN plugin args

Re: API Proposal - TSStatGet/SetString

7f6f2f8c36ba in start_thread (arg=0x7f6f2d222700) at > pthread_create.c:333 >#16 0x7f6f2eb543dd in clone () at > ../sysdeps/unix/sysv/linux/x86_64/clone.S:109 > >still, pretty much the same, just easier to read > &g

Re: API Proposal - TSStatGet/SetString

l appropriately. FWIW, stats and configuration records are all backed by the same internal subsystem, so they are basically the same thing internally. Configuration values are either TS_RECORDTYPE_CONFIG or TS_RECORDTYPE_LOCAL; other record types are metrics. > > On 11/7/17, 10:46 AM, &

Re: API Proposal - TSStatGet/SetString

> On Nov 7, 2017, at 8:35 AM, Zelkowitz, Evan > wrote: > > Proposing adding stat string support > > TSReturnCode TSStatGetString(int id, char *string, int len); > TSReturnCode TSStatSetString(int id, char *string, int len); > > This way we can store stat strings

Re: Proxy Protocol Discussion

> On Oct 26, 2017, at 2:34 PM, Steven R. Feltner wrote: > > Following up on our recent, brief discussion in IRC on Tuesday regarding > implementing Proxy Protocol in ATS… > > After pressing for more requirements, it turns out my use case is similar to > unixwitch. In

Re: [Dependency Proposal] intel::tbb

> On Sep 29, 2017, at 7:37 AM, Derek Dagit wrote: > > 3) Does it run on platforms that are supported by ATS, like FreeBSD? I > thought there was not official support without patching it, but not > sure. https://www.threadingbuildingblocks.org/system-requirements

Re: #pragma once

void the kind of never-ending transition we have seen with this kind of thing in the past. > > > > On Monday, July 31, 2017, 9:54:59 AM CDT, Jason Kenny > <jke...@yahoo-inc.com.INVALID> wrote: > > I want to bump this again. I started moving to this already. How

Re: autests broken?

ms potentially confusing, such that people / > package owners builds and installs it (but I know we can make them > non-installed targets, so maybe not a huge deal). I’d suggest an —-enable-test-plugins that works just like —enable-example-plugins. > >> On Jul 23, 2017, at 3:17 PM

Re: autests broken?

> On Jul 23, 2017, at 2:03 PM, Alan M. Carroll > wrote: > > Susan fixed this in PR 2291. Thanks. I verified that this fixed it for me. For posterity, the error can be found here: [jpeach@sk1 _setup_tmp_RunCommand_0]$ pwd

autests broken?

Hi all, I am unable to get autest tests to run succesfully on my Fedora26 box. I’m running the ci/regression script, which builds and runs all the tests. This doesn’t fail in jenkins so there must be some non-obvious thing wrong here. AFAICT tsxs fails for some reason that is not captured by

Re: [PROPOSAL] Formalize requirements of new configuration files (and major changes to existing files)

> On Jul 21, 2017, at 3:59 AM, Leif Hedstrom wrote: > > Hi all, > > to avoid further ossification, I’d like to propose the following: > > 1. All new configuration files *must* be done using Lua syntax (with the > appropriate file extension) I think in the previous thread

Re: Help with collapsed_connection plugin.

> On Jun 23, 2017, at 12:44 AM, John Rushford wrote: > > Leif, > > The mutex is ref counted but the i look at the code for TSContDestroy, I > see that the pointer to the mutex is only set to NULL, > INKContInternal::destroy(). I think that the plugins should call >

Re: [apache/trafficserver] HTTP2 drain (#1710)

On 11 Jun 2017, at 4:45, Masakazu Kitajo wrote: On Sun, Jun 11, 2017 at 1:27 PM, James Peach <jpe...@apache.org> wrote: On 9 May 2017, at 0:02, Masakazu Kitajo wrote: Hi, Don't worry guys. I'm working on it. I merged the PR to have a draining (shedding) logic for HTTP/2 (

Re: [apache/trafficserver] HTTP2 drain (#1710)

c_ctl to manage the process and do the upgrade. 2. traffic_ctl --drain can only support HTTP and it can only be used when restarting ATS. That makes it hardly useful in our use case. 2017-05-08 22:16 GMT-07:00 James Peach <jpe...@apache.org>: On 8 May 2017, at 21:48, Miles Libbey wrote: We'd

Re: [apache/trafficserver] remove bad check for configuration directory override (kill it with fire) (#2090)

ifies the change and the motivation behind it. Also as far as I know we don't use the -C option as well.. but maybe Evil Dave knows if it is used at all. It does sound like a useful item. Jason On ‎Wednesday‎, ‎June‎ ‎7‎, ‎2017‎ ‎10‎:‎18‎:‎29‎ ‎PM‎ ‎CDT, James Peach <jpe...@apache.org> wrote: On J

Re: Milestones / Labels / Assignes

On 8 Jun 2017, at 18:01, Leif Hedstrom wrote: On Jun 8, 2017, at 6:53 PM, Leif Hedstrom wrote: We are doing very poorly on marking PRs with appropriate Milestones and labels. From hereon, please do *NOT* merge a PR which does not have the appropriate labels / Milestones.

Re: [apache/trafficserver] remove bad check for configuration directory override (kill it with fire) (#2090)

> On Jun 7, 2017, at 6:15 PM, dragon512 wrote: > > @jpeach I don't know about the -D options. I did not test to see if -D works > or not ( I would assumed you guy had tested it already). This patch enables the -D option in the generic option parsing, so I assumed

Re: [trafficserver] branch master updated: remove bad check

> On Jun 7, 2017, at 12:49 PM, dra...@apache.org wrote: > > This is an automated email from the ASF dual-hosted git repository. > > dragon pushed a commit to branch master > in repository https://gitbox.apache.org/repos/asf/trafficserver.git > > > The following commit(s) were added to

consistent whitespace between functions

Hi all, I’m starting to see code written like this, with no empty line between functions: void foo() { } void bar() { } I would like to be consistent about keeping a single empty line between functions, even inline in class definitions. The extra whitespace makes it easier to read and to

Re: [trafficserver] branch master updated: Update testing extensions

On 3 Jun 2017, at 7:42, dra...@apache.org wrote: > This is an automated email from the ASF dual-hosted git repository. > > dragon pushed a commit to branch master > in repository https://gitbox.apache.org/repos/asf/trafficserver.git > > The following commit(s) were added to refs/heads/master by

Re: [trafficserver] branch master updated: Add logic to flush gcov data from traffic_server on interrupt.

It seems pretty unlikely that __gcov_flush() is async signal safe so we can't safely call it from a signal handler. #1937 is trying to fix the shutdown sequence so this kind of thing can be done safely. > On May 30, 2017, at 2:32 PM, shinr...@apache.org wrote: > > This is an automated email

Re: broken tests on master?

DeveloperYahoo! Inc.Champaign, Illinois On Saturday, May 27, 2017 5:51 PM, James Peach <jpe...@apache.org> wrote: On 27 May 2017, at 15:26, James Peach wrote: Hi all, The remap_http autest case seems to be broken on master: [jpeach@sk1 trafficserver]$ ./tests/autest.sh --ats-bin=/opt/a

Re: broken tests on master?

On 27 May 2017, at 15:26, James Peach wrote: Hi all, The remap_http autest case seems to be broken on master: [jpeach@sk1 trafficserver]$ ./tests/autest.sh --ats-bin=/opt/ats/bin Running Test basic:. Passed Running Test basic-cop:. Passed Running Test basic-manager:. Passed Running Test

broken tests on master?

Hi all, The remap_http autest case seems to be broken on master: [jpeach@sk1 trafficserver]$ ./tests/autest.sh --ats-bin=/opt/ats/bin Running Test basic:. Passed Running Test basic-cop:. Passed Running Test basic-manager:. Passed Running Test cache-generation-clear:.. Passed Running Test

Re: New PR Review Process

On 16 May 2017, at 19:42, Phil Sorber wrote: One of the things that was accomplished at the ATS Summits over the past several days (in addition to clearing up many many Coverity issues) was getting the build system integration with GitHub fixed up. We now have real commit status updates

protected github master branch?

Hi all, I tried to commit #1986 this morning: $ git push Counting objects: 12, done. Delta compression using up to 8 threads. Compressing objects: 100% (12/12), done. Writing objects: 100% (12/12), 1.42 KiB | 0 bytes/s, done. Total 12 (delta 11), reused 0 (delta 0) remote: Resolving deltas:

Re: [trafficserver] branch master updated: Removes the tsqa tests, to avoid confusion. Use autest.

On 24 May 2017, at 18:12, zw...@apache.org wrote: This is an automated email from the ASF dual-hosted git repository. zwoop pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/trafficserver.git The following commit(s) were added to refs/heads/master by this

Re: Unit Test Framework

On 24 May 2017, at 15:00, Alan Carroll wrote: James; it's precisely because those tests don't depend on anything else in traffic_server that it seems bogus to require building and running it to do the tests. If you're in a tight edit/compile/test cycle it's nice to not have to drag in

Re: Unit Test Framework

;> somehow behind). >> >> >> >>> Do these run as part of regressions now? >> >> Cachekey plugin TSQA tests are not part of the regression since by the >> time they were created/finished our TSQA regression tests were broken and >> not being run an

Re: Unit Test Framework

On 20 May 2017, at 20:12, gan...@apache.org wrote: Hi trafficserver-dev, (1) I was wondering if we have any preference for a C/C++ unit test framework in the ATS community. Background and thoughts: I needed a unit test framework quickly to do TDD in order to deliver the AWS auth v4 (PR

Re: Reloading remap.config without restarting trafficserver

On 17 May 2017, at 15:54, Nishant Gaurav wrote: Hi everyone, I work as a part of Traffic team at LinkedIn. Our team has a use case where we want to reload ‘remap.config’ without restarting trafficserver. I understand that I can use ‘traffic_ctl config reload’ command for the same, but we

Re: [apache/trafficserver] HTTP2 drain (#1710)

and it can only be used when restarting ATS. That makes it hardly useful in our use case. 2017-05-08 22:16 GMT-07:00 James Peach <jpe...@apache.org>: On 8 May 2017, at 21:48, Miles Libbey wrote: We'd also like a bit more fine grained control in the process -- we frequently wa

Re: [apache/trafficserver] HTTP2 drain (#1710)

this would mean allowing the --drain option to apply to traffic_Ctl server stop. Yes I agree that draining make sense for stop as well as restart. miles On Mon, May 8, 2017 at 8:19 PM, James Peach <jpe...@apache.org> wrote: This patch adds another separate shutdown mechanism that only works for

Re: [apache/trafficserver] HTTP2 drain (#1710)

This patch adds another separate shutdown mechanism that only works for HTTP/2. I think that we really ought to have a single, well-defined graceful shutdown that works for all protocols. In HTTP/1.1 it works like this: - You (possibly dynamically) set

Re: Naming conventions for "lua" style configuration files

> On Feb 26, 2017, at 10:35 PM, Shu Kit Chan wrote: > > Hi, > > We had recently converted the the custom log and metrics configuration > files to lua (in 7.0.0 and 6.2.0 release respectively). In doing so, > we came up with new configuration file names as well. i.e >

Re: TS LUA Plugin

> On Feb 1, 2017, at 5:29 PM, Eric Friedrich (efriedri) > wrote: > > Thanks Kit- > One top level question, maybe more directed at use of LUA is how to generate > a unique ID or number inside of a plugin. I’ve checked the docs and don’t see > any C++ bindings from TS

Re: benchmark ATS

> On Dec 13, 2016, at 12:45 AM, Di Li wrote: > > Hey Guys, > > When I doing some benchmark for outbound proxy, and has http_cache enabled, > well, first of all, the performance are pretty low, I guess I didn’t do it > right with the cache enabled, 2nd when I use wrk to have

Re: Help tsqa and libcffi-devel

> On Dec 2, 2016, at 9:01 AM, Marie Griffiths > wrote: > > Hi, > I am new to the list and am trying to run the integration tests in tsqa but > cannot seem to find the libcffi-devel package. > A link to the rpm would be useful. What Linux distribution are you

Re: Multiple times gzip issue and TSHttpTxnHookAdd API

> On Nov 29, 2016, at 11:38 AM, Meera Mosale Nataraja wrote: > > Hello all, > > I'm working on TS-5024 where > the content is gzip’ed multiple times. Please find the sample output > provided below which indicates multiple

Re: [trafficserver] branch master updated: TS-5063: Fixes coverity warnings and cleans up the temp string

> On Nov 27, 2016, at 2:19 PM, zw...@apache.org wrote: > > This is an automated email from the ASF dual-hosted git repository. > > zwoop pushed a commit to branch master > in repository https://git-dual.apache.org/repos/asf/trafficserver.git > > The following commit(s) were added to

Re: Config variable source values

> On Nov 22, 2016, at 6:25 AM, Alan Carroll > wrote: > > "If `proxy.config.james` supersedes the old configuration, I should not have > to explicitly specify it in records.config for that to work" > Correct. And if the administrator specifies no

Re: Config variable source values

> On Nov 21, 2016, at 2:36 PM, Alan Carroll > wrote: > > Sudheer - this was originally put in (TS-3650) precisely so we could add / > change configuration values on point releases, so that in particular LTS > releases could be tweaked to accept next

Re: Config variable source values

default and “foo=1” as “I actually mean it. I can’t even imagine how we would document the behaviour of plugins or configuration settings that take advantage of this. > > On Monday, November 21, 2016 3:37 PM, James Peach <jpe...@apache.org> > wrote: > > > &

Re: Config variable source values

or a built in it is >> detectable if the value is in records.config, but not detectable for a >> plugin created variable. >> >> On Monday, November 21, 2016 2:34 PM, James Peach <jpe...@apache.org> >> wrote: >> >> >> >>

Re: Config variable source values

you are addressing here? > > >On Monday, November 21, 2016 12:21 PM, James Peach <jpe...@apache.org> > wrote: > > > >> On Nov 21, 2016, at 9:14 AM, Alan Carroll >> <solidwallofc...@yahoo-inc.com.INVALID> wrote: >> >> REC_SOURCE_EXPLIC

Re: Config variable source values

me. The value was set in a configuration file and is being consumed by a plugin. >On Monday, November 21, 2016 10:29 AM, James Peach <jpe...@apache.org> > wrote: > > > >> On Nov 21, 2016, at 7:20 AM, Alan Carroll >> <solidwallofc...@yahoo-inc.com

Re: Config variable source values

> On Nov 21, 2016, at 7:20 AM, Alan Carroll > wrote: > > The config variable sourcing data was originally put in to be able to detect > that a variable was set even if that setting was the same as the default > (otherwise this is impossible to reliably

Re: New protocol plugin prior to HTTP session

> On Nov 9, 2016, at 8:22 PM, Assaf Cohen wrote: > > I am trying to write a new protocol plugin ( proprietary ) that will run > prior to HTTP transaction, > and will invoke full HTTP logic as if it accepted a new connection. > Is there example I can look at? or some other

Re: Configurations in ssl_multicert.config

> On Nov 8, 2016, at 1:17 PM, Leif Hedstrom wrote: > > Hi all, > > I know this has been discussed many times before, but it keeps coming back to > bite me in ugly ways. Right now, there’s no way (other than plugin code) to > make TLS behave differently based on the SSL

Re: RTD instance

> On Nov 7, 2016, at 1:53 PM, Leif Hedstrom wrote: > > Hi all, > > I think it’d be best to delete the ReadTheDoc instance, because 1) it’s not > up to date (stale) and 2) it can’t build our current sphinx docs anyways. > > My fear is that we serve stale versions of the

Re: parent.config documentation questions

> On Nov 3, 2016, at 3:09 PM, John Rushford wrote: > > Miles, > > The weight parameter was added as part of the consistent hash feature added > to parent selection with TS-2996. It was never intended for the other > round robin strategies. > > yes, for round robin =

Re: [VOTE] Release Apache Traffic Server 7.0.0 (RC2)

+1 Regressions on OS X 10.11.6 Forward proxy on Fedora 24 > On Oct 28, 2016, at 2:19 PM, Bryan Call wrote: > > I've prepared a release for 7.0.0 (RC2) which is the next major version of > Apache Traffic Server. This version breaks binary compatibility and plugins > will

Re: ATS PMC chair person changes

> On Oct 19, 2016, at 11:53 AM, Leif Hedstrom wrote: > > Hi everyone, > > I have decided it’s time to change PMC chair for the ATS project, so > effective immediately, I’m no longer the it. Please congratulate and support > our new PMC Chair and VP of the Apache Traffic

Re: [trafficserver] branch master updated: TS-4858: fix memory leak problem of global_default_keyblock

> On Oct 17, 2016, at 3:53 PM, shinr...@apache.org wrote: > > This is an automated email from the ASF dual-hosted git repository. > > shinrich pushed a commit to branch master > in repository https://git-dual.apache.org/repos/asf/trafficserver.git > > The following commit(s) were added to

RFC: stop using recursive make.

Hi all, Leif suggested we move away from using recursive make to improve the parallel build. I’ve posted a pull request to show what this could look like. In most cases, we would need to use per-target compiler flags, or radically simplify

Re: RFC: convert from NULL tp nullptr

pthread_t (which is an integral type in glibc). I added ink_thread_null() to capture the platform-specific value for this (pretty sure 0 is never a valid pthread_t on any platform). > > -- Leif > >> On Oct 16, 2016, at 9:15 AM, James Peach <jpe...@apache.org> wrote: >> >

RFC: convert from NULL tp nullptr

Hi all, I’ve posted a RFC pull request that converts all uses of NULL to nullptr. The primary motivation for this is that there are circumstances (primarily template usage) where nullptr is required to detect the difference between a null

Re: [trafficserver] branch master updated: Fix possibility of NULL assignment to std::string

> On Oct 2, 2016, at 5:36 PM, sor...@apache.org wrote: > > This is an automated email from the ASF dual-hosted git repository. > > sorber pushed a commit to branch master > in repository https://git-dual.apache.org/repos/asf/trafficserver.git > > The following commit(s) were added to

Re: github rebase merging

up with a confusing concatenation of commit messages. Of course, the committer could do a manual merge and clean it all up, but I'd recommend polishing the branch for presentation after addressing any review feedback. J > > Thanks, > Peter > > -Original Message- > F

Re: github rebase merging

> On Sep 26, 2016, at 12:24 PM, Leif Hedstrom <zw...@apache.org> wrote: > >> >> On Sep 26, 2016, at 12:34 PM, Bryan Call <bc...@apache.org> wrote: >> >> +1 - Glad to see they are doing this. >> >> -Bryan >> >> >> >

github rebase merging

Hi all, Github just released a new "rebase merging" feature, which makes merging PRs as clean as doing the merge by hand. See https://github.com/blog/2243-rebase-and-merge-pull-requests. I'd like to propose that we always "rebase merge" PRs. There may be occasions where we would not do this,

Re: Issue with collpased_forwarding plugin

> On Sep 22, 2016, at 7:01 AM, BONUMAHANTI, RAJENDRA KISHORE > wrote: > > Hi, > > I am testing collapsed_forwarding plugin > (https://docs.trafficserver.apache.org/en/latest/admin-guide/plugins/collapsed_forwarding.en.html?highlight=collapsed_forwarding) > via ATS 6.2.x

Re: [trafficserver] 01/01: Merge pull request #968 from shinrich/ts-3046

> On Sep 8, 2016, at 11:48 AM, shinr...@apache.org wrote: > > This is an automated email from the ASF dual-hosted git repository. > > shinrich pushed a commit to branch master > in repository https://git-dual.apache.org/repos/asf/trafficserver.git > > commit

Re: "Anonymous" PRs

> On Sep 10, 2016, at 12:23 PM, Leif Hedstrom wrote: > > >> On Sep 10, 2016, at 1:15 PM, Leif Hedstrom wrote: >> >> Hi all, >> >> we’re seeing a fair number of PRs with the following information: >> >> Commit: GitHub >>

Re: TS-4703 && PR-829

> On Sep 9, 2016, at 2:22 PM, Alan Carroll > <solidwallofc...@yahoo-inc.com.INVALID> wrote: > > 1. So why the output array then? > > >On Friday, September 9, 2016 1:19 PM, James Peach <jpe...@apache.org> > wrote: > > > >> On Sep 9

Re: TS-4703 && PR-829

he tag to search for, using an anchored prefix search.result - > optional return value for the tag found (if NULL the found tag is not > returned). How many results can you get? > > >On Friday, September 9, 2016 12:18 PM, James Peach <jpe...@apache.org> > wro

Re: TS-4703 && PR-829

> On Sep 9, 2016, at 10:15 AM, Susan Hinrichs > <shinr...@network-geographics.com> wrote: > > > > On 9/9/2016 12:01 PM, James Peach wrote: >>> On Sep 9, 2016, at 9:39 AM, Susan Hinrichs >>> <shinr...@network-geographics.com> wr

Re: TS-4703 && PR-829

> On Sep 9, 2016, at 9:39 AM, Susan Hinrichs > wrote: > > I'd like to propose a slight tweak for TSHttpTxnClientProtocolStackContains > and TSHttpSsnClientProtocolStackContains > > Replace the tag argument with two explicit input and output arguments, e.g. >

Re: [API REVIEW] TSVConnInternalSet

> On Sep 8, 2016, at 7:55 AM, Sudheer Vinukonda > <sudheervinuko...@yahoo.com.INVALID> wrote: > > > >> On Sep 7, 2016, at 10:09 PM, James Peach <jpe...@apache.org> wrote: >> >> >>> On Sep 7, 2016, at 9:16 PM, Sudheer Vin

Re: [API REVIEW] TSVConnInternalSet

> On Sep 7, 2016, at 9:16 PM, Sudheer Vinukonda > <sudheervinuko...@yahoo.com.INVALID> wrote: > > > >> On Sep 7, 2016, at 8:48 PM, James Peach <jpe...@apache.org> wrote: >> >> >>> On Sep 7, 2016, at 8:30 PM, Sudheer Vinukonda >

Re: [API REVIEW] TSVConnInternalSet

ifics. That would be great, because I’m struggling to see the special case here :) > > >> On Sep 7, 2016, at 7:38 PM, James Peach <jpe...@apache.org> wrote: >> >> >>> On Sep 7, 2016, at 6:39 PM, Sudheer Vinukonda >>> <sudheervinuko...

Re: [API REVIEW] TSVConnInternalSet

ot extensible in any meaningful way (I’d argue it is totally broken). Are you referring to the TS_FETCH_FLAGS_STREAM flag? That doesn’t apply here because there’s no API change for TSFetchUrl. > >> On Sep 7, 2016, at 6:27 PM, James Peach <jpe...@apache.org> wrote: >> >> &

Re: [API REVIEW] TSVConnInternalSet

ers (Connection/Keep Alive) and some special handling for POST > method etc. This API may expose problems from that code. I don’t think this is any different from allowing SPDY or HTTP/2 to mark their transactions as non-internal. > > Thanks, > > Sudheer > >> On Se

[API REVIEW] TSVConnInternalSet

Hi all, It is common to write protocol plugins that accept a non-HTTP protocol and generate HTTP request using TSHttpConnectWithPluginId(). In this case, although the HTTP transaction is technically an internal transaction, it is logically external since it is generated directly on behalf of

initial code coverage report

Hi all, I just committed the ci/coverage, which runs the tests (not tsqa though) and generates a coverage report using lcov. You can see the initial report here . As you can see there’s some room for improvement :-/ Leif, can we put our heads

Re: [trafficserver] branch master updated (f8718b7 -> 43e0be5)

> On Aug 24, 2016, at 2:47 PM, Leif Hedstrom <zw...@apache.org> wrote: > > >> On Aug 24, 2016, at 11:31 AM, James Peach <jpe...@apache.org> wrote: >> >> I'm having second thoughts about this. There's currently no replacement for >> the SWR plug

  1   2   3   4   5   6   7   8   >