[GitHub] [incubator-tubemq] gosonzhang merged pull request #94: [TUBEMQ-156] Update for README.md
gosonzhang merged pull request #94: URL: https://github.com/apache/incubator-tubemq/pull/94 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-tubemq] gosonzhang commented on pull request #94: [TUBEMQ-156] Update for README.md
gosonzhang commented on pull request #94: URL: https://github.com/apache/incubator-tubemq/pull/94#issuecomment-635096866 Thanks @Technoboy- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (TUBEMQ-149) Some of the consumers stop consuming their corresponding partitions and never release the partition to others
[ https://issues.apache.org/jira/browse/TUBEMQ-149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17118227#comment-17118227 ] Guocheng Zhang commented on TUBEMQ-149: --- Thanks [~marklaw]，I'll close this issue. > Some of the consumers stop consuming their corresponding partitions and never > release the partition to others > - > > Key: TUBEMQ-149 > URL: https://issues.apache.org/jira/browse/TUBEMQ-149 > Project: Apache TubeMQ > Issue Type: Bug >Reporter: Mark Law >Assignee: Guocheng Zhang >Priority: Critical > Labels: pull-request-available > Fix For: 0.3.0, 0.5.0 > > Attachments: screenshot-1.png > > > We have experienced issues while we consuming a topic for a while, some of > the consumers will wait forever and stop consuming from Tube. > The problem here is the corresponding partitions are being held and it will > not trigger any repartition, therefore messages would be delayed in these > partitions while the others are OK. > > We have faced this issue in both 3.5.x and 3.8.x version recently, however we > have used Tube for months and never have this issue before. > Another point here is we have 100+ topics and many consumers, only a few > consumer groups are having this issue. > It is hard to reproduce since it just happened randomly. > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (TUBEMQ-149) Some of the consumers stop consuming their corresponding partitions and never release the partition to others
[ https://issues.apache.org/jira/browse/TUBEMQ-149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17118225#comment-17118225 ] Mark Law commented on TUBEMQ-149: - We have not seen the same issue happened again since upgrading to Goson's patch. Thanks! > Some of the consumers stop consuming their corresponding partitions and never > release the partition to others > - > > Key: TUBEMQ-149 > URL: https://issues.apache.org/jira/browse/TUBEMQ-149 > Project: Apache TubeMQ > Issue Type: Bug >Reporter: Mark Law >Assignee: Guocheng Zhang >Priority: Critical > Labels: pull-request-available > Fix For: 0.3.0, 0.5.0 > > Attachments: screenshot-1.png > > > We have experienced issues while we consuming a topic for a while, some of > the consumers will wait forever and stop consuming from Tube. > The problem here is the corresponding partitions are being held and it will > not trigger any repartition, therefore messages would be delayed in these > partitions while the others are OK. > > We have faced this issue in both 3.5.x and 3.8.x version recently, however we > have used Tube for months and never have this issue before. > Another point here is we have 100+ topics and many consumers, only a few > consumer groups are having this issue. > It is hard to reproduce since it just happened randomly. > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [incubator-tubemq] aloyszhang commented on pull request #102: [TUBEMQ-160] Improve the protocol between Broker and Master
aloyszhang commented on pull request #102: URL: https://github.com/apache/incubator-tubemq/pull/102#issuecomment-635041320 +1 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Assigned] (TUBEMQ-160) Improve the protocol between Broker and Master
[ https://issues.apache.org/jira/browse/TUBEMQ-160?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guocheng Zhang reassigned TUBEMQ-160: - Assignee: Guocheng Zhang > Improve the protocol between Broker and Master > -- > > Key: TUBEMQ-160 > URL: https://issues.apache.org/jira/browse/TUBEMQ-160 > Project: Apache TubeMQ > Issue Type: Sub-task >Reporter: Guocheng Zhang >Assignee: Guocheng Zhang >Priority: Major > Labels: pull-request-available > > Based on the need for storage improvement, first adjust the definition of the > message fields of Broker and Master. In order to avoid affecting the use of > everyone, the new changes will be distinguished by version number, and the > final delivery content will be adjusted again. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (TUBEMQ-160) Improve the protocol between Broker and Master
[ https://issues.apache.org/jira/browse/TUBEMQ-160?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated TUBEMQ-160: -- Labels: pull-request-available (was: ) > Improve the protocol between Broker and Master > -- > > Key: TUBEMQ-160 > URL: https://issues.apache.org/jira/browse/TUBEMQ-160 > Project: Apache TubeMQ > Issue Type: Sub-task >Reporter: Guocheng Zhang >Priority: Major > Labels: pull-request-available > > Based on the need for storage improvement, first adjust the definition of the > message fields of Broker and Master. In order to avoid affecting the use of > everyone, the new changes will be distinguished by version number, and the > final delivery content will be adjusted again. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (TUBEMQ-34) Some screenshots in user-guide page contain Chinese characters
[ https://issues.apache.org/jira/browse/TUBEMQ-34?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17117850#comment-17117850 ] Guangxu Cheng commented on TUBEMQ-34: - Hi [~dbhaskaran], thank you for your contribution, I have assgined this issue to you and added you to the list of contributors，enjoy your trip. > Some screenshots in user-guide page contain Chinese characters > -- > > Key: TUBEMQ-34 > URL: https://issues.apache.org/jira/browse/TUBEMQ-34 > Project: Apache TubeMQ > Issue Type: Bug >Reporter: Xiang Li >Assignee: Deepak Bhaskaran >Priority: High > > I noticed some screenshots in > [https://tubemq.apache.org/en-us/docs/tubemq_user_guide.html] contain Chinese > characters. > Better to change them, which would be more friendly to users/developers whose > mother language is not Chinese. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [incubator-tubemq] gosonzhang opened a new pull request #102: [TUBEMQ-160] Improve the protocol between Broker and Master
gosonzhang opened a new pull request #102: URL: https://github.com/apache/incubator-tubemq/pull/102 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (TUBEMQ-160) Improve the protocol between Broker and Master
Guocheng Zhang created TUBEMQ-160: - Summary: Improve the protocol between Broker and Master Key: TUBEMQ-160 URL: https://issues.apache.org/jira/browse/TUBEMQ-160 Project: Apache TubeMQ Issue Type: Sub-task Reporter: Guocheng Zhang Based on the need for storage improvement, first adjust the definition of the message fields of Broker and Master. In order to avoid affecting the use of everyone, the new changes will be distinguished by version number, and the final delivery content will be adjusted again. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (TUBEMQ-34) Some screenshots in user-guide page contain Chinese characters
[ https://issues.apache.org/jira/browse/TUBEMQ-34?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guangxu Cheng reassigned TUBEMQ-34: --- Assignee: Deepak Bhaskaran > Some screenshots in user-guide page contain Chinese characters > -- > > Key: TUBEMQ-34 > URL: https://issues.apache.org/jira/browse/TUBEMQ-34 > Project: Apache TubeMQ > Issue Type: Bug >Reporter: Xiang Li >Assignee: Deepak Bhaskaran >Priority: High > > I noticed some screenshots in > [https://tubemq.apache.org/en-us/docs/tubemq_user_guide.html] contain Chinese > characters. > Better to change them, which would be more friendly to users/developers whose > mother language is not Chinese. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (TUBEMQ-110) Optimize Broker storage to increase throughput
[ https://issues.apache.org/jira/browse/TUBEMQ-110?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guocheng Zhang reassigned TUBEMQ-110: - Assignee: Guocheng Zhang > Optimize Broker storage to increase throughput > -- > > Key: TUBEMQ-110 > URL: https://issues.apache.org/jira/browse/TUBEMQ-110 > Project: Apache TubeMQ > Issue Type: Task >Reporter: Guocheng Zhang >Assignee: Guocheng Zhang >Priority: Major > Labels: features, performance > > I think the current Broker's read and write performance still has a > relatively large room for improvement. We need to continue to iterate to > improve the storage performance of the system. I have listed some > considerations and hope to get some better suggestions: > 1. Data read and write operations should consider the characteristics of the > disk, for example, the disk is based on 512-byte sectors as its storage unit, > and read data in batches of 64k; the file system will eliminate the cache > according to certain rules Pages in memory etc. If the read and write > operations take these contents into account, I believe that the current TPS > can be higher; > 2. Storage should consider the problem of fragmentation of disk space, such > as pre-allocation of fixed-length files and reuse of aging files to enable > continuous reading of disk files and improve data read and write speed; > 3. The number of memory cache blocks should be configurable: the current > memory cache is managed according to the fixed configuration of 2 memory > blocks per topic. We should allow the business to build more memory cache > space based on actual resource conditions; > 4. More effective memory-to-disk operation: At present, the flashing > operation is to flash messages from the memory to the disk one by one for > storage. This block can be adjusted to write to the disk in batches according > to the memory block, thereby improving storage efficiency; > 5. Remove the SSD auxiliary consumption function: Because the SSD disk > capacity is too small, the SSD storage consumption is not suitable for > practical applications, so it should be removed to avoid user confusion, and > related configurations and settings need to be cleaned up; > 6. The stored file should increase the content of the file header, including > the data version information, in order to facilitate the subsequent storage > scheme is still seamlessly compatible with the data format of the old version; > 7. Add CheckPoint check mechanism: the current system will only check the > validity of the last file when it is restarted. In fact, when the system is > shut down, there may be multiple consecutive files still in memory, the > practice that only the last file is checked currently is easy to cause > abnormal mixing into the data stream, we should add CheckPoint mechanism to > improve this abnormal situation. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [incubator-tubemq] gosonzhang commented on a change in pull request #97: [TUBEMQ-141] Remove the requirement to provide localHostIP
gosonzhang commented on a change in pull request #97:
URL: https://github.com/apache/incubator-tubemq/pull/97#discussion_r431196936
##
File path:
tubemq-core/src/main/java/org/apache/tubemq/corebase/utils/AddressUtils.java
##
@@ -130,4 +137,50 @@ public static String getRemoteAddressIP(Channel channel) {
}
return strRemoteIP;
}
+
+public static Enumeration listNetworkInterface() {
+try {
+return NetworkInterface.getNetworkInterfaces();
+} catch (SocketException e) {
+throw new AddressException(e);
+}
+}
+
+public static String getIPV4LocalAddress() {
+try {
+return doGetIPV4LocalAddress();
+} catch (SocketException | UnknownHostException e) {
+String errorMsg = "Unable to obtain local IP, please check if the
local network is normal";
+throw new AddressException(errorMsg, e);
+}
+}
+
+private static String doGetIPV4LocalAddress() throws SocketException,
UnknownHostException {
+Enumeration enumeration =
NetworkInterface.getNetworkInterfaces();
+
+while (enumeration.hasMoreElements()) {
+NetworkInterface networkInterface = enumeration.nextElement();
+if ("docker0".equals(networkInterface.getName()) ||
!networkInterface.isUp()) {
Review comment:
Need to add NetworkInterface isLoopback() status judgment
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [incubator-tubemq] gosonzhang commented on a change in pull request #97: [TUBEMQ-141] Remove the requirement to provide localHostIP
gosonzhang commented on a change in pull request #97:
URL: https://github.com/apache/incubator-tubemq/pull/97#discussion_r431195106
##
File path:
tubemq-core/src/main/java/org/apache/tubemq/corebase/utils/AddressUtils.java
##
@@ -34,31 +39,33 @@ public static synchronized String getLocalAddress() throws
Exception {
return localIPAddress;
}
-public static boolean validLocalIp(String currLocalHost) throws Exception {
+public static synchronized void setLocalAddress(String localIPAddress) {
+AddressUtils.localIPAddress = localIPAddress;
+}
+
+public static boolean validLocalIp(String currLocalHost) {
Review comment:
The validLocalIp function seems to be superfluous and should be removed
along with the sub-functions
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [incubator-tubemq] gosonzhang commented on a change in pull request #97: [TUBEMQ-141] Remove the requirement to provide localHostIP
gosonzhang commented on a change in pull request #97:
URL: https://github.com/apache/incubator-tubemq/pull/97#discussion_r431195383
##
File path:
tubemq-core/src/main/java/org/apache/tubemq/corebase/utils/AddressUtils.java
##
@@ -34,31 +40,29 @@ public static synchronized String getLocalAddress() throws
Exception {
return localIPAddress;
}
-public static boolean validLocalIp(String currLocalHost) throws Exception {
+public static boolean validLocalIp(String currLocalHost) {
if (TStringUtils.isNotEmpty(localIPAddress)
&& localIPAddress.equals(currLocalHost)) {
return true;
}
-Enumeration allInterface =
NetworkInterface.getNetworkInterfaces();
-if (allInterface == null) {
-throw new Exception("Get NetworkInterfaces is null");
-}
+
+Enumeration allInterface = listNetworkInterface();
+
return checkValidIp(allInterface, currLocalHost);
}
-private static boolean checkValidIp(Enumeration
allInterface,
-String currLocalHost) throws Exception
{
-String localIp = null;
+private static boolean checkValidIp(Enumeration
allInterface, String currLocalHost) {
Review comment:
ok！
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [incubator-tubemq] gosonzhang merged pull request #99: [TUBEMQ-159] Fix some typos
gosonzhang merged pull request #99: URL: https://github.com/apache/incubator-tubemq/pull/99 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (TUBEMQ-159) Fix some typos
[ https://issues.apache.org/jira/browse/TUBEMQ-159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17117753#comment-17117753 ] Neo Yang commented on TUBEMQ-159: - Thanks for the comment. [~technoboy] I added a list of typos to the JIRA description. [~gosonzhang] I have received comments and I have replied to you in PR. > Fix some typos > -- > > Key: TUBEMQ-159 > URL: https://issues.apache.org/jira/browse/TUBEMQ-159 > Project: Apache TubeMQ > Issue Type: Bug >Reporter: Neo Yang >Priority: Normal > Labels: pull-request-available > > Fix some typos in Apache TubeMQ Project. > *In file "LICENSE":* > * Componnents -> Components > * Copyrighy -> Copyright > *In file "docs/http_access_API_definition.md":* > * allowBCleintRatio -> allowedBClientRate > * modfiyUser -> modifyUser > * Modfiy -> Modify > *In file "resources/assets/scripts/brokerDetail.js":* > * getCheckeBox -> getCheckBox > * Tipc -> Topic > *In file "resources/assets/scripts/brokerList.js":* > * Tipc -> Topic > *In file "resources/assets/scripts/subscribe.js":* > * Tipc -> Topic > *In file "resources/assets/scripts/subscribeDetail.js":* > * Tipc -> Topic > *In file "resources/assets/scripts/common/helper.js":* > * reutrns -> Returns > *In file "resources/assets/scripts/topicDetail.js":* > * getCheckeBox -> getCheckBox > * Tipc -> Topic > *In file > "tubemq-client/src/main/java/org/apache/tubemq/client/consumer/BaseMessageConsumer.java":* > * Chekc -> Check > * reblance -> rebalance > *In file > "tubemq-client/src/main/java/org/apache/tubemq/client/producer/SimpleMessageProducer.java":* > * META_MAX_MESSAGEG_DATA_SIZE -> META_MAX_MESSAGE_DATA_SIZE > *In file > "tubemq-core/src/main/java/org/apache/tubemq/corebase/TBaseConstants.java":* > * META_MAX_MESSAGEG_DATA_SIZE -> META_MAX_MESSAGE_DATA_SIZE > * META_MAX_MESSAGEG_HEADER_SIZE -> META_MAX_MESSAGE_HEADER_SIZE > *In file > "tubemq-server/src/main/java/org/apache/tubemq/server/broker/BrokerServiceServer.java":* > * META_MAX_MESSAGEG_DATA_SIZE -> META_MAX_MESSAGE_DATA_SIZE > *In file > "tubemq-server/src/main/java/org/apache/tubemq/server/broker/msgstore/disk/MsgFileStatisInfo.java":* > * CFG_STORE_STATS_MAX_REFRESH_DURATITON -> > CFG_STORE_STATS_MAX_REFRESH_DURATION > *In file > "tubemq-server/src/main/java/org/apache/tubemq/server/broker/msgstore/mem/MsgMemStatisInfo.java":* > * CFG_STORE_STATS_MAX_REFRESH_DURATITON -> > CFG_STORE_STATS_MAX_REFRESH_DURATION > *In file > "tubemq-server/src/main/java/org/apache/tubemq/server/broker/msgstore/mem/MsgMemStore.java":* > * META_MAX_MESSAGEG_DATA_SIZE -> META_MAX_MESSAGE_DATA_SIZE > *In file > "tubemq-server/src/main/java/org/apache/tubemq/server/broker/utils/DataStoreUtils.java":* > * META_MAX_MESSAGEG_DATA_SIZE -> META_MAX_MESSAGE_DATA_SIZE > *In file > "tubemq-server/src/main/java/org/apache/tubemq/server/broker/web/BrokerAdminServlet.java":* > * messge -> message > * failue -> failure > *In file > "tubemq-server/src/main/java/org/apache/tubemq/server/common/TServerConstants.java":* > * CFG_STORE_STATS_MAX_REFRESH_DURATITON -> > CFG_STORE_STATS_MAX_REFRESH_DURATION > *In file > "tubemq-server/src/main/java/org/apache/tubemq/server/common/offsetstorage/zookeeper/RecoverableZooKeeper.java":* > * idemnpotent -> idempotent > *In file > "tubemq-server/src/main/java/org/apache/tubemq/server/common/offsetstorage/zookeeper/ZKUtil.java":* > * DEFAULT_ZOOKEPER_CLIENT_PORT -> DEFAULT_ZOOKEEPER_CLIENT_PORT > *In file > "tubemq-server/src/main/java/org/apache/tubemq/server/common/utils/WebParameterUtils.java":* > * reqAuthorizenCheck -> reqAuthorizeCheck > * *In file > "tubemq-server/src/main/java/org/apache/tubemq/server/master/TMaster.java":* > * requredPartMap -> requiredPartMap > * neet -> need > *In file > "tubemq-server/src/main/java/org/apache/tubemq/server/master/balance/DefaultLoadBalancer.java":* > * isRebalanCheckPrint -> isRebalanceCheckPrint > *In file > "tubemq-server/src/main/java/org/apache/tubemq/server/master/nodemanage/nodebroker/BrokerSyncStatusInfo.java":* > * CFG_REPORT_DEFAULT_SYNC_DURATITON -> CFG_REPORT_DEFAULT_SYNC_DURATION > *In file > "tubemq-server/src/main/java/org/apache/tubemq/server/master/nodemanage/nodeconsumer/ConsumerBandInfo.java":* > * rebalanCheckPrint -> rebalanceCheckPrint > * isRebalanCheckPrint -> isRebalanceCheckPrint > *In file > "tubemq-server/src/main/java/org/apache/tubemq/server/master/web/action/screen/Webapi.java":* > * reqAuthorizenCheck -> reqAuthorizeCheck > * rebanceCheckTime -> rebalanceCheckTime > * existedTopicCondtions -> existedTopicConditions > *In file > "tubemq-server/src/main/java/org/apache/tubemq/server/master/web/handler/WebAdminFlowRuleHandler.java":* > * reqAuthorizenCheck -> reqAuthorizeCheck > *In file >
[jira] [Updated] (TUBEMQ-159) Fix some typos
[ https://issues.apache.org/jira/browse/TUBEMQ-159?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neo Yang updated TUBEMQ-159: Description: Fix some typos in Apache TubeMQ Project. *In file "LICENSE":* * Componnents -> Components * Copyrighy -> Copyright *In file "docs/http_access_API_definition.md":* * allowBCleintRatio -> allowedBClientRate * modfiyUser -> modifyUser * Modfiy -> Modify *In file "resources/assets/scripts/brokerDetail.js":* * getCheckeBox -> getCheckBox * Tipc -> Topic *In file "resources/assets/scripts/brokerList.js":* * Tipc -> Topic *In file "resources/assets/scripts/subscribe.js":* * Tipc -> Topic *In file "resources/assets/scripts/subscribeDetail.js":* * Tipc -> Topic *In file "resources/assets/scripts/common/helper.js":* * reutrns -> Returns *In file "resources/assets/scripts/topicDetail.js":* * getCheckeBox -> getCheckBox * Tipc -> Topic *In file "tubemq-client/src/main/java/org/apache/tubemq/client/consumer/BaseMessageConsumer.java":* * Chekc -> Check * reblance -> rebalance *In file "tubemq-client/src/main/java/org/apache/tubemq/client/producer/SimpleMessageProducer.java":* * META_MAX_MESSAGEG_DATA_SIZE -> META_MAX_MESSAGE_DATA_SIZE *In file "tubemq-core/src/main/java/org/apache/tubemq/corebase/TBaseConstants.java":* * META_MAX_MESSAGEG_DATA_SIZE -> META_MAX_MESSAGE_DATA_SIZE * META_MAX_MESSAGEG_HEADER_SIZE -> META_MAX_MESSAGE_HEADER_SIZE *In file "tubemq-server/src/main/java/org/apache/tubemq/server/broker/BrokerServiceServer.java":* * META_MAX_MESSAGEG_DATA_SIZE -> META_MAX_MESSAGE_DATA_SIZE *In file "tubemq-server/src/main/java/org/apache/tubemq/server/broker/msgstore/disk/MsgFileStatisInfo.java":* * CFG_STORE_STATS_MAX_REFRESH_DURATITON -> CFG_STORE_STATS_MAX_REFRESH_DURATION *In file "tubemq-server/src/main/java/org/apache/tubemq/server/broker/msgstore/mem/MsgMemStatisInfo.java":* * CFG_STORE_STATS_MAX_REFRESH_DURATITON -> CFG_STORE_STATS_MAX_REFRESH_DURATION *In file "tubemq-server/src/main/java/org/apache/tubemq/server/broker/msgstore/mem/MsgMemStore.java":* * META_MAX_MESSAGEG_DATA_SIZE -> META_MAX_MESSAGE_DATA_SIZE *In file "tubemq-server/src/main/java/org/apache/tubemq/server/broker/utils/DataStoreUtils.java":* * META_MAX_MESSAGEG_DATA_SIZE -> META_MAX_MESSAGE_DATA_SIZE *In file "tubemq-server/src/main/java/org/apache/tubemq/server/broker/web/BrokerAdminServlet.java":* * messge -> message * failue -> failure *In file "tubemq-server/src/main/java/org/apache/tubemq/server/common/TServerConstants.java":* * CFG_STORE_STATS_MAX_REFRESH_DURATITON -> CFG_STORE_STATS_MAX_REFRESH_DURATION *In file "tubemq-server/src/main/java/org/apache/tubemq/server/common/offsetstorage/zookeeper/RecoverableZooKeeper.java":* * idemnpotent -> idempotent *In file "tubemq-server/src/main/java/org/apache/tubemq/server/common/offsetstorage/zookeeper/ZKUtil.java":* * DEFAULT_ZOOKEPER_CLIENT_PORT -> DEFAULT_ZOOKEEPER_CLIENT_PORT *In file "tubemq-server/src/main/java/org/apache/tubemq/server/common/utils/WebParameterUtils.java":* * reqAuthorizenCheck -> reqAuthorizeCheck * *In file "tubemq-server/src/main/java/org/apache/tubemq/server/master/TMaster.java":* * requredPartMap -> requiredPartMap * neet -> need *In file "tubemq-server/src/main/java/org/apache/tubemq/server/master/balance/DefaultLoadBalancer.java":* * isRebalanCheckPrint -> isRebalanceCheckPrint *In file "tubemq-server/src/main/java/org/apache/tubemq/server/master/nodemanage/nodebroker/BrokerSyncStatusInfo.java":* * CFG_REPORT_DEFAULT_SYNC_DURATITON -> CFG_REPORT_DEFAULT_SYNC_DURATION *In file "tubemq-server/src/main/java/org/apache/tubemq/server/master/nodemanage/nodeconsumer/ConsumerBandInfo.java":* * rebalanCheckPrint -> rebalanceCheckPrint * isRebalanCheckPrint -> isRebalanceCheckPrint *In file "tubemq-server/src/main/java/org/apache/tubemq/server/master/web/action/screen/Webapi.java":* * reqAuthorizenCheck -> reqAuthorizeCheck * rebanceCheckTime -> rebalanceCheckTime * existedTopicCondtions -> existedTopicConditions *In file "tubemq-server/src/main/java/org/apache/tubemq/server/master/web/handler/WebAdminFlowRuleHandler.java":* * reqAuthorizenCheck -> reqAuthorizeCheck *In file "tubemq-server/src/main/java/org/apache/tubemq/server/master/web/handler/WebAdminGroupCtrlHandler.java":* * reqAuthorizenCheck -> reqAuthorizeCheck * confgiuredTopicSet -> configuredTopicSet *In file "tubemq-server/src/main/java/org/apache/tubemq/server/master/web/handler/WebAdminTopicAuthHandler.java":* * reqAuthorizenCheck -> reqAuthorizeCheck *In file "tubemq-server/src/main/java/org/apache/tubemq/server/master/web/handler/WebBrokerDefConfHandler.java":* * oldManagStatus -> oldManageStatus * reqAuthorizenCheck -> reqAuthorizeCheck * inBrokerConfEntiyMap -> inBrokerConfEntityMap *In file "tubemq-server/src/main/java/org/apache/tubemq/server/master/web/handler/WebBrokerTopicConfHandler.java":*
[jira] [Updated] (TUBEMQ-159) Fix some typos
[ https://issues.apache.org/jira/browse/TUBEMQ-159?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neo Yang updated TUBEMQ-159: Description: Fix some typos in Apache TubeMQ Project. *In file "LICENSE":* * Componnents -> Components * Copyrighy -> Copyright *In file "docs/http_access_API_definition.md":* * allowBCleintRatio -> allowedBClientRate * modfiyUser -> modifyUser * Modfiy -> Modify *In file "resources/assets/scripts/brokerDetail.js":* * getCheckeBox -> getCheckBox * Tipc -> Topic *In file "resources/assets/scripts/brokerList.js":* * Tipc -> Topic *In file "resources/assets/scripts/subscribe.js":* * Tipc -> Topic *In file "resources/assets/scripts/subscribeDetail.js":* * Tipc -> Topic *In file "resources/assets/scripts/common/helper.js":* * reutrns -> Returns *In file "resources/assets/scripts/topicDetail.js":* * getCheckeBox -> getCheckBox * Tipc -> Topic *In file "tubemq-client/src/main/java/org/apache/tubemq/client/consumer/BaseMessageConsumer.java":* * Chekc -> Check * reblance -> rebalance *In file "tubemq-client/src/main/java/org/apache/tubemq/client/producer/SimpleMessageProducer.java":* * META_MAX_MESSAGEG_DATA_SIZE -> META_MAX_MESSAGE_DATA_SIZE *In file "tubemq-core/src/main/java/org/apache/tubemq/corebase/TBaseConstants.java":* * META_MAX_MESSAGEG_DATA_SIZE -> META_MAX_MESSAGE_DATA_SIZE * META_MAX_MESSAGEG_HEADER_SIZE -> META_MAX_MESSAGE_HEADER_SIZE *In file "tubemq-server/src/main/java/org/apache/tubemq/server/broker/BrokerServiceServer.java":* * META_MAX_MESSAGEG_DATA_SIZE -> META_MAX_MESSAGE_DATA_SIZE *In file "tubemq-server/src/main/java/org/apache/tubemq/server/broker/msgstore/disk/MsgFileStatisInfo.java":* * CFG_STORE_STATS_MAX_REFRESH_DURATITON -> CFG_STORE_STATS_MAX_REFRESH_DURATION *In file "tubemq-server/src/main/java/org/apache/tubemq/server/broker/msgstore/mem/MsgMemStatisInfo.java":* * CFG_STORE_STATS_MAX_REFRESH_DURATITON -> CFG_STORE_STATS_MAX_REFRESH_DURATION *In file "tubemq-server/src/main/java/org/apache/tubemq/server/broker/msgstore/mem/MsgMemStore.java":* * META_MAX_MESSAGEG_DATA_SIZE -> META_MAX_MESSAGE_DATA_SIZE *In file "tubemq-server/src/main/java/org/apache/tubemq/server/broker/utils/DataStoreUtils.java":* * META_MAX_MESSAGEG_DATA_SIZE -> META_MAX_MESSAGE_DATA_SIZE *In file "tubemq-server/src/main/java/org/apache/tubemq/server/broker/web/BrokerAdminServlet.java":* * messge -> message * failue -> failure *In file "tubemq-server/src/main/java/org/apache/tubemq/server/common/TServerConstants.java":* * CFG_STORE_STATS_MAX_REFRESH_DURATITON -> CFG_STORE_STATS_MAX_REFRESH_DURATION *In file "tubemq-server/src/main/java/org/apache/tubemq/server/common/offsetstorage/zookeeper/RecoverableZooKeeper.java":* * idemnpotent -> idempotent *In file "tubemq-server/src/main/java/org/apache/tubemq/server/common/offsetstorage/zookeeper/ZKUtil.java":* * DEFAULT_ZOOKEPER_CLIENT_PORT -> DEFAULT_ZOOKEEPER_CLIENT_PORT *In file "tubemq-server/src/main/java/org/apache/tubemq/server/common/utils/WebParameterUtils.java":* * reqAuthorizenCheck -> reqAuthorizeCheck * *In file "tubemq-server/src/main/java/org/apache/tubemq/server/master/TMaster.java":* * requredPartMap -> requiredPartMap * neet -> need *In file "tubemq-server/src/main/java/org/apache/tubemq/server/master/balance/DefaultLoadBalancer.java":* * isRebalanCheckPrint -> isRebalanceCheckPrint *In file "tubemq-server/src/main/java/org/apache/tubemq/server/master/nodemanage/nodebroker/BrokerSyncStatusInfo.java":* * CFG_REPORT_DEFAULT_SYNC_DURATITON -> CFG_REPORT_DEFAULT_SYNC_DURATION *In file "tubemq-server/src/main/java/org/apache/tubemq/server/master/nodemanage/nodeconsumer/ConsumerBandInfo.java":* * rebalanCheckPrint -> rebalanceCheckPrint * isRebalanCheckPrint -> isRebalanceCheckPrint *In file "tubemq-server/src/main/java/org/apache/tubemq/server/master/web/action/screen/Webapi.java":* * reqAuthorizenCheck -> reqAuthorizeCheck * rebanceCheckTime -> rebalanceCheckTime * existedTopicCondtions -> existedTopicConditions *In file "tubemq-server/src/main/java/org/apache/tubemq/server/master/web/handler/WebAdminFlowRuleHandler.java":* * reqAuthorizenCheck -> reqAuthorizeCheck *In file "tubemq-server/src/main/java/org/apache/tubemq/server/master/web/handler/WebAdminGroupCtrlHandler.java":* * reqAuthorizenCheck -> reqAuthorizeCheck * confgiuredTopicSet -> configuredTopicSet *In file "tubemq-server/src/main/java/org/apache/tubemq/server/master/web/handler/WebAdminTopicAuthHandler.java":* * reqAuthorizenCheck -> reqAuthorizeCheck *In file "tubemq-server/src/main/java/org/apache/tubemq/server/master/web/handler/WebBrokerDefConfHandler.java":* * oldManagStatus -> oldManageStatus * reqAuthorizenCheck -> reqAuthorizeCheck * inBrokerConfEntiyMap -> inBrokerConfEntityMap *In file "tubemq-server/src/main/java/org/apache/tubemq/server/master/web/handler/WebBrokerTopicConfHandler.java":* *
[jira] [Commented] (TUBEMQ-159) Fix some typos
[ https://issues.apache.org/jira/browse/TUBEMQ-159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17117676#comment-17117676 ] Guocheng Zhang commented on TUBEMQ-159: --- [~cku328] I made a review of the PR 99. For the modification of the interface parameter file, the modification of the interface parameter and compatibility issues need to be considered. I think the parameters of the interface can be modified separately > Fix some typos > -- > > Key: TUBEMQ-159 > URL: https://issues.apache.org/jira/browse/TUBEMQ-159 > Project: Apache TubeMQ > Issue Type: Bug >Reporter: Neo Yang >Priority: Normal > Labels: pull-request-available > > Fix some typos in Apache TubeMQ Project. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (TUBEMQ-158) nextWithAuthInfo2B status should be managed independently according to Broker
[ https://issues.apache.org/jira/browse/TUBEMQ-158?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guocheng Zhang resolved TUBEMQ-158. --- Fix Version/s: 0.5.0 Resolution: Fixed > nextWithAuthInfo2B status should be managed independently according to Broker > - > > Key: TUBEMQ-158 > URL: https://issues.apache.org/jira/browse/TUBEMQ-158 > Project: Apache TubeMQ > Issue Type: Bug >Reporter: Guocheng Zhang >Assignee: Guocheng Zhang >Priority: Normal > Labels: pull-request-available > Fix For: 0.5.0 > > Attachments: image-2020-05-26-20-06-46-124.png > > > In class BaseMessageConsumer.java , the nextWithAuthInfo2B parameter is set > globally, but its purpose is to record whether the contacted Broker will > perform authentication and authorization management during the next > interaction. This parameter should be managed separately according to the > Broker dimension: > !image-2020-05-26-20-06-46-124.png! -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (TUBEMQ-141) Remove the requirement to provide localHostIP
[ https://issues.apache.org/jira/browse/TUBEMQ-141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17117668#comment-17117668 ] Guocheng Zhang commented on TUBEMQ-141: --- (y) > Remove the requirement to provide localHostIP > - > > Key: TUBEMQ-141 > URL: https://issues.apache.org/jira/browse/TUBEMQ-141 > Project: Apache TubeMQ > Issue Type: Improvement >Reporter: Guocheng Zhang >Assignee: viviel >Priority: Major > Labels: pull-request-available > Fix For: 0.5.0 > > Attachments: image-2020-05-21-20-54-37-013.png > > > The initial requirement to provide localHostIP during initialization is > because we have multiple network cards and multiple IPs in our environment. > The initial implementation is to find the first IP from the specified > NetworkInterface and report it, but It is found that sometimes the specified > NetworkInterface is not configured with IP, so, we consider the user is > required to provide a local IP: > !image-2020-05-21-20-54-37-013.png! > After a period of use, the user feedback the API is cumbersome to use. The > best way is to provide a configurable NetworkInterface API, so if the IP is > not found, we can change the NetworkInterface. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (TUBEMQ-141) Remove the requirement to provide localHostIP
[ https://issues.apache.org/jira/browse/TUBEMQ-141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17117543#comment-17117543 ] viviel commented on TUBEMQ-141: --- After discussion, the final process for obtaining IP is roughly as follows: 1. Get all network interfaces 2. Filter out the docker0 interface, non-up interface 3. Traverse the address of a legal network interface 4. Exclude LoopbackAddress, 127.0 network segment address, and IPV6 address 5. Obtain the final legal IPV4 address 6. If you can't get it in the fifth step, call InetAddress.getLocalHost () to get it, otherwise throw the exception information to the user About the transformation of TubeClientConfig and ConsumerConfig: 1. The old construction method is marked as deprecated 2. Add a new construction method without localhost parameter > Remove the requirement to provide localHostIP > - > > Key: TUBEMQ-141 > URL: https://issues.apache.org/jira/browse/TUBEMQ-141 > Project: Apache TubeMQ > Issue Type: Improvement >Reporter: Guocheng Zhang >Assignee: viviel >Priority: Major > Labels: pull-request-available > Fix For: 0.5.0 > > Attachments: image-2020-05-21-20-54-37-013.png > > > The initial requirement to provide localHostIP during initialization is > because we have multiple network cards and multiple IPs in our environment. > The initial implementation is to find the first IP from the specified > NetworkInterface and report it, but It is found that sometimes the specified > NetworkInterface is not configured with IP, so, we consider the user is > required to provide a local IP: > !image-2020-05-21-20-54-37-013.png! > After a period of use, the user feedback the API is cumbersome to use. The > best way is to provide a configurable NetworkInterface API, so if the IP is > not found, we can change the NetworkInterface. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [incubator-tubemq] aloyszhang merged pull request #101: [TUBEMQ-158] nextWithAuthInfo2B status should be managed independently according to Broker
aloyszhang merged pull request #101: URL: https://github.com/apache/incubator-tubemq/pull/101 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-tubemq] gosonzhang opened a new pull request #101: [TUBEMQ-158] nextWithAuthInfo2B status should be managed independently according to Broker
gosonzhang opened a new pull request #101: URL: https://github.com/apache/incubator-tubemq/pull/101 1. According to Broker, record and check whether the next request carries user authentication information or authorization token information provided by Broker 2. According to Master requirements, add authentication information to the Master heartbeat request processing This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-tubemq] gosonzhang closed pull request #100: [TUBEMQ-158] nextWithAuthInfo2B status should be managed independently according to Broker
gosonzhang closed pull request #100: URL: https://github.com/apache/incubator-tubemq/pull/100 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (TUBEMQ-158) nextWithAuthInfo2B status should be managed independently according to Broker
[ https://issues.apache.org/jira/browse/TUBEMQ-158?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated TUBEMQ-158: -- Labels: pull-request-available (was: ) > nextWithAuthInfo2B status should be managed independently according to Broker > - > > Key: TUBEMQ-158 > URL: https://issues.apache.org/jira/browse/TUBEMQ-158 > Project: Apache TubeMQ > Issue Type: Bug >Reporter: Guocheng Zhang >Assignee: Guocheng Zhang >Priority: Normal > Labels: pull-request-available > Attachments: image-2020-05-26-20-06-46-124.png > > > In class BaseMessageConsumer.java , the nextWithAuthInfo2B parameter is set > globally, but its purpose is to record whether the contacted Broker will > perform authentication and authorization management during the next > interaction. This parameter should be managed separately according to the > Broker dimension: > !image-2020-05-26-20-06-46-124.png! -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [incubator-tubemq] gosonzhang opened a new pull request #100: [TUBEMQ-158] nextWithAuthInfo2B status should be managed independently according to Broker
gosonzhang opened a new pull request #100: URL: https://github.com/apache/incubator-tubemq/pull/100 1. Add authorization token expiration judgment in Master heartbeat request processing; 2. According to Broker, record and check whether the next request carries authentication information or authorization token. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
